)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f049a718f6e811c3e6013eaf01e1b1b2350a6576","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   entry that allows that network to be accessed by all tenants."},{"line_number":27,"context_line":" * An external network may have all of its RBAC entries deleted and then"},{"line_number":28,"context_line":"   only an admin will be able to attach to it."},{"line_number":29,"context_line":" * An RBAC entry cannot be deleted if it is required for a tenant that"},{"line_number":30,"context_line":"   currently has a router attached to that network."},{"line_number":31,"context_line":" * Creating an \u0027access_as_external\u0027 RBAC entry will automatically attempt"},{"line_number":32,"context_line":"   to convert the network into an external network. (This is to enable a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_af430212","line":29,"updated":"2016-02-23 23:26:57.000000000","message":"An RBAC \u0027access_as_external\u0027 entry?","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"00e48c9df7c494fd9fe792fdcb83c7d19ea0b375","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   entry that allows that network to be accessed by all tenants."},{"line_number":27,"context_line":" * An external network may have all of its RBAC entries deleted and then"},{"line_number":28,"context_line":"   only an admin will be able to attach to it."},{"line_number":29,"context_line":" * An RBAC entry cannot be deleted if it is required for a tenant that"},{"line_number":30,"context_line":"   currently has a router attached to that network."},{"line_number":31,"context_line":" * Creating an \u0027access_as_external\u0027 RBAC entry will automatically attempt"},{"line_number":32,"context_line":"   to convert the network into an external network. (This is to enable a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aed3d3a_4fd5b941","line":29,"updated":"2016-02-26 06:33:58.000000000","message":"yes","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f049a718f6e811c3e6013eaf01e1b1b2350a6576","unresolved":false,"context_lines":[{"line_number":29,"context_line":" * An RBAC entry cannot be deleted if it is required for a tenant that"},{"line_number":30,"context_line":"   currently has a router attached to that network."},{"line_number":31,"context_line":" * Creating an \u0027access_as_external\u0027 RBAC entry will automatically attempt"},{"line_number":32,"context_line":"   to convert the network into an external network. (This is to enable a"},{"line_number":33,"context_line":"   workflow where a private external network is never visible to everyone.)"},{"line_number":34,"context_line":" * The default policy.json will prevent a non-admin from creating"},{"line_number":35,"context_line":"   \u0027access_as_external\u0027 RBAC entries to align with the current default policy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_4f6cf69b","line":32,"range":{"start_line":32,"start_character":42,"end_line":32,"end_character":43},"updated":"2016-02-23 23:26:57.000000000","message":"If the attempt fails then the entry is removed?","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"00e48c9df7c494fd9fe792fdcb83c7d19ea0b375","unresolved":false,"context_lines":[{"line_number":29,"context_line":" * An RBAC entry cannot be deleted if it is required for a tenant that"},{"line_number":30,"context_line":"   currently has a router attached to that network."},{"line_number":31,"context_line":" * Creating an \u0027access_as_external\u0027 RBAC entry will automatically attempt"},{"line_number":32,"context_line":"   to convert the network into an external network. (This is to enable a"},{"line_number":33,"context_line":"   workflow where a private external network is never visible to everyone.)"},{"line_number":34,"context_line":" * The default policy.json will prevent a non-admin from creating"},{"line_number":35,"context_line":"   \u0027access_as_external\u0027 RBAC entries to align with the current default policy"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aed3d3a_afca859f","line":32,"updated":"2016-02-26 06:33:58.000000000","message":"yes","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f9b838855538b45fe1bb68a006b80f29591dd55b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     35e234db (Make __table_args__ declarative in RBACColumns)"},{"line_number":2,"context_line":"Author:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-02-19 03:34:27 -0800"},{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_51f14e00","line":1,"updated":"2016-02-29 19:41:10.000000000","message":"Being able to access an external network with a router vs directly attaching a VM are different things. Being able to attach a VM directly to an external network is not something operators would want to allow in many cases. These need to be two different things a tenant is allowed to do.","commit_id":"3226cfbc605edc401e34160dd45d282014fd6f6a"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"6ecba23d36d2e4ef7273a7172601f6342f72aa82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     35e234db (Make __table_args__ declarative in RBACColumns)"},{"line_number":2,"context_line":"Author:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-02-19 03:34:27 -0800"},{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_f4ed30f0","line":1,"updated":"2016-02-28 07:10:13.000000000","message":"Having a bit \u0027wacky\u0027 idea here: what if the two access_as_* permissions are melded into one e.g. access_allowed ?\nI mean they do have the same property - allowing access, but it seems that the difference is mainly in \u0027who\u0027s the lucky guy with the access\u0027.","commit_id":"3226cfbc605edc401e34160dd45d282014fd6f6a"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"0bf11a514318dd1e305cb031fad0de989cde0923","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     35e234db (Make __table_args__ declarative in RBACColumns)"},{"line_number":2,"context_line":"Author:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-02-19 03:34:27 -0800"},{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_2cb711f6","line":1,"in_reply_to":"9aed3d3a_51f14e00","updated":"2016-02-29 20:08:35.000000000","message":"Ok, I see the difference now.","commit_id":"3226cfbc605edc401e34160dd45d282014fd6f6a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"76ecaac8c403ebdb3974373ba8fb83210ab89600","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   entry that allows that network to be accessed by all tenants."},{"line_number":27,"context_line":" * An external network may have all of its RBAC entries deleted and then"},{"line_number":28,"context_line":"   only an admin will be able to attach to it."},{"line_number":29,"context_line":" * An RBAC \u0027access_as_external\u0027 entry cannot be deleted if it is required"},{"line_number":30,"context_line":"   for a tenant that currently has a router attached to that network."},{"line_number":31,"context_line":" * Creating an \u0027access_as_external\u0027 RBAC entry will automatically convert"},{"line_number":32,"context_line":"   the network into an external network. (This is to enable a workflow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_ce221d01","line":29,"updated":"2016-02-28 02:01:00.000000000","message":"It means that the tenant wouldn\u0027t be able to attach a router to the network without the policy present.","commit_id":"3226cfbc605edc401e34160dd45d282014fd6f6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a4376df318844832898de46e9794686f370019d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   entry that allows that network to be accessed by all tenants."},{"line_number":27,"context_line":" * An external network may have all of its RBAC entries deleted and then"},{"line_number":28,"context_line":"   only an admin will be able to attach to it."},{"line_number":29,"context_line":" * An RBAC \u0027access_as_external\u0027 entry cannot be deleted if it is required"},{"line_number":30,"context_line":"   for a tenant that currently has a router attached to that network."},{"line_number":31,"context_line":" * Creating an \u0027access_as_external\u0027 RBAC entry will automatically convert"},{"line_number":32,"context_line":"   the network into an external network. (This is to enable a workflow"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_35fe7f37","line":29,"range":{"start_line":29,"start_character":65,"end_line":29,"end_character":72},"updated":"2016-02-27 13:23:01.000000000","message":"Qeury: couldnt understand how we are tranlating \"required\" in OS?","commit_id":"3226cfbc605edc401e34160dd45d282014fd6f6a"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"6ecba23d36d2e4ef7273a7172601f6342f72aa82","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   everyone else\u0027s network lists."},{"line_number":38,"context_line":" * The default policy.json will allow a tenant to create an"},{"line_number":39,"context_line":"   \u0027access_as_external\u0027 RBAC entry to allow specific tenants"},{"line_number":40,"context_line":"   (including itself) the ability to use its netowrk as an external network."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Closes-Bug: #1547985"},{"line_number":43,"context_line":"DocImpact: External networks can now have access restricted to small subsets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_542dfc44","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":52},"updated":"2016-02-28 07:10:13.000000000","message":"s/netowrk/network","commit_id":"3226cfbc605edc401e34160dd45d282014fd6f6a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"45fe0d55d49c6ed5ce60032f0054d9cdc040018e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   everyone else\u0027s network lists."},{"line_number":38,"context_line":" * The default policy.json will allow a tenant to create an"},{"line_number":39,"context_line":"   \u0027access_as_external\u0027 RBAC entry to allow specific tenants"},{"line_number":40,"context_line":"   (including itself) the ability to use its netowrk as an external network."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Closes-Bug: #1547985"},{"line_number":43,"context_line":"DocImpact: External networks can now have access restricted to small subsets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9aed3d3a_ccf02594","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":52},"in_reply_to":"9aed3d3a_542dfc44","updated":"2016-02-29 20:12:46.000000000","message":"Done","commit_id":"3226cfbc605edc401e34160dd45d282014fd6f6a"}],"neutron/db/external_net_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"00e48c9df7c494fd9fe792fdcb83c7d19ea0b375","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            if context.session.query(rbac_db.NetworkRBAC).filter("},{"line_number":237,"context_line":"                    rbac.object_id \u003d\u003d policy[\u0027object_id\u0027],"},{"line_number":238,"context_line":"                    rbac.action \u003d\u003d \u0027access_as_external\u0027,"},{"line_number":239,"context_line":"                    rbac.target_tenant \u003d\u003d \u0027*\u0027).first():"},{"line_number":240,"context_line":"                return"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            # deleting the wildcard is okay as long as the tenants with"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_efc48d93","line":239,"updated":"2016-02-26 06:33:58.000000000","message":"Done","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f049a718f6e811c3e6013eaf01e1b1b2350a6576","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            if context.session.query(rbac_db.NetworkRBAC).filter("},{"line_number":237,"context_line":"                    rbac.object_id \u003d\u003d policy[\u0027object_id\u0027],"},{"line_number":238,"context_line":"                    rbac.action \u003d\u003d \u0027access_as_external\u0027,"},{"line_number":239,"context_line":"                    rbac.target_tenant \u003d\u003d \u0027*\u0027).first():"},{"line_number":240,"context_line":"                return"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            # deleting the wildcard is okay as long as the tenants with"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_fd05c345","line":239,"range":{"start_line":239,"start_character":47,"end_line":239,"end_character":52},"updated":"2016-02-23 23:26:57.000000000","message":"using .count() instead of .first() avoid to unmarshall the db object","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"00e48c9df7c494fd9fe792fdcb83c7d19ea0b375","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                       rbac.target_tenant !\u003d \u0027*\u0027))"},{"line_number":249,"context_line":"            router \u003d router.filter("},{"line_number":250,"context_line":"                ~l3_db.Router.tenant_id.in_(tenants_with_entries))"},{"line_number":251,"context_line":"        if router.first():"},{"line_number":252,"context_line":"            # TODO(kevinbenton): better exception because this one mentions"},{"line_number":253,"context_line":"            # making the network non-external"},{"line_number":254,"context_line":"            raise external_net.ExternalNetworkInUse(net_id\u003dpolicy[\u0027object_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_cfc1c982","line":251,"updated":"2016-02-26 06:33:58.000000000","message":"done","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f049a718f6e811c3e6013eaf01e1b1b2350a6576","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                       rbac.target_tenant !\u003d \u0027*\u0027))"},{"line_number":249,"context_line":"            router \u003d router.filter("},{"line_number":250,"context_line":"                ~l3_db.Router.tenant_id.in_(tenants_with_entries))"},{"line_number":251,"context_line":"        if router.first():"},{"line_number":252,"context_line":"            # TODO(kevinbenton): better exception because this one mentions"},{"line_number":253,"context_line":"            # making the network non-external"},{"line_number":254,"context_line":"            raise external_net.ExternalNetworkInUse(net_id\u003dpolicy[\u0027object_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_bd9e9b04","line":251,"range":{"start_line":251,"start_character":18,"end_line":251,"end_character":23},"updated":"2016-02-23 23:26:57.000000000","message":"itto","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"}],"neutron/db/migration/alembic_migrations/versions/mitaka/contract/5ffceebfada_rbac_network_external.py":[{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"0ed81e3a4b434ee170b74338963eb4873ef7deba","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"network \u003d sa.Table(\u0027networks\u0027, sa.MetaData(),"},{"line_number":42,"context_line":"                   sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":43,"context_line":"                   sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255)))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"networkrbacs \u003d sa.Table("},{"line_number":46,"context_line":"    \u0027networkrbacs\u0027, sa.MetaData(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_3d2248ba","line":43,"updated":"2016-02-19 11:59:17.000000000","message":"I think it would be nice if the new tables would use attributes.TENANT_ID_MAX_LEN","commit_id":"1ea80b85818bb6436d1f14e1752c478e5bdca348"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f3bc166a364c693f7f59033007806d7f4e20be18","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"network \u003d sa.Table(\u0027networks\u0027, sa.MetaData(),"},{"line_number":42,"context_line":"                   sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":43,"context_line":"                   sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255)))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"networkrbacs \u003d sa.Table("},{"line_number":46,"context_line":"    \u0027networkrbacs\u0027, sa.MetaData(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_58e8f37c","line":43,"in_reply_to":"bae84128_3d2248ba","updated":"2016-02-19 14:02:39.000000000","message":"Done","commit_id":"1ea80b85818bb6436d1f14e1752c478e5bdca348"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"0ed81e3a4b434ee170b74338963eb4873ef7deba","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \u0027networkrbacs\u0027, sa.MetaData(),"},{"line_number":47,"context_line":"    sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":48,"context_line":"    sa.Column(\u0027object_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":49,"context_line":"    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue,"},{"line_number":50,"context_line":"              index\u003dTrue),"},{"line_number":51,"context_line":"    sa.Column(\u0027target_tenant\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":52,"context_line":"    sa.Column(\u0027action\u0027, sa.String(length\u003d255), nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_3d09a832","line":49,"updated":"2016-02-19 11:59:17.000000000","message":"ditto","commit_id":"1ea80b85818bb6436d1f14e1752c478e5bdca348"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"0ed81e3a4b434ee170b74338963eb4873ef7deba","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    sa.Column(\u0027object_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":49,"context_line":"    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue,"},{"line_number":50,"context_line":"              index\u003dTrue),"},{"line_number":51,"context_line":"    sa.Column(\u0027target_tenant\u0027, sa.String(length\u003d255), nullable\u003dFalse),"},{"line_number":52,"context_line":"    sa.Column(\u0027action\u0027, sa.String(length\u003d255), nullable\u003dFalse))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c003730c","line":51,"updated":"2016-02-19 11:59:17.000000000","message":"ditto","commit_id":"1ea80b85818bb6436d1f14e1752c478e5bdca348"}],"neutron/db/rbac_db_models.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f049a718f6e811c3e6013eaf01e1b1b2350a6576","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          nullable\u003dFalse)"},{"line_number":85,"context_line":"    object_type \u003d \u0027network\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def get_valid_actions(self):"},{"line_number":88,"context_line":"        actions \u003d (\u0027access_as_shared\u0027, )"},{"line_number":89,"context_line":"        pl \u003d manager.NeutronManager.get_plugin()"},{"line_number":90,"context_line":"        if \u0027external-net\u0027 in pl.supported_extension_aliases:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_8f9efeb6","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":25},"updated":"2016-02-23 23:26:57.000000000","message":"It seems we can cache the method which is called for every query","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"00e48c9df7c494fd9fe792fdcb83c7d19ea0b375","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          nullable\u003dFalse)"},{"line_number":85,"context_line":"    object_type \u003d \u0027network\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def get_valid_actions(self):"},{"line_number":88,"context_line":"        actions \u003d (\u0027access_as_shared\u0027, )"},{"line_number":89,"context_line":"        pl \u003d manager.NeutronManager.get_plugin()"},{"line_number":90,"context_line":"        if \u0027external-net\u0027 in pl.supported_extension_aliases:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_8fcfc1af","line":87,"updated":"2016-02-26 06:33:58.000000000","message":"Yeah, and even then it\u0027s basically a dictionary lookup for the plugin handle and a list check.","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d8e682fa7ef227bb77d8f28947b7b09a52af924a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                          nullable\u003dFalse)"},{"line_number":85,"context_line":"    object_type \u003d \u0027network\u0027"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def get_valid_actions(self):"},{"line_number":88,"context_line":"        actions \u003d (\u0027access_as_shared\u0027, )"},{"line_number":89,"context_line":"        pl \u003d manager.NeutronManager.get_plugin()"},{"line_number":90,"context_line":"        if \u0027external-net\u0027 in pl.supported_extension_aliases:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_8fbd5eda","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":25},"in_reply_to":"bae84128_8f9efeb6","updated":"2016-02-23 23:29:16.000000000","message":"Oups, it\u0027s called only when network rbacs are updated so it\u0027s perhaps overkill to cache the result","commit_id":"71e277cf1df14ea44d80baa02cd75f521973f027"}]}
