)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2013-05-05 02:22:17 -0700"},{"line_number":4,"context_line":"Commit:     Avishay Balderman \u003cavishayb@radware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-06 06:24:36 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BluePrint: multi-vendor-support-for-lbaas-step0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic5b2c46c5a74338c3fa14cc991f4420cabd7798e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAOn%2F%2FiXM%3D","line":6,"updated":"2013-05-06 14:04:43.000000000","message":"Could you update this. For example:\n\nmulti-vendor-support-for-lbaas\n\nBluePrint: multi-vendor-support-for-lbaas-step0\n\nThis is the first stage of ...","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2013-05-05 02:22:17 -0700"},{"line_number":4,"context_line":"Commit:     Avishay Balderman \u003cavishayb@radware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-06 06:24:36 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"BluePrint: multi-vendor-support-for-lbaas-step0"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic5b2c46c5a74338c3fa14cc991f4420cabd7798e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAOn%2F%2FiV4%3D","line":6,"in_reply_to":"AAAAOn%2F%2FiXM%3D","updated":"2013-05-07 07:55:33.000000000","message":"I will update it.","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"}],"etc/quantum.conf":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#lbaas_driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAOn%2F%2FdTE%3D","line":317,"updated":"2013-05-08 23:35:46.000000000","message":"Is this the right place to put this conf? Shouldn\u0027t there be a separate lbaas conf file?","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#lbaas_driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAOn%2F%2FczQ%3D","line":317,"in_reply_to":"AAAAOn%2F%2Fc1c%3D","updated":"2013-05-09 07:31:05.000000000","message":"The  lbaas_agent.ini is a config file for the lbaas agent. As we are not dealing with the agent in this patch I did not think the config should go into this file.","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#lbaas_driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAOn%2F%2Fc1c%3D","line":317,"in_reply_to":"AAAAOn%2F%2Fc2k%3D","updated":"2013-05-09 06:45:09.000000000","message":"I would like to hear what others think about this. We follow the practice of using independent configuration files at the level of plugins and agents.  This also helps in creating independent packages. There is already a lbaas_agent.ini which has the configuration for a \"device_driver\". Why should this not go in there?","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#lbaas_driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAOn%2F%2Fcxg%3D","line":317,"in_reply_to":"AAAAOn%2F%2FczQ%3D","updated":"2013-05-09 07:56:50.000000000","message":"I agree with your reasoning that this is not agent configuration at this stage, hence it should not go there. I would still prefer to see this eventually in a LB-specific configuration file.","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#lbaas_driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":6,"id":"AAAAOn%2F%2Fc2k%3D","line":317,"in_reply_to":"AAAAOn%2F%2FdTE%3D","updated":"2013-05-09 06:30:40.000000000","message":"Sumit, I doubt there should be a separate conf file fore each service otherwise we end up running quantum with a bunch of conf files","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#lbaas_driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":7,"id":"AAAAOn%2F%2Fcng%3D","line":317,"updated":"2013-05-09 11:06:38.000000000","message":"Why not call it the driver_fqn - I do not think that you need the lbaas prefix as it is already has this section","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#lbaas_driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":7,"id":"AAAAOn%2F%2FcmY%3D","line":317,"in_reply_to":"AAAAOn%2F%2Fcng%3D","updated":"2013-05-09 12:13:58.000000000","message":"OK","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":9,"id":"AAAAOn%2F%2FV78%3D","line":317,"updated":"2013-05-14 05:23:31.000000000","message":"nit: space around \u003d like everything else.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"signing_dir \u003d /var/lib/quantum/keystone-signing"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"[LBAAS]"},{"line_number":317,"context_line":"#driver_fqn\u003dquantum.plugins.services.agent_loadbalancer.drivers.noop.noop_driver.NoopLbaaSDriver"}],"source_content_type":"text/plain","patch_set":9,"id":"AAAAO3%2F%2F9G0%3D","line":317,"in_reply_to":"AAAAOn%2F%2FV78%3D","updated":"2013-05-16 10:37:21.000000000","message":"OK","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"}],"quantum/db/loadbalancer/loadbalancer_db.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHg%3D","line":512,"updated":"2013-05-05 10:18:22.000000000","message":"This change should be made in the scope of separate bug.","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjDo%3D","line":512,"in_reply_to":"AAAAOn%2F%2FjHg%3D","updated":"2013-05-05 15:12:32.000000000","message":"This change was included since we want to enable the stats update by the plugin/driver. I found that it is not possible and since I defined the plugin \u003c--\u003e driver interfaced I decided to add this ability here.","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fioc%3D","line":512,"updated":"2013-05-06 11:22:12.000000000","message":"How is it related to the blueprint that you are addressing with this patch? \n\nAlso it seems this function is unused in the current class.","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fieo%3D","line":512,"in_reply_to":"AAAAOn%2F%2Fioc%3D","updated":"2013-05-07 07:55:18.000000000","message":"1) It is used by the plugin\n2) The BP deals with API definition for the lbaas driver. This method supports the ability to add new stats record. Until now we did not have this option - thus the API was not complete.","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":516,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":517,"context_line":"            context.session.add(pool_db)"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def _create_pool_stats(self, context, pool_id, data\u003dNone):"},{"line_number":520,"context_line":"        # This is internal method to add pool statistics. It won\u0027t"},{"line_number":521,"context_line":"        # be exposed to API"},{"line_number":522,"context_line":"        if data:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FioE%3D","line":519,"updated":"2013-05-06 11:22:12.000000000","message":"consider {} as a default value","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":522,"context_line":"        if data:"},{"line_number":523,"context_line":"            stats_db \u003d PoolStatistics("},{"line_number":524,"context_line":"                pool_id\u003dpool_id,"},{"line_number":525,"context_line":"                bytes_in\u003ddata[\"bytes_in\"],"},{"line_number":526,"context_line":"                bytes_out\u003ddata[\"bytes_out\"],"},{"line_number":527,"context_line":"                active_connections\u003ddata[\"active_connections\"],"},{"line_number":528,"context_line":"                total_connections\u003ddata[\"total_connections\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fin4%3D","line":525,"updated":"2013-05-06 11:22:12.000000000","message":"then you can have: \"bytes_in\u003ddata.get(\"bytes_in\", 0) ...\" thus making it safer and removing else block.","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        if data:"},{"line_number":523,"context_line":"            stats_db \u003d PoolStatistics("},{"line_number":524,"context_line":"                pool_id\u003dpool_id,"},{"line_number":525,"context_line":"                bytes_in\u003ddata[\"bytes_in\"],"},{"line_number":526,"context_line":"                bytes_out\u003ddata[\"bytes_out\"],"},{"line_number":527,"context_line":"                active_connections\u003ddata[\"active_connections\"],"},{"line_number":528,"context_line":"                total_connections\u003ddata[\"total_connections\"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fiec%3D","line":525,"in_reply_to":"AAAAOn%2F%2Fin4%3D","updated":"2013-05-07 07:55:18.000000000","message":"makes sense - I will do that.","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fg3U%3D","line":512,"updated":"2013-05-07 13:29:47.000000000","message":"as was said previously, this should be a separate change.\nPlease file a bug and fix it as it may go to stable/grizzly branch.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Few8%3D","line":512,"in_reply_to":"AAAAOn%2F%2Fg3U%3D","updated":"2013-05-08 12:11:06.000000000","message":"I think this change is small enough to be included here. Lets see the opinion of other reviewers.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fc%2F4%3D","line":512,"updated":"2013-05-09 04:13:25.000000000","message":"If this is a backport potential candidate, I agree that this might make more sense to be a separate bug.","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fcys%3D","line":512,"in_reply_to":"AAAAOn%2F%2Fc%2F4%3D","updated":"2013-05-09 07:36:26.000000000","message":"Do not think it is a backport candidate.","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"},{"line_number":516,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2FdAY%3D","line":513,"updated":"2013-05-09 04:13:25.000000000","message":"pep-257 docstring? only relevant if you plan to keep this change in this patch.","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        # update a pool with new stats structure"},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"},{"line_number":516,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fcyo%3D","line":513,"in_reply_to":"AAAAOn%2F%2FdAY%3D","updated":"2013-05-09 07:36:26.000000000","message":"OK","commit_id":"03cf3273c90449d0076e8f49e4aff579c4ff4e8d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        \"\"\"update a pool with new stats structure.\"\"\""},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        self.assert_modification_allowed(pool_db)"},{"line_number":516,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2Fcnc%3D","line":513,"updated":"2013-05-09 11:06:38.000000000","message":"update \u003d\u003e Update","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":510,"context_line":"        return self._fields(res, fields)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        \"\"\"update a pool with new stats structure.\"\"\""},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        self.assert_modification_allowed(pool_db)"},{"line_number":516,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcmU%3D","line":513,"in_reply_to":"AAAAOn%2F%2Fcnc%3D","updated":"2013-05-09 12:13:58.000000000","message":"OK","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":517,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":518,"context_line":"            context.session.add(pool_db)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def _create_pool_stats(self, context, pool_id, data\u003d{}):"},{"line_number":521,"context_line":"        # This is internal method to add pool statistics. It won\u0027t"},{"line_number":522,"context_line":"        # be exposed to API"},{"line_number":523,"context_line":"        stats_db \u003d PoolStatistics("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV7w%3D","line":520,"updated":"2013-05-14 05:23:31.000000000","message":"you should not make a param have a default of \u003d{} as this has side effects: for example: \nIn [4]: def foo(data\u003d{}):\n    print data\n    data[\u0027foo\u0027] \u003d \u0027bar\u0027\n   ...:     \n\nIn [5]: \n\nIn [5]: foo()\n{}\n\nIn [6]: foo()\n{\u0027foo\u0027: \u0027bar\u0027}","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":517,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":518,"context_line":"            context.session.add(pool_db)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def _create_pool_stats(self, context, pool_id, data\u003d{}):"},{"line_number":521,"context_line":"        # This is internal method to add pool statistics. It won\u0027t"},{"line_number":522,"context_line":"        # be exposed to API"},{"line_number":523,"context_line":"        stats_db \u003d PoolStatistics("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F9Fc%3D","line":520,"in_reply_to":"AAAAOn%2F%2FV7w%3D","updated":"2013-05-16 10:37:21.000000000","message":"OK","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        \"\"\"Update a pool with new stats structure.\"\"\""},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        self.assert_modification_allowed(pool_db)"},{"line_number":516,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"},{"line_number":517,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F65E%3D","line":514,"updated":"2013-05-20 10:05:28.000000000","message":"This piece should be rewritten this way:\nwith context.session.begin(subtransactions\u003dTrue):\n     pool_db \u003d self._get_resource(context, Pool, pool_id)\n     self.assert_modification_allowed(pool_db)\n     pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)\n\nExplanation:\nyou need to query and update db object within one transaction.\nYou don\u0027t need to explicitly call add, because \u0027pool_db.stats \u003d\u0027 will automatically update object in DB when \u0027with\u0027 block is exited","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"    def _update_pool_stats(self, context, pool_id, data):"},{"line_number":513,"context_line":"        \"\"\"Update a pool with new stats structure.\"\"\""},{"line_number":514,"context_line":"        pool_db \u003d self._get_resource(context, Pool, pool_id)"},{"line_number":515,"context_line":"        self.assert_modification_allowed(pool_db)"},{"line_number":516,"context_line":"        pool_db.stats \u003d self._create_pool_stats(context, pool_id, data)"},{"line_number":517,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F6xg%3D","line":514,"in_reply_to":"AAAAPH%2F%2F65E%3D","updated":"2013-05-20 15:56:51.000000000","message":"OK","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"}],"quantum/plugins/services/agent_loadbalancer/drivers/__init__.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fgjw%3D","line":3,"updated":"2013-05-07 13:23:14.000000000","message":"Why do you need to change the license. It is not really related to the patch","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fg3Q%3D","line":3,"updated":"2013-05-07 13:29:47.000000000","message":"why changing copyrights?","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FfCk%3D","line":3,"in_reply_to":"AAAAOn%2F%2Fg3Q%3D","updated":"2013-05-08 12:11:06.000000000","message":"It is my BUG - I will fix it.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"}],"quantum/plugins/services/agent_loadbalancer/drivers/abstract_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstarctDriver(object):"},{"line_number":23,"context_line":"    \"\"\"Abstarct lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiXU%3D","line":22,"updated":"2013-05-06 14:04:43.000000000","message":"Typo","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstarctDriver(object):"},{"line_number":23,"context_line":"    \"\"\"Abstarct lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiWA%3D","line":22,"in_reply_to":"AAAAOn%2F%2FiXU%3D","updated":"2013-05-07 07:55:33.000000000","message":"will be fixed","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstarctDriver(object):"},{"line_number":23,"context_line":"    \"\"\"Abstarct lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."},{"line_number":26,"context_line":"       Get operations are not part of the API - it will be handeled"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiXQ%3D","line":23,"updated":"2013-05-06 14:04:43.000000000","message":"Typo","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":23,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."},{"line_number":26,"context_line":"       Get operations are not part of the API - it will be handeled"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fgjk%3D","line":23,"updated":"2013-05-07 13:23:14.000000000","message":"Missing new line (I think)","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":23,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."},{"line_number":26,"context_line":"       Get operations are not part of the API - it will be handeled"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe%2Fw%3D","line":23,"in_reply_to":"AAAAOn%2F%2Fgjk%3D","updated":"2013-05-08 12:11:06.000000000","message":"OK","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."},{"line_number":26,"context_line":"       Get operations are not part of the API - it will be handeled"},{"line_number":27,"context_line":"       by the lbaas plugin."},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    __metaclass__ \u003d abc.ABCMeta"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fgjg%3D","line":26,"updated":"2013-05-07 13:23:14.000000000","message":"handeled \u003d\u003e handled","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."},{"line_number":26,"context_line":"       Get operations are not part of the API - it will be handeled"},{"line_number":27,"context_line":"       by the lbaas plugin."},{"line_number":28,"context_line":"    \"\"\""},{"line_number":29,"context_line":"    __metaclass__ \u003d abc.ABCMeta"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe%2F0%3D","line":26,"in_reply_to":"AAAAOn%2F%2Fgjg%3D","updated":"2013-05-08 12:11:06.000000000","message":"OK","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":23,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":26,"context_line":"       are returned to the tenant."},{"line_number":27,"context_line":"       Get operations are not part of the API - it will be handled"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcnY%3D","line":24,"updated":"2013-05-09 11:06:38.000000000","message":"I think lines 25-28 should be moved back 4 spaces","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":23,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":26,"context_line":"       are returned to the tenant."},{"line_number":27,"context_line":"       Get operations are not part of the API - it will be handled"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcmQ%3D","line":24,"in_reply_to":"AAAAOn%2F%2FcnY%3D","updated":"2013-05-09 12:13:58.000000000","message":"OK","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Radware LTD."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2Fca8%3D","line":1,"updated":"2013-05-09 14:42:11.000000000","message":"Why not call this module base?","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Radware LTD."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FYho%3D","line":1,"in_reply_to":"AAAAOn%2F%2Fca8%3D","updated":"2013-05-12 13:30:38.000000000","message":"My java background again... This class is basically an interface - a contract. When I use the name \"base\" - it feels to me that there is some \"meat\" in the base class and I use the abilities of the super class it when I inherit from it.\nAgain: if it is not the \"python way\" - I am ok to change it.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @abc.abstractmethod"},{"line_number":77,"context_line":"    def update_health_monitor(self, context,"},{"line_number":78,"context_line":"                              pool_associations,"},{"line_number":79,"context_line":"                              health_monitor):"},{"line_number":80,"context_line":"        pass"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F63I%3D","line":78,"updated":"2013-05-20 10:05:28.000000000","message":"That needs to be changed to \u0027pool_association\u0027 or just pool_id.\nRationale:\n  there is a set of associations (pool, healthmonitor) each of which could belong to a different driver, that\u0027s why it\u0027s more convenient to call a driver with one association.\nIn fact, association is just a (pool_id, healthmon_id), so since you\u0027re already passing healthmon, pool_id is sufficient.\n\nAlso, I would suggest that you change the order of parameters like in methods create_pool_health_monitor and delete_pool_health_monitor, e.g. health_monitor, pool_id","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @abc.abstractmethod"},{"line_number":77,"context_line":"    def update_health_monitor(self, context,"},{"line_number":78,"context_line":"                              pool_associations,"},{"line_number":79,"context_line":"                              health_monitor):"},{"line_number":80,"context_line":"        pass"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F6wo%3D","line":78,"in_reply_to":"AAAAPH%2F%2F63I%3D","updated":"2013-05-20 15:56:51.000000000","message":"The reason I call the driver with pool_association[s] and with pool_association is that that the driver may succeeded in updating some of the health_monitor and might fail for the others. So we need to decide if the operation is OK or failed. The driver looks to me like the natural candidate for doing this.\nAbout the parameter order - I agree.","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @abc.abstractmethod"},{"line_number":83,"context_line":"    def delete_health_monitor(self, context,"},{"line_number":84,"context_line":"                              pool_associations,"},{"line_number":85,"context_line":"                              health_monitor):"},{"line_number":86,"context_line":"        pass"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F63E%3D","line":84,"updated":"2013-05-20 10:05:28.000000000","message":"ditto","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @abc.abstractmethod"},{"line_number":83,"context_line":"    def delete_health_monitor(self, context,"},{"line_number":84,"context_line":"                              pool_associations,"},{"line_number":85,"context_line":"                              health_monitor):"},{"line_number":86,"context_line":"        pass"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F6wg%3D","line":84,"in_reply_to":"AAAAPH%2F%2F63E%3D","updated":"2013-05-20 15:56:51.000000000","message":"see my other comment.","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":74,"context_line":"        pass"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @abc.abstractmethod"},{"line_number":77,"context_line":"    def update_health_monitor(self, context,"},{"line_number":78,"context_line":"                              health_monitor,"},{"line_number":79,"context_line":"                              pool_associations):"},{"line_number":80,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2Fcpc%3D","line":77,"updated":"2013-06-03 18:17:48.000000000","message":"could you please change the interface of this method to handle single association?\nWe have discussed this.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        pass"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @abc.abstractmethod"},{"line_number":77,"context_line":"    def update_health_monitor(self, context,"},{"line_number":78,"context_line":"                              health_monitor,"},{"line_number":79,"context_line":"                              pool_associations):"},{"line_number":80,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2FwA%3D","line":77,"in_reply_to":"AAAAPH%2F%2Fcpc%3D","updated":"2013-06-04 12:49:36.000000000","message":"OK","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":80,"context_line":"        pass"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @abc.abstractmethod"},{"line_number":83,"context_line":"    def delete_health_monitor(self, context,"},{"line_number":84,"context_line":"                              health_monitor,"},{"line_number":85,"context_line":"                              pool_associations):"},{"line_number":86,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2FcpY%3D","line":83,"updated":"2013-06-03 18:17:48.000000000","message":"ditto","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        pass"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @abc.abstractmethod"},{"line_number":83,"context_line":"    def delete_health_monitor(self, context,"},{"line_number":84,"context_line":"                              health_monitor,"},{"line_number":85,"context_line":"                              pool_associations):"},{"line_number":86,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2Fv4%3D","line":83,"in_reply_to":"AAAAPH%2F%2FcpY%3D","updated":"2013-06-04 12:49:36.000000000","message":"OK","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":121,"context_line":"        pass"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context,"},{"line_number":125,"context_line":"                              health_monitor,"},{"line_number":126,"context_line":"                              pool_association):"},{"line_number":127,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAPX%2F%2F%2FQ8%3D","line":124,"updated":"2013-06-04 13:47:38.000000000","message":"I think this could be removed as delete_pool_health_monitor does exactly the same.\nSee comment to lbaas_plugin","commit_id":"24e518d3c16d3d930d6502c22c87bd4da80e150f"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        pass"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    @abc.abstractmethod"},{"line_number":124,"context_line":"    def delete_health_monitor(self, context,"},{"line_number":125,"context_line":"                              health_monitor,"},{"line_number":126,"context_line":"                              pool_association):"},{"line_number":127,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAPX%2F%2F9Rk%3D","line":124,"in_reply_to":"AAAAPX%2F%2F%2FQ8%3D","updated":"2013-06-05 13:09:48.000000000","message":"OK","commit_id":"24e518d3c16d3d930d6502c22c87bd4da80e150f"}],"quantum/plugins/services/agent_loadbalancer/drivers/lbaas_abstract_driver.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Radware LTD."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHc%3D","line":1,"updated":"2013-05-05 10:18:22.000000000","message":"I think just \"abstract_driver.py\" will be a better name. We\u0027re in lbaas subtree anyway","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstarctDriver():"},{"line_number":23,"context_line":"    \"\"\"Abstarct lbaas driver that expose the same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHY%3D","line":22,"updated":"2013-05-05 10:18:22.000000000","message":"class LoadBalancerAbstarctDriver(object):","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstarctDriver():"},{"line_number":23,"context_line":"    \"\"\"Abstarct lbaas driver that expose the same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjDk%3D","line":22,"in_reply_to":"AAAAOn%2F%2FjHY%3D","updated":"2013-05-05 15:12:32.000000000","message":"will be fixed in the next patch","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    __metaclass__ \u003d abc.ABCMeta"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @abc.abstractmethod"},{"line_number":32,"context_line":"    def create_vip(self, context, vip_db_dict):"},{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHM%3D","line":32,"updated":"2013-05-05 10:18:22.000000000","message":"parameter naming: i think a common way to name model dicts is just the name of a model: pool, vip, etc.\nSo here it would be just \u0027vip\u0027","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    __metaclass__ \u003d abc.ABCMeta"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @abc.abstractmethod"},{"line_number":32,"context_line":"    def create_vip(self, context, vip_db_dict):"},{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjDg%3D","line":32,"in_reply_to":"AAAAOn%2F%2FjHM%3D","updated":"2013-05-05 15:12:32.000000000","message":"I have added the _dict because I wanted to \"declare\" that the argument is not the model entity (not the SQLAlchemy class)","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @abc.abstractmethod"},{"line_number":36,"context_line":"    def update_vip(self, context, id, vip_db_dict):"},{"line_number":37,"context_line":"        pass"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHQ%3D","line":36,"updated":"2013-05-05 10:18:22.000000000","message":"don\u0027t need id since we have vip","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        pass"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @abc.abstractmethod"},{"line_number":40,"context_line":"    def delete_vip(self, context, id):"},{"line_number":41,"context_line":"        pass"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHU%3D","line":40,"updated":"2013-05-05 10:18:22.000000000","message":"vip instead of just id.\nDrivers may need to access vip dict on vip deletion.\nEx: current solution will update the pool by id, which is stored in vip[\u0027pool_id\u0027]","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        pass"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @abc.abstractmethod"},{"line_number":48,"context_line":"    def update_pool(self, context, id, pool_db_dict):"},{"line_number":49,"context_line":"        pass"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHI%3D","line":48,"updated":"2013-05-05 10:18:22.000000000","message":"don\u0027t need id, coz we have pool","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"7b1784f21a0c20ee594dc8af7e6bb3c9ff2ebdf3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        pass"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @abc.abstractmethod"},{"line_number":52,"context_line":"    def delete_pool(self, context, id):"},{"line_number":53,"context_line":"        pass"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FjHA%3D","line":52,"updated":"2013-05-05 10:18:22.000000000","message":"pool, instead of just id.\nThe same for the rest of methods","commit_id":"a4b8347c7082db7edc604cd3ede4ab2a328ef895"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstarctDriver():"},{"line_number":23,"context_line":"    \"\"\"Abstarct lbaas driver that expose the same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FikU%3D","line":22,"updated":"2013-05-06 11:22:12.000000000","message":"please address Eugene\u0027s comment","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import abc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class LoadBalancerAbstarctDriver():"},{"line_number":23,"context_line":"    \"\"\"Abstarct lbaas driver that expose the same API as lbaas plugin."},{"line_number":24,"context_line":"       The configuration elements (Vip,Member,etc) are the dicts that"},{"line_number":25,"context_line":"       are returned to the tenant."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fias%3D","line":22,"in_reply_to":"AAAAOn%2F%2FikU%3D","updated":"2013-05-07 07:55:18.000000000","message":"OK","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"    __metaclass__ \u003d abc.ABCMeta"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @abc.abstractmethod"},{"line_number":32,"context_line":"    def create_vip(self, context, vip_db_dict):"},{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fig0%3D","line":32,"updated":"2013-05-06 11:22:12.000000000","message":"Agree with Eugene here that vip_db_dict looks a bit tricky. Please consider using docstrings to clarify parameters type","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    __metaclass__ \u003d abc.ABCMeta"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @abc.abstractmethod"},{"line_number":32,"context_line":"    def create_vip(self, context, vip_db_dict):"},{"line_number":33,"context_line":"        pass"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fiaw%3D","line":32,"in_reply_to":"AAAAOn%2F%2Fig0%3D","updated":"2013-05-07 07:55:18.000000000","message":"OK","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"}],"quantum/plugins/services/agent_loadbalancer/drivers/noop/lbaas_noop_driver.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"    lbaas_abstract_driver import LoadBalancerAbstarctDriver"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#from quantum.db.loadbalancer.loadbalancer_db import ("},{"line_number":26,"context_line":"#    HealthMonitor"},{"line_number":27,"context_line":"#    Member"},{"line_number":28,"context_line":"#    Pool"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FinQ%3D","line":25,"updated":"2013-05-06 11:22:12.000000000","message":"please remove if unused","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"#)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#from quantum.plugins.common import constants"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FinM%3D","line":33,"updated":"2013-05-06 11:22:12.000000000","message":"ditto","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":44,"context_line":"    return wrapper"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NoopLbaaSDriver(LoadBalancerAbstarctDriver):"},{"line_number":48,"context_line":"    \"\"\"A dummy lbass driver that:"},{"line_number":49,"context_line":"       1) Logs methods input"},{"line_number":50,"context_line":"       2) Uses the plugin API in order to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FimA%3D","line":47,"updated":"2013-05-06 11:22:12.000000000","message":"Could you please clarify what is the purpose of this class? As almost all methods pass wouldn\u0027t it be more reasonable just to put docstrings into lbaas_abstract driver?","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    return wrapper"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NoopLbaaSDriver(LoadBalancerAbstarctDriver):"},{"line_number":48,"context_line":"    \"\"\"A dummy lbass driver that:"},{"line_number":49,"context_line":"       1) Logs methods input"},{"line_number":50,"context_line":"       2) Uses the plugin API in order to update"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FieE%3D","line":47,"in_reply_to":"AAAAOn%2F%2FimA%3D","updated":"2013-05-07 07:55:18.000000000","message":"It has the logging functionality plus it can be used as a good starting point for a vendor","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class NoopLbaaSDriver(LoadBalancerAbstarctDriver):"},{"line_number":48,"context_line":"    \"\"\"A dummy lbass driver that:"},{"line_number":49,"context_line":"       1) Logs methods input"},{"line_number":50,"context_line":"       2) Uses the plugin API in order to update"},{"line_number":51,"context_line":"          the config elements status in DB"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FimQ%3D","line":48,"updated":"2013-05-06 11:22:12.000000000","message":"Please format docstring according to pep257: http://www.python.org/dev/peps/pep-0257","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @log"},{"line_number":58,"context_line":"    def create_vip(self, context, vip_db_dict):"},{"line_number":59,"context_line":"        # A \"real driver\" would invoke a call to his backend"},{"line_number":60,"context_line":"        # and set the Vip status to ACTIVE/ERROR according"},{"line_number":61,"context_line":"        # to the backend call result"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FimM%3D","line":59,"updated":"2013-05-06 11:22:12.000000000","message":"pep257 here and in other methods","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # and set the Vip status to ACTIVE/ERROR according"},{"line_number":61,"context_line":"        # to the backend call result"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # self.plugin.update_status(context, Vip, vip_db_dict[\"id\"],"},{"line_number":64,"context_line":"        #                          constants.ACTIVE)"},{"line_number":65,"context_line":"        pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FimY%3D","line":63,"updated":"2013-05-06 11:22:12.000000000","message":"why is it commented?","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # and set the Vip status to ACTIVE/ERROR according"},{"line_number":61,"context_line":"        # to the backend call result"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        # self.plugin.update_status(context, Vip, vip_db_dict[\"id\"],"},{"line_number":64,"context_line":"        #                          constants.ACTIVE)"},{"line_number":65,"context_line":"        pass"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FieM%3D","line":63,"in_reply_to":"AAAAOn%2F%2FimY%3D","updated":"2013-05-07 07:55:18.000000000","message":"because if we activate it - it will break the test. The test expects the record to be in PENDEING status","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"}],"quantum/plugins/services/agent_loadbalancer/drivers/noop/noop_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":21,"context_line":"from quantum.plugins.services.agent_loadbalancer.drivers. \\"},{"line_number":22,"context_line":"    abstract_driver import LoadBalancerAbstarctDriver"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#from quantum.db.loadbalancer.loadbalancer_db import ("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiXw%3D","line":22,"updated":"2013-05-06 14:04:43.000000000","message":"LoadBalancerAbstarctDriver - typo\nLoadBalancerAbstractDriver","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":21,"context_line":"from quantum.plugins.services.agent_loadbalancer.drivers. \\"},{"line_number":22,"context_line":"    abstract_driver import LoadBalancerAbstarctDriver"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#from quantum.db.loadbalancer.loadbalancer_db import ("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiWI%3D","line":22,"in_reply_to":"AAAAOn%2F%2FiXw%3D","updated":"2013-05-07 07:55:33.000000000","message":"will fix it.","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"    abstract_driver import LoadBalancerAbstarctDriver"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#from quantum.db.loadbalancer.loadbalancer_db import ("},{"line_number":26,"context_line":"#    HealthMonitor"},{"line_number":27,"context_line":"#    Member"},{"line_number":28,"context_line":"#    Pool"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiX4%3D","line":25,"updated":"2013-05-06 14:04:43.000000000","message":"Doe you need these?","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    abstract_driver import LoadBalancerAbstarctDriver"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#from quantum.db.loadbalancer.loadbalancer_db import ("},{"line_number":26,"context_line":"#    HealthMonitor"},{"line_number":27,"context_line":"#    Member"},{"line_number":28,"context_line":"#    Pool"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiWE%3D","line":25,"in_reply_to":"AAAAOn%2F%2FiX4%3D","updated":"2013-05-07 07:55:33.000000000","message":"the idea is to use this noop driver as a starting point for vendor impl. This is why I have all those comments in code. If this is not acceptable  - I will remove those imports.","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"#)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#from quantum.plugins.common import constants"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiX0%3D","line":33,"updated":"2013-05-06 14:04:43.000000000","message":"ditto","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Radware LTD."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fg28%3D","line":1,"updated":"2013-05-07 13:29:47.000000000","message":"Since this file is used for testing/example purposes, it should reside in unit tests.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.plugin \u003d plugin"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @log"},{"line_number":46,"context_line":"    def create_vip(self, context, vip):"},{"line_number":47,"context_line":"        # A \"real driver\" would invoke a call to his backend"},{"line_number":48,"context_line":"        # and set the Vip status to ACTIVE/ERROR according"},{"line_number":49,"context_line":"        # to the backend call result"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fgi8%3D","line":46,"updated":"2013-05-07 13:23:14.000000000","message":"Why not use the docstring conventions - pep257?","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.plugin \u003d plugin"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @log"},{"line_number":46,"context_line":"    def create_vip(self, context, vip):"},{"line_number":47,"context_line":"        # A \"real driver\" would invoke a call to his backend"},{"line_number":48,"context_line":"        # and set the Vip status to ACTIVE/ERROR according"},{"line_number":49,"context_line":"        # to the backend call result"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe%2Fg%3D","line":46,"in_reply_to":"AAAAOn%2F%2Fgi8%3D","updated":"2013-05-08 12:11:06.000000000","message":"OK","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":"        to the backend call result"},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # self.plugin.update_status(context, Vip, vip[\"id\"],"},{"line_number":54,"context_line":"        #                          constants.ACTIVE)"},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcnU%3D","line":53,"updated":"2013-05-09 11:06:38.000000000","message":"Why is this commented out. If it is an example then please move it to the comment above","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        to the backend call result"},{"line_number":51,"context_line":"        \"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        # self.plugin.update_status(context, Vip, vip[\"id\"],"},{"line_number":54,"context_line":"        #                          constants.ACTIVE)"},{"line_number":55,"context_line":"        pass"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcmM%3D","line":53,"in_reply_to":"AAAAOn%2F%2FcnU%3D","updated":"2013-05-09 12:13:58.000000000","message":"OK.","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @log"},{"line_number":58,"context_line":"    def update_vip(self, context, vip):"},{"line_number":59,"context_line":"        \"\"\"driver may call the code below in order to update the status.\"\"\""},{"line_number":60,"context_line":"        # self.plugin.update_status(context, Vip, id, constants.ACTIVE)"},{"line_number":61,"context_line":"        pass"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @log"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcnQ%3D","line":60,"updated":"2013-05-09 11:06:38.000000000","message":"ditto","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @log"},{"line_number":81,"context_line":"    def update_pool(self, context, pool):"},{"line_number":82,"context_line":"        \"\"\"driver may call the code below in order to update the status.\"\"\""},{"line_number":83,"context_line":"        # self.plugin.update_status(context,"},{"line_number":84,"context_line":"        #                           Pool,"},{"line_number":85,"context_line":"        #                           pool[\"id\"], constants.ACTIVE)"},{"line_number":86,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcnM%3D","line":83,"updated":"2013-05-09 11:06:38.000000000","message":"ditto","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @log"},{"line_number":100,"context_line":"    def create_member(self, context, member):"},{"line_number":101,"context_line":"        \"\"\"driver may call the code below in order to update the status.\"\"\""},{"line_number":102,"context_line":"        # self.plugin.update_status(context, Member, member[\"id\"],"},{"line_number":103,"context_line":"        #                           constants.ACTIVE)"},{"line_number":104,"context_line":"        pass"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcnI%3D","line":102,"updated":"2013-05-09 11:06:38.000000000","message":"ditto","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":106,"context_line":"    @log"},{"line_number":107,"context_line":"    def update_member(self, context, member):"},{"line_number":108,"context_line":"        \"\"\"driver may call the code below in order to update the status.\"\"\""},{"line_number":109,"context_line":"        # self.plugin.update_status(context, Member,"},{"line_number":110,"context_line":"        #                           member[\"id\"], constants.ACTIVE)"},{"line_number":111,"context_line":"        pass"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcnE%3D","line":109,"updated":"2013-05-09 11:06:38.000000000","message":"ditto","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @log"},{"line_number":118,"context_line":"    def create_health_monitor(self, context, health_monitor):"},{"line_number":119,"context_line":"        \"\"\"driver may call the code below in order to update the status.\"\"\""},{"line_number":120,"context_line":"        # self.plugin.update_status(context, HealthMonitor,"},{"line_number":121,"context_line":"        #                          health_monitor[\"id\"],"},{"line_number":122,"context_line":"        #                          constants.ACTIVE)"},{"line_number":123,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FcnA%3D","line":120,"updated":"2013-05-09 11:06:38.000000000","message":"ditto","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":132,"context_line":"        the health monitor status will be set to ACTIVE."},{"line_number":133,"context_line":"        \"\"\""},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        # driver may call the code below in order to update the status"},{"line_number":136,"context_line":"        # self.plugin.update_status(context, HealthMonitor,"},{"line_number":137,"context_line":"        #                           health_monitor[\"id\"], constants.ACTIVE)"},{"line_number":138,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2Fcm8%3D","line":135,"updated":"2013-05-09 11:06:38.000000000","message":"ditto","commit_id":"0b168fe78e4d0eaacab22c4a1270d3859f281abe"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Radware LTD."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2Fca0%3D","line":1,"updated":"2013-05-09 14:42:11.000000000","message":"I\u0027m not sure this needs to be a separate file.  Logically this could go into the base module that contains the abstract impl.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Radware LTD."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FYiE%3D","line":1,"in_reply_to":"AAAAOn%2F%2Fca0%3D","updated":"2013-05-12 13:30:38.000000000","message":"This must be my java background where 1 class \u003d\u003d 1 file (module) . In my eyes it makes sense to separate the modules: 1 module for the contract (the abstract class)  and another one for the dummy impl (noop). However if it just feels \"not right\" for you I can change it.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":21,"context_line":"from quantum.plugins.services.agent_loadbalancer.drivers. \\"},{"line_number":22,"context_line":"    abstract_driver import LoadBalancerAbstractDriver"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcbE%3D","line":21,"updated":"2013-05-09 14:42:11.000000000","message":"Line continuations are not allowed per Quantum\u0027s hacking guidelines.  Also you should import the module and not the class into the namespace.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":21,"context_line":"from quantum.plugins.services.agent_loadbalancer.drivers. \\"},{"line_number":22,"context_line":"    abstract_driver import LoadBalancerAbstractDriver"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FYh4%3D","line":21,"in_reply_to":"AAAAOn%2F%2FcbE%3D","updated":"2013-05-12 13:30:38.000000000","message":"OK\n\n(Maybe a new \"rule\" should be added to the flake8 to catch line continuations)","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @log"},{"line_number":92,"context_line":"    def delete_pool(self, context, pool):"},{"line_number":93,"context_line":"        self.plugin._delete_db_pool(context, pool[\"id\"])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @log"},{"line_number":96,"context_line":"    def stats(self, context, pool_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2Fcbs%3D","line":93,"updated":"2013-05-09 14:42:11.000000000","message":"Seems like this should be commented out.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @log"},{"line_number":92,"context_line":"    def delete_pool(self, context, pool):"},{"line_number":93,"context_line":"        self.plugin._delete_db_pool(context, pool[\"id\"])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @log"},{"line_number":96,"context_line":"    def stats(self, context, pool_id):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FYh0%3D","line":93,"in_reply_to":"AAAAOn%2F%2Fcbs%3D","updated":"2013-05-12 13:30:38.000000000","message":"OK","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @log"},{"line_number":119,"context_line":"    def delete_member(self, context, member):"},{"line_number":120,"context_line":"        self.plugin._delete_db_member(context, member[\"id\"])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @log"},{"line_number":123,"context_line":"    def create_health_monitor(self, context, health_monitor):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2Fcbk%3D","line":120,"updated":"2013-05-09 14:42:11.000000000","message":"Seems like this should be commented out.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @log"},{"line_number":119,"context_line":"    def delete_member(self, context, member):"},{"line_number":120,"context_line":"        self.plugin._delete_db_member(context, member[\"id\"])"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @log"},{"line_number":123,"context_line":"    def create_health_monitor(self, context, health_monitor):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FYhw%3D","line":120,"in_reply_to":"AAAAOn%2F%2Fcbk%3D","updated":"2013-05-12 13:30:38.000000000","message":"Cant comment it out - it breaks the test","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":146,"context_line":"    @log"},{"line_number":147,"context_line":"    def delete_health_monitor(self, context, pool_associations,"},{"line_number":148,"context_line":"                              health_monitor):"},{"line_number":149,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @log"},{"line_number":152,"context_line":"    def create_pool_health_monitor(self, context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2Fcbg%3D","line":149,"updated":"2013-05-09 14:42:11.000000000","message":"Same as above.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    @log"},{"line_number":147,"context_line":"    def delete_health_monitor(self, context, pool_associations,"},{"line_number":148,"context_line":"                              health_monitor):"},{"line_number":149,"context_line":"        self.plugin._delete_db_health_monitor(context, health_monitor[\"id\"])"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    @log"},{"line_number":152,"context_line":"    def create_pool_health_monitor(self, context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FYhs%3D","line":149,"in_reply_to":"AAAAOn%2F%2Fcbg%3D","updated":"2013-05-12 13:30:38.000000000","message":"Cant comment it out - it breaks the test","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \"\"\"A real driver would invoke a call to his backend"},{"line_number":50,"context_line":"        and set the Vip status to ACTIVE/ERROR according"},{"line_number":51,"context_line":"        to the backend call result"},{"line_number":52,"context_line":"        self.plugin.update_status(context, Vip, vip[\"id\"],"},{"line_number":53,"context_line":"                                  constants.ACTIVE)"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV6s%3D","line":52,"updated":"2013-05-14 05:23:31.000000000","message":"ditto below.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \"\"\"A real driver would invoke a call to his backend"},{"line_number":50,"context_line":"        and set the Vip status to ACTIVE/ERROR according"},{"line_number":51,"context_line":"        to the backend call result"},{"line_number":52,"context_line":"        self.plugin.update_status(context, Vip, vip[\"id\"],"},{"line_number":53,"context_line":"                                  constants.ACTIVE)"},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F9Go%3D","line":52,"in_reply_to":"AAAAOn%2F%2FV6s%3D","updated":"2013-05-16 10:37:21.000000000","message":"OK for this one and for the rest of the comments in this file.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"    @log"},{"line_number":59,"context_line":"    def update_vip(self, context, vip):"},{"line_number":60,"context_line":"        \"\"\"driver may call the code below in order to update the status."},{"line_number":61,"context_line":"        self.plugin.update_status(context, Vip, id, constants.ACTIVE)"},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        pass"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV6w%3D","line":61,"updated":"2013-05-14 05:23:31.000000000","message":"ditto below.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":75,"context_line":"    @log"},{"line_number":76,"context_line":"    def create_pool(self, context, pool):"},{"line_number":77,"context_line":"        \"\"\"driver may call the code below in order to update the status."},{"line_number":78,"context_line":"        self.plugin.update_status(context, Pool, pool[\"id\"],"},{"line_number":79,"context_line":"                                  constants.ACTIVE)"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV60%3D","line":78,"updated":"2013-05-14 05:23:31.000000000","message":"diito below","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @log"},{"line_number":84,"context_line":"    def update_pool(self, context, pool):"},{"line_number":85,"context_line":"        \"\"\"driver may call the code below in order to update the status."},{"line_number":86,"context_line":"        self.plugin.update_status(context,"},{"line_number":87,"context_line":"                                  Pool,"},{"line_number":88,"context_line":"                                  pool[\"id\"], constants.ACTIVE)"},{"line_number":89,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV68%3D","line":86,"updated":"2013-05-14 05:23:31.000000000","message":"remove commented out code.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @log"},{"line_number":93,"context_line":"    def delete_pool(self, context, pool):"},{"line_number":94,"context_line":"        \"\"\"self.plugin._delete_db_pool(context, pool[\"id\"]).\"\"\""},{"line_number":95,"context_line":"        pass"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @log"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV64%3D","line":94,"updated":"2013-05-14 05:23:31.000000000","message":"ditto","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @log"},{"line_number":105,"context_line":"    def create_member(self, context, member):"},{"line_number":106,"context_line":"        \"\"\"driver may call the code below in order to update the status."},{"line_number":107,"context_line":"        self.plugin.update_status(context, Member, member[\"id\"],"},{"line_number":108,"context_line":"                                   constants.ACTIVE)"},{"line_number":109,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV7A%3D","line":106,"updated":"2013-05-14 05:23:31.000000000","message":"Sentence starts with a capital letter.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":133,"context_line":"    @log"},{"line_number":134,"context_line":"    def update_health_monitor(self, context, pool_associations,"},{"line_number":135,"context_line":"                              health_monitor):"},{"line_number":136,"context_line":"        \"\"\"A real driver would handle the update of all accociations atomicaly"},{"line_number":137,"context_line":"        This means that if any of the association updates has failed,"},{"line_number":138,"context_line":"        the health monitor status will be set to ERROR."},{"line_number":139,"context_line":"        If all associations were successfull,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV7I%3D","line":136,"updated":"2013-05-14 05:23:31.000000000","message":"associations \natomically.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":33,"context_line":"    return wrapper"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class NoopLbaaSDriver(abstract_driver.LoadBalancerAbstractDriver):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \"\"\"A dummy lbass driver that:"},{"line_number":39,"context_line":"       1) Logs methods input"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAO3%2F%2F8bY%3D","line":36,"updated":"2013-05-16 15:31:23.000000000","message":"I\u0027m still not sure about the value of this class. If we put method docstrings into abstract driver then it will serve as a starting point for vendors and it will be the only place for vendors to look at. What do you think?","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    return wrapper"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class NoopLbaaSDriver(abstract_driver.LoadBalancerAbstractDriver):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \"\"\"A dummy lbass driver that:"},{"line_number":39,"context_line":"       1) Logs methods input"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAPH%2F%2F7vY%3D","line":36,"in_reply_to":"AAAAO3%2F%2F8bY%3D","updated":"2013-05-19 10:55:43.000000000","message":"I think that the value can come from the fact that it is the default driver and it has the @log. With this a driver developer can understnd very fast the data structures that are passed to the driver. (since those structures are dicts abd not classes it is not easy to understand what is a passed)","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":131,"context_line":"        pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @log"},{"line_number":134,"context_line":"    def update_health_monitor(self, context, pool_associations,"},{"line_number":135,"context_line":"                              health_monitor):"},{"line_number":136,"context_line":"        \"\"\"A real driver would handle the update of all associations"},{"line_number":137,"context_line":"        atomically."}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F62o%3D","line":134,"updated":"2013-05-20 10:05:28.000000000","message":"change accordingly to comments to abstract driver","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        pass"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @log"},{"line_number":134,"context_line":"    def update_health_monitor(self, context, pool_associations,"},{"line_number":135,"context_line":"                              health_monitor):"},{"line_number":136,"context_line":"        \"\"\"A real driver would handle the update of all associations"},{"line_number":137,"context_line":"        atomically."}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F6wc%3D","line":134,"in_reply_to":"AAAAPH%2F%2F62o%3D","updated":"2013-05-20 15:56:51.000000000","message":"OK","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":"        pass"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @log"},{"line_number":150,"context_line":"    def delete_health_monitor(self, context, pool_associations,"},{"line_number":151,"context_line":"                              health_monitor):"},{"line_number":152,"context_line":"        self.plugin._delete_db_health_monitor("},{"line_number":153,"context_line":"            context, health_monitor[\"id\"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F62k%3D","line":150,"updated":"2013-05-20 10:05:28.000000000","message":"ditto","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        pass"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @log"},{"line_number":150,"context_line":"    def delete_health_monitor(self, context, pool_associations,"},{"line_number":151,"context_line":"                              health_monitor):"},{"line_number":152,"context_line":"        self.plugin._delete_db_health_monitor("},{"line_number":153,"context_line":"            context, health_monitor[\"id\"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPH%2F%2F6wY%3D","line":150,"in_reply_to":"AAAAPH%2F%2F62k%3D","updated":"2013-05-20 15:56:51.000000000","message":"OK","commit_id":"11537ef93acd822f3bbf1200b8169fae20179343"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        LOG.debug(\u0027NoopLbaaSDriver method %s called with arguments %s %s\u0027"},{"line_number":31,"context_line":"                  % (method.__name__, args, kwargs))"},{"line_number":32,"context_line":"        return method(*args, **kwargs)"},{"line_number":33,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FeqY%3D","line":30,"updated":"2013-06-02 12:38:34.000000000","message":"Please use the i18n format:\nLOG.debug(_(\"....\"), {})","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        LOG.debug(\u0027NoopLbaaSDriver method %s called with arguments %s %s\u0027"},{"line_number":31,"context_line":"                  % (method.__name__, args, kwargs))"},{"line_number":32,"context_line":"        return method(*args, **kwargs)"},{"line_number":33,"context_line":"    return wrapper"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FdBk%3D","line":30,"in_reply_to":"AAAAPH%2F%2FeqY%3D","updated":"2013-06-03 17:06:14.000000000","message":"OK","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        data \u003d {\"method_name\": method.__name__, \"args\": args, \"kwargs\": kwargs}"},{"line_number":31,"context_line":"        LOG.debug(_(\u0027NoopLbaaSDriver method %(method_name)s\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2FcIg%3D","line":28,"updated":"2013-06-03 22:47:32.000000000","message":"This decorator is useful. it would be nice If we have it in common.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        data \u003d {\"method_name\": method.__name__, \"args\": args, \"kwargs\": kwargs}"},{"line_number":31,"context_line":"        LOG.debug(_(\u0027NoopLbaaSDriver method %(method_name)s\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2Frc%3D","line":28,"in_reply_to":"AAAAPH%2F%2FcIg%3D","updated":"2013-06-04 12:49:36.000000000","message":"I agree. Where should it be? (Oslo?)","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        data \u003d {\"method_name\": method.__name__, \"args\": args, \"kwargs\": kwargs}"},{"line_number":31,"context_line":"        LOG.debug(_(\u0027NoopLbaaSDriver method %(method_name)s\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F9Qk%3D","line":28,"in_reply_to":"AAAAPX%2F%2F%2Frc%3D","updated":"2013-06-05 07:20:36.000000000","message":"quantum/common or oslo looks a good place. I am not sure which is better. When I commented quantum/common was in my mind.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        data \u003d {\"method_name\": method.__name__, \"args\": args, \"kwargs\": kwargs}"},{"line_number":31,"context_line":"        LOG.debug(_(\u0027NoopLbaaSDriver method %(method_name)s\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F9LA%3D","line":28,"in_reply_to":"AAAAPX%2F%2F9Qk%3D","updated":"2013-06-05 13:10:03.000000000","message":"I can open a bug and move it to common","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        data \u003d {\"method_name\": method.__name__, \"args\": args, \"kwargs\": kwargs}"},{"line_number":31,"context_line":"        LOG.debug(_(\u0027NoopLbaaSDriver method %(method_name)s\u0027"},{"line_number":32,"context_line":"                    \u0027called with arguments %(args)s %(kwargs)s\u0027)"},{"line_number":33,"context_line":"                  % data)"},{"line_number":34,"context_line":"        return method(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2FcIc%3D","line":31,"updated":"2013-06-03 22:47:32.000000000","message":"Needs a space at the end of line.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"def log(method):"},{"line_number":29,"context_line":"    def wrapper(*args, **kwargs):"},{"line_number":30,"context_line":"        data \u003d {\"method_name\": method.__name__, \"args\": args, \"kwargs\": kwargs}"},{"line_number":31,"context_line":"        LOG.debug(_(\u0027NoopLbaaSDriver method %(method_name)s\u0027"},{"line_number":32,"context_line":"                    \u0027called with arguments %(args)s %(kwargs)s\u0027)"},{"line_number":33,"context_line":"                  % data)"},{"line_number":34,"context_line":"        return method(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2FrY%3D","line":31,"in_reply_to":"AAAAPH%2F%2FcIc%3D","updated":"2013-06-04 12:49:36.000000000","message":"OK","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class NoopLbaaSDriver(abstract_driver.LoadBalancerAbstractDriver):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"\"\"A dummy lbass driver that:"},{"line_number":41,"context_line":"       1) Logs methods input"},{"line_number":42,"context_line":"       2) Uses the plugin API in order to update"},{"line_number":43,"context_line":"          the config elements status in DB"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2FcIw%3D","line":40,"updated":"2013-06-03 22:47:32.000000000","message":"It is better Multiline Docstirng consists of first summary line, second empty line and the detail from the third line (though it is not checked by flake8 now). Same comments for method docstrings.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class NoopLbaaSDriver(abstract_driver.LoadBalancerAbstractDriver):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"\"\"A dummy lbass driver that:"},{"line_number":41,"context_line":"       1) Logs methods input"},{"line_number":42,"context_line":"       2) Uses the plugin API in order to update"},{"line_number":43,"context_line":"          the config elements status in DB"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2Frk%3D","line":40,"in_reply_to":"AAAAPH%2F%2FcIw%3D","updated":"2013-06-04 12:49:36.000000000","message":"If we think it is important - lets add it to flake8.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":"        and set the Vip status to ACTIVE/ERROR according"},{"line_number":53,"context_line":"        to the backend call result"},{"line_number":54,"context_line":"        self.plugin.update_status(context, Vip, vip[\"id\"],"},{"line_number":55,"context_line":"                                  constants.ACTIVE)"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2FcH0%3D","line":55,"updated":"2013-06-03 22:47:32.000000000","message":"These description look general. How about moving them to the abstract class?","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        and set the Vip status to ACTIVE/ERROR according"},{"line_number":53,"context_line":"        to the backend call result"},{"line_number":54,"context_line":"        self.plugin.update_status(context, Vip, vip[\"id\"],"},{"line_number":55,"context_line":"                                  constants.ACTIVE)"},{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2FrU%3D","line":55,"in_reply_to":"AAAAPH%2F%2FcH0%3D","updated":"2013-06-04 12:49:36.000000000","message":"I will do that.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"}],"quantum/plugins/services/agent_loadbalancer/lbaas_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":24,"context_line":"from quantum.plugins.common import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Member"},{"line_number":27,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Pool"},{"line_number":28,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Vip"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Figo%3D","line":26,"updated":"2013-05-06 11:22:12.000000000","message":"Please use module level import instead of Class level import. Also check import order","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":24,"context_line":"from quantum.plugins.common import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Member"},{"line_number":27,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Pool"},{"line_number":28,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Vip"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FibA%3D","line":26,"in_reply_to":"AAAAOn%2F%2Figo%3D","updated":"2013-05-07 07:55:18.000000000","message":"I assume that once I pass flake8 I am OK with import order.","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class LoadBalancerPlugin(loadbalancer_db.LoadBalancerPluginDb):"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    Implementation of the Quantum Loadbalancer Service Plugin."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Figk%3D","line":46,"updated":"2013-05-06 11:22:12.000000000","message":"pep257","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class LoadBalancerPlugin(loadbalancer_db.LoadBalancerPluginDb):"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    Implementation of the Quantum Loadbalancer Service Plugin."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fia0%3D","line":46,"in_reply_to":"AAAAOn%2F%2Figk%3D","updated":"2013-05-07 07:55:18.000000000","message":"OK","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":"from quantum.openstack.common import importutils"},{"line_number":23,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":24,"context_line":"from quantum.plugins.common import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Member"},{"line_number":27,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Pool"},{"line_number":28,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Vip"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiXk%3D","line":25,"updated":"2013-05-06 14:04:43.000000000","message":"why the new line here?","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from quantum.openstack.common import importutils"},{"line_number":23,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":24,"context_line":"from quantum.plugins.common import constants"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Member"},{"line_number":27,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Pool"},{"line_number":28,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Vip"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiWY%3D","line":25,"in_reply_to":"AAAAOn%2F%2FiXk%3D","updated":"2013-05-07 07:55:33.000000000","message":"will fix it","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright 2013 Radware LTD."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fg2o%3D","line":1,"updated":"2013-05-07 13:29:47.000000000","message":"As I said previously, separate plugin is not needed, please remove.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo.config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.db import api as qdbapi"},{"line_number":21,"context_line":"from quantum.db.loadbalancer import loadbalancer_db"},{"line_number":22,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Member"},{"line_number":23,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Pool"},{"line_number":24,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Vip"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fgig%3D","line":21,"updated":"2013-05-07 13:23:14.000000000","message":"i do not think that you need lines 22-24 you can use loadbalancer_db.Member etc.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo.config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from quantum.db import api as qdbapi"},{"line_number":21,"context_line":"from quantum.db.loadbalancer import loadbalancer_db"},{"line_number":22,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Member"},{"line_number":23,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Pool"},{"line_number":24,"context_line":"from quantum.db.loadbalancer.loadbalancer_db import Vip"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe%2B0%3D","line":21,"in_reply_to":"AAAAOn%2F%2Fgig%3D","updated":"2013-05-08 12:11:06.000000000","message":"OK","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"                  \".drivers.noop\""},{"line_number":33,"context_line":"                  \".noop_driver.NoopLbaaSDriver\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027lbaas_driver_fqn\u0027,"},{"line_number":37,"context_line":"               default\u003dDEFAULT_DRIVER,"},{"line_number":38,"context_line":"               help\u003d_(\u0027LBaaS driver Fully Qualified Name\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FggE%3D","line":35,"updated":"2013-05-07 13:35:46.000000000","message":"Also, lbaas drivers will not be taken from configuration, the\u0027re gonna be taken from servicetypes framework","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                  \".drivers.noop\""},{"line_number":33,"context_line":"                  \".noop_driver.NoopLbaaSDriver\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027lbaas_driver_fqn\u0027,"},{"line_number":37,"context_line":"               default\u003dDEFAULT_DRIVER,"},{"line_number":38,"context_line":"               help\u003d_(\u0027LBaaS driver Fully Qualified Name\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe%2Bs%3D","line":35,"in_reply_to":"AAAAOn%2F%2FggE%3D","updated":"2013-05-08 12:11:06.000000000","message":"As for now - there is no service type implementation. This is why the driver is loaded from config.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":33,"context_line":"                  \".noop_driver.NoopLbaaSDriver\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027lbaas_driver_fqn\u0027,"},{"line_number":37,"context_line":"               default\u003dDEFAULT_DRIVER,"},{"line_number":38,"context_line":"               help\u003d_(\u0027LBaaS driver Fully Qualified Name\u0027))"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fgic%3D","line":36,"updated":"2013-05-07 13:23:14.000000000","message":"Can you please update the configuration ini file with this as a comment so that the user knows the default","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                  \".noop_driver.NoopLbaaSDriver\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":36,"context_line":"    cfg.StrOpt(\u0027lbaas_driver_fqn\u0027,"},{"line_number":37,"context_line":"               default\u003dDEFAULT_DRIVER,"},{"line_number":38,"context_line":"               help\u003d_(\u0027LBaaS driver Fully Qualified Name\u0027))"},{"line_number":39,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe%2Bw%3D","line":36,"in_reply_to":"AAAAOn%2F%2Fgic%3D","updated":"2013-05-08 12:11:06.000000000","message":"OK","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def create_vip(self, context, vip):"},{"line_number":70,"context_line":"        v \u003d super(LoadBalancerPlugin, self).create_vip(context, vip)"},{"line_number":71,"context_line":"        self.driver.create_vip(context, v)"},{"line_number":72,"context_line":"        return v"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def update_vip(self, context, id, vip):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FgiU%3D","line":71,"updated":"2013-05-07 13:23:14.000000000","message":"fit his fails do you want to rollback the vip creation?","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def create_vip(self, context, vip):"},{"line_number":70,"context_line":"        v \u003d super(LoadBalancerPlugin, self).create_vip(context, vip)"},{"line_number":71,"context_line":"        self.driver.create_vip(context, v)"},{"line_number":72,"context_line":"        return v"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def update_vip(self, context, id, vip):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe9c%3D","line":71,"in_reply_to":"AAAAOn%2F%2FgiU%3D","updated":"2013-05-08 12:11:06.000000000","message":"Not sure I get your point. The vip is created in the DB by calling the super.\nNow the driver in called and try to create the vip on its \"backend\" device.\nIf the operation fail - the driver will mark the DB record of vip with ERROR.\nIs that helps?","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.driver.delete_member(context, m)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def create_health_monitor(self, context, health_monitor):"},{"line_number":130,"context_line":"        # make pep8 happy"},{"line_number":131,"context_line":"        _create_hm \u003d super(LoadBalancerPlugin, self).create_health_monitor"},{"line_number":132,"context_line":"        hm \u003d _create_hm(context, health_monitor)"},{"line_number":133,"context_line":"        self.driver.create_health_monitor(context, hm)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FgiI%3D","line":130,"updated":"2013-05-07 13:23:14.000000000","message":"why?","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.driver.delete_member(context, m)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def create_health_monitor(self, context, health_monitor):"},{"line_number":130,"context_line":"        # make pep8 happy"},{"line_number":131,"context_line":"        _create_hm \u003d super(LoadBalancerPlugin, self).create_health_monitor"},{"line_number":132,"context_line":"        hm \u003d _create_hm(context, health_monitor)"},{"line_number":133,"context_line":"        self.driver.create_health_monitor(context, hm)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fe9M%3D","line":130,"in_reply_to":"AAAAOn%2F%2FgiI%3D","updated":"2013-05-08 12:11:06.000000000","message":"I had to break the line because it was long - so I assigned the function to a variable and invoked the function on the next line.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.driver.delete_member(context, m)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def create_health_monitor(self, context, health_monitor):"},{"line_number":130,"context_line":"        # make pep8 happy"},{"line_number":131,"context_line":"        _create_hm \u003d super(LoadBalancerPlugin, self).create_health_monitor"},{"line_number":132,"context_line":"        hm \u003d _create_hm(context, health_monitor)"},{"line_number":133,"context_line":"        self.driver.create_health_monitor(context, hm)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcaU%3D","line":130,"updated":"2013-05-09 14:42:11.000000000","message":"Not sure I see why this is necessary to make pep8 happy.  Consider the alternate layout below.  It is more common for Python and pep8 compliant.\n\nhm \u003d super(LoadBalancerPlugin, self).create_health_monitor(\n    context,\n    healt_monitor\n)","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.driver.delete_member(context, m)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def create_health_monitor(self, context, health_monitor):"},{"line_number":130,"context_line":"        # make pep8 happy"},{"line_number":131,"context_line":"        _create_hm \u003d super(LoadBalancerPlugin, self).create_health_monitor"},{"line_number":132,"context_line":"        hm \u003d _create_hm(context, health_monitor)"},{"line_number":133,"context_line":"        self.driver.create_health_monitor(context, hm)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcWk%3D","line":130,"in_reply_to":"AAAAOn%2F%2FcaU%3D","updated":"2013-05-12 13:30:38.000000000","message":"OK","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":198,"context_line":"            context, hm, pool_id)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def stats(self, context, pool_id):"},{"line_number":201,"context_line":"        _stats \u003d self.driver.stats(context, pool_id)"},{"line_number":202,"context_line":"        # if we get something from the driver -"},{"line_number":203,"context_line":"        # update the db and return the value from db"},{"line_number":204,"context_line":"        # else - return what we have in db"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcZ0%3D","line":201,"updated":"2013-05-09 14:42:11.000000000","message":"_stats is a local variable.  I don\u0027t think this needs to be prefaced with an underscore.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            context, hm, pool_id)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def stats(self, context, pool_id):"},{"line_number":201,"context_line":"        _stats \u003d self.driver.stats(context, pool_id)"},{"line_number":202,"context_line":"        # if we get something from the driver -"},{"line_number":203,"context_line":"        # update the db and return the value from db"},{"line_number":204,"context_line":"        # else - return what we have in db"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcWc%3D","line":201,"in_reply_to":"AAAAOn%2F%2FcZ0%3D","updated":"2013-05-12 13:30:38.000000000","message":"OK","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # update the db and return the value from db"},{"line_number":204,"context_line":"        # else - return what we have in db"},{"line_number":205,"context_line":"        if _stats:"},{"line_number":206,"context_line":"            super(LoadBalancerPlugin,"},{"line_number":207,"context_line":"                  self)._update_pool_stats(context,"},{"line_number":208,"context_line":"                                           pool_id,"},{"line_number":209,"context_line":"                                           _stats)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcZc%3D","line":206,"updated":"2013-05-09 14:42:11.000000000","message":"super(LoadBalancerPlugin, self)._update_pool_stats(\n    context, \n    pool_id,\n    stats\n)","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        # update the db and return the value from db"},{"line_number":204,"context_line":"        # else - return what we have in db"},{"line_number":205,"context_line":"        if _stats:"},{"line_number":206,"context_line":"            super(LoadBalancerPlugin,"},{"line_number":207,"context_line":"                  self)._update_pool_stats(context,"},{"line_number":208,"context_line":"                                           pool_id,"},{"line_number":209,"context_line":"                                           _stats)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcWM%3D","line":206,"in_reply_to":"AAAAOn%2F%2FcZc%3D","updated":"2013-05-12 13:30:38.000000000","message":"OK","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":216,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":217,"context_line":"        vip[\u0027pool\u0027] \u003d pool"},{"line_number":218,"context_line":"        vip[\u0027members\u0027] \u003d []"},{"line_number":219,"context_line":"        for member_id in pool[\u0027members\u0027]:"},{"line_number":220,"context_line":"            member \u003d self.get_member(context, member_id)"},{"line_number":221,"context_line":"            vip[\u0027members\u0027].append(member)"},{"line_number":222,"context_line":"        vip[\u0027health_monitors\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcZI%3D","line":219,"updated":"2013-05-09 14:42:11.000000000","message":"You should use a list comprehension here.  Replace 218-221\n\nvip[\u0027members\u0027] \u003d [\n    self.get_member(context, member_id)\n    for member_id in pool[\u0027members\u0027]\n]","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":217,"context_line":"        vip[\u0027pool\u0027] \u003d pool"},{"line_number":218,"context_line":"        vip[\u0027members\u0027] \u003d []"},{"line_number":219,"context_line":"        for member_id in pool[\u0027members\u0027]:"},{"line_number":220,"context_line":"            member \u003d self.get_member(context, member_id)"},{"line_number":221,"context_line":"            vip[\u0027members\u0027].append(member)"},{"line_number":222,"context_line":"        vip[\u0027health_monitors\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcWI%3D","line":219,"in_reply_to":"AAAAOn%2F%2FcZI%3D","updated":"2013-05-12 13:30:38.000000000","message":"OK","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":219,"context_line":"        for member_id in pool[\u0027members\u0027]:"},{"line_number":220,"context_line":"            member \u003d self.get_member(context, member_id)"},{"line_number":221,"context_line":"            vip[\u0027members\u0027].append(member)"},{"line_number":222,"context_line":"        vip[\u0027health_monitors\u0027] \u003d []"},{"line_number":223,"context_line":"        for hm_id in pool[\u0027health_monitors\u0027]:"},{"line_number":224,"context_line":"            hm \u003d self.get_health_monitor(context, hm_id)"},{"line_number":225,"context_line":"            vip[\u0027health_monitors\u0027].append(hm)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcY4%3D","line":222,"updated":"2013-05-09 14:42:11.000000000","message":"Same as above.  Replace lines 222-225 with:\n\nvip[\u0027health_monitors\u0027] \u003d [\n    self.get_health_monitor(context, hm_id)\n    for hm_id in pool[\u0027health_monitors\u0027]\n]","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        for member_id in pool[\u0027members\u0027]:"},{"line_number":220,"context_line":"            member \u003d self.get_member(context, member_id)"},{"line_number":221,"context_line":"            vip[\u0027members\u0027].append(member)"},{"line_number":222,"context_line":"        vip[\u0027health_monitors\u0027] \u003d []"},{"line_number":223,"context_line":"        for hm_id in pool[\u0027health_monitors\u0027]:"},{"line_number":224,"context_line":"            hm \u003d self.get_health_monitor(context, hm_id)"},{"line_number":225,"context_line":"            vip[\u0027health_monitors\u0027].append(hm)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcV8%3D","line":222,"in_reply_to":"AAAAOn%2F%2FcY4%3D","updated":"2013-05-12 13:30:38.000000000","message":"OK","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":213,"context_line":"                                                     pool_id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def populate_vip_graph(self, context, vip):"},{"line_number":216,"context_line":"        \"\"\"populate the vip with: pool,members,healthmonitors.\"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":219,"context_line":"        vip[\u0027pool\u0027] \u003d pool"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV7k%3D","line":216,"updated":"2013-05-14 05:23:31.000000000","message":"it would be nice to add some space,after,the,comas","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                                                     pool_id)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def populate_vip_graph(self, context, vip):"},{"line_number":216,"context_line":"        \"\"\"populate the vip with: pool,members,healthmonitors.\"\"\""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":219,"context_line":"        vip[\u0027pool\u0027] \u003d pool"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F9Gg%3D","line":216,"in_reply_to":"AAAAOn%2F%2FV7k%3D","updated":"2013-05-16 10:37:21.000000000","message":"OK","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":219,"context_line":"        vip[\u0027pool\u0027] \u003d pool"},{"line_number":220,"context_line":"        vip[\u0027members\u0027] \u003d ["},{"line_number":221,"context_line":"            self.get_member(context, member_id)"},{"line_number":222,"context_line":"            for member_id in pool[\u0027members\u0027]"},{"line_number":223,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV7g%3D","line":220,"updated":"2013-05-14 05:23:31.000000000","message":"220-223 could all fit on two lines.\n\n vip[\u0027members\u0027] \u003d [self.get_member(context, member_id)\n                   for member_id in pool[\u0027members\u0027]]\n\nimo that\u0027s more readable.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":221,"context_line":"            self.get_member(context, member_id)"},{"line_number":222,"context_line":"            for member_id in pool[\u0027members\u0027]"},{"line_number":223,"context_line":"        ]"},{"line_number":224,"context_line":"        vip[\u0027health_monitors\u0027] \u003d ["},{"line_number":225,"context_line":"            self.get_health_monitor(context, hm_id)"},{"line_number":226,"context_line":"            for hm_id in pool[\u0027health_monitors\u0027]"},{"line_number":227,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV7Q%3D","line":224,"updated":"2013-05-14 05:23:31.000000000","message":"ditto","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.driver.update_vip(context, v)"},{"line_number":76,"context_line":"        return v"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _delete_db_vip(self, context, id):"},{"line_number":79,"context_line":"        super(LoadBalancerPlugin, self).delete_vip(context, id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete_vip(self, context, id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAO3%2F%2F8vw%3D","line":78,"updated":"2013-05-16 15:31:23.000000000","message":"seems unused now. If used outside the class then probably shouldn\u0027t start with \"_\"","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.driver.update_vip(context, v)"},{"line_number":76,"context_line":"        return v"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _delete_db_vip(self, context, id):"},{"line_number":79,"context_line":"        super(LoadBalancerPlugin, self).delete_vip(context, id)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete_vip(self, context, id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAPH%2F%2F7vc%3D","line":78,"in_reply_to":"AAAAO3%2F%2F8vw%3D","updated":"2013-05-19 10:55:43.000000000","message":"All those \"_\" methods are \"driver facing API\". I think a better naming convention should be used for them. Any idea?","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self.driver.update_pool(context, p)"},{"line_number":97,"context_line":"        return p"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _delete_db_pool(self, context, id):"},{"line_number":100,"context_line":"        super(LoadBalancerPlugin, self).delete_pool(context, id)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def delete_pool(self, context, id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAO3%2F%2F8vs%3D","line":99,"updated":"2013-05-16 15:31:23.000000000","message":"ditto","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":117,"context_line":"        self.driver.update_member(context, m)"},{"line_number":118,"context_line":"        return m"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _delete_db_member(self, context, id):"},{"line_number":121,"context_line":"        super(LoadBalancerPlugin, self).delete_member(context, id)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def delete_member(self, context, id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAO3%2F%2F8vo%3D","line":120,"updated":"2013-05-16 15:31:23.000000000","message":"ditto","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":"        self.driver.update_health_monitor(context, assocs, hm)"},{"line_number":159,"context_line":"        return hm"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _delete_db_health_monitor(self, context, id):"},{"line_number":162,"context_line":"        super(LoadBalancerPlugin, self).delete_health_monitor(context, id)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def delete_health_monitor(self, context, id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAO3%2F%2F8vk%3D","line":161,"updated":"2013-05-16 15:31:23.000000000","message":"ditto","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":219,"context_line":"        vip[\u0027pool\u0027] \u003d pool"},{"line_number":220,"context_line":"        vip[\u0027members\u0027] \u003d ["},{"line_number":221,"context_line":"            self.get_member(context, member_id)"},{"line_number":222,"context_line":"            for member_id in pool[\u0027members\u0027]]"},{"line_number":223,"context_line":"        vip[\u0027health_monitors\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAO3%2F%2F8sQ%3D","line":220,"updated":"2013-05-16 15:31:23.000000000","message":"Please address Aaron\u0027s comments","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":219,"context_line":"        vip[\u0027pool\u0027] \u003d pool"},{"line_number":220,"context_line":"        vip[\u0027members\u0027] \u003d ["},{"line_number":221,"context_line":"            self.get_member(context, member_id)"},{"line_number":222,"context_line":"            for member_id in pool[\u0027members\u0027]]"},{"line_number":223,"context_line":"        vip[\u0027health_monitors\u0027] \u003d ["}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAPH%2F%2F7vk%3D","line":220,"in_reply_to":"AAAAO3%2F%2F8sQ%3D","updated":"2013-05-19 10:55:43.000000000","message":"As far as I understand - I did address it in the last commit. Please let me know what i have missed.","commit_id":"b8bf97482def1d36fa18e52a9c5194b17947f876"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def delete_vip(self, context, id):"},{"line_number":80,"context_line":"        self.update_status(context, loadbalancer_db.Vip,"},{"line_number":81,"context_line":"                           id, constants.PENDING_DELETE)"},{"line_number":82,"context_line":"        v \u003d self.get_vip(context, id)"},{"line_number":83,"context_line":"        self.driver.delete_vip(context, v)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def create_pool(self, context, pool):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FeqQ%3D","line":82,"updated":"2013-06-02 12:38:34.000000000","message":"question - if there is an exception in lines 82 or 83, do you want to do a rollback for the updated status of the vip?","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    def delete_vip(self, context, id):"},{"line_number":80,"context_line":"        self.update_status(context, loadbalancer_db.Vip,"},{"line_number":81,"context_line":"                           id, constants.PENDING_DELETE)"},{"line_number":82,"context_line":"        v \u003d self.get_vip(context, id)"},{"line_number":83,"context_line":"        self.driver.delete_vip(context, v)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def create_pool(self, context, pool):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Fc%2Bs%3D","line":82,"in_reply_to":"AAAAPH%2F%2FeqQ%3D","updated":"2013-06-03 17:06:14.000000000","message":"The reason that I mark the vip with PENDING_DELETE is that I ask the driver to delete it. The driver will try to delete it but I want to make sure that from now on, the tenant will not be able manipulate this vip. Later on when the driver will be able to remove it from the \u0027device\u0027 - it will be removed from DB. if the driver will fail it will mark the vip with ERROR.\nA typical driver implementation would put the delete request in a queue and return back to the calling code","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def delete_pool(self, context, id):"},{"line_number":101,"context_line":"        self.update_status(context, loadbalancer_db.Pool,"},{"line_number":102,"context_line":"                           id, constants.PENDING_DELETE)"},{"line_number":103,"context_line":"        p \u003d self.get_pool(context, id)"},{"line_number":104,"context_line":"        self.driver.delete_pool(context, p)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def create_member(self, context, member):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FeqM%3D","line":103,"updated":"2013-06-02 12:38:34.000000000","message":"ditto","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def delete_pool(self, context, id):"},{"line_number":101,"context_line":"        self.update_status(context, loadbalancer_db.Pool,"},{"line_number":102,"context_line":"                           id, constants.PENDING_DELETE)"},{"line_number":103,"context_line":"        p \u003d self.get_pool(context, id)"},{"line_number":104,"context_line":"        self.driver.delete_pool(context, p)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def create_member(self, context, member):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Fc%2Bk%3D","line":103,"in_reply_to":"AAAAPH%2F%2FeqM%3D","updated":"2013-06-03 17:06:14.000000000","message":"ditto","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003dhm[\u0027id\u0027])"},{"line_number":151,"context_line":"            assocs \u003d qry.all()"},{"line_number":152,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":153,"context_line":"        # validate that updating all association either suceeds"},{"line_number":154,"context_line":"        # and then the health monitor status will be updated to active"},{"line_number":155,"context_line":"        # or when failed, the health monitor status will be updated to error"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FeqI%3D","line":152,"updated":"2013-06-02 12:38:34.000000000","message":"atomicaly \u003d\u003e atomically","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            )"},{"line_number":150,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003dhm[\u0027id\u0027])"},{"line_number":151,"context_line":"            assocs \u003d qry.all()"},{"line_number":152,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":153,"context_line":"        # validate that updating all association either suceeds"},{"line_number":154,"context_line":"        # and then the health monitor status will be updated to active"},{"line_number":155,"context_line":"        # or when failed, the health monitor status will be updated to error"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FdBY%3D","line":152,"in_reply_to":"AAAAPH%2F%2FeqI%3D","updated":"2013-06-03 17:06:14.000000000","message":"OK","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":150,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003dhm[\u0027id\u0027])"},{"line_number":151,"context_line":"            assocs \u003d qry.all()"},{"line_number":152,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":153,"context_line":"        # validate that updating all association either suceeds"},{"line_number":154,"context_line":"        # and then the health monitor status will be updated to active"},{"line_number":155,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":156,"context_line":"        self.driver.update_health_monitor(context, hm, assocs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FeqA%3D","line":153,"updated":"2013-06-02 12:38:34.000000000","message":"association \u003d\u003e associations","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003dhm[\u0027id\u0027])"},{"line_number":151,"context_line":"            assocs \u003d qry.all()"},{"line_number":152,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":153,"context_line":"        # validate that updating all association either suceeds"},{"line_number":154,"context_line":"        # and then the health monitor status will be updated to active"},{"line_number":155,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":156,"context_line":"        self.driver.update_health_monitor(context, hm, assocs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FdBU%3D","line":153,"in_reply_to":"AAAAPH%2F%2FeqA%3D","updated":"2013-06-03 17:06:14.000000000","message":"OK","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":166,"context_line":"            )"},{"line_number":167,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003did)"},{"line_number":168,"context_line":"            assocs \u003d qry.all()"},{"line_number":169,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":170,"context_line":"        # validate that deleting all association either suceeds"},{"line_number":171,"context_line":"        # and then the health monitor will be deleted"},{"line_number":172,"context_line":"        # or when failed, the health monitor status will be updated to error"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Fep8%3D","line":169,"updated":"2013-06-02 12:38:34.000000000","message":"ditto","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            )"},{"line_number":167,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003did)"},{"line_number":168,"context_line":"            assocs \u003d qry.all()"},{"line_number":169,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":170,"context_line":"        # validate that deleting all association either suceeds"},{"line_number":171,"context_line":"        # and then the health monitor will be deleted"},{"line_number":172,"context_line":"        # or when failed, the health monitor status will be updated to error"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FdBM%3D","line":169,"in_reply_to":"AAAAPH%2F%2Fep8%3D","updated":"2013-06-03 17:06:14.000000000","message":"OK","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":167,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003did)"},{"line_number":168,"context_line":"            assocs \u003d qry.all()"},{"line_number":169,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":170,"context_line":"        # validate that deleting all association either suceeds"},{"line_number":171,"context_line":"        # and then the health monitor will be deleted"},{"line_number":172,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":173,"context_line":"        hm \u003d self.get_health_monitor(context, id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Fep4%3D","line":170,"updated":"2013-06-02 12:38:34.000000000","message":"ditto","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            qry \u003d qry.filter_by(monitor_id\u003did)"},{"line_number":168,"context_line":"            assocs \u003d qry.all()"},{"line_number":169,"context_line":"        # It is the drivers reponsibility to atomicaly"},{"line_number":170,"context_line":"        # validate that deleting all association either suceeds"},{"line_number":171,"context_line":"        # and then the health monitor will be deleted"},{"line_number":172,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":173,"context_line":"        hm \u003d self.get_health_monitor(context, id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FdBI%3D","line":170,"in_reply_to":"AAAAPH%2F%2Fep4%3D","updated":"2013-06-03 17:06:14.000000000","message":"OK","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":211,"context_line":"                                                     pool_id)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def populate_vip_graph(self, context, vip):"},{"line_number":214,"context_line":"        \"\"\"populate the vip with: pool, members, healthmonitors.\"\"\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":217,"context_line":"        vip[\u0027pool\u0027] \u003d pool"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Fep0%3D","line":214,"updated":"2013-06-02 12:38:34.000000000","message":"populate \u003d\u003e Populate","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                                                     pool_id)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def populate_vip_graph(self, context, vip):"},{"line_number":214,"context_line":"        \"\"\"populate the vip with: pool, members, healthmonitors.\"\"\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"        pool \u003d self.get_pool(context, vip[\u0027pool_id\u0027])"},{"line_number":217,"context_line":"        vip[\u0027pool\u0027] \u003d pool"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Fc%2Bg%3D","line":214,"in_reply_to":"AAAAPH%2F%2Fep0%3D","updated":"2013-06-03 17:06:14.000000000","message":"OK","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"                  \".noop_driver.NoopLbaaSDriver\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027driver_fqn\u0027,"},{"line_number":34,"context_line":"               default\u003dDEFAULT_DRIVER,"},{"line_number":35,"context_line":"               help\u003d_(\u0027LBaaS driver Fully Qualified Name\u0027))"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2FcG4%3D","line":33,"updated":"2013-06-03 22:47:32.000000000","message":"It may better to consider using stevedore to load the driver. We can use shortname to specify a driver.\n\n\"_fqn\" is needed? Other drivers in quantum do not use this naming style (though i don\u0027t have strong opinion on it). If \"_fqn\" is used, it is better to add an description to lbaas.ini too.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                  \".noop_driver.NoopLbaaSDriver\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"lbaas_plugin_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027driver_fqn\u0027,"},{"line_number":34,"context_line":"               default\u003dDEFAULT_DRIVER,"},{"line_number":35,"context_line":"               help\u003d_(\u0027LBaaS driver Fully Qualified Name\u0027))"},{"line_number":36,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2FuU%3D","line":33,"in_reply_to":"AAAAPH%2F%2FcG4%3D","updated":"2013-06-04 12:49:36.000000000","message":"In my eyes the using stevedore is \"nice to have\" and the importutils.import_object is good enough.\nAbout the \u0027driver_fqn\u0027 - it seems (to me) that is is easy to understand that we are dealing with dynamic loading of a class when I see the \u0027fqn\u0027.\nI have added an explanation to the quantum.conf file.","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # validate that updating all associations either suceeds"},{"line_number":154,"context_line":"        # and then the health monitor status will be updated to active"},{"line_number":155,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":156,"context_line":"        self.driver.update_health_monitor(context, hm, assocs)"},{"line_number":157,"context_line":"        return hm"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _delete_db_health_monitor(self, context, id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2F7s%3D","line":156,"updated":"2013-06-04 04:23:31.000000000","message":"It should be one association per call, see comment to abstract driver","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        # validate that updating all associations either suceeds"},{"line_number":154,"context_line":"        # and then the health monitor status will be updated to active"},{"line_number":155,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":156,"context_line":"        self.driver.update_health_monitor(context, hm, assocs)"},{"line_number":157,"context_line":"        return hm"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _delete_db_health_monitor(self, context, id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2Fuw%3D","line":156,"in_reply_to":"AAAAPX%2F%2F%2F7s%3D","updated":"2013-06-04 12:49:36.000000000","message":"OK","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # and then the health monitor will be deleted"},{"line_number":172,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":173,"context_line":"        hm \u003d self.get_health_monitor(context, id)"},{"line_number":174,"context_line":"        self.driver.delete_health_monitor(context, hm, assocs)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id):"},{"line_number":177,"context_line":"        retval \u003d super(LoadBalancerPlugin, self).create_pool_health_monitor("}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2F7o%3D","line":174,"updated":"2013-06-04 04:23:31.000000000","message":"ditto","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # and then the health monitor will be deleted"},{"line_number":172,"context_line":"        # or when failed, the health monitor status will be updated to error"},{"line_number":173,"context_line":"        hm \u003d self.get_health_monitor(context, id)"},{"line_number":174,"context_line":"        self.driver.delete_health_monitor(context, hm, assocs)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id):"},{"line_number":177,"context_line":"        retval \u003d super(LoadBalancerPlugin, self).create_pool_health_monitor("}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2Fu0%3D","line":174,"in_reply_to":"AAAAPX%2F%2F%2F7o%3D","updated":"2013-06-04 12:49:36.000000000","message":"OK","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":169,"context_line":"            assocs \u003d qry.all()"},{"line_number":170,"context_line":"        hm \u003d self.get_health_monitor(context, id)"},{"line_number":171,"context_line":"        for assoc in assocs:"},{"line_number":172,"context_line":"            self.driver.delete_health_monitor(context, hm, assoc)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id):"},{"line_number":175,"context_line":"        retval \u003d super(LoadBalancerPlugin, self).create_pool_health_monitor("}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAPX%2F%2F%2FSg%3D","line":172,"updated":"2013-06-04 13:47:38.000000000","message":"I think you should use self.driver.delete_pool_health_monitor here.\nThe calls are the same for both cases.\n\nSo here it would be:\n\nself.driver.create_pool_health_monitor(\ncontext, health_monitor, assoc[\u0027pool_id\u0027])","commit_id":"24e518d3c16d3d930d6502c22c87bd4da80e150f"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            assocs \u003d qry.all()"},{"line_number":170,"context_line":"        hm \u003d self.get_health_monitor(context, id)"},{"line_number":171,"context_line":"        for assoc in assocs:"},{"line_number":172,"context_line":"            self.driver.delete_health_monitor(context, hm, assoc)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def create_pool_health_monitor(self, context, health_monitor, pool_id):"},{"line_number":175,"context_line":"        retval \u003d super(LoadBalancerPlugin, self).create_pool_health_monitor("}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAPX%2F%2F9Ro%3D","line":172,"in_reply_to":"AAAAPX%2F%2F%2FSg%3D","updated":"2013-06-05 13:09:48.000000000","message":"OK","commit_id":"24e518d3c16d3d930d6502c22c87bd4da80e150f"}],"quantum/tests/unit/db/loadbalancer/test_db_loadbalancer.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":936,"context_line":"            pool_obj \u003d ctx.session.query(ldb.Pool).filter_by(id\u003dpool_id).one()"},{"line_number":937,"context_line":"            for k, v in stats_data.items():"},{"line_number":938,"context_line":"                self.assertEqual(pool_obj.stats.__dict__[k], v)"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def test_get_pool_stats(self):"},{"line_number":941,"context_line":"        keys \u003d [(\"bytes_in\", 0),"},{"line_number":942,"context_line":"                (\"bytes_out\", 0),"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2Feps%3D","line":939,"updated":"2013-06-02 12:38:34.000000000","message":"Can you also please add in a test case when no stats data is passed in and check that the results are 0","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":936,"context_line":"            pool_obj \u003d ctx.session.query(ldb.Pool).filter_by(id\u003dpool_id).one()"},{"line_number":937,"context_line":"            for k, v in stats_data.items():"},{"line_number":938,"context_line":"                self.assertEqual(pool_obj.stats.__dict__[k], v)"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    def test_get_pool_stats(self):"},{"line_number":941,"context_line":"        keys \u003d [(\"bytes_in\", 0),"},{"line_number":942,"context_line":"                (\"bytes_out\", 0),"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPH%2F%2FdBg%3D","line":939,"in_reply_to":"AAAAPH%2F%2Feps%3D","updated":"2013-06-03 17:06:14.000000000","message":"OK","commit_id":"1ab5d1a2f03309167d02111cdfc9fa2e46a9b1f3"}],"quantum/tests/unit/services/agent_loadbalancer/test_plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Figc%3D","line":286,"updated":"2013-05-06 11:22:12.000000000","message":"?","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fibc%3D","line":286,"in_reply_to":"AAAAOn%2F%2Figc%3D","updated":"2013-05-07 07:55:18.000000000","message":"see my comment about the \u0027hack\u0027. As for this patch we have 2 lbass plugins in the code. The unit tests assumes a given some functionality from the plugin and this functionality is provided only in the Grizzly plugin. This specific test fails and was commented out. The tests will be refactored in the next patch \"step1\"","commit_id":"8a699c786c59ffcc53a3cf9833d3fb35ef164995"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiXY%3D","line":286,"updated":"2013-05-06 14:04:43.000000000","message":"do you need these?","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FiWs%3D","line":286,"in_reply_to":"AAAAOn%2F%2FiXY%3D","updated":"2013-05-07 07:55:33.000000000","message":"good question - since currently we have 2 lbaas plugins in the system there are tests that are relevant to the Grizzly lbaas plugin. Once we will have one plugin only the tests will be changed as well.","commit_id":"3a047be2120b903ec664007ee49e459fc4db2e3d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FgiA%3D","line":286,"updated":"2013-05-07 13:23:14.000000000","message":"why is this here?","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2FexE%3D","line":286,"in_reply_to":"AAAAOn%2F%2FgiA%3D","updated":"2013-05-08 12:11:06.000000000","message":"it is commented out because this test fails. It was not removed totally because in the next \"sub BP\" (multi-vendor-support-for-lbaas-step1) I will review this test and may return this test to be active.\nAs for now we have 2 lbaas plugins in the system - in the next phase we will have one and I will be able to remove the hack and the comment.","commit_id":"c4bd8f656a2332784b8da7e47b8735da036dbfd4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # we need access to loaded plugins to modify models"},{"line_number":43,"context_line":"        loaded_plugins \u003d manager.QuantumManager().get_service_plugins()"},{"line_number":44,"context_line":"        # TODO(avishayb) - below is a little hack that helps the"},{"line_number":45,"context_line":"        # test to pass :-)"},{"line_number":46,"context_line":"        # the problem is the code below assumes the existance of \u0027callbacks\u0027"},{"line_number":47,"context_line":"        # on the plugin. So the bypass is to load the plugin that has"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcX8%3D","line":44,"updated":"2013-05-09 14:42:11.000000000","message":"Hmmm... Not sure how I feel about this commit anything with the variable name \"hack\"  We\u0027ll need to think on alternatives.","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        # we need access to loaded plugins to modify models"},{"line_number":43,"context_line":"        loaded_plugins \u003d manager.QuantumManager().get_service_plugins()"},{"line_number":44,"context_line":"        # TODO(avishayb) - below is a little hack that helps the"},{"line_number":45,"context_line":"        # test to pass :-)"},{"line_number":46,"context_line":"        # the problem is the code below assumes the existance of \u0027callbacks\u0027"},{"line_number":47,"context_line":"        # on the plugin. So the bypass is to load the plugin that has"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcWs%3D","line":44,"in_reply_to":"AAAAOn%2F%2FcX8%3D","updated":"2013-05-12 13:30:38.000000000","message":"this is temporary and will be removed in step1","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcX0%3D","line":286,"updated":"2013-05-09 14:42:11.000000000","message":"Why are we commenting out this out?","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FcWo%3D","line":286,"in_reply_to":"AAAAOn%2F%2FcX0%3D","updated":"2013-05-12 13:30:38.000000000","message":"Because the test fails. In step1 we will have one lbaas plugin only. Those tests will be related to haproxy plugin only","commit_id":"1da5e6e6ac7e1b521a7417dd63a798ae18393f11"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FV7o%3D","line":286,"updated":"2013-05-14 05:23:31.000000000","message":"whoops","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        self.addCleanup(mock.patch.stopall)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    #def test_create_vip(self):"},{"line_number":287,"context_line":"    #    with self.subnet() as subnet:"},{"line_number":288,"context_line":"    #        with self.pool(subnet\u003dsubnet) as pool:"},{"line_number":289,"context_line":"    #            with self.vip(pool\u003dpool, subnet\u003dsubnet) as vip:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAO3%2F%2F9E0%3D","line":286,"in_reply_to":"AAAAOn%2F%2FV7o%3D","updated":"2013-05-16 10:37:21.000000000","message":"I have replied to this in the previous reviews.","commit_id":"d906d80c9ac4bcb06279646d5f2feb496621936b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # the problem is the code below assumes the existance of \u0027callbacks\u0027"},{"line_number":47,"context_line":"        # on the plugin. So the bypass is to load the plugin that has"},{"line_number":48,"context_line":"        # the callbacks as a member.The hack will be removed once we will"},{"line_number":49,"context_line":"        # have one lbass plugin. (we currently have 2 - (Grizzly and Havana))"},{"line_number":50,"context_line":"        hack \u003d True"},{"line_number":51,"context_line":"        if hack:"},{"line_number":52,"context_line":"            HACK_KLASS \u003d ("}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPH%2F%2FcNg%3D","line":49,"updated":"2013-06-03 21:45:53.000000000","message":"lbass - lbaas","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"9f73d02f0a302ccc55bf9e0045646515f60db61b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # the problem is the code below assumes the existance of \u0027callbacks\u0027"},{"line_number":47,"context_line":"        # on the plugin. So the bypass is to load the plugin that has"},{"line_number":48,"context_line":"        # the callbacks as a member.The hack will be removed once we will"},{"line_number":49,"context_line":"        # have one lbass plugin. (we currently have 2 - (Grizzly and Havana))"},{"line_number":50,"context_line":"        hack \u003d True"},{"line_number":51,"context_line":"        if hack:"},{"line_number":52,"context_line":"            HACK_KLASS \u003d ("}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAPX%2F%2F%2FwE%3D","line":49,"in_reply_to":"AAAAPH%2F%2FcNg%3D","updated":"2013-06-04 12:49:36.000000000","message":"OK","commit_id":"252df7012b95fe723c745a51658ef90e09ce6d10"}]}
