)]}'
{"neutron/plugins/ml2/db.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"d6278e49f5329e85fac6517d96579da7ae6082e7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    return bindings"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"def is_ha_port(session, port):"},{"line_number":368,"context_line":"    if port[\u0027device_owner\u0027] !\u003d n_const.DEVICE_OWNER_ROUTER_INTF:"},{"line_number":369,"context_line":"        return False"},{"line_number":370,"context_line":"    query \u003d session.query(l3_hamode_db.L3HARouterAgentPortBinding)"},{"line_number":371,"context_line":"    ha_routers \u003d [router.router_id for router in query.all()]"},{"line_number":372,"context_line":"    if len(ha_routers):"},{"line_number":373,"context_line":"        if port[\u0027device_id\u0027] in ha_routers:"},{"line_number":374,"context_line":"            return True"},{"line_number":375,"context_line":"    return False"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"def get_ha_router_hosts(session, router_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_a46d4d9a","line":375,"range":{"start_line":367,"start_character":0,"end_line":375,"end_character":16},"updated":"2016-03-02 13:40:44.000000000","message":"You have the same code in https://review.openstack.org/#/c/255237/15/neutron/plugins/ml2/drivers/l2pop/db.py May be made this changes connected and use this method from one place? Duplication is not the right decision.","commit_id":"dfc0af3be5f33cbb2944c3720c9a655ddc00cb48"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"36a644dc7c936a88ffc550847d9380b8966c8576","unresolved":false,"context_lines":[{"line_number":367,"context_line":"def is_ha_port(session, port):"},{"line_number":368,"context_line":"    if port[\u0027device_owner\u0027] !\u003d n_const.DEVICE_OWNER_ROUTER_INTF:"},{"line_number":369,"context_line":"        return False"},{"line_number":370,"context_line":"    query \u003d session.query(l3_hamode_db.L3HARouterAgentPortBinding)"},{"line_number":371,"context_line":"    ha_routers \u003d [router.router_id for router in query.all()]"},{"line_number":372,"context_line":"    if len(ha_routers):"},{"line_number":373,"context_line":"        if port[\u0027device_id\u0027] in ha_routers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_8c6de19a","line":370,"updated":"2016-03-08 14:29:14.000000000","message":"Why not filter here using a where clause instead of lines 371 to 374?","commit_id":"d5327df4f8cbc2dbec629f2a7817bfcedbb8ca1e"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"17f5760690b800ca8d9b8b7675032549dd93504b","unresolved":false,"context_lines":[{"line_number":367,"context_line":"def is_ha_port(session, port):"},{"line_number":368,"context_line":"    if port[\u0027device_owner\u0027] !\u003d n_const.DEVICE_OWNER_ROUTER_INTF:"},{"line_number":369,"context_line":"        return False"},{"line_number":370,"context_line":"    query \u003d session.query(l3_hamode_db.L3HARouterAgentPortBinding)"},{"line_number":371,"context_line":"    ha_routers \u003d [router.router_id for router in query.all()]"},{"line_number":372,"context_line":"    if len(ha_routers):"},{"line_number":373,"context_line":"        if port[\u0027device_id\u0027] in ha_routers:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_51fa0876","line":370,"in_reply_to":"5aef4532_8c6de19a","updated":"2016-03-09 16:41:54.000000000","message":"In fact, isn\u0027t there a version of this function (defined as is_ha_router_port()) in you other patch here: https://review.openstack.org/#/c/255237/17/neutron/plugins/ml2/drivers/l2pop/db.py ?","commit_id":"d5327df4f8cbc2dbec629f2a7817bfcedbb8ca1e"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"280e5506f3e6f15a2b3859890e77c170a26cdf1c","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":1621,"context_line":"            query \u003d context.session.query("},{"line_number":1622,"context_line":"                l3_hamode_db.L3HARouterAgentPortBinding)"},{"line_number":1623,"context_line":"            ha_host \u003d query.join(agents_db.Agent).filter("},{"line_number":1624,"context_line":"                agents_db.Agent.host \u003d\u003d host,"},{"line_number":1625,"context_line":"                l3_hamode_db.L3HARouterAgentPortBinding.router_id \u003d\u003d"},{"line_number":1626,"context_line":"                port[\u0027device_id\u0027]).first()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_6fec9e8f","line":1623,"updated":"2016-04-06 07:59:07.000000000","message":"could we extract this to a separate function in the db layer as for L1632 ?","commit_id":"73355fcb7d66346ddfc15825811d654b68b9fd53"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"62d7ebf605e7c4e0bab38d6475cbd010add03546","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_HA_REPLICATED_INT:"},{"line_number":1621,"context_line":"            query \u003d context.session.query("},{"line_number":1622,"context_line":"                l3_hamode_db.L3HARouterAgentPortBinding)"},{"line_number":1623,"context_line":"            ha_host \u003d query.join(agents_db.Agent).filter("},{"line_number":1624,"context_line":"                agents_db.Agent.host \u003d\u003d host,"},{"line_number":1625,"context_line":"                l3_hamode_db.L3HARouterAgentPortBinding.router_id \u003d\u003d"},{"line_number":1626,"context_line":"                port[\u0027device_id\u0027]).first()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_aaf4e486","line":1623,"in_reply_to":"9a061dce_6fec9e8f","updated":"2016-04-06 08:14:03.000000000","message":"sure","commit_id":"73355fcb7d66346ddfc15825811d654b68b9fd53"}]}