)]}'
{"neutron/tests/api/test_network_ip_availability.py":[{"author":{"_account_id":10962,"name":"David Bingham","email":"dbingham@godaddy.com","username":"wwriverrat"},"change_message_id":"2f3af515d84d470ac62d0bcc21ccaf29203e6815","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DEFAULT_IP_CONSUMED \u003d 3"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class NetworksIpAvailabilityTestJSON(base.BaseNetworkTest):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_994bab59","line":26,"updated":"2016-02-25 18:41:34.000000000","message":"If it were me, I\u0027d add a note above this def something like: # Default number of reserved ips taken from a subnet cidr when subnet defined.","commit_id":"b542dfe4f75c19ed2952a2f3779931f589dbd938"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0ae6e6d0afc05c0cce69b4b3d74106498c7a63d8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":69,"context_line":"        for ext in exts:"},{"line_number":70,"context_line":"            if ext[\u0027alias\u0027] \u003d\u003d ext_name:"},{"line_number":71,"context_line":"                ext_status \u003d True"},{"line_number":72,"context_line":"                break"},{"line_number":73,"context_line":"        return ext_status"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_a49e7504","line":71,"updated":"2016-02-24 08:42:13.000000000","message":"return True, no need for the break and no need to keep a variable","commit_id":"b542dfe4f75c19ed2952a2f3779931f589dbd938"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0ae6e6d0afc05c0cce69b4b3d74106498c7a63d8","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            if ext[\u0027alias\u0027] \u003d\u003d ext_name:"},{"line_number":71,"context_line":"                ext_status \u003d True"},{"line_number":72,"context_line":"                break"},{"line_number":73,"context_line":"        return ext_status"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @classmethod"},{"line_number":76,"context_line":"    def _delete_network(self, network):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_e48cfddb","line":73,"updated":"2016-02-24 08:42:13.000000000","message":"return False","commit_id":"b542dfe4f75c19ed2952a2f3779931f589dbd938"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0ae6e6d0afc05c0cce69b4b3d74106498c7a63d8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    return total_ips"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class NetworksIpAvailabilityIPv4TestJSON(NetworksIpAvailabilityTestJSON):"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":98,"context_line":"    @test.idempotent_id(\u00270f33cc8c-1bf6-47d1-9ce1-010618240599\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_2406e51f","line":95,"updated":"2016-02-24 08:42:13.000000000","message":"You\u0027ll want some tests that create ports and verifies that the IP availability decreases after, and also when you delete ports it increases.","commit_id":"b542dfe4f75c19ed2952a2f3779931f589dbd938"},{"author":{"_account_id":10962,"name":"David Bingham","email":"dbingham@godaddy.com","username":"wwriverrat"},"change_message_id":"2f3af515d84d470ac62d0bcc21ccaf29203e6815","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class NetworksIpAvailabilityIPv6TestJSON(NetworksIpAvailabilityTestJSON):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":133,"context_line":"    @test.idempotent_id(\u002733b78891-6fbb-4a51-9cf7-3fb782fb3c4d\u0027)"},{"line_number":134,"context_line":"    def test_admin_list_network_ipv6_availability_after_subnet(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_f9d597b9","line":131,"updated":"2016-02-25 18:41:34.000000000","message":"Add this here:\n\nip_version \u003d 6\n\n\nThis will put to good use line 52 above.","commit_id":"b542dfe4f75c19ed2952a2f3779931f589dbd938"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        test total and used ips for net create before subnet"},{"line_number":37,"context_line":"        test total ips for net after subnet create"},{"line_number":38,"context_line":"        test total and used ips for net after subnet and port create"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_1203ed74","line":38,"updated":"2016-02-25 20:56:19.000000000","message":"you should also test total/used ips after port/subnet/network delete","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7da20064b0b905830bfad4d7117283e8b3a0f10a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        test total and used ips for net create before subnet"},{"line_number":37,"context_line":"        test total ips for net after subnet create"},{"line_number":38,"context_line":"        test total and used ips for net after subnet and port create"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_b7b66e3b","line":38,"in_reply_to":"9aed3d3a_1203ed74","updated":"2016-02-25 22:09:01.000000000","message":"i realize you don\u0027t need to do this in API tests but in unittests :)","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"},{"line_number":44,"context_line":"        super(NetworksIpAvailabilityTestJSON, cls).resource_setup()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def _create_subnet(self, network, ip_version):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_17ec7fc6","line":44,"range":{"start_line":44,"start_character":14,"end_line":44,"end_character":44},"updated":"2016-02-25 20:56:19.000000000","message":"we don\u0027t need this","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def resource_setup(cls):"},{"line_number":44,"context_line":"        super(NetworksIpAvailabilityTestJSON, cls).resource_setup()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def _create_subnet(self, network, ip_version):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_97c40a93","line":44,"range":{"start_line":44,"start_character":14,"end_line":44,"end_character":44},"in_reply_to":"9aed3d3a_17ec7fc6","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def _create_subnet(self, network, ip_version):"},{"line_number":48,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":49,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720.0.0.0/24\u0027)"},{"line_number":50,"context_line":"            mask_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":51,"context_line":"        elif ip_version \u003d\u003d 6:"},{"line_number":52,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720:db8::/64\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_72afd9e3","line":49,"range":{"start_line":49,"start_character":27,"end_line":49,"end_character":36},"updated":"2016-02-25 20:56:19.000000000","message":"Why not using CONF.network.tenant_network_cidr?","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def _create_subnet(self, network, ip_version):"},{"line_number":48,"context_line":"        if ip_version \u003d\u003d 4:"},{"line_number":49,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720.0.0.0/24\u0027)"},{"line_number":50,"context_line":"            mask_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":51,"context_line":"        elif ip_version \u003d\u003d 6:"},{"line_number":52,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720:db8::/64\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_1a7e5ae4","line":49,"range":{"start_line":49,"start_character":27,"end_line":49,"end_character":36},"in_reply_to":"9aed3d3a_72afd9e3","updated":"2016-02-26 01:06:02.000000000","message":"I doubt the cleanup done in other tests which I did not write tests. I wanted a fresh clean cidr which is never used that\u0027s the reason i used this.","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720.0.0.0/24\u0027)"},{"line_number":50,"context_line":"            mask_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":51,"context_line":"        elif ip_version \u003d\u003d 6:"},{"line_number":52,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720:db8::/64\u0027)"},{"line_number":53,"context_line":"            mask_bits \u003d CONF.network.tenant_network_v6_mask_bits"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        subnet_cidr \u003d list(cidr.subnet(mask_bits))[-1]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_d286a564","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":36},"updated":"2016-02-25 20:56:19.000000000","message":"Why not using CONF.network.tenant_network_V6_cidr?","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720.0.0.0/24\u0027)"},{"line_number":50,"context_line":"            mask_bits \u003d CONF.network.tenant_network_mask_bits"},{"line_number":51,"context_line":"        elif ip_version \u003d\u003d 6:"},{"line_number":52,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720:db8::/64\u0027)"},{"line_number":53,"context_line":"            mask_bits \u003d CONF.network.tenant_network_v6_mask_bits"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        subnet_cidr \u003d list(cidr.subnet(mask_bits))[-1]"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_fa773600","line":52,"range":{"start_line":52,"start_character":27,"end_line":52,"end_character":36},"in_reply_to":"9aed3d3a_d286a564","updated":"2016-02-26 01:06:02.000000000","message":"same reason here wanted cidr on which ports were never created.","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720:db8::/64\u0027)"},{"line_number":53,"context_line":"            mask_bits \u003d CONF.network.tenant_network_v6_mask_bits"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        subnet_cidr \u003d list(cidr.subnet(mask_bits))[-1]"},{"line_number":56,"context_line":"        prefix_len \u003d subnet_cidr.prefixlen"},{"line_number":57,"context_line":"        gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":58,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dgateway_ip,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_72419939","line":55,"updated":"2016-02-25 20:56:19.000000000","message":"Why not the following which avoids to compute every \"sub\"-cidr?\n\n subnet_cidr \u003d cidr.subnet(mask_bits).next()","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            cidr \u003d netaddr.IPNetwork(\u002720:db8::/64\u0027)"},{"line_number":53,"context_line":"            mask_bits \u003d CONF.network.tenant_network_v6_mask_bits"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        subnet_cidr \u003d list(cidr.subnet(mask_bits))[-1]"},{"line_number":56,"context_line":"        prefix_len \u003d subnet_cidr.prefixlen"},{"line_number":57,"context_line":"        gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":58,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dgateway_ip,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_badbeeec","line":55,"in_reply_to":"9aed3d3a_72419939","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        subnet_cidr \u003d list(cidr.subnet(mask_bits))[-1]"},{"line_number":56,"context_line":"        prefix_len \u003d subnet_cidr.prefixlen"},{"line_number":57,"context_line":"        gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":58,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dgateway_ip,"},{"line_number":59,"context_line":"                                    cidr\u003dsubnet_cidr, mask_bits\u003dmask_bits,"},{"line_number":60,"context_line":"                                    ip_version\u003dip_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_320f11e3","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":32},"updated":"2016-02-25 20:56:19.000000000","message":"gateway_ip \u003d str(subnet_cidr.ip + 1)","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        subnet_cidr \u003d list(cidr.subnet(mask_bits))[-1]"},{"line_number":56,"context_line":"        prefix_len \u003d subnet_cidr.prefixlen"},{"line_number":57,"context_line":"        gateway_ip \u003d str(netaddr.IPAddress(subnet_cidr) + 1)"},{"line_number":58,"context_line":"        subnet \u003d self.create_subnet(network, gateway\u003dgateway_ip,"},{"line_number":59,"context_line":"                                    cidr\u003dsubnet_cidr, mask_bits\u003dmask_bits,"},{"line_number":60,"context_line":"                                    ip_version\u003dip_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_3aeebe8b","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":32},"in_reply_to":"9aed3d3a_320f11e3","updated":"2016-02-26 01:06:02.000000000","message":"actually i don\u0027t even need it default one will handle this","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def is_extension_loaded(self, ext_name):"},{"line_number":65,"context_line":"        loaded_extensions \u003d self.client.list_extensions()"},{"line_number":66,"context_line":"        exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":67,"context_line":"        for ext in exts:"},{"line_number":68,"context_line":"            if ext[\u0027alias\u0027] \u003d\u003d ext_name:"},{"line_number":69,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_521d750e","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":32},"updated":"2016-02-25 20:56:19.000000000","message":"prefer:\n\n return any(ext[\u0027alias\u0027] \u003d\u003d ext_name if ext in exts)","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def is_extension_loaded(self, ext_name):"},{"line_number":65,"context_line":"        loaded_extensions \u003d self.client.list_extensions()"},{"line_number":66,"context_line":"        exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":67,"context_line":"        for ext in exts:"},{"line_number":68,"context_line":"            if ext[\u0027alias\u0027] \u003d\u003d ext_name:"},{"line_number":69,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_7ae8467d","line":66,"range":{"start_line":66,"start_character":15,"end_line":66,"end_character":32},"in_reply_to":"9aed3d3a_521d750e","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                return True"},{"line_number":70,"context_line":"        return False"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def _delete_network(self, network):"},{"line_number":74,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":75,"context_line":"        self.client.delete_network(network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_f22ac9e6","line":72,"updated":"2016-02-25 20:56:19.000000000","message":"classmethod?","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                return True"},{"line_number":70,"context_line":"        return False"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def _delete_network(self, network):"},{"line_number":74,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":75,"context_line":"        self.client.delete_network(network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_5aed828a","line":72,"in_reply_to":"9aed3d3a_f22ac9e6","updated":"2016-02-26 01:06:02.000000000","message":"my bad removed","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def _delete_network(self, network):"},{"line_number":74,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":75,"context_line":"        self.client.delete_network(network[\u0027id\u0027])"},{"line_number":76,"context_line":"        if network in self.networks:"},{"line_number":77,"context_line":"            self.networks.remove(network)"},{"line_number":78,"context_line":"        for subnet in self.subnets:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_b24961d3","line":75,"updated":"2016-02-25 20:56:19.000000000","message":"what if any instruction in this method fails?","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @classmethod"},{"line_number":73,"context_line":"    def _delete_network(self, network):"},{"line_number":74,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":75,"context_line":"        self.client.delete_network(network[\u0027id\u0027])"},{"line_number":76,"context_line":"        if network in self.networks:"},{"line_number":77,"context_line":"            self.networks.remove(network)"},{"line_number":78,"context_line":"        for subnet in self.subnets:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_daf9924f","line":75,"in_reply_to":"9aed3d3a_b24961d3","updated":"2016-02-26 01:06:02.000000000","message":"I used this from api/test_networks.py. that\u0027s question to improve there as well","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"52a3d3c64c018e812020616f36b8588d0300b1fb","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":84,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":85,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":86,"context_line":"        total_ips \u003d (2 ** (32 - prefix)) - DEFAULT_IP4_CONSUMED"},{"line_number":87,"context_line":"    elif ip_version \u003d\u003d 6:"},{"line_number":88,"context_line":"        total_ips \u003d (2 ** (128 - prefix)) - DEFAULT_IP6_CONSUMED"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_b2aa0118","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":22},"updated":"2016-02-25 21:11:24.000000000","message":"You could use the constants.IPV4 for this for consistency.\n\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L78","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":84,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":85,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":86,"context_line":"        total_ips \u003d (2 ** (32 - prefix)) - DEFAULT_IP4_CONSUMED"},{"line_number":87,"context_line":"    elif ip_version \u003d\u003d 6:"},{"line_number":88,"context_line":"        total_ips \u003d (2 ** (128 - prefix)) - DEFAULT_IP6_CONSUMED"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_3a951ee4","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":22},"in_reply_to":"9aed3d3a_b2aa0118","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":84,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":85,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":86,"context_line":"        total_ips \u003d (2 ** (32 - prefix)) - DEFAULT_IP4_CONSUMED"},{"line_number":87,"context_line":"    elif ip_version \u003d\u003d 6:"},{"line_number":88,"context_line":"        total_ips \u003d (2 ** (128 - prefix)) - DEFAULT_IP6_CONSUMED"},{"line_number":89,"context_line":"    return total_ips"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_12b5adcc","line":86,"updated":"2016-02-25 20:56:19.000000000","message":"useless braces","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":83,"context_line":"def calc_total_ips(prefix, ip_version):"},{"line_number":84,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":85,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":86,"context_line":"        total_ips \u003d (2 ** (32 - prefix)) - DEFAULT_IP4_CONSUMED"},{"line_number":87,"context_line":"    elif ip_version \u003d\u003d 6:"},{"line_number":88,"context_line":"        total_ips \u003d (2 ** (128 - prefix)) - DEFAULT_IP6_CONSUMED"},{"line_number":89,"context_line":"    return total_ips"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_1a9ada14","line":86,"in_reply_to":"9aed3d3a_12b5adcc","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"52a3d3c64c018e812020616f36b8588d0300b1fb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":85,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":86,"context_line":"        total_ips \u003d (2 ** (32 - prefix)) - DEFAULT_IP4_CONSUMED"},{"line_number":87,"context_line":"    elif ip_version \u003d\u003d 6:"},{"line_number":88,"context_line":"        total_ips \u003d (2 ** (128 - prefix)) - DEFAULT_IP6_CONSUMED"},{"line_number":89,"context_line":"    return total_ips"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_f2492990","line":87,"range":{"start_line":87,"start_character":23,"end_line":87,"end_character":24},"updated":"2016-02-25 21:11:24.000000000","message":"Same with my above comment.  Using the constants would be nice.","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    # will calculate total ips after removing reserved."},{"line_number":85,"context_line":"    if ip_version \u003d\u003d 4:"},{"line_number":86,"context_line":"        total_ips \u003d (2 ** (32 - prefix)) - DEFAULT_IP4_CONSUMED"},{"line_number":87,"context_line":"    elif ip_version \u003d\u003d 6:"},{"line_number":88,"context_line":"        total_ips \u003d (2 ** (128 - prefix)) - DEFAULT_IP6_CONSUMED"},{"line_number":89,"context_line":"    return total_ips"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_7a9fa603","line":87,"range":{"start_line":87,"start_character":23,"end_line":87,"end_character":24},"in_reply_to":"9aed3d3a_f2492990","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"52a3d3c64c018e812020616f36b8588d0300b1fb","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        net_name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":116,"context_line":"        network \u003d self.create_network(network_name\u003dnet_name)"},{"line_number":117,"context_line":"        self.addCleanup(self._delete_network, network)"},{"line_number":118,"context_line":"        subnet, prefix \u003d self._create_subnet(network, 4)"},{"line_number":119,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":120,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":121,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_6ddd3c70","line":118,"range":{"start_line":118,"start_character":54,"end_line":118,"end_character":55},"updated":"2016-02-25 21:11:24.000000000","message":"https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L78","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        net_name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":116,"context_line":"        network \u003d self.create_network(network_name\u003dnet_name)"},{"line_number":117,"context_line":"        self.addCleanup(self._delete_network, network)"},{"line_number":118,"context_line":"        subnet, prefix \u003d self._create_subnet(network, 4)"},{"line_number":119,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":120,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":121,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_5aa46256","line":118,"range":{"start_line":118,"start_character":54,"end_line":118,"end_character":55},"in_reply_to":"9aed3d3a_6ddd3c70","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":128,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":129,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":130,"context_line":"                self.assertEqual(availability[\u0027total_ips\u0027],"},{"line_number":131,"context_line":"                                 calc_total_ips(prefix, 4))"},{"line_number":132,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":133,"context_line":"                self.assertEqual(availability[\u0027used_ips\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_7295193f","line":130,"range":{"start_line":130,"start_character":21,"end_line":130,"end_character":32},"updated":"2016-02-25 20:56:19.000000000","message":"it should be the opposite:\n\n self.assertEqual(expected, observed)","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":128,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":129,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":130,"context_line":"                self.assertEqual(availability[\u0027total_ips\u0027],"},{"line_number":131,"context_line":"                                 calc_total_ips(prefix, 4))"},{"line_number":132,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":133,"context_line":"                self.assertEqual(availability[\u0027used_ips\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_ba892ecd","line":130,"range":{"start_line":130,"start_character":21,"end_line":130,"end_character":32},"in_reply_to":"9aed3d3a_7295193f","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":140,"context_line":"    @test.idempotent_id(\u002733b78891-6fbb-4a51-9cf7-3fb782fb3c4d\u0027)"},{"line_number":141,"context_line":"    def test_admin_list_network_ipv6_availability_after_subnet(self):"},{"line_number":142,"context_line":"        if not self.is_extension_loaded(\u0027network-ip-availability\u0027):"},{"line_number":143,"context_line":"            self.skipTest(\"net ip availability extension not loaded\")"},{"line_number":144,"context_line":"        net_name \u003d data_utils.rand_name(\u0027network-\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_b2ade18a","line":141,"updated":"2016-02-25 20:56:19.000000000","message":"it seems you can avoid to duplicate the test code","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":140,"context_line":"    @test.idempotent_id(\u002733b78891-6fbb-4a51-9cf7-3fb782fb3c4d\u0027)"},{"line_number":141,"context_line":"    def test_admin_list_network_ipv6_availability_after_subnet(self):"},{"line_number":142,"context_line":"        if not self.is_extension_loaded(\u0027network-ip-availability\u0027):"},{"line_number":143,"context_line":"            self.skipTest(\"net ip availability extension not loaded\")"},{"line_number":144,"context_line":"        net_name \u003d data_utils.rand_name(\u0027network-\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_9a86eab7","line":141,"in_reply_to":"9aed3d3a_b2ade18a","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"52a3d3c64c018e812020616f36b8588d0300b1fb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        net_name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":145,"context_line":"        network \u003d self.create_network(network_name\u003dnet_name)"},{"line_number":146,"context_line":"        self.addCleanup(self._delete_network, network)"},{"line_number":147,"context_line":"        subnet, prefix \u003d self._create_subnet(network, 6)"},{"line_number":148,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":149,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":150,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_d21ce579","line":147,"range":{"start_line":147,"start_character":54,"end_line":147,"end_character":55},"updated":"2016-02-25 21:11:24.000000000","message":"Same with above comments about constants.","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        net_name \u003d data_utils.rand_name(\u0027network-\u0027)"},{"line_number":145,"context_line":"        network \u003d self.create_network(network_name\u003dnet_name)"},{"line_number":146,"context_line":"        self.addCleanup(self._delete_network, network)"},{"line_number":147,"context_line":"        subnet, prefix \u003d self._create_subnet(network, 6)"},{"line_number":148,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":149,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":150,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_da9072ef","line":147,"range":{"start_line":147,"start_character":54,"end_line":147,"end_character":55},"in_reply_to":"9aed3d3a_d21ce579","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f54df51f542bde15476f1172f5ab21a788c984b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        availabilities \u003d body[\u0027network_ip_availabilities\u0027]"},{"line_number":158,"context_line":"        for availability in availabilities:"},{"line_number":159,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":160,"context_line":"                self.assertEqual(availability[\u0027total_ips\u0027],"},{"line_number":161,"context_line":"                                 calc_total_ips(prefix, 6))"},{"line_number":162,"context_line":"                self.assertEqual(availability[\u0027used_ips\u0027],"},{"line_number":163,"context_line":"                                 used_ip + 2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_929c1d6b","line":160,"range":{"start_line":160,"start_character":21,"end_line":160,"end_character":32},"updated":"2016-02-25 20:56:19.000000000","message":"itto","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        availabilities \u003d body[\u0027network_ip_availabilities\u0027]"},{"line_number":158,"context_line":"        for availability in availabilities:"},{"line_number":159,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":160,"context_line":"                self.assertEqual(availability[\u0027total_ips\u0027],"},{"line_number":161,"context_line":"                                 calc_total_ips(prefix, 6))"},{"line_number":162,"context_line":"                self.assertEqual(availability[\u0027used_ips\u0027],"},{"line_number":163,"context_line":"                                 used_ip + 2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_3abcfe6b","line":160,"range":{"start_line":160,"start_character":21,"end_line":160,"end_character":32},"in_reply_to":"9aed3d3a_929c1d6b","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"52a3d3c64c018e812020616f36b8588d0300b1fb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        for availability in availabilities:"},{"line_number":159,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":160,"context_line":"                self.assertEqual(availability[\u0027total_ips\u0027],"},{"line_number":161,"context_line":"                                 calc_total_ips(prefix, 6))"},{"line_number":162,"context_line":"                self.assertEqual(availability[\u0027used_ips\u0027],"},{"line_number":163,"context_line":"                                 used_ip + 2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_adbe24fd","line":161,"range":{"start_line":161,"start_character":56,"end_line":161,"end_character":57},"updated":"2016-02-25 21:11:24.000000000","message":"Same with above comments about constants.","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9a79f7643c7ca42eacdad022bcc7e04b8af4dce","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        for availability in availabilities:"},{"line_number":159,"context_line":"            if availability[\u0027id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":160,"context_line":"                self.assertEqual(availability[\u0027total_ips\u0027],"},{"line_number":161,"context_line":"                                 calc_total_ips(prefix, 6))"},{"line_number":162,"context_line":"                self.assertEqual(availability[\u0027used_ips\u0027],"},{"line_number":163,"context_line":"                                 used_ip + 2)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_1ac13ae5","line":161,"range":{"start_line":161,"start_character":56,"end_line":161,"end_character":57},"in_reply_to":"9aed3d3a_adbe24fd","updated":"2016-02-26 01:06:02.000000000","message":"Done","commit_id":"34afc5a237c2e28a7005511cb1d14eed60c34a46"},{"author":{"_account_id":10962,"name":"David Bingham","email":"dbingham@godaddy.com","username":"wwriverrat"},"change_message_id":"05739e1bfc2fda6068a89f76f28955ff4ad2be5c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":"from tempest_lib.common.utils import data_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.tests.api import base"},{"line_number":22,"context_line":"from neutron.tests.tempest import config"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_d7579100","line":19,"updated":"2016-03-02 01:15:17.000000000","message":"Stack trace from gate-neutron-dsvm-api says: \"ImportError: No module named tempest_lib.common.utils\".\n\nCheck the path to see if it is correct or if it has moved?\n\nRef: http://logs.openstack.org/57/283357/10/check/gate-neutron-dsvm-api/cd346a4/console.html","commit_id":"b69de6316caa49bd46d2831a075243ccfe520025"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7f7b7b8b104518f9ee0ac402b8f7c0e61547e1cf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":"from tempest_lib.common.utils import data_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.tests.api import base"},{"line_number":22,"context_line":"from neutron.tests.tempest import config"}],"source_content_type":"text/x-python","patch_set":10,"id":"7af24918_5ae608b5","line":19,"in_reply_to":"7af24918_d7579100","updated":"2016-03-02 02:01:07.000000000","message":"Done thanks !","commit_id":"b69de6316caa49bd46d2831a075243ccfe520025"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b699dc6a914df8e0206007ecc7e83f78e9756cc1","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def is_extension_loaded(self, ext_name):"},{"line_number":65,"context_line":"        loaded_extensions \u003d self.client.list_extensions()"},{"line_number":66,"context_line":"        exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":67,"context_line":"        return any(ext[\u0027alias\u0027] \u003d\u003d ext_name for ext in exts)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_a8c6a246","line":65,"updated":"2016-03-02 20:11:58.000000000","message":"you should not check the extensions like so and use the skip_checks classmethod to skip the tests. You don\u0027t need this method at all.\n\nhttps://github.com/openstack/tempest/blob/master/tempest/test.py#L206","commit_id":"90c07d0f93bb9c35988627b24b5e7da8f57394eb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"082d81b889a2171aa452c68b1aab0215d83990ec","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def is_extension_loaded(self, ext_name):"},{"line_number":65,"context_line":"        loaded_extensions \u003d self.client.list_extensions()"},{"line_number":66,"context_line":"        exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":67,"context_line":"        return any(ext[\u0027alias\u0027] \u003d\u003d ext_name for ext in exts)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_2267464e","line":65,"in_reply_to":"7af24918_a8c6a246","updated":"2016-03-02 23:00:55.000000000","message":"already existing method https://github.com/openstack/tempest/blob/master/tempest/test.py#L163 will return true after reading all from tempest.conf so test will end in failure badly even when extension is not loaded. that\u0027s the reason i had this method. \n\nI like the idea to have skip_check but any way I need to override it. how about having this \n\ndef setUp(self):\n      if not self.is_extension_loaded(\u0027network-ip-availability\u0027):\n       self.skipTest(\"net ip availability extension not loaded\")\n\n??","commit_id":"90c07d0f93bb9c35988627b24b5e7da8f57394eb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b699dc6a914df8e0206007ecc7e83f78e9756cc1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":67,"context_line":"        return any(ext[\u0027alias\u0027] \u003d\u003d ext_name for ext in exts)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _delete_network(self, network):"},{"line_number":70,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":71,"context_line":"        self.client.delete_network(network[\u0027id\u0027])"},{"line_number":72,"context_line":"        if network in self.networks:"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_e8454ab3","line":69,"updated":"2016-03-02 20:11:58.000000000","message":"there\u0027s a resource cleanup method. Please use it.\n\nThere are plenty of good examples about how to do this properly. [1] is one of them\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/api/test_routers.py","commit_id":"90c07d0f93bb9c35988627b24b5e7da8f57394eb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"082d81b889a2171aa452c68b1aab0215d83990ec","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":67,"context_line":"        return any(ext[\u0027alias\u0027] \u003d\u003d ext_name for ext in exts)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _delete_network(self, network):"},{"line_number":70,"context_line":"        # Deleting network also deletes its subnets if exists"},{"line_number":71,"context_line":"        self.client.delete_network(network[\u0027id\u0027])"},{"line_number":72,"context_line":"        if network in self.networks:"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_9ecde05f","line":69,"in_reply_to":"7af24918_e8454ab3","updated":"2016-03-02 23:00:55.000000000","message":"Clean up method asks for a delete method this was the approach being used in test_networks.py this method is given to cleanup.","commit_id":"90c07d0f93bb9c35988627b24b5e7da8f57394eb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"192a3bdf8c20865ef415ad9c970cef010a5eb466","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return subnet, prefix_len"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def is_extension_loaded(client, ext_name):"},{"line_number":73,"context_line":"    loaded_extensions \u003d client.list_extensions()"},{"line_number":74,"context_line":"    exts \u003d loaded_extensions[\u0027extensions\u0027]"},{"line_number":75,"context_line":"    return any(ext[\u0027alias\u0027] \u003d\u003d ext_name for ext in exts)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7af24918_6d7f3ee0","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":23},"updated":"2016-03-03 19:56:39.000000000","message":"the reason why I used this function is . function test.is_extension_enabled will read tempest.conf and after reading api_extension \u003d all from conf files return true no matter which extension is there or not. so having this function will check actual environment and it can prevent future gate failures.","commit_id":"c26f3be75b41ec76bf5579481506551b072fd3aa"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"caa815e0000f8e23e6a9db400f17301061d1ba8f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEFAULT_IP6_RESERVED \u003d 2"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class NetworksIpAvailabilityTestJSON(base.BaseAdminNetworkTest):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    Tests the following operations in the Neutron API using the REST client for"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_6a3ebc2a","line":36,"updated":"2016-03-04 22:48:25.000000000","message":"drop the json suffix, there\u0027s no point in it.","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"42b3563d98ba9f1e20e16d304f21886a22607cd2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEFAULT_IP6_RESERVED \u003d 2"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class NetworksIpAvailabilityTestJSON(base.BaseAdminNetworkTest):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    Tests the following operations in the Neutron API using the REST client for"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_e7d817f2","line":36,"in_reply_to":"7af24918_6a3ebc2a","updated":"2016-03-08 05:59:10.000000000","message":"Done","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7de88421a06dcba429a63858f738ec534cfd0d55","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def resource_setup(cls):"},{"line_number":50,"context_line":"        super(NetworksIpAvailabilityTestJSON, cls).resource_setup()"},{"line_number":51,"context_line":"        if not is_extension_loaded(cls.client, \u0027network-ip-availability\u0027):"},{"line_number":52,"context_line":"            msg \u003d \"network-ip-availability extension not enabled.\""},{"line_number":53,"context_line":"            raise cls.skipException(msg)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_0d7b1ac2","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":34},"updated":"2016-03-03 19:59:18.000000000","message":"the reason why I used this function is . function test.is_extension_enabled will read tempest.conf and after reading api_extension \u003d all from conf files return true no matter which extension is there or not. so having this function will check actual environment and it can prevent future gate failures.","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3632996201ecd550b9d10701f481939b776c25d9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def resource_setup(cls):"},{"line_number":50,"context_line":"        super(NetworksIpAvailabilityTestJSON, cls).resource_setup()"},{"line_number":51,"context_line":"        if not is_extension_loaded(cls.client, \u0027network-ip-availability\u0027):"},{"line_number":52,"context_line":"            msg \u003d \"network-ip-availability extension not enabled.\""},{"line_number":53,"context_line":"            raise cls.skipException(msg)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_4acdc05c","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":34},"in_reply_to":"7af24918_0d7b1ac2","updated":"2016-03-04 22:46:10.000000000","message":"If you keep this approach, these tests \u0027are useless\u0027, in that they are skipped in the gate, and that\u0027s because of the way you test the presence of the extension..\n\nIn fact you have two options as of today, if you want these tests to be useful:\n\na) add a line to [1] and support in [2] to make the plugin load and tested in the gate\n\nb) add the plugin to the list of loaded service plugins [3]\n\nOption b) looks pretty safe as there\u0027s really no dependency on core plugins.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/contrib/gate_hook.sh#L55\n[2] https://github.com/openstack/neutron/tree/master/devstack/lib\n[3] https://github.com/openstack/neutron/blob/master/neutron/plugins/common/constants.py#L42","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"42b3563d98ba9f1e20e16d304f21886a22607cd2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def resource_setup(cls):"},{"line_number":50,"context_line":"        super(NetworksIpAvailabilityTestJSON, cls).resource_setup()"},{"line_number":51,"context_line":"        if not is_extension_loaded(cls.client, \u0027network-ip-availability\u0027):"},{"line_number":52,"context_line":"            msg \u003d \"network-ip-availability extension not enabled.\""},{"line_number":53,"context_line":"            raise cls.skipException(msg)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_4277393a","line":51,"range":{"start_line":51,"start_character":15,"end_line":51,"end_character":34},"in_reply_to":"7af24918_4acdc05c","updated":"2016-03-08 05:59:10.000000000","message":"Thanks I am following approach [3]. and its working","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"caa815e0000f8e23e6a9db400f17301061d1ba8f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    return total_ips"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NetworksIpAvailabilityIPv4TestJSON(NetworksIpAvailabilityTestJSON):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_4"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_aa48c4cd","line":87,"updated":"2016-03-04 22:48:25.000000000","message":"ditto","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"42b3563d98ba9f1e20e16d304f21886a22607cd2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    return total_ips"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NetworksIpAvailabilityIPv4TestJSON(NetworksIpAvailabilityTestJSON):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_4"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_c2b069e0","line":87,"in_reply_to":"7af24918_aa48c4cd","updated":"2016-03-08 05:59:10.000000000","message":"Done","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"caa815e0000f8e23e6a9db400f17301061d1ba8f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":122,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":123,"context_line":"            if availability[\u0027network_id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":124,"context_line":"                self.assertEqual(calc_total_ips(prefix, self.ip_version),"},{"line_number":125,"context_line":"                                 availability[\u0027total_ips\u0027])"},{"line_number":126,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_ca7c30ee","line":124,"updated":"2016-03-04 22:48:25.000000000","message":"I fear these tests can be race-y because there may be a lag between the time the port is actually deleted and the ip allocation returned. Have you considered that?","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b67af5e230d9e8ef88827439555a8b7f6b83b03a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":122,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":123,"context_line":"            if availability[\u0027network_id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":124,"context_line":"                self.assertEqual(calc_total_ips(prefix, self.ip_version),"},{"line_number":125,"context_line":"                                 availability[\u0027total_ips\u0027])"},{"line_number":126,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_fb9c145f","line":124,"in_reply_to":"5aef4532_229dcd65","updated":"2016-03-08 17:25:09.000000000","message":"I don\u0027t see a delete happening before the ip allocation call, just creates.  However, this does bring up a good point, there should also be tests that test teh ip allocation numbers after a delete.","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"286f07d38bbc85e92960a461413bdcec3a23bde6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":122,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":123,"context_line":"            if availability[\u0027network_id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":124,"context_line":"                self.assertEqual(calc_total_ips(prefix, self.ip_version),"},{"line_number":125,"context_line":"                                 availability[\u0027total_ips\u0027])"},{"line_number":126,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"3afc51ec_6660a636","line":124,"in_reply_to":"5aef4532_64a81378","updated":"2016-03-11 22:20:32.000000000","message":"Armando, Cleanup method is used by all other api tests, if there is a potential lag then i think we need to rework on all others tests where it is been used. i checked with people cleanup is called at the end of test. and to address that I am saving the dictionary returned by list and querying against it using a new function. even if it deletes the port I am passing net_availability dictionary to query the results. I hope it addresses the issue","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e761cf15d65632138b817ba62f35d6d4b272a2d4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":122,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":123,"context_line":"            if availability[\u0027network_id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":124,"context_line":"                self.assertEqual(calc_total_ips(prefix, self.ip_version),"},{"line_number":125,"context_line":"                                 availability[\u0027total_ips\u0027])"},{"line_number":126,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_64a81378","line":124,"in_reply_to":"5aef4532_fb9c145f","updated":"2016-03-09 20:00:57.000000000","message":"Maybe I am overreacting, but trust me: if there\u0027s a chance for a race, this test will exploit it :)\n\nPerhaps a wait_until_true may help","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"42b3563d98ba9f1e20e16d304f21886a22607cd2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        body \u003d self.client.list_network_ip_availabilities()"},{"line_number":122,"context_line":"        for availability in body[\u0027network_ip_availabilities\u0027]:"},{"line_number":123,"context_line":"            if availability[\u0027network_id\u0027] \u003d\u003d network[\u0027id\u0027]:"},{"line_number":124,"context_line":"                self.assertEqual(calc_total_ips(prefix, self.ip_version),"},{"line_number":125,"context_line":"                                 availability[\u0027total_ips\u0027])"},{"line_number":126,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_229dcd65","line":124,"in_reply_to":"7af24918_ca7c30ee","updated":"2016-03-08 05:59:10.000000000","message":"I followed other tests and never had a single failure due to this on local machine. does not clean up delete stuff after the test ends ? any suggestion for approach to avoid that ?","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"caa815e0000f8e23e6a9db400f17301061d1ba8f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class NetworksIpAvailabilityIPv6TestJSON(NetworksIpAvailabilityIPv4TestJSON):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_ea100cae","line":130,"updated":"2016-03-04 22:48:25.000000000","message":"ditto","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b67af5e230d9e8ef88827439555a8b7f6b83b03a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class NetworksIpAvailabilityIPv6TestJSON(NetworksIpAvailabilityIPv4TestJSON):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_1b8460d2","line":130,"in_reply_to":"5aef4532_22f02d90","updated":"2016-03-08 17:25:09.000000000","message":"Isn\u0027t that the point of this? To avoid having to copy/paste the same tests with just the ip_version changing?  Normally, this would be a red flag but I think this is making an acceptable care of inheriting another test class.","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e761cf15d65632138b817ba62f35d6d4b272a2d4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class NetworksIpAvailabilityIPv6TestJSON(NetworksIpAvailabilityIPv4TestJSON):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_e4e9c3b8","line":130,"in_reply_to":"5aef4532_22f02d90","updated":"2016-03-09 20:00:57.000000000","message":"This went away in:\n\nhttp://logs.openstack.org/57/283357/16/check/gate-neutron-dsvm-api/690576c/testr_results.html.gz\n\nbut look at:\n\nhttp://logs.openstack.org/57/283357/14/check/gate-neutron-dsvm-api/d70d5ff/testr_results.html.gz\n\nThe IPv6 testcasse ran twice. I guess it\u0027s all good now.","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"42b3563d98ba9f1e20e16d304f21886a22607cd2","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class NetworksIpAvailabilityIPv6TestJSON(NetworksIpAvailabilityIPv4TestJSON):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":14,"id":"5aef4532_22f02d90","line":130,"in_reply_to":"7af24918_4ad780bf","updated":"2016-03-08 05:59:10.000000000","message":"i did not get how tests are being run twice ?","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6036f16551611c64f64eae8c66b0fc8ae666fbfc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"class NetworksIpAvailabilityIPv6TestJSON(NetworksIpAvailabilityIPv4TestJSON):"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_4ad780bf","line":130,"in_reply_to":"7af24918_ea100cae","updated":"2016-03-04 22:50:21.000000000","message":"the hierarchy should not be designed this way. You\u0027re running IPv6 tests twice.","commit_id":"12066e6421861986c7dde004d3bed8e9c77e81f9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"d027edab3df776cca7a8bca051b8187e921eb70f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":121,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"class NetworksIpAvailabilityIPv6Test(NetworksIpAvailabilityIPv4Test):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aef4532_df5124da","line":123,"updated":"2016-03-09 08:34:29.000000000","message":"I still think you should add tests that delete a port and verify the ip availability numbers change on that as well.","commit_id":"17916632117cecf7a797303994bf27442303ace7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"718cdcbfc2b96d090b50464fed7a2eb9ff949e10","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":121,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"class NetworksIpAvailabilityIPv6Test(NetworksIpAvailabilityIPv4Test):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aef4532_c2f75657","line":123,"in_reply_to":"5aef4532_a95de27a","updated":"2016-03-09 20:58:04.000000000","message":"yeah, a method/function can be defined that trys to delete the port and catches the exception if it doesn\u0027t exist.  Add that to the cleanup and it should work.","commit_id":"17916632117cecf7a797303994bf27442303ace7"},{"author":{"_account_id":10962,"name":"David Bingham","email":"dbingham@godaddy.com","username":"wwriverrat"},"change_message_id":"f8f2ba3413ed6b1c4e0b3870c8607897c8e3a8e6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                # total used ips should be used_ip + no of ports created"},{"line_number":121,"context_line":"                self.assertEqual(used_ip + 2, availability[\u0027used_ips\u0027])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"class NetworksIpAvailabilityIPv6Test(NetworksIpAvailabilityIPv4Test):"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    ip_version \u003d lib_constants.IP_VERSION_6"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aef4532_a95de27a","line":123,"in_reply_to":"5aef4532_df5124da","updated":"2016-03-09 16:36:13.000000000","message":"Likely you\u0027re aware, but... would have to be careful doing this. We would need to remove \"addCleanup\" on 112 and 114 so they could be deleted by this test.  Afterwards, we would need to ensure they are deleted either by the test itself or somehow added to cleanup if any failures occur between (i.e. one of the test assertions fail for example line 118).","commit_id":"17916632117cecf7a797303994bf27442303ace7"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"6f3165d09129a893b3010a431796151a9a7cb979","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.addCleanup(self._cleanUp_port, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":147,"context_line":"        net_availability \u003d self.admin_client.list_network_ip_availabilities()"},{"line_number":148,"context_line":"        used_ip \u003d self._get_used_ips(network, net_availability)"},{"line_number":149,"context_line":"        self.client.delete_port(port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":150,"context_line":"        net_availability \u003d self.admin_client.list_network_ip_availabilities()"},{"line_number":151,"context_line":"        used_ip_after_port_delete \u003d self._get_used_ips(network,"},{"line_number":152,"context_line":"                                                       net_availability)"},{"line_number":153,"context_line":"        self.assertEqual(used_ip - 1, used_ip_after_port_delete)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3afc51ec_2959515b","line":150,"range":{"start_line":149,"start_character":8,"end_line":150,"end_character":77},"updated":"2016-03-11 22:52:27.000000000","message":"this is the part I think armando is concerned about a race condition.  It may be possible that the port is not deleted immediately, and that list_network_ip_availabilities will return numbers based on that fact.\n\nIf you polled neutron by doing a get_port or show_port (can\u0027t remember what it is for tempest), and wait until you get a 404, then you\u0027re good to check the ip availability.","commit_id":"6485a44ed51dff86ac482f75383046ae18ff8f55"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7247f37d7771db0917d912ea869032461eba7aa2","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        self.addCleanup(self._cleanUp_port, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":147,"context_line":"        net_availability \u003d self.admin_client.list_network_ip_availabilities()"},{"line_number":148,"context_line":"        used_ip \u003d self._get_used_ips(network, net_availability)"},{"line_number":149,"context_line":"        self.client.delete_port(port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":150,"context_line":"        net_availability \u003d self.admin_client.list_network_ip_availabilities()"},{"line_number":151,"context_line":"        used_ip_after_port_delete \u003d self._get_used_ips(network,"},{"line_number":152,"context_line":"                                                       net_availability)"},{"line_number":153,"context_line":"        self.assertEqual(used_ip - 1, used_ip_after_port_delete)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3afc51ec_5579ca92","line":150,"range":{"start_line":149,"start_character":8,"end_line":150,"end_character":77},"in_reply_to":"3afc51ec_2959515b","updated":"2016-03-12 00:43:33.000000000","message":"I\u0027ll fix it, bear with me","commit_id":"6485a44ed51dff86ac482f75383046ae18ff8f55"}]}
