)]}'
{"neutron/objects/base.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76b98a5d875ffcd542f945a75b2b64cb47621a59","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"},{"line_number":57,"context_line":"        super(NeutronObject, self).__init__(context, **kwargs)"},{"line_number":58,"context_line":"        self.obj_set_defaults()"},{"line_number":59,"context_line":"        self.context \u003d context"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def to_dict(self):"},{"line_number":62,"context_line":"        return dict(self.items())"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0754aafc","line":59,"updated":"2016-02-23 16:12:00.000000000","message":"i do not understand why we are duplicating this - https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L302","commit_id":"3cabc117370b7e5373216149554c7b050dc4a0df"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea421d54d306e9a853402b4bf8dabbe10d7157b1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"},{"line_number":57,"context_line":"        super(NeutronObject, self).__init__(context, **kwargs)"},{"line_number":58,"context_line":"        self.obj_set_defaults()"},{"line_number":59,"context_line":"        self.context \u003d context"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def to_dict(self):"},{"line_number":62,"context_line":"        return dict(self.items())"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_4ecd63b6","line":59,"in_reply_to":"3afc51ec_0ed8e252","updated":"2016-03-17 11:44:27.000000000","message":"Dan, I prefer we don\u0027t make an exception for oslo.versionedobjects library and maintain public interfaces with proper public names, as we do in other oslo libraries.","commit_id":"3cabc117370b7e5373216149554c7b050dc4a0df"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ad9d6ba2cb8d9a9539ef0e157fbe591c417cfc7f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"},{"line_number":57,"context_line":"        super(NeutronObject, self).__init__(context, **kwargs)"},{"line_number":58,"context_line":"        self.obj_set_defaults()"},{"line_number":59,"context_line":"        self.context \u003d context"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def to_dict(self):"},{"line_number":62,"context_line":"        return dict(self.items())"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_2d01cf6a","line":59,"in_reply_to":"bae84128_0754aafc","updated":"2016-02-23 16:58:57.000000000","message":"Because it\u0027s private attribute. We are not supposed to rely on it. I thought I described the reason in the commit message. Isn\u0027t it clear enough? Should I change the wording somehow?","commit_id":"3cabc117370b7e5373216149554c7b050dc4a0df"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f80fec19edfbe595f817f1934b6014331511f639","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"},{"line_number":57,"context_line":"        super(NeutronObject, self).__init__(context, **kwargs)"},{"line_number":58,"context_line":"        self.obj_set_defaults()"},{"line_number":59,"context_line":"        self.context \u003d context"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def to_dict(self):"},{"line_number":62,"context_line":"        return dict(self.items())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_0ed8e252","line":59,"in_reply_to":"bae84128_1876c7a3","updated":"2016-03-11 19:22:38.000000000","message":"Everyone that currently uses o.vo accesses self._context, so I don\u0027t think we could change it if we wanted to. I understand your concern, although this comes from early days in nova where this was intended to be private from other users, not from object implementations.\n\nIf you feel strongly, we could add an @property obj_context accessor, but I don\u0027t think it\u0027s really necessary, personally.","commit_id":"3cabc117370b7e5373216149554c7b050dc4a0df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0f4f52fcafaa86b9e425a293a4a37b24acb41f23","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"},{"line_number":57,"context_line":"        super(NeutronObject, self).__init__(context, **kwargs)"},{"line_number":58,"context_line":"        self.obj_set_defaults()"},{"line_number":59,"context_line":"        self.context \u003d context"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def to_dict(self):"},{"line_number":62,"context_line":"        return dict(self.items())"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_edcd2732","line":59,"in_reply_to":"bae84128_2d01cf6a","updated":"2016-02-23 17:01:39.000000000","message":"I do not think that this is a problem. The proper way to address this would be to add a method to the oslo objects to return the context.\nI do not think that we should be duplicating variables.","commit_id":"3cabc117370b7e5373216149554c7b050dc4a0df"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2b5c7b12b6b280c204f862ca79989befda452b2d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def __init__(self, context\u003dNone, **kwargs):"},{"line_number":57,"context_line":"        super(NeutronObject, self).__init__(context, **kwargs)"},{"line_number":58,"context_line":"        self.obj_set_defaults()"},{"line_number":59,"context_line":"        self.context \u003d context"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def to_dict(self):"},{"line_number":62,"context_line":"        return dict(self.items())"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_1876c7a3","line":59,"in_reply_to":"bae84128_edcd2732","updated":"2016-02-23 17:07:36.000000000","message":"OK. Let me work with oslo folks to get the context exposed properly.","commit_id":"3cabc117370b7e5373216149554c7b050dc4a0df"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"76b98a5d875ffcd542f945a75b2b64cb47621a59","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def create(self):"},{"line_number":153,"context_line":"        fields \u003d self._get_changed_persistent_fields()"},{"line_number":154,"context_line":"        try:"},{"line_number":155,"context_line":"            db_obj \u003d db_api.create_object(self.context, self.db_model, fields)"},{"line_number":156,"context_line":"        except obj_exc.DBDuplicateEntry as db_exc:"},{"line_number":157,"context_line":"            raise NeutronDbObjectDuplicateEntry(object_class\u003dself.__class__,"},{"line_number":158,"context_line":"                                                db_exception\u003ddb_exc)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_475a322b","line":155,"updated":"2016-02-23 16:12:00.000000000","message":"see above","commit_id":"3cabc117370b7e5373216149554c7b050dc4a0df"}]}