)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8ae84678abbc6cf3aee329adb8c7e2823ef547b3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Closes-Bug: #1549470"},{"line_number":28,"context_line":"Closes-Bug: #1542108"},{"line_number":29,"context_line":"Closes-Bug: #1542475"},{"line_number":30,"context_line":"DocImpact"},{"line_number":31,"context_line":"Co-Authored-By: Matt Kassawara \u003cmkassawara@gmail.com\u003e"},{"line_number":32,"context_line":"Change-Id: Ic091fa78dfd133179c71cbc847bf955a06cb248a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9aed3d3a_e347fcb9","line":30,"updated":"2016-02-29 19:14:21.000000000","message":"Ah, sorry I left this out. Matt was handling the docs for it already so I was being lazy. :)","commit_id":"7d5a92e972487155752f9aece9ec54474410cd28"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b5e43479bcbe3c58d26a3911c85421fe6fbd422b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Closes-Bug: #1549470"},{"line_number":28,"context_line":"Closes-Bug: #1542108"},{"line_number":29,"context_line":"Closes-Bug: #1542475"},{"line_number":30,"context_line":"DocImpact"},{"line_number":31,"context_line":"Co-Authored-By: Matt Kassawara \u003cmkassawara@gmail.com\u003e"},{"line_number":32,"context_line":"Change-Id: Ic091fa78dfd133179c71cbc847bf955a06cb248a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9aed3d3a_68bf4eaa","line":30,"updated":"2016-02-29 17:43:27.000000000","message":"you should add a sentence explaining what are the changes needed for the documentation","commit_id":"7d5a92e972487155752f9aece9ec54474410cd28"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"b114870a9ff1cec007d0b2abcc3dc2c1dbd14f8d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Closes-Bug: #1549470"},{"line_number":28,"context_line":"Closes-Bug: #1542108"},{"line_number":29,"context_line":"Closes-Bug: #1542475"},{"line_number":30,"context_line":"DocImpact"},{"line_number":31,"context_line":"Co-Authored-By: Matt Kassawara \u003cmkassawara@gmail.com\u003e"},{"line_number":32,"context_line":"Change-Id: Ic091fa78dfd133179c71cbc847bf955a06cb248a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9aed3d3a_63e64cb1","line":30,"in_reply_to":"9aed3d3a_e347fcb9","updated":"2016-02-29 19:18:12.000000000","message":"For central docs, primarily the installation and networking guides. Also need to trigger a config reference update.","commit_id":"7d5a92e972487155752f9aece9ec54474410cd28"}],"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eccd803ae3f246689d220059dd25a90cf4a14c40","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                         ex_gw_port[\u0027mac_address\u0027],"},{"line_number":107,"context_line":"                         bridge\u003dself.agent_conf.external_network_bridge,"},{"line_number":108,"context_line":"                         namespace\u003dns_name,"},{"line_number":109,"context_line":"                         prefix\u003dFIP_EXT_DEV_PREFIX, mtu\u003dex_gw_port.get(\u0027mtu\u0027))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        ip_cidrs \u003d common_utils.fixed_ip_cidrs(ex_gw_port[\u0027fixed_ips\u0027])"},{"line_number":112,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs, namespace\u003dns_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_f0a01a44","line":109,"updated":"2016-02-24 15:44:07.000000000","message":"nit: mtu should be on own line","commit_id":"50921f2aaf8b094d17a3f9baf4f7c4311a376122"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b4e6dd2526f0a4d489e56e2b100b700f6ea163b2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                         ex_gw_port[\u0027mac_address\u0027],"},{"line_number":107,"context_line":"                         bridge\u003dself.agent_conf.external_network_bridge,"},{"line_number":108,"context_line":"                         namespace\u003dns_name,"},{"line_number":109,"context_line":"                         prefix\u003dFIP_EXT_DEV_PREFIX, mtu\u003dex_gw_port.get(\u0027mtu\u0027))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        ip_cidrs \u003d common_utils.fixed_ip_cidrs(ex_gw_port[\u0027fixed_ips\u0027])"},{"line_number":112,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs, namespace\u003dns_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2a0b207f","line":109,"in_reply_to":"bae84128_f0a01a44","updated":"2016-02-24 20:08:24.000000000","message":"Done","commit_id":"50921f2aaf8b094d17a3f9baf4f7c4311a376122"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"bf99d618fd93b6a44632307555a3fe3b54caad8f","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            self._internal_ns_interface_added(str(fip_2_rtr),"},{"line_number":234,"context_line":"                                              fip_2_rtr_name,"},{"line_number":235,"context_line":"                                              fip_ns_name)"},{"line_number":236,"context_line":"            mtu \u003d (self.agent_conf.network_device_mtu or"},{"line_number":237,"context_line":"                   ri.get_ex_gw_port().get(\u0027mtu\u0027))"},{"line_number":238,"context_line":"            if mtu:"},{"line_number":239,"context_line":"                int_dev[0].link.set_mtu(mtu)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_60ffcb67","line":236,"updated":"2016-02-26 16:29:23.000000000","message":"Aren\u0027t config deprecation warnings just for when users specify them? Why would oslo config throw warnings at an operator because code checks a config option he/she didn\u0027t set?","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cff1ec1331e9b5e450b91506876ecb03c420cc2","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            self._internal_ns_interface_added(str(fip_2_rtr),"},{"line_number":234,"context_line":"                                              fip_2_rtr_name,"},{"line_number":235,"context_line":"                                              fip_ns_name)"},{"line_number":236,"context_line":"            mtu \u003d (self.agent_conf.network_device_mtu or"},{"line_number":237,"context_line":"                   ri.get_ex_gw_port().get(\u0027mtu\u0027))"},{"line_number":238,"context_line":"            if mtu:"},{"line_number":239,"context_line":"                int_dev[0].link.set_mtu(mtu)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_59829095","line":236,"updated":"2016-02-26 13:12:16.000000000","message":"With https://review.openstack.org/283798, this effectively makes us trigger the deprecation warning. Should we swap the order, relying on plugin MTU value first and falling back to well known bad behavior [and maybe warn specifically about the issue in log?]?","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eccd803ae3f246689d220059dd25a90cf4a14c40","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                         namespace\u003dself.ha_namespace,"},{"line_number":276,"context_line":"                         prefix\u003dprefix,"},{"line_number":277,"context_line":"                         mtu\u003dport.get(\u0027mtu\u0027)"},{"line_number":278,"context_line":"                         )"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        self._disable_ipv6_addressing_on_interface(interface_name)"},{"line_number":281,"context_line":"        self._add_vips(port, interface_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_d0beb663","line":278,"updated":"2016-02-24 15:44:07.000000000","message":"nit :)","commit_id":"50921f2aaf8b094d17a3f9baf4f7c4311a376122"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b4e6dd2526f0a4d489e56e2b100b700f6ea163b2","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                         namespace\u003dself.ha_namespace,"},{"line_number":276,"context_line":"                         prefix\u003dprefix,"},{"line_number":277,"context_line":"                         mtu\u003dport.get(\u0027mtu\u0027)"},{"line_number":278,"context_line":"                         )"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        self._disable_ipv6_addressing_on_interface(interface_name)"},{"line_number":281,"context_line":"        self._add_vips(port, interface_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_4a22e402","line":278,"in_reply_to":"bae84128_d0beb663","updated":"2016-02-24 20:08:24.000000000","message":"Done","commit_id":"50921f2aaf8b094d17a3f9baf4f7c4311a376122"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13dd4249cbdbb79f259630627b468f3cd2a8a8c9","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def ha_network_added(self):"},{"line_number":140,"context_line":"        interface_name \u003d self.get_ha_device_name()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        self.driver.plug(self.ha_port[\u0027network_id\u0027],"},{"line_number":143,"context_line":"                         self.ha_port[\u0027id\u0027],"},{"line_number":144,"context_line":"                         interface_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_6290b8ed","side":"PARENT","line":141,"updated":"2016-02-25 17:16:09.000000000","message":"nit: unrelated change","commit_id":"3d749f7cc363bfe528c8fd07a4d4340aa7f6d9fc"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"13dd4249cbdbb79f259630627b468f3cd2a8a8c9","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    def _plug_ha_router_port(self, port, name_getter, prefix):"},{"line_number":269,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":270,"context_line":"        interface_name \u003d name_getter(port_id)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        self.driver.plug(port[\u0027network_id\u0027],"},{"line_number":273,"context_line":"                         port_id,"},{"line_number":274,"context_line":"                         interface_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_22ad1032","side":"PARENT","line":271,"updated":"2016-02-25 17:16:09.000000000","message":"nit: unrelated change","commit_id":"3d749f7cc363bfe528c8fd07a4d4340aa7f6d9fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cff1ec1331e9b5e450b91506876ecb03c420cc2","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def ha_network_added(self):"},{"line_number":140,"context_line":"        interface_name \u003d self.get_ha_device_name()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        self.driver.plug(self.ha_port[\u0027network_id\u0027],"},{"line_number":143,"context_line":"                         self.ha_port[\u0027id\u0027],"},{"line_number":144,"context_line":"                         interface_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_192648ce","side":"PARENT","line":141,"updated":"2016-02-26 13:12:16.000000000","message":"Some pedant could tell that the line should not be touched. Damn pedant.","commit_id":"3fb153b15b7d846947476221c79b129c878d4e56"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59b61747905357ed0efbaaa3586a372068e8fb21","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def ha_network_added(self):"},{"line_number":140,"context_line":"        interface_name \u003d self.get_ha_device_name()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        self.driver.plug(self.ha_port[\u0027network_id\u0027],"},{"line_number":143,"context_line":"                         self.ha_port[\u0027id\u0027],"},{"line_number":144,"context_line":"                         interface_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_cfed20f1","side":"PARENT","line":141,"in_reply_to":"9aed3d3a_192648ce","updated":"2016-02-26 17:37:04.000000000","message":"Done","commit_id":"3fb153b15b7d846947476221c79b129c878d4e56"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eccd803ae3f246689d220059dd25a90cf4a14c40","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            if self.conf.ovs_use_veth:"},{"line_number":335,"context_line":"                root_dev.link.set_mtu(mtu)"},{"line_number":336,"context_line":"        else:"},{"line_number":337,"context_line":"            LOG.warning(_LW(\"No MTU configured for port %s\"), port_id)"},{"line_number":338,"context_line":"        # Add an interface created by ovs to the namespace."},{"line_number":339,"context_line":"        if not self.conf.ovs_use_veth and namespace:"},{"line_number":340,"context_line":"            namespace_obj \u003d ip.ensure_namespace(namespace)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_cb844b5f","line":337,"updated":"2016-02-24 15:44:07.000000000","message":"So is this going to create lots of warnings when someone updates?  Seems excessive.  Should we figure out what the mtu should be and update the port?","commit_id":"50921f2aaf8b094d17a3f9baf4f7c4311a376122"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b4e6dd2526f0a4d489e56e2b100b700f6ea163b2","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            if self.conf.ovs_use_veth:"},{"line_number":335,"context_line":"                root_dev.link.set_mtu(mtu)"},{"line_number":336,"context_line":"        else:"},{"line_number":337,"context_line":"            LOG.warning(_LW(\"No MTU configured for port %s\"), port_id)"},{"line_number":338,"context_line":"        # Add an interface created by ovs to the namespace."},{"line_number":339,"context_line":"        if not self.conf.ovs_use_veth and namespace:"},{"line_number":340,"context_line":"            namespace_obj \u003d ip.ensure_namespace(namespace)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_8ae18c9d","line":337,"in_reply_to":"bae84128_cb844b5f","updated":"2016-02-24 20:08:24.000000000","message":"Only if they are using a plugin that doesn\u0027t support the MTU extension and they don\u0027t have network_device_mtu defined. I think we want to warn so they explicitly set it with the config value.","commit_id":"50921f2aaf8b094d17a3f9baf4f7c4311a376122"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cff1ec1331e9b5e450b91506876ecb03c420cc2","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        ns_dev.link.set_address(mac_address)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        mtu \u003d self.conf.network_device_mtu or mtu"},{"line_number":332,"context_line":"        if mtu:"},{"line_number":333,"context_line":"            ns_dev.link.set_mtu(mtu)"},{"line_number":334,"context_line":"            if self.conf.ovs_use_veth:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_cc09c02e","line":331,"updated":"2016-02-26 13:12:16.000000000","message":"ditto: I suggest we reverse the order to avoid triggering deprecation message; and also to switch users to correct implementation.","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59b61747905357ed0efbaaa3586a372068e8fb21","unresolved":false,"context_lines":[{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        ns_dev.link.set_address(mac_address)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        mtu \u003d self.conf.network_device_mtu or mtu"},{"line_number":332,"context_line":"        if mtu:"},{"line_number":333,"context_line":"            ns_dev.link.set_mtu(mtu)"},{"line_number":334,"context_line":"            if self.conf.ovs_use_veth:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_6f421412","line":331,"in_reply_to":"9aed3d3a_cc09c02e","updated":"2016-02-26 17:37:04.000000000","message":"I don\u0027t want to do this because it immediately breaks network_device_mtu.","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cff1ec1331e9b5e450b91506876ecb03c420cc2","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        ns_dev \u003d ip.device(device_name)"},{"line_number":396,"context_line":"        ns_dev.link.set_address(mac_address)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        mtu \u003d self.conf.network_device_mtu or mtu"},{"line_number":399,"context_line":"        if mtu:"},{"line_number":400,"context_line":"            ns_dev.link.set_mtu(mtu)"},{"line_number":401,"context_line":"            root_dev.link.set_mtu(mtu)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_2c32ecf1","line":398,"updated":"2016-02-26 13:12:16.000000000","message":"ditto","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cff1ec1331e9b5e450b91506876ecb03c420cc2","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                         namespace2\u003dnamespace)"},{"line_number":442,"context_line":"        ns_veth.link.set_address(mac_address)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        mtu \u003d self.conf.network_device_mtu or mtu"},{"line_number":445,"context_line":"        if mtu:"},{"line_number":446,"context_line":"            root_veth.link.set_mtu(mtu)"},{"line_number":447,"context_line":"            ns_veth.link.set_mtu(mtu)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_8c74d89c","line":444,"updated":"2016-02-26 13:12:16.000000000","message":"ditto","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cff1ec1331e9b5e450b91506876ecb03c420cc2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        router_info \u003d self.generate_dvr_router_info("},{"line_number":125,"context_line":"            enable_ha, enable_snat, extra_routes\u003dTrue)"},{"line_number":126,"context_line":"        if use_port_mtu:"},{"line_number":127,"context_line":"            self.agent.conf.network_device_mtu \u003d None"},{"line_number":128,"context_line":"            for port in router_info[\u0027_interfaces\u0027]:"},{"line_number":129,"context_line":"                port[\u0027mtu\u0027] \u003d custom_mtu"},{"line_number":130,"context_line":"            for port in router_info[\u0027_snat_router_interfaces\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_4c913099","line":127,"updated":"2016-02-26 13:12:16.000000000","message":"nit: default value is already None I think","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59b61747905357ed0efbaaa3586a372068e8fb21","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        router_info \u003d self.generate_dvr_router_info("},{"line_number":125,"context_line":"            enable_ha, enable_snat, extra_routes\u003dTrue)"},{"line_number":126,"context_line":"        if use_port_mtu:"},{"line_number":127,"context_line":"            self.agent.conf.network_device_mtu \u003d None"},{"line_number":128,"context_line":"            for port in router_info[\u0027_interfaces\u0027]:"},{"line_number":129,"context_line":"                port[\u0027mtu\u0027] \u003d custom_mtu"},{"line_number":130,"context_line":"            for port in router_info[\u0027_snat_router_interfaces\u0027]:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_4fe110fe","line":127,"in_reply_to":"9aed3d3a_4c913099","updated":"2016-02-26 17:37:04.000000000","message":"Done","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7cff1ec1331e9b5e450b91506876ecb03c420cc2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            enable_ha, enable_snat, extra_routes\u003dTrue)"},{"line_number":126,"context_line":"        if use_port_mtu:"},{"line_number":127,"context_line":"            self.agent.conf.network_device_mtu \u003d None"},{"line_number":128,"context_line":"            for port in router_info[\u0027_interfaces\u0027]:"},{"line_number":129,"context_line":"                port[\u0027mtu\u0027] \u003d custom_mtu"},{"line_number":130,"context_line":"            for port in router_info[\u0027_snat_router_interfaces\u0027]:"},{"line_number":131,"context_line":"                port[\u0027mtu\u0027] \u003d custom_mtu"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_6c6354b2","line":128,"updated":"2016-02-26 13:12:16.000000000","message":"nitty nit:\n\nfor port in itertools.chain(router_info[\u0027_interfaces\u0027],\n                            router_info[\u0027_snat_router_interfaces\u0027], ...):\n    port[\u0027mtu\u0027] \u003d custom_mtu","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"59b61747905357ed0efbaaa3586a372068e8fb21","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            enable_ha, enable_snat, extra_routes\u003dTrue)"},{"line_number":126,"context_line":"        if use_port_mtu:"},{"line_number":127,"context_line":"            self.agent.conf.network_device_mtu \u003d None"},{"line_number":128,"context_line":"            for port in router_info[\u0027_interfaces\u0027]:"},{"line_number":129,"context_line":"                port[\u0027mtu\u0027] \u003d custom_mtu"},{"line_number":130,"context_line":"            for port in router_info[\u0027_snat_router_interfaces\u0027]:"},{"line_number":131,"context_line":"                port[\u0027mtu\u0027] \u003d custom_mtu"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aed3d3a_0fd70824","line":128,"in_reply_to":"9aed3d3a_6c6354b2","updated":"2016-02-26 17:37:04.000000000","message":"chain is meh, but i\u0027ll fix this :)","commit_id":"062b3088e23364a291f7c781bb5bb2aac919dcde"}]}