)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c35f63ee05c88253ca2a97a03c7d9c298c9aa562","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sonu \u003csonu.sudhakaran@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-23 19:39:56 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On systems where IPv6 is disabled, the routers should not assign"},{"line_number":8,"context_line":"link local IPv6 addresses on router interfaces."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I2fe20cac59237dc0980f51608f1ffbcb68f51d50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bae84128_07bba676","line":7,"updated":"2016-02-25 01:10:16.000000000","message":"please limit the commit messaget o 50 characters for the head","commit_id":"38b174f3208c56a975c6be30784b9e026493b797"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2c91e79aa1b3d770893b07a07b7fd12e7cb1c032","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure IPv6 on HA router only if IPv6 is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"L3 agent should check if IPv6 is disabled on the system"},{"line_number":10,"context_line":"and create HA router namespace with IPv6 disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is required especially in case of L3 HA because,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_b97a46ef","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":55},"updated":"2016-02-29 18:51:13.000000000","message":"This makes me think you\u0027re checking the host OS to see if IPV6 is enabled.  But, you\u0027re not.  So, I\u0027d say that this is misleading.\n\nI was about to make an argument about how IPv6 being enabled or not in the host (default namespace) shouldn\u0027t be correlated with IPv6 being enabled in a router namespace.  But, then I noticed that your code is checking Neutron config.","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"270acadf8f4d5fce9fb5b19aad8855a85086b142","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure IPv6 on HA router only if IPv6 is enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"L3 agent should check if IPv6 is disabled on the system"},{"line_number":10,"context_line":"and create HA router namespace with IPv6 disabled."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is required especially in case of L3 HA because,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_01c7aa64","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":55},"in_reply_to":"9aed3d3a_b97a46ef","updated":"2016-03-09 10:49:32.000000000","message":"I am relying on the variable initialized using ipv6_utils::is_enabled function. And I believe it checks if IPv6 is enabled on the system.\n\nLet me know where I am missing to understand the point you are making.","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2c91e79aa1b3d770893b07a07b7fd12e7cb1c032","unresolved":false,"context_lines":[{"line_number":22,"context_line":"of L3 agent results in IPv6 packets in the network."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch introduces a check in L3 agent to create HA"},{"line_number":25,"context_line":"router namespace with IPv6 disabled if IPv6 addressing"},{"line_number":26,"context_line":"is disabled on the system."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1551065"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_204f1a6c","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":35},"updated":"2016-02-29 18:51:13.000000000","message":"So, does this only fix the bug when ipv6 is disabled in Neutron?  What about when ipv6 is not disabled?  We still have this bug?\n\nDidn\u0027t we already solve this problem in Ia5071552239c9444c5105a150b268fb0437e4b85?  Did this not fix the issue?  Did we have a regression?","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"270acadf8f4d5fce9fb5b19aad8855a85086b142","unresolved":false,"context_lines":[{"line_number":22,"context_line":"of L3 agent results in IPv6 packets in the network."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch introduces a check in L3 agent to create HA"},{"line_number":25,"context_line":"router namespace with IPv6 disabled if IPv6 addressing"},{"line_number":26,"context_line":"is disabled on the system."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1551065"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_810a9a77","line":25,"range":{"start_line":25,"start_character":7,"end_line":25,"end_character":35},"in_reply_to":"9aed3d3a_204f1a6c","updated":"2016-03-09 10:49:32.000000000","message":"This case is applicable to case where IPv6 is disabled. The fix to configure the IPv6 only on master router is separate issue.","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"}],"neutron/agent/l3/namespaces.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"42512170fcaaec8be7b3521bfe2bb223327a64a5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.driver \u003d driver"},{"line_number":68,"context_line":"        self.use_ipv6 \u003d use_ipv6"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create(self):"},{"line_number":71,"context_line":"        ip_wrapper \u003d self.ip_wrapper_root.ensure_namespace(self.name)"},{"line_number":72,"context_line":"        cmd \u003d [\u0027sysctl\u0027, \u0027-w\u0027, \u0027net.ipv4.ip_forward\u003d1\u0027]"},{"line_number":73,"context_line":"        ip_wrapper.netns.execute(cmd)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_1cea36ac","line":70,"updated":"2016-02-29 21:58:47.000000000","message":"The dvr_fip_ns code never calls super(), does it need the same addition?  I\u0027m actually taking a look at that code now to see if it can be tweaked in that way.","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"270acadf8f4d5fce9fb5b19aad8855a85086b142","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.driver \u003d driver"},{"line_number":68,"context_line":"        self.use_ipv6 \u003d use_ipv6"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def create(self):"},{"line_number":71,"context_line":"        ip_wrapper \u003d self.ip_wrapper_root.ensure_namespace(self.name)"},{"line_number":72,"context_line":"        cmd \u003d [\u0027sysctl\u0027, \u0027-w\u0027, \u0027net.ipv4.ip_forward\u003d1\u0027]"},{"line_number":73,"context_line":"        ip_wrapper.netns.execute(cmd)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_fcc6a566","line":70,"in_reply_to":"9aed3d3a_1cea36ac","updated":"2016-03-09 10:49:32.000000000","message":"I find super being invoked for FipNamespace instance. This will ensure ipv6 is disabled on FIP DVR namespaces. \n\nLet me know if I miss something.","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"42512170fcaaec8be7b3521bfe2bb223327a64a5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            ip_wrapper.netns.execute(cmd)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            ip_wrapper.netns.execute([\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":79,"context_line":"                                \u0027net.ipv6.conf.default.disable_ipv6\u003d1\u0027])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete(self):"},{"line_number":82,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c9fad242","line":79,"updated":"2016-02-29 21:58:47.000000000","message":"nit: to be consistent with the other code here, this should be:\n\ncmd \u003d [...]\nip_wrapper...(cmd)","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"270acadf8f4d5fce9fb5b19aad8855a85086b142","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            ip_wrapper.netns.execute(cmd)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            ip_wrapper.netns.execute([\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":79,"context_line":"                                \u0027net.ipv6.conf.default.disable_ipv6\u003d1\u0027])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def delete(self):"},{"line_number":82,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_1ca8b18c","line":79,"in_reply_to":"9aed3d3a_c9fad242","updated":"2016-03-09 10:49:32.000000000","message":"Done","commit_id":"a4bdbc77c9143c9b82a6d4f4cf3039ce98b2f059"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"b64ae17fc6e865baa791123163cf05248b3badeb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            ip_wrapper.netns.execute(cmd)"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            cmd \u003d [\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":79,"context_line":"                        \u0027net.ipv6.conf.default.disable_ipv6\u003d1\u0027]"},{"line_number":80,"context_line":"            ip_wrapper.netns.execute(cmd)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def delete(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_c66bbdb5","line":79,"updated":"2016-03-10 15:05:20.000000000","message":"please, remove 5 extra spaces","commit_id":"2e2481c5fc4b9cfa09d30ec2696d08f2cfbee4e2"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"b64ae17fc6e865baa791123163cf05248b3badeb","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            cmd \u003d [\u0027sysctl\u0027, \u0027-w\u0027,"},{"line_number":79,"context_line":"                        \u0027net.ipv6.conf.default.disable_ipv6\u003d1\u0027]"},{"line_number":80,"context_line":"            ip_wrapper.netns.execute(cmd)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def delete(self):"},{"line_number":83,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_0b064e1f","line":80,"updated":"2016-03-10 15:05:20.000000000","message":"I think, the duplicate lines (76 and 80) can be deleted and you can just write ip_wrapper.netns.execute(cmd) after if-else statement","commit_id":"2e2481c5fc4b9cfa09d30ec2696d08f2cfbee4e2"}]}
