)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e178a4347de89aa8a4c21e46fc369523a105861f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Basic extension and CRUD for Segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables basic CRUD on Segments by defining a new entitiy"},{"line_number":10,"context_line":"called \u0027Segment\u0027.  So far, this is just the basic boilerb-plate but"},{"line_number":11,"context_line":"I\u0027ve got to start somewhere."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bae84128_35453817","line":9,"range":{"start_line":9,"start_character":65,"end_line":9,"end_character":66},"updated":"2016-02-24 22:35:40.000000000","message":"Stray character","commit_id":"c855f82fdb9521304851a64c83f6bcd1230d947f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e178a4347de89aa8a4c21e46fc369523a105861f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Basic extension and CRUD for Segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables basic CRUD on Segments by defining a new entitiy"},{"line_number":10,"context_line":"called \u0027Segment\u0027.  So far, this is just the basic boilerb-plate but"},{"line_number":11,"context_line":"I\u0027ve got to start somewhere."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0a198545ba02e5db25c25355feff763257696075"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bae84128_5540bc07","line":10,"range":{"start_line":10,"start_character":56,"end_line":10,"end_character":57},"updated":"2016-02-24 22:35:40.000000000","message":"Stray character","commit_id":"c855f82fdb9521304851a64c83f6bcd1230d947f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0529dc1a9a0ee11d90ad95fdc395c7a340109e97","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Basic extension and CRUD for Segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables basic CRUD on Segments by defining a new entitiy"},{"line_number":10,"context_line":"called \u0027Segment\u0027.  So far, this is just the basic boilerb-plate but"},{"line_number":11,"context_line":"I\u0027ve got to start somewhere."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0a198545ba02e5db25c25355feff763257696075"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_705f6ce5","line":10,"range":{"start_line":10,"start_character":56,"end_line":10,"end_character":58},"updated":"2016-03-09 02:37:02.000000000","message":"extra b ?","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Basic extension and CRUD for Segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables basic CRUD on Segments by defining a new entitiy"},{"line_number":10,"context_line":"called \u0027Segment\u0027.  So far, this is just the basic boilerb-plate but"},{"line_number":11,"context_line":"I\u0027ve got to start somewhere."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0a198545ba02e5db25c25355feff763257696075"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_5549d98a","line":10,"range":{"start_line":10,"start_character":56,"end_line":10,"end_character":58},"in_reply_to":"5aef4532_705f6ce5","updated":"2016-03-11 23:00:21.000000000","message":"Done","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"}],"neutron/db/segment_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"49b911d95d799b8e8fb5e2a5a7c50e47f0d266f0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from sqlalchemy.orm import exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.extensions import segment as ext_segment"},{"line_number":23,"context_line":"from neutron.plugins.ml2 import models as ml2_models"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_ca81a94c","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":52},"updated":"2016-03-02 00:27:17.000000000","message":"This shouldn\u0027t be pulling ml2_models.  In fact, since it is rebased on the patch to move it, this is totally wrong anyway.","commit_id":"805e039741339f28d71d2e514cdb9dbd7afa39b9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"bd9258442700eafb22a3e3c45e51d3b38a7e15a3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# TODO(Carl) Combine this with providernet_db?"},{"line_number":29,"context_line":"class SegmentDbMixin(ext_segment.SegmentPluginBase):"},{"line_number":30,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_aa125db2","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":45},"updated":"2016-03-02 00:39:28.000000000","message":"What do others think?","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9b1d471601eae51189151458635fe5c30596caab","unresolved":false,"context_lines":[{"line_number":25,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# TODO(Carl) Combine this with providernet_db?"},{"line_number":29,"context_line":"class SegmentDbMixin(ext_segment.SegmentPluginBase):"},{"line_number":30,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_48925af7","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":45},"in_reply_to":"7af24918_aa125db2","updated":"2016-03-03 10:11:47.000000000","message":"It will be good to eliminate duplication","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"021afb702fc78f013d9dab2444fbcbe6c78d56e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# TODO(Carl) Combine this with providernet_db?"},{"line_number":29,"context_line":"class SegmentDbMixin(ext_segment.SegmentPluginBase):"},{"line_number":30,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _make_segment_dict(self, segment, fields\u003dNone, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_049e1a07","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":20},"updated":"2016-03-04 22:27:11.000000000","message":"Maybe rename to SegmentsMixin","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# TODO(Carl) Combine this with providernet_db?"},{"line_number":29,"context_line":"class SegmentDbMixin(ext_segment.SegmentPluginBase):"},{"line_number":30,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _make_segment_dict(self, segment, fields\u003dNone, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_18794894","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":20},"in_reply_to":"7af24918_049e1a07","updated":"2016-03-11 23:00:21.000000000","message":"Done","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3544a4da23c218eb34fdd93353a00406ccf799aa","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            raise ext_segment.SegmentNotFound(segment_id\u003did)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @log_helpers.log_method_call"},{"line_number":47,"context_line":"    def create_segment(self, context, segment):"},{"line_number":48,"context_line":"        \"\"\"Create a segment.\"\"\""},{"line_number":49,"context_line":"        segment \u003d segment[\u0027segment\u0027]"},{"line_number":50,"context_line":"        segment_id \u003d segment.get(\u0027id\u0027) or uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_f869acbf","line":47,"updated":"2016-03-08 21:55:00.000000000","message":"Should we give segments an optional admin provided name and/or description?","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d815dec266a120ea8300338da1985f485046aa6b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            raise ext_segment.SegmentNotFound(segment_id\u003did)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @log_helpers.log_method_call"},{"line_number":47,"context_line":"    def create_segment(self, context, segment):"},{"line_number":48,"context_line":"        \"\"\"Create a segment.\"\"\""},{"line_number":49,"context_line":"        segment \u003d segment[\u0027segment\u0027]"},{"line_number":50,"context_line":"        segment_id \u003d segment.get(\u0027id\u0027) or uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_1ec62c67","line":47,"in_reply_to":"3afc51ec_d503290e","updated":"2016-03-14 00:38:04.000000000","message":"I think putting Name/Description is good, so that admin can easily identify the segments easily ( Naming allows admin to know that a segment is part of Subnet-XYZ, without running segment-show)","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            raise ext_segment.SegmentNotFound(segment_id\u003did)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @log_helpers.log_method_call"},{"line_number":47,"context_line":"    def create_segment(self, context, segment):"},{"line_number":48,"context_line":"        \"\"\"Create a segment.\"\"\""},{"line_number":49,"context_line":"        segment \u003d segment[\u0027segment\u0027]"},{"line_number":50,"context_line":"        segment_id \u003d segment.get(\u0027id\u0027) or uuidutils.generate_uuid()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_d503290e","line":47,"in_reply_to":"5aef4532_f869acbf","updated":"2016-03-11 23:00:21.000000000","message":"I think someone could follow up with that a bit later.  Right, now I want to stay focused on what\u0027s necessary to get the whole thing off the ground.  I find my time is very limited lately.  ;)  I\u0027m happy to put this up as low hanging fruit that could be picked up.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"}],"neutron/extensions/segment.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"748afe44ac6ddd535c41d2c3f4c343e12fd72958","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SEGMENT_ID \u003d \u0027segment_id\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_9106e61e","line":30,"updated":"2016-03-11 13:05:37.000000000","message":"Right now all attributes must be specified on the CLI to create a segment.  Will there be any defaults?","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"077737dabdb48753c6d53f9593d5c956ba96cdf3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SEGMENT_ID \u003d \u0027segment_id\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_94f9aacb","line":30,"in_reply_to":"3afc51ec_9106e61e","updated":"2016-03-11 16:11:11.000000000","message":"Infact I would also like to know if there would be any optional and required/positional arguments?","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":27,"context_line":"SEGMENT_ID \u003d \u0027segment_id\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_58aab0d5","line":30,"in_reply_to":"3afc51ec_94f9aacb","updated":"2016-03-11 23:00:21.000000000","message":"For now, all three attributes will be required.  I\u0027m not sure what sensible defaults would be.  Any ideas?  The multi-provider extension doesn\u0027t seem to define any defaults.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9b1d471601eae51189151458635fe5c30596caab","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"},{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1716b54b","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"updated":"2016-03-03 10:11:47.000000000","message":"Do you consider to add a name to segment? I think it would be easy to use segment with a name.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d2f5bfc3c8128bcc53190ed95e49008d5ad617cd","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"},{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_868c9980","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"in_reply_to":"3afc51ec_2dd2c8d2","updated":"2016-03-14 13:58:51.000000000","message":"If it is ok, I will submit the new CRUD spec tomorrow ( as Carl is on Vacation) with the Name/Desc parameter ( its a low hanging fruit, but lets not let it hang too long :D )","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"9102b368261a7a1a61c610c7ae6519537431de7f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"},{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_2dd2c8d2","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"in_reply_to":"3afc51ec_d8b6c03c","updated":"2016-03-14 13:54:00.000000000","message":"Hi Carl, having a name is nice when working from the CLI.  That would be the primary use case I see now.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"},{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_d8b6c03c","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"in_reply_to":"5aef4532_c9d35b37","updated":"2016-03-11 23:00:21.000000000","message":"Low hanging fruit.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"021afb702fc78f013d9dab2444fbcbe6c78d56e2","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"},{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_e4716eaa","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"in_reply_to":"7af24918_1716b54b","updated":"2016-03-04 22:27:11.000000000","message":"I think that is something that someone can follow up with later.  Do you see a compelling use case requiring a name?","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0529dc1a9a0ee11d90ad95fdc395c7a340109e97","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Attribute Map"},{"line_number":30,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":31,"context_line":"    SEGMENTS: {"},{"line_number":32,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False,"},{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"},{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_c9d35b37","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":15},"in_reply_to":"7af24918_e4716eaa","updated":"2016-03-09 02:37:02.000000000","message":"Not a pretty compelling one, but naming a segment sure makes it easier for a user to know whats being worked upon ( for example, user can have a script which creates a list of segments based on a particular naming construct).\nSame goes for description","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":33,"context_line":"               \u0027allow_put\u0027: False,"},{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":35,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":36,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":37,"context_line":"        \u0027network_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":38,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":39,"context_line":"                       \u0027default\u0027: None,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_3579adfd","line":36,"range":{"start_line":36,"start_character":16,"end_line":36,"end_character":27},"updated":"2016-03-11 23:00:21.000000000","message":"What does this mean in this context?  I\u0027m sure that I copied this from somewhere.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"021afb702fc78f013d9dab2444fbcbe6c78d56e2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":35,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":36,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":37,"context_line":"        \u0027network_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":38,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":39,"context_line":"                       \u0027default\u0027: None,"},{"line_number":40,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_ed85d107","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":20},"updated":"2016-03-04 22:27:11.000000000","message":"These should be using constants.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":34,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":35,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":36,"context_line":"               \u0027primary_key\u0027: True},"},{"line_number":37,"context_line":"        \u0027network_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":38,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":39,"context_line":"                       \u0027default\u0027: None,"},{"line_number":40,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_f890dc97","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":20},"in_reply_to":"7af24918_ed85d107","updated":"2016-03-11 23:00:21.000000000","message":"Done","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9b1d471601eae51189151458635fe5c30596caab","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                             \u0027allow_put\u0027: False,"},{"line_number":44,"context_line":"                             \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":45,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":46,"context_line":"        \u0027network_type\u0027: {\u0027allow_post\u0027: True,"},{"line_number":47,"context_line":"                         \u0027allow_put\u0027: False,"},{"line_number":48,"context_line":"                         \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":49,"context_line":"                         \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_37a9317c","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":44},"updated":"2016-03-03 10:11:47.000000000","message":"Now, it is impossible to specify arbitrary value for \"--provider:network_type\". Will you consider add check here to prevent illegal segment from being created.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"021afb702fc78f013d9dab2444fbcbe6c78d56e2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                             \u0027allow_put\u0027: False,"},{"line_number":44,"context_line":"                             \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":45,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":46,"context_line":"        \u0027network_type\u0027: {\u0027allow_post\u0027: True,"},{"line_number":47,"context_line":"                         \u0027allow_put\u0027: False,"},{"line_number":48,"context_line":"                         \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":49,"context_line":"                         \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_0408da27","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":44},"in_reply_to":"7af24918_37a9317c","updated":"2016-03-04 22:27:11.000000000","message":"See TODO L57.  Remember, this is a WIP.  :)","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"920ad3134cbe1ea009fe228e5082a49d73d3e030","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":50,"context_line":"        \u0027segmentation_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":51,"context_line":"                            \u0027allow_put\u0027: False,"},{"line_number":52,"context_line":"                            \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":53,"context_line":"                            \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_047aef76","line":52,"updated":"2016-03-09 19:49:51.000000000","message":"Should this be an integer?  When I do a POST, a string is expected.  However, GET will return an integer.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                         \u0027is_visible\u0027: True},"},{"line_number":50,"context_line":"        \u0027segmentation_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":51,"context_line":"                            \u0027allow_put\u0027: False,"},{"line_number":52,"context_line":"                            \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":53,"context_line":"                            \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_f8c8dc76","line":52,"in_reply_to":"5aef4532_047aef76","updated":"2016-03-11 23:00:21.000000000","message":"You\u0027re right.  This is defined as an integer in the model and the multiprovider extension validates it as an integer.  Done.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"9b1d471601eae51189151458635fe5c30596caab","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027segmentation_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":51,"context_line":"                            \u0027allow_put\u0027: False,"},{"line_number":52,"context_line":"                            \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":53,"context_line":"                            \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_770c59ed","line":53,"updated":"2016-03-03 10:11:47.000000000","message":"Since [1] will populate tenant_id to the request body. If tenant_id is not added here, the post request coming from http request will fail with \"Unrecognized attribute(s) \u0027tenant_id\u0027\"\n\n[1] https://github.com/openstack/neutron/blob/230068bf8544355d999bae2bfd6e35cbfebbb2a7/neutron/api/v2/attributes.py#L979","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f4a315cd5ef9cdd6b5f59da20c859268e6f4b735","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027segmentation_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":51,"context_line":"                            \u0027allow_put\u0027: False,"},{"line_number":52,"context_line":"                            \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":53,"context_line":"                            \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_cb48ac5e","line":53,"in_reply_to":"5aef4532_1456aecd","updated":"2016-03-11 23:00:21.000000000","message":"Done","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"40d8818f2e2dbb5db5c71f6bc05df673fee79c9f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027segmentation_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":51,"context_line":"                            \u0027allow_put\u0027: False,"},{"line_number":52,"context_line":"                            \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":53,"context_line":"                            \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_1456aecd","line":53,"in_reply_to":"7af24918_770c59ed","updated":"2016-03-09 16:47:54.000000000","message":"+1, after adding tenant_id I was able to create a segment using the OSC segment CLI.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"021afb702fc78f013d9dab2444fbcbe6c78d56e2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027segmentation_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":51,"context_line":"                            \u0027allow_put\u0027: False,"},{"line_number":52,"context_line":"                            \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":53,"context_line":"                            \u0027is_visible\u0027: True},"},{"line_number":54,"context_line":"    },"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_a49e46b6","line":53,"in_reply_to":"7af24918_770c59ed","updated":"2016-03-04 22:27:11.000000000","message":"I\u0027ll look in to this.  It is possible that I just haven\u0027t done enough testing with this yet.","commit_id":"a284d49f15720e0dfd48b64da03b9eea431db061"}],"neutron/neutron_plugin_base_v2.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4361a76c6af3c5b04fe665b8062ba6533c63c345","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        :param id: UUID representing the segment to update."},{"line_number":290,"context_line":"        :param segment: dictionary with keys indicating fields to update."},{"line_number":291,"context_line":"                        valid keys are those that have a value of True for"},{"line_number":292,"context_line":"                        \u0027allow_put\u0027 as listed in the"},{"line_number":293,"context_line":"                        :obj:`RESOURCE_ATTRIBUTE_MAP` object in"},{"line_number":294,"context_line":"                        :file:`neutron/extensions/segment.py`."},{"line_number":295,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"3afc51ec_262145a0","line":292,"updated":"2016-03-14 13:59:38.000000000","message":"Right now there aren\u0027t any fields that can be updated?  Should there be?","commit_id":"6468046b1c2ceda6f8a1f30fdc20972292feb4f9"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0abe32ea3f1115dc0a3bbd123c1a394637edd939","unresolved":false,"context_lines":[{"line_number":1647,"context_line":"    def get_workers(self):"},{"line_number":1648,"context_line":"        return self.mechanism_manager.get_workers()"},{"line_number":1649,"context_line":""},{"line_number":1650,"context_line":"    def create_segment(self, context, segment):"},{"line_number":1651,"context_line":"        session \u003d context.session"},{"line_number":1652,"context_line":"        segment_data \u003d segment[segment.SEGMENT]"},{"line_number":1653,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da0c15f0_e3362251","line":1650,"updated":"2016-03-28 09:24:42.000000000","message":"I think on all of these we are going to need to invoke a call to the mechanism drivers with update_network pre and post-commit events so they can propagate this stuff to a backend or block it if it\u0027s incompatible. Right now this is implicitly done in the create_network with the existing segment codepath.","commit_id":"b0618fbcb5f0640faba975584d718945a7ddbb72"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"de8b8c9fbb89180a7df5a9a3140cf94148271795","unresolved":false,"context_lines":[{"line_number":1652,"context_line":"        segment_data \u003d segment[segment.SEGMENT]"},{"line_number":1653,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1654,"context_line":"            result \u003d super(Ml2Plugin, self).create_segment(context, segment)"},{"line_number":1655,"context_line":"            self.type_manager.create_network_segment(context, segment_data)"},{"line_number":1656,"context_line":"            return result"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"    def update_segment(self, context, segment):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_b73704fe","line":1655,"updated":"2016-04-06 18:55:57.000000000","message":"I think there needs to be validation of the segment_data like is done by validate_provider_segment().\n\nAs I\u0027m writing the CLI, should I assume that the segment validation done when creating a provider network will also be done when creating a segment?","commit_id":"b0618fbcb5f0640faba975584d718945a7ddbb72"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d1e0f3a80c9061e3ea0af032e84f2ee3e0d50450","unresolved":false,"context_lines":[{"line_number":1652,"context_line":"        segment_data \u003d segment[segment.SEGMENT]"},{"line_number":1653,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":1654,"context_line":"            result \u003d super(Ml2Plugin, self).create_segment(context, segment)"},{"line_number":1655,"context_line":"            self.type_manager.create_network_segment(context, segment_data)"},{"line_number":1656,"context_line":"            return result"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"    def update_segment(self, context, segment):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_ecafca7a","line":1655,"in_reply_to":"9a061dce_b73704fe","updated":"2016-04-07 14:01:41.000000000","message":"I agree with this, the new patch set will add validation to the segment data.","commit_id":"b0618fbcb5f0640faba975584d718945a7ddbb72"}]}
