)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"07c4b0ba1cfce8576236bf3bac26c1b0a25f95c5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"so that we can add API methods to \"/resources\" path rather than"},{"line_number":11,"context_line":"\"/resources/action\" path."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also allow extentions to controll correspondences"},{"line_number":14,"context_line":"between action and status in API request."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_95edddf1","line":13,"updated":"2016-02-26 22:11:11.000000000","message":"Nit: \"control correspondences\"","commit_id":"28c32b4202a811d9b728a7adc09cec523a82e101"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"19a907afcacbc484d73f0a819b5a4281cd0fe1eb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch also allow extentions to control correspondences"},{"line_number":14,"context_line":"between action and status in API request."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"APIImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I862086f7528583e65d7bee794f011ddff6ae8901"},{"line_number":19,"context_line":"Partial-Implements: blueprint add-tags-to-core-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aed3d3a_b1f45587","line":16,"updated":"2016-02-28 13:41:51.000000000","message":"This commit does not change the API itself, so I don\u0027t think APIImpact is required.","commit_id":"a8ffe73df8dea84e9a652d7bf38c33a3bb4733c5"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"dbbb66cdc095167b9a3bb5d4b912b3dec96344a3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch also allow extentions to control correspondences"},{"line_number":14,"context_line":"between action and status in API request."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"APIImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I862086f7528583e65d7bee794f011ddff6ae8901"},{"line_number":19,"context_line":"Partial-Implements: blueprint add-tags-to-core-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9aed3d3a_2f061986","line":16,"in_reply_to":"9aed3d3a_b1f45587","updated":"2016-02-29 00:24:28.000000000","message":"I got it","commit_id":"a8ffe73df8dea84e9a652d7bf38c33a3bb4733c5"}],"neutron/api/extensions.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"819a7666da9a7493231a788bbaeb2b59b2859cdd","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    submap.connect(path)"},{"line_number":276,"context_line":"                    submap.connect(\"%s.:(format)\" % path)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            for action, method in six.iteritems(resource.collection_methods):"},{"line_number":279,"context_line":"                conditions \u003d dict(method\u003d[method])"},{"line_number":280,"context_line":"                path \u003d \"/%s\" % resource.collection"},{"line_number":281,"context_line":"                with mapper.submapper(controller\u003dresource.controller,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_d41df067","line":278,"range":{"start_line":278,"start_character":38,"end_line":278,"end_character":47},"updated":"2016-02-25 21:50:04.000000000","message":"it seems overkill to use six.iteritems when iterating on a small dict","commit_id":"ecf38985af2e4964e90415c029a01a980089ca86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"93f33f135af13580ceafad35dc21161aa8f59b01","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    submap.connect(path)"},{"line_number":276,"context_line":"                    submap.connect(\"%s.:(format)\" % path)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            for action, method in six.iteritems(resource.collection_methods):"},{"line_number":279,"context_line":"                conditions \u003d dict(method\u003d[method])"},{"line_number":280,"context_line":"                path \u003d \"/%s\" % resource.collection"},{"line_number":281,"context_line":"                with mapper.submapper(controller\u003dresource.controller,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_b08f7822","line":278,"range":{"start_line":278,"start_character":38,"end_line":278,"end_character":47},"in_reply_to":"9aed3d3a_7f8670ba","updated":"2016-02-26 11:39:21.000000000","message":"In general, it is unnecessary to use six.iteritems for such small dict.\nI understand your point that we already have the same pattern as well, but how about change both to xxx.items()?\n(I don\u0027t have strong opinions on this)","commit_id":"ecf38985af2e4964e90415c029a01a980089ca86"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20f7812b8095d1dc5b5f9228f924c10ac73a2927","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    submap.connect(path)"},{"line_number":276,"context_line":"                    submap.connect(\"%s.:(format)\" % path)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            for action, method in six.iteritems(resource.collection_methods):"},{"line_number":279,"context_line":"                conditions \u003d dict(method\u003d[method])"},{"line_number":280,"context_line":"                path \u003d \"/%s\" % resource.collection"},{"line_number":281,"context_line":"                with mapper.submapper(controller\u003dresource.controller,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_b902aa09","line":278,"range":{"start_line":278,"start_character":38,"end_line":278,"end_character":47},"in_reply_to":"9aed3d3a_b08f7822","updated":"2016-02-26 17:20:07.000000000","message":"I got it. However, I\u0027d like to avoid changing unrelated place in this patch. I will use xxx.items() here only and I will fix the consistency on other patch if need.","commit_id":"ecf38985af2e4964e90415c029a01a980089ca86"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"11a47fc0a0333c2563644d4b87316eab322e8644","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                    submap.connect(path)"},{"line_number":276,"context_line":"                    submap.connect(\"%s.:(format)\" % path)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"            for action, method in six.iteritems(resource.collection_methods):"},{"line_number":279,"context_line":"                conditions \u003d dict(method\u003d[method])"},{"line_number":280,"context_line":"                path \u003d \"/%s\" % resource.collection"},{"line_number":281,"context_line":"                with mapper.submapper(controller\u003dresource.controller,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_7f8670ba","line":278,"range":{"start_line":278,"start_character":38,"end_line":278,"end_character":47},"in_reply_to":"9aed3d3a_d41df067","updated":"2016-02-26 04:16:36.000000000","message":"I can understand but it\u0027s used on L268 too and I prefer consistency of code.","commit_id":"ecf38985af2e4964e90415c029a01a980089ca86"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"93f33f135af13580ceafad35dc21161aa8f59b01","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                with mapper.submapper(controller\u003dresource.controller,"},{"line_number":282,"context_line":"                                      action\u003daction,"},{"line_number":283,"context_line":"                                      path_prefix\u003dpath_prefix,"},{"line_number":284,"context_line":"                                      conditions\u003dconditions) as submap:"},{"line_number":285,"context_line":"                    submap.connect(path)"},{"line_number":286,"context_line":"                    submap.connect(\"%s.:(format)\" % path)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_217ddc1c","line":284,"updated":"2016-02-26 11:39:21.000000000","message":"Question: when we define custom methods for collections, what happens for the default methods for collections? I guess GET/POST are defined. Are they overridden?","commit_id":"ecf38985af2e4964e90415c029a01a980089ca86"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"20f7812b8095d1dc5b5f9228f924c10ac73a2927","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                with mapper.submapper(controller\u003dresource.controller,"},{"line_number":282,"context_line":"                                      action\u003daction,"},{"line_number":283,"context_line":"                                      path_prefix\u003dpath_prefix,"},{"line_number":284,"context_line":"                                      conditions\u003dconditions) as submap:"},{"line_number":285,"context_line":"                    submap.connect(path)"},{"line_number":286,"context_line":"                    submap.connect(\"%s.:(format)\" % path)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_19891627","line":284,"in_reply_to":"9aed3d3a_217ddc1c","updated":"2016-02-26 17:20:07.000000000","message":"No. Maybe tag patch[1] may show the answer to you. Tag uses this custom methods and adds \"PUT\" and \"DELETE\" behavior in \"/tags\" case but other methods(GET, POST) are not overridden.\n\n[1]: https://review.openstack.org/#/c/273881/19/neutron/extensions/tag.py","commit_id":"ecf38985af2e4964e90415c029a01a980089ca86"}]}
