)]}'
{"quantum/db/db_base_plugin_v2.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a5428c69c9af20b1d3b0e196182b5b5a2adfce83","unresolved":false,"context_lines":[{"line_number":996,"context_line":"            network \u003d models_v2.Network(**args)"},{"line_number":997,"context_line":"            context.session.add(network)"},{"line_number":998,"context_line":"        LOG.warn(\"#### INPUT:%s\", n)"},{"line_number":999,"context_line":"        LOG.warn(\"#### NETWORK:%s\", network)"},{"line_number":1000,"context_line":"        return self._make_network_dict(network)"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"    def update_network(self, context, id, network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FfRQ%3D","line":999,"updated":"2013-05-08 04:17:12.000000000","message":"you forget remove this. :)","commit_id":"76f47c3e44d99a5f12d2d5b37bc8d81d715e24ad"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":996,"context_line":"            network \u003d models_v2.Network(**args)"},{"line_number":997,"context_line":"            context.session.add(network)"},{"line_number":998,"context_line":"        LOG.warn(\"#### INPUT:%s\", n)"},{"line_number":999,"context_line":"        LOG.warn(\"#### NETWORK:%s\", network)"},{"line_number":1000,"context_line":"        return self._make_network_dict(network)"},{"line_number":1001,"context_line":""},{"line_number":1002,"context_line":"    def update_network(self, context, id, network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FaZM%3D","line":999,"in_reply_to":"AAAAOn%2F%2FfRQ%3D","updated":"2013-05-10 13:16:36.000000000","message":"Done","commit_id":"76f47c3e44d99a5f12d2d5b37bc8d81d715e24ad"}],"quantum/db/l3_db.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a5428c69c9af20b1d3b0e196182b5b5a2adfce83","unresolved":false,"context_lines":[{"line_number":824,"context_line":""},{"line_number":825,"context_line":"        existing_value \u003d self._network_is_external(context, net_id)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        if existing_value \u003d\u003d new_value:"},{"line_number":828,"context_line":"            return"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        if new_value:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FfPo%3D","line":827,"updated":"2013-05-08 04:17:12.000000000","message":"net_data include the value of external.  it should be \u0027 if net_data[\u0027external\u0027] \u003d\u003d net_value:\u0027. So line 825 is needless.","commit_id":"76f47c3e44d99a5f12d2d5b37bc8d81d715e24ad"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":824,"context_line":""},{"line_number":825,"context_line":"        existing_value \u003d self._network_is_external(context, net_id)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        if existing_value \u003d\u003d new_value:"},{"line_number":828,"context_line":"            return"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        if new_value:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FaZE%3D","line":827,"in_reply_to":"AAAAOn%2F%2FfPo%3D","updated":"2013-05-10 13:16:36.000000000","message":"I spotted that too but did not want to change unrelated code.\nwill do anyway","commit_id":"76f47c3e44d99a5f12d2d5b37bc8d81d715e24ad"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"b77b9a09509e8e34361cb2bc80953c314f2c401e","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            # allow it to be update to external\u003dFalse"},{"line_number":841,"context_line":"            port \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":842,"context_line":"                device_owner\u003dDEVICE_OWNER_ROUTER_GW,"},{"line_number":843,"context_line":"                network_id\u003dnet_data[\u0027id\u0027]).first()"},{"line_number":844,"context_line":"            if port:"},{"line_number":845,"context_line":"                raise l3.ExternalNetworkInUse(net_id\u003dnet_id)"},{"line_number":846,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FYR8%3D","line":843,"updated":"2013-05-12 21:17:35.000000000","message":"nit: may reuse net_id","commit_id":"ca82088951cbd544222fe1503b599dc6eb8944c0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":65,"context_line":"                           primary_key\u003dTrue)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    # Add a relationship to the Network model in order to instruct"},{"line_number":68,"context_line":"    # SQLAlchemy to eagerly load this association"},{"line_number":69,"context_line":"    network \u003d orm.relationship("},{"line_number":70,"context_line":"        models_v2.Network,"},{"line_number":71,"context_line":"        backref\u003dorm.backref(\"external\", lazy\u003d\u0027joined\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F%2Bog%3D","line":68,"updated":"2013-06-16 06:49:59.000000000","message":"I am never really sure - does this require a database migration?","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":65,"context_line":"                           primary_key\u003dTrue)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    # Add a relationship to the Network model in order to instruct"},{"line_number":68,"context_line":"    # SQLAlchemy to eagerly load this association"},{"line_number":69,"context_line":"    network \u003d orm.relationship("},{"line_number":70,"context_line":"        models_v2.Network,"},{"line_number":71,"context_line":"        backref\u003dorm.backref(\"external\", lazy\u003d\u0027joined\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F%2BeU%3D","line":68,"in_reply_to":"AAAAPn%2F%2F%2Bog%3D","updated":"2013-06-16 14:01:27.000000000","message":"This just controls how sqlalchemy behaves and does not affect database schema. I don\u0027t think it requires a dbmigration.","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":822,"context_line":"            return"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        existing_value \u003d (net_data.get(l3.EXTERNAL) or"},{"line_number":825,"context_line":"                          self._network_is_external(context, net_id))"},{"line_number":826,"context_line":"        if existing_value \u003d\u003d new_value:"},{"line_number":827,"context_line":"            return"},{"line_number":828,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F%2BDo%3D","line":825,"updated":"2013-06-17 04:06:48.000000000","message":"why do we still need to call self._network_is_external(context, net_id)?","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":822,"context_line":"            return"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        existing_value \u003d (net_data.get(l3.EXTERNAL) or"},{"line_number":825,"context_line":"                          self._network_is_external(context, net_id))"},{"line_number":826,"context_line":"        if existing_value \u003d\u003d new_value:"},{"line_number":827,"context_line":"            return"},{"line_number":828,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F9as%3D","line":825,"in_reply_to":"AAAAPn%2F%2F%2BDo%3D","updated":"2013-06-17 12:03:05.000000000","message":"Because this is process_l3_update, and the input data might not contain router:external (for instance you\u0027ve updated just the name)","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":822,"context_line":"            return"},{"line_number":823,"context_line":""},{"line_number":824,"context_line":"        existing_value \u003d (net_data.get(l3.EXTERNAL) or"},{"line_number":825,"context_line":"                          self._network_is_external(context, net_id))"},{"line_number":826,"context_line":"        if existing_value \u003d\u003d new_value:"},{"line_number":827,"context_line":"            return"},{"line_number":828,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F9SY%3D","line":825,"in_reply_to":"AAAAPn%2F%2F9as%3D","updated":"2013-06-17 13:17:50.000000000","message":"existing_value should be value currently in db. _process_l3_update is called by plugin\u0027s update_network, and the net_data parameter is the whole network, not the input data.","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"}],"quantum/plugins/midonet/plugin.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":218,"context_line":"        LOG.debug(_(\"MidonetPluginV2.get_network exiting: qnet\u003d%r\"), qnet)"},{"line_number":219,"context_line":"        return qnet"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":222,"context_line":"        \"\"\"List quantum networks and verify that all exist in MidoNet.\"\"\""},{"line_number":223,"context_line":"        LOG.debug(_(\"MidonetPluginV2.get_networks called: \""},{"line_number":224,"context_line":"                    \"filters\u003d%(filters)r, fields\u003d%(fields)r\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F%2BDg%3D","line":221,"updated":"2013-06-17 04:06:48.000000000","message":"why not delete this overriding completely?","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":218,"context_line":"        LOG.debug(_(\"MidonetPluginV2.get_network exiting: qnet\u003d%r\"), qnet)"},{"line_number":219,"context_line":"        return qnet"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":222,"context_line":"        \"\"\"List quantum networks and verify that all exist in MidoNet.\"\"\""},{"line_number":223,"context_line":"        LOG.debug(_(\"MidonetPluginV2.get_networks called: \""},{"line_number":224,"context_line":"                    \"filters\u003d%(filters)r, fields\u003d%(fields)r\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F9ak%3D","line":221,"in_reply_to":"AAAAPn%2F%2F%2BDg%3D","updated":"2013-06-17 12:03:05.000000000","message":"right. I forgot to do that.","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                    prefix)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"            # For external network, link the bridge to the provider router."},{"line_number":117,"context_line":"            # router"},{"line_number":118,"context_line":"            if net[\u0027router:external\u0027]:"},{"line_number":119,"context_line":"                gateway_ip \u003d sn_entry[\u0027gateway_ip\u0027]"},{"line_number":120,"context_line":"                network_address, length \u003d sn_entry[\u0027cidr\u0027].split(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FdWY%3D","line":117,"updated":"2013-07-01 14:52:44.000000000","message":"Not sure we need this one word comment.","commit_id":"19b0ae1ba5dba7ddcd0c6abc8ccbba9b9ca94d33"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                    prefix)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"            # For external network, link the bridge to the provider router."},{"line_number":117,"context_line":"            # router"},{"line_number":118,"context_line":"            if net[\u0027router:external\u0027]:"},{"line_number":119,"context_line":"                gateway_ip \u003d sn_entry[\u0027gateway_ip\u0027]"},{"line_number":120,"context_line":"                network_address, length \u003d sn_entry[\u0027cidr\u0027].split(\u0027/\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FdO0%3D","line":117,"in_reply_to":"AAAAPn%2F%2FdWY%3D","updated":"2013-07-01 15:37:43.000000000","message":"And I\u0027m not sure how that comment ended up there","commit_id":"19b0ae1ba5dba7ddcd0c6abc8ccbba9b9ca94d33"}],"quantum/plugins/nec/nec_plugin.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":365,"context_line":"        nets \u003d super(NECPluginV2, self).get_networks(context, filters, None)"},{"line_number":366,"context_line":"        return [self._fields(net, fields) for net in nets]"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def _extend_port_dict_binding(self, context, port):"},{"line_number":369,"context_line":"        port[portbindings.VIF_TYPE] \u003d portbindings.VIF_TYPE_OVS"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F%2BDY%3D","line":366,"updated":"2013-06-17 04:06:48.000000000","message":"remove get_network(s)","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":365,"context_line":"        nets \u003d super(NECPluginV2, self).get_networks(context, filters, None)"},{"line_number":366,"context_line":"        return [self._fields(net, fields) for net in nets]"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def _extend_port_dict_binding(self, context, port):"},{"line_number":369,"context_line":"        port[portbindings.VIF_TYPE] \u003d portbindings.VIF_TYPE_OVS"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F9aY%3D","line":366,"in_reply_to":"AAAAPn%2F%2F%2BDY%3D","updated":"2013-06-17 12:03:05.000000000","message":"will do","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"}],"quantum/plugins/ryu/ryu_quantum_plugin.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":188,"context_line":"        return self._fields(net, fields)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":191,"context_line":"        nets \u003d super(RyuQuantumPluginV2, self).get_networks(context, filters,"},{"line_number":192,"context_line":"                                                            None)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        return [self._fields(net, fields) for net in nets]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F%2BDQ%3D","line":191,"updated":"2013-06-17 04:06:48.000000000","message":"remove get_network(s)","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":188,"context_line":"        return self._fields(net, fields)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def get_networks(self, context, filters\u003dNone, fields\u003dNone):"},{"line_number":191,"context_line":"        nets \u003d super(RyuQuantumPluginV2, self).get_networks(context, filters,"},{"line_number":192,"context_line":"                                                            None)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        return [self._fields(net, fields) for net in nets]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2F9aU%3D","line":191,"in_reply_to":"AAAAPn%2F%2F%2BDQ%3D","updated":"2013-06-17 12:03:05.000000000","message":"will do","commit_id":"f544f3f9e4bf918ee07498470e4ace1592b099cf"}]}
