)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     armando-migliaccio \u003camigliaccio@nicira.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-08 02:02:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log a warning if dnsmasq version is below the minimum required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It has been noted that older versions of dnsmasq may have unexpected"},{"line_number":10,"context_line":"behavior, so this patch introduces a check on dnsmasq version; if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2Fer8%3D","line":7,"updated":"2013-05-08 12:27:24.000000000","message":"Would it be worthwhile considering making changes to the parameters passed to the dnsmasq according to the version discovered?","commit_id":"364032897293256436647cb89c61a3dffb408946"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     armando-migliaccio \u003camigliaccio@nicira.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-08 02:02:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log a warning if dnsmasq version is below the minimum required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It has been noted that older versions of dnsmasq may have unexpected"},{"line_number":10,"context_line":"behavior, so this patch introduces a check on dnsmasq version; if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2Feng%3D","line":7,"in_reply_to":"AAAAOn%2F%2FeqU%3D","updated":"2013-05-08 13:45:44.000000000","message":"Yes, I guess that we could do it in an additional patch.\n\nSay for example there are versions that do not support the tags (version 2.48). One option would be to set the flags according to the version.\n\nMaybe it is an overkill.\n\nAt least your patch will help identify the source of the issues.","commit_id":"364032897293256436647cb89c61a3dffb408946"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     armando-migliaccio \u003camigliaccio@nicira.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-05-08 02:02:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log a warning if dnsmasq version is below the minimum required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It has been noted that older versions of dnsmasq may have unexpected"},{"line_number":10,"context_line":"behavior, so this patch introduces a check on dnsmasq version; if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2FeqU%3D","line":7,"in_reply_to":"AAAAOn%2F%2Fer8%3D","updated":"2013-05-08 12:57:18.000000000","message":"What are you thinking of exactly? If we went ahead and do so, wouldn\u0027t this be part of another patch?","commit_id":"364032897293256436647cb89c61a3dffb408946"}],"quantum/agent/linux/dhcp.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1cb7053b99b7c25b4439ec989aead3ea93c31d3c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            is_valid_version \u003d float(ver) \u003e\u003d cls.MINIMUM_VERSION"},{"line_number":234,"context_line":"            if not is_valid_version:"},{"line_number":235,"context_line":"                LOG.warning(_(\u0027FAILED VERSION REQUIREMENT FOR DNSMASQ. \u0027"},{"line_number":236,"context_line":"                              \u0027DHCP AGENT MAY NOT RUN CORRECTLY!\u0027))"},{"line_number":237,"context_line":"        except (RuntimeError, IndexError, ValueError):"},{"line_number":238,"context_line":"            LOG.warning(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":239,"context_line":"                          \u0027Please ensure that its version is %s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FfS0%3D","line":236,"updated":"2013-05-08 03:08:33.000000000","message":"How about show the right version for user that here. Like line 238","commit_id":"cd4efbfaa77831b072742f4c9ceb53d4b6e7bce8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":233,"context_line":"            is_valid_version \u003d float(ver) \u003e\u003d cls.MINIMUM_VERSION"},{"line_number":234,"context_line":"            if not is_valid_version:"},{"line_number":235,"context_line":"                LOG.warning(_(\u0027FAILED VERSION REQUIREMENT FOR DNSMASQ. \u0027"},{"line_number":236,"context_line":"                              \u0027DHCP AGENT MAY NOT RUN CORRECTLY!\u0027))"},{"line_number":237,"context_line":"        except (RuntimeError, IndexError, ValueError):"},{"line_number":238,"context_line":"            LOG.warning(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":239,"context_line":"                          \u0027Please ensure that its version is %s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fe8s%3D","line":236,"in_reply_to":"AAAAOn%2F%2FfS0%3D","updated":"2013-05-08 08:45:52.000000000","message":"Can do.","commit_id":"cd4efbfaa77831b072742f4c9ceb53d4b6e7bce8"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"65dbb338c113fa8ac2579190706b34a6619e8257","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            LOG.warning(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":239,"context_line":"                          \u0027Please ensure that its version is %s \u0027"},{"line_number":240,"context_line":"                          \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":241,"context_line":"        return is_valid_version"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @classmethod"},{"line_number":244,"context_line":"    def existing_dhcp_networks(cls, conf, root_helper):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FfM4%3D","line":241,"updated":"2013-05-08 05:46:50.000000000","message":"return value is not used in caller","commit_id":"cd4efbfaa77831b072742f4c9ceb53d4b6e7bce8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":238,"context_line":"            LOG.warning(_(\u0027Unable to determine dnsmasq version. \u0027"},{"line_number":239,"context_line":"                          \u0027Please ensure that its version is %s \u0027"},{"line_number":240,"context_line":"                          \u0027or above!\u0027), cls.MINIMUM_VERSION)"},{"line_number":241,"context_line":"        return is_valid_version"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    @classmethod"},{"line_number":244,"context_line":"    def existing_dhcp_networks(cls, conf, root_helper):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fe8o%3D","line":241,"in_reply_to":"AAAAOn%2F%2FfM4%3D","updated":"2013-05-08 08:45:52.000000000","message":"True, but that\u0027s up to the caller.","commit_id":"cd4efbfaa77831b072742f4c9ceb53d4b6e7bce8"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"0dfe7c9ed94ee9d53d371957d8eaf162bf86ece5","unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    @classmethod"},{"line_number":227,"context_line":"    def check_version(cls, root_helper):"},{"line_number":228,"context_line":"        is_valid_version \u003d None"},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":231,"context_line":"            out \u003d utils.execute(cmd, root_helper)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FezM%3D","line":228,"updated":"2013-05-08 10:45:00.000000000","message":"Why not false, instead of none?","commit_id":"364032897293256436647cb89c61a3dffb408946"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    @classmethod"},{"line_number":227,"context_line":"    def check_version(cls, root_helper):"},{"line_number":228,"context_line":"        is_valid_version \u003d None"},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":231,"context_line":"            out \u003d utils.execute(cmd, root_helper)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeqQ%3D","line":228,"in_reply_to":"AAAAOn%2F%2FezM%3D","updated":"2013-05-08 12:57:18.000000000","message":"None is returned in case the version couldn\u0027t be checked. False if the check fails, True if it succeeds. If I set it to False here, I would need to set it to None in the except block.","commit_id":"364032897293256436647cb89c61a3dffb408946"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":232,"context_line":"            ver \u003d re.findall(\"\\d+.\\d+\", out)[0]"},{"line_number":233,"context_line":"            is_valid_version \u003d float(ver) \u003e\u003d cls.MINIMUM_VERSION"},{"line_number":234,"context_line":"            if not is_valid_version:"},{"line_number":235,"context_line":"                LOG.warning(_(\u0027FAILED VERSION REQUIREMENT FOR DNSMASQ. \u0027"},{"line_number":236,"context_line":"                              \u0027DHCP AGENT MAY NOT RUN CORRECTLY! \u0027"},{"line_number":237,"context_line":"                              \u0027Please ensure that its version is %s \u0027"},{"line_number":238,"context_line":"                              \u0027or above!\u0027), cls.MINIMUM_VERSION)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeNY%3D","line":235,"updated":"2013-05-08 17:15:47.000000000","message":"nit: may be, we should use small letter for constant log format.","commit_id":"364032897293256436647cb89c61a3dffb408946"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":232,"context_line":"            ver \u003d re.findall(\"\\d+.\\d+\", out)[0]"},{"line_number":233,"context_line":"            is_valid_version \u003d float(ver) \u003e\u003d cls.MINIMUM_VERSION"},{"line_number":234,"context_line":"            if not is_valid_version:"},{"line_number":235,"context_line":"                LOG.warning(_(\u0027FAILED VERSION REQUIREMENT FOR DNSMASQ. \u0027"},{"line_number":236,"context_line":"                              \u0027DHCP AGENT MAY NOT RUN CORRECTLY! \u0027"},{"line_number":237,"context_line":"                              \u0027Please ensure that its version is %s \u0027"},{"line_number":238,"context_line":"                              \u0027or above!\u0027), cls.MINIMUM_VERSION)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fagw%3D","line":235,"in_reply_to":"AAAAOn%2F%2FeME%3D","updated":"2013-05-10 12:19:47.000000000","message":"If you want to catch my attention, you should put something like \"You\u0027ve won the Openstack admin lottery!\"\n\nSeriously, I have no opinion on lower vs uppercase.","commit_id":"364032897293256436647cb89c61a3dffb408946"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":232,"context_line":"            ver \u003d re.findall(\"\\d+.\\d+\", out)[0]"},{"line_number":233,"context_line":"            is_valid_version \u003d float(ver) \u003e\u003d cls.MINIMUM_VERSION"},{"line_number":234,"context_line":"            if not is_valid_version:"},{"line_number":235,"context_line":"                LOG.warning(_(\u0027FAILED VERSION REQUIREMENT FOR DNSMASQ. \u0027"},{"line_number":236,"context_line":"                              \u0027DHCP AGENT MAY NOT RUN CORRECTLY! \u0027"},{"line_number":237,"context_line":"                              \u0027Please ensure that its version is %s \u0027"},{"line_number":238,"context_line":"                              \u0027or above!\u0027), cls.MINIMUM_VERSION)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeME%3D","line":235,"in_reply_to":"AAAAOn%2F%2FeNY%3D","updated":"2013-05-08 17:23:34.000000000","message":"Reason why I chose all upper cases is to catch the admin\u0027s eye. Some warning messages are more harmless than others, so a trained eye may decide to skip reading :)\n\nIf you think it\u0027s not appropriate, I can go lower case and log at an error level.","commit_id":"364032897293256436647cb89c61a3dffb408946"}]}
