)]}'
{"quantum/plugins/cisco/common/cisco_exceptions.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c5b557757f820847a9763dfb5b3b184833ecb9c8","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    message \u003d _(\"Connection to %(host)s is not configured.\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NexusPortBindingNotFound(exceptions.QuantumException):"},{"line_number":88,"context_line":"    \"\"\"NexusPort Binding is not present.\"\"\""},{"line_number":89,"context_line":"    message \u003d _(\"Nexus Port Binding (%(filters)s) is not present\")"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Feys%3D","line":87,"updated":"2013-05-08 11:13:05.000000000","message":"Nit: Keep in same position as original class definition so diff better shows the changes.","commit_id":"66e91af6bf9a21874641c2ecc7892cb7de86c227"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    message \u003d _(\"Connection to %(host)s is not configured.\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class NexusPortBindingNotFound(exceptions.QuantumException):"},{"line_number":88,"context_line":"    \"\"\"NexusPort Binding is not present.\"\"\""},{"line_number":89,"context_line":"    message \u003d _(\"Nexus Port Binding (%(filters)s) is not present\")"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fep4%3D","line":87,"in_reply_to":"AAAAOn%2F%2Feys%3D","updated":"2013-05-08 15:12:11.000000000","message":"Done","commit_id":"66e91af6bf9a21874641c2ecc7892cb7de86c227"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":99,"context_line":"    message \u003d _(\"Nexus Port Binding (%(filters)s) is not present\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __init__(self, **kwargs):"},{"line_number":102,"context_line":"        filters \u003d \u0027,\u0027.join(\u0027%s\u003d%s\u0027 % (k, v) for k, v in kwargs.items())"},{"line_number":103,"context_line":"        super(NexusPortBindingNotFound, self).__init__(filters\u003dfilters)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeGw%3D","line":102,"updated":"2013-05-08 18:05:44.000000000","message":"filters \u003d \u0027,\u0027.join(\u0027%s\u003d%s\u0027 % i for i kwargs.items())","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    message \u003d _(\"Nexus Port Binding (%(filters)s) is not present\")"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def __init__(self, **kwargs):"},{"line_number":102,"context_line":"        filters \u003d \u0027,\u0027.join(\u0027%s\u003d%s\u0027 % (k, v) for k, v in kwargs.items())"},{"line_number":103,"context_line":"        super(NexusPortBindingNotFound, self).__init__(filters\u003dfilters)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fd84%3D","line":102,"in_reply_to":"AAAAOn%2F%2FeGw%3D","updated":"2013-05-08 19:20:20.000000000","message":"Done","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"}],"quantum/plugins/cisco/db/nexus_db_v2.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c5b557757f820847a9763dfb5b3b184833ecb9c8","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if not bindings:"},{"line_number":50,"context_line":"        raise c_exc.NexusPortBindingNotFound(vlan_id\u003dvlan_id,"},{"line_number":51,"context_line":"                                             port_id\u003dport_id,"},{"line_number":52,"context_line":"                                             switch_ip\u003dswitch_ip,"},{"line_number":53,"context_line":"                                             instance_id\u003dinstance_id)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Feyg%3D","line":51,"updated":"2013-05-08 11:13:05.000000000","message":"Nit: is this just a display issue in the review, or are the rest of the arguments not lined up with the first argument? Here and following functions...","commit_id":"66e91af6bf9a21874641c2ecc7892cb7de86c227"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if not bindings:"},{"line_number":50,"context_line":"        raise c_exc.NexusPortBindingNotFound(vlan_id\u003dvlan_id,"},{"line_number":51,"context_line":"                                             port_id\u003dport_id,"},{"line_number":52,"context_line":"                                             switch_ip\u003dswitch_ip,"},{"line_number":53,"context_line":"                                             instance_id\u003dinstance_id)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Feo4%3D","line":51,"in_reply_to":"AAAAOn%2F%2Feyg%3D","updated":"2013-05-08 15:12:11.000000000","message":"It seems to be a display issue. The arguments are lined up and PEP8 check doesn\u0027t complain.","commit_id":"66e91af6bf9a21874641c2ecc7892cb7de86c227"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c5b557757f820847a9763dfb5b3b184833ecb9c8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"               filter_by(instance_id\u003dinstance_id)."},{"line_number":123,"context_line":"               filter_by(vlan_id\u003dvlan_id).first())"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    if binding is None:"},{"line_number":126,"context_line":"        raise c_exc.NexusPortBindingNotFound(vlan_id\u003dvlan_id,"},{"line_number":127,"context_line":"                                             instance_id\u003dinstance_id)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fexw%3D","line":125,"updated":"2013-05-08 11:13:05.000000000","message":"Consistency of if clauses in this file. Two using \"if not bindings\", and this using \"if binding is None\".","commit_id":"66e91af6bf9a21874641c2ecc7892cb7de86c227"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":122,"context_line":"               filter_by(instance_id\u003dinstance_id)."},{"line_number":123,"context_line":"               filter_by(vlan_id\u003dvlan_id).first())"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    if binding is None:"},{"line_number":126,"context_line":"        raise c_exc.NexusPortBindingNotFound(vlan_id\u003dvlan_id,"},{"line_number":127,"context_line":"                                             instance_id\u003dinstance_id)"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FepM%3D","line":125,"in_reply_to":"AAAAOn%2F%2Fexw%3D","updated":"2013-05-08 15:12:11.000000000","message":"Done","commit_id":"66e91af6bf9a21874641c2ecc7892cb7de86c227"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"    session \u003d db.get_session()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    bindings \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":45,"context_line":"                filter_by(vlan_id\u003dvlan_id).filter_by(switch_ip\u003dswitch_ip)."},{"line_number":46,"context_line":"                filter_by(port_id\u003dport_id)."},{"line_number":47,"context_line":"                filter_by(instance_id\u003dinstance_id).all())"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeGg%3D","line":45,"updated":"2013-05-08 18:05:44.000000000","message":"No need to chain filter_by this way can put them all into one.\n\n.filter_by(vlan_id\u003dvlan_id, switch_ip\u003dswitch_ip, port_id\u003dport_id, ...)","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    session \u003d db.get_session()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    bindings \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":45,"context_line":"                filter_by(vlan_id\u003dvlan_id).filter_by(switch_ip\u003dswitch_ip)."},{"line_number":46,"context_line":"                filter_by(port_id\u003dport_id)."},{"line_number":47,"context_line":"                filter_by(instance_id\u003dinstance_id).all())"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fd74%3D","line":45,"in_reply_to":"AAAAOn%2F%2FeGg%3D","updated":"2013-05-08 19:20:20.000000000","message":"Done","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"    LOG.debug(_(\"get_nexusvlan_binding() called\"))"},{"line_number":61,"context_line":"    session \u003d db.get_session()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    bindings \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":64,"context_line":"                filter_by(vlan_id\u003dvlan_id).filter_by(switch_ip\u003dswitch_ip)."},{"line_number":65,"context_line":"                all())"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeGY%3D","line":63,"updated":"2013-05-08 18:05:44.000000000","message":"Same as above.","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    LOG.debug(_(\"get_nexusvlan_binding() called\"))"},{"line_number":61,"context_line":"    session \u003d db.get_session()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    bindings \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":64,"context_line":"                filter_by(vlan_id\u003dvlan_id).filter_by(switch_ip\u003dswitch_ip)."},{"line_number":65,"context_line":"                all())"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fd7s%3D","line":63,"in_reply_to":"AAAAOn%2F%2FeGY%3D","updated":"2013-05-08 19:20:20.000000000","message":"Done","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":118,"context_line":"    LOG.debug(_(\"get_nexusvm_binding() called\"))"},{"line_number":119,"context_line":"    session \u003d db.get_session()"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    binding \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":122,"context_line":"               filter_by(instance_id\u003dinstance_id)."},{"line_number":123,"context_line":"               filter_by(vlan_id\u003dvlan_id).first())"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeGQ%3D","line":121,"updated":"2013-05-08 18:05:44.000000000","message":"Same as above.","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    LOG.debug(_(\"get_nexusvm_binding() called\"))"},{"line_number":119,"context_line":"    session \u003d db.get_session()"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    binding \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":122,"context_line":"               filter_by(instance_id\u003dinstance_id)."},{"line_number":123,"context_line":"               filter_by(vlan_id\u003dvlan_id).first())"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fd7g%3D","line":121,"in_reply_to":"AAAAOn%2F%2FeGQ%3D","updated":"2013-05-08 19:20:20.000000000","message":"Done","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":134,"context_line":"    LOG.debug(_(\"get_port_vlan_switch_binding() called\"))"},{"line_number":135,"context_line":"    session \u003d db.get_session()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    bindings \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":138,"context_line":"                filter_by(port_id\u003dport_id).filter_by(switch_ip\u003dswitch_ip)."},{"line_number":139,"context_line":"                filter_by(vlan_id\u003dvlan_id).all())"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FeGM%3D","line":137,"updated":"2013-05-08 18:05:44.000000000","message":"Same as above.","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"92ef5fd67a52886452567aeefdded45112e6e794","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    LOG.debug(_(\"get_port_vlan_switch_binding() called\"))"},{"line_number":135,"context_line":"    session \u003d db.get_session()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    bindings \u003d (session.query(nexus_models_v2.NexusPortBinding)."},{"line_number":138,"context_line":"                filter_by(port_id\u003dport_id).filter_by(switch_ip\u003dswitch_ip)."},{"line_number":139,"context_line":"                filter_by(vlan_id\u003dvlan_id).all())"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fd7c%3D","line":137,"in_reply_to":"AAAAOn%2F%2FeGM%3D","updated":"2013-05-08 19:20:20.000000000","message":"Done","commit_id":"20e36aa7e7094007972161a2be6bf9ca4f52c24a"}]}