)]}'
{"neutron/db/sqlalchemytypes.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59a58c3e688bf1c377fd6b5b86e06b2c12121503","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        return netaddr.IPNetwork(value)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def process_bind_param(self, value, dialect):"},{"line_number":38,"context_line":"        return str(value)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_01fcbcb6","line":38,"updated":"2016-02-29 10:40:07.000000000","message":"There was a concern before in IPAddress patch that we probably need to validate the type of the value before allowing its string representation into the database.","commit_id":"e26a0d8a70744952deabae8550a277e222a60976"}],"neutron/tests/tools.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4ff6434d1a7dac7e4ae5569085e6b0d01cc19924","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return \u002710.%d.%d.0/%d\u0027 % (random.randint(3, 254),"},{"line_number":212,"context_line":"                                  random.randint(3, 254),"},{"line_number":213,"context_line":"                                  random.randint(16, 24))"},{"line_number":214,"context_line":"    return \u00272001::dfef:%x/\u0026d\u0027 % (random.getrandbits(16),"},{"line_number":215,"context_line":"                                 random.randint(64, 128))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_4b6a51b4","line":214,"updated":"2016-02-29 14:55:45.000000000","message":"nit: s/dfef/db8","commit_id":"e26a0d8a70744952deabae8550a277e222a60976"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"303d7e79e991dd9fda76122caf799ff333b869d7","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    if version \u003d\u003d 4:"},{"line_number":202,"context_line":"        return \u002710.%d.%d.0/%d\u0027 % (random.randint(3, 254),"},{"line_number":203,"context_line":"                                  random.randint(3, 254),"},{"line_number":204,"context_line":"                                  random.randint(16, 24))"},{"line_number":205,"context_line":"    return \u00272001:db8:%x::/\u0026d\u0027 % (random.getrandbits(16),"},{"line_number":206,"context_line":"                                 random.randint(64, 128))"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_0aa58303","line":204,"updated":"2016-03-15 12:48:38.000000000","message":"I wouldn\u0027t use randint here but simply 24 to be able to produce CIDR that makes sense. Since the last 8 bits will be 0, if we set a /24 we will have for every of the random values a subnet address that it\u0027s valid. If we have random values from /16 to /24 in this line then we have to calculate the subnet address accordingly and we want to avoid that.","commit_id":"ffd226e280fd3def067e38acab974d0f1e404d6e"}],"neutron/tests/unit/db/test_db.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2c34c6f1bee410c69ced511086f0aaf32f3a3fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9aed3d3a_eb98e11d","line":1,"updated":"2016-02-26 16:03:50.000000000","message":"Is this empty file required?","commit_id":"e26a0d8a70744952deabae8550a277e222a60976"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"59a58c3e688bf1c377fd6b5b86e06b2c12121503","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9aed3d3a_613308ac","line":1,"in_reply_to":"9aed3d3a_eb98e11d","updated":"2016-02-29 10:40:07.000000000","message":"Should be removed.","commit_id":"e26a0d8a70744952deabae8550a277e222a60976"}],"neutron/tests/unit/db/test_sqlalchemytypes.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"2c34c6f1bee410c69ced511086f0aaf32f3a3fbf","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        self.assertEqual(0, len(objs))"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def test_wrong_cidr(self):"},{"line_number":198,"context_line":"        wrong_cidrs \u003d [\"10.500.0.5/24\", \"10.0.0.1/40\"]"},{"line_number":199,"context_line":"        for cidr in wrong_cidrs:"},{"line_number":200,"context_line":"            self._add_row(uuidutils.generate_uuid(), cidr)"},{"line_number":201,"context_line":"            obj \u003d self._get_one(cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_0bc8a521","line":198,"updated":"2016-02-26 16:03:50.000000000","message":"What about to include another with more than three dots? Or any invalid character.","commit_id":"e26a0d8a70744952deabae8550a277e222a60976"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7d760a76f16a03db76a67b82a0441f906b399f1f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            self.test_table.insert().values(id\u003dident, cidr\u003dcidr))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _get_one(self, value):"},{"line_number":134,"context_line":"        row_select \u003d self.test_table.select().\\"},{"line_number":135,"context_line":"            where(self.test_table.c.cidr \u003d\u003d value)"},{"line_number":136,"context_line":"        return self.engine.execute(row_select).first()"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _get_all(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_853dbdbd","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":50},"updated":"2016-03-14 10:31:13.000000000","message":"Brackets are preferable over backslash","commit_id":"01596a18bd8c7ba83777166dcc326f80f62b3a74"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"502a730d7d4b8dc8e1c0d9ce1635ffa015dc2d32","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self._add_row(uuidutils.generate_uuid(), cidr)"},{"line_number":158,"context_line":"            obj \u003d self._get_one(cidr)"},{"line_number":159,"context_line":"            self.assertEqual(cidr, obj[\u0027cidr\u0027])"},{"line_number":160,"context_line":"            random_cidr \u003d netaddr.IPNetwork(tools.get_random_cidr())"},{"line_number":161,"context_line":"            self._update_row(cidr, random_cidr)"},{"line_number":162,"context_line":"            obj \u003d self._get_one(random_cidr)"},{"line_number":163,"context_line":"            self.assertEqual(random_cidr, obj[\u0027cidr\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_450d7536","line":160,"range":{"start_line":160,"start_character":50,"end_line":160,"end_character":67},"updated":"2016-03-14 10:28:38.000000000","message":"Why do we need randomness here? It\u0027s better to have unit tests as deterministic as possible.","commit_id":"01596a18bd8c7ba83777166dcc326f80f62b3a74"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"d277128ca148131b76f799af1139685e63ab949b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self._test_multiple_create(ip_addresses)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"class CIDRTestCase(test_base.DbTestCase):"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def setUp(self):"},{"line_number":119,"context_line":"        super(CIDRTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_29fe4338","line":116,"range":{"start_line":116,"start_character":6,"end_line":116,"end_character":18},"updated":"2016-03-14 11:41:57.000000000","message":"Looking back at this, most of the functions here are quite a duplicate with the above class. This test library should be smarter (testscenarios?)","commit_id":"5b287a916b744fc6cfb0aa267ce6b192452b768d"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"03d869f172c0494b3fc17b5deba544e5dae9b214","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            where(self.test_table.c.cidr \u003d\u003d key))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_crud(self):"},{"line_number":155,"context_line":"        cidrs \u003d [\"10.0.0.0/24\", \"10.123.250.9/32\", \"2001:db8::/42\","},{"line_number":156,"context_line":"                 \"fe80::21e:67ff:fed0:56f0/64\"]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        for cidr_str in cidrs:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3afc51ec_bbb447d1","line":155,"updated":"2016-03-14 15:26:41.000000000","message":"netaddr.IPNetwork constructor accepts several variants, we can base on them for unit testing\n\nhttps://github.com/drkjam/netaddr/blob/rel-0.7.x/netaddr/ip/__init__.py#L828-L868","commit_id":"5ddd9373d6b66d817e834397b02bb26859dbad10"}]}
