)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d58979c0de0a428a77d30ec322c8c76931546af5","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Closes-Bug: #1499647"},{"line_number":37,"context_line":"Closes-Bug: #1533460"},{"line_number":38,"context_line":"Change-Id: I1977355cbf282cd3719b5b69732bcc072557e095"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_dc957233","line":38,"updated":"2016-03-10 01:30:51.000000000","message":"Bug 1550886?","commit_id":"9d152570872d3ad5a3c096ecdb1d880fc55a4578"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"a5725b577bd4de7f673fd3bd98a0effcc9f3c6f1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"when they are created, even with the option set to False:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* Legacy routers are scheduled when an interface is added to them."},{"line_number":16,"context_line":"* HA routers, including DVR-HA routers  are scheduled when they are"},{"line_number":17,"context_line":"  created."},{"line_number":18,"context_line":"* Distributed routers are scheduled to compute nodes automatically"},{"line_number":19,"context_line":"  as needed, and the SNAT portion is scheduled automatically"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_e47d7db2","line":16,"range":{"start_line":16,"start_character":38,"end_line":16,"end_character":40},"updated":"2016-02-28 15:53:30.000000000","message":"nit: double space","commit_id":"5d9cb018f84e0e047f449934b9477866f35f72ea"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"a5725b577bd4de7f673fd3bd98a0effcc9f3c6f1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The only change here then, is that if a legacy router is created"},{"line_number":23,"context_line":"(But no interfaces added), or if any other type of router is created"},{"line_number":24,"context_line":"and then manually unscheduled by an admin via neutron l3-agent-router-remove,"},{"line_number":25,"context_line":"restarting or starting a L3 agent would not automatically schedule said"},{"line_number":26,"context_line":"router, which seems like a positive change. If the admin unscheduled"},{"line_number":27,"context_line":"a router, I think he or her would expect it not to be rescheduled without"},{"line_number":28,"context_line":"him or her explicitly doing it via the same way the router was"},{"line_number":29,"context_line":"unscheduled. Note that the L3 agent does *not* periodically resync"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_c714bb45","line":26,"range":{"start_line":25,"start_character":11,"end_line":26,"end_character":42},"updated":"2016-02-28 15:53:30.000000000","message":"If an HA router was populated by \u0027min_l3_agents_per_router\u0027 agents, and one of those agents were removed - the HA router will now be under-scheduled. Removing the option will mean that adding a (brand) new l3 agent won\u0027t automatically fix this problem, and will require additional steps (ie. manual scheduling) from the admin to schedule the under-scheduled router to the new agent.\nFor this reason I suggest rewording the marked text and making it a bit more clear that this use case (which probably auto_schedule was meant to fix) will be removed with this patch.","commit_id":"5d9cb018f84e0e047f449934b9477866f35f72ea"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d93d1998675da8f96592864263b8f0030bb094c2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"schedule() codepath in the L3 agent. This patch, therefor, removes all"},{"line_number":12,"context_line":"this excess code in favor of using the original schedule() codepath."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TODO: Fix Jenkins, make sure it\u0027s reentrant."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1499647"},{"line_number":17,"context_line":"Closes-Bug: #1533460"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_7cd09e1f","line":14,"updated":"2016-03-10 01:28:29.000000000","message":"You should add yourself as a co-author John.","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"d4145fe4e3294bc3afa6e208759664045f36ac07","unresolved":false,"context_lines":[{"line_number":11,"context_line":"schedule() codepath in the L3 agent. This patch, therefor, removes all"},{"line_number":12,"context_line":"this excess code in favor of using the original schedule() codepath."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TODO: Fix Jenkins, make sure it\u0027s reentrant."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1499647"},{"line_number":17,"context_line":"Closes-Bug: #1533460"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_95bfa45f","line":14,"in_reply_to":"5aef4532_7cd09e1f","updated":"2016-03-14 12:43:45.000000000","message":"Done","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a1d1971440db2adddd1580eb648b9fdd80b49ec5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, auto_schedule_routers has a (rather large) codepath specific"},{"line_number":10,"context_line":"to it. This large codepath exists *in addition* to the original"},{"line_number":11,"context_line":"schedule() codepath in the L3 agent. This patch, therefor, removes all"},{"line_number":12,"context_line":"this excess code in favor of using the original schedule() codepath."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It\u0027s also important to note that this patch introduces a regression in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_cf96da93","line":11,"range":{"start_line":11,"start_character":49,"end_line":11,"end_character":57},"updated":"2016-03-29 11:43:41.000000000","message":"typo","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c12368fb80ae2a70a160d67021a400c6318c4dbb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, auto_schedule_routers has a (rather large) codepath specific"},{"line_number":10,"context_line":"to it. This large codepath exists *in addition* to the original"},{"line_number":11,"context_line":"schedule() codepath in the L3 agent. This patch, therefor, removes all"},{"line_number":12,"context_line":"this excess code in favor of using the original schedule() codepath."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It\u0027s also important to note that this patch introduces a regression in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_debad8e0","line":11,"range":{"start_line":11,"start_character":49,"end_line":11,"end_character":57},"in_reply_to":"ba0121b8_cf96da93","updated":"2016-03-30 08:50:40.000000000","message":"Done","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a1d1971440db2adddd1580eb648b9fdd80b49ec5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"schedule() codepath in the L3 agent. This patch, therefor, removes all"},{"line_number":12,"context_line":"this excess code in favor of using the original schedule() codepath."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It\u0027s also important to note that this patch introduces a regression in"},{"line_number":15,"context_line":"the form of auto_schedule not working for routers that are"},{"line_number":16,"context_line":"under-scheduled. This means that if an HA router is scheduled to less"},{"line_number":17,"context_line":"than \u0027max_l3_agents_per_router\u0027 and additional agents are available, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_0fe8d20f","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":67},"updated":"2016-03-29 11:43:41.000000000","message":"this requires a release note (at least)","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c12368fb80ae2a70a160d67021a400c6318c4dbb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"schedule() codepath in the L3 agent. This patch, therefor, removes all"},{"line_number":12,"context_line":"this excess code in favor of using the original schedule() codepath."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It\u0027s also important to note that this patch introduces a regression in"},{"line_number":15,"context_line":"the form of auto_schedule not working for routers that are"},{"line_number":16,"context_line":"under-scheduled. This means that if an HA router is scheduled to less"},{"line_number":17,"context_line":"than \u0027max_l3_agents_per_router\u0027 and additional agents are available, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_dc130165","line":14,"range":{"start_line":14,"start_character":57,"end_line":14,"end_character":67},"in_reply_to":"ba0121b8_0fe8d20f","updated":"2016-03-30 08:50:40.000000000","message":"Done","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"51453a545642f248294a39092bfe4a29d63c9a82","unresolved":false,"context_lines":[{"line_number":17,"context_line":"than \u0027max_l3_agents_per_router\u0027 and additional agents are available, the"},{"line_number":18,"context_line":"router won\u0027t be scheduled to them automatically. This is a known"},{"line_number":19,"context_line":"regression that we\u0027re putting in place to make the code safer and future"},{"line_number":20,"context_line":"patches will put this functionality back into place."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-Authored-By: John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":23,"context_line":"Closes-Bug: #1499647"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_5459a4fd","line":20,"updated":"2016-03-29 17:59:28.000000000","message":"Can we also include in here which current features use the auto-schedule logic and how it would be affected or not affected by removing the auto-schedule logic.","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c12368fb80ae2a70a160d67021a400c6318c4dbb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"than \u0027max_l3_agents_per_router\u0027 and additional agents are available, the"},{"line_number":18,"context_line":"router won\u0027t be scheduled to them automatically. This is a known"},{"line_number":19,"context_line":"regression that we\u0027re putting in place to make the code safer and future"},{"line_number":20,"context_line":"patches will put this functionality back into place."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Co-Authored-By: John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":23,"context_line":"Closes-Bug: #1499647"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba0121b8_de8f7821","line":20,"in_reply_to":"ba0121b8_5459a4fd","updated":"2016-03-30 08:50:40.000000000","message":"I\u0027ve expanded upon this issue in the commit message. If you think something is still missing let me know.","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eb60f42715350b6598966cc0ca8c04b906f5d434","unresolved":false,"context_lines":[{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and future patches will put these functionality back into"},{"line_number":25,"context_line":"place."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":28,"context_line":"Closes-Bug: #1499647"},{"line_number":29,"context_line":"Closes-Bug: #1533460"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"1a122d0e_af6a2418","line":26,"updated":"2016-05-04 23:30:12.000000000","message":"I think that a DocImpact flag should be added here.","commit_id":"eccfd600d59d74bed6ad5c1d548bc911e51dcc27"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"8215113d2531810a5cd637c1fe85b2323427411c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and future patches will put these functionality back into"},{"line_number":25,"context_line":"place."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":28,"context_line":"Closes-Bug: #1499647"},{"line_number":29,"context_line":"Closes-Bug: #1533460"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"dab17558_cf8fbe21","line":26,"in_reply_to":"1a122d0e_af6a2418","updated":"2016-05-09 12:37:24.000000000","message":"Done","commit_id":"eccfd600d59d74bed6ad5c1d548bc911e51dcc27"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34fffdf45062e8cd598b940e54a7fe997d8e54d2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"1. If an HA router is scheduled to less than \u0027max_l3_agents_per_router\u0027"},{"line_number":18,"context_line":"   and additional agents are available, the router won\u0027t be scheduled to"},{"line_number":19,"context_line":"   them automatically."},{"line_number":20,"context_line":"2. If a router was manually unscheduled by the tenant responsible, it"},{"line_number":21,"context_line":"   won\u0027t be automatically re-scheduled to some other agent (or even the"},{"line_number":22,"context_line":"   same, if it\u0027s restarted). This also effects non-HA routers."},{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and future patches will put these functionality back into"},{"line_number":25,"context_line":"place."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"dab17558_20acf434","line":22,"range":{"start_line":20,"start_character":3,"end_line":22,"end_character":62},"updated":"2016-05-12 09:12:06.000000000","message":"is this true with the current state of the patch? I see that schedule is still called so unscheduled routers should be handled, right?","commit_id":"e92b5efdedd4782b2589c78435ca90c4ce9ba19a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"353408175caa30bb5b5af4f70b919a893db8effe","unresolved":false,"context_lines":[{"line_number":17,"context_line":"1. If an HA router is scheduled to less than \u0027max_l3_agents_per_router\u0027"},{"line_number":18,"context_line":"   and additional agents are available, the router won\u0027t be scheduled to"},{"line_number":19,"context_line":"   them automatically."},{"line_number":20,"context_line":"2. If a router was manually unscheduled by the tenant responsible, it"},{"line_number":21,"context_line":"   won\u0027t be automatically re-scheduled to some other agent (or even the"},{"line_number":22,"context_line":"   same, if it\u0027s restarted). This also effects non-HA routers."},{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and future patches will put these functionality back into"},{"line_number":25,"context_line":"place."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"dab17558_3a0f0030","line":22,"range":{"start_line":20,"start_character":3,"end_line":22,"end_character":62},"in_reply_to":"dab17558_20acf434","updated":"2016-05-12 09:30:57.000000000","message":"I believe you are correct - non-HA routers should get rescheduled properly. I\u0027ll make sure this happens and will change the commit message/let you know if it doesn\u0027t.","commit_id":"e92b5efdedd4782b2589c78435ca90c4ce9ba19a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34fffdf45062e8cd598b940e54a7fe997d8e54d2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"   won\u0027t be automatically re-scheduled to some other agent (or even the"},{"line_number":22,"context_line":"   same, if it\u0027s restarted). This also effects non-HA routers."},{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and future patches will put these functionality back into"},{"line_number":25,"context_line":"place."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":28,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"dab17558_607d5cb1","line":25,"range":{"start_line":24,"start_character":15,"end_line":25,"end_character":6},"updated":"2016-05-12 09:12:06.000000000","message":"I\u0027d like to see theses patches in the chain before we merge this.","commit_id":"e92b5efdedd4782b2589c78435ca90c4ce9ba19a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"353408175caa30bb5b5af4f70b919a893db8effe","unresolved":false,"context_lines":[{"line_number":21,"context_line":"   won\u0027t be automatically re-scheduled to some other agent (or even the"},{"line_number":22,"context_line":"   same, if it\u0027s restarted). This also effects non-HA routers."},{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and future patches will put these functionality back into"},{"line_number":25,"context_line":"place."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Co-Authored-By: John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":28,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"dab17558_fa23b8a5","line":25,"range":{"start_line":24,"start_character":15,"end_line":25,"end_character":6},"in_reply_to":"dab17558_607d5cb1","updated":"2016-05-12 09:30:57.000000000","message":"These patches are being worked on - I plan to see them myself before I push this to the gate :)","commit_id":"e92b5efdedd4782b2589c78435ca90c4ce9ba19a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b7397866dc3d78086a95ef00c135aa99d7f58b0b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"1. If an HA router is scheduled to less than \u0027max_l3_agents_per_router\u0027"},{"line_number":18,"context_line":"   and additional agents are available, the router won\u0027t be scheduled to"},{"line_number":19,"context_line":"   them automatically."},{"line_number":20,"context_line":"2. If a router was manually unscheduled by the tenant responsible, it"},{"line_number":21,"context_line":"   won\u0027t be automatically re-scheduled to some other agent (or even the"},{"line_number":22,"context_line":"   same, if it\u0027s restarted)."},{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and followup patches will put these functionality back into"},{"line_number":25,"context_line":"place."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"bab6814e_c0ffca32","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":28},"updated":"2016-05-18 14:17:36.000000000","message":"So you checked and it\u0027s still true?","commit_id":"7c460f2ecf06e88394597debe7051b53d79c2bdc"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7ccd8822fb129009be5c34f3590d00634f41ed05","unresolved":false,"context_lines":[{"line_number":17,"context_line":"1. If an HA router is scheduled to less than \u0027max_l3_agents_per_router\u0027"},{"line_number":18,"context_line":"   and additional agents are available, the router won\u0027t be scheduled to"},{"line_number":19,"context_line":"   them automatically."},{"line_number":20,"context_line":"2. If a router was manually unscheduled by the tenant responsible, it"},{"line_number":21,"context_line":"   won\u0027t be automatically re-scheduled to some other agent (or even the"},{"line_number":22,"context_line":"   same, if it\u0027s restarted)."},{"line_number":23,"context_line":"These are a known regression that we\u0027re putting in place to make the"},{"line_number":24,"context_line":"code safer and followup patches will put these functionality back into"},{"line_number":25,"context_line":"place."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"bab6814e_fb527fdc","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":28},"in_reply_to":"bab6814e_c0ffca32","updated":"2016-05-18 14:22:35.000000000","message":"The wording is still a be a bit confusing - this is true only when a router has been completely unscheduled. On legacy/DVR routers this can happen when you manually unschedule a router from the single agent, and on HA router this can happen when it has been *completely* unscheduled. I will fix the wording now.","commit_id":"7c460f2ecf06e88394597debe7051b53d79c2bdc"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"0214bd8f2cdcc57e373ef14fad26f717c41980bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-18 14:29:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove auto_schedule_routers codepath"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, auto_schedule_routers has a (rather large) codepath specific"},{"line_number":10,"context_line":"to it. This large codepath exists *in addition* to the original"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"bab6814e_35c5fd3c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"updated":"2016-05-25 09:47:10.000000000","message":"The title is not clear on what exactly is being deleted.","commit_id":"d509c9739864e1e0ca3aec4755c9b56efe022133"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ea83dd1d3e8722a99e6d5caa8c07052e4e2cdc67","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_router_ids(self, context, host):"},{"line_number":66,"context_line":"        \"\"\"Returns IDs of routers scheduled to l3 agent on \u003chost\u003e."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        This will autoschedule unhosted routers to l3 agent on \u003chost\u003e and then"},{"line_number":69,"context_line":"        return all ids of routers scheduled to it."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        if utils.is_extension_supported("}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_0133f314","line":68,"updated":"2016-03-10 01:27:03.000000000","message":"It will schedule all unhosted routers, not necessarily to \u003chost\u003e.","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"93a80e92268f68e1c21b8f738a4828f0f131d248","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_router_ids(self, context, host):"},{"line_number":66,"context_line":"        \"\"\"Returns IDs of routers scheduled to l3 agent on \u003chost\u003e."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        This will autoschedule unhosted routers to l3 agent on \u003chost\u003e and then"},{"line_number":69,"context_line":"        return all ids of routers scheduled to it."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        if utils.is_extension_supported("}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_a02f003d","line":68,"in_reply_to":"5aef4532_0133f314","updated":"2016-03-14 15:37:30.000000000","message":"Done","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"142c5d7177bc7575aaf3935a52e2b5e7e58b3e71","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if utils.is_extension_supported("},{"line_number":72,"context_line":"                self.l3plugin, constants.L3_AGENT_SCHEDULER_EXT_ALIAS):"},{"line_number":73,"context_line":"            if cfg.CONF.router_auto_schedule:"},{"line_number":74,"context_line":"                self.l3plugin.auto_schedule_routers(context)"},{"line_number":75,"context_line":"        return self.l3plugin.list_router_ids_on_host(context, host)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @db_api.retry_db_errors"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a122d0e_059362a4","line":74,"range":{"start_line":74,"start_character":59,"end_line":74,"end_character":60},"updated":"2016-04-18 19:02:17.000000000","message":"I don\u0027t think we even need here for the DVR routers, since it is rescheduling the routers.\n\nEither we can apply the \u0027comment\u0027 I made in l3_agent_schedulers.py and then modify here to pass in the auto_schedule_routers(context, exclude_distributed\u003dTrue) or else just remove it.","commit_id":"83870a5995f7c04b572cd52af049f6b68cafe028"}],"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ea83dd1d3e8722a99e6d5caa8c07052e4e2cdc67","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        if self.router_scheduler:"},{"line_number":495,"context_line":"            return self.router_scheduler.auto_schedule_routers(self, context)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def schedule_router(self, context, router_id, candidates\u003dNone):"},{"line_number":498,"context_line":"        if self.router_scheduler:"},{"line_number":499,"context_line":"            return self.router_scheduler.schedule("},{"line_number":500,"context_line":"                self, context, router_id, candidates\u003dcandidates)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_dca1f2f9","line":497,"updated":"2016-03-10 01:27:03.000000000","message":"This change from router to router_id seems unnecessary.","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"93a80e92268f68e1c21b8f738a4828f0f131d248","unresolved":false,"context_lines":[{"line_number":494,"context_line":"        if self.router_scheduler:"},{"line_number":495,"context_line":"            return self.router_scheduler.auto_schedule_routers(self, context)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def schedule_router(self, context, router_id, candidates\u003dNone):"},{"line_number":498,"context_line":"        if self.router_scheduler:"},{"line_number":499,"context_line":"            return self.router_scheduler.schedule("},{"line_number":500,"context_line":"                self, context, router_id, candidates\u003dcandidates)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_2047701e","line":497,"in_reply_to":"5aef4532_dca1f2f9","updated":"2016-03-14 15:37:30.000000000","message":"I agree.","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"}],"neutron/db/l3_hascheduler_db.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"51453a545642f248294a39092bfe4a29d63c9a82","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_ha_routers_l3_agents_count(self, context):"},{"line_number":27,"context_line":"        \"\"\"Return a map between HA routers and how many agents every"},{"line_number":28,"context_line":"        router is scheduled to."},{"line_number":29,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_7464a8e4","side":"PARENT","line":26,"range":{"start_line":26,"start_character":52,"end_line":26,"end_character":54},"updated":"2016-03-29 17:59:28.000000000","message":"Is this change related to removing the auto-schedule","commit_id":"53dea4afe07a4eab34f192e519d82d9f5e061771"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c12368fb80ae2a70a160d67021a400c6318c4dbb","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_ha_routers_l3_agents_count(self, context):"},{"line_number":27,"context_line":"        \"\"\"Return a map between HA routers and how many agents every"},{"line_number":28,"context_line":"        router is scheduled to."},{"line_number":29,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_1f7e0b19","side":"PARENT","line":26,"range":{"start_line":26,"start_character":52,"end_line":26,"end_character":54},"in_reply_to":"ba0121b8_7464a8e4","updated":"2016-03-30 08:50:40.000000000","message":"Yes. This function was used by the auto_schedule_routers logic and since it\u0027s no longer used it can be removed.","commit_id":"53dea4afe07a4eab34f192e519d82d9f5e061771"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34fffdf45062e8cd598b940e54a7fe997d8e54d2","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_ha_routers_l3_agents_count(self, context):"},{"line_number":27,"context_line":"        \"\"\"Return a map between HA routers and how many agents every"},{"line_number":28,"context_line":"        router is scheduled to."},{"line_number":29,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"dab17558_e03e6cd9","side":"PARENT","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":53},"updated":"2016-05-12 09:12:06.000000000","message":"Should we remove this if have plans to bring this functionality back in future patches?","commit_id":"1019d2b1e5c4c6a8729598e2c57e650fc94ce2f7"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"353408175caa30bb5b5af4f70b919a893db8effe","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class L3_HA_scheduler_db_mixin(l3_sch_db.AZL3AgentSchedulerDbMixin):"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_ha_routers_l3_agents_count(self, context):"},{"line_number":27,"context_line":"        \"\"\"Return a map between HA routers and how many agents every"},{"line_number":28,"context_line":"        router is scheduled to."},{"line_number":29,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"dab17558_1af2fc06","side":"PARENT","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":53},"in_reply_to":"dab17558_e03e6cd9","updated":"2016-05-12 09:30:57.000000000","message":"I\u0027m unsure. The current version of future patches I\u0027m working on makes a slight modification of this function but most of it is still in. I\u0027m yet to decide if the new \u0027underscheduled\u0027 logic will be in this patch or a followup.\n\nI suppose we can leave this in with a \"NOTE: this isn\u0027t used but future patches will use this\" comment.","commit_id":"1019d2b1e5c4c6a8729598e2c57e650fc94ce2f7"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ea83dd1d3e8722a99e6d5caa8c07052e4e2cdc67","unresolved":false,"context_lines":[{"line_number":39,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":40,"context_line":"class L3Scheduler(object):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    ROUTER_SCHEDULER_QUOTA \u003d \u0027router_scheduler\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        self.min_ha_agents \u003d cfg.CONF.min_l3_agents_per_router"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_41e69bb0","line":42,"updated":"2016-03-10 01:27:03.000000000","message":"Unused.","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"93a80e92268f68e1c21b8f738a4828f0f131d248","unresolved":false,"context_lines":[{"line_number":39,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":40,"context_line":"class L3Scheduler(object):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    ROUTER_SCHEDULER_QUOTA \u003d \u0027router_scheduler\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        self.min_ha_agents \u003d cfg.CONF.min_l3_agents_per_router"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_e044681c","line":42,"in_reply_to":"5aef4532_41e69bb0","updated":"2016-03-14 15:37:30.000000000","message":"Whoops.","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ea83dd1d3e8722a99e6d5caa8c07052e4e2cdc67","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                context, filters\u003d{\u0027id\u0027: unscheduled_router_ids})"},{"line_number":68,"context_line":"        return []"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def auto_schedule_routers(self, plugin, context):"},{"line_number":71,"context_line":"        unscheduled_routers \u003d self._get_unscheduled_routers(plugin, context)"},{"line_number":72,"context_line":"        for router in unscheduled_routers:"},{"line_number":73,"context_line":"            self.schedule(plugin, context, router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_3cf1f601","line":70,"updated":"2016-03-10 01:27:03.000000000","message":"This method now doesn\u0027t have a test.","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"93a80e92268f68e1c21b8f738a4828f0f131d248","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                context, filters\u003d{\u0027id\u0027: unscheduled_router_ids})"},{"line_number":68,"context_line":"        return []"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def auto_schedule_routers(self, plugin, context):"},{"line_number":71,"context_line":"        unscheduled_routers \u003d self._get_unscheduled_routers(plugin, context)"},{"line_number":72,"context_line":"        for router in unscheduled_routers:"},{"line_number":73,"context_line":"            self.schedule(plugin, context, router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_6072184b","line":70,"in_reply_to":"5aef4532_3cf1f601","updated":"2016-03-14 15:37:30.000000000","message":"Done","commit_id":"2d969420a4af62dce7cc292a281d0c20bc517bd4"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"1b26dc0648f3158c12f172a3187f9cfdea5f3b43","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            plugin, context, candidates)"},{"line_number":227,"context_line":"        LOG.debug(\"Chosen agents for HA router %(router_id)s: %(agents)r \","},{"line_number":228,"context_line":"                  {\u0027router_id\u0027: router_id,"},{"line_number":229,"context_line":"                   \u0027agents\u0027: \u0027agents\u0027})"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        self._bind_ha_router_to_agents(plugin, context, router_id,"},{"line_number":232,"context_line":"                                       chosen_agents)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_07f7e7f5","line":229,"updated":"2016-03-16 17:41:06.000000000","message":"This doesn\u0027t look right.","commit_id":"18675527c810bc6f3e9313f7d000ba897fed40b1"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"6ce39c7a7b200dd8ada6296f79478f2560b8d2db","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            plugin, context, candidates)"},{"line_number":227,"context_line":"        LOG.debug(\"Chosen agents for HA router %(router_id)s: %(agents)r \","},{"line_number":228,"context_line":"                  {\u0027router_id\u0027: router_id,"},{"line_number":229,"context_line":"                   \u0027agents\u0027: \u0027agents\u0027})"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        self._bind_ha_router_to_agents(plugin, context, router_id,"},{"line_number":232,"context_line":"                                       chosen_agents)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1af94dfe_87a9377e","line":229,"in_reply_to":"1af94dfe_07f7e7f5","updated":"2016-03-16 17:45:44.000000000","message":"\u003c.\u003c\n\u003e.\u003e\n\u003e.\u003c","commit_id":"18675527c810bc6f3e9313f7d000ba897fed40b1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ae8d796e5ce2191f75edbb58c9121f4469f082b0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            l3_db.Router.id \u003d\u003d"},{"line_number":64,"context_line":"            l3_agentschedulers_db.RouterL3AgentBinding.router_id)"},{"line_number":65,"context_line":"        query \u003d context.session.query(l3_db.Router.id).filter(no_agent_binding)"},{"line_number":66,"context_line":"        query \u003d query.filter(l3_db.Router.status \u003d\u003d"},{"line_number":67,"context_line":"                             constants.ROUTER_STATUS_ACTIVE)"},{"line_number":68,"context_line":"        unscheduled_router_ids \u003d [router_id_[0] for router_id_ in query]"},{"line_number":69,"context_line":"        if unscheduled_router_ids:"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa0719c6_f0af44e1","line":66,"updated":"2016-03-21 14:59:22.000000000","message":"Yay.","commit_id":"f60bbfdff85489049a49ba7e9d2b5c00a5b08fa1"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"f30fd0e5ec7d6be14c2afc65d69b3b084675ed35","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            l3_db.Router.id \u003d\u003d"},{"line_number":64,"context_line":"            l3_agentschedulers_db.RouterL3AgentBinding.router_id)"},{"line_number":65,"context_line":"        query \u003d context.session.query(l3_db.Router.id).filter(no_agent_binding)"},{"line_number":66,"context_line":"        query \u003d query.filter(l3_db.Router.status \u003d\u003d"},{"line_number":67,"context_line":"                             constants.ROUTER_STATUS_ACTIVE)"},{"line_number":68,"context_line":"        unscheduled_router_ids \u003d [router_id_[0] for router_id_ in query]"},{"line_number":69,"context_line":"        if unscheduled_router_ids:"},{"line_number":70,"context_line":"            return plugin.get_routers("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa0719c6_241625f1","line":67,"range":{"start_line":66,"start_character":8,"end_line":67,"end_character":60},"updated":"2016-03-23 14:56:33.000000000","message":"This should be done in the ALLOCATING patch.","commit_id":"ff6f990c42d1da57eabf0663083cad258fd67ca9"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9d9e3b622f65ca899a0fc4f5e6c7b8d68c1bbb23","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            l3_db.Router.id \u003d\u003d"},{"line_number":64,"context_line":"            l3_agentschedulers_db.RouterL3AgentBinding.router_id)"},{"line_number":65,"context_line":"        query \u003d context.session.query(l3_db.Router.id).filter(no_agent_binding)"},{"line_number":66,"context_line":"        query \u003d query.filter(l3_db.Router.status \u003d\u003d"},{"line_number":67,"context_line":"                             constants.ROUTER_STATUS_ACTIVE)"},{"line_number":68,"context_line":"        unscheduled_router_ids \u003d [router_id_[0] for router_id_ in query]"},{"line_number":69,"context_line":"        if unscheduled_router_ids:"},{"line_number":70,"context_line":"            return plugin.get_routers("}],"source_content_type":"text/x-python","patch_set":14,"id":"da0c15f0_80e11cd3","line":67,"range":{"start_line":66,"start_character":8,"end_line":67,"end_character":60},"in_reply_to":"fa0719c6_241625f1","updated":"2016-03-28 09:03:06.000000000","message":"Done","commit_id":"ff6f990c42d1da57eabf0663083cad258fd67ca9"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3a8f7b89e03c7e6857be83f7e1a33517ef787089","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                   \u0027bindings\u0027: port_bindings})"},{"line_number":207,"context_line":"        for port_binding, agent in zip(port_bindings, chosen_agents):"},{"line_number":208,"context_line":"            try:"},{"line_number":209,"context_line":"                with db_api.autonested_transaction(context.session):"},{"line_number":210,"context_line":"                    port_binding.l3_agent_id \u003d agent.id"},{"line_number":211,"context_line":"                    self.bind_router(context, router_id, agent)"},{"line_number":212,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":213,"context_line":"                LOG.debug(\"Router %(router)s already scheduled for agent \""},{"line_number":214,"context_line":"                          \"%(agent)s\", {\u0027router\u0027: router_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa0719c6_238eea2d","line":211,"range":{"start_line":209,"start_character":0,"end_line":211,"end_character":63},"updated":"2016-03-24 10:47:40.000000000","message":"Here is sill facing the exception: http://paste.openstack.org/show/488732/\nJohn and I discussed here:\nhttps://review.openstack.org/#/c/284400/9/neutron/scheduler/l3_agent_scheduler.py\n\nAfter all HA attributes of a HA router was created, it will be set to ROUTER_STATUS_ACTIVE status according to ALLOCATING patch (257059). And then a get_router_ids RPC comes, both create_router API and get_router_ids RPC will try to scheduler the router, then the exception (paste 488732) will be raised.","commit_id":"ff6f990c42d1da57eabf0663083cad258fd67ca9"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"6171ca447d43a57c70b5fbe547d2068702e0ae05","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                   \u0027bindings\u0027: port_bindings})"},{"line_number":207,"context_line":"        for port_binding, agent in zip(port_bindings, chosen_agents):"},{"line_number":208,"context_line":"            try:"},{"line_number":209,"context_line":"                with db_api.autonested_transaction(context.session):"},{"line_number":210,"context_line":"                    port_binding.l3_agent_id \u003d agent.id"},{"line_number":211,"context_line":"                    self.bind_router(context, router_id, agent)"},{"line_number":212,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":213,"context_line":"                LOG.debug(\"Router %(router)s already scheduled for agent \""},{"line_number":214,"context_line":"                          \"%(agent)s\", {\u0027router\u0027: router_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da0c15f0_cc806b49","line":211,"range":{"start_line":209,"start_character":0,"end_line":211,"end_character":63},"in_reply_to":"da0c15f0_20977049","updated":"2016-03-28 10:23:26.000000000","message":"This has been fixed by a new patch in the change: https://review.openstack.org/284400.","commit_id":"ff6f990c42d1da57eabf0663083cad258fd67ca9"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"8b08505c39757485115741c83b451efa1026cd61","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                   \u0027bindings\u0027: port_bindings})"},{"line_number":207,"context_line":"        for port_binding, agent in zip(port_bindings, chosen_agents):"},{"line_number":208,"context_line":"            try:"},{"line_number":209,"context_line":"                with db_api.autonested_transaction(context.session):"},{"line_number":210,"context_line":"                    port_binding.l3_agent_id \u003d agent.id"},{"line_number":211,"context_line":"                    self.bind_router(context, router_id, agent)"},{"line_number":212,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":213,"context_line":"                LOG.debug(\"Router %(router)s already scheduled for agent \""},{"line_number":214,"context_line":"                          \"%(agent)s\", {\u0027router\u0027: router_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"da0c15f0_20977049","line":211,"range":{"start_line":209,"start_character":0,"end_line":211,"end_character":63},"in_reply_to":"fa0719c6_238eea2d","updated":"2016-03-28 08:53:22.000000000","message":"You are correct. I\u0027ve answered this on https://review.openstack.org/#/c/284400/9/neutron/scheduler/l3_agent_scheduler.py (line 224) but haven\u0027t had the time to address this yet. Next patchset will see this solved.","commit_id":"ff6f990c42d1da57eabf0663083cad258fd67ca9"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5a1cdf647aa159d071e21359a1640ae215dacbf","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                                   \u0027agent_id\u0027: chosen_agent_id})"},{"line_number":230,"context_line":"        return binding"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _schedule_router(self, plugin, context, router_id,"},{"line_number":233,"context_line":"                         candidates\u003dNone):"},{"line_number":234,"context_line":"        sync_router \u003d plugin.get_router(context, router_id)"},{"line_number":235,"context_line":"        candidates \u003d candidates or self._get_candidates("},{"line_number":236,"context_line":"            plugin, context, sync_router)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_86e95d1d","side":"PARENT","line":233,"range":{"start_line":232,"start_character":4,"end_line":233,"end_character":42},"updated":"2016-03-29 16:28:41.000000000","message":"unrelated","commit_id":"53dea4afe07a4eab34f192e519d82d9f5e061771"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c12368fb80ae2a70a160d67021a400c6318c4dbb","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                                   \u0027agent_id\u0027: chosen_agent_id})"},{"line_number":230,"context_line":"        return binding"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _schedule_router(self, plugin, context, router_id,"},{"line_number":233,"context_line":"                         candidates\u003dNone):"},{"line_number":234,"context_line":"        sync_router \u003d plugin.get_router(context, router_id)"},{"line_number":235,"context_line":"        candidates \u003d candidates or self._get_candidates("},{"line_number":236,"context_line":"            plugin, context, sync_router)"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_9fb7bbd7","side":"PARENT","line":233,"range":{"start_line":232,"start_character":4,"end_line":233,"end_character":42},"in_reply_to":"ba0121b8_86e95d1d","updated":"2016-03-30 08:50:40.000000000","message":"Done","commit_id":"53dea4afe07a4eab34f192e519d82d9f5e061771"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c5a1cdf647aa159d071e21359a1640ae215dacbf","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_unscheduled_routers(self, plugin, context):"},{"line_number":60,"context_line":"        \"\"\"Get routers with no agent binding.\"\"\""},{"line_number":61,"context_line":"        # TODO(gongysh) consider the disabled agent\u0027s router"},{"line_number":62,"context_line":"        no_agent_binding \u003d ~sql.exists().where("}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_c37ce774","line":59,"range":{"start_line":59,"start_character":39,"end_line":59,"end_character":54},"updated":"2016-03-29 16:28:41.000000000","message":"please make \u0027context\u0027 the first arg","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c12368fb80ae2a70a160d67021a400c6318c4dbb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_unscheduled_routers(self, plugin, context):"},{"line_number":60,"context_line":"        \"\"\"Get routers with no agent binding.\"\"\""},{"line_number":61,"context_line":"        # TODO(gongysh) consider the disabled agent\u0027s router"},{"line_number":62,"context_line":"        no_agent_binding \u003d ~sql.exists().where("}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_5fafe380","line":59,"range":{"start_line":59,"start_character":39,"end_line":59,"end_character":54},"in_reply_to":"ba0121b8_c37ce774","updated":"2016-03-30 08:50:40.000000000","message":"All the other functions in this file use \u0027plugin\u0027 as first arg. I\u0027m game with changing this in a follow up patch if you want.","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a1d1971440db2adddd1580eb648b9fdd80b49ec5","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                 chosen_agents):"},{"line_number":211,"context_line":"        port_bindings \u003d plugin.get_ha_router_port_bindings(context,"},{"line_number":212,"context_line":"                                                           [router_id])"},{"line_number":213,"context_line":"        LOG.debug(\"There are %(amount)s bindings for binding: %(bindings)s \","},{"line_number":214,"context_line":"                  {\u0027amount\u0027: len(port_bindings),"},{"line_number":215,"context_line":"                   \u0027bindings\u0027: port_bindings})"},{"line_number":216,"context_line":"        for port_binding, agent in zip(port_bindings, chosen_agents):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_6f5d0ee9","line":213,"updated":"2016-03-29 11:43:41.000000000","message":"this log message does not really make sense. please at least add in the router id for some context","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c12368fb80ae2a70a160d67021a400c6318c4dbb","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                                 chosen_agents):"},{"line_number":211,"context_line":"        port_bindings \u003d plugin.get_ha_router_port_bindings(context,"},{"line_number":212,"context_line":"                                                           [router_id])"},{"line_number":213,"context_line":"        LOG.debug(\"There are %(amount)s bindings for binding: %(bindings)s \","},{"line_number":214,"context_line":"                  {\u0027amount\u0027: len(port_bindings),"},{"line_number":215,"context_line":"                   \u0027bindings\u0027: port_bindings})"},{"line_number":216,"context_line":"        for port_binding, agent in zip(port_bindings, chosen_agents):"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba0121b8_1fcc4b69","line":213,"in_reply_to":"ba0121b8_6f5d0ee9","updated":"2016-03-30 08:50:40.000000000","message":"Done","commit_id":"0766c00ed6dc2095371d913549eccdbbf568d367"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"142c5d7177bc7575aaf3935a52e2b5e7e58b3e71","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def auto_schedule_routers(self, plugin, context):"},{"line_number":75,"context_line":"        unscheduled_routers \u003d self._get_unscheduled_routers(plugin, context)"},{"line_number":76,"context_line":"        for router in unscheduled_routers:"},{"line_number":77,"context_line":"            self.schedule(plugin, context, router[\u0027id\u0027])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_candidates(self, plugin, context, sync_router):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a122d0e_c524cab0","line":76,"updated":"2016-04-18 19:02:17.000000000","message":"John, as part of your clean, is it possible to add this in the current auto_schedule_routers, since the auto_schedule is messing up with the DVR routers.\n\nOr do you want me to add an additional patch for this.\n\nauto_shedule_routers(self, plugin, context, exclude_distributed\u003dFalse)\n \n if exclude_distributed:\n    unscheduled_routers \u003d [\n        r for r in unscheduled_routers if not        i  r.get(\u0027distributed\u0027)\n            ]\n        return unscheduled_routers","commit_id":"83870a5995f7c04b572cd52af049f6b68cafe028"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7ece77d534fef98a1d723fcb1e8bf530ca3ff4d4","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def auto_schedule_routers(self, plugin, context):"},{"line_number":75,"context_line":"        unscheduled_routers \u003d self._get_unscheduled_routers(plugin, context)"},{"line_number":76,"context_line":"        for router in unscheduled_routers:"},{"line_number":77,"context_line":"            self.schedule(plugin, context, router[\u0027id\u0027])"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_candidates(self, plugin, context, sync_router):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a122d0e_17b4cf7d","line":76,"in_reply_to":"1a122d0e_c524cab0","updated":"2016-04-20 14:05:44.000000000","message":"There is no need for an additional patch. If this patch breaks DVR it should fix it :)\n\nCan you please specify what doesn\u0027t work (so that I may test that the fix works)?","commit_id":"83870a5995f7c04b572cd52af049f6b68cafe028"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"34fffdf45062e8cd598b940e54a7fe997d8e54d2","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":296,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _schedule_ha_routers_to_additional_agent(self, plugin, context, agent):"},{"line_number":299,"context_line":"        \"\"\"Bind already scheduled routers to the agent."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        Retrieve the number of agents per router and check if the router has"}],"source_content_type":"text/x-python","patch_set":26,"id":"dab17558_8bc34138","side":"PARENT","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":48},"updated":"2016-05-12 09:12:06.000000000","message":"agent parameter seems unused so can we just call this func inside _schedule_router() and not introduce a regression?","commit_id":"1019d2b1e5c4c6a8729598e2c57e650fc94ce2f7"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"e6c0f95a319040d532107b79f04f9d37de91f776","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":296,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _schedule_ha_routers_to_additional_agent(self, plugin, context, agent):"},{"line_number":299,"context_line":"        \"\"\"Bind already scheduled routers to the agent."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        Retrieve the number of agents per router and check if the router has"}],"source_content_type":"text/x-python","patch_set":26,"id":"bab6814e_60953ee3","side":"PARENT","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":48},"in_reply_to":"bab6814e_20f216d3","updated":"2016-05-18 14:22:48.000000000","message":"The main idea of this patch is to remove all the duplicate code that does what the remaining code already does. Leaving this here means most of the code needs to be brought back, thus code duplication.\n\nThe followup patch (317949) proposes a different way to do this using the remaining codepath (no code duplication), by making the code aware that it might need to create not all the resources but only some. This can happen when a new agent has been added and an HA router can be scheduled to it.","commit_id":"1019d2b1e5c4c6a8729598e2c57e650fc94ce2f7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"38b8b820cb8b0062bab80f568d3109f41221072e","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":296,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _schedule_ha_routers_to_additional_agent(self, plugin, context, agent):"},{"line_number":299,"context_line":"        \"\"\"Bind already scheduled routers to the agent."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        Retrieve the number of agents per router and check if the router has"}],"source_content_type":"text/x-python","patch_set":26,"id":"bab6814e_20f216d3","side":"PARENT","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":48},"in_reply_to":"dab17558_1a403c07","updated":"2016-05-18 14:12:17.000000000","message":"So it\u0027s not that simple, right?","commit_id":"1019d2b1e5c4c6a8729598e2c57e650fc94ce2f7"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"353408175caa30bb5b5af4f70b919a893db8effe","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        \"\"\"Return a mapping (router, # agents) matching specified filters.\"\"\""},{"line_number":296,"context_line":"        return plugin.get_ha_routers_l3_agents_count(context)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _schedule_ha_routers_to_additional_agent(self, plugin, context, agent):"},{"line_number":299,"context_line":"        \"\"\"Bind already scheduled routers to the agent."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        Retrieve the number of agents per router and check if the router has"}],"source_content_type":"text/x-python","patch_set":26,"id":"dab17558_1a403c07","side":"PARENT","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":48},"in_reply_to":"dab17558_8bc34138","updated":"2016-05-12 09:30:57.000000000","message":"Sounds like a promising direction. I\u0027ll look into this.","commit_id":"1019d2b1e5c4c6a8729598e2c57e650fc94ce2f7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de0f07a8d7d7ba6dc6bd8e48e01f993886bd10d5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_unscheduled_routers(self, plugin, context):"},{"line_number":60,"context_line":"        \"\"\"Get routers with no agent binding.\"\"\""},{"line_number":61,"context_line":"        # TODO(gongysh) consider the disabled agent\u0027s router"},{"line_number":62,"context_line":"        no_agent_binding \u003d ~sql.exists().where("}],"source_content_type":"text/x-python","patch_set":26,"id":"dab17558_a213630c","line":59,"updated":"2016-05-09 17:53:07.000000000","message":"context should always be the first argument","commit_id":"e92b5efdedd4782b2589c78435ca90c4ce9ba19a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"353408175caa30bb5b5af4f70b919a893db8effe","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        \"\"\""},{"line_number":57,"context_line":"        pass"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_unscheduled_routers(self, plugin, context):"},{"line_number":60,"context_line":"        \"\"\"Get routers with no agent binding.\"\"\""},{"line_number":61,"context_line":"        # TODO(gongysh) consider the disabled agent\u0027s router"},{"line_number":62,"context_line":"        no_agent_binding \u003d ~sql.exists().where("}],"source_content_type":"text/x-python","patch_set":26,"id":"dab17558_063aa8e7","line":59,"in_reply_to":"dab17558_a213630c","updated":"2016-05-12 09:30:57.000000000","message":"Will do, either in this patch or some other patch that will change this to all the functions in the file.","commit_id":"e92b5efdedd4782b2589c78435ca90c4ce9ba19a"}],"releasenotes/notes/auto-schedule-routers-regression-9d2282a38e94fcdc.yaml":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eb60f42715350b6598966cc0ca8c04b906f5d434","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    L3\u0027s auto schedule has been reduced to avoid race conditions."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The L3 agent\u0027s auto schedule code was prone to race conditions."},{"line_number":6,"context_line":"    This change introduces a significant reduction in the logic and"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1a122d0e_4feef08b","line":3,"updated":"2016-05-04 23:30:12.000000000","message":"missing agent\u0027s","commit_id":"eccfd600d59d74bed6ad5c1d548bc911e51dcc27"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"8215113d2531810a5cd637c1fe85b2323427411c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    L3\u0027s auto schedule has been reduced to avoid race conditions."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The L3 agent\u0027s auto schedule code was prone to race conditions."},{"line_number":6,"context_line":"    This change introduces a significant reduction in the logic and"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"dab17558_6f72124b","line":3,"in_reply_to":"1a122d0e_4feef08b","updated":"2016-05-09 12:37:24.000000000","message":"Done","commit_id":"eccfd600d59d74bed6ad5c1d548bc911e51dcc27"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"eb60f42715350b6598966cc0ca8c04b906f5d434","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - If an HA router is scheduled to less than \u0027max_l3_agents_per_router\u0027"},{"line_number":13,"context_line":"    and additional agents are available, the router won\u0027t be scheduled"},{"line_number":14,"context_line":"    to them automatically."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"1a122d0e_6fe92c7f","line":15,"updated":"2016-05-04 23:30:12.000000000","message":"one new line too many","commit_id":"eccfd600d59d74bed6ad5c1d548bc911e51dcc27"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"8215113d2531810a5cd637c1fe85b2323427411c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - If an HA router is scheduled to less than \u0027max_l3_agents_per_router\u0027"},{"line_number":13,"context_line":"    and additional agents are available, the router won\u0027t be scheduled"},{"line_number":14,"context_line":"    to them automatically."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"dab17558_8f777639","line":15,"in_reply_to":"1a122d0e_6fe92c7f","updated":"2016-05-09 12:37:24.000000000","message":"Done","commit_id":"eccfd600d59d74bed6ad5c1d548bc911e51dcc27"}]}
