)]}'
{"quantum/db/extraroute_db.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5729d85a86ea846f022ea6c07bfbc46ff12ed794","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from oslo.config import cfg"},{"line_number":20,"context_line":"import sqlalchemy as sa"},{"line_number":21,"context_line":"from sqlalchemy import orm"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantum.common import utils"},{"line_number":24,"context_line":"from quantum.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FeiY%3D","line":21,"updated":"2013-05-08 14:55:23.000000000","message":"This should be before line 20","commit_id":"3a8d317b8be5d108e71e73c18dff879029803ef5"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4d55835449b6cbe4dc4da472a5e291a7b6eca9db","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from oslo.config import cfg"},{"line_number":20,"context_line":"import sqlalchemy as sa"},{"line_number":21,"context_line":"from sqlalchemy import orm"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantum.common import utils"},{"line_number":24,"context_line":"from quantum.db import db_base_plugin_v2"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FeY8%3D","line":21,"in_reply_to":"AAAAOn%2F%2FeiY%3D","updated":"2013-05-08 15:43:47.000000000","message":"No, pep8 is checking this.","commit_id":"3a8d317b8be5d108e71e73c18dff879029803ef5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5729d85a86ea846f022ea6c07bfbc46ff12ed794","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          primary_key\u003dTrue)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    router \u003d orm.relationship(l3_db.Router,"},{"line_number":51,"context_line":"                              backref\u003dorm.backref(\"route_list\","},{"line_number":52,"context_line":"                                                  lazy\u003d\u0027joined\u0027,"},{"line_number":53,"context_line":"                                                  cascade\u003d\u0027delete\u0027))"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FegY%3D","line":51,"updated":"2013-05-08 15:02:04.000000000","message":"nit. How about use name \u0027routes\u0027 instead of \u0027route_list\u0027","commit_id":"3a8d317b8be5d108e71e73c18dff879029803ef5"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4d55835449b6cbe4dc4da472a5e291a7b6eca9db","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          primary_key\u003dTrue)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    router \u003d orm.relationship(l3_db.Router,"},{"line_number":51,"context_line":"                              backref\u003dorm.backref(\"route_list\","},{"line_number":52,"context_line":"                                                  lazy\u003d\u0027joined\u0027,"},{"line_number":53,"context_line":"                                                  cascade\u003d\u0027delete\u0027))"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FeZo%3D","line":51,"in_reply_to":"AAAAOn%2F%2FegY%3D","updated":"2013-05-08 15:43:47.000000000","message":"In fact, that was initial version, but that would require additional actions in update_router method:\n super(ExtraRoute_db_mixin, self).update_router(context, id, router) can not receive a dict with \u0027routes\u0027 attribute because it would map on sqlalchemy attr \u0027routes\u0027 and would be in different format.","commit_id":"3a8d317b8be5d108e71e73c18dff879029803ef5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5729d85a86ea846f022ea6c07bfbc46ff12ed794","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                self._update_extra_routes(context,"},{"line_number":75,"context_line":"                                          router_db,"},{"line_number":76,"context_line":"                                          r[\u0027routes\u0027])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            router_updated \u003d super(ExtraRoute_db_mixin, self).update_router("},{"line_number":79,"context_line":"                context, id, router)"},{"line_number":80,"context_line":"            router_updated[\u0027routes\u0027] \u003d self._get_extra_routes_by_router_id("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fehc%3D","line":77,"updated":"2013-05-08 14:55:23.000000000","message":"Not sure we need add blank line. In normal we shoudn\u0027t touch those unrelated-modification. Right?","commit_id":"3a8d317b8be5d108e71e73c18dff879029803ef5"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4d55835449b6cbe4dc4da472a5e291a7b6eca9db","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                self._update_extra_routes(context,"},{"line_number":75,"context_line":"                                          router_db,"},{"line_number":76,"context_line":"                                          r[\u0027routes\u0027])"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            router_updated \u003d super(ExtraRoute_db_mixin, self).update_router("},{"line_number":79,"context_line":"                context, id, router)"},{"line_number":80,"context_line":"            router_updated[\u0027routes\u0027] \u003d self._get_extra_routes_by_router_id("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FeZk%3D","line":77,"in_reply_to":"AAAAOn%2F%2Fehc%3D","updated":"2013-05-08 15:43:47.000000000","message":"Done","commit_id":"3a8d317b8be5d108e71e73c18dff879029803ef5"}],"quantum/tests/unit/test_extension_extraroute.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5729d85a86ea846f022ea6c07bfbc46ff12ed794","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"                    body \u003d self._update(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":93,"context_line":"                                        {\u0027router\u0027: {\u0027routes\u0027: routes}})"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"                    body \u003d self._show(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027])"},{"line_number":96,"context_line":"                    self.assertEqual(body[\u0027router\u0027][\u0027routes\u0027],"},{"line_number":97,"context_line":"                                     routes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FehA%3D","side":"PARENT","line":94,"updated":"2013-05-08 14:55:23.000000000","message":"I didn\u0027t suggestion touch this","commit_id":"f94126739a48993efaf1d1439dcd3dadb0c69742"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"4d55835449b6cbe4dc4da472a5e291a7b6eca9db","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"                    body \u003d self._update(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":93,"context_line":"                                        {\u0027router\u0027: {\u0027routes\u0027: routes}})"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"                    body \u003d self._show(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027])"},{"line_number":96,"context_line":"                    self.assertEqual(body[\u0027router\u0027][\u0027routes\u0027],"},{"line_number":97,"context_line":"                                     routes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FeY0%3D","side":"PARENT","line":94,"in_reply_to":"AAAAOn%2F%2FehA%3D","updated":"2013-05-08 15:43:47.000000000","message":"Done","commit_id":"f94126739a48993efaf1d1439dcd3dadb0c69742"}]}