)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e84372423c3738da609df49daef0bdd05aeda337","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Ann Kamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1548285"},{"line_number":19,"context_line":"Change-Id: Iadb5a69d4cbc2515fb112867c525676cadea002b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_8b2bfe93","line":18,"updated":"2016-02-26 22:43:48.000000000","message":"Is this the correct bug?","commit_id":"e7abb062dac36feb37f315fed5b6408027598833"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ad91a5e7ae1b1206e106d508002e9b77b194c3ce","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Ann Kamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1548285"},{"line_number":19,"context_line":"Change-Id: Iadb5a69d4cbc2515fb112867c525676cadea002b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_c6d33d5e","line":18,"updated":"2016-02-26 22:50:41.000000000","message":"whoops, no. copied from the wrong patch","commit_id":"e7abb062dac36feb37f315fed5b6408027598833"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d2a7cd8a92c450f70aefaab7c9cac9e150aa8907","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Co-Authored-By: Ann Kamyshnikova \u003cakamyshnikova@mirantis.com\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1499647"},{"line_number":19,"context_line":"Change-Id: Iadb5a69d4cbc2515fb112867c525676cadea002b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_e6c76110","line":18,"updated":"2016-02-26 23:03:50.000000000","message":"This patch doesn\u0027t close this bug \u003dp\n\nThis patch: https://review.openstack.org/#/c/285480/ closes the bug you\u0027re referring to.","commit_id":"53d9691b0faaf1383f6e5d4d98c8e4d4da8c75f5"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ad91a5e7ae1b1206e106d508002e9b77b194c3ce","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            router[constants.HA_INTERFACE_KEY] \u003d port_dict"},{"line_number":633,"context_line":"            router[constants.HA_ROUTER_STATE_KEY] \u003d binding.state"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        # keys that must be present present not None in the router body to be"},{"line_number":636,"context_line":"        # sent to the agent if it\u0027s an HA router."},{"line_number":637,"context_line":"        REQUIRED_KEYS \u003d [constants.HA_INTERFACE_KEY,"},{"line_number":638,"context_line":"                         constants.HA_ROUTER_STATE_KEY]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_26cb09a7","line":635,"updated":"2016-02-26 22:50:41.000000000","message":"Done","commit_id":"e7abb062dac36feb37f315fed5b6408027598833"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e84372423c3738da609df49daef0bdd05aeda337","unresolved":false,"context_lines":[{"line_number":632,"context_line":"            router[constants.HA_INTERFACE_KEY] \u003d port_dict"},{"line_number":633,"context_line":"            router[constants.HA_ROUTER_STATE_KEY] \u003d binding.state"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"        # keys that must be present present not None in the router body to be"},{"line_number":636,"context_line":"        # sent to the agent if it\u0027s an HA router."},{"line_number":637,"context_line":"        REQUIRED_KEYS \u003d [constants.HA_INTERFACE_KEY,"},{"line_number":638,"context_line":"                         constants.HA_ROUTER_STATE_KEY]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_cb66a628","line":635,"updated":"2016-02-26 22:43:48.000000000","message":"This is kind of a round about way I think. Looking at lines 628 to 633, the code is populating router[constants...] if the router has a binding on the host. So essentially shouldn\u0027t lines 637 to 648 be something like:\n\nrouter_ids_with_bindings \u003d set(binding.router_id for binding in bindings)  # Or preferably build it while you\u0027re iterating over the bindings.\n\nThen do a dict comprehension, filtering out keys from routers_dict if the \u0027id\u0027 field is not present in router_ids_with_bindings and it\u0027s an HA router.","commit_id":"e7abb062dac36feb37f315fed5b6408027598833"}],"neutron/tests/unit/db/test_l3_hamode_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f490ce15da128e0d89ad98fc881067cd698dc8c1","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.plugin.supported_extension_aliases \u003d ["},{"line_number":430,"context_line":"            constants.L3_HA_MODE_EXT_ALIAS]"},{"line_number":431,"context_line":"        # simulate a router that is being allocated during"},{"line_number":432,"context_line":"        # the agent\u0027s sychcronization"},{"line_number":433,"context_line":"        r1, r2 \u003d self._create_router(), self._create_router()"},{"line_number":434,"context_line":"        self.plugin._delete_ha_interfaces(self.admin_ctx, r1[\u0027id\u0027])"},{"line_number":435,"context_line":"        # store shorter name for readability"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_5ad4031f","line":432,"range":{"start_line":432,"start_character":22,"end_line":432,"end_character":37},"updated":"2016-02-28 10:16:18.000000000","message":"sychcronization \u003d\u003e synchronization","commit_id":"c2cee540252ceddab4cf0f09e81b4e2bbb42c1e4"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e2015987bb8d5565199e13ebc98486f95733fe52","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.plugin.supported_extension_aliases \u003d ["},{"line_number":430,"context_line":"            constants.L3_HA_MODE_EXT_ALIAS]"},{"line_number":431,"context_line":"        # simulate a router that is being allocated during"},{"line_number":432,"context_line":"        # the agent\u0027s sychcronization"},{"line_number":433,"context_line":"        r1, r2 \u003d self._create_router(), self._create_router()"},{"line_number":434,"context_line":"        self.plugin._delete_ha_interfaces(self.admin_ctx, r1[\u0027id\u0027])"},{"line_number":435,"context_line":"        # store shorter name for readability"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_a26ec593","line":432,"range":{"start_line":432,"start_character":22,"end_line":432,"end_character":37},"in_reply_to":"9aed3d3a_5ad4031f","updated":"2016-02-28 18:03:36.000000000","message":"Done","commit_id":"c2cee540252ceddab4cf0f09e81b4e2bbb42c1e4"}]}
