)]}'
{"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d193dcf441d18eb08c00aaccf5a9fb1ae8195847","unresolved":false,"context_lines":[{"line_number":2089,"context_line":""},{"line_number":2090,"context_line":"            def mock_update(port_id, dict):"},{"line_number":2091,"context_line":"                port \u003d reserved_port"},{"line_number":2092,"context_line":"                port.network_id \u003d dict[\u0027port\u0027].get(\u0027network_id\u0027, None)"},{"line_number":2093,"context_line":"                port.device_id \u003d dict[\u0027port\u0027].get(\u0027device_id\u0027, None)"},{"line_number":2094,"context_line":"                return port"},{"line_number":2095,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_f2da294a","line":2092,"range":{"start_line":2092,"start_character":46,"end_line":2092,"end_character":70},"updated":"2016-03-03 13:12:07.000000000","message":"\"get\" will return None, by default","commit_id":"5e63b0661889065e42bcd042f15f51afbd4570dd"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d193dcf441d18eb08c00aaccf5a9fb1ae8195847","unresolved":false,"context_lines":[{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"            except_ips \u003d [\u0027192.168.0.6/24\u0027]"},{"line_number":2105,"context_line":"            if enable_isolated_metadata or force_metadata:"},{"line_number":2106,"context_line":"                except_ips.append(\u0027169.254.169.254/16\u0027)"},{"line_number":2107,"context_line":"            mgr.driver.init_l3.assert_called_with(\u0027ns-XXX\u0027,"},{"line_number":2108,"context_line":"                                                  except_ips,"},{"line_number":2109,"context_line":"                                                  namespace\u003d\u0027qdhcp-ns\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_12f7d58b","line":2106,"range":{"start_line":2106,"start_character":35,"end_line":2106,"end_character":54},"updated":"2016-03-03 13:12:07.000000000","message":"how about using the const METADATA_DEFAULT_CIDR","commit_id":"5e63b0661889065e42bcd042f15f51afbd4570dd"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d193dcf441d18eb08c00aaccf5a9fb1ae8195847","unresolved":false,"context_lines":[{"line_number":2160,"context_line":"                    return None"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"                port \u003d reserved_port_2"},{"line_number":2163,"context_line":"                port.network_id \u003d dict[\u0027port\u0027].get(\u0027network_id\u0027, None)"},{"line_number":2164,"context_line":"                port.device_id \u003d dict[\u0027port\u0027].get(\u0027device_id\u0027, None)"},{"line_number":2165,"context_line":"                return port"},{"line_number":2166,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_927f65df","line":2163,"range":{"start_line":2163,"start_character":46,"end_line":2163,"end_character":70},"updated":"2016-03-03 13:12:07.000000000","message":"\"get\" will return None, by default","commit_id":"5e63b0661889065e42bcd042f15f51afbd4570dd"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"d193dcf441d18eb08c00aaccf5a9fb1ae8195847","unresolved":false,"context_lines":[{"line_number":2174,"context_line":""},{"line_number":2175,"context_line":"            except_ips \u003d [\u0027192.168.0.6/24\u0027]"},{"line_number":2176,"context_line":"            if enable_isolated_metadata or force_metadata:"},{"line_number":2177,"context_line":"                except_ips.append(\u0027169.254.169.254/16\u0027)"},{"line_number":2178,"context_line":"            mgr.driver.init_l3.assert_called_with(\u0027ns-XXX\u0027,"},{"line_number":2179,"context_line":"                                                  except_ips,"},{"line_number":2180,"context_line":"                                                  namespace\u003d\u0027qdhcp-ns\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_b261c13b","line":2177,"range":{"start_line":2177,"start_character":35,"end_line":2177,"end_character":53},"updated":"2016-03-03 13:12:07.000000000","message":"how about using the const METADATA_DEFAULT_CIDR","commit_id":"5e63b0661889065e42bcd042f15f51afbd4570dd"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8155bc104717b374b2be228f2060888c441d5d93","unresolved":false,"context_lines":[{"line_number":2185,"context_line":"        \"\"\""},{"line_number":2186,"context_line":"        self._test_setup_reserved_2()"},{"line_number":2187,"context_line":""},{"line_number":2188,"context_line":"    def test_setup_reserved_2_with_isolated_metadata_enable(self):"},{"line_number":2189,"context_line":"        \"\"\"Test scenario where a network has two reserved ports, and"},{"line_number":2190,"context_line":"        update_dhcp_port fails for the first of those."},{"line_number":2191,"context_line":"        \"\"\""},{"line_number":2192,"context_line":"        self._test_setup_reserved_2(enable_isolated_metadata\u003dTrue)"},{"line_number":2193,"context_line":""},{"line_number":2194,"context_line":"    def test_setup_reserved_2_with_force_metadata_enable(self):"},{"line_number":2195,"context_line":"        \"\"\"Test scenario where a network has two reserved ports, and"},{"line_number":2196,"context_line":"        update_dhcp_port fails for the first of those."},{"line_number":2197,"context_line":"        \"\"\""},{"line_number":2198,"context_line":"        self._test_setup_reserved_2(force_metadata\u003dTrue)"},{"line_number":2199,"context_line":""},{"line_number":2200,"context_line":"    def test_setup_reserved_2_and_enable_metadata(self):"},{"line_number":2201,"context_line":"        \"\"\"Test scenario where a network has two reserved ports, and"},{"line_number":2202,"context_line":"        update_dhcp_port fails for the first of those."},{"line_number":2203,"context_line":"        \"\"\""},{"line_number":2204,"context_line":"        self._test_setup_reserved_2(enable_isolated_metadata\u003dTrue,"},{"line_number":2205,"context_line":"                                    force_metadata\u003dTrue)"},{"line_number":2206,"context_line":""},{"line_number":2207,"context_line":""},{"line_number":2208,"context_line":"class TestDictModel(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_b7211afe","line":2205,"range":{"start_line":2188,"start_character":0,"end_line":2205,"end_character":56},"updated":"2016-03-14 03:05:58.000000000","message":"I think it is over test here. line 2117 ~ 2134 has done the test. The test here seems duplicated. If I am wrong, pls correct me.","commit_id":"eeb52e625b55031146e8d7f273684f311a844e90"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"939eb59e4a61e42258bc21df26404767b1fb7620","unresolved":false,"context_lines":[{"line_number":2139,"context_line":"            self.conf.register_opt("},{"line_number":2140,"context_line":"                cfg.BoolOpt(\u0027enable_isolated_metadata\u0027, default\u003dFalse))"},{"line_number":2141,"context_line":"            self.conf.register_opt(cfg.BoolOpt(\u0027force_metadata\u0027,"},{"line_number":2142,"context_line":"                                   default\u003dFalse))"},{"line_number":2143,"context_line":"            plugin \u003d mock.Mock()"},{"line_number":2144,"context_line":"            device \u003d mock.Mock()"},{"line_number":2145,"context_line":"            mock_IPDevice.return_value \u003d device"}],"source_content_type":"text/x-python","patch_set":10,"id":"3afc51ec_dd07a77f","line":2142,"updated":"2016-03-14 04:53:11.000000000","message":"If you got another chance to re-spin the patch, the indention here should be the same as line 2077.","commit_id":"dcb945a7690d21e964f7b532a7f461ebc4baddff"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"39fc27f8be7d681d7d68fd0ab6cca6697e43690d","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"                                                  namespace\u003d\u0027qdhcp-ns\u0027)"},{"line_number":2111,"context_line":""},{"line_number":2112,"context_line":"    def test_setup_reserved_and_disable_metadata(self):"},{"line_number":2113,"context_line":"        \"\"\"Test reserved port case of DeviceManager\u0027s DHCP port setup"},{"line_number":2114,"context_line":"        logic."},{"line_number":2115,"context_line":"        \"\"\""},{"line_number":2116,"context_line":"        self._test_setup_reserved()"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":"    def test_setup_reserved_with_isolated_metadata_enable(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a1b2928_dfd517ba","line":2115,"range":{"start_line":2113,"start_character":8,"end_line":2115,"end_character":11},"updated":"2016-04-10 22:07:05.000000000","message":"Four tests have same docstring. Does it provide any information more than method names? If needed, it is better to use different docstring for the four tests.","commit_id":"c3e21a515f500249f7150057e17b5de5f0e014fb"},{"author":{"_account_id":14103,"name":"wangtianfa","email":"wang.tianfa@99cloud.net","username":"wangtianfa"},"change_message_id":"c9ec5859e0153eac9726c2f1eb025064993a3bc2","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"                                                  namespace\u003d\u0027qdhcp-ns\u0027)"},{"line_number":2111,"context_line":""},{"line_number":2112,"context_line":"    def test_setup_reserved_and_disable_metadata(self):"},{"line_number":2113,"context_line":"        \"\"\"Test reserved port case of DeviceManager\u0027s DHCP port setup"},{"line_number":2114,"context_line":"        logic."},{"line_number":2115,"context_line":"        \"\"\""},{"line_number":2116,"context_line":"        self._test_setup_reserved()"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":"    def test_setup_reserved_with_isolated_metadata_enable(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7a1b2928_aad73722","line":2115,"range":{"start_line":2113,"start_character":8,"end_line":2115,"end_character":11},"in_reply_to":"7a1b2928_dfd517ba","updated":"2016-04-11 00:11:48.000000000","message":"Done","commit_id":"c3e21a515f500249f7150057e17b5de5f0e014fb"}]}
