)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"80b928c004c4926784ef9533897e1e5bfac74db4","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":263,"context_line":"            except Exception as e:"},{"line_number":264,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":265,"context_line":"                    LOG.error(_LE(\"Failed to connect to OVS. \""},{"line_number":266,"context_line":"                                  \"Retrying in 1 second. Attempt: %s\"), i)"},{"line_number":267,"context_line":"                    time.sleep(1)"},{"line_number":268,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_a8cdad67","line":265,"updated":"2016-03-01 09:58:16.000000000","message":"probably warning is a good idea since this is something that shouldn\u0027t really happen during normal operations","commit_id":"c50ac0bc76384d5b44bc5179dcd806296535507c"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"9798ad0912e5cb899f5281953a72036ee8cb115b","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":263,"context_line":"            except Exception as e:"},{"line_number":264,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":265,"context_line":"                    LOG.error(_LE(\"Failed to connect to OVS. \""},{"line_number":266,"context_line":"                                  \"Retrying in 1 second. Attempt: %s\"), i)"},{"line_number":267,"context_line":"                    time.sleep(1)"},{"line_number":268,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_dfb8a913","line":265,"updated":"2016-03-01 09:00:18.000000000","message":"since we are not failing here, maybe it\u0027s better to decrease the log level to warning or even info?","commit_id":"c50ac0bc76384d5b44bc5179dcd806296535507c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1989be040c741c75f44050a2a6a0f5c957ab47ef","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def run_ofctl(self, cmd, args, process_input\u003dNone):"},{"line_number":258,"context_line":"        full_args \u003d [\"ovs-ofctl\", cmd, self.br_name] + args"},{"line_number":259,"context_line":"        for i in range(1, 11):"},{"line_number":260,"context_line":"            try:"},{"line_number":261,"context_line":"                return utils.execute(full_args, run_as_root\u003dTrue,"},{"line_number":262,"context_line":"                                     process_input\u003dprocess_input)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_d6096833","line":259,"updated":"2016-03-01 19:02:13.000000000","message":"In the interest of gate stability, I would be okay to merge this. However, I would like to see a giant TODO added: this error handling is very brittle and we would either need to figure out a more robust way of detecting the missing bridge setup, or move away from executing shell commands completely in favor of the native interface.","commit_id":"588bfe89dc649f833833790318a409a25daf8fd5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"71b3a4cce0dd591bd6f1000a39df2bbe949056c0","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        for attempts in range(1, 11):"},{"line_number":228,"context_line":"            if self.run_ofctl(\"dump-flows\", []) is not None:"},{"line_number":229,"context_line":"                return"},{"line_number":230,"context_line":"            LOG.warning(_LW(\"Failed to retrieve flows from bridge. Retrying \""},{"line_number":231,"context_line":"                            \"in 1 second. Attempt: %s/10\"), attempts)"},{"line_number":232,"context_line":"            time.sleep(1)"},{"line_number":233,"context_line":"        raise RuntimeError(_(\"Timed out waiting to get flows from \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_11747a33","line":230,"updated":"2016-03-01 19:10:26.000000000","message":"I am not sure we can do anything with this warning, I would demote it to debug.","commit_id":"f3c51d8eaf9d1d3a073c59ea80c19548a9c0cbd4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"da14db4a04851eee4d8d196d3a79e10c1096927a","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        for attempts in range(1, 11):"},{"line_number":228,"context_line":"            if self.run_ofctl(\"dump-flows\", []) is not None:"},{"line_number":229,"context_line":"                return"},{"line_number":230,"context_line":"            LOG.warning(_LW(\"Failed to retrieve flows from bridge. Retrying \""},{"line_number":231,"context_line":"                            \"in 1 second. Attempt: %s/10\"), attempts)"},{"line_number":232,"context_line":"            time.sleep(1)"},{"line_number":233,"context_line":"        raise RuntimeError(_(\"Timed out waiting to get flows from \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_3c4fcdbe","line":230,"in_reply_to":"7af24918_11747a33","updated":"2016-03-01 19:29:06.000000000","message":"I\u0027ll demote you to debug!","commit_id":"f3c51d8eaf9d1d3a073c59ea80c19548a9c0cbd4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b511ccadfcd76701a1b1f09619e10c9dd7bc60e4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.ovsdb.add_br(bridge_name,"},{"line_number":122,"context_line":"                          datapath_type).execute()"},{"line_number":123,"context_line":"        br \u003d OVSBridge(bridge_name)"},{"line_number":124,"context_line":"        # Don\u0027t return until vswitchd sets up the internal port"},{"line_number":125,"context_line":"        br.get_port_ofport(bridge_name)"},{"line_number":126,"context_line":"        br.ensure_list_flows()"},{"line_number":127,"context_line":"        return br"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_33a6d3c1","line":124,"updated":"2016-03-01 21:54:41.000000000","message":"nit: like L226... # and we can list flows","commit_id":"260daae0ee8be51868a17f9b9b6be4e50290e4a8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5f0098126ea66e16cee41d457ec2a43d609575c1","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":267,"context_line":"            except Exception as e:"},{"line_number":268,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":269,"context_line":"                    LOG.warning(_LW(\"Failed to connect to OVS. Retrying \""},{"line_number":270,"context_line":"                                    \"in 1 second. Attempt: %s/10\"), i)"},{"line_number":271,"context_line":"                    time.sleep(1)"},{"line_number":272,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_7fee5923","line":269,"updated":"2016-03-02 00:07:20.000000000","message":"Done","commit_id":"4246d15a506d526fc008529412ca725367b24ab2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0c8f89d4278ae006b996f87f2278df21d5dfe48d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                                     process_input\u003dprocess_input)"},{"line_number":267,"context_line":"            except Exception as e:"},{"line_number":268,"context_line":"                if \"failed to connect to socket\" in str(e):"},{"line_number":269,"context_line":"                    LOG.warning(_LW(\"Failed to connect to OVS. Retrying \""},{"line_number":270,"context_line":"                                    \"in 1 second. Attempt: %s/10\"), i)"},{"line_number":271,"context_line":"                    time.sleep(1)"},{"line_number":272,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_245fa442","line":269,"updated":"2016-03-02 00:04:07.000000000","message":"debug?","commit_id":"4246d15a506d526fc008529412ca725367b24ab2"}]}
