)]}'
{"quantum/plugins/common/plugin_utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"809e60f5a3babaca15ede9cc9407a1a1b49c3670","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 Cisco Systems, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc3U%3D","line":1,"updated":"2013-05-09 06:26:39.000000000","message":"why not call this utils?","commit_id":"ba3b63054bb4b74c4cc20783c7437927c13df9cd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"809e60f5a3babaca15ede9cc9407a1a1b49c3670","unresolved":false,"context_lines":[{"line_number":19,"context_line":"\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class PluginUtilsException(Exception):"},{"line_number":23,"context_line":"    def __init__(self, **kwargs):"},{"line_number":24,"context_line":"        super(PluginUtilsException, self).__init__(self.message % kwargs)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc3I%3D","line":22,"updated":"2013-05-09 06:26:39.000000000","message":"Why not use the quantum exceptions?\n\nThese are from https://github.com/openstack/quantum/blob/master/quantum/common/exceptions.py","commit_id":"ba3b63054bb4b74c4cc20783c7437927c13df9cd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"809e60f5a3babaca15ede9cc9407a1a1b49c3670","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def parse_network_vlan_range(network_vlan_range):"},{"line_number":32,"context_line":"    \u0027\u0027\u0027Interpret a string as network[:vlan_begin:vlan_end]."},{"line_number":33,"context_line":"    \u0027\u0027\u0027"},{"line_number":34,"context_line":"    entry \u003d network_vlan_range.strip()"},{"line_number":35,"context_line":"    if \u0027:\u0027 in entry:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc3E%3D","line":32,"updated":"2013-05-09 06:26:39.000000000","message":"Please use \"\"\" to be consistant with the rest of the code","commit_id":"ba3b63054bb4b74c4cc20783c7437927c13df9cd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"809e60f5a3babaca15ede9cc9407a1a1b49c3670","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def parse_network_vlan_ranges(network_vlan_ranges_cfg_entries):"},{"line_number":47,"context_line":"    \u0027\u0027\u0027Interpret a list of strings as network[:vlan_begin:vlan_end] entries."},{"line_number":48,"context_line":"    \u0027\u0027\u0027"},{"line_number":49,"context_line":"    networks \u003d {}"},{"line_number":50,"context_line":"    for entry in network_vlan_ranges_cfg_entries:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc3A%3D","line":47,"updated":"2013-05-09 06:26:39.000000000","message":"Ditto","commit_id":"ba3b63054bb4b74c4cc20783c7437927c13df9cd"}],"quantum/plugins/common/utils.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"be62f96fcf1cdf32e43f1b9f8c18ff9b24f705fa","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def parse_network_vlan_range(network_vlan_range):"},{"line_number":25,"context_line":"    \"\"\"Interpret a string as network[:vlan_begin:vlan_end]."},{"line_number":26,"context_line":"    \"\"\""},{"line_number":27,"context_line":"    entry \u003d network_vlan_range.strip()"},{"line_number":28,"context_line":"    if \u0027:\u0027 in entry:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fcg4%3D","line":25,"updated":"2013-05-09 13:01:16.000000000","message":"Nit: See PEP257, closing quotes on same line, for one liners.","commit_id":"f9a96d6beed381a2ad1e60e6f020b34f096f376b"}],"quantum/plugins/hyperv/hyperv_quantum_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"809e60f5a3babaca15ede9cc9407a1a1b49c3670","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from quantum.extensions import providernet as provider"},{"line_number":29,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":30,"context_line":"from quantum.openstack.common import rpc"},{"line_number":31,"context_line":"from quantum.plugins.common import plugin_utils"},{"line_number":32,"context_line":"from quantum.plugins.hyperv import agent_notifier_api"},{"line_number":33,"context_line":"from quantum.plugins.hyperv.common import constants"},{"line_number":34,"context_line":"from quantum.plugins.hyperv import db as hyperv_db"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc28%3D","line":31,"updated":"2013-05-09 06:26:39.000000000","message":"I would prefer from quantum.plugins.common import utils as plugin_utils (if utils has already been used)","commit_id":"ba3b63054bb4b74c4cc20783c7437927c13df9cd"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"be62f96fcf1cdf32e43f1b9f8c18ff9b24f705fa","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        try:"},{"line_number":201,"context_line":"            self._network_vlan_ranges \u003d plugin_utils.parse_network_vlan_ranges("},{"line_number":202,"context_line":"                cfg.CONF.HYPERV.network_vlan_ranges)"},{"line_number":203,"context_line":"        except Exception as ex:"},{"line_number":204,"context_line":"            msg \u003d _(\"%(error)s. Agent terminated!\") % {\u0027error\u0027: ex}"},{"line_number":205,"context_line":"            raise q_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":206,"context_line":"        LOG.info(_(\"Network VLAN ranges: %s\"), self._network_vlan_ranges)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fcks%3D","line":203,"updated":"2013-05-09 12:10:09.000000000","message":"Since plugin_utils.parse_network_vlan_ranges() is already raising an exception, couldn\u0027t we just remove the try block and handling, and let that exception percolate up?\n\nCould re-throw it as an InvalidInput exception, inside of parse_network_vlan_ranges(), if want to keep the exception the same.","commit_id":"ba3b63054bb4b74c4cc20783c7437927c13df9cd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"809e60f5a3babaca15ede9cc9407a1a1b49c3670","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            self._network_vlan_ranges \u003d plugin_utils.parse_network_vlan_ranges("},{"line_number":202,"context_line":"                cfg.CONF.HYPERV.network_vlan_ranges)"},{"line_number":203,"context_line":"        except Exception as ex:"},{"line_number":204,"context_line":"            msg \u003d _(\"%(error)s. Agent terminated!\") % {\u0027error\u0027: ex}"},{"line_number":205,"context_line":"            raise q_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":206,"context_line":"        LOG.info(_(\"Network VLAN ranges: %s\"), self._network_vlan_ranges)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fc24%3D","line":204,"updated":"2013-05-09 06:26:39.000000000","message":"If there is only parameter then you do not need a dictionary.\n\nI think that you should change the text here. At this stage the agent is not terminated. This may or may not be done later.","commit_id":"ba3b63054bb4b74c4cc20783c7437927c13df9cd"}],"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"be62f96fcf1cdf32e43f1b9f8c18ff9b24f705fa","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.l3_agent_notifier \u003d l3_rpc_agent_api.L3AgentNotify"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _parse_network_vlan_ranges(self):"},{"line_number":254,"context_line":"        try:"},{"line_number":255,"context_line":"            self.network_vlan_ranges \u003d plugin_utils.parse_network_vlan_ranges("},{"line_number":256,"context_line":"                cfg.CONF.VLANS.network_vlan_ranges)"},{"line_number":257,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fcgw%3D","line":254,"updated":"2013-05-09 13:01:16.000000000","message":"Remove try block here too?","commit_id":"f9a96d6beed381a2ad1e60e6f020b34f096f376b"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"be62f96fcf1cdf32e43f1b9f8c18ff9b24f705fa","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.l3_agent_notifier \u003d l3_rpc_agent_api.L3AgentNotify"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _parse_network_vlan_ranges(self):"},{"line_number":254,"context_line":"        try:"},{"line_number":255,"context_line":"            self.network_vlan_ranges \u003d plugin_utils.parse_network_vlan_ranges("},{"line_number":256,"context_line":"                cfg.CONF.VLANS.network_vlan_ranges)"},{"line_number":257,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FcfQ%3D","line":254,"in_reply_to":"AAAAOn%2F%2Fcgg%3D","updated":"2013-05-09 13:27:01.000000000","message":"Gotcha. Was thinking these were the same as the HyperV plugin.","commit_id":"f9a96d6beed381a2ad1e60e6f020b34f096f376b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":251,"context_line":"        self.l3_agent_notifier \u003d l3_rpc_agent_api.L3AgentNotify"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def _parse_network_vlan_ranges(self):"},{"line_number":254,"context_line":"        try:"},{"line_number":255,"context_line":"            self.network_vlan_ranges \u003d plugin_utils.parse_network_vlan_ranges("},{"line_number":256,"context_line":"                cfg.CONF.VLANS.network_vlan_ranges)"},{"line_number":257,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fcgg%3D","line":254,"in_reply_to":"AAAAOn%2F%2Fcgw%3D","updated":"2013-05-09 13:08:44.000000000","message":"I didn\u0027t want to change the behaviour of the plugin. Currently it logs the error and quits.","commit_id":"f9a96d6beed381a2ad1e60e6f020b34f096f376b"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"be62f96fcf1cdf32e43f1b9f8c18ff9b24f705fa","unresolved":false,"context_lines":[{"line_number":300,"context_line":"        self.conn.consume_in_thread()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _parse_network_vlan_ranges(self):"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            self.network_vlan_ranges \u003d plugin_utils.parse_network_vlan_ranges("},{"line_number":305,"context_line":"                cfg.CONF.OVS.network_vlan_ranges)"},{"line_number":306,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fcgs%3D","line":303,"updated":"2013-05-09 13:01:16.000000000","message":"Ditto on try block removal.","commit_id":"f9a96d6beed381a2ad1e60e6f020b34f096f376b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":300,"context_line":"        self.conn.consume_in_thread()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def _parse_network_vlan_ranges(self):"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            self.network_vlan_ranges \u003d plugin_utils.parse_network_vlan_ranges("},{"line_number":305,"context_line":"                cfg.CONF.OVS.network_vlan_ranges)"},{"line_number":306,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Fcgc%3D","line":303,"in_reply_to":"AAAAOn%2F%2Fcgs%3D","updated":"2013-05-09 13:08:44.000000000","message":"Ditto on keeping existing behaviour.","commit_id":"f9a96d6beed381a2ad1e60e6f020b34f096f376b"}]}