)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c7a879e9851ff142ad8354a033ce4d9618c5198b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When the ARP responder is enabled, secondary IP addresses explicitly"},{"line_number":10,"context_line":"allowed by via the allowed-address-pairs extensions do not resolve."},{"line_number":11,"context_line":"This change adds the ability to enable the local ARP responder similar"},{"line_number":12,"context_line":"to the feature in the OVS agent.  This change disables local ARP"},{"line_number":13,"context_line":"responses by default, so ARP traffic will be sent over the overlay."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"},{"line_number":16,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba0121b8_10edaa8e","line":13,"range":{"start_line":12,"start_character":34,"end_line":13,"end_character":67},"updated":"2016-04-02 15:01:50.000000000","message":"This commit message is wrong.\nIn this backport, the default value is changed to False.","commit_id":"c823e8ccb951a4abdf247dd094a794b7741d7cca"}],"etc/neutron/plugins/ml2/linuxbridge_agent.ini":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f13ad8c5a6043d316fada9dc3ec0bd4a599c7846","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# iproute2 supports unicast flooding - requires 3.11 kernel and iproute2 3.10)"},{"line_number":41,"context_line":"# l2_population \u003d False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# (BoolOpt) Flag to disable local ARP responder which provides local responses "},{"line_number":44,"context_line":"# instead of performing ARP broadcast into the overlay. Enabling local ARP "},{"line_number":45,"context_line":"# responder is not fully compatible with the allowed-address-pairs extension."},{"line_number":46,"context_line":"# arp_responder \u003d True"}],"source_content_type":"text/x-properties","patch_set":6,"id":"ba0121b8_7d70640b","line":43,"updated":"2016-04-01 13:24:30.000000000","message":"red thingies...","commit_id":"03948a77d16c5205141219597015a6a4b3a43d69"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6274cff63bea65fe1e2bdfe8cb6bc170f1168b53","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":42,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":43,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027arp_responder\u0027, default\u003dTrue,"},{"line_number":45,"context_line":"                help\u003d_(\"Enable local ARP responder which provides local \""},{"line_number":46,"context_line":"                       \"responses instead of performing ARP broadcast into \""},{"line_number":47,"context_line":"                       \"the overlay. Enabling local ARP responder is not fully\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_c129e7e7","line":44,"updated":"2016-03-10 15:26:27.000000000","message":"You should also manually update linuxbridge agent config file to include the option since we don\u0027t have config generator in Liberty.","commit_id":"b850f4e21f471a396d105853b3fc73c90c63a646"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e8ba570693dbcc1432d8717b136006c59c2fbf9d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":42,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":43,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027arp_responder\u0027, default\u003dTrue,"},{"line_number":45,"context_line":"                help\u003d_(\"Enable local ARP responder which provides local \""},{"line_number":46,"context_line":"                       \"responses instead of performing ARP broadcast into \""},{"line_number":47,"context_line":"                       \"the overlay. Enabling local ARP responder is not fully\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_6e541254","line":44,"in_reply_to":"5aef4532_c129e7e7","updated":"2016-03-15 15:22:28.000000000","message":"Done","commit_id":"b850f4e21f471a396d105853b3fc73c90c63a646"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"593c65dfe946810035131f010e4daf02bd7a7a90","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":42,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":43,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027arp_responder\u0027, default\u003dFalse,"},{"line_number":45,"context_line":"                help\u003d_(\"Enable local ARP responder which provides local \""},{"line_number":46,"context_line":"                       \"responses instead of performing ARP broadcast into \""},{"line_number":47,"context_line":"                       \"the overlay. Enabling local ARP responder is not fully\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_839736eb","line":44,"updated":"2016-03-30 21:44:42.000000000","message":"Defaults now to False whereas previously it was True?","commit_id":"d231a478e40d06c1ed37625dc4033087a229b42f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ced7e22bb90b5c0eaeba8b29cd87d6f8a97a5a32","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":42,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":43,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027arp_responder\u0027, default\u003dFalse,"},{"line_number":45,"context_line":"                help\u003d_(\"Enable local ARP responder which provides local \""},{"line_number":46,"context_line":"                       \"responses instead of performing ARP broadcast into \""},{"line_number":47,"context_line":"                       \"the overlay. Enabling local ARP responder is not fully\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_c7d48c21","line":44,"in_reply_to":"ba0121b8_839736eb","updated":"2016-03-31 06:46:37.000000000","message":"Done","commit_id":"d231a478e40d06c1ed37625dc4033087a229b42f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"d2fedceb81e3f4774a5c9b4f4941925b7bd4dec0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                help\u003d_(\"Extension to use alongside ml2 plugin\u0027s l2population \""},{"line_number":42,"context_line":"                       \"mechanism driver. It enables the plugin to populate \""},{"line_number":43,"context_line":"                       \"VXLAN forwarding table.\")),"},{"line_number":44,"context_line":"    cfg.BoolOpt(\u0027arp_responder\u0027, default\u003dFalse,"},{"line_number":45,"context_line":"                help\u003d_(\"Enable local ARP responder which provides local \""},{"line_number":46,"context_line":"                       \"responses instead of performing ARP broadcast into \""},{"line_number":47,"context_line":"                       \"the overlay. Enabling local ARP responder is not fully\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_473cfcc7","line":44,"in_reply_to":"ba0121b8_839736eb","updated":"2016-03-31 06:37:42.000000000","message":"You are correct this should be False. Its my mistake, it would seem in the course of PS2/3 it was set back to False. I will update this change set now.","commit_id":"d231a478e40d06c1ed37625dc4033087a229b42f"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"593c65dfe946810035131f010e4daf02bd7a7a90","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            if cfg.CONF.VXLAN.tos:"},{"line_number":321,"context_line":"                args[\u0027tos\u0027] \u003d cfg.CONF.VXLAN.tos"},{"line_number":322,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":323,"context_line":"                args[\u0027proxy\u0027] \u003d True"},{"line_number":324,"context_line":"            try:"},{"line_number":325,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"},{"line_number":326,"context_line":"                                              **args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_e301d239","side":"PARENT","line":323,"updated":"2016-03-30 21:44:42.000000000","message":"So this was True all the time in the past and will now default to False?","commit_id":"a0fed179c3af77e4db7806b21a7f1b249d86adf5"},{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"b7b31e7e47f81bb366925e91405879a0c30b2fd8","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            if cfg.CONF.VXLAN.tos:"},{"line_number":321,"context_line":"                args[\u0027tos\u0027] \u003d cfg.CONF.VXLAN.tos"},{"line_number":322,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":323,"context_line":"                args[\u0027proxy\u0027] \u003d cfg.CONF.VXLAN.arp_responder"},{"line_number":324,"context_line":"            try:"},{"line_number":325,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"},{"line_number":326,"context_line":"                                              **args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_43c365ed","line":323,"updated":"2016-03-30 18:51:14.000000000","message":"Since the default is False, but the previous code was True, would it be better to make the default True?","commit_id":"d231a478e40d06c1ed37625dc4033087a229b42f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"ced7e22bb90b5c0eaeba8b29cd87d6f8a97a5a32","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            if cfg.CONF.VXLAN.tos:"},{"line_number":321,"context_line":"                args[\u0027tos\u0027] \u003d cfg.CONF.VXLAN.tos"},{"line_number":322,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":323,"context_line":"                args[\u0027proxy\u0027] \u003d cfg.CONF.VXLAN.arp_responder"},{"line_number":324,"context_line":"            try:"},{"line_number":325,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"},{"line_number":326,"context_line":"                                              **args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_a7d99859","line":323,"in_reply_to":"ba0121b8_43c365ed","updated":"2016-03-31 06:46:37.000000000","message":"Done","commit_id":"d231a478e40d06c1ed37625dc4033087a229b42f"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"18b2f55c02195cc04c5e43b43095d56d37a2b2ab","unresolved":false,"context_lines":[{"line_number":320,"context_line":"            if cfg.CONF.VXLAN.tos:"},{"line_number":321,"context_line":"                args[\u0027tos\u0027] \u003d cfg.CONF.VXLAN.tos"},{"line_number":322,"context_line":"            if cfg.CONF.VXLAN.l2_population:"},{"line_number":323,"context_line":"                args[\u0027proxy\u0027] \u003d cfg.CONF.VXLAN.arp_responder"},{"line_number":324,"context_line":"            try:"},{"line_number":325,"context_line":"                int_vxlan \u003d self.ip.add_vxlan(interface, segmentation_id,"},{"line_number":326,"context_line":"                                              **args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_07c844a7","line":323,"in_reply_to":"ba0121b8_43c365ed","updated":"2016-03-31 06:43:54.000000000","message":"Yes it would be better to set this to True due to this being a backport, I was mistaken in my previous comment.","commit_id":"d231a478e40d06c1ed37625dc4033087a229b42f"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b73032d2a85d2db557e5c61e4a3ff7ec86d6c6e5","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                                                dev\u003dself.lbm.local_int,"},{"line_number":763,"context_line":"                                                proxy\u003dexpected_proxy)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def test_ensure_vxlan_arp_responder_enabled(self):"},{"line_number":766,"context_line":"        cfg.CONF.set_override(\u0027arp_responder\u0027, True, \u0027VXLAN\u0027)"},{"line_number":767,"context_line":"        self.test_ensure_vxlan(expected_proxy\u003dTrue)"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_f908c92a","line":765,"range":{"start_line":765,"start_character":8,"end_line":765,"end_character":47},"updated":"2016-03-07 06:37:28.000000000","message":"need to invert these two tests now that the default is different","commit_id":"b850f4e21f471a396d105853b3fc73c90c63a646"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e8ba570693dbcc1432d8717b136006c59c2fbf9d","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                                                dev\u003dself.lbm.local_int,"},{"line_number":763,"context_line":"                                                proxy\u003dexpected_proxy)"},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"    def test_ensure_vxlan_arp_responder_enabled(self):"},{"line_number":766,"context_line":"        cfg.CONF.set_override(\u0027arp_responder\u0027, True, \u0027VXLAN\u0027)"},{"line_number":767,"context_line":"        self.test_ensure_vxlan(expected_proxy\u003dTrue)"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1af94dfe_ee5f8273","line":765,"range":{"start_line":765,"start_character":8,"end_line":765,"end_character":47},"in_reply_to":"7af24918_f908c92a","updated":"2016-03-15 15:22:28.000000000","message":"Done.  I\u0027ve added a disabled test and flipped the \"test_ensure_vxlan\" methods default.","commit_id":"b850f4e21f471a396d105853b3fc73c90c63a646"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"88e529877ec0c42bc35cc32a0521ce6028cd6a07","unresolved":false,"context_lines":[{"line_number":738,"context_line":"                self.assertIsNone(self.lbm.ensure_vlan(\"eth0\", \"1\"))"},{"line_number":739,"context_line":"                self.assertEqual(exec_fn.call_count, 3)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    def test_ensure_vxlan(self, expected_proxy\u003dTrue):"},{"line_number":742,"context_line":"        seg_id \u003d \"12345678\""},{"line_number":743,"context_line":"        self.lbm.local_int \u003d \u0027eth0\u0027"},{"line_number":744,"context_line":"        self.lbm.vxlan_mode \u003d lconst.VXLAN_MCAST"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_40cde583","line":741,"updated":"2016-03-24 00:38:47.000000000","message":"set to:\n\nexpected_proxy\u003dFalse\n\nand gtg as this test will run independent of the others first, and the default is now False.","commit_id":"566180dfe482ff9e222f2883788f9723173cbfde"}],"releasenotes/notes/linuxbridge_vxlan_arp_responder-e9ea91552e1b62a7.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c7a879e9851ff142ad8354a033ce4d9618c5198b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"    The Linuxbridge agent now supports the ability to toggle the local ARP"},{"line_number":4,"context_line":"    responder when L2Population is enabled. This ensures compatibility with"},{"line_number":5,"context_line":"    the allowed-address-pairs extension."},{"line_number":6,"context_line":"  - closes bug 1445089"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba0121b8_30ec2e8f","line":5,"range":{"start_line":4,"start_character":44,"end_line":5,"end_character":40},"updated":"2016-04-02 15:01:50.000000000","message":"I am not sure this description is appropriate because we need to change the config value to False to make the allowed-address-pair extension work.","commit_id":"c823e8ccb951a4abdf247dd094a794b7741d7cca"}]}
