)]}'
{"quantum/tests/unit/midonet/test_midonet_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"57b275bfa23be4c02da6262718cbd0c761bd7114","unresolved":false,"context_lines":[{"line_number":399,"context_line":"              self).test_update_subnet_shared_returns_400()"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":402,"context_line":"        pass"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_update_subnet_inconsistent_ipv4_gatewayv6(self):"},{"line_number":405,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FVLs%3D","line":402,"updated":"2013-05-14 13:26:26.000000000","message":"I see here you\u0027re just doing the same as other tests, so this is no reason for holding this patch.\n\nDid you figured out why we need to do this? and if yes, what we should to avoid this which is tantamount to skipping the test (and indeed it should be a test skip rather than a pass which will cause the test to succeed)","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"54b05e7aa1eb9cab327e080884a87d9665e017ab","unresolved":false,"context_lines":[{"line_number":399,"context_line":"              self).test_update_subnet_shared_returns_400()"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":402,"context_line":"        pass"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_update_subnet_inconsistent_ipv4_gatewayv6(self):"},{"line_number":405,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FUtk%3D","line":402,"in_reply_to":"AAAAOn%2F%2FU1A%3D","updated":"2013-05-14 17:58:01.000000000","message":"So can leave this as is then, right?","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":399,"context_line":"              self).test_update_subnet_shared_returns_400()"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":402,"context_line":"        pass"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_update_subnet_inconsistent_ipv4_gatewayv6(self):"},{"line_number":405,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FU1A%3D","line":402,"in_reply_to":"AAAAOn%2F%2FU3M%3D","updated":"2013-05-14 16:27:52.000000000","message":"thanks, I did not see that patch.","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":399,"context_line":"              self).test_update_subnet_shared_returns_400()"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":402,"context_line":"        pass"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_update_subnet_inconsistent_ipv4_gatewayv6(self):"},{"line_number":405,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FUY4%3D","line":402,"in_reply_to":"AAAAOn%2F%2FUtk%3D","updated":"2013-05-14 20:15:50.000000000","message":"yes","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"44a34ca628a24d1e998aa6194723439be93d5fa4","unresolved":false,"context_lines":[{"line_number":399,"context_line":"              self).test_update_subnet_shared_returns_400()"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":402,"context_line":"        pass"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_update_subnet_inconsistent_ipv4_gatewayv6(self):"},{"line_number":405,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FU3M%3D","line":402,"in_reply_to":"AAAAOn%2F%2FVLs%3D","updated":"2013-05-14 16:04:26.000000000","message":"Looks like this is addressed here:\n\nhttps://review.openstack.org/#/c/23378/3","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"}],"quantum/tests/unit/test_db_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"57b275bfa23be4c02da6262718cbd0c761bd7114","unresolved":false,"context_lines":[{"line_number":2696,"context_line":"                                network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2697,"context_line":"                                \u002710.0.0.0/24\u0027,"},{"line_number":2698,"context_line":"                                400,"},{"line_number":2699,"context_line":"                                gateway_ip\u003d\u002710.0.0.0\u0027)"},{"line_number":2700,"context_line":"            self._create_subnet(self.fmt,"},{"line_number":2701,"context_line":"                                network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2702,"context_line":"                                \u002710.0.0.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FVLk%3D","line":2699,"updated":"2013-05-14 13:26:26.000000000","message":"This test would also fail because the cidr is the same as the one previously created.\n\nEven with overlapping IPs, subnets on the same network must have distinct CIDRs.\n\nI think a simple change in the CIDRs for the 2nd and 3rd subnets would do the trick.","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":2696,"context_line":"                                network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2697,"context_line":"                                \u002710.0.0.0/24\u0027,"},{"line_number":2698,"context_line":"                                400,"},{"line_number":2699,"context_line":"                                gateway_ip\u003d\u002710.0.0.0\u0027)"},{"line_number":2700,"context_line":"            self._create_subnet(self.fmt,"},{"line_number":2701,"context_line":"                                network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2702,"context_line":"                                \u002710.0.0.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FUYo%3D","line":2699,"in_reply_to":"AAAAOn%2F%2FUus%3D","updated":"2013-05-14 20:15:50.000000000","message":"I think we should split this into 3 separate tests.  The test method name will then give a hint of what is being tested otherwise those who follow may understand what is being tested here.","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"54b05e7aa1eb9cab327e080884a87d9665e017ab","unresolved":false,"context_lines":[{"line_number":2696,"context_line":"                                network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2697,"context_line":"                                \u002710.0.0.0/24\u0027,"},{"line_number":2698,"context_line":"                                400,"},{"line_number":2699,"context_line":"                                gateway_ip\u003d\u002710.0.0.0\u0027)"},{"line_number":2700,"context_line":"            self._create_subnet(self.fmt,"},{"line_number":2701,"context_line":"                                network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2702,"context_line":"                                \u002710.0.0.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FUus%3D","line":2699,"in_reply_to":"AAAAOn%2F%2FVLk%3D","updated":"2013-05-14 17:58:01.000000000","message":"These three examples are supposed to all be failure cases (should I rename this to test_create_fails_gw_bad_when_forced or something?).\n\nFirst (existing) is with gw outside of subnet. The two I added are when gw matches BCAST or subnet (as that is what is tested in the code).\n\nDoes that sound OK, or am I missing something more?","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"57b275bfa23be4c02da6262718cbd0c761bd7114","unresolved":false,"context_lines":[{"line_number":2967,"context_line":"                res \u003d req.get_response(self.api)"},{"line_number":2968,"context_line":"                self.assertEqual(res.status_int, 400)"},{"line_number":2969,"context_line":""},{"line_number":2970,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":2971,"context_line":"        cfg.CONF.set_override(\u0027force_gateway_on_subnet\u0027, True)"},{"line_number":2972,"context_line":"        with self.network() as network:"},{"line_number":2973,"context_line":"            with self.subnet(network\u003dnetwork) as subnet:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FVLg%3D","line":2970,"updated":"2013-05-14 13:26:26.000000000","message":"as this is a negative tests perhaps rename it to\ntest_update_subnet_gw_outside_cidr_for_on_returns_400\n\nI know it\u0027s very long, but that would be consistent with the style of other unit tests.","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"44a34ca628a24d1e998aa6194723439be93d5fa4","unresolved":false,"context_lines":[{"line_number":2967,"context_line":"                res \u003d req.get_response(self.api)"},{"line_number":2968,"context_line":"                self.assertEqual(res.status_int, 400)"},{"line_number":2969,"context_line":""},{"line_number":2970,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":2971,"context_line":"        cfg.CONF.set_override(\u0027force_gateway_on_subnet\u0027, True)"},{"line_number":2972,"context_line":"        with self.network() as network:"},{"line_number":2973,"context_line":"            with self.subnet(network\u003dnetwork) as subnet:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FU3I%3D","line":2970,"in_reply_to":"AAAAOn%2F%2FVLg%3D","updated":"2013-05-14 16:04:26.000000000","message":"+1","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"54b05e7aa1eb9cab327e080884a87d9665e017ab","unresolved":false,"context_lines":[{"line_number":2967,"context_line":"                res \u003d req.get_response(self.api)"},{"line_number":2968,"context_line":"                self.assertEqual(res.status_int, 400)"},{"line_number":2969,"context_line":""},{"line_number":2970,"context_line":"    def test_update_subnet_gw_outside_when_force_on(self):"},{"line_number":2971,"context_line":"        cfg.CONF.set_override(\u0027force_gateway_on_subnet\u0027, True)"},{"line_number":2972,"context_line":"        with self.network() as network:"},{"line_number":2973,"context_line":"            with self.subnet(network\u003dnetwork) as subnet:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FUuk%3D","line":2970,"in_reply_to":"AAAAOn%2F%2FVLg%3D","updated":"2013-05-14 17:58:01.000000000","message":"Done","commit_id":"fb09d278e8f0a321017a3338387a3fa2bceeb7a8"}]}