)]}'
{"neutron/common/exceptions.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"888b8120143b1edde2984a16439f7da3bdc63683","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class SubnetsNotAllAssociatedWithSegments(e.BadRequest):"},{"line_number":333,"context_line":"    message \u003d _(\"If any subnet on a network is associated with a segment, \""},{"line_number":334,"context_line":"                \"they all must be associated with segments.\")"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"class SubnetCantAssociateToDynamicSegment(e.BadRequest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_6b55211c","line":334,"updated":"2016-04-11 05:14:11.000000000","message":"dont know what , but the framing of the statement here seems to miss something, specially the class name.\n\n\nCan you also make  \"they all must\"  to \" then all subnets on the network must\" just to give the statement a bit more volume?","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"882bc814183cb7483143520b396497701018fad1","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class SubnetsNotAllAssociatedWithSegments(e.BadRequest):"},{"line_number":333,"context_line":"    message \u003d _(\"If any subnet on a network is associated with a segment, \""},{"line_number":334,"context_line":"                \"they all must be associated with segments.\")"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"class SubnetCantAssociateToDynamicSegment(e.BadRequest):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_6ef4b385","line":334,"in_reply_to":"7a1b2928_6b55211c","updated":"2016-04-20 20:02:12.000000000","message":"I\u0027m not really sure what to make of this.  What class name is missing?","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"521d0cab97601f7843f3940c0a80e108b5b60b7e","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class SubnetsNotAllAssociatedWithSegments(e.BadRequest):"},{"line_number":333,"context_line":"    message \u003d _(\"If any subnet on a network is associated with a segment, \""},{"line_number":334,"context_line":"                \"they all must be associated with segments.\")"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"class SubnetCantAssociateToDynamicSegment(e.BadRequest):"},{"line_number":338,"context_line":"    message \u003d _(\"A subnet cannot be associated with a dynamic segment.\")"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"class NetworkIdsDontMatch(e.BadRequest):"},{"line_number":342,"context_line":"    message \u003d _(\"A subnet cannot be associated with a segment from a \""},{"line_number":343,"context_line":"                \"different network.\")"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"class ObjectActionError(e.NeutronException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_c42d96a9","line":343,"range":{"start_line":333,"start_character":0,"end_line":343,"end_character":37},"updated":"2016-04-07 05:04:04.000000000","message":"It will be easier to debug, if add some details to the error message. For example, which subnet, which segement.","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"882bc814183cb7483143520b396497701018fad1","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class SubnetsNotAllAssociatedWithSegments(e.BadRequest):"},{"line_number":333,"context_line":"    message \u003d _(\"If any subnet on a network is associated with a segment, \""},{"line_number":334,"context_line":"                \"they all must be associated with segments.\")"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"class SubnetCantAssociateToDynamicSegment(e.BadRequest):"},{"line_number":338,"context_line":"    message \u003d _(\"A subnet cannot be associated with a dynamic segment.\")"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"class NetworkIdsDontMatch(e.BadRequest):"},{"line_number":342,"context_line":"    message \u003d _(\"A subnet cannot be associated with a segment from a \""},{"line_number":343,"context_line":"                \"different network.\")"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"class ObjectActionError(e.NeutronException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_4e4617c0","line":343,"range":{"start_line":333,"start_character":0,"end_line":343,"end_character":37},"in_reply_to":"7a1b2928_2b2209ba","updated":"2016-04-20 20:02:12.000000000","message":"The subnet doesn\u0027t have an id because it hasn\u0027t been created yet.  But, I could add some details about the network and segment.","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"888b8120143b1edde2984a16439f7da3bdc63683","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class SubnetsNotAllAssociatedWithSegments(e.BadRequest):"},{"line_number":333,"context_line":"    message \u003d _(\"If any subnet on a network is associated with a segment, \""},{"line_number":334,"context_line":"                \"they all must be associated with segments.\")"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"class SubnetCantAssociateToDynamicSegment(e.BadRequest):"},{"line_number":338,"context_line":"    message \u003d _(\"A subnet cannot be associated with a dynamic segment.\")"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"class NetworkIdsDontMatch(e.BadRequest):"},{"line_number":342,"context_line":"    message \u003d _(\"A subnet cannot be associated with a segment from a \""},{"line_number":343,"context_line":"                \"different network.\")"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"class ObjectActionError(e.NeutronException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_2b2209ba","line":343,"range":{"start_line":333,"start_character":0,"end_line":343,"end_character":37},"in_reply_to":"9a061dce_c42d96a9","updated":"2016-04-11 05:14:11.000000000","message":"+1","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93effbc5449d187ce0fb4d6c4a5d8a2fce0e94cb","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                \"the same subnet pool.\")"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"class SubnetsNotAllAssociatedWithSegments(e.BadRequest):"},{"line_number":329,"context_line":"    message \u003d _(\"All of the subnets on network \u0027%(network_id)s\u0027 must either \""},{"line_number":330,"context_line":"                \"all be associated with segments or all not associated with \""},{"line_number":331,"context_line":"                \"any segment.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_4c37d14c","line":328,"range":{"start_line":328,"start_character":6,"end_line":328,"end_character":41},"updated":"2016-04-20 17:07:59.000000000","message":"Move these to neutron/services/segments/exceptions.py","commit_id":"3596747faf862fb67b1381cd95f2290e6065e517"}],"neutron/db/common_db_mixin.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"888b8120143b1edde2984a16439f7da3bdc63683","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                # See \"An Important Expression Language Gotcha\" in:"},{"line_number":207,"context_line":"                # docs.sqlalchemy.org/en/rel_0_9/changelog/migration_06.html"},{"line_number":208,"context_line":"                if column is not None:"},{"line_number":209,"context_line":"                    if value is not None and not value:"},{"line_number":210,"context_line":"                        query \u003d query.filter(sql.false())"},{"line_number":211,"context_line":"                        return query"},{"line_number":212,"context_line":"                    if isinstance(column, associationproxy.AssociationProxy):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_4b0ca542","line":209,"updated":"2016-04-11 05:14:11.000000000","message":"Doesnt the previous statement ( if not value) cover the above conditions?","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"882bc814183cb7483143520b396497701018fad1","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                # See \"An Important Expression Language Gotcha\" in:"},{"line_number":207,"context_line":"                # docs.sqlalchemy.org/en/rel_0_9/changelog/migration_06.html"},{"line_number":208,"context_line":"                if column is not None:"},{"line_number":209,"context_line":"                    if value is not None and not value:"},{"line_number":210,"context_line":"                        query \u003d query.filter(sql.false())"},{"line_number":211,"context_line":"                        return query"},{"line_number":212,"context_line":"                    if isinstance(column, associationproxy.AssociationProxy):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_6e6e7396","line":209,"in_reply_to":"7a1b2928_4b0ca542","updated":"2016-04-20 20:02:12.000000000","message":"This is essentially reducing this check to only catch empty containers.  Maybe I\u0027ll change this to:\n\n  is_empty_container \u003d value is not None and not value\n  if is_empty_container:\n\nConsider the case where value is None.  This check will be False:\n\n  \"None is not None and not value\" is False.  But, \"not None\" is True.  So, it will fall through to L218 where","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a7607b46c97b530de9acca00f9ab0f88d463ed63","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                # See \"An Important Expression Language Gotcha\" in:"},{"line_number":207,"context_line":"                # docs.sqlalchemy.org/en/rel_0_9/changelog/migration_06.html"},{"line_number":208,"context_line":"                if column is not None:"},{"line_number":209,"context_line":"                    is_empty_sequence \u003d value is not None and not value"},{"line_number":210,"context_line":"                    if is_empty_sequence:"},{"line_number":211,"context_line":"                        query \u003d query.filter(sql.false())"},{"line_number":212,"context_line":"                        return query"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_86c34f57","line":209,"range":{"start_line":209,"start_character":40,"end_line":209,"end_character":71},"updated":"2016-05-01 06:19:08.000000000","message":"doesn\u0027t just \"not value\" suffice?","commit_id":"799e90605bc710275212772f6aa5a610713a6530"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"b3ec26239e96549385194f4b452442ba656807e9","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                # See \"An Important Expression Language Gotcha\" in:"},{"line_number":207,"context_line":"                # docs.sqlalchemy.org/en/rel_0_9/changelog/migration_06.html"},{"line_number":208,"context_line":"                if column is not None:"},{"line_number":209,"context_line":"                    is_empty_sequence \u003d value is not None and not value"},{"line_number":210,"context_line":"                    if is_empty_sequence:"},{"line_number":211,"context_line":"                        query \u003d query.filter(sql.false())"},{"line_number":212,"context_line":"                        return query"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_cbd6d9c2","line":209,"range":{"start_line":209,"start_character":40,"end_line":209,"end_character":71},"in_reply_to":"1a122d0e_6bfd0508","updated":"2016-05-02 18:55:17.000000000","message":"Sorry missed the previous comment on this.  I swear I stared at this line for a few minutes trying to think of that same scenario and i think my brain just left out the \"not\" in the \"value is not None\".","commit_id":"799e90605bc710275212772f6aa5a610713a6530"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0fffa61d327b54a2761a0bf43ab88344d5ee46f6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                # See \"An Important Expression Language Gotcha\" in:"},{"line_number":207,"context_line":"                # docs.sqlalchemy.org/en/rel_0_9/changelog/migration_06.html"},{"line_number":208,"context_line":"                if column is not None:"},{"line_number":209,"context_line":"                    is_empty_sequence \u003d value is not None and not value"},{"line_number":210,"context_line":"                    if is_empty_sequence:"},{"line_number":211,"context_line":"                        query \u003d query.filter(sql.false())"},{"line_number":212,"context_line":"                        return query"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_6bfd0508","line":209,"range":{"start_line":209,"start_character":40,"end_line":209,"end_character":71},"in_reply_to":"1a122d0e_86c34f57","updated":"2016-05-02 18:36:53.000000000","message":"Same question was asked on PS3.\n\nConsider how this boolean evaluates if value is None.\n\n  value is not None and not value \u003d\u003e False\n  not value \u003d\u003e True\n\nIf value is None, I don\u0027t want to take this branch.  I want to fall through to L219 which couldn\u0027t happen with the return on L212.","commit_id":"799e90605bc710275212772f6aa5a610713a6530"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"517ac760b9a89dfd91f42816e761098bbfb219c9","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                # See \"An Important Expression Language Gotcha\" in:"},{"line_number":208,"context_line":"                # docs.sqlalchemy.org/en/rel_0_9/changelog/migration_06.html"},{"line_number":209,"context_line":"                if column is not None:"},{"line_number":210,"context_line":"                    is_empty_sequence \u003d value is not None and not value"},{"line_number":211,"context_line":"                    if is_empty_sequence:"},{"line_number":212,"context_line":"                        query \u003d query.filter(sql.false())"},{"line_number":213,"context_line":"                        return query"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_36eee222","line":210,"range":{"start_line":210,"start_character":20,"end_line":210,"end_character":37},"updated":"2016-05-06 14:45:59.000000000","message":"In future patches, I\u0027m going to have to do more complex things such as searching for subnets with segment_id \u003d \u0027xyz\u0027 *or* None.  This change won\u0027t allow that and I don\u0027t want to do it in two queries.  I\u0027m thinking of backing this out and changing the way I query for subnets in ipam.","commit_id":"b125364e5267fbe0e35008f1bc84f0495adc6062"}],"neutron/db/db_base_plugin_common.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93effbc5449d187ce0fb4d6c4a5d8a2fce0e94cb","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                args[\u0027ipv6_ra_mode\u0027] \u003d subnet[\u0027ipv6_ra_mode\u0027]"},{"line_number":313,"context_line":"            if attributes.is_attr_set(subnet[\u0027ipv6_address_mode\u0027]):"},{"line_number":314,"context_line":"                args[\u0027ipv6_address_mode\u0027] \u003d subnet[\u0027ipv6_address_mode\u0027]"},{"line_number":315,"context_line":"        # FIXME Is there a way to accomplish this without modifying this code?"},{"line_number":316,"context_line":"        if attributes.is_attr_set(subnet.get(segment.SEGMENT_ID)):"},{"line_number":317,"context_line":"            args[\u0027segment_id\u0027] \u003d subnet[segment.SEGMENT_ID]"},{"line_number":318,"context_line":"        return args"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_ccdf61d4","line":315,"range":{"start_line":315,"start_character":10,"end_line":315,"end_character":15},"updated":"2016-04-20 17:07:59.000000000","message":"Figure this out.","commit_id":"3596747faf862fb67b1381cd95f2290e6065e517"}],"neutron/db/ipam_backend_mixin.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"521d0cab97601f7843f3940c0a80e108b5b60b7e","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        subnet \u003d models_v2.Subnet(**subnet_args)"},{"line_number":458,"context_line":"        context.session.add(subnet)"},{"line_number":459,"context_line":"        self._validate_segment(context,"},{"line_number":460,"context_line":"                               network[\u0027id\u0027],"},{"line_number":461,"context_line":"                               subnet_args.get(\u0027segment_id\u0027))"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # NOTE(changzhi) Store DNS nameservers with order into DB one"},{"line_number":464,"context_line":"        # by one when create subnet with DNS nameservers"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_2f7f0b67","line":461,"range":{"start_line":459,"start_character":0,"end_line":461,"end_character":61},"updated":"2016-04-07 05:04:04.000000000","message":"Should we move this validate before adding data in DB?","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"882bc814183cb7483143520b396497701018fad1","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        subnet \u003d models_v2.Subnet(**subnet_args)"},{"line_number":458,"context_line":"        context.session.add(subnet)"},{"line_number":459,"context_line":"        self._validate_segment(context,"},{"line_number":460,"context_line":"                               network[\u0027id\u0027],"},{"line_number":461,"context_line":"                               subnet_args.get(\u0027segment_id\u0027))"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # NOTE(changzhi) Store DNS nameservers with order into DB one"},{"line_number":464,"context_line":"        # by one when create subnet with DNS nameservers"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_6e1cb312","line":461,"range":{"start_line":459,"start_character":0,"end_line":461,"end_character":61},"in_reply_to":"9a061dce_2f7f0b67","updated":"2016-04-20 20:02:12.000000000","message":"Not unless we change how the validation works.  I thought it was more natural to insert the new subnet and then have the validation check them all together in the DB instead of trying to validate one subnet that hasn\u0027t been inserted in to the DB with others which have.\n\nif the validation fails then the whole thing gets reverted and we\u0027ve just paid for one extra insert call within the transaction.  To me, that isn\u0027t too much to pay for straight-forward validation.","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"521096869fd10897c51fdba4e6bec317c16c38a5","unresolved":false,"context_lines":[{"line_number":312,"context_line":"    def _validate_segment(self, context, network_id, segment_id):"},{"line_number":313,"context_line":"        query \u003d context.session.query(models_v2.Subnet.segment_id)"},{"line_number":314,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":315,"context_line":"        associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":316,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":317,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("},{"line_number":318,"context_line":"                network_id\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_dfc7fc93","line":315,"range":{"start_line":315,"start_character":34,"end_line":315,"end_character":48},"updated":"2016-04-20 18:55:36.000000000","message":"This reference ends up raising a db_exc.DBReferenceError if the subnet just inserted (within the on-going transaction) refers to a segment that doesn\u0027t exist.  It seems to be because the foreign constraint check is deferred to this point.  I\u0027ll see if I can write a unit test for it.","commit_id":"7e91d8253654ef6d44abea578427180008a10cb6"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"05a3c9d671447d14225e3d4da4b6f18640032c38","unresolved":false,"context_lines":[{"line_number":312,"context_line":"    def _validate_segment(self, context, network_id, segment_id):"},{"line_number":313,"context_line":"        query \u003d context.session.query(models_v2.Subnet.segment_id)"},{"line_number":314,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":315,"context_line":"        associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":316,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":317,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("},{"line_number":318,"context_line":"                network_id\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_d5debddb","line":315,"range":{"start_line":315,"start_character":34,"end_line":315,"end_character":48},"in_reply_to":"1a122d0e_dfc7fc93","updated":"2016-04-20 19:57:03.000000000","message":"Done","commit_id":"7e91d8253654ef6d44abea578427180008a10cb6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"98653ef0a0c65a368f967ec5693c92d7f91aeffe","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            msg \u003d _(\u0027Exceeded maximum amount of fixed ips per port.\u0027)"},{"line_number":313,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _validate_segment(self, context, network_id, segment_id):"},{"line_number":316,"context_line":"        query \u003d context.session.query(models_v2.Subnet.segment_id)"},{"line_number":317,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":318,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_6496abf1","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":25},"updated":"2016-05-09 17:07:17.000000000","message":"This function should be also tested","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93512b48874bed1b32406c6eff2455858505e796","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            msg \u003d _(\u0027Exceeded maximum amount of fixed ips per port.\u0027)"},{"line_number":313,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _validate_segment(self, context, network_id, segment_id):"},{"line_number":316,"context_line":"        query \u003d context.session.query(models_v2.Subnet.segment_id)"},{"line_number":317,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":318,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_b39f364f","line":315,"range":{"start_line":315,"start_character":8,"end_line":315,"end_character":25},"in_reply_to":"dab17558_6496abf1","updated":"2016-05-09 20:19:57.000000000","message":"This method is pretty well covered here [1].\n\n  [1] https://review.openstack.org/#/c/288774/15/neutron/tests/unit/extensions/test_segment.py","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"500098b5ccd65705a838f1d86b6bd4bdcc7260f8","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                fixed_ip_list.append({\u0027subnet_id\u0027: subnet[\u0027id\u0027]})"},{"line_number":534,"context_line":"        return fixed_ip_list"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def _ipam_get_subnets(self, context, network_id, segment_id):"},{"line_number":537,"context_line":"        make_subnet_dict \u003d functools.partial(self._make_subnet_dict,"},{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_24f303d8","line":536,"updated":"2016-05-09 16:57:12.000000000","message":"\"segment_id\" value is not used","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93512b48874bed1b32406c6eff2455858505e796","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                fixed_ip_list.append({\u0027subnet_id\u0027: subnet[\u0027id\u0027]})"},{"line_number":534,"context_line":"        return fixed_ip_list"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def _ipam_get_subnets(self, context, network_id, segment_id):"},{"line_number":537,"context_line":"        make_subnet_dict \u003d functools.partial(self._make_subnet_dict,"},{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_f316deef","line":536,"in_reply_to":"dab17558_24f303d8","updated":"2016-05-09 20:19:57.000000000","message":"I could remove it but one of my next patches is just going to add it right back.  This patch is an enabler for more segment-aware IPAM.","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"611bbbb42bb08db2988173b16d81151df9b2f06b","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":541,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id.is_(None))"},{"line_number":542,"context_line":"        subnets \u003d [make_subnet_dict(c, None) for c in query]"},{"line_number":543,"context_line":"        return subnets"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_932152a2","line":541,"updated":"2016-05-09 19:34:55.000000000","message":"Did you mean to do this only when segment_id is None? Seems like this should check for segment_id \u003d None and if so do what this does and if not actually filter by Subnet.segment_id \u003d\u003d segment_id.","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"42e4be5b7be9c86f8b151463a59b8dc1d3332a04","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":541,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id.is_(None))"},{"line_number":542,"context_line":"        subnets \u003d [make_subnet_dict(c, None) for c in query]"},{"line_number":543,"context_line":"        return subnets"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_96b78085","line":541,"in_reply_to":"dab17558_56619838","updated":"2016-05-09 20:21:15.000000000","message":"[1] http://docs.sqlalchemy.org/en/latest/core/sqlelement.html#sqlalchemy.sql.expression.ColumnElement.is_","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93512b48874bed1b32406c6eff2455858505e796","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":541,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id.is_(None))"},{"line_number":542,"context_line":"        subnets \u003d [make_subnet_dict(c, None) for c in query]"},{"line_number":543,"context_line":"        return subnets"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_56619838","line":541,"in_reply_to":"dab17558_932152a2","updated":"2016-05-09 20:19:57.000000000","message":"That\u0027s a good observation.  I\u0027m glad you\u0027re understanding this well.\n\nActually, it is going to be a little more complicated because even if a segment_id is provided, we\u0027ve got to fall back to subnets without segments for backward compatibility.  I was hoping to work this out in a follow on to make IPAM full segment aware.\n\nI just noticed that I can use a regular comparison here and sqlalchemy will generate IS NULL if segment_id is None [1].  Pretty cool.  I\u0027ll change it. I also noticed that this little detail is not covered by UTs.","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a9896411437b08d5e675222e1789f47edaff7773","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":541,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id.is_(None))"},{"line_number":542,"context_line":"        subnets \u003d [make_subnet_dict(c, None) for c in query]"},{"line_number":543,"context_line":"        return subnets"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_f95ebd10","line":541,"in_reply_to":"dab17558_96b78085","updated":"2016-05-09 20:48:21.000000000","message":"I actually already had the UT I need to test this written in my newer patch.  I\u0027ll just put it in here since this makes it relevant for this patch.","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"92abde72565ba3147eda8df0039b37778a8cd1b9","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":541,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id.is_(None))"},{"line_number":542,"context_line":"        subnets \u003d [make_subnet_dict(c, None) for c in query]"},{"line_number":543,"context_line":"        return subnets"},{"line_number":544,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"dab17558_3c2af37e","line":541,"range":{"start_line":541,"start_character":56,"end_line":541,"end_character":66},"updated":"2016-05-09 20:52:04.000000000","message":"Hmmm.  Somehow my change here didn\u0027t make it in the patch.  I did test it.  Another patch set coming.","commit_id":"113fdb7a5bdbd2e0f0dbffb34bfc40d6060c9b8b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9a446e86b2eb31692f79bc1a9810426bf768caed","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":320,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":321,"context_line":"            raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"},{"line_number":322,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":323,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_0dbb7728","line":320,"updated":"2016-05-09 22:23:22.000000000","message":"I\u0027m confused about how this can generate a DBReference error. It\u0027s not querying for a specific segment here. It seems like this handler belongs in the case down on L329 with .one() fails to return a record.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"bed60b6eaa9912a64d403263c46823d4949c2f0d","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":320,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":321,"context_line":"            raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"},{"line_number":322,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":323,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_cd27af10","line":320,"in_reply_to":"dab17558_0dbb7728","updated":"2016-05-09 22:41:03.000000000","message":"perhaps if the block starting at L326 was moved before L316-L324 then that would invalidate the need for this particular exception handling?","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"85b2c76d65361bbee5ffa63db03f15214a78da4a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":320,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":321,"context_line":"            raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"},{"line_number":322,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":323,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_7d672bb7","line":320,"in_reply_to":"dab17558_48d1ed56","updated":"2016-05-10 14:44:09.000000000","message":"I\u0027ll add a comment to clarify this.  Actually, I thought I had added a comment already because it wasn\u0027t clear to me but I guess I didn\u0027t.\n\nTo be clearer, L476 calls \"add\" on a subnet containing a segment_id which isn\u0027t found in the DB.  However, that line doesn\u0027t trigger the DBReferenceError.  This line does because it triggers the creation of the subnet be sent to the DB.\n\nIt would be clearer if I issued a flush explicitly after the add.  That would incur one more DB round-trip but maybe the clarity is better?  What do you think?","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"883d60de4bdb2481a25b85ac774778d36955414c","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":320,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":321,"context_line":"            raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"},{"line_number":322,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":323,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_66015306","line":320,"in_reply_to":"dab17558_7d672bb7","updated":"2016-05-10 16:37:51.000000000","message":"Actually, I\u0027ll try another approach to make it clearer.  I\u0027ll take try adding a flush after L476 and catch this exception there.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7644bc3e0356e2ae9ef1661c6284244905d9df4c","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":320,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":321,"context_line":"            raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"},{"line_number":322,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":323,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_48d1ed56","line":320,"in_reply_to":"dab17558_cd27af10","updated":"2016-05-09 22:59:45.000000000","message":"Just tested this out btw and it generates the DBReference error because if an erroneous segment_id is provided, the foreign key constraint fails.\n\nexception message:\n(pymysql.err.IntegrityError) (1452, u\u0027Cannot add or update a child row: a foreign key constraint fails","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6cf8828af9dc8281eb7c749dbe4e52d0b6a2ff00","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":320,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":321,"context_line":"            raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"},{"line_number":322,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":323,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("},{"line_number":324,"context_line":"                network_id\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_94859d08","line":321,"range":{"start_line":321,"start_character":46,"end_line":321,"end_character":67},"updated":"2016-05-10 10:12:25.000000000","message":"The segment_id has not been used yet. Why would it be in the exception?","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"85b2c76d65361bbee5ffa63db03f15214a78da4a","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            associated_segments \u003d set(row.segment_id for row in query)"},{"line_number":320,"context_line":"        except db_exc.DBReferenceError:"},{"line_number":321,"context_line":"            raise segment_exc.SegmentNotFound(segment_id\u003dsegment_id)"},{"line_number":322,"context_line":"        if None in associated_segments and len(associated_segments) \u003e 1:"},{"line_number":323,"context_line":"            raise segment_exc.SubnetsNotAllAssociatedWithSegments("},{"line_number":324,"context_line":"                network_id\u003dnetwork_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_5d222753","line":321,"range":{"start_line":321,"start_character":46,"end_line":321,"end_character":67},"in_reply_to":"dab17558_94859d08","updated":"2016-05-10 14:44:09.000000000","message":"See the discussion on L320, it actually is this segment that isn\u0027t found.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9a446e86b2eb31692f79bc1a9810426bf768caed","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        return fixed_ip_list"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def _ipam_get_subnets(self, context, network_id, segment_id):"},{"line_number":537,"context_line":"        make_subnet_dict \u003d functools.partial(self._make_subnet_dict,"},{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_edb55331","line":537,"updated":"2016-05-09 22:23:22.000000000","message":"is the partial really buying you anything here? It seems like less code to think about if you just pass context in on L542 when you call make_subnet_dict. If it was to make the list comprehension fit on one line I think the gain is lost by the two added up here.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"883d60de4bdb2481a25b85ac774778d36955414c","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        return fixed_ip_list"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def _ipam_get_subnets(self, context, network_id, segment_id):"},{"line_number":537,"context_line":"        make_subnet_dict \u003d functools.partial(self._make_subnet_dict,"},{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_e90b5422","line":537,"in_reply_to":"dab17558_bda7d3bb","updated":"2016-05-10 16:37:51.000000000","message":"Done","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"85b2c76d65361bbee5ffa63db03f15214a78da4a","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        return fixed_ip_list"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    def _ipam_get_subnets(self, context, network_id, segment_id):"},{"line_number":537,"context_line":"        make_subnet_dict \u003d functools.partial(self._make_subnet_dict,"},{"line_number":538,"context_line":"                                             context\u003dcontext)"},{"line_number":539,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":540,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_bda7d3bb","line":537,"in_reply_to":"dab17558_edb55331","updated":"2016-05-10 14:44:09.000000000","message":"Ya, it was copied from some more generic code that I borrowed.  Over time, its usefulness waned and I never removed it.  I\u0027ll remove it.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a9fb9a7b36730a2beb336bf2962cb341a9808c27","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":537,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":538,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id \u003d\u003d segment_id)"},{"line_number":539,"context_line":"        subnets \u003d [self._make_subnet_dict(context, c, None) for c in query]"},{"line_number":540,"context_line":"        return subnets"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _make_subnet_args(self, detail, subnet, subnetpool_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_60e64ab1","line":539,"updated":"2016-05-10 21:52:19.000000000","message":"context is a keyword argument, not positional.  which is the reason for the failures.","commit_id":"fcb4b84b632ced1cafeba28b74206aa06902349f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2860004cd0c6f3c6e93de1fb13260cca01c4d821","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":537,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":538,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id \u003d\u003d segment_id)"},{"line_number":539,"context_line":"        subnets \u003d [self._make_subnet_dict(context, c, None) for c in query]"},{"line_number":540,"context_line":"        return subnets"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _make_subnet_args(self, detail, subnet, subnetpool_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_009c9e0d","line":539,"range":{"start_line":539,"start_character":42,"end_line":539,"end_character":51},"updated":"2016-05-10 21:53:58.000000000","message":"fail!","commit_id":"fcb4b84b632ced1cafeba28b74206aa06902349f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"85c11f1e8c2a619d44ad0e76282251d31aed195f","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":537,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":538,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id \u003d\u003d segment_id)"},{"line_number":539,"context_line":"        subnets \u003d [self._make_subnet_dict(context, c, None) for c in query]"},{"line_number":540,"context_line":"        return subnets"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _make_subnet_args(self, detail, subnet, subnetpool_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_805d2e49","line":539,"range":{"start_line":539,"start_character":42,"end_line":539,"end_character":51},"in_reply_to":"dab17558_009c9e0d","updated":"2016-05-10 21:55:43.000000000","message":"@Brandon, actually all arguments in python methods are positional and keyword args.  But, I got the position wrong!  All because I\u0027m lazy and I thought the change was so trivial that I didn\u0027t need to run tests.  :(  My fault.","commit_id":"fcb4b84b632ced1cafeba28b74206aa06902349f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dbfd7fe96b75b13be98e7eecaabde142fcc7ad0d","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":537,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":538,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id \u003d\u003d segment_id)"},{"line_number":539,"context_line":"        subnets \u003d [self._make_subnet_dict(context, c, None) for c in query]"},{"line_number":540,"context_line":"        return subnets"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _make_subnet_args(self, detail, subnet, subnetpool_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_772451c4","line":539,"range":{"start_line":539,"start_character":42,"end_line":539,"end_character":51},"in_reply_to":"dab17558_547aeb77","updated":"2016-05-10 23:05:12.000000000","message":"This is often confused.  In the method definition, context is given a default value but that doesn\u0027t mean you have to pass a value as a keyword argument.  The two are actually two different concepts.\n\n1. When you define a method, arguments with default values must be defined after all arguments without default values.  Adding a default value just means you can leave the argument off when you call it, its optional.\n\n2. When you call a method, *any* argument can be passed as a positional argument or a keyword argument.  But, you must specify your positional arguments starting with the first argument before you can specify your keyword arguments.\n\nAll of the following are valid ways to call this method based on those rules and can be verified on your own.\n\n  self._make_subnet_dict(c, None, context):\n  self._make_subnet_dict(context\u003dcontext, subnet\u003dc):  \n  self._make_subnet_dict(c, context\u003dcontext):\n  self._make_subnet_dict(fields\u003dNone, subnet\u003dc, context\u003dcontext):\n\nMy mistake was that I assumed that context was in the first position after self and tried to pass it in that position.  That was clearly wrong.","commit_id":"fcb4b84b632ced1cafeba28b74206aa06902349f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"309042087775a02f134f529fc257348160fc23c4","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":537,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":538,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id \u003d\u003d segment_id)"},{"line_number":539,"context_line":"        subnets \u003d [self._make_subnet_dict(context, c, None) for c in query]"},{"line_number":540,"context_line":"        return subnets"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _make_subnet_args(self, detail, subnet, subnetpool_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_53067420","line":539,"range":{"start_line":539,"start_character":42,"end_line":539,"end_character":51},"in_reply_to":"dab17558_772451c4","updated":"2016-05-11 08:02:20.000000000","message":"ah I did not know you could reference the positional args out of order. good to know, thanks!","commit_id":"fcb4b84b632ced1cafeba28b74206aa06902349f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"ea179e07a1e2c162c97f0dea735314306922c32a","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        query \u003d self._get_collection_query(context, models_v2.Subnet)"},{"line_number":537,"context_line":"        query \u003d query.filter(models_v2.Subnet.network_id \u003d\u003d network_id)"},{"line_number":538,"context_line":"        query \u003d query.filter(models_v2.Subnet.segment_id \u003d\u003d segment_id)"},{"line_number":539,"context_line":"        subnets \u003d [self._make_subnet_dict(context, c, None) for c in query]"},{"line_number":540,"context_line":"        return subnets"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def _make_subnet_args(self, detail, subnet, subnetpool_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"dab17558_547aeb77","line":539,"range":{"start_line":539,"start_character":42,"end_line":539,"end_character":51},"in_reply_to":"dab17558_805d2e49","updated":"2016-05-10 22:01:39.000000000","message":"well in the method definition its a keyword arg which does mean it has to come after positional args :) i know they can be passed in positionally or with keywords, but it always felt like a dirty trick to do that.","commit_id":"fcb4b84b632ced1cafeba28b74206aa06902349f"}],"neutron/db/ipam_non_pluggable_backend.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"521d0cab97601f7843f3940c0a80e108b5b60b7e","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        v6_stateless \u003d []"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        filters \u003d {\u0027network_id\u0027: [p[\u0027network_id\u0027]]}"},{"line_number":350,"context_line":"        filters[\u0027segment_id\u0027] \u003d None"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        subnets \u003d self._get_subnets(context, filters\u003dfilters)"},{"line_number":353,"context_line":"        is_router_port \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_8f4d7740","line":350,"range":{"start_line":350,"start_character":0,"end_line":350,"end_character":36},"updated":"2016-04-07 05:04:04.000000000","message":"Add the same change to ipam_pluggable_backend ?","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"882bc814183cb7483143520b396497701018fad1","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        v6_stateless \u003d []"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        filters \u003d {\u0027network_id\u0027: [p[\u0027network_id\u0027]]}"},{"line_number":350,"context_line":"        filters[\u0027segment_id\u0027] \u003d None"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        subnets \u003d self._get_subnets(context, filters\u003dfilters)"},{"line_number":353,"context_line":"        is_router_port \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2ed3db05","line":350,"range":{"start_line":350,"start_character":0,"end_line":350,"end_character":36},"in_reply_to":"7a1b2928_7d8de87a","updated":"2016-04-20 20:02:12.000000000","message":"Done.  This is mostly due to this being a work in progress and I probably was just playing around with it in different configurations.  Have patience.  :)","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"888b8120143b1edde2984a16439f7da3bdc63683","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        v6_stateless \u003d []"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        filters \u003d {\u0027network_id\u0027: [p[\u0027network_id\u0027]]}"},{"line_number":350,"context_line":"        filters[\u0027segment_id\u0027] \u003d None"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        subnets \u003d self._get_subnets(context, filters\u003dfilters)"},{"line_number":353,"context_line":"        is_router_port \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_7d8de87a","line":350,"range":{"start_line":350,"start_character":0,"end_line":350,"end_character":36},"in_reply_to":"9a061dce_8f4d7740","updated":"2016-04-11 05:14:11.000000000","message":"Can we also combine it in one line?\nI mean, its the same filters, right?","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7128c3768678d70318c06da0f8064206251479f2","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        added \u003d []"},{"line_number":319,"context_line":"        changes \u003d self._get_changed_ips_for_port(context, original_ips,"},{"line_number":320,"context_line":"                                                 new_ips, device_owner)"},{"line_number":321,"context_line":"        net_id_filter \u003d {\u0027network_id\u0027: [network_id]}"},{"line_number":322,"context_line":"        subnets \u003d self._get_subnets(context, filters\u003dnet_id_filter)"},{"line_number":323,"context_line":"        # Check if the IP\u0027s to add are OK"},{"line_number":324,"context_line":"        to_add \u003d self._test_fixed_ips_for_port(context, network_id,"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_33655445","side":"PARENT","line":321,"range":{"start_line":321,"start_character":8,"end_line":321,"end_character":21},"updated":"2016-05-06 14:36:41.000000000","message":"I need to adjust this filter too.","commit_id":"a34c3543d0953d11718c6a88704a3822faf8f941"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"517ac760b9a89dfd91f42816e761098bbfb219c9","unresolved":false,"context_lines":[{"line_number":347,"context_line":"        \"\"\""},{"line_number":348,"context_line":"        p \u003d port[\u0027port\u0027]"},{"line_number":349,"context_line":"        net_id_filter \u003d {\u0027network_id\u0027: [p[\u0027network_id\u0027]]}"},{"line_number":350,"context_line":"        subnets \u003d self._get_subnets(context, filters\u003dnet_id_filter)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        v4, v6_stateful, v6_stateless \u003d self._classify_subnets("},{"line_number":353,"context_line":"            context, subnets)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_166d9e98","side":"PARENT","line":350,"range":{"start_line":350,"start_character":23,"end_line":350,"end_character":35},"updated":"2016-05-06 14:45:59.000000000","message":"In follow-on patches, I\u0027m hitting the limits of how I\u0027m able to express filters using this method.  I\u0027m thinking I might need to bypass this method and go straight to _get_collection_query.","commit_id":"a34c3543d0953d11718c6a88704a3822faf8f941"}],"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"39566f1166cc892137b8c8690cc03d24392d184c","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                subnet[\u0027cidr\u0027],"},{"line_number":434,"context_line":"                subnet[\u0027gateway_ip\u0027])"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        group_id \u003d subnet.get(segment.SEGMENT_ID)"},{"line_number":437,"context_line":"        ipam_driver \u003d driver.Pool.get_instance(subnetpool, context)"},{"line_number":438,"context_line":"        subnet_factory \u003d ipam_driver.get_subnet_request_factory()"},{"line_number":439,"context_line":"        # FIXME(Carl) We need to have a way to discover if the IPAM driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_d263fa18","line":436,"range":{"start_line":436,"start_character":8,"end_line":436,"end_character":16},"updated":"2016-03-30 17:49:25.000000000","message":"I\u0027m thinking of moving this in to another patch for pluggable IPAM and just doing non-pluggable in this patch.  The implementation for pluggable will need a little more pre-work, I think.","commit_id":"ae302073734a694831d13a6743f171c0352e5b04"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7128c3768678d70318c06da0f8064206251479f2","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        changes \u003d self._get_changed_ips_for_port("},{"line_number":266,"context_line":"            context, original_ips, new_ips, port[\u0027device_owner\u0027])"},{"line_number":267,"context_line":"        net_id_filter \u003d {\u0027network_id\u0027: [port[\u0027network_id\u0027]]}"},{"line_number":268,"context_line":"        subnets \u003d self._get_subnets(context, filters\u003dnet_id_filter)"},{"line_number":269,"context_line":"        # Check if the IP\u0027s to add are OK"},{"line_number":270,"context_line":"        to_add \u003d self._test_fixed_ips_for_port("},{"line_number":271,"context_line":"            context, port[\u0027network_id\u0027], changes.add,"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_93d1a0d0","side":"PARENT","line":268,"range":{"start_line":268,"start_character":23,"end_line":268,"end_character":35},"updated":"2016-05-06 14:36:41.000000000","message":"And this one.","commit_id":"a34c3543d0953d11718c6a88704a3822faf8f941"}],"neutron/db/migration/alembic_migrations/versions/mitaka/expand/c879c5e1ee90_add_segment_id_to_subnet.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93effbc5449d187ce0fb4d6c4a5d8a2fce0e94cb","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Add segment_id to subnet"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: c879c5e1ee90"},{"line_number":19,"context_line":"Revises: 45f8dd33480b"},{"line_number":20,"context_line":"Create Date: 2016-03-02 23:59:59.040137"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_6c43ad6c","line":18,"updated":"2016-04-20 17:07:59.000000000","message":"Remove this stuff","commit_id":"3596747faf862fb67b1381cd95f2290e6065e517"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"8db39e905a661dbd01f44414c078f4e130f3a02d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":28,"context_line":"        sa.Column(\u0027segment_id\u0027, sa.String(length\u003d36), nullable\u003dTrue))"},{"line_number":29,"context_line":"    op.create_foreign_key("},{"line_number":30,"context_line":"        None, \u0027subnets\u0027, \u0027networksegments\u0027, [\u0027segment_id\u0027], [\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_f112a457","line":30,"updated":"2016-04-22 03:48:28.000000000","message":"I don\u0027t know if alembic, or SA takes care of the constraint name, but doesn\u0027t pg require a constraint name?","commit_id":"799e90605bc710275212772f6aa5a610713a6530"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0fffa61d327b54a2761a0bf43ab88344d5ee46f6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":28,"context_line":"        sa.Column(\u0027segment_id\u0027, sa.String(length\u003d36), nullable\u003dTrue))"},{"line_number":29,"context_line":"    op.create_foreign_key("},{"line_number":30,"context_line":"        None, \u0027subnets\u0027, \u0027networksegments\u0027, [\u0027segment_id\u0027], [\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_8ba861dd","line":30,"in_reply_to":"1a122d0e_ababb474","updated":"2016-05-02 18:36:53.000000000","message":":)","commit_id":"799e90605bc710275212772f6aa5a610713a6530"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a7607b46c97b530de9acca00f9ab0f88d463ed63","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":28,"context_line":"        sa.Column(\u0027segment_id\u0027, sa.String(length\u003d36), nullable\u003dTrue))"},{"line_number":29,"context_line":"    op.create_foreign_key("},{"line_number":30,"context_line":"        None, \u0027subnets\u0027, \u0027networksegments\u0027, [\u0027segment_id\u0027], [\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_ababb474","line":30,"in_reply_to":"1a122d0e_f112a457","updated":"2016-05-01 06:19:08.000000000","message":"doesn\u0027t appear this is a thing at this point.  i rescind my comment. :)","commit_id":"799e90605bc710275212772f6aa5a610713a6530"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"090c9c5665363a3491b227d7cda2b7896d321633","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":28,"context_line":"        sa.Column(\u0027segment_id\u0027, sa.String(length\u003d36), nullable\u003dTrue))"},{"line_number":29,"context_line":"    op.create_foreign_key("},{"line_number":30,"context_line":"        None, \u0027subnets\u0027, \u0027networksegments\u0027, [\u0027segment_id\u0027], [\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"dab17558_f4fd966f","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":41},"updated":"2016-05-05 21:03:28.000000000","message":"So, I finally looked in to why this is failing the functional test.  First, this script is in the mitaka directory when it should be in the newton directory.  Second, this script is in the expand directory but it depends on another migration in the contract branch.  I\u0027m thinking this probably means that it must also go in the contract branch.","commit_id":"20668f92afb7cf8d33d2d1e6780ac51d6ff710f7"}],"neutron/db/migration/alembic_migrations/versions/newton/contract/c879c5e1ee90_add_segment_id_to_subnet.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"2d1e31ffcc10a0ae1614b946f235cd184b44ecc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dab17558_1692709e","line":31,"updated":"2016-05-09 20:04:37.000000000","message":"so just a thought, if there is a concern that this should be just an EXPAND migration, then this script could look for the existance of networksegments table OR the ml2_network_segments table and do the operation to the one that exists.  I\u0027m sure some feel that minimizing CONTRACT migrations where possible is a worthy goal.","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93512b48874bed1b32406c6eff2455858505e796","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dab17558_d6cf487d","line":31,"in_reply_to":"dab17558_1692709e","updated":"2016-05-09 20:19:57.000000000","message":"Let me think about this.","commit_id":"20544628898012c9cdcefcb6def7ece4d2fb2814"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9a446e86b2eb31692f79bc1a9810426bf768caed","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def upgrade():"},{"line_number":27,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":28,"context_line":"        sa.Column(\u0027segment_id\u0027, sa.String(length\u003d36), nullable\u003dTrue))"},{"line_number":29,"context_line":"    op.create_foreign_key("},{"line_number":30,"context_line":"        None, \u0027subnets\u0027, \u0027networksegments\u0027, [\u0027segment_id\u0027], [\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_4d83bf56","line":28,"updated":"2016-05-09 22:23:22.000000000","message":"Since this column is nullable, this actually should be an expand script. An old version of the server should work fine whether or not this column is present.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"bed60b6eaa9912a64d403263c46823d4949c2f0d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def upgrade():"},{"line_number":27,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":28,"context_line":"        sa.Column(\u0027segment_id\u0027, sa.String(length\u003d36), nullable\u003dTrue))"},{"line_number":29,"context_line":"    op.create_foreign_key("},{"line_number":30,"context_line":"        None, \u0027subnets\u0027, \u0027networksegments\u0027, [\u0027segment_id\u0027], [\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_8dff6766","line":28,"in_reply_to":"dab17558_4d83bf56","updated":"2016-05-09 22:41:03.000000000","message":"it relies on a rename of this table in the dependent contract migratoin, which is why its here.  I suggested to check for the old and/or new table existance and then perform the option on the table that exists to get this to being an EXPAND migration again.  I\u0027m not sure that buys much though.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"85b2c76d65361bbee5ffa63db03f15214a78da4a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def upgrade():"},{"line_number":27,"context_line":"    op.add_column(\u0027subnets\u0027,"},{"line_number":28,"context_line":"        sa.Column(\u0027segment_id\u0027, sa.String(length\u003d36), nullable\u003dTrue))"},{"line_number":29,"context_line":"    op.create_foreign_key("},{"line_number":30,"context_line":"        None, \u0027subnets\u0027, \u0027networksegments\u0027, [\u0027segment_id\u0027], [\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_609820c1","line":28,"in_reply_to":"dab17558_8dff6766","updated":"2016-05-10 14:44:09.000000000","message":"Right, Henry suggested possibly splitting the foreign key constraint out in to a contract migration and adding the table in an expand.  But, the conclusion was that contract migrations will not be optional in Newton and so it doesn\u0027t buy us anything.  The code would have to be able to handle the lack of FK constraint which is something we\u0027re quite set up to do very well yet.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"}],"neutron/db/models_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"43f420d3f1befe0b47791509e24adf42f122bd10","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    segment_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networksegments.id\u0027))"},{"line_number":188,"context_line":"    subnetpool_id \u003d sa.Column(sa.String(36), index\u003dTrue)"},{"line_number":189,"context_line":"    # NOTE: Explicitly specify join conditions for the relationship because"},{"line_number":190,"context_line":"    # subnetpool_id in subnet might be \u0027prefix_delegation\u0027 when the IPv6 Prefix"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_cce1a49c","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":14},"updated":"2016-03-29 22:40:27.000000000","message":"I think the code should prevent associating with dynamic segments.  Maybe someone who understands dynamic segments a little bit better can comment.","commit_id":"ae302073734a694831d13a6743f171c0352e5b04"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"480cd1e7d21c994bba597a6692b75b35ba54b8fb","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    segment_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networksegments.id\u0027))"},{"line_number":188,"context_line":"    subnetpool_id \u003d sa.Column(sa.String(36), index\u003dTrue)"},{"line_number":189,"context_line":"    # NOTE: Explicitly specify join conditions for the relationship because"},{"line_number":190,"context_line":"    # subnetpool_id in subnet might be \u0027prefix_delegation\u0027 when the IPv6 Prefix"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_ec5dd37a","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":14},"in_reply_to":"ba0121b8_2be363da","updated":"2016-04-01 20:18:26.000000000","message":"You\u0027re -1ing my comment to myself on my own WIP patch?  Looking for stats?\n\nThink about what this is trying to accomplish.  A network made up of more than one segment.  I think it should be clear.  If it isn\u0027t, wait for the final version and -1 there.","commit_id":"ae302073734a694831d13a6743f171c0352e5b04"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"72deff0c5e052e3b5d09e9854be541b64ed14d65","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    segment_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networksegments.id\u0027))"},{"line_number":188,"context_line":"    subnetpool_id \u003d sa.Column(sa.String(36), index\u003dTrue)"},{"line_number":189,"context_line":"    # NOTE: Explicitly specify join conditions for the relationship because"},{"line_number":190,"context_line":"    # subnetpool_id in subnet might be \u0027prefix_delegation\u0027 when the IPv6 Prefix"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_2be363da","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":14},"in_reply_to":"ba0121b8_c71e2f6f","updated":"2016-03-31 23:13:23.000000000","message":"Is that all subnets on the same network should be associated with *any* segment or the same segment? If the latter, could the network_id implicitly define the associated segment?","commit_id":"ae302073734a694831d13a6743f171c0352e5b04"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e130588bbe0afa5f39deaa7cde2dabdea303a09d","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":186,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networks.id\u0027))"},{"line_number":187,"context_line":"    segment_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\u0027networksegments.id\u0027))"},{"line_number":188,"context_line":"    subnetpool_id \u003d sa.Column(sa.String(36), index\u003dTrue)"},{"line_number":189,"context_line":"    # NOTE: Explicitly specify join conditions for the relationship because"},{"line_number":190,"context_line":"    # subnetpool_id in subnet might be \u0027prefix_delegation\u0027 when the IPv6 Prefix"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_c71e2f6f","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":14},"in_reply_to":"ba0121b8_cce1a49c","updated":"2016-03-31 16:57:12.000000000","message":"Also, I think we should start by requiring that all of the subnets on a network be associated with a segment or all *not*.  We can discuss how this constraint might be relaxed in the future (e.g. floating subnets which are routed) but that won\u0027t be needed for a while.","commit_id":"ae302073734a694831d13a6743f171c0352e5b04"}],"neutron/db/segments_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"521d0cab97601f7843f3940c0a80e108b5b60b7e","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":46,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":47,"context_line":"                           nullable\u003dFalse)"},{"line_number":48,"context_line":"    network_type \u003d sa.Column(sa.String(32), nullable\u003dFalse)"},{"line_number":49,"context_line":"    physical_network \u003d sa.Column(sa.String(64))"},{"line_number":50,"context_line":"    segmentation_id \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_44422669","line":47,"range":{"start_line":47,"start_character":27,"end_line":47,"end_character":41},"updated":"2016-04-07 05:04:04.000000000","message":"Will the network_id still required not null? Previously, the segment is created with network, so it must be with a network. Now, user might create a segment first, and then associate it to a subnet.","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"882bc814183cb7483143520b396497701018fad1","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":46,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":47,"context_line":"                           nullable\u003dFalse)"},{"line_number":48,"context_line":"    network_type \u003d sa.Column(sa.String(32), nullable\u003dFalse)"},{"line_number":49,"context_line":"    physical_network \u003d sa.Column(sa.String(64))"},{"line_number":50,"context_line":"    segmentation_id \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_eeff2365","line":47,"range":{"start_line":47,"start_character":27,"end_line":47,"end_character":41},"in_reply_to":"9a061dce_44422669","updated":"2016-04-20 20:02:12.000000000","message":"network_id is always required with a segment and that remains true.","commit_id":"a0f342d4348c80d0207b01d2ba2209e13c2b8d37"}],"neutron/ipam/requests.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0283867ebdcd596a2564fc154fcf6a65c3337b32","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self._subnet_id \u003d subnet_id"},{"line_number":59,"context_line":"        self._gateway_ip \u003d None"},{"line_number":60,"context_line":"        self._allocation_pools \u003d None"},{"line_number":61,"context_line":"        self._group_id \u003d group_id"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if gateway_ip is not None:"},{"line_number":64,"context_line":"            self._gateway_ip \u003d netaddr.IPAddress(gateway_ip)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_26a96ae0","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":33},"updated":"2016-03-29 17:30:26.000000000","message":"Should we add this to SubnetRequest or create a new request type.  It seems a bit heavy to add a whole new hierarchy of subnet requests (i.e. corresponding classes for AnySubnetRequest and SpecificSubnetRequest) to support this.","commit_id":"ae302073734a694831d13a6743f171c0352e5b04"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0283867ebdcd596a2564fc154fcf6a65c3337b32","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"class SubnetRequestFactory(object):"},{"line_number":281,"context_line":"    \"\"\"Builds request using subnet info\"\"\""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    @classmethod"},{"line_number":284,"context_line":"    def get_request(cls, context, subnet, subnetpool, group_id\u003dNone):"},{"line_number":285,"context_line":"        cidr \u003d subnet.get(\u0027cidr\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_265e8a76","line":282,"updated":"2016-03-29 17:30:26.000000000","message":"Where would be the right place to add the ability to ask the driver if it supports grouping (or whatever we end up calling it?)","commit_id":"ae302073734a694831d13a6743f171c0352e5b04"}],"neutron/services/segments/db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"859124df11095f71affdfc225d98328028eb96c2","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def _extend_subnet_dict_binding(plugin, subnet_res, subnet_db):"},{"line_number":123,"context_line":"    plugin.extend_subnet_dict_segment(subnet_res, subnet_db)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Register dict extend functions for subnets"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_dc6b8ab5","line":123,"range":{"start_line":123,"start_character":4,"end_line":123,"end_character":37},"updated":"2016-04-20 18:28:49.000000000","message":"This doesn\u0027t work like this.  It ends up trying to call this on the Ml2Plugin instance.","commit_id":"7e91d8253654ef6d44abea578427180008a10cb6"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"521096869fd10897c51fdba4e6bec317c16c38a5","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def _extend_subnet_dict_binding(plugin, subnet_res, subnet_db):"},{"line_number":123,"context_line":"    plugin.extend_subnet_dict_segment(subnet_res, subnet_db)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"# Register dict extend functions for subnets"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_ff5c781a","line":123,"range":{"start_line":123,"start_character":4,"end_line":123,"end_character":37},"in_reply_to":"1a122d0e_dc6b8ab5","updated":"2016-04-20 18:55:36.000000000","message":"Done","commit_id":"7e91d8253654ef6d44abea578427180008a10cb6"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6cf8828af9dc8281eb7c749dbe4e52d0b6a2ff00","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            net \u003d network[\u0027network\u0027]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        # Can\u0027t create a dynamic segment through the API"},{"line_number":232,"context_line":"        with cxt.session.begin():"},{"line_number":233,"context_line":"            segment \u003d segments_db.NetworkSegment("},{"line_number":234,"context_line":"                            id\u003duuidutils.generate_uuid(),"},{"line_number":235,"context_line":"                            network_id\u003dnet[\u0027id\u0027],"},{"line_number":236,"context_line":"                            physical_network\u003d\u0027phys_net\u0027,"},{"line_number":237,"context_line":"                            network_type\u003d\u0027net_type\u0027,"},{"line_number":238,"context_line":"                            segmentation_id\u003d200,"},{"line_number":239,"context_line":"                            is_dynamic\u003dTrue)"},{"line_number":240,"context_line":"            cxt.session.add(segment)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        res \u003d self._create_subnet(self.fmt,"},{"line_number":243,"context_line":"                                  net_id\u003dnet[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_0fa9947b","line":240,"range":{"start_line":232,"start_character":0,"end_line":240,"end_character":36},"updated":"2016-05-10 10:12:25.000000000","message":"What about using \"segments_db.add_network_segment\"?","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"85b2c76d65361bbee5ffa63db03f15214a78da4a","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            net \u003d network[\u0027network\u0027]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        # Can\u0027t create a dynamic segment through the API"},{"line_number":232,"context_line":"        with cxt.session.begin():"},{"line_number":233,"context_line":"            segment \u003d segments_db.NetworkSegment("},{"line_number":234,"context_line":"                            id\u003duuidutils.generate_uuid(),"},{"line_number":235,"context_line":"                            network_id\u003dnet[\u0027id\u0027],"},{"line_number":236,"context_line":"                            physical_network\u003d\u0027phys_net\u0027,"},{"line_number":237,"context_line":"                            network_type\u003d\u0027net_type\u0027,"},{"line_number":238,"context_line":"                            segmentation_id\u003d200,"},{"line_number":239,"context_line":"                            is_dynamic\u003dTrue)"},{"line_number":240,"context_line":"            cxt.session.add(segment)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        res \u003d self._create_subnet(self.fmt,"},{"line_number":243,"context_line":"                                  net_id\u003dnet[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_a09de867","line":240,"range":{"start_line":232,"start_character":0,"end_line":240,"end_character":36},"in_reply_to":"dab17558_0fa9947b","updated":"2016-05-10 14:44:09.000000000","message":"I\u0027ll look at it.","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"883d60de4bdb2481a25b85ac774778d36955414c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            net \u003d network[\u0027network\u0027]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        # Can\u0027t create a dynamic segment through the API"},{"line_number":232,"context_line":"        with cxt.session.begin():"},{"line_number":233,"context_line":"            segment \u003d segments_db.NetworkSegment("},{"line_number":234,"context_line":"                            id\u003duuidutils.generate_uuid(),"},{"line_number":235,"context_line":"                            network_id\u003dnet[\u0027id\u0027],"},{"line_number":236,"context_line":"                            physical_network\u003d\u0027phys_net\u0027,"},{"line_number":237,"context_line":"                            network_type\u003d\u0027net_type\u0027,"},{"line_number":238,"context_line":"                            segmentation_id\u003d200,"},{"line_number":239,"context_line":"                            is_dynamic\u003dTrue)"},{"line_number":240,"context_line":"            cxt.session.add(segment)"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        res \u003d self._create_subnet(self.fmt,"},{"line_number":243,"context_line":"                                  net_id\u003dnet[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":17,"id":"dab17558_265d8b47","line":240,"range":{"start_line":232,"start_character":0,"end_line":240,"end_character":36},"in_reply_to":"dab17558_a09de867","updated":"2016-05-10 16:37:51.000000000","message":"Done","commit_id":"d7610362f5153a9432af10a5ec452497375c4215"}]}
