)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":9423,"name":"Roey Chen","email":"roeyc@vmware.com","username":"roeyc"},"change_message_id":"c8ca9a9108923540713818b5724bfad069c95b3a","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        for db_rule in db_rules:"},{"line_number":568,"context_line":"            if (security_group_rule[\u0027security_group_rule\u0027] \u003d\u003d db_rule):"},{"line_number":569,"context_line":"                raise ext_sg.SecurityGroupRuleExists("},{"line_number":570,"context_line":"                    id\u003ddb_rule[\u0027security_group_id\u0027])"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _validate_ip_prefix(self, rule):"},{"line_number":573,"context_line":"        \"\"\"Check that a valid cidr was specified as remote_ip_prefix"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_b76c9609","line":570,"range":{"start_line":570,"start_character":23,"end_line":570,"end_character":51},"updated":"2016-03-06 12:52:18.000000000","message":"We want the existing *rule* id, instead of the sg id","commit_id":"f9ec41e55260ac74113d980490eabfc0b7396dcb"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"9a99c5c8513dbe43d07569d1dbe76957a843f5a2","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        # Check in database if rule exists"},{"line_number":553,"context_line":"        filters \u003d self._make_security_group_rule_filter_dict("},{"line_number":554,"context_line":"            security_group_rule)"},{"line_number":555,"context_line":"        db_rules \u003d self.get_security_group_rules(context, filters)"},{"line_number":556,"context_line":"        # Note(arosen): the call to get_security_group_rules wildcards"},{"line_number":557,"context_line":"        # values in the filter that have a value of [None]. For"},{"line_number":558,"context_line":"        # example, filters \u003d {\u0027remote_group_id\u0027: [None]} will return"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_94252cc4","line":555,"updated":"2016-03-07 13:39:56.000000000","message":"Why we have removed fields? As the commit msg talks about missing local variable accidentally deleted via \"https://review.openstack.org/#/c/269887/28/neutron/db/securitygroups_db.py@568\".. Doesn\u0027t we only restore the deleted local variable?","commit_id":"60f6482ee6035d0f0683c3bd22006b6fb1b9f4bc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5ccbe11e59f2be0a7f91dc295c3c9db4544aded0","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        # Check in database if rule exists"},{"line_number":553,"context_line":"        filters \u003d self._make_security_group_rule_filter_dict("},{"line_number":554,"context_line":"            security_group_rule)"},{"line_number":555,"context_line":"        db_rules \u003d self.get_security_group_rules(context, filters)"},{"line_number":556,"context_line":"        # Note(arosen): the call to get_security_group_rules wildcards"},{"line_number":557,"context_line":"        # values in the filter that have a value of [None]. For"},{"line_number":558,"context_line":"        # example, filters \u003d {\u0027remote_group_id\u0027: [None]} will return"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_5a6aab1b","line":555,"in_reply_to":"5aef4532_1ab943ea","updated":"2016-03-07 14:10:39.000000000","message":"No, your understanding is not correct. The comparison of the rules cannot be done with the ID\u0027s as they are unique. Same for description (one may write foo for the one and bar for the other...)","commit_id":"60f6482ee6035d0f0683c3bd22006b6fb1b9f4bc"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"cb24fbad9160342a0b4a36932be1ff5ee479d705","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        # Check in database if rule exists"},{"line_number":553,"context_line":"        filters \u003d self._make_security_group_rule_filter_dict("},{"line_number":554,"context_line":"            security_group_rule)"},{"line_number":555,"context_line":"        db_rules \u003d self.get_security_group_rules(context, filters)"},{"line_number":556,"context_line":"        # Note(arosen): the call to get_security_group_rules wildcards"},{"line_number":557,"context_line":"        # values in the filter that have a value of [None]. For"},{"line_number":558,"context_line":"        # example, filters \u003d {\u0027remote_group_id\u0027: [None]} will return"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_257340b3","line":555,"in_reply_to":"5aef4532_5a6aab1b","updated":"2016-03-07 14:19:11.000000000","message":"You\u0027re right :)","commit_id":"60f6482ee6035d0f0683c3bd22006b6fb1b9f4bc"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"2e52f36b4b18fdb728d237b7b242a8c1b48a51f6","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        # Check in database if rule exists"},{"line_number":553,"context_line":"        filters \u003d self._make_security_group_rule_filter_dict("},{"line_number":554,"context_line":"            security_group_rule)"},{"line_number":555,"context_line":"        db_rules \u003d self.get_security_group_rules(context, filters)"},{"line_number":556,"context_line":"        # Note(arosen): the call to get_security_group_rules wildcards"},{"line_number":557,"context_line":"        # values in the filter that have a value of [None]. For"},{"line_number":558,"context_line":"        # example, filters \u003d {\u0027remote_group_id\u0027: [None]} will return"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_1ab943ea","line":555,"in_reply_to":"5aef4532_94252cc4","updated":"2016-03-07 14:07:19.000000000","message":"If just enable the fields, we cannot get the id on L567. What you want is like following?\n\n\n security_group_rule[\u0027security_group_rule\u0027][\u0027id\u0027] \u003d None\n db_rules \u003d self.get_security_group_rules(context, filters,\n       fields\u003dsecurity_group_rule[\u0027security_group_rule\u0027].keys())\n\n\nIt seems not make sense ;)\nOr my understanding is wrong?","commit_id":"60f6482ee6035d0f0683c3bd22006b6fb1b9f4bc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5c6e73c3f7a356ffc6aa6c972c15ea21ede4c3aa","unresolved":false,"context_lines":[{"line_number":552,"context_line":"        # Check in database if rule exists"},{"line_number":553,"context_line":"        filters \u003d self._make_security_group_rule_filter_dict("},{"line_number":554,"context_line":"            security_group_rule)"},{"line_number":555,"context_line":"        db_rules \u003d self.get_security_group_rules(context, filters)"},{"line_number":556,"context_line":"        # Note(arosen): the call to get_security_group_rules wildcards"},{"line_number":557,"context_line":"        # values in the filter that have a value of [None]. For"},{"line_number":558,"context_line":"        # example, filters \u003d {\u0027remote_group_id\u0027: [None]} will return"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_baf2cf98","line":555,"in_reply_to":"5aef4532_94252cc4","updated":"2016-03-07 14:09:01.000000000","message":"If you look at the commit https://review.openstack.org/#q,5dacbba701037200f9b0ae40c34981ecd941b41c,n,z you will see that it removed code that had id \u003d db_rule.pop(\u0027id\u0027)\nNow the variable id was used in the exception where the SecurityGroupRuleExists is raised.\nSo the user will get some dodgy pointer that does not tell her/him what is the duplicate rules.\nThe reason the search above was changed was to remove the descriptn. This is removed below..","commit_id":"60f6482ee6035d0f0683c3bd22006b6fb1b9f4bc"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"63c41e2cd7ad02f6012254b962a8de2c0b7a0472","unresolved":false,"context_lines":[{"line_number":567,"context_line":"            rule_id \u003d db_rule.pop(\u0027id\u0027, None)"},{"line_number":568,"context_line":"            db_rule.pop(\u0027description\u0027, None)"},{"line_number":569,"context_line":"            if (security_group_rule[\u0027security_group_rule\u0027] \u003d\u003d db_rule):"},{"line_number":570,"context_line":"                raise ext_sg.SecurityGroupRuleExists(id\u003drule_id)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _validate_ip_prefix(self, rule):"},{"line_number":573,"context_line":"        \"\"\"Check that a valid cidr was specified as remote_ip_prefix"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a5bbd00d","line":570,"updated":"2016-03-07 14:22:58.000000000","message":"we should move away from id, as id is a reserved word; I suspect that\u0027s why we didn\u0027t catch the issue in the first place.\n\nI realize that the change may end up slightly more invasive, but using id as keyword was broken to begin with.","commit_id":"60f6482ee6035d0f0683c3bd22006b6fb1b9f4bc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"599f7e40700ccf2760017ade9b6f9a713d6a89c1","unresolved":false,"context_lines":[{"line_number":567,"context_line":"            rule_id \u003d db_rule.pop(\u0027id\u0027, None)"},{"line_number":568,"context_line":"            db_rule.pop(\u0027description\u0027, None)"},{"line_number":569,"context_line":"            if (security_group_rule[\u0027security_group_rule\u0027] \u003d\u003d db_rule):"},{"line_number":570,"context_line":"                raise ext_sg.SecurityGroupRuleExists(id\u003drule_id)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"    def _validate_ip_prefix(self, rule):"},{"line_number":573,"context_line":"        \"\"\"Check that a valid cidr was specified as remote_ip_prefix"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a59c706a","line":570,"in_reply_to":"5aef4532_a5bbd00d","updated":"2016-03-07 14:29:00.000000000","message":"Done","commit_id":"60f6482ee6035d0f0683c3bd22006b6fb1b9f4bc"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0f96f3036146528662385060a38cef9578df37ef","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        filters \u003d self._make_security_group_rule_filter_dict("},{"line_number":555,"context_line":"            security_group_rule)"},{"line_number":556,"context_line":"        db_rules \u003d self.get_security_group_rules(context, filters,"},{"line_number":557,"context_line":"            fields\u003dsecurity_group_rule[\u0027security_group_rule\u0027].keys())"},{"line_number":558,"context_line":"        # Note(arosen): the call to get_security_group_rules wildcards"},{"line_number":559,"context_line":"        # values in the filter that have a value of [None]. For"},{"line_number":560,"context_line":"        # example, filters \u003d {\u0027remote_group_id\u0027: [None]} will return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_a7ec4fc8","line":557,"range":{"start_line":557,"start_character":40,"end_line":557,"end_character":59},"updated":"2016-03-08 05:21:23.000000000","message":"can\u0027t we just request the ID field here as well and then pop it back off before the comparison just like the previous code?\n\ndb_rules \u003d self.get_security_group_rules(context, filters,\n    fields\u003dsecurity_group_rule[\u0027security_group_rule\u0027].keys()+[\u0027id\u0027])\nfor db_rule in db_rules:\n    id \u003d db_rule.pop(\u0027id\u0027)\n    if (security_group_rule[\u0027security_group_rule\u0027] \u003d\u003d db_rule):\n        raise ext_sg.SecurityGroupRuleExists(id\u003did)","commit_id":"958d07270d1314084d6222c95674a96eea888a43"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"32a338e0a080d9d327299bc7172a299d7d15b346","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        filters \u003d self._make_security_group_rule_filter_dict("},{"line_number":555,"context_line":"            security_group_rule)"},{"line_number":556,"context_line":"        db_rules \u003d self.get_security_group_rules(context, filters,"},{"line_number":557,"context_line":"            fields\u003dsecurity_group_rule[\u0027security_group_rule\u0027].keys())"},{"line_number":558,"context_line":"        # Note(arosen): the call to get_security_group_rules wildcards"},{"line_number":559,"context_line":"        # values in the filter that have a value of [None]. For"},{"line_number":560,"context_line":"        # example, filters \u003d {\u0027remote_group_id\u0027: [None]} will return"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_272ddfa7","line":557,"range":{"start_line":557,"start_character":40,"end_line":557,"end_character":59},"in_reply_to":"5aef4532_a7ec4fc8","updated":"2016-03-08 05:35:00.000000000","message":"Nice. Not sure why I did not do this from the start :)","commit_id":"958d07270d1314084d6222c95674a96eea888a43"}],"neutron/extensions/securitygroup.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"94ac34f3f4626defa09bd249c700b9de485b8c2d","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class SecurityGroupRuleNotFound(nexception.NotFound):"},{"line_number":109,"context_line":"    message \u003d _(\"Security group rule %(id)s does not exist\")"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"class DuplicateSecurityGroupRuleInPost(nexception.InUse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_b7266514","line":109,"range":{"start_line":109,"start_character":37,"end_line":109,"end_character":43},"updated":"2016-03-07 15:22:02.000000000","message":"I\u0027m so picky so it feel inconsistency...but it may be beyond this patch.","commit_id":"4373d49e446ce66cc77f3012e3bfb92d1ea10cba"}],"neutron/tests/unit/extensions/test_securitygroup.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6c32935c4851f978c8464cc9899f20b3f3e02e94","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                res \u003d self._create_security_group_rule(self.fmt, rule)"},{"line_number":954,"context_line":"                self.deserialize(self.fmt, res)"},{"line_number":955,"context_line":"                self.assertEqual(webob.exc.HTTPConflict.code, res.status_int)"},{"line_number":956,"context_line":"                self.assertIn(sgr[\u0027security_group_rule\u0027][\u0027id\u0027],"},{"line_number":957,"context_line":"                              res.json[\u0027NeutronError\u0027][\u0027message\u0027])"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    def test_create_security_group_rule_min_port_greater_max(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_6a57d002","line":956,"updated":"2016-03-07 15:26:00.000000000","message":"this assert is superfluous now that we moved away from id(), I can\u0027t see ourselves regress to using id(), in fact I think I wonder if it\u0027s safe to make a hacking rule out of this because I can\u0027t think of any scenario where shadowing id() is a good idea.\n\nThe problem is that we used indiscriminately all over the place :(","commit_id":"4373d49e446ce66cc77f3012e3bfb92d1ea10cba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7b6c7d4fdb8f405cbf272fade707083c70243e3c","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                res \u003d self._create_security_group_rule(self.fmt, rule)"},{"line_number":954,"context_line":"                self.deserialize(self.fmt, res)"},{"line_number":955,"context_line":"                self.assertEqual(webob.exc.HTTPConflict.code, res.status_int)"},{"line_number":956,"context_line":"                self.assertIn(sgr[\u0027security_group_rule\u0027][\u0027id\u0027],"},{"line_number":957,"context_line":"                              res.json[\u0027NeutronError\u0027][\u0027message\u0027])"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    def test_create_security_group_rule_min_port_greater_max(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_2d37a2b1","line":956,"in_reply_to":"5aef4532_2a882822","updated":"2016-03-07 15:47:12.000000000","message":"correct, even though we can have a whitelist, and ensure that no more slip in.","commit_id":"4373d49e446ce66cc77f3012e3bfb92d1ea10cba"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"06cbfe98482b51bceddf640c2def2e9e5edd4d2e","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                res \u003d self._create_security_group_rule(self.fmt, rule)"},{"line_number":954,"context_line":"                self.deserialize(self.fmt, res)"},{"line_number":955,"context_line":"                self.assertEqual(webob.exc.HTTPConflict.code, res.status_int)"},{"line_number":956,"context_line":"                self.assertIn(sgr[\u0027security_group_rule\u0027][\u0027id\u0027],"},{"line_number":957,"context_line":"                              res.json[\u0027NeutronError\u0027][\u0027message\u0027])"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    def test_create_security_group_rule_min_port_greater_max(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_8a7cce73","line":956,"in_reply_to":"5aef4532_2d37a2b1","updated":"2016-03-07 19:20:41.000000000","message":"this is necessary to check that we return the correct rule id","commit_id":"4373d49e446ce66cc77f3012e3bfb92d1ea10cba"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5df6c84241e25ceef8f25f02e6203bc764d8143d","unresolved":false,"context_lines":[{"line_number":953,"context_line":"                res \u003d self._create_security_group_rule(self.fmt, rule)"},{"line_number":954,"context_line":"                self.deserialize(self.fmt, res)"},{"line_number":955,"context_line":"                self.assertEqual(webob.exc.HTTPConflict.code, res.status_int)"},{"line_number":956,"context_line":"                self.assertIn(sgr[\u0027security_group_rule\u0027][\u0027id\u0027],"},{"line_number":957,"context_line":"                              res.json[\u0027NeutronError\u0027][\u0027message\u0027])"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    def test_create_security_group_rule_min_port_greater_max(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_2a882822","line":956,"in_reply_to":"5aef4532_6a57d002","updated":"2016-03-07 15:34:20.000000000","message":"The biggest problem is [1]. That is going to be quite an invasive fix. :(\n\n- [1] https://github.com/openstack/neutron/blob/master/neutron/db/model_base.py#L33-L38","commit_id":"4373d49e446ce66cc77f3012e3bfb92d1ea10cba"}]}
