)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7455396baac61d3452f7f5b8bb6272e42f3c5d0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds the pagination_url config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"JIRA:NCP-1831"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code for fetching the pagination links is hard coded to use"},{"line_number":12,"context_line":"WebOb\u0027s Request path_url property."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_18212a4e","line":9,"updated":"2016-03-08 04:09:20.000000000","message":"internal tracking.  don\u0027t want to put this upstream.","commit_id":"6da619afbe766855af0c2a59fa1a145bf20fba7d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"576b27e31b9bed02997e9c5825c225283c488598","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds the pagination_url config option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"JIRA:NCP-1831"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The code for fetching the pagination links is hard coded to use"},{"line_number":12,"context_line":"WebOb\u0027s Request path_url property."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_8c95f8e5","line":9,"in_reply_to":"5aef4532_18212a4e","updated":"2016-03-08 04:58:04.000000000","message":"+1","commit_id":"6da619afbe766855af0c2a59fa1a145bf20fba7d"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7455396baac61d3452f7f5b8bb6272e42f3c5d0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5aef4532_d1ab1d88","line":21,"updated":"2016-03-08 04:09:20.000000000","message":"Need to also add DocImpact flag because its adding a config option.","commit_id":"6da619afbe766855af0c2a59fa1a145bf20fba7d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"04ce843cd42d5c21b47c594c0b512d1f14a0ce49","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The code for fetching the pagination links is hard coded to use"},{"line_number":10,"context_line":"WebOb\u0027s Request path_url property."},{"line_number":11,"context_line":"In a setup where a proxy is used to forward requests to neutron"},{"line_number":12,"context_line":"nodes, the href shown to the requesting tenant does not match the"},{"line_number":13,"context_line":"one the client made the request against."},{"line_number":14,"context_line":"This change adds a configuration variable \u0027pagination_url\u0027 that\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_caa2f298","line":11,"updated":"2016-03-09 12:31:44.000000000","message":"It seems we don\u0027t need this change because you can use the middleware HTTPProxyToWSGI(1] to solve this trouble.\n\nMoreover this change handles only pagination urls but path_url is also used in version urls (at least).\n\n\n[1] oslo.middleware.http_proxy_to_wsgi","commit_id":"eb9c70f53626be1cd0776386a74f567fbc386660"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"cd5662ba36bee505f0ebb662575c663ab783a107","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This change adds a configuration variable \u0027pagination_url\u0027 that\u0027s"},{"line_number":15,"context_line":"used in place of teh request.path_url if defined."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Closes-Bug: #1483873"},{"line_number":19,"context_line":"Change-Id: Ie3c83594607080ffa80a672d773ce3bfbc7fd1cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_555cd5ec","line":17,"updated":"2016-03-09 09:09:39.000000000","message":"DocImpact now requires a short description of what needs to be documented.  In this case its the config option so you need to add a short description of the config option.","commit_id":"eb9c70f53626be1cd0776386a74f567fbc386660"}],"neutron/api/api_common.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"576b27e31b9bed02997e9c5825c225283c488598","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    pagination_url \u003d cfg.CONF.pagination_url"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if len(pagination_url) \u003d\u003d 0:"},{"line_number":73,"context_line":"        path_url \u003d request.path_url"},{"line_number":74,"context_line":"    else:"},{"line_number":75,"context_line":"        path_url \u003d \u0027%s%s\u0027 % (pagination_url, request.path)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_2c75c4f8","line":72,"range":{"start_line":72,"start_character":4,"end_line":72,"end_character":32},"updated":"2016-03-08 04:58:04.000000000","message":"Use just \"if pagination_url:\".","commit_id":"6da619afbe766855af0c2a59fa1a145bf20fba7d"}],"neutron/tests/unit/api/v2/test_base.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7455396baac61d3452f7f5b8bb6272e42f3c5d0c","unresolved":false,"context_lines":[{"line_number":525,"context_line":"        scheme \u003d \u0027https\u0027"},{"line_number":526,"context_line":"        netloc \u003d \u0027not-so-localhost:1337\u0027"},{"line_number":527,"context_line":"        path \u003d \u0027/networks\u0027"},{"line_number":528,"context_line":"        cfg.CONF.set_default(\u0027pagination_url\u0027, \u0027%s://%s\u0027 % (scheme, netloc))"},{"line_number":529,"context_line":"        instance \u003d self.plugin.return_value"},{"line_number":530,"context_line":"        instance.get_networks.return_value \u003d []"},{"line_number":531,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_11faa5bd","line":528,"updated":"2016-03-08 04:09:20.000000000","message":"use cfg.CONF.set_override","commit_id":"6da619afbe766855af0c2a59fa1a145bf20fba7d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"576b27e31b9bed02997e9c5825c225283c488598","unresolved":false,"context_lines":[{"line_number":536,"context_line":""},{"line_number":537,"context_line":"        for link in res.json[\u0027networks_links\u0027]:"},{"line_number":538,"context_line":"            url \u003d urlparse.urlparse(link[\u0027href\u0027])"},{"line_number":539,"context_line":"            self.assertEqual(url.scheme, scheme)"},{"line_number":540,"context_line":"            self.assertEqual(url.netloc, netloc)"},{"line_number":541,"context_line":"            self.assertEqual(url.path, path)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"# Note: since all resources use the same controller and validation"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_0c03a843","line":541,"range":{"start_line":539,"start_character":12,"end_line":541,"end_character":44},"updated":"2016-03-08 04:58:04.000000000","message":"Use the pattern \"self.assertEqual(expected, observed)\"","commit_id":"6da619afbe766855af0c2a59fa1a145bf20fba7d"}]}