)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"76a6a63406c6ff24df865f99f588ac8699855529","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Also change the help text to specify the effect of setting"},{"line_number":22,"context_line":"min_l3_agents_per_router more clearly."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I8a5fc74a96c784d474aefe2d9b27eeb66521ca82"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_0f922cf6","line":23,"updated":"2016-03-09 12:12:53.000000000","message":"You should reference the associated bug:\n\n Closes-Bug: #1555042","commit_id":"c6466252dc1c002e85181623e46c2fbe742472a1"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c4d024b4b9e3060dcc50b22263d3518a21b0bca1","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            raise l3_ha.HAMaximumAgentsNumberNotValid("},{"line_number":178,"context_line":"                max_agents\u003dmax_agents, min_agents\u003dmin_agents)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if min_agents \u003c 1:"},{"line_number":181,"context_line":"            raise l3_ha.HAMinimumAgentsNumberNotValid()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_7d0481bf","line":180,"range":{"start_line":180,"start_character":24,"end_line":180,"end_character":25},"updated":"2016-03-08 15:25:28.000000000","message":"Instead of replacing the constant (constants.MINIMUM_AGENTS_FOR_HA) with a magic number (1), why not just update the constant to be the value 1?","commit_id":"307ddbf5ccbfcb4e0d821863b2a867f051458339"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1ca141ee128e4be36935176fe8837a9f02e26bf2","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            raise l3_ha.HAMaximumAgentsNumberNotValid("},{"line_number":178,"context_line":"                max_agents\u003dmax_agents, min_agents\u003dmin_agents)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if min_agents \u003c 1:"},{"line_number":181,"context_line":"            raise l3_ha.HAMinimumAgentsNumberNotValid()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_f8b09fdf","line":180,"in_reply_to":"5aef4532_7d0481bf","updated":"2016-03-08 15:47:13.000000000","message":"Because the constant is also used for setting the default value and having a default of 2 doesn\u0027t seem unreasonable in general. One could make two constants out of this, like ALLOWED_MINIMUM_AGENTS_FOR_HA and DEFAULT_MINIMUM_AGENTS_FOR_HA but I\u0027m not sure whether that would be helpful.","commit_id":"307ddbf5ccbfcb4e0d821863b2a867f051458339"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"cb1052d2ca6896f4c9f4a0f5b1d05b4d512efc1b","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            raise l3_ha.HAMaximumAgentsNumberNotValid("},{"line_number":178,"context_line":"                max_agents\u003dmax_agents, min_agents\u003dmin_agents)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if min_agents \u003c 1:"},{"line_number":181,"context_line":"            raise l3_ha.HAMinimumAgentsNumberNotValid()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_85a92f7e","line":180,"in_reply_to":"5aef4532_f8b09fdf","updated":"2016-03-08 16:48:44.000000000","message":"2 constants make a lot of sense here. How about:\n1) Changing MINIMUM_AGENTS_FOR_HA\u003d1\n2) Adding a new DEFAULT_AGENTS_FOR_HA\u003d2","commit_id":"307ddbf5ccbfcb4e0d821863b2a867f051458339"}]}