)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Firewall as a Service (FWaaS) APIs and DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint quantum-fwaas"},{"line_number":10,"context_line":"blueprint: quantum-fwaas-plugin"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is the first iteration of the FWaaS implementation and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAPn%2F%2F9k0%3D","line":9,"updated":"2013-06-17 13:29:42.000000000","message":"newline after implements wll help reader understand you\u0027re implementing two blueprints.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Firewall as a Service (FWaaS) APIs and DB Model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint quantum-fwaas"},{"line_number":10,"context_line":"blueprint: quantum-fwaas-plugin"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is the first iteration of the FWaaS implementation and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAPn%2F%2FtvI%3D","line":9,"in_reply_to":"AAAAPn%2F%2F9k0%3D","updated":"2013-06-24 17:08:52.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"* application/service objects"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Unit test coverage is not complete and tests are being constantly"},{"line_number":22,"context_line":"added."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I57a62d6e9d3f1e6c4dd44cd5c745710a3d9e488e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAPn%2F%2F9ks%3D","line":22,"updated":"2013-06-17 13:29:42.000000000","message":"Should I expect to find patches dependent on this with the other unit tests?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"* application/service objects"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Unit test coverage is not complete and tests are being constantly"},{"line_number":22,"context_line":"added."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I57a62d6e9d3f1e6c4dd44cd5c745710a3d9e488e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAPn%2F%2FtvA%3D","line":22,"in_reply_to":"AAAAPn%2F%2F9ks%3D","updated":"2013-06-24 17:08:52.000000000","message":"Unit tests will be in this patch.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"}],"etc/policy.json":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"create_firewall_rule:shared\": \"rule:admin_or_owner\","},{"line_number":76,"context_line":"    \"get_firewall_rule:shared\": \"rule:admin_or_owner\","},{"line_number":77,"context_line":"    \"update_firewall_rule\": \"rule:admin_or_owner\","},{"line_number":78,"context_line":"    \"delete_firewall_rule\": \"rule:admin_or_owner\","},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    \"create_service_type\": \"rule:admin_only\","},{"line_number":81,"context_line":"    \"update_service_type\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":9,"id":"AAAAPn%2F%2F9lQ%3D","line":78,"updated":"2013-06-17 13:29:42.000000000","message":"nit: all the rules with admin_or_owner can be removed, as the the default policy is admin_or_owner.\n\nthis unless the goal is to explicitly have an admin_or_owner rule regardless of what the default rule is","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    \"create_firewall_rule:shared\": \"rule:admin_or_owner\","},{"line_number":76,"context_line":"    \"get_firewall_rule:shared\": \"rule:admin_or_owner\","},{"line_number":77,"context_line":"    \"update_firewall_rule\": \"rule:admin_or_owner\","},{"line_number":78,"context_line":"    \"delete_firewall_rule\": \"rule:admin_or_owner\","},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    \"create_service_type\": \"rule:admin_only\","},{"line_number":81,"context_line":"    \"update_service_type\": \"rule:admin_only\","}],"source_content_type":"application/json","patch_set":9,"id":"AAAAPn%2F%2Ftuo%3D","line":78,"in_reply_to":"AAAAPn%2F%2F9lQ%3D","updated":"2013-06-24 17:08:52.000000000","message":"Thanks for that input. Yeah, I thought explicitly stating might be good, makes it easier to read and understand what is the actual policy.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"get_firewall_policy\": \"rule:admin_or_owner\","},{"line_number":67,"context_line":"    \"create_firewall_policy:shared\": \"rule:admin_or_owner\","},{"line_number":68,"context_line":"    \"get_firewall_policy:shared\": \"rule:admin_or_owner\","},{"line_number":69,"context_line":"    \"get_firewall_policy:audited\": \"rule:admin_or_owner\","},{"line_number":70,"context_line":"    \"update_firewall_policy\": \"rule:admin_or_owner\","},{"line_number":71,"context_line":"    \"delete_firewall_policy\": \"rule:admin_or_owner\","},{"line_number":72,"context_line":""}],"source_content_type":"application/json","patch_set":19,"id":"AAAAPn%2F%2FecU%3D","line":69,"updated":"2013-07-01 07:23:32.000000000","message":"Policies for shared and audited are same as get_firewall_policy, so they aren\u0027t needed in this case. If it is a usual case where shared or audited have different policies from get_firewall_policy, it is reasonable to define them explicitly.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"get_firewall_policy\": \"rule:admin_or_owner\","},{"line_number":67,"context_line":"    \"create_firewall_policy:shared\": \"rule:admin_or_owner\","},{"line_number":68,"context_line":"    \"get_firewall_policy:shared\": \"rule:admin_or_owner\","},{"line_number":69,"context_line":"    \"get_firewall_policy:audited\": \"rule:admin_or_owner\","},{"line_number":70,"context_line":"    \"update_firewall_policy\": \"rule:admin_or_owner\","},{"line_number":71,"context_line":"    \"delete_firewall_policy\": \"rule:admin_or_owner\","},{"line_number":72,"context_line":""}],"source_content_type":"application/json","patch_set":19,"id":"AAAAPn%2F%2FZsQ%3D","line":69,"in_reply_to":"AAAAPn%2F%2FecU%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"}],"neutron/db/firewall/__init__.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmJk%3D","line":3,"updated":"2013-07-26 21:07:47.000000000","message":"You\u0027ve won today\u0027s share of my pedantry!\n\nThere\u0027s a missing line here: \u0027all rights reserved\u0027","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmAQ%3D","line":3,"in_reply_to":"AAAAQn%2F%2FmJk%3D","updated":"2013-07-26 23:16:23.000000000","message":"Done","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"}],"neutron/db/firewall/firewall_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":169,"context_line":"                    # the following implementation is inefficient"},{"line_number":170,"context_line":"                    # because it makes one DB fetch for every rule"},{"line_number":171,"context_line":"                    # in the system"},{"line_number":172,"context_line":"                    rules_in_db[fwrule_id] \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":173,"context_line":"                except exc.NoResultFound:"},{"line_number":174,"context_line":"                    # If we find an invalid rule in the list we"},{"line_number":175,"context_line":"                    # do not perform the update since this breaks"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fu0Y%3D","line":172,"updated":"2013-07-12 10:00:07.000000000","message":"It should be not hard to build a filter to load all rules.\nAnd you can still raise firewallrulenotfound while checking fetched rules vs ids in filter\n\nneutron performance will thank you a lot for this.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":169,"context_line":"                    # the following implementation is inefficient"},{"line_number":170,"context_line":"                    # because it makes one DB fetch for every rule"},{"line_number":171,"context_line":"                    # in the system"},{"line_number":172,"context_line":"                    rules_in_db[fwrule_id] \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":173,"context_line":"                except exc.NoResultFound:"},{"line_number":174,"context_line":"                    # If we find an invalid rule in the list we"},{"line_number":175,"context_line":"                    # do not perform the update since this breaks"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fq9k%3D","line":172,"in_reply_to":"AAAAP3%2F%2Fu0Y%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":371,"context_line":"        insert_before \u003d True"},{"line_number":372,"context_line":"        ref_firewall_rule_id \u003d None"},{"line_number":373,"context_line":"        if \u0027firewall_rule_id\u0027 in rule_info:"},{"line_number":374,"context_line":"            firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":375,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":376,"context_line":"            insert_before \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":377,"context_line":"        if \u0027reference_firewall_rule_id\u0027 in rule_info:"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2FoQ0%3D","line":374,"updated":"2013-07-15 16:56:59.000000000","message":"it seems we should fail if this is missing (we\u0027ll fail anyway at line 381 - but it you fail here you\u0027ll save db ops (the one for reading the policy - and the one that fails)","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        insert_before \u003d True"},{"line_number":372,"context_line":"        ref_firewall_rule_id \u003d None"},{"line_number":373,"context_line":"        if \u0027firewall_rule_id\u0027 in rule_info:"},{"line_number":374,"context_line":"            firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":375,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":376,"context_line":"            insert_before \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":377,"context_line":"        if \u0027reference_firewall_rule_id\u0027 in rule_info:"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2Fnp0%3D","line":374,"in_reply_to":"AAAAP3%2F%2FoQ0%3D","updated":"2013-07-15 19:40:46.000000000","message":"Done","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":375,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":376,"context_line":"            insert_before \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":377,"context_line":"        if \u0027reference_firewall_rule_id\u0027 in rule_info:"},{"line_number":378,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027reference_firewall_rule_id\u0027]"},{"line_number":379,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":380,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":381,"context_line":"            fwr_db \u003d self._get_firewall_rule(context, firewall_rule_id)"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2FoQM%3D","line":378,"updated":"2013-07-15 16:56:59.000000000","message":"API suggestiong:\nconsider doing\n\ninsert_before: rule_id\ninsert_after: rule_id\n\nwith the two attrs mutually exclusive.\n\nThis looks simpler, imho.","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":376,"context_line":"            insert_before \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":377,"context_line":"        if \u0027reference_firewall_rule_id\u0027 in rule_info:"},{"line_number":378,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027reference_firewall_rule_id\u0027]"},{"line_number":379,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":380,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":381,"context_line":"            fwr_db \u003d self._get_firewall_rule(context, firewall_rule_id)"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2Fnpw%3D","line":378,"in_reply_to":"AAAAP3%2F%2FoQM%3D","updated":"2013-07-15 19:40:46.000000000","message":"Nice suggestion, done.","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":383,"context_line":"                raise firewall.FirewallRuleInUse(firewall_rule_id\u003dfwr_db[\u0027id\u0027])"},{"line_number":384,"context_line":"            if ref_firewall_rule_id:"},{"line_number":385,"context_line":"                # If reference_firewall_rule_id is set, the new rule"},{"line_number":386,"context_line":"                # the new rule is inserted depending on the value of"},{"line_number":387,"context_line":"                # insert_before. If insert_before is True, the new rule"},{"line_number":388,"context_line":"                # is inserted before reference_firewall_rule_id, and if"},{"line_number":389,"context_line":"                # it is False is inserted after reference_firewall_rule_id."}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2FoRI%3D","line":386,"updated":"2013-07-15 16:56:59.000000000","message":"\"the new rule\" twice in the comment","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                raise firewall.FirewallRuleInUse(firewall_rule_id\u003dfwr_db[\u0027id\u0027])"},{"line_number":384,"context_line":"            if ref_firewall_rule_id:"},{"line_number":385,"context_line":"                # If reference_firewall_rule_id is set, the new rule"},{"line_number":386,"context_line":"                # the new rule is inserted depending on the value of"},{"line_number":387,"context_line":"                # insert_before. If insert_before is True, the new rule"},{"line_number":388,"context_line":"                # is inserted before reference_firewall_rule_id, and if"},{"line_number":389,"context_line":"                # it is False is inserted after reference_firewall_rule_id."}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2Fnps%3D","line":386,"in_reply_to":"AAAAP3%2F%2FoRI%3D","updated":"2013-07-15 19:40:46.000000000","message":"Done","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":406,"context_line":"        LOG.debug(_(\"remove_rule() called\"))"},{"line_number":407,"context_line":"        firewall_rule_id \u003d None"},{"line_number":408,"context_line":"        if \u0027firewall_rule_id\u0027 in rule_info:"},{"line_number":409,"context_line":"            firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":410,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":411,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":412,"context_line":"            fwr_db \u003d self._get_firewall_rule(context, firewall_rule_id)"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2FoQA%3D","line":409,"updated":"2013-07-15 16:56:59.000000000","message":"fail here if missing firewall_rule_id is missing.","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        LOG.debug(_(\"remove_rule() called\"))"},{"line_number":407,"context_line":"        firewall_rule_id \u003d None"},{"line_number":408,"context_line":"        if \u0027firewall_rule_id\u0027 in rule_info:"},{"line_number":409,"context_line":"            firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":410,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":411,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":412,"context_line":"            fwr_db \u003d self._get_firewall_rule(context, firewall_rule_id)"}],"source_content_type":"text/x-python","patch_set":35,"id":"AAAAP3%2F%2Fnpo%3D","line":409,"in_reply_to":"AAAAP3%2F%2FoQA%3D","updated":"2013-07-15 19:40:46.000000000","message":"Done","commit_id":"335b9134175c7339e8e09d9b88bbfe233fe3d577"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(24))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fkew%3D","line":47,"updated":"2013-07-16 14:01:00.000000000","message":"securty groups defines this as a 40 char field.  Ideally both fields should be the same size.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(24))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fih0%3D","line":47,"in_reply_to":"AAAAP3%2F%2Fkew%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fkes%3D","line":51,"updated":"2013-07-16 14:01:00.000000000","message":"Why are these strings instead of integers?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fgrc%3D","line":51,"in_reply_to":"AAAAP3%2F%2Fifc%3D","updated":"2013-07-17 06:12:46.000000000","message":"The notion of port ranges is quite in line with multiple vendors in specifying ACLs/Firewall rules. Albeit each one has a subtle variation. This would be consistent with that.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fifc%3D","line":51,"in_reply_to":"AAAAP3%2F%2Fkes%3D","updated":"2013-07-16 22:27:43.000000000","message":"We needed a way to represent, both a single port, and also a port range. We decided to follow the well understood/established convention used by Iptables to use the following format:\nSingle port: String or Integer, e.g. 8800\nPort range: \"p1:p2\" where 0 \u003c int(p1) \u003c\u003d int(p2) \u003c 65535\nThe up side of this approach is that we don\u0027t have to do additional processing before passing it to the reference Iptables implementation, and also that this convention is familiar to operators.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"},{"line_number":55,"context_line":"    position \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fkek%3D","line":52,"updated":"2013-07-16 14:01:00.000000000","message":"same question","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"},{"line_number":55,"context_line":"    position \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FifU%3D","line":52,"in_reply_to":"AAAAP3%2F%2Fkek%3D","updated":"2013-07-16 22:27:43.000000000","message":"Ditto","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"class Firewall(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":59,"context_line":"    \"\"\"Represents a Firewall resource.\"\"\""},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027firewalls\u0027"},{"line_number":61,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":62,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":63,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":64,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkeU%3D","line":61,"updated":"2013-07-16 14:01:00.000000000","message":"The name column for other models are 255 chars long. Why are these shorter?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":58,"context_line":"class Firewall(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":59,"context_line":"    \"\"\"Represents a Firewall resource.\"\"\""},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027firewalls\u0027"},{"line_number":61,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":62,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":63,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":64,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FidY%3D","line":61,"in_reply_to":"AAAAP3%2F%2Fjds%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done, I changed the name to be a longer String.\n\nBased on talking to some of the vendor folks, there was a need for a larger string to capture longer annotation. Hence I would prefer to keep the description field, unless there is strong disagreement. Also, description is being used in other resources as well.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"class Firewall(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":59,"context_line":"    \"\"\"Represents a Firewall resource.\"\"\""},{"line_number":60,"context_line":"    __tablename__ \u003d \u0027firewalls\u0027"},{"line_number":61,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":62,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":63,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":64,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fjds%3D","line":61,"in_reply_to":"AAAAP3%2F%2FkeU%3D","updated":"2013-07-16 16:38:17.000000000","message":"My request or my fault.\nI proposed to reduce the name size because we already had the description attribute.\n\nIt probably was not a very wise recommendation. Consistency across data models should have priority (hence probably the description attribute should go)","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":74,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":75,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":76,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":77,"context_line":"    firewall_rules \u003d orm.relationship(FirewallRule,"},{"line_number":78,"context_line":"                                      backref\u003dorm.backref(\u0027firewall_policies\u0027,"},{"line_number":79,"context_line":"                                                          cascade\u003d"},{"line_number":80,"context_line":"                                                          \u0027all, delete\u0027),"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkeM%3D","line":77,"updated":"2013-07-16 14:01:00.000000000","message":"Please format so that the text is not so right justified\n\n    firewall_rules \u003d orm.relationship(\n        FirewallRule,\n        backref\u003dorm.backref(\u0027firewall_policies\u0027, cascade\u003d\u0027all, delete\u0027),\n        order_by\u003d\u0027FirewallRule.position\u0027,\n        collection_class\u003dordering_list(\u0027position\u0027, count_from\u003d1)\n    )","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":75,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":76,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":77,"context_line":"    firewall_rules \u003d orm.relationship(FirewallRule,"},{"line_number":78,"context_line":"                                      backref\u003dorm.backref(\u0027firewall_policies\u0027,"},{"line_number":79,"context_line":"                                                          cascade\u003d"},{"line_number":80,"context_line":"                                                          \u0027all, delete\u0027),"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fgws%3D","line":77,"in_reply_to":"AAAAP3%2F%2Ficc%3D","updated":"2013-07-17 06:00:06.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":75,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":76,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":77,"context_line":"    firewall_rules \u003d orm.relationship(FirewallRule,"},{"line_number":78,"context_line":"                                      backref\u003dorm.backref(\u0027firewall_policies\u0027,"},{"line_number":79,"context_line":"                                                          cascade\u003d"},{"line_number":80,"context_line":"                                                          \u0027all, delete\u0027),"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Ficc%3D","line":77,"in_reply_to":"AAAAP3%2F%2FkeM%3D","updated":"2013-07-16 22:27:43.000000000","message":"I tried changing the way you suggest, but I get:\n\n  /opt/stack/tox-neutron$ /opt/stack/tox-neutron/.tox/pep8/bin/flake8\n./neutron/db/firewall/firewall_db.py:78:13: E128 continuation line under-indented for visual indent\n            backref\u003dorm.backref(\u0027firewall_policies\u0027, cascade\u003d\u0027all, delete\u0027),\n            ^","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2Fg2w%3D","line":51,"updated":"2013-07-17 05:01:20.000000000","message":"If we\u0027re aiming at consistency in data model representation source_port and destination_port should be split in \u0027min\u0027 and \u0027max\u0027 fields of type integer as the security groups db model does.\n\nBesides having an easy way for translating the field into a component of an iptables rule, I don\u0027t know if there is any other reasons for having a field which could a port or a port range.\n\nI\u0027m adding this comment just to say that probably Mark\u0027s comment has not been fully addressed here.","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":6995,"name":"Sridar Kandaswamy","email":"skandasw@yahoo.com","username":"skandasw"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2Fgqw%3D","line":51,"in_reply_to":"AAAAP3%2F%2Fg2w%3D","updated":"2013-07-17 06:13:00.000000000","message":"The notion of port ranges is quite in line with multiple vendors in specifying ACLs/Firewall rules. Albeit each one has a subtle variation. This would be consistent with that.","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":7752,"name":"Rajesh Mohan","email":"rajesh.mlists@gmail.com","username":"rajesh.mohan"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2FgMY%3D","line":51,"in_reply_to":"AAAAP3%2F%2Fgqw%3D","updated":"2013-07-17 09:23:36.000000000","message":"I agree with Sridar. Use of \u0027:\u0027 or \u0027-\u0027 for ranges is common.","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":50,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(46))"},{"line_number":51,"context_line":"    source_port \u003d sa.Column(sa.String(12))"},{"line_number":52,"context_line":"    destination_port \u003d sa.Column(sa.String(12))"},{"line_number":53,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"},{"line_number":54,"context_line":"    enabled \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2FgU8%3D","line":51,"in_reply_to":"AAAAP3%2F%2Fgqw%3D","updated":"2013-07-17 08:33:33.000000000","message":"Yes, as I mentioned in my earlier comment in patch 39, talking to some of the vendors it seemed that this format for port/range was generally more acceptable. The reason for adopting this convention is not because it is less work to translate in code. To  reiterate, it follows an established convention. I appreciate the concern to be consistent, and in this case I think we should be consistent with conventions in the firewall world not necessarily how it\u0027s done in security groups.","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                  cascade\u003d\u0027all, delete\u0027),"},{"line_number":81,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":82,"context_line":"                                      collection_class\u003d"},{"line_number":83,"context_line":"                                      ordering_list(\u0027position\u0027, count_from\u003d1))"},{"line_number":84,"context_line":"    audited \u003d sa.Column(sa.Boolean)"},{"line_number":85,"context_line":"    firewalls \u003d orm.relationship(Firewall, backref\u003d\u0027firewall_policies\u0027)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2Fg2s%3D","line":83,"updated":"2013-07-17 05:01:20.000000000","message":"It\u0027s strange you had the issue you reported while refactoring the code.\n\nI tried that and pep8 does not complain. But this is not important, I guess.","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                                                  cascade\u003d\u0027all, delete\u0027),"},{"line_number":81,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":82,"context_line":"                                      collection_class\u003d"},{"line_number":83,"context_line":"                                      ordering_list(\u0027position\u0027, count_from\u003d1))"},{"line_number":84,"context_line":"    audited \u003d sa.Column(sa.Boolean)"},{"line_number":85,"context_line":"    firewalls \u003d orm.relationship(Firewall, backref\u003d\u0027firewall_policies\u0027)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2Fgv8%3D","line":83,"in_reply_to":"AAAAP3%2F%2Fg2s%3D","updated":"2013-07-17 08:33:33.000000000","message":"Done","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"unresolved":false,"context_lines":[{"line_number":375,"context_line":"        firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":376,"context_line":"        insert_before \u003d True"},{"line_number":377,"context_line":"        ref_firewall_rule_id \u003d None"},{"line_number":378,"context_line":"        if \u0027firewall_rule_id\u0027 in rule_info:"},{"line_number":379,"context_line":"            firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":380,"context_line":"        if not firewall_rule_id:"},{"line_number":381,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003dNone)"}],"source_content_type":"text/x-python","patch_set":41,"id":"AAAAP3%2F%2Ffjk%3D","line":378,"updated":"2013-07-17 13:32:01.000000000","message":"Line 375 and 378-379 seem problematic.\n\n375 will throw a KeyError, if no rule id. Then 378 tests for the same thing. Seems like 375 should be removed.","commit_id":"0428f7f8e4f5257b2ef84f87e70745cc64fe2cae"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":376,"context_line":"        insert_before \u003d True"},{"line_number":377,"context_line":"        ref_firewall_rule_id \u003d None"},{"line_number":378,"context_line":"        if \u0027firewall_rule_id\u0027 in rule_info:"},{"line_number":379,"context_line":"            firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"},{"line_number":380,"context_line":"        if not firewall_rule_id:"},{"line_number":381,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003dNone)"}],"source_content_type":"text/x-python","patch_set":41,"id":"AAAAP3%2F%2Fees%3D","line":378,"in_reply_to":"AAAAP3%2F%2Ffjk%3D","updated":"2013-07-17 17:28:14.000000000","message":"Done, 378 - 379 was redundant.","commit_id":"0428f7f8e4f5257b2ef84f87e70745cc64fe2cae"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"unresolved":false,"context_lines":[{"line_number":381,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003dNone)"},{"line_number":382,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":383,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":384,"context_line":"        # If insert_before is set, we will ignore insert_after."},{"line_number":385,"context_line":"        if not ref_firewall_rule_id and \u0027insert_after\u0027 in rule_info:"},{"line_number":386,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_after\u0027]"},{"line_number":387,"context_line":"            insert_before \u003d False"}],"source_content_type":"text/x-python","patch_set":41,"id":"AAAAP3%2F%2FfjQ%3D","line":384,"updated":"2013-07-17 13:32:01.000000000","message":"Here, could we just say...\n\nelif \u0027insert_after\u0027 in rule_info:\n    ref_firewall_rule_id \u003d ...\n\nIOW, if there is an insert_before, does that guarantee that we\u0027ll have a rule ID? If so, then the else clause could be used.","commit_id":"0428f7f8e4f5257b2ef84f87e70745cc64fe2cae"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":381,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003dNone)"},{"line_number":382,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":383,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":384,"context_line":"        # If insert_before is set, we will ignore insert_after."},{"line_number":385,"context_line":"        if not ref_firewall_rule_id and \u0027insert_after\u0027 in rule_info:"},{"line_number":386,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_after\u0027]"},{"line_number":387,"context_line":"            insert_before \u003d False"}],"source_content_type":"text/x-python","patch_set":41,"id":"AAAAP3%2F%2Feeg%3D","line":384,"in_reply_to":"AAAAP3%2F%2FfjQ%3D","updated":"2013-07-17 17:28:14.000000000","message":"Actually I cannot use elif/else here. I also need to check for the case where insert_before key is present and but value is None. The following check for conditions achieves.","commit_id":"0428f7f8e4f5257b2ef84f87e70745cc64fe2cae"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":43,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2FylI%3D","line":45,"updated":"2013-07-23 08:09:50.000000000","message":"One rule is owned by one policy?","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":43,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2Fwxw%3D","line":45,"in_reply_to":"AAAAQn%2F%2FylI%3D","updated":"2013-07-23 17:55:42.000000000","message":"Yes.","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2Fyks%3D","line":46,"updated":"2013-07-23 08:09:50.000000000","message":"If one rule is owned by one policy, what purpose of the shared field? Admin creates a shared rule, then it is able to be used only by one policy!","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2Fwxc%3D","line":46,"in_reply_to":"AAAAQn%2F%2Fyks%3D","updated":"2013-07-23 17:55:42.000000000","message":"The purpose of the share attribute is so that the entity which creates the rule does not have to be the entity which uses that rule in a policy.","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":156,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":157,"context_line":"        return self._fields(res, fields)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_db, rule_id_list):"},{"line_number":160,"context_line":"        fwp_db \u003d firewall_policy_db"},{"line_number":161,"context_line":"        if not rule_id_list:"},{"line_number":162,"context_line":"            fwp_db.firewall_rules \u003d []"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2FykE%3D","line":159,"updated":"2013-07-23 08:09:50.000000000","message":"_add_rules_to_policy -\u003e _set_policy_rules?","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":157,"context_line":"        return self._fields(res, fields)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_db, rule_id_list):"},{"line_number":160,"context_line":"        fwp_db \u003d firewall_policy_db"},{"line_number":161,"context_line":"        if not rule_id_list:"},{"line_number":162,"context_line":"            fwp_db.firewall_rules \u003d []"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2FwxA%3D","line":159,"in_reply_to":"AAAAQn%2F%2FykE%3D","updated":"2013-07-23 17:55:42.000000000","message":"The current name is probably preferable since it\u0027s more descriptive.","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if not rule_id_list:"},{"line_number":162,"context_line":"            fwp_db.firewall_rules \u003d []"},{"line_number":163,"context_line":"            fwp_db.audited \u003d False"},{"line_number":164,"context_line":"            return"},{"line_number":165,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":166,"context_line":"            # We will first check if the new list of rules is valid"},{"line_number":167,"context_line":"            filters \u003d {\u0027id\u0027: [r_id for r_id in rule_id_list]}"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2Fykc%3D","line":164,"updated":"2013-07-23 08:09:50.000000000","message":"line 161-164 are not useful if they are not in a db session.","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        if not rule_id_list:"},{"line_number":162,"context_line":"            fwp_db.firewall_rules \u003d []"},{"line_number":163,"context_line":"            fwp_db.audited \u003d False"},{"line_number":164,"context_line":"            return"},{"line_number":165,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":166,"context_line":"            # We will first check if the new list of rules is valid"},{"line_number":167,"context_line":"            filters \u003d {\u0027id\u0027: [r_id for r_id in rule_id_list]}"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2Fww8%3D","line":164,"in_reply_to":"AAAAQn%2F%2Fykc%3D","updated":"2013-07-23 17:55:42.000000000","message":"Done","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":182,"context_line":"            fwp_db.firewall_rules \u003d []"},{"line_number":183,"context_line":"            for fwrule_id in rule_id_list:"},{"line_number":184,"context_line":"                fwp_db.firewall_rules.append(rules_dict[fwrule_id])"},{"line_number":185,"context_line":"            fwp_db.audited \u003d False"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def _insert_rule_in_policy(self, context, firewall_policy_db,"},{"line_number":188,"context_line":"                               firewall_rule_db, position):"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2FykY%3D","line":185,"updated":"2013-07-23 08:09:50.000000000","message":"why do we need to change fwp_db.audited?","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            fwp_db.firewall_rules \u003d []"},{"line_number":183,"context_line":"            for fwrule_id in rule_id_list:"},{"line_number":184,"context_line":"                fwp_db.firewall_rules.append(rules_dict[fwrule_id])"},{"line_number":185,"context_line":"            fwp_db.audited \u003d False"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def _insert_rule_in_policy(self, context, firewall_policy_db,"},{"line_number":188,"context_line":"                               firewall_rule_db, position):"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2FwuY%3D","line":185,"in_reply_to":"AAAAQn%2F%2FykY%3D","updated":"2013-07-23 17:55:42.000000000","message":"Once the firewall policy changes, it needs to re-audited by the auditing entity. This is intentionally an explicit operation.","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":379,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003dNone)"},{"line_number":380,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":381,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":382,"context_line":"        if not ref_firewall_rule_id and \u0027insert_after\u0027 in rule_info:"},{"line_number":383,"context_line":"            # If insert_before is set, we will ignore insert_after."},{"line_number":384,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_after\u0027]"},{"line_number":385,"context_line":"            insert_before \u003d False"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2FyeA%3D","line":382,"updated":"2013-07-23 08:09:50.000000000","message":"else insert_after in rule_info?","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003dNone)"},{"line_number":380,"context_line":"        if \u0027insert_before\u0027 in rule_info:"},{"line_number":381,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_before\u0027]"},{"line_number":382,"context_line":"        if not ref_firewall_rule_id and \u0027insert_after\u0027 in rule_info:"},{"line_number":383,"context_line":"            # If insert_before is set, we will ignore insert_after."},{"line_number":384,"context_line":"            ref_firewall_rule_id \u003d rule_info[\u0027insert_after\u0027]"},{"line_number":385,"context_line":"            insert_before \u003d False"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2FwuE%3D","line":382,"in_reply_to":"AAAAQn%2F%2FyeA%3D","updated":"2013-07-23 17:55:42.000000000","message":"If ref_firewall_rule_is is set, it was because insert_before was set, so we will ignore insert_after (see the following comment).","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":410,"context_line":"            return self._insert_rule_in_policy(context, fwp_db, fwr_db,"},{"line_number":411,"context_line":"                                               position)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def remove_rule(self, context, id, rule_info):"},{"line_number":414,"context_line":"        LOG.debug(_(\"remove_rule() called\"))"},{"line_number":415,"context_line":"        self._validate_insert_remove_rule_request(id, rule_info)"},{"line_number":416,"context_line":"        firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2Fydo%3D","line":413,"updated":"2013-07-23 08:09:50.000000000","message":"why not just rule_id?","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            return self._insert_rule_in_policy(context, fwp_db, fwr_db,"},{"line_number":411,"context_line":"                                               position)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def remove_rule(self, context, id, rule_info):"},{"line_number":414,"context_line":"        LOG.debug(_(\"remove_rule() called\"))"},{"line_number":415,"context_line":"        self._validate_insert_remove_rule_request(id, rule_info)"},{"line_number":416,"context_line":"        firewall_rule_id \u003d rule_info[\u0027firewall_rule_id\u0027]"}],"source_content_type":"text/x-python","patch_set":44,"id":"AAAAQn%2F%2Fwt4%3D","line":413,"in_reply_to":"AAAAQn%2F%2Fydo%3D","updated":"2013-07-23 17:55:42.000000000","message":"We wanted to keep this consistent with the add_rule API. It\u0027s much easier for the users that way.","commit_id":"8c99ec117638f0e62ebab8bcf72fc1beda74085b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2Fr9U%3D","line":46,"updated":"2013-07-25 01:58:43.000000000","message":"I don\u0027t think we should keep the \u0027shared\u0027 since one rule is only used by one policy. IMO, there is no need for one tenant to create an once-used rule for another tenant.\n\nneutron network has shared field because after it, all other tenant can use the network at the same time. glance has \u0027shared\u0027 image, because all other tenants can use it at the same time.","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                                   sa.ForeignKey(\u0027firewall_policies.id\u0027),"},{"line_number":45,"context_line":"                                   nullable\u003dTrue)"},{"line_number":46,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":47,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":48,"context_line":"    ip_version \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":49,"context_line":"    source_ip_address \u003d sa.Column(sa.String(46))"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2FptE%3D","line":46,"in_reply_to":"AAAAQn%2F%2Fr9U%3D","updated":"2013-07-26 03:23:09.000000000","message":"The use case that is being addressed here is that the rules and policies can be created by different entities. Without the \u0027shared\u0027 attributed the rules (needing to be shared) would not be visible to the entity which is creating the policy.\n\nWe have had this discussion in the earlier patches.","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":156,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":157,"context_line":"        return self._fields(res, fields)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_db, rule_id_list):"},{"line_number":160,"context_line":"        fwp_db \u003d firewall_policy_db"},{"line_number":161,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":162,"context_line":"            if not rule_id_list:"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2Fr9w%3D","line":159,"updated":"2013-07-25 01:58:43.000000000","message":"_add_rules_to_policy will also mean to keep the existing rules of policy.\nIf we use _set_policy_rules, which is obvious to set the rules of the policy into the wanted rules. So I think we should use _set_policy_rules","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":157,"context_line":"        return self._fields(res, fields)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_db, rule_id_list):"},{"line_number":160,"context_line":"        fwp_db \u003d firewall_policy_db"},{"line_number":161,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":162,"context_line":"            if not rule_id_list:"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2Fptw%3D","line":159,"in_reply_to":"AAAAQn%2F%2Fr9w%3D","updated":"2013-07-26 03:23:09.000000000","message":"Done","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":202,"context_line":"            fwp_db.firewall_rules.remove(firewall_rule_db)"},{"line_number":203,"context_line":"            fwp_db.firewall_rules.reorder()"},{"line_number":204,"context_line":"            fwp_db.audited \u003d False"},{"line_number":205,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_firewall(self, context, firewall):"},{"line_number":208,"context_line":"        LOG.debug(_(\"create_firewall() called\"))"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2Fr9E%3D","line":205,"updated":"2013-07-25 01:58:43.000000000","message":"we should use _make_firewall_policy_with_rules_dict so that user can see the result of _remove_rule_from policy.","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            fwp_db.firewall_rules.remove(firewall_rule_db)"},{"line_number":203,"context_line":"            fwp_db.firewall_rules.reorder()"},{"line_number":204,"context_line":"            fwp_db.audited \u003d False"},{"line_number":205,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_firewall(self, context, firewall):"},{"line_number":208,"context_line":"        LOG.debug(_(\"create_firewall() called\"))"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2Fptg%3D","line":205,"in_reply_to":"AAAAQn%2F%2Fr9E%3D","updated":"2013-07-26 03:23:09.000000000","message":"_make_firewall_policy_dict already has a firewall_rules attribute with the updated list after removal. What you are requesting is already happening.","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":407,"context_line":"                # So default insertion is always at the top."},{"line_number":408,"context_line":"                # Also note that position numbering starts at 1."},{"line_number":409,"context_line":"                position \u003d 1"},{"line_number":410,"context_line":"            return self._insert_rule_in_policy(context, fwp_db, fwr_db,"},{"line_number":411,"context_line":"                                               position)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def remove_rule(self, context, id, rule_info):"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2Fr8Y%3D","line":410,"updated":"2013-07-25 01:58:43.000000000","message":"imagine two threads running into here at the same time, what will happen? they will have the same position","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                # So default insertion is always at the top."},{"line_number":408,"context_line":"                # Also note that position numbering starts at 1."},{"line_number":409,"context_line":"                position \u003d 1"},{"line_number":410,"context_line":"            return self._insert_rule_in_policy(context, fwp_db, fwr_db,"},{"line_number":411,"context_line":"                                               position)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def remove_rule(self, context, id, rule_info):"}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2Fozo%3D","line":410,"in_reply_to":"AAAAQn%2F%2Fr8Y%3D","updated":"2013-07-26 03:23:09.000000000","message":"Added db lock to take care of this case.","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"               \u0027source_ip_address\u0027: firewall_rule[\u0027source_ip_address\u0027],"},{"line_number":158,"context_line":"               \u0027destination_ip_address\u0027:"},{"line_number":159,"context_line":"               firewall_rule[\u0027destination_ip_address\u0027],"},{"line_number":160,"context_line":"               \u0027source_port\u0027: src_port_range,"},{"line_number":161,"context_line":"               \u0027destination_port\u0027: dst_port_range,"},{"line_number":162,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027],"},{"line_number":163,"context_line":"               \u0027position\u0027: position,"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeU0%3D","line":160,"updated":"2013-07-30 17:17:39.000000000","message":"if this returns a range wouldn\u0027t be clearer to label it \u0027source_port_range\u0027? What\u0027s the advantage of collapsing the two attributes into one? The DB already stores these separately and I guess they would still need to be handled separately, so does it really make sense doing the extra processing to combine them?","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":157,"context_line":"               \u0027source_ip_address\u0027: firewall_rule[\u0027source_ip_address\u0027],"},{"line_number":158,"context_line":"               \u0027destination_ip_address\u0027:"},{"line_number":159,"context_line":"               firewall_rule[\u0027destination_ip_address\u0027],"},{"line_number":160,"context_line":"               \u0027source_port\u0027: src_port_range,"},{"line_number":161,"context_line":"               \u0027destination_port\u0027: dst_port_range,"},{"line_number":162,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027],"},{"line_number":163,"context_line":"               \u0027position\u0027: position,"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd6I%3D","line":160,"in_reply_to":"AAAAQn%2F%2FeU0%3D","updated":"2013-07-30 18:06:54.000000000","message":"This is to be consistent with the input API.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":"               \u0027destination_ip_address\u0027:"},{"line_number":159,"context_line":"               firewall_rule[\u0027destination_ip_address\u0027],"},{"line_number":160,"context_line":"               \u0027source_port\u0027: src_port_range,"},{"line_number":161,"context_line":"               \u0027destination_port\u0027: dst_port_range,"},{"line_number":162,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027],"},{"line_number":163,"context_line":"               \u0027position\u0027: position,"},{"line_number":164,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeUw%3D","line":161,"updated":"2013-07-30 17:17:39.000000000","message":"ditto","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               \u0027destination_ip_address\u0027:"},{"line_number":159,"context_line":"               firewall_rule[\u0027destination_ip_address\u0027],"},{"line_number":160,"context_line":"               \u0027source_port\u0027: src_port_range,"},{"line_number":161,"context_line":"               \u0027destination_port\u0027: dst_port_range,"},{"line_number":162,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027],"},{"line_number":163,"context_line":"               \u0027position\u0027: position,"},{"line_number":164,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd6E%3D","line":161,"in_reply_to":"AAAAQn%2F%2FeUw%3D","updated":"2013-07-30 18:06:54.000000000","message":"Ditto.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def _get_min_max_ports_from_range(self, port_range):"},{"line_number":212,"context_line":"        if not port_range:"},{"line_number":213,"context_line":"            return [None, None]"},{"line_number":214,"context_line":"        ports \u003d port_range.split(\u0027:\u0027)"},{"line_number":215,"context_line":"        ports[0] \u003d int(ports[0])"},{"line_number":216,"context_line":"        if len(ports) \u003c 2:"},{"line_number":217,"context_line":"            ports.append(ports[0])"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FfSc%3D","line":214,"updated":"2013-07-30 11:32:23.000000000","message":"You could do...\n\nmin_port, sep, max_port \u003d port_range.partition(\":\")\nif not max_port:\n    max_port \u003d min_port\nreturn [int(min_port), int(max_port)]","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def _get_min_max_ports_from_range(self, port_range):"},{"line_number":212,"context_line":"        if not port_range:"},{"line_number":213,"context_line":"            return [None, None]"},{"line_number":214,"context_line":"        ports \u003d port_range.split(\u0027:\u0027)"},{"line_number":215,"context_line":"        ports[0] \u003d int(ports[0])"},{"line_number":216,"context_line":"        if len(ports) \u003c 2:"},{"line_number":217,"context_line":"            ports.append(ports[0])"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd5A%3D","line":214,"in_reply_to":"AAAAQn%2F%2Feu8%3D","updated":"2013-07-30 18:06:54.000000000","message":"Bug filed to track this:\nhttps://bugs.launchpad.net/neutron/+bug/1206620","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":211,"context_line":"    def _get_min_max_ports_from_range(self, port_range):"},{"line_number":212,"context_line":"        if not port_range:"},{"line_number":213,"context_line":"            return [None, None]"},{"line_number":214,"context_line":"        ports \u003d port_range.split(\u0027:\u0027)"},{"line_number":215,"context_line":"        ports[0] \u003d int(ports[0])"},{"line_number":216,"context_line":"        if len(ports) \u003c 2:"},{"line_number":217,"context_line":"            ports.append(ports[0])"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Feu8%3D","line":214,"in_reply_to":"AAAAQn%2F%2FfSc%3D","updated":"2013-07-30 14:48:17.000000000","message":"Let\u0027s merge this and follow up with a small clean-up patch to use partition here an the fix below.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":225,"context_line":"        if min_port \u003d\u003d max_port:"},{"line_number":226,"context_line":"            return str(min_port)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            return str(min_port) + \u0027:\u0027 + str(max_port)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def create_firewall(self, context, firewall):"},{"line_number":231,"context_line":"        LOG.debug(_(\"create_firewall() called\"))"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Feus%3D","line":228,"updated":"2013-07-30 14:48:17.000000000","message":"In a follow up patch..\n\nreturn \u0027%d:%d\u0027 % (min_port, max_port)","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        if min_port \u003d\u003d max_port:"},{"line_number":226,"context_line":"            return str(min_port)"},{"line_number":227,"context_line":"        else:"},{"line_number":228,"context_line":"            return str(min_port) + \u0027:\u0027 + str(max_port)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def create_firewall(self, context, firewall):"},{"line_number":231,"context_line":"        LOG.debug(_(\"create_firewall() called\"))"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd48%3D","line":228,"in_reply_to":"AAAAQn%2F%2Feus%3D","updated":"2013-07-30 18:06:54.000000000","message":"https://bugs.launchpad.net/neutron/+bug/1206620","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"}],"neutron/db/migration/alembic_migrations/versions/39cf3f799352_fwaas_havana_2_model.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    op.create_table(\u0027firewall_policies\u0027,"},{"line_number":55,"context_line":"                    sa.Column(\u0027tenant_id\u0027, mysql.VARCHAR(length\u003d255),"},{"line_number":56,"context_line":"                              nullable\u003dTrue),"},{"line_number":57,"context_line":"                    sa.Column(\u0027id\u0027, mysql.VARCHAR(length\u003d36), nullable\u003dFalse),"},{"line_number":58,"context_line":"                    sa.Column(\u0027name\u0027, mysql.VARCHAR(length\u003d64),"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAP3%2F%2Fybc%3D","line":55,"updated":"2013-07-11 13:49:25.000000000","message":"Why not to use sqlalchemy types? sa.String, etc?","commit_id":"b9de3688b46c8869a27fcf497e44fa7b3a85e4a0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    op.create_table(\u0027firewall_policies\u0027,"},{"line_number":55,"context_line":"                    sa.Column(\u0027tenant_id\u0027, mysql.VARCHAR(length\u003d255),"},{"line_number":56,"context_line":"                              nullable\u003dTrue),"},{"line_number":57,"context_line":"                    sa.Column(\u0027id\u0027, mysql.VARCHAR(length\u003d36), nullable\u003dFalse),"},{"line_number":58,"context_line":"                    sa.Column(\u0027name\u0027, mysql.VARCHAR(length\u003d64),"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAP3%2F%2Fx3I%3D","line":55,"in_reply_to":"AAAAP3%2F%2Fybc%3D","updated":"2013-07-11 15:46:22.000000000","message":"Done, thanks for catching!","commit_id":"b9de3688b46c8869a27fcf497e44fa7b3a85e4a0"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"                              nullable\u003dTrue),"},{"line_number":59,"context_line":"                    sa.Column(\u0027description\u0027, sa.String(length\u003d1024),"},{"line_number":60,"context_line":"                              nullable\u003dTrue),"},{"line_number":61,"context_line":"                    sa.Column(\u0027shared\u0027, sa.Boolean(display_width\u003d1),"},{"line_number":62,"context_line":"                              autoincrement\u003dFalse, nullable\u003dTrue),"},{"line_number":63,"context_line":"                    sa.Column(\u0027audited\u0027, sa.Boolean(display_width\u003d1),"},{"line_number":64,"context_line":"                              autoincrement\u003dFalse, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fu20%3D","line":61,"updated":"2013-07-12 10:00:07.000000000","message":"display_width is being used to set the length to mysql default value, so perhaps it is not necessary.\n\nafaik, display_width is also understood by mysql only. These migrations are instead supposed to be used by any db (well, postgresql at least)","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                              nullable\u003dTrue),"},{"line_number":59,"context_line":"                    sa.Column(\u0027description\u0027, sa.String(length\u003d1024),"},{"line_number":60,"context_line":"                              nullable\u003dTrue),"},{"line_number":61,"context_line":"                    sa.Column(\u0027shared\u0027, sa.Boolean(display_width\u003d1),"},{"line_number":62,"context_line":"                              autoincrement\u003dFalse, nullable\u003dTrue),"},{"line_number":63,"context_line":"                    sa.Column(\u0027audited\u0027, sa.Boolean(display_width\u003d1),"},{"line_number":64,"context_line":"                              autoincrement\u003dFalse, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fq1s%3D","line":61,"in_reply_to":"AAAAP3%2F%2Fu20%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done, thanks for catching this.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    op.create_table(\u0027firewall_policies\u0027,"},{"line_number":54,"context_line":"                    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255),"},{"line_number":55,"context_line":"                              nullable\u003dTrue),"},{"line_number":56,"context_line":"                    sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":57,"context_line":"                    sa.Column(\u0027name\u0027, sa.String(length\u003d64),"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fkdw%3D","line":54,"updated":"2013-07-16 14:01:00.000000000","message":"I\u0027d remove reformat so that sa.Column is only 4 spaces indented from the parent line.  This will make the code more readable.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    op.create_table(\u0027firewall_policies\u0027,"},{"line_number":54,"context_line":"                    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255),"},{"line_number":55,"context_line":"                              nullable\u003dTrue),"},{"line_number":56,"context_line":"                    sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":57,"context_line":"                    sa.Column(\u0027name\u0027, sa.String(length\u003d64),"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fgwo%3D","line":54,"in_reply_to":"AAAAP3%2F%2FibE%3D","updated":"2013-07-17 06:00:06.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    op.create_table(\u0027firewall_policies\u0027,"},{"line_number":54,"context_line":"                    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255),"},{"line_number":55,"context_line":"                              nullable\u003dTrue),"},{"line_number":56,"context_line":"                    sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":57,"context_line":"                    sa.Column(\u0027name\u0027, sa.String(length\u003d64),"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FibE%3D","line":54,"in_reply_to":"AAAAP3%2F%2Fkdw%3D","updated":"2013-07-16 22:27:43.000000000","message":"I tried doing this but pep8 does not seem to like it:\npep8 runtests: commands[0]\n  /opt/stack/tox-neutron$ /opt/stack/tox-neutron/.tox/pep8/bin/flake8\n./neutron/db/migration/alembic_migrations/versions/39cf3f799352_fwaas_havana_2_model.py:54:9: E128 continuation line under-indented for visual indent\n        sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),\n        ^","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if not migration.should_run(active_plugin, migration_for_plugins):"},{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    op.create_table(\u0027firewall_policies\u0027,"},{"line_number":54,"context_line":"                    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255),"},{"line_number":55,"context_line":"                              nullable\u003dTrue),"},{"line_number":56,"context_line":"                    sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2Fg2g%3D","line":53,"updated":"2013-07-17 05:01:20.000000000","message":"re pep8 issue on Mark\u0027s comment.\nI tried that and works fine for me.\n\nop.create_table(\n    \u0027firewall_policies\u0027,\n    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255), nullable\u003dTrue),\n...\n...","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if not migration.should_run(active_plugin, migration_for_plugins):"},{"line_number":51,"context_line":"        return"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    op.create_table(\u0027firewall_policies\u0027,"},{"line_number":54,"context_line":"                    sa.Column(\u0027tenant_id\u0027, sa.String(length\u003d255),"},{"line_number":55,"context_line":"                              nullable\u003dTrue),"},{"line_number":56,"context_line":"                    sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2FgwA%3D","line":53,"in_reply_to":"AAAAP3%2F%2Fg2g%3D","updated":"2013-07-17 08:33:33.000000000","message":"Done","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# revision identifiers, used by Alembic."},{"line_number":27,"context_line":"revision \u003d \u002739cf3f799352\u0027"},{"line_number":28,"context_line":"down_revision \u003d \u0027b7a8863760e\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmM4%3D","line":28,"updated":"2013-07-26 21:07:47.000000000","message":"I think the latest revision at the moment is: e6b16a30d97","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# revision identifiers, used by Alembic."},{"line_number":27,"context_line":"revision \u003d \u002739cf3f799352\u0027"},{"line_number":28,"context_line":"down_revision \u003d \u0027b7a8863760e\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmAI%3D","line":28,"in_reply_to":"AAAAQn%2F%2FmM4%3D","updated":"2013-07-26 23:16:23.000000000","message":"Done","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"}],"neutron/extensions/firewall.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # firewall_policy resource. For proper XML serialization"},{"line_number":296,"context_line":"        # and deserialization of the list elements we need to add the"},{"line_number":297,"context_line":"        # the following to list of plurals."},{"line_number":298,"context_line":"        my_plurals.append((\u0027firewall_rule_list\u0027, \u0027firewall_rule\u0027))"},{"line_number":299,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":300,"context_line":"        resources \u003d []"},{"line_number":301,"context_line":"        plugin \u003d manager.NeutronManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fuzo%3D","line":298,"updated":"2013-07-12 10:00:07.000000000","message":"which is another way to say you\u0027re deviating from the standard :)\n\nYou already explained that you believe this is more clear. My objection is about having a uniform API throughout the project.\n\nIf you are not willing to reconsider it won\u0027t be a major issue for me.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # firewall_policy resource. For proper XML serialization"},{"line_number":296,"context_line":"        # and deserialization of the list elements we need to add the"},{"line_number":297,"context_line":"        # the following to list of plurals."},{"line_number":298,"context_line":"        my_plurals.append((\u0027firewall_rule_list\u0027, \u0027firewall_rule\u0027))"},{"line_number":299,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":300,"context_line":"        resources \u003d []"},{"line_number":301,"context_line":"        plugin \u003d manager.NeutronManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fq0M%3D","line":298,"in_reply_to":"AAAAP3%2F%2Fuzo%3D","updated":"2013-07-14 19:51:19.000000000","message":"I changed it to firewall_rules.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":96,"context_line":"def convert_protocol(value):"},{"line_number":97,"context_line":"    if value is None:"},{"line_number":98,"context_line":"        return"},{"line_number":99,"context_line":"    try:"},{"line_number":100,"context_line":"        val \u003d int(value)"},{"line_number":101,"context_line":"        if 0 \u003c\u003d val \u003c\u003d 255:"},{"line_number":102,"context_line":"            return val"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkZ4%3D","line":99,"updated":"2013-07-16 14:01:00.000000000","message":"Consider replacing 99-112 with:\n\nif value.isdigit():\n   value \u003d int(value)\n   if 0 \u003c\u003d val \u003c\u003d 255:\n       return val\nelif value.lower() in fw_valid_protocol_values:\n   return value.lower()\nelse:\n    raise FirewallRuleInvalidProtocol(\n        protocol\u003dvalue, values\u003dfw_valid_protocol_values)","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":96,"context_line":"def convert_protocol(value):"},{"line_number":97,"context_line":"    if value is None:"},{"line_number":98,"context_line":"        return"},{"line_number":99,"context_line":"    try:"},{"line_number":100,"context_line":"        val \u003d int(value)"},{"line_number":101,"context_line":"        if 0 \u003c\u003d val \u003c\u003d 255:"},{"line_number":102,"context_line":"            return val"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiYc%3D","line":99,"in_reply_to":"AAAAP3%2F%2FkZ4%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done. I used your suggestion, but I had to change slightly to raise an exception if val \u003c0 or val \u003e 255.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":116,"context_line":"    if value is None:"},{"line_number":117,"context_line":"        return"},{"line_number":118,"context_line":"    try:"},{"line_number":119,"context_line":"        return value.lower()"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkZE%3D","line":116,"updated":"2013-07-16 14:01:00.000000000","message":"if value is None:\n    return\nelse:\n    return value.lower()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":116,"context_line":"    if value is None:"},{"line_number":117,"context_line":"        return"},{"line_number":118,"context_line":"    try:"},{"line_number":119,"context_line":"        return value.lower()"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiXY%3D","line":116,"in_reply_to":"AAAAP3%2F%2FkZE%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":127,"context_line":"        return"},{"line_number":128,"context_line":"    try:"},{"line_number":129,"context_line":"        return str(value)"},{"line_number":130,"context_line":"    except AttributeError:"},{"line_number":131,"context_line":"        raise FirewallInvalidPortValue(port\u003dvalue)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2Fkcc%3D","line":130,"updated":"2013-07-16 14:01:00.000000000","message":"str() does not raise an AttributeError.  This except should be removed.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        return"},{"line_number":128,"context_line":"    try:"},{"line_number":129,"context_line":"        return str(value)"},{"line_number":130,"context_line":"    except AttributeError:"},{"line_number":131,"context_line":"        raise FirewallInvalidPortValue(port\u003dvalue)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiTc%3D","line":130,"in_reply_to":"AAAAP3%2F%2Fkcc%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":131,"context_line":"        raise FirewallInvalidPortValue(port\u003dvalue)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def _validate_port_range(data, key_specs\u003dNone):"},{"line_number":135,"context_line":"    if data is None:"},{"line_number":136,"context_line":"        return"},{"line_number":137,"context_line":"    data \u003d str(data)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkYo%3D","line":134,"updated":"2013-07-16 14:01:00.000000000","message":"key_specs is unused... why do we need it?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        raise FirewallInvalidPortValue(port\u003dvalue)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def _validate_port_range(data, key_specs\u003dNone):"},{"line_number":135,"context_line":"    if data is None:"},{"line_number":136,"context_line":"        return"},{"line_number":137,"context_line":"    data \u003d str(data)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiR4%3D","line":134,"in_reply_to":"AAAAP3%2F%2FkYo%3D","updated":"2013-07-16 22:27:43.000000000","message":"The validation framework requires this argument to be present.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":154,"context_line":"        return None"},{"line_number":155,"context_line":"    msg_ip \u003d attr._validate_ip_address(data, valid_values)"},{"line_number":156,"context_line":"    if not msg_ip:"},{"line_number":157,"context_line":"        return msg_ip"},{"line_number":158,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":159,"context_line":"    if not msg_subnet:"},{"line_number":160,"context_line":"        return msg_subnet"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkYE%3D","line":157,"updated":"2013-07-16 14:01:00.000000000","message":"why not return None here?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        return None"},{"line_number":155,"context_line":"    msg_ip \u003d attr._validate_ip_address(data, valid_values)"},{"line_number":156,"context_line":"    if not msg_ip:"},{"line_number":157,"context_line":"        return msg_ip"},{"line_number":158,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":159,"context_line":"    if not msg_subnet:"},{"line_number":160,"context_line":"        return msg_subnet"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiUA%3D","line":157,"in_reply_to":"AAAAP3%2F%2FkYE%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"        return msg_ip"},{"line_number":158,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":159,"context_line":"    if not msg_subnet:"},{"line_number":160,"context_line":"        return msg_subnet"},{"line_number":161,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkYA%3D","line":160,"updated":"2013-07-16 14:01:00.000000000","message":"Same as above?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        return msg_ip"},{"line_number":158,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":159,"context_line":"    if not msg_subnet:"},{"line_number":160,"context_line":"        return msg_subnet"},{"line_number":161,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiT4%3D","line":160,"in_reply_to":"AAAAP3%2F%2FkYA%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":159,"context_line":"    if not msg_subnet:"},{"line_number":160,"context_line":"        return msg_subnet"},{"line_number":161,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"attr.validators[\u0027type:port_range\u0027] \u003d _validate_port_range"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkX0%3D","line":161,"updated":"2013-07-16 14:01:00.000000000","message":"This error message does not make sense.","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":159,"context_line":"    if not msg_subnet:"},{"line_number":160,"context_line":"        return msg_subnet"},{"line_number":161,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"attr.validators[\u0027type:port_range\u0027] \u003d _validate_port_range"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiUM%3D","line":161,"in_reply_to":"AAAAP3%2F%2FkX0%3D","updated":"2013-07-16 22:27:43.000000000","message":"The actual error message will show up as:\n\n\"\u003cip\u003e is not a valid IP address and \u003csubnet\u003e is not a valid IP subnet\".\n\nAlso validated in the tests test_extension_firewall.py:test_validate_ip_or_subnet_or_none()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return None"},{"line_number":153,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":154,"context_line":"    if not msg_subnet:"},{"line_number":155,"context_line":"        return None"},{"line_number":156,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2Fg10%3D","line":155,"updated":"2013-07-17 05:01:20.000000000","message":"Probably when mark said you can return none he meant to use just the return statement, as the None after that is pleonastic.","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        return None"},{"line_number":153,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":154,"context_line":"    if not msg_subnet:"},{"line_number":155,"context_line":"        return None"},{"line_number":156,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2FgwM%3D","line":155,"in_reply_to":"AAAAP3%2F%2Fg10%3D","updated":"2013-07-17 08:33:33.000000000","message":"Done","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":153,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":154,"context_line":"    if not msg_subnet:"},{"line_number":155,"context_line":"        return None"},{"line_number":156,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"attr.validators[\u0027type:port_range\u0027] \u003d _validate_port_range"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2Fg2E%3D","line":156,"updated":"2013-07-17 05:01:20.000000000","message":"consider\n\n%(msg_ip)s and %(msg_subnet)s","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    msg_subnet \u003d attr._validate_subnet(data, valid_values)"},{"line_number":154,"context_line":"    if not msg_subnet:"},{"line_number":155,"context_line":"        return None"},{"line_number":156,"context_line":"    return _(\"%(ip)s and %(subnet)s\") % {\u0027ip\u0027: msg_ip, \u0027subnet\u0027: msg_subnet}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"attr.validators[\u0027type:port_range\u0027] \u003d _validate_port_range"}],"source_content_type":"text/x-python","patch_set":40,"id":"AAAAP3%2F%2FgwI%3D","line":156,"in_reply_to":"AAAAP3%2F%2Fg2E%3D","updated":"2013-07-17 08:33:33.000000000","message":"Done","commit_id":"81d2ab8e9b0b1694c675ec35d683fa9f9fd51c35"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":116,"context_line":"    if value is None:"},{"line_number":117,"context_line":"        return"},{"line_number":118,"context_line":"    else:"},{"line_number":119,"context_line":"        return value.lower()"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmR0%3D","line":116,"updated":"2013-07-26 21:07:47.000000000","message":"Sorry if this has been noted already in other patchset.\nIs the comparison with None necessary?\nEg.: any reason for which we should hit the other branch when an empty string is passed?","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":116,"context_line":"    if value is None:"},{"line_number":117,"context_line":"        return"},{"line_number":118,"context_line":"    else:"},{"line_number":119,"context_line":"        return value.lower()"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmAg%3D","line":116,"in_reply_to":"AAAAQn%2F%2FmR0%3D","updated":"2013-07-26 23:16:23.000000000","message":"We want to differentiate between the case when the user does not specify this argument (and hence the default needs to be used), and the one where in the user actually passes an empty string.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def convert_port_to_string(value):"},{"line_number":123,"context_line":"    if value is None:"},{"line_number":124,"context_line":"        return"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        return str(value)"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmRw%3D","line":123,"updated":"2013-07-26 21:07:47.000000000","message":"same as above","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"def convert_port_to_string(value):"},{"line_number":123,"context_line":"    if value is None:"},{"line_number":124,"context_line":"        return"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        return str(value)"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmAc%3D","line":123,"in_reply_to":"AAAAQn%2F%2FmRw%3D","updated":"2013-07-26 23:16:23.000000000","message":"Addressed in the earlier comment.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":141,"context_line":"        if val \u003c\u003d 0 or val \u003e 65535:"},{"line_number":142,"context_line":"            msg \u003d _(\"Invalid port \u0027%s\u0027\") % p"},{"line_number":143,"context_line":"            LOG.debug(msg)"},{"line_number":144,"context_line":"            return msg"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"def _validate_ip_or_subnet_or_none(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmNU%3D","line":144,"updated":"2013-07-26 21:07:47.000000000","message":"Is there a need to check that the first item of the range is less than the second?\n\neg: 2000:1000 should be an invalid range?","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        if val \u003c\u003d 0 or val \u003e 65535:"},{"line_number":142,"context_line":"            msg \u003d _(\"Invalid port \u0027%s\u0027\") % p"},{"line_number":143,"context_line":"            LOG.debug(msg)"},{"line_number":144,"context_line":"            return msg"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"def _validate_ip_or_subnet_or_none(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmAY%3D","line":144,"in_reply_to":"AAAAQn%2F%2FmNU%3D","updated":"2013-07-26 23:16:23.000000000","message":"Yes, we want to treat that as an invalid range.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                   \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":200,"context_line":"        \u0027source_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":201,"context_line":"                        \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":202,"context_line":"                        \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":203,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":204,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":205,"context_line":"                             \u0027validate\u0027: {\u0027type:port_range\u0027: None},"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmQg%3D","line":202,"updated":"2013-07-26 21:07:47.000000000","message":"quick question: why allow_put would be true for addresses and false for port ranges?","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                   \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":200,"context_line":"        \u0027source_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":201,"context_line":"                        \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":202,"context_line":"                        \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":203,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":204,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":205,"context_line":"                             \u0027validate\u0027: {\u0027type:port_range\u0027: None},"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmAw%3D","line":202,"in_reply_to":"AAAAQn%2F%2FmQg%3D","updated":"2013-07-26 23:16:23.000000000","message":"Good catch, I have fixed this to allow_put for ports as well.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":205,"context_line":"                             \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":206,"context_line":"                             \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":207,"context_line":"                             \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":208,"context_line":"        \u0027position\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":209,"context_line":"                     \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":210,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmRA%3D","line":207,"updated":"2013-07-26 21:07:47.000000000","message":"the security group API uses port_range_min, port_range_max attributes.\n\nI think this has been noted in other patchsets, perhaps on the db side, but I did not read any answer which might justify divergence from the security group API.\n\nWhat is the reason for acting differently on the firewall API?","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":205,"context_line":"                             \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":206,"context_line":"                             \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":207,"context_line":"                             \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":208,"context_line":"        \u0027position\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":209,"context_line":"                     \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":210,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmAk%3D","line":207,"in_reply_to":"AAAAQn%2F%2FmRA%3D","updated":"2013-07-26 23:16:23.000000000","message":"I did respond to the earlier comments on this. I am paraphrasing those in the top level response to these comments.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"    message \u003d _(\"Firewall %(firewall_id)s is still active.\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class FirewallInPendingState(qexception.Conflict):"},{"line_number":47,"context_line":"    message \u003d _(\"Operation cannot be performed since associated Firewall \""},{"line_number":48,"context_line":"                \"%(firewall_id)s is in %(pending_state)s.\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeSY%3D","line":46,"updated":"2013-07-30 17:17:39.000000000","message":"Wouldn\u0027t it be more extensible to have an exception FirewallStateConflict and let the message specify the state, e.g. pending, error, etc.?","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    message \u003d _(\"Firewall %(firewall_id)s is still active.\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class FirewallInPendingState(qexception.Conflict):"},{"line_number":47,"context_line":"    message \u003d _(\"Operation cannot be performed since associated Firewall \""},{"line_number":48,"context_line":"                \"%(firewall_id)s is in %(pending_state)s.\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd84%3D","line":46,"in_reply_to":"AAAAQn%2F%2FeSY%3D","updated":"2013-07-30 18:06:54.000000000","message":"This message does provide the details of the pending state.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class FirewallRuleInfoMissing(qexception.InvalidInput):"},{"line_number":88,"context_line":"    message \u003d _(\"Missing rule info argument for insert/remove \""},{"line_number":89,"context_line":"                \"rule opertaion.\")"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"fw_valid_protocol_values \u003d [None, constants.TCP, constants.UDP, constants.ICMP]"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeSQ%3D","line":89,"updated":"2013-07-30 17:17:39.000000000","message":"grammar nit.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class FirewallRuleInfoMissing(qexception.InvalidInput):"},{"line_number":88,"context_line":"    message \u003d _(\"Missing rule info argument for insert/remove \""},{"line_number":89,"context_line":"                \"rule opertaion.\")"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"fw_valid_protocol_values \u003d [None, constants.TCP, constants.UDP, constants.ICMP]"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd80%3D","line":89,"in_reply_to":"AAAAQn%2F%2FeSQ%3D","updated":"2013-07-30 18:06:54.000000000","message":"Thanks, I will fix this in a follow up patch.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"                                                 \u0027msg_subnet\u0027: msg_subnet}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"attr.validators[\u0027type:port_range\u0027] \u003d _validate_port_range"},{"line_number":161,"context_line":"attr.validators[\u0027type:ip_or_subnet_or_none\u0027] \u003d _validate_ip_or_subnet_or_none"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeQ0%3D","line":160,"updated":"2013-07-30 17:17:39.000000000","message":"Suggestion: I would \u0027promote\u0027 this validator to be part of the other validators. I would also consider data to be in both representations (min, max) or \"min:max\"","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                                                 \u0027msg_subnet\u0027: msg_subnet}"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"attr.validators[\u0027type:port_range\u0027] \u003d _validate_port_range"},{"line_number":161,"context_line":"attr.validators[\u0027type:ip_or_subnet_or_none\u0027] \u003d _validate_ip_or_subnet_or_none"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd8I%3D","line":160,"in_reply_to":"AAAAQn%2F%2FeQ0%3D","updated":"2013-07-30 18:06:54.000000000","message":"Yes, we can do that, but once this is being used by another extension or core resource. currently this is only being used here, and it\u0027s easier to manage (delete if not required) if it\u0027s here.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                   \u0027validate\u0027: {\u0027type:ip_or_subnet_or_none\u0027:"},{"line_number":198,"context_line":"                                                None},"},{"line_number":199,"context_line":"                                   \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":200,"context_line":"        \u0027source_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":201,"context_line":"                        \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":202,"context_line":"                        \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":203,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeQg%3D","line":200,"updated":"2013-07-30 17:17:39.000000000","message":"once again, if this is a range I find it potentially confusing to call it source_port.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                   \u0027validate\u0027: {\u0027type:ip_or_subnet_or_none\u0027:"},{"line_number":198,"context_line":"                                                None},"},{"line_number":199,"context_line":"                                   \u0027is_visible\u0027: True, \u0027default\u0027: None},"},{"line_number":200,"context_line":"        \u0027source_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":201,"context_line":"                        \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":202,"context_line":"                        \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":203,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd7Y%3D","line":200,"in_reply_to":"AAAAQn%2F%2FeQg%3D","updated":"2013-07-30 18:06:54.000000000","message":"One can provide a single port or a range. Did not want to say range since it implies always providing a range, this way it\u0027s sufficiently open ended.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":202,"context_line":"                        \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":203,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":204,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":205,"context_line":"                             \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":206,"context_line":"                             \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":207,"context_line":"                             \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeQY%3D","line":204,"updated":"2013-07-30 17:17:39.000000000","message":"so for this one.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                        \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":202,"context_line":"                        \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":203,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":204,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":205,"context_line":"                             \u0027validate\u0027: {\u0027type:port_range\u0027: None},"},{"line_number":206,"context_line":"                             \u0027convert_to\u0027: convert_port_to_string,"},{"line_number":207,"context_line":"                             \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd7U%3D","line":204,"in_reply_to":"AAAAQn%2F%2FeQY%3D","updated":"2013-07-30 18:06:54.000000000","message":"Ditto","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"firewall_quota_opts \u003d ["},{"line_number":274,"context_line":"    cfg.IntOpt(\u0027quota_firewall\u0027,"},{"line_number":275,"context_line":"               default\u003d1,"},{"line_number":276,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant, -1 for \u0027"},{"line_number":277,"context_line":"                      \u0027unlimited\u0027)),"},{"line_number":278,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FeP8%3D","line":275,"updated":"2013-07-30 17:17:39.000000000","message":"isn\u0027t 1 \u0027too\u0027 limited for being the default value? I can certainly see one case where it is: during debugging cycles :)","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"firewall_quota_opts \u003d ["},{"line_number":274,"context_line":"    cfg.IntOpt(\u0027quota_firewall\u0027,"},{"line_number":275,"context_line":"               default\u003d1,"},{"line_number":276,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant, -1 for \u0027"},{"line_number":277,"context_line":"                      \u0027unlimited\u0027)),"},{"line_number":278,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd6s%3D","line":275,"in_reply_to":"AAAAQn%2F%2FeP8%3D","updated":"2013-07-30 18:06:54.000000000","message":"Since we don\u0027t have a service insertion model, we apply the firewall to all the routers (in the agent/driver implementation). Hence, one can have one firewall per tenant in this iteration of implementation, and this default reflects that.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":275,"context_line":"               default\u003d1,"},{"line_number":276,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant, -1 for \u0027"},{"line_number":277,"context_line":"                      \u0027unlimited\u0027)),"},{"line_number":278,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"},{"line_number":279,"context_line":"               default\u003d1,"},{"line_number":280,"context_line":"               help\u003d_(\u0027Number of firewall policies allowed per tenant, -1 \u0027"},{"line_number":281,"context_line":"                      \u0027for unlimited\u0027)),"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2FePs%3D","line":278,"updated":"2013-07-30 17:17:39.000000000","message":"so would this one?","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":275,"context_line":"               default\u003d1,"},{"line_number":276,"context_line":"               help\u003d_(\u0027Number of firewalls allowed per tenant, -1 for \u0027"},{"line_number":277,"context_line":"                      \u0027unlimited\u0027)),"},{"line_number":278,"context_line":"    cfg.IntOpt(\u0027quota_firewall_policy\u0027,"},{"line_number":279,"context_line":"               default\u003d1,"},{"line_number":280,"context_line":"               help\u003d_(\u0027Number of firewall policies allowed per tenant, -1 \u0027"},{"line_number":281,"context_line":"                      \u0027for unlimited\u0027)),"}],"source_content_type":"text/x-python","patch_set":51,"id":"AAAAQn%2F%2Fd6k%3D","line":278,"in_reply_to":"AAAAQn%2F%2FePs%3D","updated":"2013-07-30 18:06:54.000000000","message":"Ditto.","commit_id":"a5a88c7ed30deea47a4e1f63bb29523bc0af36d0"}],"neutron/services/firewall/fwaas_plugin.py":[{"author":{"_account_id":6641,"name":"Ravi Chunduru","email":"ravivsn@gmail.com","username":"ravivsn"},"unresolved":false,"context_lines":[{"line_number":218,"context_line":"            self._make_firewall_dict_with_rules(context, fw[\u0027id\u0027]))"},{"line_number":219,"context_line":"        self.agent_rpc.delete_firewall(context, fw_with_rules)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"},{"line_number":222,"context_line":"        fwp \u003d super(FirewallPlugin,"},{"line_number":223,"context_line":"                    self).update_firewall_policy(context, id, firewall_policy)"},{"line_number":224,"context_line":"        self._rpc_update_firewall_policy(context, id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2F0dg%3D","line":221,"updated":"2013-07-10 23:05:15.000000000","message":"I think we should add some validations to avoid un-necessary update of firewall rules in the policy such as \n1) Duplicate firewall rule in the rule-list\n2) the new rule list is same as old rule list in order and rule-ids","commit_id":"c7c6c641f3b229e71a942f7cffdab4d05bb1b4a6"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            self._make_firewall_dict_with_rules(context, fw[\u0027id\u0027]))"},{"line_number":219,"context_line":"        self.agent_rpc.delete_firewall(context, fw_with_rules)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"},{"line_number":222,"context_line":"        fwp \u003d super(FirewallPlugin,"},{"line_number":223,"context_line":"                    self).update_firewall_policy(context, id, firewall_policy)"},{"line_number":224,"context_line":"        self._rpc_update_firewall_policy(context, id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FzXo%3D","line":221,"in_reply_to":"AAAAP3%2F%2F0dg%3D","updated":"2013-07-11 07:59:30.000000000","message":"We intentionally decided not to validate the policy in the plugin, we will leave that to the backend. I also checked with other the other folks working on this, and they seem to share this opinion.","commit_id":"c7c6c641f3b229e71a942f7cffdab4d05bb1b4a6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":59,"context_line":"        LOG.debug(_(\"firewall_deleted() called\"))"},{"line_number":60,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":61,"context_line":"            fw_db \u003d self.plugin._get_firewall(context, firewall_id)"},{"line_number":62,"context_line":"            if fw_db[\u0027status\u0027] \u003d\u003d const.PENDING_DELETE:"},{"line_number":63,"context_line":"                self.plugin.delete_firewall_after_agt(context, firewall_id)"},{"line_number":64,"context_line":"                return True"},{"line_number":65,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fusc%3D","line":62,"updated":"2013-07-12 10:00:07.000000000","message":"mini nit - be consistent in referencing to status in lines 62 \u0026 66","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        LOG.debug(_(\"firewall_deleted() called\"))"},{"line_number":60,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":61,"context_line":"            fw_db \u003d self.plugin._get_firewall(context, firewall_id)"},{"line_number":62,"context_line":"            if fw_db[\u0027status\u0027] \u003d\u003d const.PENDING_DELETE:"},{"line_number":63,"context_line":"                self.plugin.delete_firewall_after_agt(context, firewall_id)"},{"line_number":64,"context_line":"                return True"},{"line_number":65,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fq0E%3D","line":62,"in_reply_to":"AAAAP3%2F%2Fusc%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":63,"context_line":"                self.plugin.delete_firewall_after_agt(context, firewall_id)"},{"line_number":64,"context_line":"                return True"},{"line_number":65,"context_line":"            else:"},{"line_number":66,"context_line":"                fw_db.status \u003d const.ERROR"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_firewalls_for_tenant(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2FusM%3D","line":66,"updated":"2013-07-12 10:00:07.000000000","message":"What would be the case in which an agent sends a firewall_delete, but the corresponding db object is not in PENDING_DELETE?\n\nIt seems a rather exceptional case - and I think it would deserve to be logged as it\u0027s something that would need to be investigated","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                self.plugin.delete_firewall_after_agt(context, firewall_id)"},{"line_number":64,"context_line":"                return True"},{"line_number":65,"context_line":"            else:"},{"line_number":66,"context_line":"                fw_db.status \u003d const.ERROR"},{"line_number":67,"context_line":"                return False"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get_firewalls_for_tenant(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fqz8%3D","line":66,"in_reply_to":"AAAAP3%2F%2FusM%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":"        # change to the firewall, policy or rule, we send all the rules."},{"line_number":159,"context_line":"        # We also need to verify what is the largest message size supported"},{"line_number":160,"context_line":"        # by rabbit/qpid since the with a large number of rules this firewall"},{"line_number":161,"context_line":"        # dict can be potentially be a large number of bytes."},{"line_number":162,"context_line":"        firewall[\u0027firewall_rule_list\u0027] \u003d fw_rules_list"},{"line_number":163,"context_line":"        return firewall"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2FutY%3D","line":161,"updated":"2013-07-12 10:00:07.000000000","message":"then it\u0027s a FIXME ;)\n\nHowever, rabbitmq (don\u0027t know about qpid) handles very large messages - much larger than the ones we\u0027re trying to send here.\nStill sending large amoun of information over a channel, especially when they\u0027re not needed is not healthy.\n\nBut as this is similar to what the l3 agent does with the router info, I guess all these improvements can be addressed at a later stage.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        # change to the firewall, policy or rule, we send all the rules."},{"line_number":159,"context_line":"        # We also need to verify what is the largest message size supported"},{"line_number":160,"context_line":"        # by rabbit/qpid since the with a large number of rules this firewall"},{"line_number":161,"context_line":"        # dict can be potentially be a large number of bytes."},{"line_number":162,"context_line":"        firewall[\u0027firewall_rule_list\u0027] \u003d fw_rules_list"},{"line_number":163,"context_line":"        return firewall"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fqzk%3D","line":161,"in_reply_to":"AAAAP3%2F%2FutY%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self.agent_rpc.update_firewall(context, fw_with_rules)"},{"line_number":199,"context_line":"        return fw"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def delete_firewall_after_agt(self, context, id):"},{"line_number":202,"context_line":"        firewall \u003d super(FirewallPlugin, self).get_firewall(context, id)"},{"line_number":203,"context_line":"        if firewall[\u0027status\u0027] in [const.PENDING_DELETE]:"},{"line_number":204,"context_line":"            super(FirewallPlugin, self).delete_firewall(context, id)"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Furc%3D","line":201,"updated":"2013-07-12 10:00:07.000000000","message":"mini nit: probably delete_db_firewall_object is a more apt name","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self.agent_rpc.update_firewall(context, fw_with_rules)"},{"line_number":199,"context_line":"        return fw"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def delete_firewall_after_agt(self, context, id):"},{"line_number":202,"context_line":"        firewall \u003d super(FirewallPlugin, self).get_firewall(context, id)"},{"line_number":203,"context_line":"        if firewall[\u0027status\u0027] in [const.PENDING_DELETE]:"},{"line_number":204,"context_line":"            super(FirewallPlugin, self).delete_firewall(context, id)"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fqz4%3D","line":201,"in_reply_to":"AAAAP3%2F%2Furc%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":244,"context_line":"        # PENDING_UPDATE state, the firewall behavior might differ based"},{"line_number":245,"context_line":"        # on the backend implementation."},{"line_number":246,"context_line":"        if firewall_policy_id:"},{"line_number":247,"context_line":"            self._rpc_update_firewall_policy(context, firewall_policy_id)"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Furw%3D","line":247,"updated":"2013-07-12 10:00:07.000000000","message":"what would happen in case of failure in this RPC?\nIn other words, how are we dealing with the resulting difference between the db and the data on the agent?\nIs it somethign we need to worry about?\n\nThis question actually refers to all the bits in the plugin code where the db is updated before sending the command to the agent, but the feedback from the RPC operation is not checked (or at least I could not see where in the driver/agent patches this happens)","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        # PENDING_UPDATE state, the firewall behavior might differ based"},{"line_number":245,"context_line":"        # on the backend implementation."},{"line_number":246,"context_line":"        if firewall_policy_id:"},{"line_number":247,"context_line":"            self._rpc_update_firewall_policy(context, firewall_policy_id)"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fqzw%3D","line":247,"in_reply_to":"AAAAP3%2F%2Furw%3D","updated":"2013-07-14 19:51:19.000000000","message":"Whenever we create/update the firewall, and/or update the firewall_policy/firewall_rules associated with the firewall, we set the firewall to PENDING_CREATE/UPDATE state. The firewall is moved to ACTIVE (or ERROR) by the agent depending on whether the creation/update was successful on the agent/driver side. This is being handled in set_firewall_status and firewall_deleted.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def get_firewalls_for_tenant(self, context, **kwargs):"},{"line_number":73,"context_line":"        \"\"\"Agent uses this to get all firewalls for a tenant.\"\"\""},{"line_number":74,"context_line":"        LOG.debug(_(\"get_firewalls_for_tenant() called\"))"},{"line_number":75,"context_line":"        fwalls \u003d self.plugin.get_firewalls(context)"},{"line_number":76,"context_line":"        fw_list \u003d []"},{"line_number":77,"context_line":"        for fw in fwalls:"},{"line_number":78,"context_line":"            fw_id \u003d fw[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkXE%3D","line":75,"updated":"2013-07-16 14:01:00.000000000","message":"replace 75-80:\n\nfw_list \u003d [\n    self.plugin._firewal_dict_with_rules(context, fw[\u0027id\u0027])\n    for fw in self.plugin.get_firewalls(context)\n]","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def get_firewalls_for_tenant(self, context, **kwargs):"},{"line_number":73,"context_line":"        \"\"\"Agent uses this to get all firewalls for a tenant.\"\"\""},{"line_number":74,"context_line":"        LOG.debug(_(\"get_firewalls_for_tenant() called\"))"},{"line_number":75,"context_line":"        fwalls \u003d self.plugin.get_firewalls(context)"},{"line_number":76,"context_line":"        fw_list \u003d []"},{"line_number":77,"context_line":"        for fw in fwalls:"},{"line_number":78,"context_line":"            fw_id \u003d fw[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiIc%3D","line":75,"in_reply_to":"AAAAP3%2F%2FkXE%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _make_firewall_dict_with_rules(self, context, firewall_id):"},{"line_number":147,"context_line":"        firewall \u003d super(FirewallPlugin, self).get_firewall(context,"},{"line_number":148,"context_line":"                                                            firewall_id)"},{"line_number":149,"context_line":"        fw_policy_id \u003d firewall[\u0027firewall_policy_id\u0027]"},{"line_number":150,"context_line":"        if fw_policy_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkWE%3D","line":147,"updated":"2013-07-16 14:01:00.000000000","message":"Why the call to super here?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _make_firewall_dict_with_rules(self, context, firewall_id):"},{"line_number":147,"context_line":"        firewall \u003d super(FirewallPlugin, self).get_firewall(context,"},{"line_number":148,"context_line":"                                                            firewall_id)"},{"line_number":149,"context_line":"        fw_policy_id \u003d firewall[\u0027firewall_policy_id\u0027]"},{"line_number":150,"context_line":"        if fw_policy_id:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiLg%3D","line":147,"in_reply_to":"AAAAP3%2F%2FkWE%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                                            firewall_id)"},{"line_number":149,"context_line":"        fw_policy_id \u003d firewall[\u0027firewall_policy_id\u0027]"},{"line_number":150,"context_line":"        if fw_policy_id:"},{"line_number":151,"context_line":"            fw_policy \u003d super(FirewallPlugin,"},{"line_number":152,"context_line":"                              self).get_firewall_policy(context,"},{"line_number":153,"context_line":"                                                        fw_policy_id)"},{"line_number":154,"context_line":"            fw_rules_list \u003d []"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkWY%3D","line":151,"updated":"2013-07-16 14:01:00.000000000","message":"Why the call to super here? self.get_firewall_policy()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                                                            firewall_id)"},{"line_number":149,"context_line":"        fw_policy_id \u003d firewall[\u0027firewall_policy_id\u0027]"},{"line_number":150,"context_line":"        if fw_policy_id:"},{"line_number":151,"context_line":"            fw_policy \u003d super(FirewallPlugin,"},{"line_number":152,"context_line":"                              self).get_firewall_policy(context,"},{"line_number":153,"context_line":"                                                        fw_policy_id)"},{"line_number":154,"context_line":"            fw_rules_list \u003d []"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiLo%3D","line":151,"in_reply_to":"AAAAP3%2F%2FkWY%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                                        fw_policy_id)"},{"line_number":154,"context_line":"            fw_rules_list \u003d []"},{"line_number":155,"context_line":"            for rule_id in fw_policy[\u0027firewall_rules\u0027]:"},{"line_number":156,"context_line":"                fw_rule \u003d super(FirewallPlugin,"},{"line_number":157,"context_line":"                                self).get_firewall_rule(context,"},{"line_number":158,"context_line":"                                                        rule_id)"},{"line_number":159,"context_line":"                fw_rules_list.append(fw_rule)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkWk%3D","line":156,"updated":"2013-07-16 14:01:00.000000000","message":"Why the call to super here?  self.get_firewall_rule()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                                                        fw_policy_id)"},{"line_number":154,"context_line":"            fw_rules_list \u003d []"},{"line_number":155,"context_line":"            for rule_id in fw_policy[\u0027firewall_rules\u0027]:"},{"line_number":156,"context_line":"                fw_rule \u003d super(FirewallPlugin,"},{"line_number":157,"context_line":"                                self).get_firewall_rule(context,"},{"line_number":158,"context_line":"                                                        rule_id)"},{"line_number":159,"context_line":"                fw_rules_list.append(fw_rule)"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiLw%3D","line":156,"in_reply_to":"AAAAP3%2F%2FkWk%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _rpc_update_firewall(self, context, firewall_id):"},{"line_number":167,"context_line":"        status_update \u003d {\"firewall\": {\"status\": const.PENDING_UPDATE}}"},{"line_number":168,"context_line":"        fw \u003d super(FirewallPlugin, self).update_firewall(context, firewall_id,"},{"line_number":169,"context_line":"                                                         status_update)"},{"line_number":170,"context_line":"        if fw:"},{"line_number":171,"context_line":"            fw_with_rules \u003d ("}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkWA%3D","line":168,"updated":"2013-07-16 14:01:00.000000000","message":"same comment about super()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def _rpc_update_firewall(self, context, firewall_id):"},{"line_number":167,"context_line":"        status_update \u003d {\"firewall\": {\"status\": const.PENDING_UPDATE}}"},{"line_number":168,"context_line":"        fw \u003d super(FirewallPlugin, self).update_firewall(context, firewall_id,"},{"line_number":169,"context_line":"                                                         status_update)"},{"line_number":170,"context_line":"        if fw:"},{"line_number":171,"context_line":"            fw_with_rules \u003d ("}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiMg%3D","line":168,"in_reply_to":"AAAAP3%2F%2FkWA%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":174,"context_line":"            self.agent_rpc.update_firewall(context, fw_with_rules)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _rpc_update_firewall_policy(self, context, firewall_policy_id):"},{"line_number":177,"context_line":"        firewall_policy \u003d super(FirewallPlugin,"},{"line_number":178,"context_line":"                                self).get_firewall_policy(context,"},{"line_number":179,"context_line":"                                                          firewall_policy_id)"},{"line_number":180,"context_line":"        if firewall_policy:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkV4%3D","line":177,"updated":"2013-07-16 14:01:00.000000000","message":"same comment about super()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            self.agent_rpc.update_firewall(context, fw_with_rules)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _rpc_update_firewall_policy(self, context, firewall_policy_id):"},{"line_number":177,"context_line":"        firewall_policy \u003d super(FirewallPlugin,"},{"line_number":178,"context_line":"                                self).get_firewall_policy(context,"},{"line_number":179,"context_line":"                                                          firewall_policy_id)"},{"line_number":180,"context_line":"        if firewall_policy:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiMc%3D","line":177,"in_reply_to":"AAAAP3%2F%2FkV4%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":182,"context_line":"                self._rpc_update_firewall(context, firewall_id)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _ensure_update_firewall(self, context, firewall_id):"},{"line_number":185,"context_line":"        fwall \u003d super(FirewallPlugin, self).get_firewall(context, firewall_id)"},{"line_number":186,"context_line":"        if fwall[\u0027status\u0027] in [const.PENDING_CREATE,"},{"line_number":187,"context_line":"                               const.PENDING_UPDATE,"},{"line_number":188,"context_line":"                               const.PENDING_DELETE]:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkVs%3D","line":185,"updated":"2013-07-16 14:01:00.000000000","message":"same comment about super()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                self._rpc_update_firewall(context, firewall_id)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _ensure_update_firewall(self, context, firewall_id):"},{"line_number":185,"context_line":"        fwall \u003d super(FirewallPlugin, self).get_firewall(context, firewall_id)"},{"line_number":186,"context_line":"        if fwall[\u0027status\u0027] in [const.PENDING_CREATE,"},{"line_number":187,"context_line":"                               const.PENDING_UPDATE,"},{"line_number":188,"context_line":"                               const.PENDING_DELETE]:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiMY%3D","line":185,"in_reply_to":"AAAAP3%2F%2FkVs%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":190,"context_line":"                                                pending_state\u003dfwall[\u0027status\u0027])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _ensure_update_firewall_policy(self, context, firewall_policy_id):"},{"line_number":193,"context_line":"        firewall_policy \u003d super(FirewallPlugin,"},{"line_number":194,"context_line":"                                self).get_firewall_policy(context,"},{"line_number":195,"context_line":"                                                          firewall_policy_id)"},{"line_number":196,"context_line":"        if firewall_policy and \u0027firewall_list\u0027 in firewall_policy:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkVk%3D","line":193,"updated":"2013-07-16 14:01:00.000000000","message":"same comment about super()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                                                pending_state\u003dfwall[\u0027status\u0027])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _ensure_update_firewall_policy(self, context, firewall_policy_id):"},{"line_number":193,"context_line":"        firewall_policy \u003d super(FirewallPlugin,"},{"line_number":194,"context_line":"                                self).get_firewall_policy(context,"},{"line_number":195,"context_line":"                                                          firewall_policy_id)"},{"line_number":196,"context_line":"        if firewall_policy and \u0027firewall_list\u0027 in firewall_policy:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiMU%3D","line":193,"in_reply_to":"AAAAP3%2F%2FkVk%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _ensure_update_or_delete_firewall_rule(self, context,"},{"line_number":201,"context_line":"                                               firewall_rule_id):"},{"line_number":202,"context_line":"        fw_rule \u003d super(FirewallPlugin,"},{"line_number":203,"context_line":"                        self).get_firewall_rule(context,"},{"line_number":204,"context_line":"                                                firewall_rule_id)"},{"line_number":205,"context_line":"        if \u0027firewall_policy_id\u0027 in fw_rule and fw_rule[\u0027firewall_policy_id\u0027]:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkVg%3D","line":202,"updated":"2013-07-16 14:01:00.000000000","message":"same comment about super()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _ensure_update_or_delete_firewall_rule(self, context,"},{"line_number":201,"context_line":"                                               firewall_rule_id):"},{"line_number":202,"context_line":"        fw_rule \u003d super(FirewallPlugin,"},{"line_number":203,"context_line":"                        self).get_firewall_rule(context,"},{"line_number":204,"context_line":"                                                firewall_rule_id)"},{"line_number":205,"context_line":"        if \u0027firewall_policy_id\u0027 in fw_rule and fw_rule[\u0027firewall_policy_id\u0027]:"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiMQ%3D","line":202,"in_reply_to":"AAAAP3%2F%2FkVg%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":260,"context_line":"    def delete_firewall_rule(self, context, id):"},{"line_number":261,"context_line":"        LOG.debug(_(\"delete_firewall_rule() called\"))"},{"line_number":262,"context_line":"        self._ensure_update_or_delete_firewall_rule(context, id)"},{"line_number":263,"context_line":"        fwr \u003d super(FirewallPlugin, self).get_firewall_rule(context, id)"},{"line_number":264,"context_line":"        firewall_policy_id \u003d fwr[\u0027firewall_policy_id\u0027]"},{"line_number":265,"context_line":"        super(FirewallPlugin, self).delete_firewall_rule(context, id)"},{"line_number":266,"context_line":"        # At this point we have already deleted the rule in the DB,"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkVE%3D","line":263,"updated":"2013-07-16 14:01:00.000000000","message":"same comment about super()","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    def delete_firewall_rule(self, context, id):"},{"line_number":261,"context_line":"        LOG.debug(_(\"delete_firewall_rule() called\"))"},{"line_number":262,"context_line":"        self._ensure_update_or_delete_firewall_rule(context, id)"},{"line_number":263,"context_line":"        fwr \u003d super(FirewallPlugin, self).get_firewall_rule(context, id)"},{"line_number":264,"context_line":"        firewall_policy_id \u003d fwr[\u0027firewall_policy_id\u0027]"},{"line_number":265,"context_line":"        super(FirewallPlugin, self).delete_firewall_rule(context, id)"},{"line_number":266,"context_line":"        # At this point we have already deleted the rule in the DB,"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiL0%3D","line":263,"in_reply_to":"AAAAP3%2F%2FkVE%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"unresolved":false,"context_lines":[{"line_number":146,"context_line":"        fw_policy_id \u003d firewall[\u0027firewall_policy_id\u0027]"},{"line_number":147,"context_line":"        if fw_policy_id:"},{"line_number":148,"context_line":"            fw_policy \u003d self.get_firewall_policy(context, fw_policy_id)"},{"line_number":149,"context_line":"            fw_rules_list \u003d []"},{"line_number":150,"context_line":"            for rule_id in fw_policy[\u0027firewall_rules\u0027]:"},{"line_number":151,"context_line":"                fw_rule \u003d self.get_firewall_rule(context, rule_id)"},{"line_number":152,"context_line":"                fw_rules_list.append(fw_rule)"}],"source_content_type":"text/x-python","patch_set":41,"id":"AAAAP3%2F%2Ffh4%3D","line":149,"updated":"2013-07-17 13:32:01.000000000","message":"You could use a list comprehension here too.\n\nfw_rules_list \u003d [self.get_firewall_rule(context, rule_id) for rule_id in fw_policy[\u0027firewall_rules\u0027]]","commit_id":"0428f7f8e4f5257b2ef84f87e70745cc64fe2cae"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        fw_policy_id \u003d firewall[\u0027firewall_policy_id\u0027]"},{"line_number":147,"context_line":"        if fw_policy_id:"},{"line_number":148,"context_line":"            fw_policy \u003d self.get_firewall_policy(context, fw_policy_id)"},{"line_number":149,"context_line":"            fw_rules_list \u003d []"},{"line_number":150,"context_line":"            for rule_id in fw_policy[\u0027firewall_rules\u0027]:"},{"line_number":151,"context_line":"                fw_rule \u003d self.get_firewall_rule(context, rule_id)"},{"line_number":152,"context_line":"                fw_rules_list.append(fw_rule)"}],"source_content_type":"text/x-python","patch_set":41,"id":"AAAAP3%2F%2Feb0%3D","line":149,"in_reply_to":"AAAAP3%2F%2Ffh4%3D","updated":"2013-07-17 17:28:14.000000000","message":"Done","commit_id":"0428f7f8e4f5257b2ef84f87e70745cc64fe2cae"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def create_rpc_dispatcher(self):"},{"line_number":43,"context_line":"        return q_rpc.PluginRpcDispatcher([self])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def set_firewall_status(self, context, firewall_id, status,"},{"line_number":46,"context_line":"                            **kwargs):"},{"line_number":47,"context_line":"        \"\"\"Agent uses this to set a firewall\u0027s status.\"\"\""},{"line_number":48,"context_line":"        LOG.debug(_(\"set_firewall_status() called\"))"}],"source_content_type":"text/x-python","patch_set":43,"id":"AAAAQn%2F%2F3Nk%3D","line":45,"updated":"2013-07-21 04:54:29.000000000","message":"kwargs not used.","commit_id":"bcfbc9876df3c9796e79f38eb4f2ec15d9753d27"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def create_rpc_dispatcher(self):"},{"line_number":43,"context_line":"        return q_rpc.PluginRpcDispatcher([self])"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def set_firewall_status(self, context, firewall_id, status,"},{"line_number":46,"context_line":"                            **kwargs):"},{"line_number":47,"context_line":"        \"\"\"Agent uses this to set a firewall\u0027s status.\"\"\""},{"line_number":48,"context_line":"        LOG.debug(_(\"set_firewall_status() called\"))"}],"source_content_type":"text/x-python","patch_set":43,"id":"AAAAQn%2F%2F2fM%3D","line":45,"in_reply_to":"AAAAQn%2F%2F3Nk%3D","updated":"2013-07-22 04:04:25.000000000","message":"Done","commit_id":"bcfbc9876df3c9796e79f38eb4f2ec15d9753d27"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":154,"context_line":"            fw_policy \u003d self.get_firewall_policy(context, fw_policy_id)"},{"line_number":155,"context_line":"            fw_rules_list \u003d [self.get_firewall_rule("},{"line_number":156,"context_line":"                context, rule_id) for rule_id in fw_policy[\u0027firewall_rules\u0027]]"},{"line_number":157,"context_line":"        firewall[\u0027firewall_rule_list\u0027] \u003d fw_rules_list"},{"line_number":158,"context_line":"        # FIXME(Sumit): If the size of the firewall object we are creating"},{"line_number":159,"context_line":"        # here exceeds the largest message size supported by rabbit/qpid"},{"line_number":160,"context_line":"        # then we will have a problem."}],"source_content_type":"text/x-python","patch_set":43,"id":"AAAAQn%2F%2F3Ng%3D","line":157,"updated":"2013-07-21 04:54:29.000000000","message":"Shouldn\u0027t lline 157 be indented so it part of the \u0027if fw_policy_id:\u0027?","commit_id":"bcfbc9876df3c9796e79f38eb4f2ec15d9753d27"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            fw_policy \u003d self.get_firewall_policy(context, fw_policy_id)"},{"line_number":155,"context_line":"            fw_rules_list \u003d [self.get_firewall_rule("},{"line_number":156,"context_line":"                context, rule_id) for rule_id in fw_policy[\u0027firewall_rules\u0027]]"},{"line_number":157,"context_line":"        firewall[\u0027firewall_rule_list\u0027] \u003d fw_rules_list"},{"line_number":158,"context_line":"        # FIXME(Sumit): If the size of the firewall object we are creating"},{"line_number":159,"context_line":"        # here exceeds the largest message size supported by rabbit/qpid"},{"line_number":160,"context_line":"        # then we will have a problem."}],"source_content_type":"text/x-python","patch_set":43,"id":"AAAAQn%2F%2F2fI%3D","line":157,"in_reply_to":"AAAAQn%2F%2F3Ng%3D","updated":"2013-07-22 04:04:25.000000000","message":"Done, also added a UT to catch when fw_policy_id is not set and firewall[\u0027firewall_rule_list\u0027] should be [].","commit_id":"bcfbc9876df3c9796e79f38eb4f2ec15d9753d27"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"unresolved":false,"context_lines":[{"line_number":156,"context_line":"                context, rule_id) for rule_id in fw_policy[\u0027firewall_rules\u0027]]"},{"line_number":157,"context_line":"            firewall[\u0027firewall_rule_list\u0027] \u003d fw_rules_list"},{"line_number":158,"context_line":"        else:"},{"line_number":159,"context_line":"            firewall[\u0027firewall_rule_list\u0027] \u003d []"},{"line_number":160,"context_line":"        # FIXME(Sumit): If the size of the firewall object we are creating"},{"line_number":161,"context_line":"        # here exceeds the largest message size supported by rabbit/qpid"},{"line_number":162,"context_line":"        # then we will have a problem."}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2FuXk%3D","line":159,"updated":"2013-07-24 12:28:26.000000000","message":"This is redundant with line 151.","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                context, rule_id) for rule_id in fw_policy[\u0027firewall_rules\u0027]]"},{"line_number":157,"context_line":"            firewall[\u0027firewall_rule_list\u0027] \u003d fw_rules_list"},{"line_number":158,"context_line":"        else:"},{"line_number":159,"context_line":"            firewall[\u0027firewall_rule_list\u0027] \u003d []"},{"line_number":160,"context_line":"        # FIXME(Sumit): If the size of the firewall object we are creating"},{"line_number":161,"context_line":"        # here exceeds the largest message size supported by rabbit/qpid"},{"line_number":162,"context_line":"        # then we will have a problem."}],"source_content_type":"text/x-python","patch_set":47,"id":"AAAAQn%2F%2FtxY%3D","line":159,"in_reply_to":"AAAAQn%2F%2FuXk%3D","updated":"2013-07-24 15:26:15.000000000","message":"Yes, I will remove L151, this crept in as a response to some review comments.","commit_id":"a0f2fd77a874ad3c0d45901cfa8e76a60c905774"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update_firewall_rule(self, context, id, firewall_rule):"},{"line_number":243,"context_line":"        LOG.debug(_(\"update_firewall_rule() called\"))"},{"line_number":244,"context_line":"        self._ensure_update_or_delete_firewall_rule(context, id)"},{"line_number":245,"context_line":"        fwr \u003d super(FirewallPlugin,"},{"line_number":246,"context_line":"                    self).update_firewall_rule(context, id, firewall_rule)"},{"line_number":247,"context_line":"        firewall_policy_id \u003d fwr[\u0027firewall_policy_id\u0027]"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmKQ%3D","line":244,"updated":"2013-07-26 21:07:47.000000000","message":"This operation will result fairly expensive when a policy is recycled among several firewalls.\nI wonder if we could make the procedure easier by setting the status on the policy object - so that you won\u0027t have to load all firewalls which use that policy.\n\nWhat would be the case for having two firewalls with the same policy, but one is PENDING and the other is not?\n\nI\u0027m asking because I do not see _rpc_update_firewall called anywhere but in the context of _rpc_update_firewall_policy","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def update_firewall_rule(self, context, id, firewall_rule):"},{"line_number":243,"context_line":"        LOG.debug(_(\"update_firewall_rule() called\"))"},{"line_number":244,"context_line":"        self._ensure_update_or_delete_firewall_rule(context, id)"},{"line_number":245,"context_line":"        fwr \u003d super(FirewallPlugin,"},{"line_number":246,"context_line":"                    self).update_firewall_rule(context, id, firewall_rule)"},{"line_number":247,"context_line":"        firewall_policy_id \u003d fwr[\u0027firewall_policy_id\u0027]"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2Fl9U%3D","line":244,"in_reply_to":"AAAAQn%2F%2FmKQ%3D","updated":"2013-07-26 23:16:23.000000000","message":"The agent (in combination with the driver) move the firewall out of the PENDING state. This operation is done on the agent side on a per firewall basis. Hence the system could be in the state that you describe.\n\nI understand the concerns around performance, but unfortunately we cannot address those by setting/checking this status on the firewall_policy, because as mentioned above, we really need to check if the prior changes have correctly propagated to each firewall. \n\nIn this iteration we chosen to ensure correctness, and the hope is that in a subsequent iteration we can handle these potential performance issues.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":252,"context_line":"    def delete_firewall_rule(self, context, id):"},{"line_number":253,"context_line":"        LOG.debug(_(\"delete_firewall_rule() called\"))"},{"line_number":254,"context_line":"        self._ensure_update_or_delete_firewall_rule(context, id)"},{"line_number":255,"context_line":"        fwr \u003d self.get_firewall_rule(context, id)"},{"line_number":256,"context_line":"        firewall_policy_id \u003d fwr[\u0027firewall_policy_id\u0027]"},{"line_number":257,"context_line":"        super(FirewallPlugin, self).delete_firewall_rule(context, id)"},{"line_number":258,"context_line":"        # At this point we have already deleted the rule in the DB,"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2FmLM%3D","line":255,"updated":"2013-07-26 21:07:47.000000000","message":"If you load the rule before calling ensure_update_or_delete_firewall_rule you can pass the rule object to this method, avoiding an extra select query there.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":252,"context_line":"    def delete_firewall_rule(self, context, id):"},{"line_number":253,"context_line":"        LOG.debug(_(\"delete_firewall_rule() called\"))"},{"line_number":254,"context_line":"        self._ensure_update_or_delete_firewall_rule(context, id)"},{"line_number":255,"context_line":"        fwr \u003d self.get_firewall_rule(context, id)"},{"line_number":256,"context_line":"        firewall_policy_id \u003d fwr[\u0027firewall_policy_id\u0027]"},{"line_number":257,"context_line":"        super(FirewallPlugin, self).delete_firewall_rule(context, id)"},{"line_number":258,"context_line":"        # At this point we have already deleted the rule in the DB,"}],"source_content_type":"text/x-python","patch_set":49,"id":"AAAAQn%2F%2Fl8U%3D","line":255,"in_reply_to":"AAAAQn%2F%2FmLM%3D","updated":"2013-07-26 23:16:23.000000000","message":"That\u0027s a good suggestion. I could do that, but it this call is also being made from \u0027update_firewall_rule\u0027 method (L244 above) as well. Over there the query is happening inside the super of that method. So if I load the rule before calling _ensure_update_or_delete_firewall_rule here, then I would need to do it over there as well, in which case it will result in an extra query over there. Either way we would result in an extra query in one of the places. Since delete is performed only once for a particular rule (but update might be more often), I guess having the extra call in delete might be okay.","commit_id":"257566a093809fe793da9f65b2f1178b3f024f1a"}],"neutron/tests/unit/db/firewall/test_db_firewall.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":82,"context_line":"        ext_mgr \u003d api_ext.PluginAwareExtensionManager("},{"line_number":83,"context_line":"            extensions_path,"},{"line_number":84,"context_line":"            {constants.FIREWALL: self.plugin}"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        app \u003d config.load_paste_app(\u0027extensions_test_app\u0027)"},{"line_number":87,"context_line":"        self.ext_api \u003d api_ext.ExtensionMiddleware(app, ext_mgr\u003dext_mgr)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2FuzI%3D","line":85,"updated":"2013-07-12 10:00:07.000000000","message":"any reason for assigning ext_mgr twice?","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        ext_mgr \u003d api_ext.PluginAwareExtensionManager("},{"line_number":83,"context_line":"            extensions_path,"},{"line_number":84,"context_line":"            {constants.FIREWALL: self.plugin}"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        app \u003d config.load_paste_app(\u0027extensions_test_app\u0027)"},{"line_number":87,"context_line":"        self.ext_api \u003d api_ext.ExtensionMiddleware(app, ext_mgr\u003dext_mgr)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2FqzQ%3D","line":85,"in_reply_to":"AAAAP3%2F%2FuzI%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done, thanks for catching. I forgot to delete the former.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":191,"context_line":"                                  \u0027action\u0027: action,"},{"line_number":192,"context_line":"                                  \u0027enabled\u0027: enabled}}"},{"line_number":193,"context_line":"        if \u0027description\u0027 in kwargs and kwargs[\u0027description\u0027] is not None:"},{"line_number":194,"context_line":"            data[\u0027firewall_rule\u0027][\u0027description\u0027] \u003d kwargs[\u0027description\u0027]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        fw_rule_req \u003d self.new_create_request(\u0027firewall_rules\u0027, data, fmt)"},{"line_number":197,"context_line":"        fw_rule_res \u003d fw_rule_req.get_response(self.ext_api)"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fuys%3D","line":194,"updated":"2013-07-12 10:00:07.000000000","message":"as description is the only kwargs you use you might as well add it to the parameter list and simplify your logic.\n\nthis is an optional comment.","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                                  \u0027action\u0027: action,"},{"line_number":192,"context_line":"                                  \u0027enabled\u0027: enabled}}"},{"line_number":193,"context_line":"        if \u0027description\u0027 in kwargs and kwargs[\u0027description\u0027] is not None:"},{"line_number":194,"context_line":"            data[\u0027firewall_rule\u0027][\u0027description\u0027] \u003d kwargs[\u0027description\u0027]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        fw_rule_req \u003d self.new_create_request(\u0027firewall_rules\u0027, data, fmt)"},{"line_number":197,"context_line":"        fw_rule_res \u003d fw_rule_req.get_response(self.ext_api)"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fqys%3D","line":194,"in_reply_to":"AAAAP3%2F%2Fuys%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":291,"context_line":"            fw_rule_ids \u003d [r[\u0027firewall_rule\u0027][\u0027id\u0027] for r in fr]"},{"line_number":292,"context_line":"            keys \u003d [(\u0027firewall_rule_list\u0027,"},{"line_number":293,"context_line":"                     fw_rule_ids) if (x \u003d\u003d (\u0027firewall_rule_list\u0027,"},{"line_number":294,"context_line":"                                            [])) else x for x in keys]"},{"line_number":295,"context_line":"            with self.firewall_policy(name\u003dname, shared\u003dSHARED,"},{"line_number":296,"context_line":"                                      firewall_rule_list\u003dfw_rule_ids,"},{"line_number":297,"context_line":"                                      audited\u003dAUDITED,"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fuwc%3D","line":294,"updated":"2013-07-12 10:00:07.000000000","message":"nit: operations like this would be much easier if _get_test_attr_xxx functions returned a dict instead of a list of tuples","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            fw_rule_ids \u003d [r[\u0027firewall_rule\u0027][\u0027id\u0027] for r in fr]"},{"line_number":292,"context_line":"            keys \u003d [(\u0027firewall_rule_list\u0027,"},{"line_number":293,"context_line":"                     fw_rule_ids) if (x \u003d\u003d (\u0027firewall_rule_list\u0027,"},{"line_number":294,"context_line":"                                            [])) else x for x in keys]"},{"line_number":295,"context_line":"            with self.firewall_policy(name\u003dname, shared\u003dSHARED,"},{"line_number":296,"context_line":"                                      firewall_rule_list\u003dfw_rule_ids,"},{"line_number":297,"context_line":"                                      audited\u003dAUDITED,"}],"source_content_type":"text/x-python","patch_set":31,"id":"AAAAP3%2F%2Fqvw%3D","line":294,"in_reply_to":"AAAAP3%2F%2Fuwc%3D","updated":"2013-07-14 19:51:19.000000000","message":"Done","commit_id":"138a9e959511e72b11d65b59af5f46eb41c29fa3"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"DB_FW_PLUGIN_KLASS \u003d ("},{"line_number":39,"context_line":"    \"neutron.db.firewall.firewall_db.Firewall_db_mixin\""},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":"ROOTDIR \u003d os.path.dirname(__file__) + \u0027../../../..\u0027"},{"line_number":42,"context_line":"ETCDIR \u003d os.path.join(ROOTDIR, \u0027etc\u0027)"},{"line_number":43,"context_line":"extensions_path \u003d \u0027:\u0027.join(neutron.extensions.__path__)"},{"line_number":44,"context_line":"DESCRIPTION \u003d \u0027default description\u0027"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkUU%3D","line":41,"updated":"2013-07-16 14:01:00.000000000","message":"Are these even needed?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":38,"context_line":"DB_FW_PLUGIN_KLASS \u003d ("},{"line_number":39,"context_line":"    \"neutron.db.firewall.firewall_db.Firewall_db_mixin\""},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":"ROOTDIR \u003d os.path.dirname(__file__) + \u0027../../../..\u0027"},{"line_number":42,"context_line":"ETCDIR \u003d os.path.join(ROOTDIR, \u0027etc\u0027)"},{"line_number":43,"context_line":"extensions_path \u003d \u0027:\u0027.join(neutron.extensions.__path__)"},{"line_number":44,"context_line":"DESCRIPTION \u003d \u0027default description\u0027"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiHg%3D","line":41,"in_reply_to":"AAAAP3%2F%2FkUU%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"neutron.db.firewall.firewall_db.Firewall_db_mixin\""},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":"ROOTDIR \u003d os.path.dirname(__file__) + \u0027../../../..\u0027"},{"line_number":42,"context_line":"ETCDIR \u003d os.path.join(ROOTDIR, \u0027etc\u0027)"},{"line_number":43,"context_line":"extensions_path \u003d \u0027:\u0027.join(neutron.extensions.__path__)"},{"line_number":44,"context_line":"DESCRIPTION \u003d \u0027default description\u0027"},{"line_number":45,"context_line":"SHARED \u003d True"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkUQ%3D","line":42,"updated":"2013-07-16 14:01:00.000000000","message":"same","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"neutron.db.firewall.firewall_db.Firewall_db_mixin\""},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":"ROOTDIR \u003d os.path.dirname(__file__) + \u0027../../../..\u0027"},{"line_number":42,"context_line":"ETCDIR \u003d os.path.join(ROOTDIR, \u0027etc\u0027)"},{"line_number":43,"context_line":"extensions_path \u003d \u0027:\u0027.join(neutron.extensions.__path__)"},{"line_number":44,"context_line":"DESCRIPTION \u003d \u0027default description\u0027"},{"line_number":45,"context_line":"SHARED \u003d True"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiHc%3D","line":42,"in_reply_to":"AAAAP3%2F%2FkUQ%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":55,"context_line":"ADMIN_STATE_UP \u003d True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def etcdir(*p):"},{"line_number":59,"context_line":"    return os.path.join(ETCDIR, *p)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkUc%3D","line":58,"updated":"2013-07-16 14:01:00.000000000","message":"Why is this needed?","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":55,"context_line":"ADMIN_STATE_UP \u003d True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def etcdir(*p):"},{"line_number":59,"context_line":"    return os.path.join(ETCDIR, *p)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiHY%3D","line":58,"in_reply_to":"AAAAP3%2F%2FkUc%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":730,"context_line":"                                   self.firewall_rule(name\u003d\u0027fwr2\u0027,"},{"line_number":731,"context_line":"                                                      no_delete\u003dTrue)) as fr1:"},{"line_number":732,"context_line":"                fw_rule_ids \u003d [r[\u0027firewall_rule\u0027][\u0027id\u0027] for r in fr1]"},{"line_number":733,"context_line":"                attrs[\u0027firewall_rules\u0027] \u003d copy.copy(fw_rule_ids)"},{"line_number":734,"context_line":"                data \u003d {\u0027firewall_policy\u0027:"},{"line_number":735,"context_line":"                        {\u0027firewall_rules\u0027: fw_rule_ids}}"},{"line_number":736,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FkT8%3D","line":733,"updated":"2013-07-16 14:01:00.000000000","message":"Copy is not needed.\n\nattrs[\u0027firewall_rules\u0027] \u003d fw_rule_ids[:]","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                                   self.firewall_rule(name\u003d\u0027fwr2\u0027,"},{"line_number":731,"context_line":"                                                      no_delete\u003dTrue)) as fr1:"},{"line_number":732,"context_line":"                fw_rule_ids \u003d [r[\u0027firewall_rule\u0027][\u0027id\u0027] for r in fr1]"},{"line_number":733,"context_line":"                attrs[\u0027firewall_rules\u0027] \u003d copy.copy(fw_rule_ids)"},{"line_number":734,"context_line":"                data \u003d {\u0027firewall_policy\u0027:"},{"line_number":735,"context_line":"                        {\u0027firewall_rules\u0027: fw_rule_ids}}"},{"line_number":736,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"}],"source_content_type":"text/x-python","patch_set":39,"id":"AAAAP3%2F%2FiGA%3D","line":733,"in_reply_to":"AAAAP3%2F%2FkT8%3D","updated":"2013-07-16 22:27:43.000000000","message":"Done","commit_id":"cb2dfcf41a9fe36af7198375b8252a855fa16874"}],"quantum/db/firewall/firewall_db.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c17afb904b18000eba585d1999bdaceb0fb97878","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class Firewall(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":69,"context_line":"    \"\"\"Represents a Firewall resource\"\"\""},{"line_number":70,"context_line":"    __tablename__ \u003d \u0027firewall\u0027"},{"line_number":71,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":72,"context_line":"    description \u003d sa.Column(sa.String(1024))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F9EI%3D","line":69,"updated":"2013-05-17 21:02:28.000000000","message":"Nit: PEP257 add trailing period here and several others.","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class Firewall(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":69,"context_line":"    \"\"\"Represents a Firewall resource\"\"\""},{"line_number":70,"context_line":"    __tablename__ \u003d \u0027firewall\u0027"},{"line_number":71,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":72,"context_line":"    description \u003d sa.Column(sa.String(1024))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FsxM%3D","line":69,"in_reply_to":"AAAAPH%2F%2F9EI%3D","updated":"2013-06-24 23:40:15.000000000","message":"Done","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c17afb904b18000eba585d1999bdaceb0fb97878","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":89,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":90,"context_line":"            LOG.error(_(\u0027Multiple firewalls match for %s\u0027), id)"},{"line_number":91,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":92,"context_line":"        return fw"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _get_firewall_policy(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F9EQ%3D","line":91,"updated":"2013-05-17 21:02:28.000000000","message":"Is it ok to reuse the not found exception, or should there be a multiple/ambiguous exception?\n\nSame for the following ones.","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":89,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":90,"context_line":"            LOG.error(_(\u0027Multiple firewalls match for %s\u0027), id)"},{"line_number":91,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":92,"context_line":"        return fw"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _get_firewall_policy(self, context, id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FsxA%3D","line":91,"in_reply_to":"AAAAPH%2F%2F9EQ%3D","updated":"2013-06-24 23:40:15.000000000","message":"This was removed.","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c17afb904b18000eba585d1999bdaceb0fb97878","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _make_firewall_policy_dict(self, firewall_policy, fields\u003dNone):"},{"line_number":126,"context_line":"        fw_rules \u003d []"},{"line_number":127,"context_line":"        for rule in firewall_policy[\u0027firewall_rules\u0027]:"},{"line_number":128,"context_line":"            fw_rules.append(rule[\u0027id\u0027])"},{"line_number":129,"context_line":"        res \u003d {\u0027id\u0027: firewall_policy[\u0027id\u0027],"},{"line_number":130,"context_line":"               \u0027tenant_id\u0027: firewall_policy[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F9EA%3D","line":127,"updated":"2013-05-17 21:02:28.000000000","message":"Could use list comprehension for creation of rules:\nfw_rules \u003d [r for r[\u0027id\u0027] in firewall_policy[\u0027firewall_rules\u0027]]","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _make_firewall_policy_dict(self, firewall_policy, fields\u003dNone):"},{"line_number":126,"context_line":"        fw_rules \u003d []"},{"line_number":127,"context_line":"        for rule in firewall_policy[\u0027firewall_rules\u0027]:"},{"line_number":128,"context_line":"            fw_rules.append(rule[\u0027id\u0027])"},{"line_number":129,"context_line":"        res \u003d {\u0027id\u0027: firewall_policy[\u0027id\u0027],"},{"line_number":130,"context_line":"               \u0027tenant_id\u0027: firewall_policy[\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fsw4%3D","line":127,"in_reply_to":"AAAAPH%2F%2F9EA%3D","updated":"2013-06-24 23:40:15.000000000","message":"Done","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c17afb904b18000eba585d1999bdaceb0fb97878","unresolved":false,"context_lines":[{"line_number":150,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027]}"},{"line_number":151,"context_line":"        return self._fields(res, fields)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def create_firewall(self, context, fwall):"},{"line_number":154,"context_line":"        fw \u003d fwall[\u0027firewall\u0027]"},{"line_number":155,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, fw)"},{"line_number":156,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F9D0%3D","line":153,"updated":"2013-05-17 21:02:28.000000000","message":"fw_all or all_fw?","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":150,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027]}"},{"line_number":151,"context_line":"        return self._fields(res, fields)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def create_firewall(self, context, fwall):"},{"line_number":154,"context_line":"        fw \u003d fwall[\u0027firewall\u0027]"},{"line_number":155,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, fw)"},{"line_number":156,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fsw0%3D","line":153,"in_reply_to":"AAAAPH%2F%2F9D0%3D","updated":"2013-06-24 23:40:15.000000000","message":"was changed to firewall","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c17afb904b18000eba585d1999bdaceb0fb97878","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                   description\u003dfw[\u0027description\u0027],"},{"line_number":161,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":162,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":163,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":164,"context_line":"                                   status\u003d\"ACTIVE\")"},{"line_number":165,"context_line":"            context.session.add(firewall_db)"},{"line_number":166,"context_line":"        return self._make_firewall_dict(firewall_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F9Dk%3D","line":163,"updated":"2013-05-17 21:02:28.000000000","message":"Just curious, will the FW always be created in an up state?","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                   description\u003dfw[\u0027description\u0027],"},{"line_number":161,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":162,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":163,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":164,"context_line":"                                   status\u003d\"ACTIVE\")"},{"line_number":165,"context_line":"            context.session.add(firewall_db)"},{"line_number":166,"context_line":"        return self._make_firewall_dict(firewall_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fswc%3D","line":163,"in_reply_to":"AAAAPH%2F%2F9Dk%3D","updated":"2013-06-24 23:40:15.000000000","message":"The status was changed to PENDING_CREATE.","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"677c0d7b6d8245dde396b836725c1530fa97607a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":171,"context_line":"            firewall_db \u003d self._get_firewall(context, id)"},{"line_number":172,"context_line":"            # Ensure we actually have something to update"},{"line_number":173,"context_line":"            if fw.keys():"},{"line_number":174,"context_line":"                firewall_db.update(fw)"},{"line_number":175,"context_line":"        return self._make_firewall_dict(firewall_db)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FWe0%3D","line":173,"updated":"2013-05-13 22:06:52.000000000","message":"not needed. empty dict may be passed to update","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":171,"context_line":"            firewall_db \u003d self._get_firewall(context, id)"},{"line_number":172,"context_line":"            # Ensure we actually have something to update"},{"line_number":173,"context_line":"            if fw.keys():"},{"line_number":174,"context_line":"                firewall_db.update(fw)"},{"line_number":175,"context_line":"        return self._make_firewall_dict(firewall_db)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FswY%3D","line":173,"in_reply_to":"AAAAOn%2F%2FWe0%3D","updated":"2013-06-24 23:40:15.000000000","message":"Done","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c17afb904b18000eba585d1999bdaceb0fb97878","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"},{"line_number":225,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":226,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":227,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":228,"context_line":"            if \u0027firewall_rules_list\u0027 in fwp.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F9Dc%3D","line":225,"updated":"2013-05-17 21:02:28.000000000","message":"Would it be more readable to say  \"policy\" or \"fw_policy\"?","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"},{"line_number":225,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":226,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":227,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":228,"context_line":"            if \u0027firewall_rules_list\u0027 in fwp.keys():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FswA%3D","line":225,"in_reply_to":"AAAAPH%2F%2F9Dc%3D","updated":"2013-06-24 23:40:15.000000000","message":"Agreed, but I was having issues breaking the line to comply with pep8. This seemed like a reasonable compromise.","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"64d9c567a80d7cffdcc6ec5f6e069b7ae9c37031","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # class and hence this is duplicate. We need to pull out those methods"},{"line_number":96,"context_line":"    # into a seperate class which can be used by both QuantumDbPluginV2 and"},{"line_number":97,"context_line":"    # this class (and others)."},{"line_number":98,"context_line":"    def _get_tenant_id_for_create(self, context, resource):"},{"line_number":99,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"},{"line_number":100,"context_line":"            tenant_id \u003d resource[\u0027tenant_id\u0027]"},{"line_number":101,"context_line":"        elif (\u0027tenant_id\u0027 in resource and"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F5NE%3D","line":98,"updated":"2013-05-20 20:34:31.000000000","message":"Or you could inherit  in those methods into class Firewall_db_mixin().","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    # class and hence this is duplicate. We need to pull out those methods"},{"line_number":96,"context_line":"    # into a seperate class which can be used by both QuantumDbPluginV2 and"},{"line_number":97,"context_line":"    # this class (and others)."},{"line_number":98,"context_line":"    def _get_tenant_id_for_create(self, context, resource):"},{"line_number":99,"context_line":"        if context.is_admin and \u0027tenant_id\u0027 in resource:"},{"line_number":100,"context_line":"            tenant_id \u003d resource[\u0027tenant_id\u0027]"},{"line_number":101,"context_line":"        elif (\u0027tenant_id\u0027 in resource and"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FsvI%3D","line":98,"in_reply_to":"AAAAPH%2F%2F5NE%3D","updated":"2013-06-24 23:55:06.000000000","message":"This has been fixed on account of the db code refactoring by eugene.","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"            fw \u003d self._get_by_id(context, Firewall, id)"},{"line_number":158,"context_line":"        except exc.NoResultFound:"},{"line_number":159,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":160,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":161,"context_line":"            LOG.error(_(\u0027Multiple firewalls match for %s\u0027), id)"},{"line_number":162,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":163,"context_line":"        return fw"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3Mo%3D","line":160,"updated":"2013-05-21 14:05:49.000000000","message":"That might be a redundant check. id is PK so this exception is never thrown","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            fw \u003d self._get_by_id(context, Firewall, id)"},{"line_number":158,"context_line":"        except exc.NoResultFound:"},{"line_number":159,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":160,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":161,"context_line":"            LOG.error(_(\u0027Multiple firewalls match for %s\u0027), id)"},{"line_number":162,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":163,"context_line":"        return fw"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FsvE%3D","line":160,"in_reply_to":"AAAAPH%2F%2F3Mo%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":167,"context_line":"            firewall_policy \u003d self._get_by_id(context, FirewallPolicy, id)"},{"line_number":168,"context_line":"        except exc.NoResultFound:"},{"line_number":169,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":170,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":171,"context_line":"            LOG.error(_(\u0027Multiple firewalls match for %s\u0027), id)"},{"line_number":172,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":173,"context_line":"        return firewall_policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3Mk%3D","line":170,"updated":"2013-05-21 14:05:49.000000000","message":"ditto","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            firewall_policy \u003d self._get_by_id(context, FirewallPolicy, id)"},{"line_number":168,"context_line":"        except exc.NoResultFound:"},{"line_number":169,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":170,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":171,"context_line":"            LOG.error(_(\u0027Multiple firewalls match for %s\u0027), id)"},{"line_number":172,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":173,"context_line":"        return firewall_policy"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FsvA%3D","line":170,"in_reply_to":"AAAAPH%2F%2F3Mk%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":177,"context_line":"            firewall_rule \u003d self._get_by_id(context, FirewallRule, id)"},{"line_number":178,"context_line":"        except exc.NoResultFound:"},{"line_number":179,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":180,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":181,"context_line":"            LOG.error(_(\u0027Multiple firewall rules match for %s\u0027), id)"},{"line_number":182,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":183,"context_line":"        return firewall_rule"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3Mg%3D","line":180,"updated":"2013-05-21 14:05:49.000000000","message":"ditto","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            firewall_rule \u003d self._get_by_id(context, FirewallRule, id)"},{"line_number":178,"context_line":"        except exc.NoResultFound:"},{"line_number":179,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":180,"context_line":"        except exc.MultipleResultsFound:"},{"line_number":181,"context_line":"            LOG.error(_(\u0027Multiple firewall rules match for %s\u0027), id)"},{"line_number":182,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":183,"context_line":"        return firewall_rule"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fsu8%3D","line":180,"in_reply_to":"AAAAPH%2F%2F3Mg%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":196,"context_line":"    def _make_firewall_policy_dict(self, firewall_policy, fields\u003dNone):"},{"line_number":197,"context_line":"        fw_rules \u003d []"},{"line_number":198,"context_line":"        for rule_id in firewall_policy[\u0027firewall_rules\u0027]:"},{"line_number":199,"context_line":"            fw_rules.append(rule_id)"},{"line_number":200,"context_line":"        res \u003d {\u0027id\u0027: firewall_policy[\u0027id\u0027],"},{"line_number":201,"context_line":"               \u0027tenant_id\u0027: firewall_policy[\u0027tenant_id\u0027],"},{"line_number":202,"context_line":"               \u0027name\u0027: firewall_policy[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3ws%3D","line":199,"updated":"2013-05-21 13:12:46.000000000","message":"Nits: These tree lines can be \"[rule_id for rule_id in firewall_policy[\u0027firewall_rules\u0027]\" and it can be mered into L.206.","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    def _make_firewall_policy_dict(self, firewall_policy, fields\u003dNone):"},{"line_number":197,"context_line":"        fw_rules \u003d []"},{"line_number":198,"context_line":"        for rule_id in firewall_policy[\u0027firewall_rules\u0027]:"},{"line_number":199,"context_line":"            fw_rules.append(rule_id)"},{"line_number":200,"context_line":"        res \u003d {\u0027id\u0027: firewall_policy[\u0027id\u0027],"},{"line_number":201,"context_line":"               \u0027tenant_id\u0027: firewall_policy[\u0027tenant_id\u0027],"},{"line_number":202,"context_line":"               \u0027name\u0027: firewall_policy[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fstk%3D","line":199,"in_reply_to":"AAAAPH%2F%2F3ws%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":275,"context_line":"                                    shared\u003dfwp[\u0027shared\u0027],"},{"line_number":276,"context_line":"                                    audited\u003dfwp[\u0027audited\u0027])"},{"line_number":277,"context_line":"            context.session.add(fwp_db)"},{"line_number":278,"context_line":"        qry \u003d context.session.query(FirewallPolicy)"},{"line_number":279,"context_line":"        fwp_db \u003d qry.filter_by(id\u003dfwp_db[\u0027id\u0027]).one()"},{"line_number":280,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3Lo%3D","line":278,"updated":"2013-05-21 14:05:49.000000000","message":"Why querying the object that you\u0027ve just created?\nDoing it like in create_firewall is sufficient","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                                    shared\u003dfwp[\u0027shared\u0027],"},{"line_number":276,"context_line":"                                    audited\u003dfwp[\u0027audited\u0027])"},{"line_number":277,"context_line":"            context.session.add(fwp_db)"},{"line_number":278,"context_line":"        qry \u003d context.session.query(FirewallPolicy)"},{"line_number":279,"context_line":"        fwp_db \u003d qry.filter_by(id\u003dfwp_db[\u0027id\u0027]).one()"},{"line_number":280,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fstg%3D","line":278,"in_reply_to":"AAAAPH%2F%2F3Lo%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"                del fwp[\u0027firewall_rules_list\u0027]"},{"line_number":300,"context_line":"            fwp_db.update(fwp)"},{"line_number":301,"context_line":"        qry \u003d context.session.query(FirewallPolicy)"},{"line_number":302,"context_line":"        fwp_db \u003d qry.filter_by(id\u003dfwp_db[\u0027id\u0027]).one()"},{"line_number":303,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3Lg%3D","line":301,"updated":"2013-05-21 14:05:49.000000000","message":"ditto","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":298,"context_line":""},{"line_number":299,"context_line":"                del fwp[\u0027firewall_rules_list\u0027]"},{"line_number":300,"context_line":"            fwp_db.update(fwp)"},{"line_number":301,"context_line":"        qry \u003d context.session.query(FirewallPolicy)"},{"line_number":302,"context_line":"        fwp_db \u003d qry.filter_by(id\u003dfwp_db[\u0027id\u0027]).one()"},{"line_number":303,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fstc%3D","line":301,"in_reply_to":"AAAAPH%2F%2F3Lg%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":311,"context_line":"                qry \u003d context.session.query(Firewall)"},{"line_number":312,"context_line":"                if qry.filter_by(firewall_policy_id\u003did).one():"},{"line_number":313,"context_line":"                    raise firewall.FirewallPolicyInUse(firewall_policy_id\u003did)"},{"line_number":314,"context_line":"            except exc.NoResultFound:"},{"line_number":315,"context_line":"                context.session.delete(fwp)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def get_firewall_policy(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3KU%3D","line":314,"updated":"2013-05-21 14:05:49.000000000","message":"I guess you should except MultipleResultsFound as well because multiple Firewalls can use the same policy.\nAm I correct?","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                qry \u003d context.session.query(Firewall)"},{"line_number":312,"context_line":"                if qry.filter_by(firewall_policy_id\u003did).one():"},{"line_number":313,"context_line":"                    raise firewall.FirewallPolicyInUse(firewall_policy_id\u003did)"},{"line_number":314,"context_line":"            except exc.NoResultFound:"},{"line_number":315,"context_line":"                context.session.delete(fwp)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    def get_firewall_policy(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FstM%3D","line":314,"in_reply_to":"AAAAPH%2F%2F3KU%3D","updated":"2013-06-24 23:55:06.000000000","message":"Correct, good point, I will fix.","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"from quantum.db import model_base"},{"line_number":27,"context_line":"from quantum.db import models_v2"},{"line_number":28,"context_line":"from quantum.extensions import firewall"},{"line_number":29,"context_line":"from quantum import manager"},{"line_number":30,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":31,"context_line":"from quantum.openstack.common import uuidutils"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Frmg%3D","line":29,"updated":"2013-05-27 13:33:58.000000000","message":"should be at line #25 according to import order","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"from quantum.db import model_base"},{"line_number":27,"context_line":"from quantum.db import models_v2"},{"line_number":28,"context_line":"from quantum.extensions import firewall"},{"line_number":29,"context_line":"from quantum import manager"},{"line_number":30,"context_line":"from quantum.openstack.common import log as logging"},{"line_number":31,"context_line":"from quantum.openstack.common import uuidutils"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fmvo%3D","line":29,"in_reply_to":"AAAAPH%2F%2Frmg%3D","updated":"2013-05-29 14:07:57.000000000","message":"I\u0027m wrong, sorry. Please ignore","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":272,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":273,"context_line":"            if \u0027firewall_rules_list\u0027 in fwp.keys():"},{"line_number":274,"context_line":"                # We will first check if the new list of rules is valid"},{"line_number":275,"context_line":"                for fwrule_id in fwp[\u0027firewall_rules_list\u0027]:"},{"line_number":276,"context_line":"                    try:"},{"line_number":277,"context_line":"                        qry \u003d context.session.query(FirewallRule)"},{"line_number":278,"context_line":"                        qry.filter_by(id\u003dfwrule_id).one()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fsw0%3D","line":275,"updated":"2013-05-25 11:48:23.000000000","message":"I don\u0027t know the typical use case for this operation, but in case firewall_rules_list is quite long, it might worth doing one query instead of N, something like:\nif context.session.query(FirewallRule).filter(FirewallRule.id.in_(fwp[\u0027firewall_rules_list\u0027])).count() \u003d\u003d len(fwp[\u0027firewall_rules_list\u0027]):\n\nHowever finding out missing id requires more sophisticated query.\n\nAlso it seems that unit test for this block is needed.","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":273,"context_line":"            if \u0027firewall_rules_list\u0027 in fwp.keys():"},{"line_number":274,"context_line":"                # We will first check if the new list of rules is valid"},{"line_number":275,"context_line":"                for fwrule_id in fwp[\u0027firewall_rules_list\u0027]:"},{"line_number":276,"context_line":"                    try:"},{"line_number":277,"context_line":"                        qry \u003d context.session.query(FirewallRule)"},{"line_number":278,"context_line":"                        qry.filter_by(id\u003dfwrule_id).one()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2FyEg%3D","line":275,"in_reply_to":"AAAAPH%2F%2Fsw0%3D","updated":"2013-06-24 23:32:52.000000000","message":"Thanks, this is a very good point. I have not addressed this yet but will try do so in a subsequent iteration. Happy to get suggestions.","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":296,"context_line":"                qry \u003d context.session.query(Firewall)"},{"line_number":297,"context_line":"                if qry.filter_by(firewall_policy_id\u003did).all():"},{"line_number":298,"context_line":"                    raise firewall.FirewallPolicyInUse(firewall_policy_id\u003did)"},{"line_number":299,"context_line":"            except exc.NoResultFound:"},{"line_number":300,"context_line":"                context.session.delete(fwp)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def get_firewall_policy(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fswo%3D","line":299,"updated":"2013-05-25 11:48:23.000000000","message":"query.all() will not throw NoResultFound, but rather return empty list, so this should be moved to else: one line above","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                qry \u003d context.session.query(Firewall)"},{"line_number":297,"context_line":"                if qry.filter_by(firewall_policy_id\u003did).all():"},{"line_number":298,"context_line":"                    raise firewall.FirewallPolicyInUse(firewall_policy_id\u003did)"},{"line_number":299,"context_line":"            except exc.NoResultFound:"},{"line_number":300,"context_line":"                context.session.delete(fwp)"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def get_firewall_policy(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2FyEc%3D","line":299,"in_reply_to":"AAAAPH%2F%2Fswo%3D","updated":"2013-06-24 23:32:52.000000000","message":"Done","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class FirewallRule(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":38,"context_line":"    \"\"\"Represents a Firewall rule.\"\"\""},{"line_number":39,"context_line":"    __tablename__ \u003d \u0027firewall_rule\u0027"},{"line_number":40,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":41,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":42,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9TY%3D","line":39,"updated":"2013-06-17 13:29:42.000000000","message":"Most Quantum entities usually use plurals for tablenames (they often autogenerated too).\n\nfeel free to do you as you think it\u0027s best for this work piece. I don\u0027t think there\u0027s a real convention for table names.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class FirewallRule(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":38,"context_line":"    \"\"\"Represents a Firewall rule.\"\"\""},{"line_number":39,"context_line":"    __tablename__ \u003d \u0027firewall_rule\u0027"},{"line_number":40,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":41,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":42,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Ftuk%3D","line":39,"in_reply_to":"AAAAPn%2F%2F9TY%3D","updated":"2013-06-24 17:08:52.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class FirewallRule(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":38,"context_line":"    \"\"\"Represents a Firewall rule.\"\"\""},{"line_number":39,"context_line":"    __tablename__ \u003d \u0027firewall_rule\u0027"},{"line_number":40,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":41,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":42,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":43,"context_line":"                                   sa.ForeignKey(\u0027firewall_policy.id\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9TQ%3D","line":40,"updated":"2013-06-17 13:29:42.000000000","message":"nit: Having a long description attribute might allow us to have a shorter name.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"class FirewallRule(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":38,"context_line":"    \"\"\"Represents a Firewall rule.\"\"\""},{"line_number":39,"context_line":"    __tablename__ \u003d \u0027firewall_rule\u0027"},{"line_number":40,"context_line":"    name \u003d sa.Column(sa.String(255))"},{"line_number":41,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":42,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":43,"context_line":"                                   sa.ForeignKey(\u0027firewall_policy.id\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Ftug%3D","line":40,"in_reply_to":"AAAAPn%2F%2F9TQ%3D","updated":"2013-06-24 17:08:52.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   sa.ForeignKey(\u0027firewall_policy.id\u0027),"},{"line_number":44,"context_line":"                                   nullable\u003dTrue)"},{"line_number":45,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":46,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":47,"context_line":"    source_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":48,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":49,"context_line":"    source_port \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9TI%3D","line":46,"updated":"2013-06-17 13:29:42.000000000","message":"Aren\u0027t 40 chars a bit too much for a protocol name?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                   sa.ForeignKey(\u0027firewall_policy.id\u0027),"},{"line_number":44,"context_line":"                                   nullable\u003dTrue)"},{"line_number":45,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":46,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":47,"context_line":"    source_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":48,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":49,"context_line":"    source_port \u003d sa.Column(sa.Integer)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FtuY%3D","line":46,"in_reply_to":"AAAAPn%2F%2F9TI%3D","updated":"2013-06-24 17:08:52.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":46,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":47,"context_line":"    source_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":48,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":49,"context_line":"    source_port \u003d sa.Column(sa.Integer)"},{"line_number":50,"context_line":"    destination_port \u003d sa.Column(sa.Integer)"},{"line_number":51,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9S0%3D","line":48,"updated":"2013-06-17 13:29:42.000000000","message":"an IPv6 address is 128 bit. Are we going to store addresses as bitmasks, where each bit is stored as a different character?\n\nthis won\u0027t sound really efficient.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":46,"context_line":"    protocol \u003d sa.Column(sa.String(40))"},{"line_number":47,"context_line":"    source_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":48,"context_line":"    destination_ip_address \u003d sa.Column(sa.String(128))"},{"line_number":49,"context_line":"    source_port \u003d sa.Column(sa.Integer)"},{"line_number":50,"context_line":"    destination_port \u003d sa.Column(sa.Integer)"},{"line_number":51,"context_line":"    action \u003d sa.Column(sa.Enum(\u0027allow\u0027, \u0027deny\u0027, name\u003d\u0027firewallrules_action\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FtuU%3D","line":48,"in_reply_to":"AAAAPn%2F%2F9S0%3D","updated":"2013-06-24 17:08:52.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                                          \u0027all, delete\u0027),"},{"line_number":79,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":80,"context_line":"                                      collection_class\u003d"},{"line_number":81,"context_line":"                                      ordering_list(\u0027position\u0027))"},{"line_number":82,"context_line":"    audited \u003d sa.Column(sa.Boolean)"},{"line_number":83,"context_line":"    firewalls \u003d orm.relationship(Firewall, backref\u003d\u0027firewall_policy\u0027)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9Rk%3D","line":81,"updated":"2013-06-17 13:29:42.000000000","message":"In this case it\u0027s worth considering a joined load. From the code it does not seem there\u0027s any use of the FireewallPolicy object without its rules, so we might avoid the extra queries we\u0027re doing now in _make_firewall_policy","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                                                          \u0027all, delete\u0027),"},{"line_number":79,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":80,"context_line":"                                      collection_class\u003d"},{"line_number":81,"context_line":"                                      ordering_list(\u0027position\u0027))"},{"line_number":82,"context_line":"    audited \u003d sa.Column(sa.Boolean)"},{"line_number":83,"context_line":"    firewalls \u003d orm.relationship(Firewall, backref\u003d\u0027firewall_policy\u0027)"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs28%3D","line":81,"in_reply_to":"AAAAPn%2F%2F9Rk%3D","updated":"2013-06-24 23:17:56.000000000","message":"Actually the firewall can be created with a firewall_policy with an empty firewall_list (and the rules can be added later). Of course, a firewall_policy with an empty rules list would not be of much use, but is legal.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":164,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":165,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":166,"context_line":"                                   status\u003d\u0027PENDING_CREATE\u0027)"},{"line_number":167,"context_line":"            context.session.add(firewall_db)"},{"line_number":168,"context_line":"        return self._make_firewall_dict(firewall_db)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9SE%3D","line":166,"updated":"2013-06-17 13:29:42.000000000","message":"the above logic is the same as the load balancer plugin.\nSince I love to repeat myself, I would like to point out that this does not make an awful lot of sense from the perspective of the db plugin, as each entity would be always left in a \u0027PENDING\u0027 status.\n\nI understand that this needs to be \u0027completed\u0027 by the actual plugin. I am wondering if you\u0027ve tried an alternative approach where we don\u0027t have this nonsense in the db plugin, like passing the status as a keyword param (should not cause wsgi to complain).","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":164,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":165,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":166,"context_line":"                                   status\u003d\u0027PENDING_CREATE\u0027)"},{"line_number":167,"context_line":"            context.session.add(firewall_db)"},{"line_number":168,"context_line":"        return self._make_firewall_dict(firewall_db)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FtuM%3D","line":166,"in_reply_to":"AAAAPn%2F%2F9SE%3D","updated":"2013-06-24 17:08:52.000000000","message":"What would you set the default to be? Actually, why is it a problem to set it to \u0027PENDING_CREATE\u0027?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                                    description\u003dfwp[\u0027description\u0027],"},{"line_number":204,"context_line":"                                    shared\u003dfwp[\u0027shared\u0027],"},{"line_number":205,"context_line":"                                    audited\u003dfwp[\u0027audited\u0027])"},{"line_number":206,"context_line":"            context.session.add(fwp_db)"},{"line_number":207,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9RM%3D","line":206,"updated":"2013-06-17 13:29:42.000000000","message":"From the API extension module it looked like this method should also have created the rule list.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                                    description\u003dfwp[\u0027description\u0027],"},{"line_number":204,"context_line":"                                    shared\u003dfwp[\u0027shared\u0027],"},{"line_number":205,"context_line":"                                    audited\u003dfwp[\u0027audited\u0027])"},{"line_number":206,"context_line":"            context.session.add(fwp_db)"},{"line_number":207,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FtuI%3D","line":206,"in_reply_to":"AAAAPn%2F%2F9RM%3D","updated":"2013-06-24 17:08:52.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        fwr \u003d firewall_rule[\u0027firewall_rule\u0027]"},{"line_number":264,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, fwr)"},{"line_number":265,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":266,"context_line":"            fwr_db \u003d FirewallRule(id\u003duuidutils.generate_uuid(),"},{"line_number":267,"context_line":"                                  tenant_id\u003dtenant_id,"},{"line_number":268,"context_line":"                                  name\u003dfwr[\u0027name\u0027],"},{"line_number":269,"context_line":"                                  description\u003dfwr[\u0027description\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9Qo%3D","line":266,"updated":"2013-06-17 13:29:42.000000000","message":"are you deliberately ignoring the \u0027position\u0027 field?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        fwr \u003d firewall_rule[\u0027firewall_rule\u0027]"},{"line_number":264,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, fwr)"},{"line_number":265,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":266,"context_line":"            fwr_db \u003d FirewallRule(id\u003duuidutils.generate_uuid(),"},{"line_number":267,"context_line":"                                  tenant_id\u003dtenant_id,"},{"line_number":268,"context_line":"                                  name\u003dfwr[\u0027name\u0027],"},{"line_number":269,"context_line":"                                  description\u003dfwr[\u0027description\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs1U%3D","line":266,"in_reply_to":"AAAAPn%2F%2F9Qo%3D","updated":"2013-06-24 23:17:56.000000000","message":"This position field will never be directly set by the user. It gets set automatically when a firewall_rule is added to the firewall_policies\u0027 rules list. \n\nI have updated the patch to also include the position when a GET is done on the firewall_rule.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                                  source_port\u003dfwr[\u0027source_port\u0027],"},{"line_number":276,"context_line":"                                  destination_port\u003dfwr[\u0027destination_port\u0027],"},{"line_number":277,"context_line":"                                  action\u003dfwr[\u0027action\u0027],"},{"line_number":278,"context_line":"                                  enabled\u003dfwr[\u0027enabled\u0027])"},{"line_number":279,"context_line":"            context.session.add(fwr_db)"},{"line_number":280,"context_line":"        return self._make_firewall_rule_dict(fwr_db)"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9Rc%3D","line":278,"updated":"2013-06-17 13:29:42.000000000","message":"which operation can I use to bind this rule to a policy?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                                  source_port\u003dfwr[\u0027source_port\u0027],"},{"line_number":276,"context_line":"                                  destination_port\u003dfwr[\u0027destination_port\u0027],"},{"line_number":277,"context_line":"                                  action\u003dfwr[\u0027action\u0027],"},{"line_number":278,"context_line":"                                  enabled\u003dfwr[\u0027enabled\u0027])"},{"line_number":279,"context_line":"            context.session.add(fwr_db)"},{"line_number":280,"context_line":"        return self._make_firewall_rule_dict(fwr_db)"},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Ftt8%3D","line":278,"in_reply_to":"AAAAPn%2F%2F9Rc%3D","updated":"2013-06-24 17:08:52.000000000","message":"Currently it\u0027s the update_firewall_policy (with this rule present in the firewall_rules_list). I hope to add the API for adding and removing rules.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"unresolved":false,"context_lines":[{"line_number":74,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":75,"context_line":"    firewall_rules \u003d orm.relationship(FirewallRule,"},{"line_number":76,"context_line":"                                      backref\u003dorm.backref(\u0027firewall_policies\u0027,"},{"line_number":77,"context_line":"                                                          cascade\u003d"},{"line_number":78,"context_line":"                                                          \u0027all, delete\u0027),"},{"line_number":79,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":80,"context_line":"                                      collection_class\u003d"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FshI%3D","line":77,"updated":"2013-06-25 05:23:31.000000000","message":"E251 no space around keyword / parameter equals","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":75,"context_line":"    firewall_rules \u003d orm.relationship(FirewallRule,"},{"line_number":76,"context_line":"                                      backref\u003dorm.backref(\u0027firewall_policies\u0027,"},{"line_number":77,"context_line":"                                                          cascade\u003d"},{"line_number":78,"context_line":"                                                          \u0027all, delete\u0027),"},{"line_number":79,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":80,"context_line":"                                      collection_class\u003d"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsXM%3D","line":77,"in_reply_to":"AAAAPn%2F%2FshI%3D","updated":"2013-06-25 05:45:01.000000000","message":"I am not sure which pep8 standard you are following, Jenkins does not complain for any of these.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"unresolved":false,"context_lines":[{"line_number":75,"context_line":"    firewall_rules \u003d orm.relationship(FirewallRule,"},{"line_number":76,"context_line":"                                      backref\u003dorm.backref(\u0027firewall_policies\u0027,"},{"line_number":77,"context_line":"                                                          cascade\u003d"},{"line_number":78,"context_line":"                                                          \u0027all, delete\u0027),"},{"line_number":79,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":80,"context_line":"                                      collection_class\u003d"},{"line_number":81,"context_line":"                                      ordering_list(\u0027position\u0027, count_from\u003d1))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fo3k%3D","line":78,"updated":"2013-06-26 07:01:12.000000000","message":"You have cascade no delete, does this mean the firewall rules assigned to this policy will be deleted when the firewall policy is deleted?","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    firewall_rules \u003d orm.relationship(FirewallRule,"},{"line_number":76,"context_line":"                                      backref\u003dorm.backref(\u0027firewall_policies\u0027,"},{"line_number":77,"context_line":"                                                          cascade\u003d"},{"line_number":78,"context_line":"                                                          \u0027all, delete\u0027),"},{"line_number":79,"context_line":"                                      order_by\u003d\u0027FirewallRule.position\u0027,"},{"line_number":80,"context_line":"                                      collection_class\u003d"},{"line_number":81,"context_line":"                                      ordering_list(\u0027position\u0027, count_from\u003d1))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fn%2FQ%3D","line":78,"in_reply_to":"AAAAPn%2F%2Fo3k%3D","updated":"2013-06-26 14:35:56.000000000","message":"No, firewall rules will not be deleted.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"unresolved":false,"context_lines":[{"line_number":172,"context_line":"                    # in the system"},{"line_number":173,"context_line":"                    qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":174,"context_line":"                except exc.NoResultFound:"},{"line_number":175,"context_line":"                    raise firewall.FirewallRuleNotFound(firewall_rule_id\u003d"},{"line_number":176,"context_line":"                                                        fwrule_id)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            # New list of rules is valid so we will add each rule"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsZ4%3D","line":175,"updated":"2013-06-25 05:23:31.000000000","message":"E251 no space around keyword / parameter equals","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                    # in the system"},{"line_number":173,"context_line":"                    qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":174,"context_line":"                except exc.NoResultFound:"},{"line_number":175,"context_line":"                    raise firewall.FirewallRuleNotFound(firewall_rule_id\u003d"},{"line_number":176,"context_line":"                                                        fwrule_id)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            # New list of rules is valid so we will add each rule"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsXI%3D","line":175,"in_reply_to":"AAAAPn%2F%2FsZ4%3D","updated":"2013-06-25 05:45:01.000000000","message":"ditto","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            # New list of rules is valid so we will add each rule"},{"line_number":179,"context_line":"            # in order"},{"line_number":180,"context_line":"            for fwrule_id in rules_list:"},{"line_number":181,"context_line":"                qry \u003d context.session.query(FirewallRule)"},{"line_number":182,"context_line":"                fwrule_db \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":183,"context_line":"                fwp_db.firewall_rules.append(fwrule_db)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fo38%3D","line":180,"updated":"2013-06-26 07:01:12.000000000","message":"does this append all rules in rules_list to existing rules_list? Shouldn\u0027t we remove all existing rules first?","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            # New list of rules is valid so we will add each rule"},{"line_number":179,"context_line":"            # in order"},{"line_number":180,"context_line":"            for fwrule_id in rules_list:"},{"line_number":181,"context_line":"                qry \u003d context.session.query(FirewallRule)"},{"line_number":182,"context_line":"                fwrule_db \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":183,"context_line":"                fwp_db.firewall_rules.append(fwrule_db)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FlYU%3D","line":180,"in_reply_to":"AAAAPn%2F%2Fo38%3D","updated":"2013-06-27 10:07:19.000000000","message":"Yes that\u0027s right. This was a bug, I fixed it in a followup patch.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"unresolved":false,"context_lines":[{"line_number":190,"context_line":"                                   tenant_id\u003dtenant_id,"},{"line_number":191,"context_line":"                                   name\u003dfw[\u0027name\u0027],"},{"line_number":192,"context_line":"                                   description\u003dfw[\u0027description\u0027],"},{"line_number":193,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":194,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":195,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":196,"context_line":"                                   status\u003d\u0027PENDING_CREATE\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsZ0%3D","line":193,"updated":"2013-06-25 05:23:31.000000000","message":"E251 no space around keyword / parameter equals","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                                   tenant_id\u003dtenant_id,"},{"line_number":191,"context_line":"                                   name\u003dfw[\u0027name\u0027],"},{"line_number":192,"context_line":"                                   description\u003dfw[\u0027description\u0027],"},{"line_number":193,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":194,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":195,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":196,"context_line":"                                   status\u003d\u0027PENDING_CREATE\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsXE%3D","line":193,"in_reply_to":"AAAAPn%2F%2FsZ0%3D","updated":"2013-06-25 05:45:01.000000000","message":"ditto","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                      fwp[\u0027firewall_rules_list\u0027])"},{"line_number":239,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"},{"line_number":242,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":243,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":244,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fo3s%3D","line":241,"updated":"2013-06-26 07:01:12.000000000","message":"There is no API to just add/delete one rule to/from policy? So when we want to add/delete one rule, we need to provide entire rule list (after add/delete)?","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                                      fwp[\u0027firewall_rules_list\u0027])"},{"line_number":239,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def update_firewall_policy(self, context, id, firewall_policy):"},{"line_number":242,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":243,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":244,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fn%2BE%3D","line":241,"in_reply_to":"AAAAPn%2F%2Fo3s%3D","updated":"2013-06-26 14:35:56.000000000","message":"That is the current approach. We will be adding those operations as well (either in this patch or a separate follow up patch), but those are not critical to get the end-to-end use case working. Also, the client application (CLI or Horizon) can easily provide the interface for adding/removing single rules on top of this API.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"unresolved":false,"context_lines":[{"line_number":285,"context_line":"                                  shared\u003dfwr[\u0027shared\u0027],"},{"line_number":286,"context_line":"                                  protocol\u003dfwr[\u0027protocol\u0027],"},{"line_number":287,"context_line":"                                  source_ip_address\u003dfwr[\u0027source_ip_address\u0027],"},{"line_number":288,"context_line":"                                  destination_ip_address\u003d"},{"line_number":289,"context_line":"                                  fwr[\u0027destination_ip_address\u0027],"},{"line_number":290,"context_line":"                                  source_port\u003dfwr[\u0027source_port\u0027],"},{"line_number":291,"context_line":"                                  destination_port\u003dfwr[\u0027destination_port\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsZs%3D","line":288,"updated":"2013-06-25 05:23:31.000000000","message":"E251 no space around keyword / parameter equals","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                                  shared\u003dfwr[\u0027shared\u0027],"},{"line_number":286,"context_line":"                                  protocol\u003dfwr[\u0027protocol\u0027],"},{"line_number":287,"context_line":"                                  source_ip_address\u003dfwr[\u0027source_ip_address\u0027],"},{"line_number":288,"context_line":"                                  destination_ip_address\u003d"},{"line_number":289,"context_line":"                                  fwr[\u0027destination_ip_address\u0027],"},{"line_number":290,"context_line":"                                  source_port\u003dfwr[\u0027source_port\u0027],"},{"line_number":291,"context_line":"                                  destination_port\u003dfwr[\u0027destination_port\u0027],"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsXA%3D","line":288,"in_reply_to":"AAAAPn%2F%2FsZs%3D","updated":"2013-06-25 05:45:01.000000000","message":"ditto","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"unresolved":false,"context_lines":[{"line_number":294,"context_line":"            context.session.add(fwr_db)"},{"line_number":295,"context_line":"        return self._make_firewall_rule_dict(fwr_db)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def update_firewall_rule(self, context, id, firewall_rule):"},{"line_number":298,"context_line":"        fwr \u003d firewall_rule[\u0027firewall_rule\u0027]"},{"line_number":299,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":300,"context_line":"            fwr_db \u003d self._get_firewall_rule(context, id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsZU%3D","line":297,"updated":"2013-06-25 05:23:31.000000000","message":"Assignment to reserved build-in symbol:id, and many other similiar","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            context.session.add(fwr_db)"},{"line_number":295,"context_line":"        return self._make_firewall_rule_dict(fwr_db)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def update_firewall_rule(self, context, id, firewall_rule):"},{"line_number":298,"context_line":"        fwr \u003d firewall_rule[\u0027firewall_rule\u0027]"},{"line_number":299,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":300,"context_line":"            fwr_db \u003d self._get_firewall_rule(context, id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FsW8%3D","line":297,"in_reply_to":"AAAAPn%2F%2FsZU%3D","updated":"2013-06-25 05:45:01.000000000","message":"ditto","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_firewall(self, context, id):"},{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            fw \u003d self._get_by_id(context, Firewall, id)"},{"line_number":96,"context_line":"        except exc.NoResultFound:"},{"line_number":97,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":98,"context_line":"        return fw"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Fihs%3D","line":95,"updated":"2013-06-28 17:39:36.000000000","message":"nit: return here","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _get_firewall(self, context, id):"},{"line_number":94,"context_line":"        try:"},{"line_number":95,"context_line":"            fw \u003d self._get_by_id(context, Firewall, id)"},{"line_number":96,"context_line":"        except exc.NoResultFound:"},{"line_number":97,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":98,"context_line":"        return fw"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfeE%3D","line":95,"in_reply_to":"AAAAPn%2F%2Fihs%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _get_firewall_policy(self, context, id):"},{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            firewall_policy \u003d self._get_by_id(context, FirewallPolicy, id)"},{"line_number":103,"context_line":"        except exc.NoResultFound:"},{"line_number":104,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":105,"context_line":"        return firewall_policy"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Fiho%3D","line":102,"updated":"2013-06-28 17:39:36.000000000","message":"ditto","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _get_firewall_policy(self, context, id):"},{"line_number":101,"context_line":"        try:"},{"line_number":102,"context_line":"            firewall_policy \u003d self._get_by_id(context, FirewallPolicy, id)"},{"line_number":103,"context_line":"        except exc.NoResultFound:"},{"line_number":104,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":105,"context_line":"        return firewall_policy"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfeA%3D","line":102,"in_reply_to":"AAAAPn%2F%2Fiho%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _get_firewall_rule(self, context, id):"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            firewall_rule \u003d self._get_by_id(context, FirewallRule, id)"},{"line_number":110,"context_line":"        except exc.NoResultFound:"},{"line_number":111,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":112,"context_line":"        return firewall_rule"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Fihk%3D","line":109,"updated":"2013-06-28 17:39:36.000000000","message":"ditto","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _get_firewall_rule(self, context, id):"},{"line_number":108,"context_line":"        try:"},{"line_number":109,"context_line":"            firewall_rule \u003d self._get_by_id(context, FirewallRule, id)"},{"line_number":110,"context_line":"        except exc.NoResultFound:"},{"line_number":111,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":112,"context_line":"        return firewall_rule"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Ffd8%3D","line":109,"in_reply_to":"AAAAPn%2F%2Fihk%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _make_firewall_rule_dict(self, firewall_rule, fields\u003dNone):"},{"line_number":139,"context_line":"        position \u003d None"},{"line_number":140,"context_line":"        # If a firewall_rule is removed from a policy, the position"},{"line_number":141,"context_line":"        # does not get reset to None. Hence we explicitly set it"},{"line_number":142,"context_line":"        # here."},{"line_number":143,"context_line":"        if firewall_rule[\u0027firewall_policy_id\u0027]:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhH0%3D","line":140,"updated":"2013-06-28 17:39:36.000000000","message":"huh I don\u0027t follow this comment? position is just a local variable here.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def _make_firewall_rule_dict(self, firewall_rule, fields\u003dNone):"},{"line_number":139,"context_line":"        position \u003d None"},{"line_number":140,"context_line":"        # If a firewall_rule is removed from a policy, the position"},{"line_number":141,"context_line":"        # does not get reset to None. Hence we explicitly set it"},{"line_number":142,"context_line":"        # here."},{"line_number":143,"context_line":"        if firewall_rule[\u0027firewall_policy_id\u0027]:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Ffdw%3D","line":140,"in_reply_to":"AAAAPn%2F%2FhH0%3D","updated":"2013-06-30 19:02:43.000000000","message":"Based on how the DB model is setup, the \"position\" column should automatically be set to None when firewall_policy_id for this rule is set to None. However, I dont see that happening. Either I have not setup the relationships properly or there is something else happening.\n\nThis position value in the DB is however not directly used once the firewall_policy_id is set to None, hence the above is not so much of an issue. However, we don\u0027t want to the user to see a non-zero position when the rule has not firewall_policy association. Hence I am setting the position to None when creating this dictionary which is sent back to the user.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":155,"context_line":"               \u0027source_port\u0027: firewall_rule[\u0027source_port\u0027],"},{"line_number":156,"context_line":"               \u0027destination_port\u0027: firewall_rule[\u0027destination_port\u0027],"},{"line_number":157,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027],"},{"line_number":158,"context_line":"               \u0027position\u0027: position,"},{"line_number":159,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":160,"context_line":"        return self._fields(res, fields)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhH8%3D","line":158,"updated":"2013-06-28 17:39:36.000000000","message":"firewall_rule.get(\u0027firewall_policy_id\u0027) then you can  remove 143-144","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":155,"context_line":"               \u0027source_port\u0027: firewall_rule[\u0027source_port\u0027],"},{"line_number":156,"context_line":"               \u0027destination_port\u0027: firewall_rule[\u0027destination_port\u0027],"},{"line_number":157,"context_line":"               \u0027action\u0027: firewall_rule[\u0027action\u0027],"},{"line_number":158,"context_line":"               \u0027position\u0027: position,"},{"line_number":159,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":160,"context_line":"        return self._fields(res, fields)"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Ffds%3D","line":158,"in_reply_to":"AAAAPn%2F%2FhH8%3D","updated":"2013-06-30 19:02:43.000000000","message":"Following up the earlier explanation, we want to set the position to None only if the firewall_policy_id is None, otherwise we want to return the value of position as it is set in the DB.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":199,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":200,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":201,"context_line":"                                   status\u003d\u0027PENDING_CREATE\u0027)"},{"line_number":202,"context_line":"            context.session.add(firewall_db)"},{"line_number":203,"context_line":"        return self._make_firewall_dict(firewall_db)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhHI%3D","line":201,"updated":"2013-06-28 17:39:36.000000000","message":"nit: constants.PENDING_CREATE","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                   firewall_policy_id\u003d"},{"line_number":199,"context_line":"                                   fw[\u0027firewall_policy_id\u0027],"},{"line_number":200,"context_line":"                                   admin_state_up\u003dfw[\u0027admin_state_up\u0027],"},{"line_number":201,"context_line":"                                   status\u003d\u0027PENDING_CREATE\u0027)"},{"line_number":202,"context_line":"            context.session.add(firewall_db)"},{"line_number":203,"context_line":"        return self._make_firewall_dict(firewall_db)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Ffdo%3D","line":201,"in_reply_to":"AAAAPn%2F%2FhHI%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":247,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":248,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":249,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":250,"context_line":"            if \u0027firewall_rules_list\u0027 in fwp.keys():"},{"line_number":251,"context_line":"                # We will first check if the new list of rules is valid"},{"line_number":252,"context_line":"                self._add_rules_to_policy(context, id,"},{"line_number":253,"context_line":"                                          fwp[\u0027firewall_rules_list\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhGg%3D","line":250,"updated":"2013-06-28 17:39:36.000000000","message":"don\u0027t need .keys()","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":248,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":249,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":250,"context_line":"            if \u0027firewall_rules_list\u0027 in fwp.keys():"},{"line_number":251,"context_line":"                # We will first check if the new list of rules is valid"},{"line_number":252,"context_line":"                self._add_rules_to_policy(context, id,"},{"line_number":253,"context_line":"                                          fwp[\u0027firewall_rules_list\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Ffdk%3D","line":250,"in_reply_to":"AAAAPn%2F%2FhGg%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":251,"context_line":"                # We will first check if the new list of rules is valid"},{"line_number":252,"context_line":"                self._add_rules_to_policy(context, id,"},{"line_number":253,"context_line":"                                          fwp[\u0027firewall_rules_list\u0027])"},{"line_number":254,"context_line":"                del fwp[\u0027firewall_rules_list\u0027]"},{"line_number":255,"context_line":"            fwp_db.update(fwp)"},{"line_number":256,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhGU%3D","line":254,"updated":"2013-06-28 17:39:36.000000000","message":"nit: do we really need to delete this?","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                # We will first check if the new list of rules is valid"},{"line_number":252,"context_line":"                self._add_rules_to_policy(context, id,"},{"line_number":253,"context_line":"                                          fwp[\u0027firewall_rules_list\u0027])"},{"line_number":254,"context_line":"                del fwp[\u0027firewall_rules_list\u0027]"},{"line_number":255,"context_line":"            fwp_db.update(fwp)"},{"line_number":256,"context_line":"        return self._make_firewall_policy_dict(fwp_db)"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Ffdg%3D","line":254,"in_reply_to":"AAAAPn%2F%2FhGU%3D","updated":"2013-06-30 19:02:43.000000000","message":"I don\u0027t want the firewall_rules_list to the processed again in the following db update statement since we have already processed it.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    __tablename__ \u003d \u0027firewalls\u0027"},{"line_number":60,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":61,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":62,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":63,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean)"},{"line_number":64,"context_line":"    status \u003d sa.Column(sa.String(16))"},{"line_number":65,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FePo%3D","line":62,"updated":"2013-07-01 08:30:45.000000000","message":"I need more help concerning the shared firewall use case.\nI understand a shared firewall is created by a provider which then allows every tenant to use it.\n\nI am fine with this scenario, but I would like to understand what we mean by \u0027use\u0027. \n\nCan a tenant add rules to the policy for a shared firewall?\nCan a tenant reset the policy for a shared firewall?\n\nAlso an ancillary question I have is about how a tenant specifies he wants one or more of his networks protected by a given firewall. This might help me understand how the sharing is done.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    __tablename__ \u003d \u0027firewalls\u0027"},{"line_number":60,"context_line":"    name \u003d sa.Column(sa.String(64))"},{"line_number":61,"context_line":"    description \u003d sa.Column(sa.String(1024))"},{"line_number":62,"context_line":"    shared \u003d sa.Column(sa.Boolean)"},{"line_number":63,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean)"},{"line_number":64,"context_line":"    status \u003d sa.Column(sa.String(16))"},{"line_number":65,"context_line":"    firewall_policy_id \u003d sa.Column(sa.String(36),"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FSZI%3D","line":62,"in_reply_to":"AAAAPn%2F%2FePo%3D","updated":"2013-07-05 04:16:37.000000000","message":"This is a very good question. There are two aspects of usage here:\n\n(1) being able to modify the firewall\u0027s policy/rules, (2) applying the firewall service to a particular tenant\u0027s traffic\n\nTo achieve the former, the \u0027shared\u0027 attribute itself is not enough. We had planned to introduce and an attribute such as \u0027user\u0027 to facilitate it. But I think this is better done as a separate blueprint (and the approach we choose might apply to other services as well).\n\nTo achieve the later requires the service-insertion framework.\n\nMoreover, the current l3 reference implementation cannot support the shared feature (until we add the \u0027user\u0027 attribute).\n\nSo this shared attribute, for now, is a place holder for future use.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _get_firewall(self, context, id):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            fw \u003d self._get_by_id(context, Firewall, id)"},{"line_number":97,"context_line":"            return fw"},{"line_number":98,"context_line":"        except exc.NoResultFound:"},{"line_number":99,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2Febs%3D","line":97,"updated":"2013-07-01 07:23:32.000000000","message":"L.96-97 can be merged into one line.\n\nreturn self._get_by_id(context, Firewall, id)","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def _get_firewall(self, context, id):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            fw \u003d self._get_by_id(context, Firewall, id)"},{"line_number":97,"context_line":"            return fw"},{"line_number":98,"context_line":"        except exc.NoResultFound:"},{"line_number":99,"context_line":"            raise firewall.FirewallNotFound(firewall_id\u003did)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZr0%3D","line":97,"in_reply_to":"AAAAPn%2F%2Febs%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _get_firewall_policy(self, context, id):"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            firewall_policy \u003d self._get_by_id(context, FirewallPolicy, id)"},{"line_number":104,"context_line":"            return firewall_policy"},{"line_number":105,"context_line":"        except exc.NoResultFound:"},{"line_number":106,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2Febo%3D","line":104,"updated":"2013-07-01 07:23:32.000000000","message":"Ditto","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def _get_firewall_policy(self, context, id):"},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            firewall_policy \u003d self._get_by_id(context, FirewallPolicy, id)"},{"line_number":104,"context_line":"            return firewall_policy"},{"line_number":105,"context_line":"        except exc.NoResultFound:"},{"line_number":106,"context_line":"            raise firewall.FirewallPolicyNotFound(firewall_policy_id\u003did)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZrw%3D","line":104,"in_reply_to":"AAAAPn%2F%2Febo%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def _get_firewall_rule(self, context, id):"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            firewall_rule \u003d self._get_by_id(context, FirewallRule, id)"},{"line_number":111,"context_line":"            return firewall_rule"},{"line_number":112,"context_line":"        except exc.NoResultFound:"},{"line_number":113,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2Febk%3D","line":111,"updated":"2013-07-01 07:23:32.000000000","message":"Ditto","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def _get_firewall_rule(self, context, id):"},{"line_number":109,"context_line":"        try:"},{"line_number":110,"context_line":"            firewall_rule \u003d self._get_by_id(context, FirewallRule, id)"},{"line_number":111,"context_line":"            return firewall_rule"},{"line_number":112,"context_line":"        except exc.NoResultFound:"},{"line_number":113,"context_line":"            raise firewall.FirewallRuleNotFound(firewall_rule_id\u003did)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZrs%3D","line":111,"in_reply_to":"AAAAPn%2F%2Febk%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        position \u003d None"},{"line_number":141,"context_line":"        # If a firewall_rule is removed from a policy, the position"},{"line_number":142,"context_line":"        # does not get reset to None. Hence we explicitly set it"},{"line_number":143,"context_line":"        # here."},{"line_number":144,"context_line":"        if firewall_rule[\u0027firewall_policy_id\u0027]:"},{"line_number":145,"context_line":"            position \u003d firewall_rule[\u0027position\u0027]"},{"line_number":146,"context_line":"        res \u003d {\u0027id\u0027: firewall_rule[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeO0%3D","line":143,"updated":"2013-07-01 08:30:45.000000000","message":"supernit: From your comment I initially thought you were explicitly setting the position in the db, which would have been weird.\n\nPerhaps you can change the comment to just say:\n\"we return the rule of position only when it\u0027s bound to a policy\"","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        position \u003d None"},{"line_number":141,"context_line":"        # If a firewall_rule is removed from a policy, the position"},{"line_number":142,"context_line":"        # does not get reset to None. Hence we explicitly set it"},{"line_number":143,"context_line":"        # here."},{"line_number":144,"context_line":"        if firewall_rule[\u0027firewall_policy_id\u0027]:"},{"line_number":145,"context_line":"            position \u003d firewall_rule[\u0027position\u0027]"},{"line_number":146,"context_line":"        res \u003d {\u0027id\u0027: firewall_rule[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZn0%3D","line":143,"in_reply_to":"AAAAPn%2F%2FeO0%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":160,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":161,"context_line":"        return self._fields(res, fields)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_id, rules_list):"},{"line_number":164,"context_line":"        fwp_db \u003d self._get_firewall_policy(context, firewall_policy_id)"},{"line_number":165,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":166,"context_line":"            # We will first check if the new list of rules is valid"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeOo%3D","line":163,"updated":"2013-07-01 08:30:45.000000000","message":"more nit: rename 4th param to rule_ids or rule_id_list","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":160,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":161,"context_line":"        return self._fields(res, fields)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_id, rules_list):"},{"line_number":164,"context_line":"        fwp_db \u003d self._get_firewall_policy(context, firewall_policy_id)"},{"line_number":165,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":166,"context_line":"            # We will first check if the new list of rules is valid"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZl4%3D","line":163,"in_reply_to":"AAAAPn%2F%2FeOo%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return self._fields(res, fields)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_id, rules_list):"},{"line_number":164,"context_line":"        fwp_db \u003d self._get_firewall_policy(context, firewall_policy_id)"},{"line_number":165,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":166,"context_line":"            # We will first check if the new list of rules is valid"},{"line_number":167,"context_line":"            for fwrule_id in rules_list:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeOI%3D","line":164,"updated":"2013-07-01 08:30:45.000000000","message":"If you want to keep two loops (one for validating, and one for adding), you can load the fwp after the first loop.\nSo if there\u0027s an error you won\u0027t make at all this db operation.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return self._fields(res, fields)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_id, rules_list):"},{"line_number":164,"context_line":"        fwp_db \u003d self._get_firewall_policy(context, firewall_policy_id)"},{"line_number":165,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":166,"context_line":"            # We will first check if the new list of rules is valid"},{"line_number":167,"context_line":"            for fwrule_id in rules_list:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZlo%3D","line":164,"in_reply_to":"AAAAPn%2F%2FeOI%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            # Note that the list could be empty in which case we interpret"},{"line_number":184,"context_line":"            # it as clearing existing rules."},{"line_number":185,"context_line":"            fwp_db.firewall_rules \u003d []"},{"line_number":186,"context_line":"            for fwrule_id in rules_list:"},{"line_number":187,"context_line":"                qry \u003d context.session.query(FirewallRule)"},{"line_number":188,"context_line":"                fwrule_db \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":189,"context_line":"                fwp_db.firewall_rules.append(fwrule_db)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeOc%3D","line":186,"updated":"2013-07-01 08:30:45.000000000","message":"At least it shouldn\u0027t be hard avoding re-accessing the database for the 2nd time here","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            # Note that the list could be empty in which case we interpret"},{"line_number":184,"context_line":"            # it as clearing existing rules."},{"line_number":185,"context_line":"            fwp_db.firewall_rules \u003d []"},{"line_number":186,"context_line":"            for fwrule_id in rules_list:"},{"line_number":187,"context_line":"                qry \u003d context.session.query(FirewallRule)"},{"line_number":188,"context_line":"                fwrule_db \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":189,"context_line":"                fwp_db.firewall_rules.append(fwrule_db)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZkM%3D","line":186,"in_reply_to":"AAAAPn%2F%2FeOc%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    def delete_firewall(self, context, id):"},{"line_number":214,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":215,"context_line":"            fw \u003d self._get_firewall(context, id)"},{"line_number":216,"context_line":"            # TODO(Sumit): Ensure that the firewall is not active"},{"line_number":217,"context_line":"            context.session.delete(fw)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_firewall(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeNw%3D","line":216,"updated":"2013-07-01 08:30:45.000000000","message":"This is actually a rather important question I\u0027m having throughout this patch.\nHow will we define a firewall \u0027active\u0027?","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    def delete_firewall(self, context, id):"},{"line_number":214,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":215,"context_line":"            fw \u003d self._get_firewall(context, id)"},{"line_number":216,"context_line":"            # TODO(Sumit): Ensure that the firewall is not active"},{"line_number":217,"context_line":"            context.session.delete(fw)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def get_firewall(self, context, id, fields\u003dNone):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZgk%3D","line":216,"in_reply_to":"AAAAPn%2F%2FeNw%3D","updated":"2013-07-05 04:16:37.000000000","message":"At this point our approach with the reference implementation is to disable the policy/rules and instead block all traffic when the firewall\u0027s admin_status_up is set to False. All the policy/rules associations are still in place.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"from quantum.plugins.common import constants as const"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class FirewallRule(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT8w%3D","line":35,"updated":"2013-07-04 11:50:54.000000000","message":"nit: LOG is not used in the module","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from quantum.plugins.common import constants as const"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class FirewallRule(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz4w%3D","line":35,"in_reply_to":"AAAAPn%2F%2FT8w%3D","updated":"2013-07-11 07:58:22.000000000","message":"I am using it now.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class Firewall_db_mixin(firewall.FirewallPluginBase, base_db.CommonDbMixin):"},{"line_number":88,"context_line":"    \"\"\"Mixin class to for Firewall DB implementation.\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @property"},{"line_number":91,"context_line":"    def _core_plugin(self):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT8k%3D","line":88,"updated":"2013-07-04 11:50:54.000000000","message":"nit: remove \u0027to\u0027 after class","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class Firewall_db_mixin(firewall.FirewallPluginBase, base_db.CommonDbMixin):"},{"line_number":88,"context_line":"    \"\"\"Mixin class to for Firewall DB implementation.\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @property"},{"line_number":91,"context_line":"    def _core_plugin(self):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz4s%3D","line":88,"in_reply_to":"AAAAPn%2F%2FT8k%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    # the following implementation is inefficient"},{"line_number":168,"context_line":"                    # because it makes one DB fetch for every rule"},{"line_number":169,"context_line":"                    # in the system"},{"line_number":170,"context_line":"                    rules_in_db[fwrule_id] \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":171,"context_line":"                except exc.NoResultFound:"},{"line_number":172,"context_line":"                    # If we find an invalid rule in the list we"},{"line_number":173,"context_line":"                    # do not perform the update since this breaks"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT3U%3D","line":170,"updated":"2013-07-04 11:50:54.000000000","message":"Consider:\nrules_in_db \u003d qry.filter(FirewallRule.id in rule_id_list).all()\n\nThus you can avoid loop by doing only one db fetch. Then you can raise FirewallRuleNotFound if lengths of rule_id_list and rules_in_db differ.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                    # the following implementation is inefficient"},{"line_number":168,"context_line":"                    # because it makes one DB fetch for every rule"},{"line_number":169,"context_line":"                    # in the system"},{"line_number":170,"context_line":"                    rules_in_db[fwrule_id] \u003d qry.filter_by(id\u003dfwrule_id).one()"},{"line_number":171,"context_line":"                except exc.NoResultFound:"},{"line_number":172,"context_line":"                    # If we find an invalid rule in the list we"},{"line_number":173,"context_line":"                    # do not perform the update since this breaks"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2FzYM%3D","line":170,"in_reply_to":"AAAAPn%2F%2FT3U%3D","updated":"2013-07-11 07:58:22.000000000","message":"Thanks for thinking through this, and this seems like a good suggestion. However, I wouldn\u0027t not have a rule_id to raise FirewallRuleNotFound exception. Also, I am not sure if this would actually result in optimization in terms of DB access.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # Ensure that the firewall_policy  is not"},{"line_number":258,"context_line":"            # being used"},{"line_number":259,"context_line":"            qry \u003d context.session.query(Firewall)"},{"line_number":260,"context_line":"            if qry.filter_by(firewall_policy_id\u003did).all():"},{"line_number":261,"context_line":"                raise firewall.FirewallPolicyInUse(firewall_policy_id\u003did)"},{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                context.session.delete(fwp)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT20%3D","line":260,"updated":"2013-07-04 11:50:54.000000000","message":"nit: .first() seems enough here","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # Ensure that the firewall_policy  is not"},{"line_number":258,"context_line":"            # being used"},{"line_number":259,"context_line":"            qry \u003d context.session.query(Firewall)"},{"line_number":260,"context_line":"            if qry.filter_by(firewall_policy_id\u003did).all():"},{"line_number":261,"context_line":"                raise firewall.FirewallPolicyInUse(firewall_policy_id\u003did)"},{"line_number":262,"context_line":"            else:"},{"line_number":263,"context_line":"                context.session.delete(fwp)"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz4M%3D","line":260,"in_reply_to":"AAAAPn%2F%2FT20%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":159,"context_line":"        return self._fields(res, fields)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_id, rule_id_list):"},{"line_number":162,"context_line":"        rules_in_db \u003d {}"},{"line_number":163,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":164,"context_line":"            # We will first check if the new list of rules is valid"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAPn%2F%2FPz0%3D","line":161,"updated":"2013-07-06 19:18:06.000000000","message":"Looking at how this method is used I think it might worth passing firewall_policy_db object instead of id.\nThat might save self._get_firewall_policy call","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               \u0027enabled\u0027: firewall_rule[\u0027enabled\u0027]}"},{"line_number":159,"context_line":"        return self._fields(res, fields)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _add_rules_to_policy(self, context, firewall_policy_id, rule_id_list):"},{"line_number":162,"context_line":"        rules_in_db \u003d {}"},{"line_number":163,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":164,"context_line":"            # We will first check if the new list of rules is valid"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2Fzso%3D","line":161,"in_reply_to":"AAAAPn%2F%2FPz0%3D","updated":"2013-07-11 07:58:46.000000000","message":"Done","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"}],"quantum/extensions/firewall.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"64d9c567a80d7cffdcc6ec5f6e069b7ae9c37031","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_supported_actions)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_validate_port_value(port):"},{"line_number":97,"context_line":"    if port is None:"},{"line_number":98,"context_line":"        return port"},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F5OE%3D","line":96,"updated":"2013-05-20 20:34:31.000000000","message":"This method was copied from extensions/securitygroups.py we should pull both of these functions out to someplace common so we don\u0027t need to duplicate this code.","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_supported_actions)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_validate_port_value(port):"},{"line_number":97,"context_line":"    if port is None:"},{"line_number":98,"context_line":"        return port"},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FsvQ%3D","line":96,"in_reply_to":"AAAAPH%2F%2F5OE%3D","updated":"2013-06-24 23:55:06.000000000","message":"Duly noted, will do so in a follow up iteration.","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"unresolved":false,"context_lines":[{"line_number":107,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def convert_none_to_empty_list(value):"},{"line_number":111,"context_line":"    return [] if value is None else value"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F3t4%3D","line":110,"updated":"2013-05-21 12:09:19.000000000","message":"not used and copied from extensions/attributes.py","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def convert_none_to_empty_list(value):"},{"line_number":111,"context_line":"    return [] if value is None else value"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fsvc%3D","line":110,"in_reply_to":"AAAAPH%2F%2F3t4%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"201f07718080450827d09d0df5a6cd60da6894b5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    except (ValueError, TypeError):"},{"line_number":102,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":105,"context_line":"        return val"},{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2F0bM%3D","line":104,"updated":"2013-05-22 11:11:16.000000000","message":"if 0 \u003c\u003d val \u003c\u003d 65535:","commit_id":"3cea89cf9306b44862b3890ab97e7b1e4eaa4c1f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.api.v2 import attributes as attr"},{"line_number":26,"context_line":"from quantum.api.v2 import base"},{"line_number":27,"context_line":"from quantum.common import exceptions as qexception"},{"line_number":28,"context_line":"from quantum import manager"},{"line_number":29,"context_line":"from quantum.plugins.common import constants"},{"line_number":30,"context_line":"from quantum.plugins.services.service_base import ServicePluginBase"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FrlY%3D","line":28,"updated":"2013-05-27 13:33:58.000000000","message":"import order","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.api.v2 import attributes as attr"},{"line_number":26,"context_line":"from quantum.api.v2 import base"},{"line_number":27,"context_line":"from quantum.common import exceptions as qexception"},{"line_number":28,"context_line":"from quantum import manager"},{"line_number":29,"context_line":"from quantum.plugins.common import constants"},{"line_number":30,"context_line":"from quantum.plugins.services.service_base import ServicePluginBase"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fmvk%3D","line":28,"in_reply_to":"AAAAPH%2F%2FrlY%3D","updated":"2013-05-29 14:07:57.000000000","message":"please ignore","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0350b0bd4ccabab026b8cd651db825c4172603a9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_supported_actions)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_validate_port_value(port):"},{"line_number":97,"context_line":"    if port is None:"},{"line_number":98,"context_line":"        return port"},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fb2s%3D","line":96,"updated":"2013-06-04 01:10:57.000000000","message":"It would be better if we could share this logic with security groups as it has the same function but raises different exceptions.","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_supported_actions)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_validate_port_value(port):"},{"line_number":97,"context_line":"    if port is None:"},{"line_number":98,"context_line":"        return port"},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2FyFQ%3D","line":96,"in_reply_to":"AAAAPH%2F%2Fb2s%3D","updated":"2013-06-24 23:32:52.000000000","message":"Thanks for the suggestion, I have not implemented this yet, will do so in a subsequent iteration.","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":173,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":174,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":175,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":176,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":177,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":178,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":179,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Frkk%3D","line":176,"updated":"2013-05-27 13:33:58.000000000","message":"Having mutable types as default values may cause side effects. Considering that you already have proper conversion from None here I believe you can use None as default","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":174,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":175,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":176,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":177,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":178,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":179,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2FyE8%3D","line":176,"in_reply_to":"AAAAPH%2F%2Frkk%3D","updated":"2013-06-24 23:32:52.000000000","message":"Sorry, but could you explain a little more on the \"side effects\" that you expect?","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @classmethod"},{"line_number":236,"context_line":"    def get_resources(cls):"},{"line_number":237,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":238,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":239,"context_line":"        resources \u003d []"},{"line_number":240,"context_line":"        plugin \u003d manager.QuantumManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2FrjA%3D","line":237,"updated":"2013-05-27 13:33:58.000000000","message":"special handling for firewall_policies needed here too","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @classmethod"},{"line_number":236,"context_line":"    def get_resources(cls):"},{"line_number":237,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":238,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":239,"context_line":"        resources \u003d []"},{"line_number":240,"context_line":"        plugin \u003d manager.QuantumManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2FyE4%3D","line":237,"in_reply_to":"AAAAPH%2F%2FrjA%3D","updated":"2013-06-24 23:32:52.000000000","message":"Not sure I understand, can you elaborate?","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            params \u003d RESOURCE_ATTRIBUTE_MAP[collection_name]"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            member_actions \u003d {}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            controller \u003d base.create_resource("},{"line_number":254,"context_line":"                collection_name, resource_name, plugin, params,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fri4%3D","line":251,"updated":"2013-05-27 13:33:58.000000000","message":"unused","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            params \u003d RESOURCE_ATTRIBUTE_MAP[collection_name]"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            member_actions \u003d {}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            controller \u003d base.create_resource("},{"line_number":254,"context_line":"                collection_name, resource_name, plugin, params,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPX%2F%2FyE0%3D","line":251,"in_reply_to":"AAAAPH%2F%2Fri4%3D","updated":"2013-06-24 23:32:52.000000000","message":"Actually it\u0027s being used below:\nmember_actions\u003dmember_actions","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8994319057650ebd7162f3aea3ae48ceb680c012","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    except (ValueError, TypeError):"},{"line_number":102,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":105,"context_line":"        return val"},{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2Fu8M%3D","line":104,"updated":"2013-06-11 19:04:42.000000000","message":"if 0 \u003c\u003d val \u003c\u003d 65535:","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    except (ValueError, TypeError):"},{"line_number":102,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":105,"context_line":"        return val"},{"line_number":106,"context_line":"    else:"},{"line_number":107,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FszY%3D","line":104,"in_reply_to":"AAAAPX%2F%2Fu8M%3D","updated":"2013-06-24 23:33:14.000000000","message":"The earlier suggestion was to move this out to a common place so that SG and FWaaS could use the same implementation. I will be doing that in a subsequent, will address this at that point.","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    message \u003d _(\"Invalid value for port %(port)s\")"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"fw_supported_protocols \u003d [None, \u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":73,"context_line":"fw_supported_actions \u003d [\u0027allow\u0027, \u0027deny\u0027]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9lA%3D","line":72,"updated":"2013-06-17 13:29:42.000000000","message":"Instead of adding None to the list of supported protocols you can easily build on top of the _validate_values validator and have a validator that verifies if an element is in a list or is none.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    message \u003d _(\"Invalid value for port %(port)s\")"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"fw_supported_protocols \u003d [None, \u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":73,"context_line":"fw_supported_actions \u003d [\u0027allow\u0027, \u0027deny\u0027]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Ftt0%3D","line":72,"in_reply_to":"AAAAPn%2F%2F9lA%3D","updated":"2013-06-24 17:08:52.000000000","message":"I renamed this variable to fw_valid_protocol_values (since that is actually what this is meant to hold).","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027},"},{"line_number":124,"context_line":"        \u0027firewall_policy_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":125,"context_line":"                               \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None},"},{"line_number":126,"context_line":"                               \u0027is_visible\u0027: True},"},{"line_number":127,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":128,"context_line":"                   \u0027default\u0027: True, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":129,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9hw%3D","line":126,"updated":"2013-06-17 13:29:42.000000000","message":"I would consider allow_post\u003dTrue at least for this attribute.\n\nThis unless rule ordering for a policy matters - I haven\u0027t found evidence of this in the specification - but then I found the (apparently) unused attribute \u0027position\u0027 in the FirewallRule model class. I then started feeling my head exploding so I gave up!","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                        \u0027is_visible\u0027: True, \u0027default\u0027: \u0027\u0027},"},{"line_number":124,"context_line":"        \u0027firewall_policy_id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":125,"context_line":"                               \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None},"},{"line_number":126,"context_line":"                               \u0027is_visible\u0027: True},"},{"line_number":127,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":128,"context_line":"                   \u0027default\u0027: True, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":129,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FttM%3D","line":126,"in_reply_to":"AAAAPn%2F%2F9hw%3D","updated":"2013-06-24 17:08:52.000000000","message":"We want to drive the association of the rule with the policy via APIs on the policy. That simplifies the usage model, and also easier to maintain integrity.\n\nThe ordering of the rules matters.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":128,"context_line":"                   \u0027default\u0027: True, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":129,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":130,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":131,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":132,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":133,"context_line":"                     \u0027convert_to\u0027: convert_protocol_to_case_insensitive,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9kk%3D","line":130,"updated":"2013-06-17 13:29:42.000000000","message":"The above attribute is not included in the original specification. What is the use case for a shared firewall rule?\n\nIs that becase each rule in a shared firewall policy should be marked as shared too? (In this case I would set allow_post and allow_put to False)","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":128,"context_line":"                   \u0027default\u0027: True, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":129,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":130,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":131,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":132,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":133,"context_line":"                     \u0027convert_to\u0027: convert_protocol_to_case_insensitive,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fts4%3D","line":130,"in_reply_to":"AAAAPn%2F%2F9kk%3D","updated":"2013-06-24 17:08:52.000000000","message":"Yes, I added this to account for the use case where the rules might be created by a different user from the one who creates the policy, and in turn who uses both these.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":145,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":146,"context_line":"                             \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":147,"context_line":"                             \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":148,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":149,"context_line":"                   \u0027convert_to\u0027: convert_action_to_case_insensitive,"},{"line_number":150,"context_line":"                   \u0027validate\u0027: {\u0027type:values\u0027: fw_supported_actions},"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9kI%3D","line":147,"updated":"2013-06-17 13:29:42.000000000","message":"for source_port and destination_port consider adopting the same validation/conversion approach as vips.protocol_port (extensions/loadbalancer.py)\n\nThis is for consistency and DRY.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                        \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":145,"context_line":"        \u0027destination_port\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":146,"context_line":"                             \u0027convert_to\u0027: convert_validate_port_value,"},{"line_number":147,"context_line":"                             \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":148,"context_line":"        \u0027action\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":149,"context_line":"                   \u0027convert_to\u0027: convert_action_to_case_insensitive,"},{"line_number":150,"context_line":"                   \u0027validate\u0027: {\u0027type:values\u0027: fw_supported_actions},"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Ftsg%3D","line":147,"in_reply_to":"AAAAPn%2F%2F9kI%3D","updated":"2013-06-24 17:08:52.000000000","message":"We wanted to use None as a wild card implying all ports (as opposed to what I believe is happening with in the LB case).","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":174,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":175,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":176,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":178,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9iE%3D","line":176,"updated":"2013-06-17 13:29:42.000000000","message":"The semantics that we are adopting here are exactly the opposite of the onef that we adopt for other relationships such as port/network or subnet/network.\nUnless there are specific reasons for acting differently Quantum API should be consistent across resources.\n\nI have briefly looked at the mailing list in order to try and understand why this different semantic, but I did not find any specific reason, if not that one wants to push policy and rules in one call.\nThis has the downside of preventing a user to add/remove specific rules (this was pointed out in the spec review too I think).\n\nAlso, leveraging the \u0027bulk create\u0027 mechanism which is already supported by the quantum API one could create policy and rules in two calls, which is not bad, and then subsequently add/remove calls.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":174,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":175,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":176,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":178,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs6s%3D","line":176,"in_reply_to":"AAAAPn%2F%2F9iE%3D","updated":"2013-06-24 23:17:56.000000000","message":"My apologies, but I am not sure I completely understand the point you are making.\n\nIn this iteration of implementation, the firewall_rule can be associated with the firewall_policy only while creating a firewall_policy or by updating the firewall_policy. The entire firewall_rules_list needs to be provided each time a change is made to the list.\n\nThe plan is to add operations to add and remove firewall_rules from a firewall_policy such that only the rules that are affected need to be provided not the entire list. The firewall_rule\u0027s position attribute will be used for this.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":174,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":175,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":176,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":178,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FeRE%3D","line":176,"in_reply_to":"AAAAPn%2F%2Fs6s%3D","updated":"2013-07-01 07:48:18.000000000","message":"My point was simply that we do not have at this stage cases where one can create a list of first-level resources (such as the firewall rules) from within an operation creating another resource (such as the firewall policy).\n\nHowever, I understand that everything goes back to the problem that associating a rule to a policy is not trivial in the API sense as rule ordering matters.\nI will comment more on the latest patchset to simplify your addressing of comments.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":178,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":181,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":182,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9h8%3D","line":179,"updated":"2013-06-17 13:29:42.000000000","message":"syntax nit: the plural for an attribute should already mean that the value is a list, hence the _list suffix is probably redundant (this applies to firewall_rules_list too)","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":178,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":181,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":182,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs6Q%3D","line":179,"in_reply_to":"AAAAPn%2F%2F9h8%3D","updated":"2013-06-24 23:17:56.000000000","message":"I wanted to clearly articulate this is a list of values as opposed to a list of key-value pairs. I felt it\u0027s easier to the naive user when it\u0027s spelt out explicitly. I can change if there are strong objections.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":200,"context_line":"                   \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":201,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":202,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":203,"context_line":"        \u0027admin_state_up\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":204,"context_line":"                           \u0027default\u0027: True,"},{"line_number":205,"context_line":"                           \u0027convert_to\u0027: attr.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9go%3D","line":202,"updated":"2013-06-17 13:29:42.000000000","message":"What are the semantics for a shared firewall?\nA shared network is a network where any tenant can create ports (even if with restrictions on IPAM).\nI guess a shared firewall is a firewall where every tenant can create a policy... but this clashes with the fact that it seems a firewall can have a single policy.\n\nSo a clarification will be welcome!","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \u0027shared\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":200,"context_line":"                   \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":201,"context_line":"                   \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"},{"line_number":202,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":203,"context_line":"        \u0027admin_state_up\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":204,"context_line":"                           \u0027default\u0027: True,"},{"line_number":205,"context_line":"                           \u0027convert_to\u0027: attr.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs6I%3D","line":202,"in_reply_to":"AAAAPn%2F%2F9go%3D","updated":"2013-06-24 23:17:56.000000000","message":"We were thinking of the use case where the provider owns a firewall and wants to make available to the tenants for use. The policy would be common to all the tenants using this firewall.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":209,"context_line":"        \u0027firewall_policy_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":210,"context_line":"                               \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None},"},{"line_number":211,"context_line":"                               \u0027is_visible\u0027: True},"},{"line_number":212,"context_line":"    },"},{"line_number":213,"context_line":"}"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9gY%3D","line":211,"updated":"2013-06-17 13:29:42.000000000","message":"The relationship between firewall and policy is sometimes noted as 1:1 and sometimes as 1:n in the specification.\n\nIt seems that the implementation is going for 1:1 or perhaps n:1 (the same policy reusable across firewalls).\n\nCan you clarify please?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                   \u0027is_visible\u0027: True},"},{"line_number":209,"context_line":"        \u0027firewall_policy_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":210,"context_line":"                               \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None},"},{"line_number":211,"context_line":"                               \u0027is_visible\u0027: True},"},{"line_number":212,"context_line":"    },"},{"line_number":213,"context_line":"}"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs54%3D","line":211,"in_reply_to":"AAAAPn%2F%2F9gY%3D","updated":"2013-06-24 23:17:56.000000000","message":"Yes, that\u0027s correct - \n* one Firewall is associated with exactly one Firewall Policy\n* one Firewall Policy can be used by multiple Firewalls\n\nI will check for the inconsistency in the document, but please feel free to fix/comment in the document.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    collection_name,"},{"line_number":265,"context_line":"                    controller,"},{"line_number":266,"context_line":"                    member_actions\u003dmember_actions,"},{"line_number":267,"context_line":"                    attr_map\u003dparams)"},{"line_number":268,"context_line":"            else:"},{"line_number":269,"context_line":"                resource \u003d extensions.ResourceExtension("},{"line_number":270,"context_line":"                    collection_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9UI%3D","line":267,"updated":"2013-06-17 13:29:42.000000000","message":"this might be a dumb question. In that case, apoligies in advance.\n\nwhy path_prefix applies only to resources!\u003dfirewall?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                    collection_name,"},{"line_number":265,"context_line":"                    controller,"},{"line_number":266,"context_line":"                    member_actions\u003dmember_actions,"},{"line_number":267,"context_line":"                    attr_map\u003dparams)"},{"line_number":268,"context_line":"            else:"},{"line_number":269,"context_line":"                resource \u003d extensions.ResourceExtension("},{"line_number":270,"context_line":"                    collection_name,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs5w%3D","line":267,"in_reply_to":"AAAAPn%2F%2F9UI%3D","updated":"2013-06-24 23:17:56.000000000","message":"Currently we have the path_prefixes as:\n\nFirewall: /firewalls\n\nFirewall Policies: /firewall/firewall_policies\n\nFirewall Rules: /firewall/firewall_rules","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        pass"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    @abc.abstractmethod"},{"line_number":335,"context_line":"    def create_firewall_rule(self, context, firewall_rule):"},{"line_number":336,"context_line":"        pass"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9T8%3D","line":335,"updated":"2013-06-17 13:29:42.000000000","message":"Interesting. What would be the use of a rule which is not bound to a policy (as you cannot specify the policy_id for a rule on a POST)","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        pass"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    @abc.abstractmethod"},{"line_number":335,"context_line":"    def create_firewall_rule(self, context, firewall_rule):"},{"line_number":336,"context_line":"        pass"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs40%3D","line":335,"in_reply_to":"AAAAPn%2F%2F9T8%3D","updated":"2013-06-24 23:17:56.000000000","message":"If the policy is deleted, the rule does not get deleted (hence can be reused). \n\nAlso the rule and the policy could be created by different users (and the policy does not have to be present for the rule to be created).","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":73,"context_line":"fw_valid_action_values \u003d [\u0027allow\u0027, \u0027deny\u0027]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def convert_protocol_to_case_insensitive(value):"},{"line_number":77,"context_line":"    if value is None:"},{"line_number":78,"context_line":"        return value"},{"line_number":79,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fra4%3D","line":76,"updated":"2013-06-25 13:21:50.000000000","message":"This and next convertion functions look almost the same. Consider having one convert_to_lower_case function which will throw an exception if value is not a string. For both action and protocol fields below you use type:values validation - it will display values that are allowed in the error message in case any wrong value is passed.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"fw_valid_action_values \u003d [\u0027allow\u0027, \u0027deny\u0027]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def convert_protocol_to_case_insensitive(value):"},{"line_number":77,"context_line":"    if value is None:"},{"line_number":78,"context_line":"        return value"},{"line_number":79,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fe4E%3D","line":76,"in_reply_to":"AAAAPn%2F%2Fra4%3D","updated":"2013-06-30 19:01:53.000000000","message":"This was a good suggestion, but I had to change this function to account for another suggestion for dealing with the protocol field.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":90,"context_line":"        return value.lower()"},{"line_number":91,"context_line":"    except AttributeError:"},{"line_number":92,"context_line":"        raise FirewallRuleInvalidAction("},{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_valid_action_values)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_validate_port_value(port):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FrfY%3D","line":93,"updated":"2013-06-25 13:21:50.000000000","message":"action\u003dvalue instead of protocol","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        return value.lower()"},{"line_number":91,"context_line":"    except AttributeError:"},{"line_number":92,"context_line":"        raise FirewallRuleInvalidAction("},{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_valid_action_values)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_validate_port_value(port):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fe4M%3D","line":93,"in_reply_to":"AAAAPn%2F%2FrfY%3D","updated":"2013-06-30 19:01:53.000000000","message":"Done","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":6461,"name":"Kaiwei Fan","email":"fank@vmware.com","username":"kaiwei-fan"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    \u0027firewall_rules\u0027: {"},{"line_number":112,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":113,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":114,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fo5w%3D","line":111,"updated":"2013-06-26 07:01:12.000000000","message":"This resource is very different from what we have discussed in fwaas-spec-v0.1 (https://docs.google.com/document/d/1PJaKvsX2MzMRlLGfR0fBkrMraHYF0flvl0sqyZ704tA/edit), which uses source/destination/service containers for grouped object, instead of just simple raw IP/port.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":111,"context_line":"    \u0027firewall_rules\u0027: {"},{"line_number":112,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":113,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":114,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fn%2FU%3D","line":111,"in_reply_to":"AAAAPn%2F%2Fo5w%3D","updated":"2013-06-26 14:35:56.000000000","message":"\"Source/destination containers\" for grouping objects will be done in a different up patch. This has been noted in the commit message.\n\nIn the simplest case (as in the reference implementation with iptables) it should not require the user to create extra objects for source and destination before creating a rule.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":176,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":178,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":181,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":182,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Frhw%3D","line":179,"updated":"2013-06-25 13:21:50.000000000","message":"A clarification on my earlier comment regarding default values of mutable types and possible side effects: the value of this resource map will be then assigned to a resource if not specified in the request, then it may be updated (by mistake or not, like adding new elements to a list) - it will change a default value in this map. So all subsequent created resources may get wrong default value. I faced such issue with loadbalancer extension. Given that you have a proper conversion from None I think it\u0027s not a problem to use None default value andalso  it will be safer.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":178,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":181,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":182,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fe4s%3D","line":179,"in_reply_to":"AAAAPn%2F%2Frhw%3D","updated":"2013-06-30 19:01:53.000000000","message":"Done","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @classmethod"},{"line_number":242,"context_line":"    def get_resources(cls):"},{"line_number":243,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":244,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":245,"context_line":"        resources \u003d []"},{"line_number":246,"context_line":"        plugin \u003d manager.QuantumManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Frfk%3D","line":243,"updated":"2013-06-25 13:21:50.000000000","message":"on #250 special handling for firewall_policies is done - it should be done for my_plurals too.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    @classmethod"},{"line_number":242,"context_line":"    def get_resources(cls):"},{"line_number":243,"context_line":"        my_plurals \u003d [(key, key[:-1]) for key in RESOURCE_ATTRIBUTE_MAP.keys()]"},{"line_number":244,"context_line":"        attr.PLURALS.update(dict(my_plurals))"},{"line_number":245,"context_line":"        resources \u003d []"},{"line_number":246,"context_line":"        plugin \u003d manager.QuantumManager.get_service_plugins()["}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fe4Q%3D","line":243,"in_reply_to":"AAAAPn%2F%2Frfk%3D","updated":"2013-06-30 19:01:53.000000000","message":"Done","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"            params \u003d RESOURCE_ATTRIBUTE_MAP[collection_name]"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"            member_actions \u003d {}"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            controller \u003d base.create_resource("},{"line_number":260,"context_line":"                collection_name, resource_name, plugin, params,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2FrgE%3D","line":257,"updated":"2013-06-25 13:21:50.000000000","message":"I see no resource here that has member_actions so it seems defining member_actions and passing them later is not needed.","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"            params \u003d RESOURCE_ATTRIBUTE_MAP[collection_name]"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"            member_actions \u003d {}"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"            controller \u003d base.create_resource("},{"line_number":260,"context_line":"                collection_name, resource_name, plugin, params,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAPn%2F%2Fe4k%3D","line":257,"in_reply_to":"AAAAPn%2F%2FrgE%3D","updated":"2013-06-30 19:01:53.000000000","message":"Done","commit_id":"92b355773ed2367401bf9f59a740d2a699f733b7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Firewall Exceptions"},{"line_number":34,"context_line":"class FirewallNotFound(qexception.NotFound):"},{"line_number":35,"context_line":"    message \u003d _(\"Firewall %(firewall_id)s could not be found\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class FirewallInUse(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhFg%3D","line":35,"updated":"2013-06-28 17:39:36.000000000","message":"nit: these messages should end with a .","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Firewall Exceptions"},{"line_number":34,"context_line":"class FirewallNotFound(qexception.NotFound):"},{"line_number":35,"context_line":"    message \u003d _(\"Firewall %(firewall_id)s could not be found\")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class FirewallInUse(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Fe44%3D","line":35,"in_reply_to":"AAAAPn%2F%2FhFg%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"fw_valid_protocol_values \u003d [None, \u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":73,"context_line":"fw_valid_action_values \u003d [\u0027allow\u0027, \u0027deny\u0027]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def convert_protocol_to_case_insensitive(value):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhEw%3D","line":73,"updated":"2013-06-28 17:39:36.000000000","message":"nit: consider putting this in constants.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"fw_valid_protocol_values \u003d [None, \u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027]"},{"line_number":73,"context_line":"fw_valid_action_values \u003d [\u0027allow\u0027, \u0027deny\u0027]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def convert_protocol_to_case_insensitive(value):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfcY%3D","line":73,"in_reply_to":"AAAAPn%2F%2FhEw%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":131,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":132,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":133,"context_line":"                     \u0027convert_to\u0027: convert_protocol_to_case_insensitive,"},{"line_number":134,"context_line":"                     \u0027validate\u0027: {\u0027type:values\u0027: fw_valid_protocol_values}},"},{"line_number":135,"context_line":"        \u0027source_ip_address\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":136,"context_line":"                              \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":137,"context_line":"                              \u0027is_visible\u0027: True, \u0027default\u0027: None},"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhFQ%3D","line":134,"updated":"2013-06-28 17:39:36.000000000","message":"We should also allow their protocol int values to work as security profiles now does as well.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        \u0027protocol\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":132,"context_line":"                     \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":133,"context_line":"                     \u0027convert_to\u0027: convert_protocol_to_case_insensitive,"},{"line_number":134,"context_line":"                     \u0027validate\u0027: {\u0027type:values\u0027: fw_valid_protocol_values}},"},{"line_number":135,"context_line":"        \u0027source_ip_address\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":136,"context_line":"                              \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":137,"context_line":"                              \u0027is_visible\u0027: True, \u0027default\u0027: None},"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfZ0%3D","line":134,"in_reply_to":"AAAAPn%2F%2FhFQ%3D","updated":"2013-06-30 19:02:43.000000000","message":"I have done this however I have introduced the convert_protocol method in this module so as to be able to independently validate the list of supported protocols (in case it happens to be different from those supported by security groups). This comes with duplication of few lines of code, but it\u0027s probably not a huge deal.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":176,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":178,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":181,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":182,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhE4%3D","line":179,"updated":"2013-06-28 17:39:36.000000000","message":"This should not default to a [] as this is a shared resource. I.e if someone adds something to this list next time an api call will be made that value will be in there if firewall_rules_list is empty.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":177,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":178,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":179,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":181,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":182,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Fe4w%3D","line":179,"in_reply_to":"AAAAPn%2F%2FhE4%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":181,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":182,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":183,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":184,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":185,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhE0%3D","line":182,"updated":"2013-06-28 17:39:36.000000000","message":"ditto","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":180,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":181,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":182,"context_line":"                           \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":183,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":184,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":185,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfZw%3D","line":182,"in_reply_to":"AAAAPn%2F%2FhE0%3D","updated":"2013-06-30 19:02:43.000000000","message":"Actually this just a read-only field (which is set by the backend).","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class FirewallRuleInvalidProtocol(qexception.InvalidInput):"},{"line_number":59,"context_line":"    message \u003d _(\"Firewall rule protocol %(protocol)s not supported. \""},{"line_number":60,"context_line":"                \"Only protocol values %(values)s supported.\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class FirewallRuleInvalidAction(qexception.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FecE%3D","line":60,"updated":"2013-07-01 07:23:32.000000000","message":"A value from 0 to 255 is accepted in convert_protocol. It is better to describe it.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class FirewallRuleInvalidProtocol(qexception.InvalidInput):"},{"line_number":59,"context_line":"    message \u003d _(\"Firewall rule protocol %(protocol)s not supported. \""},{"line_number":60,"context_line":"                \"Only protocol values %(values)s supported.\")"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class FirewallRuleInvalidAction(qexception.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZbE%3D","line":60,"in_reply_to":"AAAAPn%2F%2FecE%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":96,"context_line":"    if value is None:"},{"line_number":97,"context_line":"        return value"},{"line_number":98,"context_line":"    try:"},{"line_number":99,"context_line":"        return value.lower()"},{"line_number":100,"context_line":"    except AttributeError:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2Feb8%3D","line":97,"updated":"2013-07-01 07:23:32.000000000","message":"nit: just \"return\". it is better to keep consistent with the above.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":96,"context_line":"    if value is None:"},{"line_number":97,"context_line":"        return value"},{"line_number":98,"context_line":"    try:"},{"line_number":99,"context_line":"        return value.lower()"},{"line_number":100,"context_line":"    except AttributeError:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZf8%3D","line":97,"in_reply_to":"AAAAPn%2F%2Feb8%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":102,"context_line":"            action\u003dvalue, values\u003dfw_valid_action_values)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def convert_validate_port_value(port):"},{"line_number":106,"context_line":"    if port is None:"},{"line_number":107,"context_line":"        return port"},{"line_number":108,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2Feb0%3D","line":105,"updated":"2013-07-01 07:23:32.000000000","message":"\"validate\" is not needed in the method name. It is for consistency with the above two.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            action\u003dvalue, values\u003dfw_valid_action_values)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def convert_validate_port_value(port):"},{"line_number":106,"context_line":"    if port is None:"},{"line_number":107,"context_line":"        return port"},{"line_number":108,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZak%3D","line":105,"in_reply_to":"AAAAPn%2F%2Feb0%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def convert_validate_port_value(port):"},{"line_number":106,"context_line":"    if port is None:"},{"line_number":107,"context_line":"        return port"},{"line_number":108,"context_line":"    try:"},{"line_number":109,"context_line":"        val \u003d int(port)"},{"line_number":110,"context_line":"    except (ValueError, TypeError):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2Feb4%3D","line":107,"updated":"2013-07-01 07:23:32.000000000","message":"Ditto.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"def convert_validate_port_value(port):"},{"line_number":106,"context_line":"    if port is None:"},{"line_number":107,"context_line":"        return port"},{"line_number":108,"context_line":"    try:"},{"line_number":109,"context_line":"        val \u003d int(port)"},{"line_number":110,"context_line":"    except (ValueError, TypeError):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FZag%3D","line":107,"in_reply_to":"AAAAPn%2F%2Feb4%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":114,"context_line":"        return val"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeNE%3D","line":116,"updated":"2013-07-01 08:30:45.000000000","message":"I don\u0027t regard this as a major problem.\nHowever Quantum API validator usually return a message when the validation fails that it\u0027s then used for generating a BadRequest error which is returned to the client.\n\nI don\u0027t think it would be great for people maintaining the code to have them learn that if they go to extension \u0027a\u0027 validation works in a way, and then if they go to extension \u0027b\u0027 validation works in another way.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    if val \u003e\u003d 0 and val \u003c\u003d 65535:"},{"line_number":114,"context_line":"        return val"},{"line_number":115,"context_line":"    else:"},{"line_number":116,"context_line":"        raise FirewallInvalidPortValue(port\u003dport)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYtE%3D","line":116,"in_reply_to":"AAAAPn%2F%2FeNE%3D","updated":"2013-07-05 04:16:37.000000000","message":"I saw that other extensions are also following this approach of using the convert function to validate protocol. Is it something that you would like me to change for this patch or should this be a bigger cleanup?","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":120,"context_line":"    \u0027firewall_rules\u0027: {"},{"line_number":121,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":122,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":123,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeMQ%3D","line":120,"updated":"2013-07-01 08:30:45.000000000","message":"Until we have an API for adding/removing single rules to/from a firewall policy I would suggest making this resource as read only.\n\nUnless there is way for binding a rule to a policy and I\u0027m missing it.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":120,"context_line":"    \u0027firewall_rules\u0027: {"},{"line_number":121,"context_line":"        \u0027id\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":122,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":123,"context_line":"               \u0027is_visible\u0027: True, \u0027primary_key\u0027: True},"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FY2k%3D","line":120,"in_reply_to":"AAAAPn%2F%2FeMQ%3D","updated":"2013-07-05 04:16:37.000000000","message":"firewall_rule creation and associating with the policy are two independent operations. So I don\u0027t think we can make this resource read only (unless I am misunderstanding your suggestion).","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":186,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":187,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":188,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":189,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":190,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":191,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeKs%3D","line":188,"updated":"2013-07-01 08:30:45.000000000","message":"If you reckon the \u0027_list\u0027 suffix clarifies this is not a dict, which I find arguable, I am ok.\nHowever \u0027list\u0027 implicitly says \u0027look this attribute must have multiple elements\u0027.\nSo perhaps the plural is redundant: firewall_list and firewall_rule_list would be perhaps better names.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":186,"context_line":"        \u0027firewall_rules_list\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":187,"context_line":"                                \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":188,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":189,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":190,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":191,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FY48%3D","line":188,"in_reply_to":"AAAAPn%2F%2FeKs%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":189,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":190,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":191,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":192,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":193,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":194,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeKg%3D","line":191,"updated":"2013-07-01 08:30:45.000000000","message":"This is just an idea for improving the API.\nfirewalls_list is a useful piece of information, but the same piece can be returned by doing GET /firewall?firewall_policy_id\u003d\u003cpolicy_id\u003e\u0026field\u003did\n\nI understand you might think it\u0027s good to return all these information in one call, but perhaps from a user perspective the firewall policy and policy-firewall association are seen as concept logically different.\nAlso the operation of retrieving the firewall list from the db is a bit expensive at the moment, especially if you have a policy which is used by a lot of firewalls.\n\nSo, well, just consider whether we can do without the above attribute.\n\nPS: is convert_to really needed for readonly attributes?","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                \u0027default\u0027: [], \u0027is_visible\u0027: True},"},{"line_number":189,"context_line":"        \u0027firewalls_list\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":190,"context_line":"                           \u0027convert_to\u0027: attr.convert_none_to_empty_list,"},{"line_number":191,"context_line":"                           \u0027default\u0027: None, \u0027is_visible\u0027: True},"},{"line_number":192,"context_line":"        \u0027audited\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":193,"context_line":"                    \u0027default\u0027: False, \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":194,"context_line":"                    \u0027is_visible\u0027: True, \u0027required_by_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FY9k%3D","line":191,"in_reply_to":"AAAAPn%2F%2FeKg%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"1bf3cc1fa97ed6f73eaff809cd3760b85d7a13b6","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                    collection_name,"},{"line_number":285,"context_line":"                    controller,"},{"line_number":286,"context_line":"                    path_prefix\u003dconstants.COMMON_PREFIXES[constants.FIREWALL],"},{"line_number":287,"context_line":"                    attr_map\u003dparams)"},{"line_number":288,"context_line":"            resources.append(resource)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        return resources"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeLo%3D","line":287,"updated":"2013-07-01 08:30:45.000000000","message":"At this stage this is my only real concern with this patch.\nI don\u0027t want to appear pedant, but from the user perspective consistency across the api is important.\n\nLoad Balancer has:\n* lb/vip\n* lb/pools\n* lb/members\n* lb/health_monitors\n\n\nFirewall has:\n\n* /firewalls\n* /firewall/firewall_rules\n* /firewall/firewall_policies\n\nI reckon they should be harmonized, and I think the load balancer way is better. The way in which firewall rules are structure seems to put the policy and the rule as sub-resources which do not have an independent life cycle, which is not the case.\n\nBeyond that, the main reason for my concern is that API users should not have to remember that there are distinct ways to access resources for distinct API services. It wouldn\u0027t be great for the project if it looks as a bunch of independent APIs sticked together.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                    collection_name,"},{"line_number":285,"context_line":"                    controller,"},{"line_number":286,"context_line":"                    path_prefix\u003dconstants.COMMON_PREFIXES[constants.FIREWALL],"},{"line_number":287,"context_line":"                    attr_map\u003dparams)"},{"line_number":288,"context_line":"            resources.append(resource)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        return resources"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FY44%3D","line":287,"in_reply_to":"AAAAPn%2F%2FeLo%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done. Changed to:\n\nfw/firewalls\nfw/firwall_rules\nfw/firewall_policies","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        val \u003d int(value)"},{"line_number":82,"context_line":"        if val \u003e\u003d 0 and val \u003c\u003d 255:"},{"line_number":83,"context_line":"            return val"},{"line_number":84,"context_line":"        raise FirewallRuleInvalidProtocol("},{"line_number":85,"context_line":"            protocol\u003dvalue, values\u003dfw_valid_protocol_values)"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAPn%2F%2FWdQ%3D","line":82,"updated":"2013-07-03 14:37:33.000000000","message":"Can do 0\u003c\u003d val \u003c\u003d 255","commit_id":"200824a5cfb76f7695456229b632f78f50c70fd5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class FirewallRuleInUse(qexception.InUse):"},{"line_number":55,"context_line":"    message \u003d _(\"FirewallPolicy %(firewall_rule_id)s is being used.\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class FirewallRuleInvalidProtocol(qexception.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT1E%3D","line":55,"updated":"2013-07-04 11:50:54.000000000","message":"FirewallPolicy -\u003e FirewallRule","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class FirewallRuleInUse(qexception.InUse):"},{"line_number":55,"context_line":"    message \u003d _(\"FirewallPolicy %(firewall_rule_id)s is being used.\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class FirewallRuleInvalidProtocol(qexception.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz3w%3D","line":55,"in_reply_to":"AAAAPn%2F%2FT1E%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class FirewallRuleInvalidProtocol(qexception.InvalidInput):"},{"line_number":59,"context_line":"    message \u003d _(\"Firewall rule protocol %(protocol)s not supported. \""},{"line_number":60,"context_line":"                \"Only protocol values %(values)s and their integer \""},{"line_number":61,"context_line":"                \"representation (0 to 255) are supported.\")"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT04%3D","line":59,"updated":"2013-07-04 11:50:54.000000000","message":"nit: is not supported (\u0027is\u0027 missed)","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class FirewallRuleInvalidProtocol(qexception.InvalidInput):"},{"line_number":59,"context_line":"    message \u003d _(\"Firewall rule protocol %(protocol)s not supported. \""},{"line_number":60,"context_line":"                \"Only protocol values %(values)s and their integer \""},{"line_number":61,"context_line":"                \"representation (0 to 255) are supported.\")"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz3s%3D","line":59,"in_reply_to":"AAAAPn%2F%2FT04%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class FirewallRuleInvalidAction(qexception.InvalidInput):"},{"line_number":65,"context_line":"    message \u003d _(\"Firewall rule action %(action)s not supported. \""},{"line_number":66,"context_line":"                \"Only action values %(values)s supported.\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT00%3D","line":65,"updated":"2013-07-04 11:50:54.000000000","message":"nit: is not supported","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class FirewallRuleInvalidAction(qexception.InvalidInput):"},{"line_number":65,"context_line":"    message \u003d _(\"Firewall rule action %(action)s not supported. \""},{"line_number":66,"context_line":"                \"Only action values %(values)s supported.\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz3o%3D","line":65,"in_reply_to":"AAAAPn%2F%2FT00%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class FirewallRuleInvalidAction(qexception.InvalidInput):"},{"line_number":65,"context_line":"    message \u003d _(\"Firewall rule action %(action)s not supported. \""},{"line_number":66,"context_line":"                \"Only action values %(values)s supported.\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class FirewallInvalidPortValue(qexception.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FT0w%3D","line":66,"updated":"2013-07-04 11:50:54.000000000","message":"nit: are supported","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class FirewallRuleInvalidAction(qexception.InvalidInput):"},{"line_number":65,"context_line":"    message \u003d _(\"Firewall rule action %(action)s not supported. \""},{"line_number":66,"context_line":"                \"Only action values %(values)s supported.\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class FirewallInvalidPortValue(qexception.InvalidInput):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz3k%3D","line":66,"in_reply_to":"AAAAPn%2F%2FT0w%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_valid_protocol_values)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":97,"context_line":"    if value is None:"},{"line_number":98,"context_line":"        return"},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FTy4%3D","line":96,"updated":"2013-07-04 11:50:54.000000000","message":"maybe useful to add convert_to_lower() to api/v2/attributes.py and use it here","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            protocol\u003dvalue, values\u003dfw_valid_protocol_values)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def convert_action_to_case_insensitive(value):"},{"line_number":97,"context_line":"    if value is None:"},{"line_number":98,"context_line":"        return"},{"line_number":99,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz3U%3D","line":96,"in_reply_to":"AAAAPn%2F%2FTy4%3D","updated":"2013-07-11 07:58:22.000000000","message":"Currently no other module apart from this will use this. Until some other module decides to use this, I would prefer to leave it here so that it can be managed in the context of this module.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"}],"quantum/plugins/services/firewall/fwaas_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8994319057650ebd7162f3aea3ae48ceb680c012","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":47,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":48,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":49,"context_line":"            firewall \u003d qry.one()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            if status in (const.ACTIVE, const.INACTIVE):"},{"line_number":52,"context_line":"                firewall.status \u003d status"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2Fu6c%3D","line":49,"updated":"2013-06-11 19:04:42.000000000","message":"should these be chained together? or maybe the last two?","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":47,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":48,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":49,"context_line":"            firewall \u003d qry.one()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            if status in (const.ACTIVE, const.INACTIVE):"},{"line_number":52,"context_line":"                firewall.status \u003d status"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2FuzU%3D","line":49,"updated":"2013-06-11 19:37:57.000000000","message":"you need to catch NoResultFound exception and reraise FirewallNotFound","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":47,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":48,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":49,"context_line":"            firewall \u003d qry.one()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            if status in (const.ACTIVE, const.INACTIVE):"},{"line_number":52,"context_line":"                firewall.status \u003d status"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FszQ%3D","line":49,"in_reply_to":"AAAAPX%2F%2FuzU%3D","updated":"2013-06-24 23:33:14.000000000","message":"Done","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8994319057650ebd7162f3aea3ae48ceb680c012","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":60,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":61,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":62,"context_line":"            firewall \u003d qry.one()"},{"line_number":63,"context_line":"            if firewall[\u0027status\u0027] \u003d\u003d const.PENDING_DELETE:"},{"line_number":64,"context_line":"                self.plugin.delete_firewall(context, firewall_id)"},{"line_number":65,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2Fu6U%3D","line":62,"updated":"2013-06-11 19:04:42.000000000","message":"Ditto on chaining.","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":59,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":60,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":61,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":62,"context_line":"            firewall \u003d qry.one()"},{"line_number":63,"context_line":"            if firewall[\u0027status\u0027] \u003d\u003d const.PENDING_DELETE:"},{"line_number":64,"context_line":"                self.plugin.delete_firewall(context, firewall_id)"},{"line_number":65,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2FuzQ%3D","line":62,"updated":"2013-06-11 19:37:57.000000000","message":"ditto","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":60,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":61,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":62,"context_line":"            firewall \u003d qry.one()"},{"line_number":63,"context_line":"            if firewall[\u0027status\u0027] \u003d\u003d const.PENDING_DELETE:"},{"line_number":64,"context_line":"                self.plugin.delete_firewall(context, firewall_id)"},{"line_number":65,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FszM%3D","line":62,"in_reply_to":"AAAAPX%2F%2FuzQ%3D","updated":"2013-06-24 23:33:14.000000000","message":"Done","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":145,"context_line":"                              self).get_firewall_policy(context,"},{"line_number":146,"context_line":"                                                        fw_policy_id)"},{"line_number":147,"context_line":"            fw_rules_list \u003d []"},{"line_number":148,"context_line":"            for rule_id in fw_policy[\u0027firewall_rules_list\u0027]:"},{"line_number":149,"context_line":"                fw_rule \u003d super(FirewallPlugin,"},{"line_number":150,"context_line":"                                self).get_firewall_policy(context,"},{"line_number":151,"context_line":"                                                          rule_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2Furw%3D","line":148,"updated":"2013-06-11 19:37:57.000000000","message":"This block is highly inefficient:\nyou\u0027ve fetched firewall policy together with firewall rules, then you\u0027ve filled fw_policy[\u0027firewall_rules_list\u0027] with ids instead of objects (see _make_firewall_policy_dict) and the you are querying the very same policy rules objects by their ids!\n\nI\u0027d suggest you introduce default parameter to get_firewall_policy and then to _make_firewall_policy_dict which will switch between ids only and objects.\nOtherwise you\u0027ll need to introduce another method which will fetch all rules for the policy at once.","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                              self).get_firewall_policy(context,"},{"line_number":146,"context_line":"                                                        fw_policy_id)"},{"line_number":147,"context_line":"            fw_rules_list \u003d []"},{"line_number":148,"context_line":"            for rule_id in fw_policy[\u0027firewall_rules_list\u0027]:"},{"line_number":149,"context_line":"                fw_rule \u003d super(FirewallPlugin,"},{"line_number":150,"context_line":"                                self).get_firewall_policy(context,"},{"line_number":151,"context_line":"                                                          rule_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FsyQ%3D","line":148,"in_reply_to":"AAAAPX%2F%2Furw%3D","updated":"2013-06-24 23:33:14.000000000","message":"Yes, I documented below in the TODO section that this is not an efficient implementation.\n\nI will attempt optimization in a subsequent iteration after I ensure correctness.\n\nPlease note that these operations are infrequent.","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"}],"quantum/services/firewall/__init__.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9T0%3D","line":1,"updated":"2013-06-17 13:29:42.000000000","message":"I don\u0027t think that preparation of the directory strucure should be part of this patch. This applies to several files in this patch.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs4k%3D","line":1,"in_reply_to":"AAAAPn%2F%2F9T0%3D","updated":"2013-06-24 23:17:56.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"}],"quantum/services/firewall/agents/__init__.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9Ts%3D","line":1,"updated":"2013-06-17 13:29:42.000000000","message":"Folder structure preparation should not be part of this patch, in my opinion.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs4g%3D","line":1,"in_reply_to":"AAAAPn%2F%2F9Ts%3D","updated":"2013-06-24 23:17:56.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"}],"quantum/services/firewall/agents/quantum-l3/__init__.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9To%3D","line":1,"updated":"2013-06-17 13:29:42.000000000","message":"Folder structure preparation should not be part of this patch, in my opinion.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs4c%3D","line":1,"in_reply_to":"AAAAPn%2F%2F9To%3D","updated":"2013-06-24 23:17:56.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"}],"quantum/services/firewall/drivers/__init__.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9Tk%3D","line":1,"updated":"2013-06-17 13:29:42.000000000","message":"Folder structure preparation should not be part of this patch, in my opinion.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs4Y%3D","line":1,"in_reply_to":"AAAAPn%2F%2F9Tk%3D","updated":"2013-06-24 23:17:56.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"}],"quantum/services/firewall/drivers/iptables/__init__.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9Tg%3D","line":1,"updated":"2013-06-17 13:29:42.000000000","message":"Folder structure preparation should not be part of this patch, in my opinion.","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 OpenStack Foundation."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs4U%3D","line":1,"in_reply_to":"AAAAPn%2F%2F9Tg%3D","updated":"2013-06-24 23:17:56.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"}],"quantum/services/firewall/fwaas_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"448543887abe90e7f5da3e5d728ab8755fc09e0b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":47,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":48,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":49,"context_line":"            firewall \u003d qry.one()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            if status in (const.ACTIVE, const.INACTIVE):"},{"line_number":52,"context_line":"                firewall.status \u003d status"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2F9QQ%3D","line":49,"updated":"2013-06-17 13:29:42.000000000","message":"Do you need to handle NoResultsFound?","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":47,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":48,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":49,"context_line":"            firewall \u003d qry.one()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            if status in (const.ACTIVE, const.INACTIVE):"},{"line_number":52,"context_line":"                firewall.status \u003d status"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2Fs4M%3D","line":49,"in_reply_to":"AAAAPn%2F%2F9QQ%3D","updated":"2013-06-24 23:17:56.000000000","message":"Done","commit_id":"2f7d0840ef85ec104543cdd7bb8027b1ed5075ab"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":"                fw.status \u003d status"},{"line_number":59,"context_line":"            else:"},{"line_number":60,"context_line":"                fw.status \u003d const.ERROR"},{"line_number":61,"context_line":"        return True"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def firewall_deleted(self, context, firewall_id, **kwargs):"},{"line_number":64,"context_line":"        \"\"\"Agent uses this to indicate firewall is deleted.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhEg%3D","line":61,"updated":"2013-06-28 17:39:36.000000000","message":"doesn\u0027t see like this returns anything other than True so we probably don\u0027t need to return this.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                fw.status \u003d status"},{"line_number":59,"context_line":"            else:"},{"line_number":60,"context_line":"                fw.status \u003d const.ERROR"},{"line_number":61,"context_line":"        return True"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def firewall_deleted(self, context, firewall_id, **kwargs):"},{"line_number":64,"context_line":"        \"\"\"Agent uses this to indicate firewall is deleted.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfYU%3D","line":61,"in_reply_to":"AAAAPn%2F%2FhEg%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"# @author: Sumit Naiksatam, sumitnaiksatam@gmail.com, Big Switch Networks, Inc."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from sqlalchemy.orm import exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.common import rpc as q_rpc"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeaA%3D","line":21,"updated":"2013-07-01 07:23:32.000000000","message":"This line is not needed. Both modules are third party.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# @author: Sumit Naiksatam, sumitnaiksatam@gmail.com, Big Switch Networks, Inc."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from sqlalchemy.orm import exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo.config import cfg"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.common import rpc as q_rpc"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYsQ%3D","line":21,"in_reply_to":"AAAAPn%2F%2FeaA%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return const.FIREWALL"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_plugin_description(self):"},{"line_number":147,"context_line":"        return \"Quantum Firewall Service Plugin\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def _make_firewall_dict_with_rules(self, context, firewall_id):"},{"line_number":150,"context_line":"        firewall \u003d super(FirewallPlugin, self).get_firewall(context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeZg%3D","line":147,"updated":"2013-07-01 07:23:32.000000000","message":"These two methods are defined in extension/firewall.py and i don\u0027t think they needs to be redefined.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        return const.FIREWALL"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_plugin_description(self):"},{"line_number":147,"context_line":"        return \"Quantum Firewall Service Plugin\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def _make_firewall_dict_with_rules(self, context, firewall_id):"},{"line_number":150,"context_line":"        firewall \u003d super(FirewallPlugin, self).get_firewall(context,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYpc%3D","line":147,"in_reply_to":"AAAAPn%2F%2FeZg%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":31,"context_line":"from quantum.plugins.common import constants as const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class FirewallCallbacks(object):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FTyU%3D","line":33,"updated":"2013-07-04 11:50:54.000000000","message":"nit: LOG is not used in the module","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":31,"context_line":"from quantum.plugins.common import constants as const"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class FirewallCallbacks(object):"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz2k%3D","line":33,"in_reply_to":"AAAAPn%2F%2FTyU%3D","updated":"2013-07-11 07:58:22.000000000","message":"Being used now.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def set_firewall_status(self, context, firewall_id, status,"},{"line_number":46,"context_line":"                            **kwargs):"},{"line_number":47,"context_line":"        \"\"\"Agent uses this to set a firewall\u0027s status.\"\"\""},{"line_number":48,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":49,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":50,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":51,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FTqc%3D","line":48,"updated":"2013-07-04 11:53:49.000000000","message":"Consider moving all db logic to firewall db plugin and just call plugin methods here in callbacks.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def set_firewall_status(self, context, firewall_id, status,"},{"line_number":46,"context_line":"                            **kwargs):"},{"line_number":47,"context_line":"        \"\"\"Agent uses this to set a firewall\u0027s status.\"\"\""},{"line_number":48,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":49,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":50,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":51,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz2Y%3D","line":48,"in_reply_to":"AAAAPn%2F%2FTqc%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def firewall_deleted(self, context, firewall_id, **kwargs):"},{"line_number":64,"context_line":"        \"\"\"Agent uses this to indicate firewall is deleted.\"\"\""},{"line_number":65,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":66,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":67,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":68,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FTx4%3D","line":65,"updated":"2013-07-04 11:50:54.000000000","message":"ditto","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def firewall_deleted(self, context, firewall_id, **kwargs):"},{"line_number":64,"context_line":"        \"\"\"Agent uses this to indicate firewall is deleted.\"\"\""},{"line_number":65,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":66,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":67,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":68,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz2U%3D","line":65,"in_reply_to":"AAAAPn%2F%2FTx4%3D","updated":"2013-07-11 07:58:22.000000000","message":"Done","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.conn.consume_in_thread()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.agent_rpc \u003d FirewallAgentApi("},{"line_number":138,"context_line":"            topics.L3_AGENT,"},{"line_number":139,"context_line":"            cfg.CONF.host"},{"line_number":140,"context_line":"        )"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FTss%3D","line":138,"updated":"2013-07-04 11:50:54.000000000","message":"wrong topic I believe","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.conn.consume_in_thread()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        self.agent_rpc \u003d FirewallAgentApi("},{"line_number":138,"context_line":"            topics.L3_AGENT,"},{"line_number":139,"context_line":"            cfg.CONF.host"},{"line_number":140,"context_line":"        )"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2Fz2c%3D","line":138,"in_reply_to":"AAAAPn%2F%2FTss%3D","updated":"2013-07-11 07:58:22.000000000","message":"We are actually using this topic.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            **kwargs):"},{"line_number":47,"context_line":"        \"\"\"Agent uses this to set a firewall\u0027s status.\"\"\""},{"line_number":48,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":49,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":50,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":51,"context_line":"            try:"},{"line_number":52,"context_line":"                fw_db \u003d qry.one()"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2F%2Fxg%3D","line":49,"updated":"2013-07-06 19:18:06.000000000","message":"looks like plugin._get_firewall could be used here if  it was public method","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                            **kwargs):"},{"line_number":47,"context_line":"        \"\"\"Agent uses this to set a firewall\u0027s status.\"\"\""},{"line_number":48,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":49,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":50,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":51,"context_line":"            try:"},{"line_number":52,"context_line":"                fw_db \u003d qry.one()"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2Fzu8%3D","line":49,"in_reply_to":"AAAAP3%2F%2F%2Fxg%3D","updated":"2013-07-11 07:58:46.000000000","message":"Done","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Agent uses this to indicate firewall is deleted.\"\"\""},{"line_number":65,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":66,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":67,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":68,"context_line":"            try:"},{"line_number":69,"context_line":"                fw_db \u003d qry.one()"},{"line_number":70,"context_line":"            except exc.NoResultFound:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2F%2Fxk%3D","line":67,"updated":"2013-07-06 19:18:06.000000000","message":"ditto","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \"\"\"Agent uses this to indicate firewall is deleted.\"\"\""},{"line_number":65,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":66,"context_line":"            qry \u003d context.session.query(firewall_db.Firewall)"},{"line_number":67,"context_line":"            qry \u003d qry.filter_by(id\u003dfirewall_id)"},{"line_number":68,"context_line":"            try:"},{"line_number":69,"context_line":"                fw_db \u003d qry.one()"},{"line_number":70,"context_line":"            except exc.NoResultFound:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2Fzu0%3D","line":67,"in_reply_to":"AAAAP3%2F%2F%2Fxk%3D","updated":"2013-07-11 07:58:46.000000000","message":"Done","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"}],"quantum/tests/unit/db/firewall/test_db_firewall.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"677c0d7b6d8245dde396b836725c1530fa97607a","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @contextlib.contextmanager"},{"line_number":93,"context_line":"    def firewall(self, fmt\u003dNone, name\u003d\u0027firewall1\u0027, firewall_policy_id\u003dNone,"},{"line_number":94,"context_line":"\t\t admin_state_up\u003dTrue, no_delete\u003dFalse, **kwargs):"},{"line_number":95,"context_line":"        if not fmt:"},{"line_number":96,"context_line":"            fmt \u003d self.fmt"},{"line_number":97,"context_line":"        res \u003d self._create_firewall(fmt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FWic%3D","line":94,"updated":"2013-05-13 22:06:52.000000000","message":"tabs","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @contextlib.contextmanager"},{"line_number":93,"context_line":"    def firewall(self, fmt\u003dNone, name\u003d\u0027firewall1\u0027, firewall_policy_id\u003dNone,"},{"line_number":94,"context_line":"\t\t admin_state_up\u003dTrue, no_delete\u003dFalse, **kwargs):"},{"line_number":95,"context_line":"        if not fmt:"},{"line_number":96,"context_line":"            fmt \u003d self.fmt"},{"line_number":97,"context_line":"        res \u003d self._create_firewall(fmt,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fsv4%3D","line":94,"in_reply_to":"AAAAOn%2F%2FWic%3D","updated":"2013-06-24 23:40:15.000000000","message":"Done","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":65,"context_line":"    resource_prefix_map[\u0027firewalls\u0027] \u003d \u0027\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def setUp(self, core_plugin\u003dNone, fw_plugin\u003dNone):"},{"line_number":68,"context_line":"        service_plugins \u003d {\u0027fw_plugin_name\u0027: DB_FW_PLUGIN_KLASS}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        fdb.Firewall_db_mixin.supported_extension_aliases \u003d [\"fwaas\"]"},{"line_number":71,"context_line":"        super(FirewallPluginDbTestCase, self).setUp("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F2S0%3D","line":68,"updated":"2013-05-21 19:26:24.000000000","message":"That should be {constants.FIREWALL: DB_FW_PLUGIN_KLASS}, but it seems you redefine service plugins in L78, so it\u0027s needless.","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    resource_prefix_map[\u0027firewalls\u0027] \u003d \u0027\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def setUp(self, core_plugin\u003dNone, fw_plugin\u003dNone):"},{"line_number":68,"context_line":"        service_plugins \u003d {\u0027fw_plugin_name\u0027: DB_FW_PLUGIN_KLASS}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        fdb.Firewall_db_mixin.supported_extension_aliases \u003d [\"fwaas\"]"},{"line_number":71,"context_line":"        super(FirewallPluginDbTestCase, self).setUp("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fsvg%3D","line":68,"in_reply_to":"AAAAPH%2F%2F2S0%3D","updated":"2013-06-24 23:55:06.000000000","message":"Done","commit_id":"98aafa331f3267032da508a1df44ee6e6a126c53"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":482,"context_line":"                for k, v in keys:"},{"line_number":483,"context_line":"                    self.assertEqual(res[\u0027firewall\u0027][k], v)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def test_delete_firewall(self):"},{"line_number":486,"context_line":"        with self.firewall_policy(no_delete\u003dTrue) as fwp:"},{"line_number":487,"context_line":"            fwp_id \u003d fwp[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":488,"context_line":"            with self.firewall(firewall_policy_id\u003dfwp_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fswk%3D","line":485,"updated":"2013-05-25 11:48:23.000000000","message":"Looks like test doesn\u0027t check that fw is deleted.\nI think you should fetch fw collection and test it\u0027s empty or something","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                for k, v in keys:"},{"line_number":483,"context_line":"                    self.assertEqual(res[\u0027firewall\u0027][k], v)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def test_delete_firewall(self):"},{"line_number":486,"context_line":"        with self.firewall_policy(no_delete\u003dTrue) as fwp:"},{"line_number":487,"context_line":"            fwp_id \u003d fwp[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":488,"context_line":"            with self.firewall(firewall_policy_id\u003dfwp_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPn%2F%2FlYE%3D","line":485,"in_reply_to":"AAAAPH%2F%2Fswk%3D","updated":"2013-06-27 10:08:20.000000000","message":"Done","commit_id":"0aec86f11ae281daa993078e27003c68acf1d65e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8994319057650ebd7162f3aea3ae48ceb680c012","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from quantum.common import config"},{"line_number":29,"context_line":"from quantum.db.firewall import firewall_db as fdb"},{"line_number":30,"context_line":"import quantum.extensions"},{"line_number":31,"context_line":"from quantum.extensions import firewall"},{"line_number":32,"context_line":"from quantum.openstack.common import importutils"},{"line_number":33,"context_line":"from quantum.plugins.common import constants"},{"line_number":34,"context_line":"from quantum.tests.unit import test_db_plugin"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2Fu4U%3D","line":31,"updated":"2013-06-11 19:04:42.000000000","message":"Two import lines for quantum.extensions?","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from quantum.common import config"},{"line_number":29,"context_line":"from quantum.db.firewall import firewall_db as fdb"},{"line_number":30,"context_line":"import quantum.extensions"},{"line_number":31,"context_line":"from quantum.extensions import firewall"},{"line_number":32,"context_line":"from quantum.openstack.common import importutils"},{"line_number":33,"context_line":"from quantum.plugins.common import constants"},{"line_number":34,"context_line":"from quantum.tests.unit import test_db_plugin"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fsx8%3D","line":31,"in_reply_to":"AAAAPX%2F%2Fu4U%3D","updated":"2013-06-24 23:33:14.000000000","message":"Yeah, both are being used.","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"ROOTDIR \u003d os.path.dirname(__file__) + \u0027../../../..\u0027"},{"line_number":42,"context_line":"ETCDIR \u003d os.path.join(ROOTDIR, \u0027etc\u0027)"},{"line_number":43,"context_line":"extensions_path \u003d \u0027:\u0027.join(quantum.extensions.__path__)"},{"line_number":44,"context_line":"SHARED \u003d True"},{"line_number":45,"context_line":"PROTOCOL \u003d \u0027tcp\u0027"},{"line_number":46,"context_line":"SOURCE_IP_ADDRESS_RAW \u003d \u00271.1.1.1\u0027"},{"line_number":47,"context_line":"DESTINATION_IP_ADDRESS_RAW \u003d \u00272.2.2.2\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhDw%3D","line":44,"updated":"2013-06-28 17:39:36.000000000","message":"nit: These don\u0027t need to be be globally defined here when they are just copied into the class  on 89-98; remove one","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"ROOTDIR \u003d os.path.dirname(__file__) + \u0027../../../..\u0027"},{"line_number":42,"context_line":"ETCDIR \u003d os.path.join(ROOTDIR, \u0027etc\u0027)"},{"line_number":43,"context_line":"extensions_path \u003d \u0027:\u0027.join(quantum.extensions.__path__)"},{"line_number":44,"context_line":"SHARED \u003d True"},{"line_number":45,"context_line":"PROTOCOL \u003d \u0027tcp\u0027"},{"line_number":46,"context_line":"SOURCE_IP_ADDRESS_RAW \u003d \u00271.1.1.1\u0027"},{"line_number":47,"context_line":"DESTINATION_IP_ADDRESS_RAW \u003d \u00272.2.2.2\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfQY%3D","line":44,"in_reply_to":"AAAAPn%2F%2FhDw%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":654,"context_line":"        name \u003d \"new_firewall1\""},{"line_number":655,"context_line":"        keys \u003d self._get_test_firewall_attrs(name)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        with self.firewall_policy(no_delete\u003dTrue) as fwp:"},{"line_number":658,"context_line":"            fwp_id \u003d fwp[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":659,"context_line":"            keys.append((\u0027firewall_policy_id\u0027, fwp_id))"},{"line_number":660,"context_line":"            with self.firewall(firewall_policy_id\u003dfwp_id,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhDY%3D","line":657,"updated":"2013-06-28 17:39:36.000000000","message":"why no_delete\u003dTrue; it would be better to have it delete just to add move testing","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        name \u003d \"new_firewall1\""},{"line_number":655,"context_line":"        keys \u003d self._get_test_firewall_attrs(name)"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"        with self.firewall_policy(no_delete\u003dTrue) as fwp:"},{"line_number":658,"context_line":"            fwp_id \u003d fwp[\u0027firewall_policy\u0027][\u0027id\u0027]"},{"line_number":659,"context_line":"            keys.append((\u0027firewall_policy_id\u0027, fwp_id))"},{"line_number":660,"context_line":"            with self.firewall(firewall_policy_id\u003dfwp_id,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Fe48%3D","line":657,"in_reply_to":"AAAAPn%2F%2FhDY%3D","updated":"2013-06-30 19:02:43.000000000","message":"Done","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":679,"context_line":"    def test_show_firewall_rule_with_fw_policy_associated(self):"},{"line_number":680,"context_line":"        #TODO(Sumit): XML formatting does not seem to be handling lists"},{"line_number":681,"context_line":"        # correctly, hence skipping this test for now"},{"line_number":682,"context_line":"        pass"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def test_update_firewall_policy_with_rules(self):"},{"line_number":685,"context_line":"        #TODO(Sumit): XML formatting does not seem to be handling lists"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeWM%3D","line":682,"updated":"2013-07-01 07:23:32.000000000","message":"It is better to use self.skipTest(\u0027xxxx\u0027). We can easily know the tests are skipped at the moment.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":679,"context_line":"    def test_show_firewall_rule_with_fw_policy_associated(self):"},{"line_number":680,"context_line":"        #TODO(Sumit): XML formatting does not seem to be handling lists"},{"line_number":681,"context_line":"        # correctly, hence skipping this test for now"},{"line_number":682,"context_line":"        pass"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def test_update_firewall_policy_with_rules(self):"},{"line_number":685,"context_line":"        #TODO(Sumit): XML formatting does not seem to be handling lists"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYY8%3D","line":682,"in_reply_to":"AAAAPn%2F%2FeWM%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":676,"context_line":"    fmt \u003d \u0027xml\u0027"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def test_show_firewall_rule_with_fw_policy_associated(self):"},{"line_number":679,"context_line":"        #TODO(Sumit): XML formatting does not seem to be handling lists"},{"line_number":680,"context_line":"        # correctly, hence skipping this test for now"},{"line_number":681,"context_line":"        self.skipTest(\"Skipping since list handling is failing\")"},{"line_number":682,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAPn%2F%2FTq0%3D","line":679,"updated":"2013-07-04 11:50:54.000000000","message":"I think it\u0027s a good practice to file bugs in such cases and include bug number into TODO comment.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    fmt \u003d \u0027xml\u0027"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def test_show_firewall_rule_with_fw_policy_associated(self):"},{"line_number":679,"context_line":"        #TODO(Sumit): XML formatting does not seem to be handling lists"},{"line_number":680,"context_line":"        # correctly, hence skipping this test for now"},{"line_number":681,"context_line":"        self.skipTest(\"Skipping since list handling is failing\")"},{"line_number":682,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAAP3%2F%2FzZQ%3D","line":679,"in_reply_to":"AAAAPn%2F%2FTq0%3D","updated":"2013-07-11 07:58:22.000000000","message":"Will do.","commit_id":"15172a848b176691cd57b130a633d2b8298c8306"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import webob.exc"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from quantum.api.extensions import ExtensionMiddleware"},{"line_number":26,"context_line":"from quantum.api.extensions import PluginAwareExtensionManager"},{"line_number":27,"context_line":"from quantum.common import config"},{"line_number":28,"context_line":"from quantum import context"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2F%2Fxw%3D","line":25,"updated":"2013-07-06 19:18:06.000000000","message":"I think usually modules are imported, not classes","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import webob.exc"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from quantum.api.extensions import ExtensionMiddleware"},{"line_number":26,"context_line":"from quantum.api.extensions import PluginAwareExtensionManager"},{"line_number":27,"context_line":"from quantum.common import config"},{"line_number":28,"context_line":"from quantum import context"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2Fz0s%3D","line":25,"in_reply_to":"AAAAP3%2F%2F%2Fxw%3D","updated":"2013-07-11 07:58:46.000000000","message":"Done","commit_id":"bf2e5a2f91426a7835da5060f8a48014a44e1905"}],"quantum/tests/unit/services/firewall/test_fwaas_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Sumit Naiksatam, sumitnaiksatam@gmail.com, Big Switch Networks, Inc."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import contextlib"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantum import context"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeV8%3D","line":20,"updated":"2013-07-01 07:23:32.000000000","message":"We need a blank line between L.20 and 21. contextlib is a standard library, but mock is third party.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# @author: Sumit Naiksatam, sumitnaiksatam@gmail.com, Big Switch Networks, Inc."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import contextlib"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantum import context"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYW0%3D","line":20,"in_reply_to":"AAAAPn%2F%2FeV8%3D","updated":"2013-07-05 04:16:37.000000000","message":"Done","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self._call_test_helper(\u0027delete_firewall\u0027)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class TestFirewallPluginBase(test_db_firewall.TestFirewallDBPlugin):"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def setUp(self):"},{"line_number":136,"context_line":"        super(TestFirewallPluginBase, self).setUp(fw_plugin\u003dFW_PLUGIN_KLASS)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FeVY%3D","line":133,"updated":"2013-07-01 07:23:32.000000000","message":"I think we need to check methods of FirewallAgentApi are called appropriately here.","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"ecd696f335dbf792128cc9c75ede75fa8736a2fe","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self._call_test_helper(\u0027delete_firewall\u0027)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"class TestFirewallPluginBase(test_db_firewall.TestFirewallDBPlugin):"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def setUp(self):"},{"line_number":136,"context_line":"        super(TestFirewallPluginBase, self).setUp(fw_plugin\u003dFW_PLUGIN_KLASS)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYVg%3D","line":133,"in_reply_to":"AAAAPn%2F%2FeVY%3D","updated":"2013-07-05 04:16:37.000000000","message":"I am trying to do this in the class above TestFirewallAgentApi. Is there something more that I need to do?","commit_id":"7fea5aeec69efb9f3e017a0bd53bacc4eed366b2"}],"quantum/tests/unit/test_extension_firewall.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8994319057650ebd7162f3aea3ae48ceb680c012","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return []"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class FirewallExtensionTestCase(testlib_api.WebTestCase):"},{"line_number":61,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2Fu0Q%3D","line":60,"updated":"2013-06-11 19:04:42.000000000","message":"Negative test cases?","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        return []"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class FirewallExtensionTestCase(testlib_api.WebTestCase):"},{"line_number":61,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fsx4%3D","line":60,"in_reply_to":"AAAAPX%2F%2Fu0Q%3D","updated":"2013-06-24 23:33:14.000000000","message":"Have added some.","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8994319057650ebd7162f3aea3ae48ceb680c012","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if entity \u003d\u003d \u0027firewall\u0027:"},{"line_number":103,"context_line":"            path_prefix \u003d \u0027\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if entity \u003d\u003d \u0027firewall_policy\u0027:"},{"line_number":106,"context_line":"            entity_plural \u003d \u0027firewall_policies\u0027"},{"line_number":107,"context_line":"        else:"},{"line_number":108,"context_line":"            entity_plural \u003d entity + \u0027s\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPX%2F%2Fu0U%3D","line":105,"updated":"2013-06-11 19:04:42.000000000","message":"This logic is in several places. Maybe make a helper function either in test or production code?","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if entity \u003d\u003d \u0027firewall\u0027:"},{"line_number":103,"context_line":"            path_prefix \u003d \u0027\u0027"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if entity \u003d\u003d \u0027firewall_policy\u0027:"},{"line_number":106,"context_line":"            entity_plural \u003d \u0027firewall_policies\u0027"},{"line_number":107,"context_line":"        else:"},{"line_number":108,"context_line":"            entity_plural \u003d entity + \u0027s\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fsx0%3D","line":105,"in_reply_to":"AAAAPX%2F%2Fu0U%3D","updated":"2013-06-24 23:33:14.000000000","message":"Sorry, but I could not find the other places where this exact code is duplicated.","commit_id":"cad32ee7684797ba6ca9cbb7eb6b42a6a2b99bad"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":389,"context_line":"                            self.serialize(data),"},{"line_number":390,"context_line":"                            content_type\u003d\u0027application/%s\u0027 % self.fmt)"},{"line_number":391,"context_line":"        \"\"\""},{"line_number":392,"context_line":"        instance.create_firewall_policy.assert_called_with(mock.ANY,"},{"line_number":393,"context_line":"                                                           firewall_policy\u003d"},{"line_number":394,"context_line":"                                                           data)"},{"line_number":395,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FhDQ%3D","line":392,"updated":"2013-06-28 17:39:36.000000000","message":"whoops","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                            self.serialize(data),"},{"line_number":390,"context_line":"                            content_type\u003d\u0027application/%s\u0027 % self.fmt)"},{"line_number":391,"context_line":"        \"\"\""},{"line_number":392,"context_line":"        instance.create_firewall_policy.assert_called_with(mock.ANY,"},{"line_number":393,"context_line":"                                                           firewall_policy\u003d"},{"line_number":394,"context_line":"                                                           data)"},{"line_number":395,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2FfYQ%3D","line":392,"in_reply_to":"AAAAPn%2F%2FhDQ%3D","updated":"2013-06-30 19:02:43.000000000","message":"This is intentionally commented out as the serialization of lists in XML doesn\u0027t seem to be working for me.","commit_id":"f99a0e32745625423e679a2ae750dcc1df4d2aff"}],"quantum/tests/unit/test_firewall_plugin.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"677c0d7b6d8245dde396b836725c1530fa97607a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FWkQ%3D","line":1,"updated":"2013-05-13 22:06:52.000000000","message":"I know it\u0027s some confusing naming practice in quantum which I can not agree with:\nthe name of a file test_firewall_plugin.py but in fact it is testing an extension. Could you rename file to test_firewall_extension.py?","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e90fefda64cbc31eff3f97a977a0b1fff99f79bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 Big Switch Networks, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2Fsvs%3D","line":1,"in_reply_to":"AAAAOn%2F%2FWkQ%3D","updated":"2013-06-24 23:40:15.000000000","message":"Done","commit_id":"014e7e4f016d8860b09a8c76e74fe58613069f21"}]}
