)]}'
{"neutron/tests/unit/plugins/ml2/extensions/test_dns_integration.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b58363b89739fb69739a8572d9b626a585edc283","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.tests.unit.plugins.ml2 import test_plugin"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"mock_client \u003d mock.Mock()"},{"line_number":29,"context_line":"mock_admin_client \u003d mock.Mock()"},{"line_number":30,"context_line":"mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":31,"context_line":"DNSDOMAIN \u003d \u0027domain.com.\u0027"},{"line_number":32,"context_line":"DNSNAME \u003d \u0027port-dns-name\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_70c29535","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":31},"updated":"2016-03-09 20:36:25.000000000","message":"I\u0027m not sure it is wise to carry a mock shared at the package level.  Running tests in parallel could be a train wreck when this is shared between tests.\n\nAfter looking in to parallel test distribution, I think this should be safe.  So, I\u0027m not really too worried.","commit_id":"9df22afb38bde886467b108ca641c471b1ac3531"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b58363b89739fb69739a8572d9b626a585edc283","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"mock_client \u003d mock.Mock()"},{"line_number":29,"context_line":"mock_admin_client \u003d mock.Mock()"},{"line_number":30,"context_line":"mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":31,"context_line":"DNSDOMAIN \u003d \u0027domain.com.\u0027"},{"line_number":32,"context_line":"DNSNAME \u003d \u0027port-dns-name\u0027"},{"line_number":33,"context_line":"NEWDNSNAME \u003d \u0027new-port-dns-name\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_10c99159","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":11},"updated":"2016-03-09 20:36:25.000000000","message":"nit:  Only used once.  Does it need to be predefined up here?","commit_id":"9df22afb38bde886467b108ca641c471b1ac3531"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b58363b89739fb69739a8572d9b626a585edc283","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                                     self._extension_drivers,"},{"line_number":47,"context_line":"                                     group\u003d\u0027ml2\u0027)"},{"line_number":48,"context_line":"        config.cfg.CONF.set_override(\u0027external_dns_driver\u0027, \u0027designate\u0027)"},{"line_number":49,"context_line":"        mock_client.reset_mock()"},{"line_number":50,"context_line":"        mock_admin_client.reset_mock()"},{"line_number":51,"context_line":"        super(DNSIntegrationTestCase, self).setUp()"},{"line_number":52,"context_line":"        dns_integration.DNS_DRIVER \u003d None"},{"line_number":53,"context_line":"        dns_integration.subscribe()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_90e3e1d8","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":38},"updated":"2016-03-09 20:36:25.000000000","message":"Instead of having to be careful about resetting mocks, I prefer to create them fresh each time.\n\n  self.mock_admin_client \u003d mock.Mock()\n\nI think it tends to be easier to not have to remember to reset mocks.","commit_id":"9df22afb38bde886467b108ca641c471b1ac3531"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b58363b89739fb69739a8572d9b626a585edc283","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        mock_admin_client.reset_mock()"},{"line_number":51,"context_line":"        super(DNSIntegrationTestCase, self).setUp()"},{"line_number":52,"context_line":"        dns_integration.DNS_DRIVER \u003d None"},{"line_number":53,"context_line":"        dns_integration.subscribe()"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _create_port_for_test(self, provider_net\u003dTrue, dns_domain\u003dTrue,"},{"line_number":56,"context_line":"                              dns_name\u003dTrue, ipv4\u003dTrue, ipv6\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_70d9f521","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":33},"updated":"2016-03-09 20:36:25.000000000","message":"I\u0027m trying to figure out the reason to need to subscribe for each test.  Shouldn\u0027t this just be a one-off run from the package itself [1] ?  Or, is there something that changes between each test run?\n\n [1] https://github.com/openstack/neutron/blob/3aaaabe9f/neutron/plugins/ml2/extensions/dns_integration.py#L329","commit_id":"9df22afb38bde886467b108ca641c471b1ac3531"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b58363b89739fb69739a8572d9b626a585edc283","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            }"},{"line_number":64,"context_line":"        if dns_domain:"},{"line_number":65,"context_line":"            net_kwargs[dns.DNSDOMAIN] \u003d DNSDOMAIN"},{"line_number":66,"context_line":"            net_kwargs[\u0027arg_list\u0027] \u003d \\"},{"line_number":67,"context_line":"                net_kwargs.get(\u0027arg_list\u0027, ()) + (dns.DNSDOMAIN,)"},{"line_number":68,"context_line":"        res \u003d self._create_network(self.fmt, \u0027test_network\u0027, True,"},{"line_number":69,"context_line":"                                   **net_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_d000c968","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":38},"updated":"2016-03-09 20:36:25.000000000","message":"Don\u0027t use \\ to continue lines.  The one exception is when using multiple context managers in a \"with\" statement because there really is no better way.\n\nIn this case, use parenthesis to allow line continuation.\n\nI\u0027m always a little more lenient on style in tests.  (maybe I shouldn\u0027t be)","commit_id":"9df22afb38bde886467b108ca641c471b1ac3531"}]}