)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ccc51f777970b33ca07e17bea789b59685ec058c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shih-Hao Li \u003cshihli@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-09 18:26:38 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-admin subnets retrieved for non-admin ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the patch for bug #1538767 (https://review.openstack.org/#/c/273278),"},{"line_number":10,"context_line":"get_ports() is passed with context.elevated() to return non-admin ports,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_ae6dc3cd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"updated":"2016-03-10 05:43:30.000000000","message":"This patch really means \"Allow admin subnets retrieved for admin ports\"?","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1fe47885bf09ed451c058b7192758f85fd3651fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shih-Hao Li \u003cshihli@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-09 18:26:38 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-admin subnets retrieved for non-admin ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the patch for bug #1538767 (https://review.openstack.org/#/c/273278),"},{"line_number":10,"context_line":"get_ports() is passed with context.elevated() to return non-admin ports,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_7defea1d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"5aef4532_4ee35fd9","updated":"2016-03-10 10:38:17.000000000","message":"It seems i only tested the case where every resource is owned by the same tenant.\n\nIt\u0027s a bit difficult to understand the change and the discussion as there is no admin/non-admin subnets/routers/... but resources associated to tenants","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"50c0d263e5fb4527dd5de48723e5b1cda00c86ea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shih-Hao Li \u003cshihli@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-09 18:26:38 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-admin subnets retrieved for non-admin ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the patch for bug #1538767 (https://review.openstack.org/#/c/273278),"},{"line_number":10,"context_line":"get_ports() is passed with context.elevated() to return non-admin ports,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_4ee35fd9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":53},"in_reply_to":"5aef4532_ae6dc3cd","updated":"2016-03-10 05:57:36.000000000","message":"I actually not sure what is a good title.\nI just kind of copying the original title.\n\nIt should mean allow tenant1 subnets retrieved for tenant1 ports by tenant2.\n\nI will try to rename the title here.","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ccc51f777970b33ca07e17bea789b59685ec058c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-admin subnets retrieved for non-admin ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the patch for bug #1538767 (https://review.openstack.org/#/c/273278),"},{"line_number":10,"context_line":"get_ports() is passed with context.elevated() to return non-admin ports,"},{"line_number":11,"context_line":"while later the get_subnet() for those ports is still passed with"},{"line_number":12,"context_line":"\"context\". This could cause \"Subnet could not be found\" exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_6e9e1bba","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":72},"updated":"2016-03-10 05:43:30.000000000","message":"Note: So the patch didn\u0027t solve \"Allow non-admins to define external extra-routes\".","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"50c0d263e5fb4527dd5de48723e5b1cda00c86ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-admin subnets retrieved for non-admin ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the patch for bug #1538767 (https://review.openstack.org/#/c/273278),"},{"line_number":10,"context_line":"get_ports() is passed with context.elevated() to return non-admin ports,"},{"line_number":11,"context_line":"while later the get_subnet() for those ports is still passed with"},{"line_number":12,"context_line":"\"context\". This could cause \"Subnet could not be found\" exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_8e84470b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":72},"in_reply_to":"5aef4532_6e9e1bba","updated":"2016-03-10 05:57:36.000000000","message":"I think the patch here should be part of the original patch.\nThat\u0027s the purpose of this commit.","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1408d41486135090f6bea0eaa6bdfc7555746505","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow non-admin subnets retrieved for non-admin ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the patch for bug #1538767 (https://review.openstack.org/#/c/273278),"},{"line_number":10,"context_line":"get_ports() is passed with context.elevated() to return non-admin ports,"},{"line_number":11,"context_line":"while later the get_subnet() for those ports is still passed with"},{"line_number":12,"context_line":"\"context\". This could cause \"Subnet could not be found\" exception"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_99001368","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":72},"in_reply_to":"5aef4532_8e84470b","updated":"2016-03-10 07:16:06.000000000","message":"Exactly","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"}],"neutron/db/extraroute_db.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1fe47885bf09ed451c058b7192758f85fd3651fb","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            raise extraroute.RoutesExhausted("},{"line_number":103,"context_line":"                router_id\u003drouter_id,"},{"line_number":104,"context_line":"                quota\u003dcfg.CONF.max_routes)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        filters \u003d {\u0027device_id\u0027: [router_id]}"},{"line_number":107,"context_line":"        ports \u003d self._core_plugin.get_ports(context.elevated(), filters)"},{"line_number":108,"context_line":"        cidrs \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_1d4fc637","line":105,"updated":"2016-03-10 10:38:17.000000000","message":"elevate the context here, it avoids to do it multiple times","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a75d57d5d472466d93f114537208bf2e82ee4089","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                router_id\u003drouter_id,"},{"line_number":104,"context_line":"                quota\u003dcfg.CONF.max_routes)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        context \u003d context.elevated()"},{"line_number":107,"context_line":"        filters \u003d {\u0027device_id\u0027: [router_id]}"},{"line_number":108,"context_line":"        ports \u003d self._core_plugin.get_ports(context, filters)"},{"line_number":109,"context_line":"        cidrs \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_c8b8f113","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":15},"updated":"2016-03-10 13:11:08.000000000","message":"I prefer admin_ctx or admin_context but it\u0027s nit.","commit_id":"914d52b98349b73b2a450bf755acb67e8b70bba3"}],"neutron/tests/unit/extensions/test_extraroute.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ccc51f777970b33ca07e17bea789b59685ec058c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":83,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":86,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":87,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as ext_subnet:"},{"line_number":88,"context_line":"            self._set_net_external(ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":89,"context_line":"            ext_info \u003d {\u0027network_id\u0027: ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]}"},{"line_number":90,"context_line":"            with self.router(external_gateway_info\u003dext_info) as r:"},{"line_number":91,"context_line":"                body \u003d self._routes_update_prepare("},{"line_number":92,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027], None, None, routes, skip_add\u003dTrue)"},{"line_number":93,"context_line":"                self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_route_clear_routes_with_None(self):"},{"line_number":96,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_eee06b2b","line":93,"range":{"start_line":85,"start_character":0,"end_line":93,"end_character":66},"updated":"2016-03-10 05:43:30.000000000","message":"This test means that admin user created router with external network and admin user add routes about the network cidr.\n\nThis test is useless. Can you remove it or make it correct instead of adding a new test?","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"cf9b49171c6a90285b1a7b291236441b9ba61c55","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":83,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":86,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":87,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as ext_subnet:"},{"line_number":88,"context_line":"            self._set_net_external(ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":89,"context_line":"            ext_info \u003d {\u0027network_id\u0027: ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]}"},{"line_number":90,"context_line":"            with self.router(external_gateway_info\u003dext_info) as r:"},{"line_number":91,"context_line":"                body \u003d self._routes_update_prepare("},{"line_number":92,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027], None, None, routes, skip_add\u003dTrue)"},{"line_number":93,"context_line":"                self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_route_clear_routes_with_None(self):"},{"line_number":96,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_b43a36e5","line":93,"range":{"start_line":85,"start_character":0,"end_line":93,"end_character":66},"in_reply_to":"5aef4532_14edeab6","updated":"2016-03-10 07:32:55.000000000","message":"Yes, that is what I meant. When I said admin context\nin that function, I meant context with admin flag.\n\nThe point is we should have the same context passed to both\nget_ports() and get_subnet().","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"3cc159269c99c96e2e79c5555fcd33b730fe9689","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":83,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":86,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":87,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as ext_subnet:"},{"line_number":88,"context_line":"            self._set_net_external(ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":89,"context_line":"            ext_info \u003d {\u0027network_id\u0027: ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]}"},{"line_number":90,"context_line":"            with self.router(external_gateway_info\u003dext_info) as r:"},{"line_number":91,"context_line":"                body \u003d self._routes_update_prepare("},{"line_number":92,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027], None, None, routes, skip_add\u003dTrue)"},{"line_number":93,"context_line":"                self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_route_clear_routes_with_None(self):"},{"line_number":96,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_dfcf1b54","line":93,"range":{"start_line":85,"start_character":0,"end_line":93,"end_character":66},"in_reply_to":"5aef4532_b43a36e5","updated":"2016-03-10 07:48:51.000000000","message":"\u003e\u003e The point is we should have the same context passed to both get_ports() and get_subnet().\nI mean that the point is we should have the \"admin\" context passed to both get_ports() and get_subnet().\n\nSo I agree with your code. We may wait Cedric\u0027s comment.","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1408d41486135090f6bea0eaa6bdfc7555746505","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":83,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":86,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":87,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as ext_subnet:"},{"line_number":88,"context_line":"            self._set_net_external(ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":89,"context_line":"            ext_info \u003d {\u0027network_id\u0027: ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]}"},{"line_number":90,"context_line":"            with self.router(external_gateway_info\u003dext_info) as r:"},{"line_number":91,"context_line":"                body \u003d self._routes_update_prepare("},{"line_number":92,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027], None, None, routes, skip_add\u003dTrue)"},{"line_number":93,"context_line":"                self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_route_clear_routes_with_None(self):"},{"line_number":96,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_14edeab6","line":93,"range":{"start_line":85,"start_character":0,"end_line":93,"end_character":66},"in_reply_to":"5aef4532_d97a9b23","updated":"2016-03-10 07:16:06.000000000","message":"The context.elevated() means context gets admin flag. After removing previous patch, the context passed into get_ports and get_subnet is no longer admin if the context is passed by non-admin user.","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4b5d9ac99c230b85d72991e7b6a09c65cfa8719a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":83,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":86,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":87,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as ext_subnet:"},{"line_number":88,"context_line":"            self._set_net_external(ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":89,"context_line":"            ext_info \u003d {\u0027network_id\u0027: ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]}"},{"line_number":90,"context_line":"            with self.router(external_gateway_info\u003dext_info) as r:"},{"line_number":91,"context_line":"                body \u003d self._routes_update_prepare("},{"line_number":92,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027], None, None, routes, skip_add\u003dTrue)"},{"line_number":93,"context_line":"                self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_route_clear_routes_with_None(self):"},{"line_number":96,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_f9eaf7d9","line":93,"range":{"start_line":85,"start_character":0,"end_line":93,"end_character":66},"in_reply_to":"5aef4532_eed18b24","updated":"2016-03-10 06:32:59.000000000","message":"I tried to test after removing fix of previous patch in extraroute_db.py but the test succeeded. This means the test is wrong for the issue, doesn\u0027t it?\n\nhttp://paste.openstack.org/show/489950/","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"50c0d263e5fb4527dd5de48723e5b1cda00c86ea","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":83,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":86,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":87,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as ext_subnet:"},{"line_number":88,"context_line":"            self._set_net_external(ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":89,"context_line":"            ext_info \u003d {\u0027network_id\u0027: ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]}"},{"line_number":90,"context_line":"            with self.router(external_gateway_info\u003dext_info) as r:"},{"line_number":91,"context_line":"                body \u003d self._routes_update_prepare("},{"line_number":92,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027], None, None, routes, skip_add\u003dTrue)"},{"line_number":93,"context_line":"                self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_route_clear_routes_with_None(self):"},{"line_number":96,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_eed18b24","line":93,"range":{"start_line":85,"start_character":0,"end_line":93,"end_character":66},"in_reply_to":"5aef4532_eee06b2b","updated":"2016-03-10 05:57:36.000000000","message":"Without the patch in this commit. This new test will break.\nSo it is not useless.\n\nThe patch can handle both cases.\n1. admin-created router with nonadmin created router interface\n2. nonadmin-created router with admin created router interface\n\nThe test for (2) is easier to implement because admin context can override previous non-admin context.\n\nIf really needed, I can add test for (1).","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"e0f878de4d19c522a4dba095e478e89c21cbc8a3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":83,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":86,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":87,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as ext_subnet:"},{"line_number":88,"context_line":"            self._set_net_external(ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":89,"context_line":"            ext_info \u003d {\u0027network_id\u0027: ext_subnet[\u0027subnet\u0027][\u0027network_id\u0027]}"},{"line_number":90,"context_line":"            with self.router(external_gateway_info\u003dext_info) as r:"},{"line_number":91,"context_line":"                body \u003d self._routes_update_prepare("},{"line_number":92,"context_line":"                    r[\u0027router\u0027][\u0027id\u0027], None, None, routes, skip_add\u003dTrue)"},{"line_number":93,"context_line":"                self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_route_clear_routes_with_None(self):"},{"line_number":96,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_d97a9b23","line":93,"range":{"start_line":85,"start_character":0,"end_line":93,"end_character":66},"in_reply_to":"5aef4532_f9eaf7d9","updated":"2016-03-10 06:45:37.000000000","message":"If you remove previous patch, it will pass.\nThis is because get_subnet() with admin-context can lookup more subnets than nonadmin-context.\n\nIf you already removed previous patch, then this test is no\nlonger needed. The purpose of this test is to show where\nthe code may break with previous patch.","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1408d41486135090f6bea0eaa6bdfc7555746505","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        nonadmin_tenant \u003d \u0027nonadmin\u0027"},{"line_number":482,"context_line":"        nonadmin_context \u003d context.Context(\u0027\u0027, nonadmin_tenant)"},{"line_number":483,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":484,"context_line":"        with self.router(tenant_id\u003dnonadmin_tenant) as r:"},{"line_number":485,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027, tenant_id\u003dadmin_tenant) as s:"},{"line_number":486,"context_line":"                self._router_interface_action(\u0027add\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":487,"context_line":"                                              s[\u0027subnet\u0027][\u0027id\u0027], None,"},{"line_number":488,"context_line":"                                              tenant_id\u003dadmin_tenant)"},{"line_number":489,"context_line":"                self._update(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":490,"context_line":"                             {\u0027router\u0027: {\u0027routes\u0027: routes}},"},{"line_number":491,"context_line":"                             neutron_context\u003dadmin_context)"},{"line_number":492,"context_line":"                self.plugin._validate_routes(admin_context,"},{"line_number":493,"context_line":"                                             r[\u0027router\u0027][\u0027id\u0027], routes)"},{"line_number":494,"context_line":"                self.plugin._validate_routes(nonadmin_context,"},{"line_number":495,"context_line":"                                             r[\u0027router\u0027][\u0027id\u0027], routes)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"class ExtraRouteDBSepTestCase(test_l3.L3NatDBSepTestCase,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_797c27ec","line":495,"range":{"start_line":484,"start_character":0,"end_line":495,"end_character":71},"updated":"2016-03-10 07:16:06.000000000","message":"I guess that the following is simpler and meets your requirement.\n\n\n    with self.router(tenant_id\u003dnonadmin_tenant) as r:\n        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027) as s:\n            self._router_interface_action(\u0027add\u0027, r[\u0027router\u0027][\u0027id\u0027],\n                                          s[\u0027subnet\u0027][\u0027id\u0027], None)\n            body \u003d self._update(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027],\n                                {\u0027router\u0027: {\u0027routes\u0027: routes}},\n                                neutron_context\u003dnonadmin_context)\n             self.assertEqual(routes, body[\u0027router\u0027][\u0027routes\u0027])","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"cf9b49171c6a90285b1a7b291236441b9ba61c55","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        nonadmin_tenant \u003d \u0027nonadmin\u0027"},{"line_number":482,"context_line":"        nonadmin_context \u003d context.Context(\u0027\u0027, nonadmin_tenant)"},{"line_number":483,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":484,"context_line":"        with self.router(tenant_id\u003dnonadmin_tenant) as r:"},{"line_number":485,"context_line":"            with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027, tenant_id\u003dadmin_tenant) as s:"},{"line_number":486,"context_line":"                self._router_interface_action(\u0027add\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":487,"context_line":"                                              s[\u0027subnet\u0027][\u0027id\u0027], None,"},{"line_number":488,"context_line":"                                              tenant_id\u003dadmin_tenant)"},{"line_number":489,"context_line":"                self._update(\u0027routers\u0027, r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":490,"context_line":"                             {\u0027router\u0027: {\u0027routes\u0027: routes}},"},{"line_number":491,"context_line":"                             neutron_context\u003dadmin_context)"},{"line_number":492,"context_line":"                self.plugin._validate_routes(admin_context,"},{"line_number":493,"context_line":"                                             r[\u0027router\u0027][\u0027id\u0027], routes)"},{"line_number":494,"context_line":"                self.plugin._validate_routes(nonadmin_context,"},{"line_number":495,"context_line":"                                             r[\u0027router\u0027][\u0027id\u0027], routes)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"class ExtraRouteDBSepTestCase(test_l3.L3NatDBSepTestCase,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_7f77e79f","line":495,"range":{"start_line":484,"start_character":0,"end_line":495,"end_character":71},"in_reply_to":"5aef4532_797c27ec","updated":"2016-03-10 07:32:55.000000000","message":"_validate_routes is function I fix here, so I need to call it explicitly.\n\nI have admin_xxx and nonadmin_xxx declared because I think\nthat is easier for people to see where different contexts are used.","commit_id":"a1d74404142ac1e8ae637ea6dc821f81980eda1d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ccaf013129e5e8f8489236a776484f99d0a266c7","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                                                     ext_mgr\u003dext_mgr)"},{"line_number":476,"context_line":"        self.setup_notification_driver()"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_admin_route_update_on_nonadmin_router(self):"},{"line_number":479,"context_line":"        admin_tenant \u003d None"},{"line_number":480,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":481,"context_line":"        nonadmin_tenant \u003d \u0027nonadmin\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_33ec73f2","line":478,"updated":"2016-03-10 12:40:16.000000000","message":"I don\u0027t understand why this test is not in ExtraRouteDBTestCaseBase","commit_id":"04c1affcfd7d3ddee14673a535c098d908ed4c27"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"60b9facd826199b33d183f917c8a390634705ab5","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                                                     ext_mgr\u003dext_mgr)"},{"line_number":476,"context_line":"        self.setup_notification_driver()"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_admin_route_update_on_nonadmin_router(self):"},{"line_number":479,"context_line":"        admin_tenant \u003d None"},{"line_number":480,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":481,"context_line":"        nonadmin_tenant \u003d \u0027nonadmin\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_f0b83313","line":478,"in_reply_to":"5aef4532_33ec73f2","updated":"2016-03-10 14:38:32.000000000","message":"This is because _validate_routes is inherited from test_l3.L3NatDBIntTestCase. But test_l3.L3NatDBSepTestCase\ndoesn\u0027t have it. So I can only add the new test under ExtraRouteDBIntTestCase.","commit_id":"04c1affcfd7d3ddee14673a535c098d908ed4c27"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"7683986f1207fa366d8398cda7558a472d050f70","unresolved":false,"context_lines":[{"line_number":475,"context_line":"                                                     ext_mgr\u003dext_mgr)"},{"line_number":476,"context_line":"        self.setup_notification_driver()"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test_admin_route_update_on_nonadmin_router(self):"},{"line_number":479,"context_line":"        admin_tenant \u003d None"},{"line_number":480,"context_line":"        admin_context \u003d context.get_admin_context()"},{"line_number":481,"context_line":"        nonadmin_tenant \u003d \u0027nonadmin\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_7270a272","line":478,"in_reply_to":"5aef4532_f0b83313","updated":"2016-03-10 16:11:31.000000000","message":"Sorry, I meant _validate_routes is not inherited from the plugin in ExtraRouteDBSepTestCase, i.e. neutron.tests.unit.extensions.test_l3.TestNoL3NatPlugin.","commit_id":"04c1affcfd7d3ddee14673a535c098d908ed4c27"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"6d1ce5696799c8cb7d3c89a5e2c65c28b704d60f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            port_id, routes, skip_add\u003dFalse, tenant_id\u003dNone):"},{"line_number":65,"context_line":"        if not skip_add:"},{"line_number":66,"context_line":"            self._router_interface_action("},{"line_number":67,"context_line":"                \u0027add\u0027, router_id, subnet_id, port_id, tenant_id\u003dNone)"},{"line_number":68,"context_line":"        ctxt \u003d context.Context(\u0027\u0027, tenant_id) if tenant_id else None"},{"line_number":69,"context_line":"        self._update(\u0027routers\u0027, router_id, {\u0027router\u0027: {\u0027routes\u0027: routes}},"},{"line_number":70,"context_line":"                     neutron_context\u003dctxt)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_d8c71562","line":67,"updated":"2016-03-10 16:40:11.000000000","message":"I think it is better to add some comment why tenant_id\u003dNone instead of tenant_id\u003dtenant_id on line 67. Otherwise it looks confusing.","commit_id":"914d52b98349b73b2a450bf755acb67e8b70bba3"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"661464a9b453a42fc28a2e4dd65e42ccc146aa59","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":87,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":90,"context_line":"        my_tenant \u003d \u0027tenant1\u0027"},{"line_number":91,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":92,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027, tenant_id\u003d\u0027notme\u0027) as ext_subnet:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_626c5e08","line":89,"updated":"2016-03-10 12:48:06.000000000","message":"I updated this test as it doesn\u0027t check the common case: the user tries to add route on an external subnet he doesn\u0027t own","commit_id":"914d52b98349b73b2a450bf755acb67e8b70bba3"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a75d57d5d472466d93f114537208bf2e82ee4089","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                    self._routes_update_cleanup(p[\u0027port\u0027][\u0027id\u0027],"},{"line_number":87,"context_line":"                                                None, r[\u0027router\u0027][\u0027id\u0027], [])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_route_update_with_external_route(self):"},{"line_number":90,"context_line":"        my_tenant \u003d \u0027tenant1\u0027"},{"line_number":91,"context_line":"        routes \u003d [{\u0027destination\u0027: \u0027135.207.0.0/16\u0027, \u0027nexthop\u0027: \u002710.0.1.3\u0027}]"},{"line_number":92,"context_line":"        with self.subnet(cidr\u003d\u002710.0.1.0/24\u0027, tenant_id\u003d\u0027notme\u0027) as ext_subnet:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_ad42d7ab","line":89,"in_reply_to":"5aef4532_626c5e08","updated":"2016-03-10 13:11:08.000000000","message":"Nice!","commit_id":"914d52b98349b73b2a450bf755acb67e8b70bba3"}]}
