)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9e547292736f742ec71b6286836ded615127711c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shih-Hao Li \u003cshihli@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-08 20:04:30 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix get_isolated_subnets in Dnsmasq"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Dnsmasq, the function get_isolated_subnets() returns a list of"},{"line_number":10,"context_line":"subnets in a network if the subnet is not connected to a router."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_1b2b8d95","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":35},"updated":"2016-03-09 13:33:51.000000000","message":"this is confusing as the patch does not actually fix it, but ratcher adds a dhcp notification to the server code","commit_id":"c8c02b2d1ee83a9dbfd28d28c6191c4455b3a564"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9e547292736f742ec71b6286836ded615127711c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"This patch fixes that by adding callback functions in DHCP RPC client"},{"line_number":18,"context_line":"to notify DHCP agent when changes happened on router interfaces."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1554825"},{"line_number":21,"context_line":"Change-Id: Ifaab163f49e0d1c5cb3eba6efa96214104647e4e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5aef4532_9e0cab3c","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":20},"updated":"2016-03-09 13:33:51.000000000","message":"please see my comment on the bug in launchpad","commit_id":"c8c02b2d1ee83a9dbfd28d28c6191c4455b3a564"}],"neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ac33b02c3ab9ce726c2feffec71e0062b71cdb9c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self._notify_agents(kwargs[\u0027context\u0027], \u0027port_create_end\u0027,"},{"line_number":185,"context_line":"                            {\u0027port\u0027: {\u0027id\u0027: kwargs[\u0027port_id\u0027],"},{"line_number":186,"context_line":"                                      \u0027network_id\u0027: kwargs[\u0027port_network_id\u0027],"},{"line_number":187,"context_line":"                                      \u0027device_id\u0027: kwargs[\u0027router_id\u0027]}},"},{"line_number":188,"context_line":"                            kwargs[\u0027port_network_id\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _after_router_interface_deleted(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_0c3abfe7","line":187,"updated":"2016-03-11 08:37:59.000000000","message":"device_owner is also needed, right?","commit_id":"a64e2a7f1d9bca7bca57bff5895e2b75718e1025"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"8a2c68d8518e3af969eedf6dd26ed3e77d32a77c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self._notify_agents(kwargs[\u0027context\u0027], \u0027port_create_end\u0027,"},{"line_number":185,"context_line":"                            {\u0027port\u0027: {\u0027id\u0027: kwargs[\u0027port_id\u0027],"},{"line_number":186,"context_line":"                                      \u0027network_id\u0027: kwargs[\u0027port_network_id\u0027],"},{"line_number":187,"context_line":"                                      \u0027device_id\u0027: kwargs[\u0027router_id\u0027]}},"},{"line_number":188,"context_line":"                            kwargs[\u0027port_network_id\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _after_router_interface_deleted(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_ee2f769f","line":187,"in_reply_to":"3afc51ec_17959ce3","updated":"2016-03-11 19:33:49.000000000","message":"It turned out my new change misses another port attribute \"fixed_ips\" used in an internal function, which causes network cache been refreshed. That\u0027s why get_isolated_subnets still works.\n\nI will fix this. Thanks.","commit_id":"a64e2a7f1d9bca7bca57bff5895e2b75718e1025"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b98cfea61d49b181803c37f3fceea6c40bf9991a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self._notify_agents(kwargs[\u0027context\u0027], \u0027port_create_end\u0027,"},{"line_number":185,"context_line":"                            {\u0027port\u0027: {\u0027id\u0027: kwargs[\u0027port_id\u0027],"},{"line_number":186,"context_line":"                                      \u0027network_id\u0027: kwargs[\u0027port_network_id\u0027],"},{"line_number":187,"context_line":"                                      \u0027device_id\u0027: kwargs[\u0027router_id\u0027]}},"},{"line_number":188,"context_line":"                            kwargs[\u0027port_network_id\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _after_router_interface_deleted(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_17959ce3","line":187,"in_reply_to":"3afc51ec_34aa56d5","updated":"2016-03-11 16:39:50.000000000","message":"port_create_end() puts the port to cache and later get_isolated_subnets() will need device_owner of each port. Am I missing something?","commit_id":"a64e2a7f1d9bca7bca57bff5895e2b75718e1025"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"5cfbd991cb1c75f39a62a9bee67621a8cbfbc6e1","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        self._notify_agents(kwargs[\u0027context\u0027], \u0027port_create_end\u0027,"},{"line_number":185,"context_line":"                            {\u0027port\u0027: {\u0027id\u0027: kwargs[\u0027port_id\u0027],"},{"line_number":186,"context_line":"                                      \u0027network_id\u0027: kwargs[\u0027port_network_id\u0027],"},{"line_number":187,"context_line":"                                      \u0027device_id\u0027: kwargs[\u0027router_id\u0027]}},"},{"line_number":188,"context_line":"                            kwargs[\u0027port_network_id\u0027])"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def _after_router_interface_deleted(self, resource, event, trigger,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_34aa56d5","line":187,"in_reply_to":"5aef4532_0c3abfe7","updated":"2016-03-11 16:08:52.000000000","message":"No, it is not needed. DHCP agent doesn\u0027t use device_owner in port_create_end case.","commit_id":"a64e2a7f1d9bca7bca57bff5895e2b75718e1025"}],"neutron/db/l3_db.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6cac1ba65a0e8f188b76fb67c38040862340e3ba","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        registry.notify(resources.ROUTER_INTERFACE,"},{"line_number":713,"context_line":"                        events.AFTER_CREATE,"},{"line_number":714,"context_line":"                        self,"},{"line_number":715,"context_line":"                        context\u003dcontext,"},{"line_number":716,"context_line":"                        network_id\u003dgw_network_id,"},{"line_number":717,"context_line":"                        gateway_ips\u003dgw_ips,"},{"line_number":718,"context_line":"                        cidrs\u003d[x[\u0027cidr\u0027] for x in subnets],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_a612ae60","line":715,"updated":"2016-03-11 22:26:31.000000000","message":"Same changes needed in neutron/db/l3_dvr_db.py (see rally job failing due to that).","commit_id":"356101761b044dbaf13d27fb4c7879a2ecf250dd"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"5afc7cc53bea2be4f7424ce2b8560ff49e21ae7f","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        registry.notify(resources.ROUTER_INTERFACE,"},{"line_number":713,"context_line":"                        events.AFTER_CREATE,"},{"line_number":714,"context_line":"                        self,"},{"line_number":715,"context_line":"                        context\u003dcontext,"},{"line_number":716,"context_line":"                        network_id\u003dgw_network_id,"},{"line_number":717,"context_line":"                        gateway_ips\u003dgw_ips,"},{"line_number":718,"context_line":"                        cidrs\u003d[x[\u0027cidr\u0027] for x in subnets],"}],"source_content_type":"text/x-python","patch_set":5,"id":"3afc51ec_54f39073","line":715,"in_reply_to":"3afc51ec_a612ae60","updated":"2016-03-11 23:21:28.000000000","message":"OK, looks like something merged recently.","commit_id":"356101761b044dbaf13d27fb4c7879a2ecf250dd"}]}
