)]}'
{"quantum/tests/unit/test_quota_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"725036c073996916b856f6c50c0a48ce0d913d22","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"import quantum.db.quota_db"},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FVFY%3D","line":14,"updated":"2013-05-14 14:24:28.000000000","message":"please add new line\n\nplease look at HACKING.rst for te import order rules.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"import quantum.db.quota_db"},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FTuk%3D","line":14,"in_reply_to":"AAAAOn%2F%2FVFY%3D","updated":"2013-05-15 05:24:49.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"import quantum.db.quota_db"},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from quantum import context"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FUxc%3D","line":15,"updated":"2013-05-14 18:02:13.000000000","message":"from quantum.db import quota_db","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":"import quantum.db.quota_db"},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from quantum import context"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FTug%3D","line":15,"in_reply_to":"AAAAOn%2F%2FUxc%3D","updated":"2013-05-15 05:24:49.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum import context"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestDbQuotaDriver(testtools.TestCase):"},{"line_number":22,"context_line":"    \u0027\u0027\u0027test for quantum.db.quota_db.DbQuotaDriver.\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _make_dummy_get_tenant_quotas(self, tenants_quota):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FUyk%3D","line":21,"updated":"2013-05-14 18:02:13.000000000","message":"Could you inherit quantum.tests.base.BaseTestCase? This class does various common setups.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum import context"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestDbQuotaDriver(testtools.TestCase):"},{"line_number":22,"context_line":"    \u0027\u0027\u0027test for quantum.db.quota_db.DbQuotaDriver.\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _make_dummy_get_tenant_quotas(self, tenants_quota):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FTtc%3D","line":21,"in_reply_to":"AAAAOn%2F%2FUyk%3D","updated":"2013-05-15 05:24:49.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestDbQuotaDriver(testtools.TestCase):"},{"line_number":22,"context_line":"    \u0027\u0027\u0027test for quantum.db.quota_db.DbQuotaDriver.\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _make_dummy_get_tenant_quotas(self, tenants_quota):"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FUy4%3D","line":22,"updated":"2013-05-14 18:02:13.000000000","message":"docstring is usually wrapped with triple double quotes.\nIn addition capitalize the first word.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class TestDbQuotaDriver(testtools.TestCase):"},{"line_number":22,"context_line":"    \u0027\u0027\u0027test for quantum.db.quota_db.DbQuotaDriver.\u0027\u0027\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _make_dummy_get_tenant_quotas(self, tenants_quota):"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FTuI%3D","line":22,"in_reply_to":"AAAAOn%2F%2FUy4%3D","updated":"2013-05-15 05:24:49.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"        return dummy_get_tenat_quotas"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_get_tenant_quotas_arg(self):"},{"line_number":33,"context_line":"        \u0027\u0027\u0027call quantum.db.quota_db.DbQuotaDriver._get_quotas.\u0027\u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        foo_quota \u003d {\u0027network\u0027: 10}"},{"line_number":36,"context_line":"        bar_quota \u003d {\u0027network\u0027: 5}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FUyw%3D","line":33,"updated":"2013-05-14 18:02:13.000000000","message":"Ditto","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        return dummy_get_tenat_quotas"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def test_get_tenant_quotas_arg(self):"},{"line_number":33,"context_line":"        \u0027\u0027\u0027call quantum.db.quota_db.DbQuotaDriver._get_quotas.\u0027\u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        foo_quota \u003d {\u0027network\u0027: 10}"},{"line_number":36,"context_line":"        bar_quota \u003d {\u0027network\u0027: 5}"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FTtU%3D","line":33,"in_reply_to":"AAAAOn%2F%2FUyw%3D","updated":"2013-05-15 05:24:49.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":35,"context_line":"        foo_quota \u003d {\u0027network\u0027: 10}"},{"line_number":36,"context_line":"        bar_quota \u003d {\u0027network\u0027: 5}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        quantum.db.quota_db.DbQuotaDriver.get_tenant_quotas \u003d \\"},{"line_number":39,"context_line":"            self._make_dummy_get_tenant_quotas({"},{"line_number":40,"context_line":"                \u0027foo\u0027: foo_quota,"},{"line_number":41,"context_line":"                \u0027bar\u0027: bar_quota})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FUwQ%3D","line":38,"updated":"2013-05-14 18:02:13.000000000","message":"It is better to use mock patch. This line just tries to control the return value of get_tenant_quotas static method.\n\nIt overrides the static method, but it is NOT reverted to the original one. We need to ensure all changes during tests should be reverted. We should avoid a potential risk though it may affect nothing now.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"725036c073996916b856f6c50c0a48ce0d913d22","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        foo_quota \u003d {\u0027network\u0027: 10}"},{"line_number":36,"context_line":"        bar_quota \u003d {\u0027network\u0027: 5}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        quantum.db.quota_db.DbQuotaDriver.get_tenant_quotas \u003d \\"},{"line_number":39,"context_line":"            self._make_dummy_get_tenant_quotas({"},{"line_number":40,"context_line":"                \u0027foo\u0027: foo_quota,"},{"line_number":41,"context_line":"                \u0027bar\u0027: bar_quota})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FVFc%3D","line":38,"updated":"2013-05-14 14:24:28.000000000","message":"please do not make use if the \\","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        foo_quota \u003d {\u0027network\u0027: 10}"},{"line_number":36,"context_line":"        bar_quota \u003d {\u0027network\u0027: 5}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        quantum.db.quota_db.DbQuotaDriver.get_tenant_quotas \u003d \\"},{"line_number":39,"context_line":"            self._make_dummy_get_tenant_quotas({"},{"line_number":40,"context_line":"                \u0027foo\u0027: foo_quota,"},{"line_number":41,"context_line":"                \u0027bar\u0027: bar_quota})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FTuM%3D","line":38,"in_reply_to":"AAAAOn%2F%2FUwQ%3D","updated":"2013-05-15 05:24:49.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"        ctx \u003d context.Context(\u0027\u0027, \u0027bar\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        quota \u003d driver._get_quotas(ctx, tenant_id, {}, {})"},{"line_number":48,"context_line":"        self.assertEquals(quota, foo_quota)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FUyQ%3D","line":48,"updated":"2013-05-14 18:02:13.000000000","message":"assertEquals -\u003e assertEqual","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        ctx \u003d context.Context(\u0027\u0027, \u0027bar\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        quota \u003d driver._get_quotas(ctx, tenant_id, {}, {})"},{"line_number":48,"context_line":"        self.assertEquals(quota, foo_quota)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FTuc%3D","line":48,"in_reply_to":"AAAAOn%2F%2FUyQ%3D","updated":"2013-05-15 05:24:49.000000000","message":"Thank you for your comment. I will amend it in the next patch.","commit_id":"adcc999a0cce893b6aa1ec1477c92b4e475a6086"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from mock import MagicMock"},{"line_number":17,"context_line":"from mock import patch"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from quantum import context"},{"line_number":20,"context_line":"from quantum.db import quota_db"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAO3%2F%2F%2F4M%3D","line":17,"updated":"2013-05-15 07:39:05.000000000","message":"Use module level import: \"import mock\"","commit_id":"930f2c9af73f6f4869d698ed30d97c4a128ee8e6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        with patch.object(quota_db.DbQuotaDriver,"},{"line_number":50,"context_line":"                          \u0027get_tenant_quotas\u0027,"},{"line_number":51,"context_line":"                          new_callable\u003dcallable_mock):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            quota \u003d driver._get_quotas(ctx, \u0027foo\u0027, {}, {})"},{"line_number":54,"context_line":"            self.assertEqual(quota, foo_quota)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAO3%2F%2F%2F2E%3D","line":51,"updated":"2013-05-15 07:39:05.000000000","message":"What to be checked here is to check a proper tenant_id is passed. MagicMock is not easy to understand.\nI believe the following test does the same. Does it make sense?\n\nwith mock.patch.object(quota_db.DbQuotaDriver, \u0027get_tenant_quotas\u0027,\n                       return_value\u003dtenant_quotas) as get_quotas:\n    quota \u003d driver._get_quotas(ctx, target_tenant, default_quotas, [\u0027network\u0027])\n    self.assertEqual(tenant_quotas, quota)\n    get_quotas.assert_called_once_with(ctx, default_quotas, target_tenant)","commit_id":"930f2c9af73f6f4869d698ed30d97c4a128ee8e6"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        with patch.object(quota_db.DbQuotaDriver,"},{"line_number":50,"context_line":"                          \u0027get_tenant_quotas\u0027,"},{"line_number":51,"context_line":"                          new_callable\u003dcallable_mock):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            quota \u003d driver._get_quotas(ctx, \u0027foo\u0027, {}, {})"},{"line_number":54,"context_line":"            self.assertEqual(quota, foo_quota)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAO3%2F%2F9Rk%3D","line":51,"in_reply_to":"AAAAO3%2F%2F%2F2E%3D","updated":"2013-05-16 06:07:39.000000000","message":"If the return value of get_tenant_quotas() is not variable, we cannot check whether _get_quotas() passes a right tenant_id to get_tenant_quotas() and cannot confirm the problem is fixed.\nTherefore, I feel the above code is right.\nBut, There was no need to use MagicMcock in this test. So, I will remove MagicMock in the next patch.","commit_id":"930f2c9af73f6f4869d698ed30d97c4a128ee8e6"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"e445ec037449ec24769d4009bc2df85d463a80f0","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        with patch.object(quota_db.DbQuotaDriver,"},{"line_number":50,"context_line":"                          \u0027get_tenant_quotas\u0027,"},{"line_number":51,"context_line":"                          new_callable\u003dcallable_mock):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            quota \u003d driver._get_quotas(ctx, \u0027foo\u0027, {}, {})"},{"line_number":54,"context_line":"            self.assertEqual(quota, foo_quota)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAO3%2F%2F9Jc%3D","line":51,"in_reply_to":"AAAAO3%2F%2F9MY%3D","updated":"2013-05-16 06:55:17.000000000","message":"Sorry, I\u0027m bad.\nI didn\u0027t understand your test code.\nI will fix test code in the next patch.","commit_id":"930f2c9af73f6f4869d698ed30d97c4a128ee8e6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        with patch.object(quota_db.DbQuotaDriver,"},{"line_number":50,"context_line":"                          \u0027get_tenant_quotas\u0027,"},{"line_number":51,"context_line":"                          new_callable\u003dcallable_mock):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            quota \u003d driver._get_quotas(ctx, \u0027foo\u0027, {}, {})"},{"line_number":54,"context_line":"            self.assertEqual(quota, foo_quota)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAO3%2F%2F9MY%3D","line":51,"in_reply_to":"AAAAO3%2F%2F9Rk%3D","updated":"2013-05-16 06:21:16.000000000","message":"I think \"get_tenant_quotas.assert_called_once_with(ctx, default_quotas, target_tenant)\" will check the right tenant_id is passed. In the previous code \"bar\" is passed as the last arguments and the above sample test fails.\n\nOne correction: \"get_quota\" in the last line in my sample code needs to be changed to \"get_tenant_quotas\".","commit_id":"930f2c9af73f6f4869d698ed30d97c4a128ee8e6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":"                          \u0027get_tenant_quotas\u0027,"},{"line_number":51,"context_line":"                          new_callable\u003dcallable_mock):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"            quota \u003d driver._get_quotas(ctx, \u0027foo\u0027, {}, {})"},{"line_number":54,"context_line":"            self.assertEqual(quota, foo_quota)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAO3%2F%2F%2F18%3D","line":53,"updated":"2013-05-15 07:39:05.000000000","message":"The type of the last argument is a list instead of a dict. Please honor the type of arguments.","commit_id":"930f2c9af73f6f4869d698ed30d97c4a128ee8e6"}]}
