)]}'
{"neutron/common/cache_utils.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3378a80d9d257dfa8be643c301674760a9aabf7f","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"cache_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":27,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in M release and will \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_642dce94","line":26,"updated":"2016-03-09 13:59:23.000000000","message":"Previously, default ttl was 5.","commit_id":"b1f7b388a8ba95925785c9de028386e05b7fbd53"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"c56d7df5eea77026915dee34add4c6c4ec3d07a0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"cache_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":27,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in M release and will \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_bafd813c","line":26,"in_reply_to":"5aef4532_642dce94","updated":"2016-03-14 04:06:51.000000000","message":"Set in metadata_agent.py as previously did","commit_id":"b1f7b388a8ba95925785c9de028386e05b7fbd53"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3378a80d9d257dfa8be643c301674760a9aabf7f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":27,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in M release and will \u0027"},{"line_number":30,"context_line":"                      \u0027be removed. Please add a [cache] group for oslo.cache \u0027"},{"line_number":31,"context_line":"                      \u0027instead.\u0027)),"},{"line_number":32,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a17068dd","line":29,"range":{"start_line":29,"start_character":56,"end_line":29,"end_character":57},"updated":"2016-03-09 13:59:23.000000000","message":"Mitaka","commit_id":"b1f7b388a8ba95925785c9de028386e05b7fbd53"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"c56d7df5eea77026915dee34add4c6c4ec3d07a0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":27,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in M release and will \u0027"},{"line_number":30,"context_line":"                      \u0027be removed. Please add a [cache] group for oslo.cache \u0027"},{"line_number":31,"context_line":"                      \u0027instead.\u0027)),"},{"line_number":32,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_9a8fe5cb","line":29,"range":{"start_line":29,"start_character":56,"end_line":29,"end_character":57},"in_reply_to":"5aef4532_a17068dd","updated":"2016-03-14 04:06:51.000000000","message":"Change to Newton","commit_id":"b1f7b388a8ba95925785c9de028386e05b7fbd53"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3378a80d9d257dfa8be643c301674760a9aabf7f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    if backend \u003d\u003d \u0027memory\u0027:"},{"line_number":66,"context_line":"        backend \u003d \u0027oslo_cache.dict\u0027"},{"line_number":67,"context_line":"        query \u003d parsed.query"},{"line_number":68,"context_line":"        # NOTE(flaper87): We need the following hack"},{"line_number":69,"context_line":"        # for python versions \u003c 2.7.5. Previous versions"},{"line_number":70,"context_line":"        # of python parsed query params just for \u0027known\u0027"},{"line_number":71,"context_line":"        # schemes. This was changed in this patch:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_2154581f","line":68,"updated":"2016-03-09 13:59:23.000000000","message":"Where is that code from the file coming from? Should we note the source somewhere?","commit_id":"b1f7b388a8ba95925785c9de028386e05b7fbd53"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"c56d7df5eea77026915dee34add4c6c4ec3d07a0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    if backend \u003d\u003d \u0027memory\u0027:"},{"line_number":66,"context_line":"        backend \u003d \u0027oslo_cache.dict\u0027"},{"line_number":67,"context_line":"        query \u003d parsed.query"},{"line_number":68,"context_line":"        # NOTE(flaper87): We need the following hack"},{"line_number":69,"context_line":"        # for python versions \u003c 2.7.5. Previous versions"},{"line_number":70,"context_line":"        # of python parsed query params just for \u0027known\u0027"},{"line_number":71,"context_line":"        # schemes. This was changed in this patch:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_3a6e9101","line":68,"in_reply_to":"5aef4532_2154581f","updated":"2016-03-14 04:06:51.000000000","message":"Added the source.","commit_id":"b1f7b388a8ba95925785c9de028386e05b7fbd53"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"cache_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":27,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in Newton release and \u0027"},{"line_number":30,"context_line":"                      \u0027will be removed. Please add a [cache] group for \u0027"},{"line_number":31,"context_line":"                      \u0027oslo.cache instead.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_1b8d787b","line":28,"updated":"2016-03-22 17:52:16.000000000","message":"missing space between sentences","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"cache_opts \u003d ["},{"line_number":26,"context_line":"    cfg.StrOpt(\u0027cache_url\u0027, default\u003d\u0027memory://\u0027,"},{"line_number":27,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in Newton release and \u0027"},{"line_number":30,"context_line":"                      \u0027will be removed. Please add a [cache] group for \u0027"},{"line_number":31,"context_line":"                      \u0027oslo.cache instead.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4243036c","line":28,"in_reply_to":"fa0719c6_1b8d787b","updated":"2016-04-22 04:18:51.000000000","message":"Done","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in Newton release and \u0027"},{"line_number":30,"context_line":"                      \u0027will be removed. Please add a [cache] group for \u0027"},{"line_number":31,"context_line":"                      \u0027oslo.cache instead.\u0027)),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_1bbbb80f","line":31,"updated":"2016-03-22 17:52:16.000000000","message":"What should be in this group? We need to give some guidance to the user who will see the warning. Also, can we e.g. use deprecated_group/deprecated_name here, or it\u0027s more complex than that?","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end.\u0027"},{"line_number":29,"context_line":"                      \u0027\"cache_url\" opt is deprecated in Newton release and \u0027"},{"line_number":30,"context_line":"                      \u0027will be removed. Please add a [cache] group for \u0027"},{"line_number":31,"context_line":"                      \u0027oslo.cache instead.\u0027)),"},{"line_number":32,"context_line":"]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_5d112251","line":31,"in_reply_to":"fa0719c6_1bbbb80f","updated":"2016-04-22 04:18:51.000000000","message":"We use [cache] group instead of cache_url option. Added some information.","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return region"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _get_cache_region_for_legacy(url\u003d\"memory://\"):"},{"line_number":62,"context_line":"    parsed \u003d parse.urlparse(url)"},{"line_number":63,"context_line":"    backend \u003d parsed.scheme"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_5b30909e","line":61,"range":{"start_line":61,"start_character":33,"end_line":61,"end_character":48},"updated":"2016-03-22 17:52:16.000000000","message":"what\u0027s the point of having this default value here? Do we have cases where we don\u0027t pass it?","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return region"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _get_cache_region_for_legacy(url\u003d\"memory://\"):"},{"line_number":62,"context_line":"    parsed \u003d parse.urlparse(url)"},{"line_number":63,"context_line":"    backend \u003d parsed.scheme"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_dd2b7280","line":61,"range":{"start_line":61,"start_character":33,"end_line":61,"end_character":48},"in_reply_to":"fa0719c6_5b30909e","updated":"2016-04-22 04:18:51.000000000","message":"removed the default value","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        region.configure(backend, **region_params)"},{"line_number":84,"context_line":"        return region"},{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        raise RuntimeError(_(\u0027Old style configuration can use only memory\u0027"},{"line_number":87,"context_line":"                             \u0027(dict) backend\u0027))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_dbe30004","line":86,"updated":"2016-03-22 17:52:16.000000000","message":"missing space after \u0027memory\u0027","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        region.configure(backend, **region_params)"},{"line_number":84,"context_line":"        return region"},{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        raise RuntimeError(_(\u0027Old style configuration can use only memory\u0027"},{"line_number":87,"context_line":"                             \u0027(dict) backend\u0027))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_1d220aa3","line":86,"in_reply_to":"fa0719c6_dbe30004","updated":"2016-04-22 04:18:51.000000000","message":"Done","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"10307389241ae236accb6c0b126ca5498a241150","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                      \u0027\"cache_url\" opt is deprecated in Newton release and \u0027"},{"line_number":31,"context_line":"                      \u0027will be removed. Please add a [cache] group  for \u0027"},{"line_number":32,"context_line":"                      \u0027oslo.cache in your neutron.conf and add \"enable\" and \u0027"},{"line_number":33,"context_line":"                      \u0027\"backend\" option in this section\u0027)),"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_c93f8385","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":39},"updated":"2016-05-11 15:29:25.000000000","message":"options","commit_id":"fb742d23f6ef204c4d6968764ee8faf58a902a6c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2bdbe80c60298c16081eb2661dd35015c0fdd132","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":29,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end. \u0027"},{"line_number":30,"context_line":"                      \u0027This option is deprecated in the Newton release and \u0027"},{"line_number":31,"context_line":"                      \u0027will be removed. Please add a [cache] group for \u0027"},{"line_number":32,"context_line":"                      \u0027oslo.cache in your neutron.conf and add \"enable\" and \u0027"},{"line_number":33,"context_line":"                      \u0027\"backend\" options in this section.\u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_4d5b1e2f","line":31,"updated":"2016-06-02 14:58:13.000000000","message":"This is probably also a material for a release note.","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a26f8d8cc960debea534de531bc658904675ffe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":29,"context_line":"               help\u003d_(\u0027URL to connect to the cache back end. \u0027"},{"line_number":30,"context_line":"                      \u0027This option is deprecated in the Newton release and \u0027"},{"line_number":31,"context_line":"                      \u0027will be removed. Please add a [cache] group for \u0027"},{"line_number":32,"context_line":"                      \u0027oslo.cache in your neutron.conf and add \"enable\" and \u0027"},{"line_number":33,"context_line":"                      \u0027\"backend\" options in this section.\u0027)),"},{"line_number":34,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_c34a3fac","line":31,"in_reply_to":"9abb7d3a_4d5b1e2f","updated":"2016-06-02 15:14:22.000000000","message":"Done","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2bdbe80c60298c16081eb2661dd35015c0fdd132","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        region \u003d cache.create_region()"},{"line_number":84,"context_line":"        region_params \u003d {\u0027expiration_time\u0027: expiration_time}"},{"line_number":85,"context_line":"        region.configure(backend, **region_params)"},{"line_number":86,"context_line":"        return region"},{"line_number":87,"context_line":"    else:"},{"line_number":88,"context_line":"        raise RuntimeError(_(\u0027Old style configuration can use only memory \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_e0f019cc","line":85,"range":{"start_line":85,"start_character":34,"end_line":85,"end_character":49},"updated":"2016-06-02 14:58:13.000000000","message":"could as well directly pass it as expiration_time\u003dexpiration_time.","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a26f8d8cc960debea534de531bc658904675ffe","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        region \u003d cache.create_region()"},{"line_number":84,"context_line":"        region_params \u003d {\u0027expiration_time\u0027: expiration_time}"},{"line_number":85,"context_line":"        region.configure(backend, **region_params)"},{"line_number":86,"context_line":"        return region"},{"line_number":87,"context_line":"    else:"},{"line_number":88,"context_line":"        raise RuntimeError(_(\u0027Old style configuration can use only memory \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_c3a6bf52","line":85,"range":{"start_line":85,"start_character":34,"end_line":85,"end_character":49},"in_reply_to":"9abb7d3a_e0f019cc","updated":"2016-06-02 15:14:22.000000000","message":"Done","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"}],"neutron/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        super(TestMetadataProxyHandlerBase, self).setUp()"},{"line_number":56,"context_line":"        self.log_p \u003d mock.patch.object(agent, \u0027LOG\u0027)"},{"line_number":57,"context_line":"        self.log \u003d self.log_p.start()"},{"line_number":58,"context_line":"        for backend in oslo_cache.core._BACKENDS:"},{"line_number":59,"context_line":"            dogpile.cache.register_backend(*backend)"},{"line_number":60,"context_line":"        self.handler \u003d agent.MetadataProxyHandler(self.fake_conf)"},{"line_number":61,"context_line":"        self.handler.plugin_rpc \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_5ed4fe45","line":58,"range":{"start_line":58,"start_character":39,"end_line":58,"end_character":48},"updated":"2016-03-22 17:52:16.000000000","message":"it\u0027s an internal symbol in the library, we should avoid accessing it.","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        super(TestMetadataProxyHandlerBase, self).setUp()"},{"line_number":56,"context_line":"        self.log_p \u003d mock.patch.object(agent, \u0027LOG\u0027)"},{"line_number":57,"context_line":"        self.log \u003d self.log_p.start()"},{"line_number":58,"context_line":"        for backend in oslo_cache.core._BACKENDS:"},{"line_number":59,"context_line":"            dogpile.cache.register_backend(*backend)"},{"line_number":60,"context_line":"        self.handler \u003d agent.MetadataProxyHandler(self.fake_conf)"},{"line_number":61,"context_line":"        self.handler.plugin_rpc \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_718e9428","line":58,"range":{"start_line":58,"start_character":39,"end_line":58,"end_character":48},"in_reply_to":"fa0719c6_5ed4fe45","updated":"2016-04-22 04:18:51.000000000","message":"We could use a oslo_config fixture  instead of FakeConf to avoid accessing it. What do you think about this?","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2bdbe80c60298c16081eb2661dd35015c0fdd132","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    fake_conf \u003d cfg.CONF"},{"line_number":101,"context_line":"    fake_conf_fixture \u003d CacheConfFixture(fake_conf)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def setUp(self):"},{"line_number":104,"context_line":"        super(TestMetadataProxyHandlerCache, self).setUp()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_call(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_0099dd1f","line":103,"updated":"2016-06-02 14:58:13.000000000","message":"Redundant.","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a26f8d8cc960debea534de531bc658904675ffe","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    fake_conf \u003d cfg.CONF"},{"line_number":101,"context_line":"    fake_conf_fixture \u003d CacheConfFixture(fake_conf)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def setUp(self):"},{"line_number":104,"context_line":"        super(TestMetadataProxyHandlerCache, self).setUp()"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def test_call(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_835af74e","line":103,"in_reply_to":"9abb7d3a_0099dd1f","updated":"2016-06-02 15:14:22.000000000","message":"Done","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2bdbe80c60298c16081eb2661dd35015c0fdd132","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    fake_conf \u003d cfg.CONF"},{"line_number":419,"context_line":"    fake_conf_fixture \u003d ConfFixture(fake_conf)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def setUp(self):"},{"line_number":422,"context_line":"        super(TestMetadataProxyHandlerNoCache, self).setUp()"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def test_get_router_networks_twice(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_c08fd5ca","line":421,"updated":"2016-06-02 14:58:13.000000000","message":"Redundant.","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a26f8d8cc960debea534de531bc658904675ffe","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    fake_conf \u003d cfg.CONF"},{"line_number":419,"context_line":"    fake_conf_fixture \u003d ConfFixture(fake_conf)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def setUp(self):"},{"line_number":422,"context_line":"        super(TestMetadataProxyHandlerNoCache, self).setUp()"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def test_get_router_networks_twice(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_633a73e9","line":421,"in_reply_to":"9abb7d3a_c08fd5ca","updated":"2016-06-02 15:14:22.000000000","message":"Done","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"}],"neutron/tests/unit/common/test_cache_utils.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class CacheConf(object):"},{"line_number":36,"context_line":"    def __init__(self, enabled, expiration_time, backend, backend_argument):"},{"line_number":37,"context_line":"        self.enabled \u003d enabled"},{"line_number":38,"context_line":"        self.expiration_time \u003d expiration_time"},{"line_number":39,"context_line":"        self.backend \u003d backend"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_5ed7de22","line":36,"updated":"2016-03-22 17:52:16.000000000","message":"Can we use oslo.config fixture to manage configuration options in the test?","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class CacheConf(object):"},{"line_number":36,"context_line":"    def __init__(self, enabled, expiration_time, backend, backend_argument):"},{"line_number":37,"context_line":"        self.enabled \u003d enabled"},{"line_number":38,"context_line":"        self.expiration_time \u003d expiration_time"},{"line_number":39,"context_line":"        self.backend \u003d backend"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_31ad3c89","line":36,"in_reply_to":"fa0719c6_5ed7de22","updated":"2016-04-22 04:18:51.000000000","message":"Done","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def _test_get_cache_region_helper(self, conf):"},{"line_number":71,"context_line":"        region \u003d cache._get_cache_region(conf)"},{"line_number":72,"context_line":"        self.assertIsNotNone(region)"},{"line_number":73,"context_line":"        self.assertEqual(conf.cache.expiration_time, region.expiration_time)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_get_cache_region(self):"},{"line_number":76,"context_line":"        self._test_get_cache_region_helper(self.dict_conf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_de9f6e4e","line":73,"updated":"2016-03-22 17:52:16.000000000","message":"that line validates oslo.cache, not neutron code. we should avoid doing that.","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def _test_get_cache_region_helper(self, conf):"},{"line_number":71,"context_line":"        region \u003d cache._get_cache_region(conf)"},{"line_number":72,"context_line":"        self.assertIsNotNone(region)"},{"line_number":73,"context_line":"        self.assertEqual(conf.cache.expiration_time, region.expiration_time)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def test_get_cache_region(self):"},{"line_number":76,"context_line":"        self._test_get_cache_region_helper(self.dict_conf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_31c41c3f","line":73,"in_reply_to":"fa0719c6_de9f6e4e","updated":"2016-04-22 04:18:51.000000000","message":"Removed","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertIsNotNone(region)"},{"line_number":82,"context_line":"        self.assertEqual(10, region.expiration_time)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @mock.patch(\u0027dogpile.cache.region.CacheRegion.configure\u0027)"},{"line_number":85,"context_line":"    def test_get_cache(self, mock_cache_region):"},{"line_number":86,"context_line":"        self.assertIsNotNone(cache.get_cache(self.memory_conf))"},{"line_number":87,"context_line":"        self.assertIsNotNone(cache.get_cache(self.dict_conf))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_9eeb36b0","line":84,"updated":"2016-03-22 17:52:16.000000000","message":"that\u0027s internal details of the oslo.cache library, how it manages the cache. We should avoid validating that.","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":14439,"name":"Fang Zhen","email":"zhen.fang@easystack.cn","username":"fangzhen"},"change_message_id":"41bc0fdf79e2b2cc2e395da3cafd891a64d7d0b5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertIsNotNone(region)"},{"line_number":82,"context_line":"        self.assertEqual(10, region.expiration_time)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @mock.patch(\u0027dogpile.cache.region.CacheRegion.configure\u0027)"},{"line_number":85,"context_line":"    def test_get_cache(self, mock_cache_region):"},{"line_number":86,"context_line":"        self.assertIsNotNone(cache.get_cache(self.memory_conf))"},{"line_number":87,"context_line":"        self.assertIsNotNone(cache.get_cache(self.dict_conf))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_91b410d2","line":84,"in_reply_to":"fa0719c6_9eeb36b0","updated":"2016-04-22 04:18:51.000000000","message":"Patches functions of neutron instead.","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2bdbe80c60298c16081eb2661dd35015c0fdd132","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_805aed4e","line":1,"updated":"2016-06-02 14:58:13.000000000","message":"why 2012?","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a26f8d8cc960debea534de531bc658904675ffe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_e305c314","line":1,"in_reply_to":"9abb7d3a_805aed4e","updated":"2016-06-02 15:14:22.000000000","message":"Done","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2bdbe80c60298c16081eb2661dd35015c0fdd132","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_config import fixture as config_fixture"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_c054f522","line":16,"updated":"2016-06-02 14:58:13.000000000","message":"nit: this empty line is not needed.","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8a26f8d8cc960debea534de531bc658904675ffe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_config import fixture as config_fixture"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_fe027608","line":16,"in_reply_to":"9abb7d3a_c054f522","updated":"2016-06-02 15:14:22.000000000","message":"Done","commit_id":"fcd54acc4fd95b021aa03ebaeffa64e36e6645b3"}],"releasenotes/notes/oslo-cache-cache-url-deprecated-16cd3d335c5962eb.yaml":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4143acde56e8741e22db58b6a99403b6a24d78df","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Neutron switched to using oslo.cache library to cache port state in"},{"line_number":4,"context_line":"    metadata agent. With it, more caching backends are now available, including"},{"line_number":5,"context_line":"    Memcached and Mongo. More details in oslo.cache documentation."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - List upgrade notes here, or remove this section."},{"line_number":8,"context_line":"    All of the list items in this section are combined"},{"line_number":9,"context_line":"    when the release notes are rendered, so the text"},{"line_number":10,"context_line":"    needs to be worded so that it does not depend on any"},{"line_number":11,"context_line":"    information only available in another section, such"},{"line_number":12,"context_line":"    as the prelude. This may mean repeating some details."},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - The cache_url configuration option is deprecated as of Newton, and will be"},{"line_number":15,"context_line":"    removed in Ocata. Please configure metadata cache using [cache] group,"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9abb7d3a_7e7326e8","line":12,"range":{"start_line":6,"start_character":0,"end_line":12,"end_character":57},"updated":"2016-06-02 15:19:49.000000000","message":"Remove","commit_id":"ec5d3c234a500e4029be36b55d2bee01b706574e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"20cc926c36b34567c95ee1c3ea7d7131f664104f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Neutron switched to using oslo.cache library to cache port state in"},{"line_number":4,"context_line":"    metadata agent. With it, more caching backends are now available, including"},{"line_number":5,"context_line":"    Memcached and Mongo. More details in oslo.cache documentation."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - List upgrade notes here, or remove this section."},{"line_number":8,"context_line":"    All of the list items in this section are combined"},{"line_number":9,"context_line":"    when the release notes are rendered, so the text"},{"line_number":10,"context_line":"    needs to be worded so that it does not depend on any"},{"line_number":11,"context_line":"    information only available in another section, such"},{"line_number":12,"context_line":"    as the prelude. This may mean repeating some details."},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - The cache_url configuration option is deprecated as of Newton, and will be"},{"line_number":15,"context_line":"    removed in Ocata. Please configure metadata cache using [cache] group,"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9abb7d3a_395b7830","line":12,"range":{"start_line":6,"start_character":0,"end_line":12,"end_character":57},"in_reply_to":"9abb7d3a_7e7326e8","updated":"2016-06-02 15:22:27.000000000","message":"Ouch.","commit_id":"ec5d3c234a500e4029be36b55d2bee01b706574e"}],"requirements.txt":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"22518369cdaa3a54b60f12b1fb4f289e6e518fd3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"six\u003e\u003d1.9.0 # MIT"},{"line_number":28,"context_line":"stevedore\u003e\u003d1.5.0 # Apache-2.0"},{"line_number":29,"context_line":"oslo.cache\u003e\u003d0.8.0 # Apache-2.0"},{"line_number":30,"context_line":"oslo.concurrency\u003e\u003d3.5.0 # Apache-2.0"},{"line_number":31,"context_line":"oslo.config\u003e\u003d3.7.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.context\u003e\u003d0.2.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.db\u003e\u003d4.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"fa0719c6_3ef4aa84","line":30,"updated":"2016-03-22 17:52:16.000000000","message":"you also introduce dogpile dependency, at least for testing [so you could put it in test-requirements.txt].","commit_id":"2cb1a328b775bbb29a84ba628ae7f07975a310a6"}]}