)]}'
{"neutron/coordinator.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"641b1782468e3720d55356cac140c73506e9ca19","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import eventlet"},{"line_number":18,"context_line":"from tooz import coordination"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import exceptions"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_17423068","line":18,"updated":"2016-03-09 17:05:48.000000000","message":"gotta add the dep to reqs.txt","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5655211ba5b569b66072fa30eb383e450b67ca22","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import eventlet"},{"line_number":18,"context_line":"from tooz import coordination"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import exceptions"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1a6b75f2","line":18,"in_reply_to":"5aef4532_17423068","updated":"2016-03-09 17:15:42.000000000","message":"Yeps. This will obviously not pass the gate so I didn\u0027t even try ;-)","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"bd5721b18161073a1be977e9ee8ea587f31a1013","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import exceptions"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"coordinator \u003d None"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def heartbeat_thread():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_057f9666","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":18},"updated":"2016-03-09 17:18:14.000000000","message":"This code here presumes that each worker process has a single thread that runs logic. If this isn\u0027t the case this should be changed to be some sort of a thread-coordinator dict.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6aa909074d0cd81d1b36a49fbf20c8cfa9b0f70d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def heartbeat_thread():"},{"line_number":26,"context_line":"    \"\"\"Makes sure all the threads in the GreenPool are considered alive.\"\"\""},{"line_number":27,"context_line":"    global coordinator"},{"line_number":28,"context_line":"    coordinator \u003d coordination.get_coordinator("},{"line_number":29,"context_line":"        \u0027redis://localhost:6379\u0027, str(os.getpid()))"},{"line_number":30,"context_line":"    coordinator.start()"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_7ad6f9f1","line":28,"updated":"2016-03-09 17:12:42.000000000","message":"I\u0027m surprised to learn there is no backend connection string Oslo config key provided by Tooz.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"132c1ac15004909d740d8ebca331e478a883a5f4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def heartbeat_thread():"},{"line_number":26,"context_line":"    \"\"\"Makes sure all the threads in the GreenPool are considered alive.\"\"\""},{"line_number":27,"context_line":"    global coordinator"},{"line_number":28,"context_line":"    coordinator \u003d coordination.get_coordinator("},{"line_number":29,"context_line":"        \u0027redis://localhost:6379\u0027, str(os.getpid()))"},{"line_number":30,"context_line":"    coordinator.start()"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_fa85e9ce","line":28,"in_reply_to":"5aef4532_7ad6f9f1","updated":"2016-03-09 17:13:49.000000000","message":"Ah, there is - I chose to ignore it in favour of simplifying the POC (making it as clear as possible).","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e2996b6d56d7cf8602695f43d973e3118570a0f9","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    @log_helpers.log_method_call"},{"line_number":208,"context_line":"    def start_rpc_listeners(self):"},{"line_number":209,"context_line":"        \"\"\"Start the RPC loop to let the plugin communicate with agents.\"\"\""},{"line_number":210,"context_line":"        eventlet.spawn(coordinator.heartbeat_thread)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self._setup_rpc()"},{"line_number":213,"context_line":"        self.topic \u003d topics.PLUGIN"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1a5535f9","line":210,"updated":"2016-03-09 17:07:32.000000000","message":"Do you need a heartbeat per neutron-server, or per worker process?","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5655211ba5b569b66072fa30eb383e450b67ca22","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    @log_helpers.log_method_call"},{"line_number":208,"context_line":"    def start_rpc_listeners(self):"},{"line_number":209,"context_line":"        \"\"\"Start the RPC loop to let the plugin communicate with agents.\"\"\""},{"line_number":210,"context_line":"        eventlet.spawn(coordinator.heartbeat_thread)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self._setup_rpc()"},{"line_number":213,"context_line":"        self.topic \u003d topics.PLUGIN"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1a9d350a","line":210,"in_reply_to":"5aef4532_1a5535f9","updated":"2016-03-09 17:15:42.000000000","message":"Basically since a single neutron-server can contain multiple workers and each worker can be raceful with a different one on the same node, per worker heartbeat is needed.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"}],"neutron/scheduler/l3_agent_scheduler.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a1c8ebbe69f9deed4ebbe169a79b9c7a170e8312","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027%(agent_id)s\u0027, {\u0027router_id\u0027: router_id,"},{"line_number":126,"context_line":"                                   \u0027agent_id\u0027: chosen_agent.id})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _schedule_router(self, plugin, context, router_id, candidates\u003dNone):"},{"line_number":129,"context_line":"        lock \u003d coordinator.get_lock(router_id)"},{"line_number":130,"context_line":"        lock.acquire()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_b7f41c5b","line":128,"updated":"2016-03-09 17:04:26.000000000","message":"In this case it looks like we just want a decorator around this entire function.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"3356128c4b04e8d7e231bf780eddeef7cfc2e6a6","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027%(agent_id)s\u0027, {\u0027router_id\u0027: router_id,"},{"line_number":126,"context_line":"                                   \u0027agent_id\u0027: chosen_agent.id})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _schedule_router(self, plugin, context, router_id, candidates\u003dNone):"},{"line_number":129,"context_line":"        lock \u003d coordinator.get_lock(router_id)"},{"line_number":130,"context_line":"        lock.acquire()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_1d4933d1","line":128,"in_reply_to":"5aef4532_1ab41580","updated":"2016-04-04 06:32:37.000000000","message":"In which use case this function is called from two different workers concurrently for same router_id?","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5655211ba5b569b66072fa30eb383e450b67ca22","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027%(agent_id)s\u0027, {\u0027router_id\u0027: router_id,"},{"line_number":126,"context_line":"                                   \u0027agent_id\u0027: chosen_agent.id})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _schedule_router(self, plugin, context, router_id, candidates\u003dNone):"},{"line_number":129,"context_line":"        lock \u003d coordinator.get_lock(router_id)"},{"line_number":130,"context_line":"        lock.acquire()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_1ab41580","line":128,"in_reply_to":"5aef4532_b7f41c5b","updated":"2016-03-09 17:15:42.000000000","message":"I agree - this should go in tooz/oslo, though.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9385e292f6d96cbbeeb0483d94523bbad13255cc","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027%(agent_id)s\u0027, {\u0027router_id\u0027: router_id,"},{"line_number":126,"context_line":"                                   \u0027agent_id\u0027: chosen_agent.id})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _schedule_router(self, plugin, context, router_id, candidates\u003dNone):"},{"line_number":129,"context_line":"        lock \u003d coordinator.get_lock(router_id)"},{"line_number":130,"context_line":"        lock.acquire()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_96fc1d40","line":128,"in_reply_to":"9a061dce_1d6f9393","updated":"2016-04-04 11:09:06.000000000","message":"According to line 74 of this file, it\u0027s calling schedule(). This patch is based on a rather-old patch that significantly modifies the way auto_schedule_routers() currently works.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"bb7044f1b2031a792c95f046e78132f1823f25ca","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027%(agent_id)s\u0027, {\u0027router_id\u0027: router_id,"},{"line_number":126,"context_line":"                                   \u0027agent_id\u0027: chosen_agent.id})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _schedule_router(self, plugin, context, router_id, candidates\u003dNone):"},{"line_number":129,"context_line":"        lock \u003d coordinator.get_lock(router_id)"},{"line_number":130,"context_line":"        lock.acquire()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_1d6f9393","line":128,"in_reply_to":"9a061dce_b725e8af","updated":"2016-04-04 08:30:55.000000000","message":"But I see, auto_schedule_routers directly calling _bind_routers instead of _schedule_router.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"99247154d35aaff6d3bc92207624f9988cc0aa35","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                  \u0027%(agent_id)s\u0027, {\u0027router_id\u0027: router_id,"},{"line_number":126,"context_line":"                                   \u0027agent_id\u0027: chosen_agent.id})"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _schedule_router(self, plugin, context, router_id, candidates\u003dNone):"},{"line_number":129,"context_line":"        lock \u003d coordinator.get_lock(router_id)"},{"line_number":130,"context_line":"        lock.acquire()"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_b725e8af","line":128,"in_reply_to":"ba0121b8_1d4933d1","updated":"2016-04-04 07:15:44.000000000","message":"create_router() (from the API) and auto_schedule_routers() (from the agentS) both call this function.","commit_id":"652796ae0223846a25593fd4e6046e6a19d51b29"}]}
