)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"55df6d9b16d28ecf0ad7ab9776b09765699ff3dd","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"                    dns_assignment \u003d self._get_dns_names_for_port("},{"line_number":1251,"context_line":"                        context, ips, request_dns_name)"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"            if (\u0027dns-integration\u0027 in self.supported_extension_aliases and"},{"line_number":1254,"context_line":"                \u0027dns_name\u0027 in p):"},{"line_number":1255,"context_line":"                db_port[\u0027dns_assignment\u0027] \u003d dns_assignment"},{"line_number":1256,"context_line":"        return db_port"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_698360cd","line":1253,"updated":"2016-03-11 19:48:12.000000000","message":"is this intentional?","commit_id":"7793cb890e1c04ccab4c5d4e438c042feb1f2f15"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0acf41f5f291c6ff40e8e2faf20d4ce839689b21","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"                    dns_assignment \u003d self._get_dns_names_for_port("},{"line_number":1251,"context_line":"                        context, ips, request_dns_name)"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"            if (\u0027dns-integration\u0027 in self.supported_extension_aliases and"},{"line_number":1254,"context_line":"                \u0027dns_name\u0027 in p):"},{"line_number":1255,"context_line":"                db_port[\u0027dns_assignment\u0027] \u003d dns_assignment"},{"line_number":1256,"context_line":"        return db_port"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_7a6f9c92","line":1253,"in_reply_to":"3afc51ec_698360cd","updated":"2016-03-11 21:00:18.000000000","message":"It may actually make sense to move it here [though not strictly needed for the patch], but then we probably need to remove lines 1253-1254 since they are identical to 1246-1247.","commit_id":"7793cb890e1c04ccab4c5d4e438c042feb1f2f15"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d10f64d3b80925fe4b0ba55fcafaac522fcf9bcb","unresolved":false,"context_lines":[{"line_number":1250,"context_line":"                    dns_assignment \u003d self._get_dns_names_for_port("},{"line_number":1251,"context_line":"                        context, ips, request_dns_name)"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"            if (\u0027dns-integration\u0027 in self.supported_extension_aliases and"},{"line_number":1254,"context_line":"                \u0027dns_name\u0027 in p):"},{"line_number":1255,"context_line":"                db_port[\u0027dns_assignment\u0027] \u003d dns_assignment"},{"line_number":1256,"context_line":"        return db_port"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_9aca684e","line":1253,"in_reply_to":"3afc51ec_698360cd","updated":"2016-03-11 21:01:46.000000000","message":"yes, there was no reason for it to be in the outer transaction. When it was first introduced outside of the transaction it wasn\u0027t updating the db_port so it didn\u0027t really matter, it was just a dict after another dict update. I think nobody thought to move it in once it was updating the db record.\n\nhttps://review.openstack.org/#/c/200952/24/neutron/db/db_base_plugin_v2.py","commit_id":"7793cb890e1c04ccab4c5d4e438c042feb1f2f15"}]}