)]}'
{"quantum/plugins/cisco/db/nexus_db_v2.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":"                   filter_by(switch_ip\u003dswitch_ip).all())"},{"line_number":148,"context_line":"        return binding"},{"line_number":149,"context_line":"    except exc.NoResultFound:"},{"line_number":150,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F8pU%3D","line":150,"updated":"2013-05-16 13:32:09.000000000","message":"why not return None?","commit_id":"8da2e971290f5091cb15513cb27700ce5c0a72b5"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"530947a5ec57a096c9defa6e28c577bfaf8caef4","unresolved":false,"context_lines":[{"line_number":147,"context_line":"                   filter_by(switch_ip\u003dswitch_ip).all())"},{"line_number":148,"context_line":"        return binding"},{"line_number":149,"context_line":"    except exc.NoResultFound:"},{"line_number":150,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F8F4%3D","line":150,"in_reply_to":"AAAAO3%2F%2F8pU%3D","updated":"2013-05-16 17:15:05.000000000","message":"Done","commit_id":"8da2e971290f5091cb15513cb27700ce5c0a72b5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":"                   filter_by(switch_ip\u003dswitch_ip).all())"},{"line_number":148,"context_line":"        return binding"},{"line_number":149,"context_line":"    except exc.NoResultFound:"},{"line_number":150,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2F07Q%3D","line":150,"updated":"2013-05-22 06:08:14.000000000","message":"nit: return (none is implied)","commit_id":"5d2bec410ecab06c23aba96fef7ce9655a571921"}],"quantum/tests/unit/cisco/test_network_plugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8407991ddf7859dc80309a0f5732d63c946f59ec","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.mock_ncclient.configure_mock(**config)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @contextlib.contextmanager"},{"line_number":156,"context_line":"    def _create_port_res(self, name\u003d\u0027myname\u0027, cidr\u003d\u00271.0.0.0/24\u0027,"},{"line_number":157,"context_line":"                         do_delete\u003dTrue):"},{"line_number":158,"context_line":"        \"\"\"Create a network, subnet, and port and yield the result."},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F96s%3D","line":156,"updated":"2013-05-15 22:32:51.000000000","message":"I think you should delete this method and use the one in test_db_plugin.py \n\n    @contextlib.contextmanager\n    def port(self, subnet\u003dNone, fmt\u003dNone, no_delete\u003dFalse,\n             **kwargs):\n        with optional_ctx(subnet, self.subnet) as subnet_to_use:\n            net_id \u003d subnet_to_use[\u0027subnet\u0027][\u0027network_id\u0027]\n            port \u003d self._make_port(fmt or self.fmt, net_id, **kwargs)\n            try:\n                yield port\n            finally:\n                if not no_delete:\n                    self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])","commit_id":"8da2e971290f5091cb15513cb27700ce5c0a72b5"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"530947a5ec57a096c9defa6e28c577bfaf8caef4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.mock_ncclient.configure_mock(**config)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @contextlib.contextmanager"},{"line_number":156,"context_line":"    def _create_port_res(self, name\u003d\u0027myname\u0027, cidr\u003d\u00271.0.0.0/24\u0027,"},{"line_number":157,"context_line":"                         do_delete\u003dTrue):"},{"line_number":158,"context_line":"        \"\"\"Create a network, subnet, and port and yield the result."},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F9uQ%3D","line":156,"in_reply_to":"AAAAO3%2F%2F96s%3D","updated":"2013-05-15 23:28:30.000000000","message":"For some of the unit tests in this module (added with an earlier commit), I needed a method which would yield the result (\u0027res\u0027) of the API request so that the HTTP result codes could be confirmed. The method in test_db_plugin.py only returns the port. For this (new) commit, I\u0027m modifying and re-using the _create_port_res() method so that I have access to the network name and subnet cidr.","commit_id":"8da2e971290f5091cb15513cb27700ce5c0a72b5"},{"author":{"_account_id":6695,"name":"Dane LeBlanc","email":"leblancd@cisco.com","username":"leblancd"},"change_message_id":"530947a5ec57a096c9defa6e28c577bfaf8caef4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.mock_ncclient.configure_mock(**config)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @contextlib.contextmanager"},{"line_number":156,"context_line":"    def _create_port_res(self, name\u003d\u0027myname\u0027, cidr\u003d\u00271.0.0.0/24\u0027,"},{"line_number":157,"context_line":"                         do_delete\u003dTrue):"},{"line_number":158,"context_line":"        \"\"\"Create a network, subnet, and port and yield the result."},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F79s%3D","line":156,"in_reply_to":"AAAAO3%2F%2F9uQ%3D","updated":"2013-05-16 17:50:38.000000000","message":"@Aaron, let me know if my response isn\u0027t satisfactory, or if there is any other optimization that I can consider. I uploaded a new patch set without making changes to _create_port_res.","commit_id":"8da2e971290f5091cb15513cb27700ce5c0a72b5"}]}