)]}'
{"etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":"# (BoolOpt) Enable server RPC compatibility with old (pre-havana)"},{"line_number":62,"context_line":"# agents."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# Default: rpc_support_old_agents \u003d False"},{"line_number":65,"context_line":"# Example: rpc_support_old_agents \u003d True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[SECURITYGROUP]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAO3%2F%2F%2BkU%3D","line":64,"updated":"2013-05-15 18:44:51.000000000","message":"Should the default not be True to support backward compatibility?","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":"# (BoolOpt) Enable server RPC compatibility with old (pre-havana)"},{"line_number":62,"context_line":"# agents."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# Default: rpc_support_old_agents \u003d False"},{"line_number":65,"context_line":"# Example: rpc_support_old_agents \u003d True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[SECURITYGROUP]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAO3%2F%2F9e8%3D","line":64,"in_reply_to":"AAAAO3%2F%2F%2Beo%3D","updated":"2013-05-16 02:14:14.000000000","message":"Done - Changed default to True for now, with revisit to change to False prior to havana rc1.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":"# (BoolOpt) Enable server RPC compatibility with old (pre-havana)"},{"line_number":62,"context_line":"# agents."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# Default: rpc_support_old_agents \u003d False"},{"line_number":65,"context_line":"# Example: rpc_support_old_agents \u003d True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[SECURITYGROUP]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAO3%2F%2F%2Beo%3D","line":64,"in_reply_to":"AAAAO3%2F%2F%2BkU%3D","updated":"2013-05-15 19:31:50.000000000","message":"Regardless of configuration, an updated linuxbridge-agent is compatible with an old linuxbridge plugin, so this does not need to be set to True during an upgrade unless the plugin is being upgraded before the agents. This option results in redundant attributes in the messages, so it would ideally be off by default, at least by the time havana ships. If its important, we could set the default to True for some period of time to allow trunk-chasers to avoiding having to think about the upgrade, then change it to False before the havana RCs. Let me know if this needs to change.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":61,"context_line":"# (BoolOpt) Enable server RPC compatibility with old (pre-havana)"},{"line_number":62,"context_line":"# agents."},{"line_number":63,"context_line":"#"},{"line_number":64,"context_line":"# Default: rpc_support_old_agents \u003d False"},{"line_number":65,"context_line":"# Example: rpc_support_old_agents \u003d True"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[SECURITYGROUP]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAAO3%2F%2F9Tc%3D","line":64,"in_reply_to":"AAAAO3%2F%2F9e8%3D","updated":"2013-05-16 05:43:47.000000000","message":"I\u0027m not sure this option should be turned off before Havana release. I don\u0027t know it is usual to upgrade quantum-server after upgrading all agents (I am thinking cases where users cannot do this due to some other limitations). IMHO, it is better to set True during the upgrade to Havana and turn off after the upgrade finishes. It looks safe.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"}],"quantum/plugins/linuxbridge/common/config.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027, default\u003d2,"},{"line_number":47,"context_line":"               help\u003d_(\"The number of seconds the agent will wait between \""},{"line_number":48,"context_line":"                      \"polling for local device changes.\")),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027rpc_support_old_agents\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Enable server RPC compatibility with old agents\")),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2F0E%3D","line":49,"updated":"2013-05-15 08:31:07.000000000","message":"For backward compatibility, it is better the default value is True.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027, default\u003d2,"},{"line_number":47,"context_line":"               help\u003d_(\"The number of seconds the agent will wait between \""},{"line_number":48,"context_line":"                      \"polling for local device changes.\")),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027rpc_support_old_agents\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Enable server RPC compatibility with old agents\")),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F9fI%3D","line":49,"in_reply_to":"AAAAO3%2F%2F%2BeQ%3D","updated":"2013-05-16 02:14:14.000000000","message":"Done","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027polling_interval\u0027, default\u003d2,"},{"line_number":47,"context_line":"               help\u003d_(\"The number of seconds the agent will wait between \""},{"line_number":48,"context_line":"                      \"polling for local device changes.\")),"},{"line_number":49,"context_line":"    cfg.BoolOpt(\u0027rpc_support_old_agents\u0027, default\u003dFalse,"},{"line_number":50,"context_line":"                help\u003d_(\"Enable server RPC compatibility with old agents\")),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BeQ%3D","line":49,"in_reply_to":"AAAAO3%2F%2F%2F0E%3D","updated":"2013-05-15 19:31:50.000000000","message":"See response to similar comment in https://review.openstack.org/#/c/29199/1/etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini. Let me know if the default definitely needs to change.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"}],"quantum/plugins/linuxbridge/common/constants.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"aa51b73c02cecd038fa61ac4d2581535654be1a8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Return (network_type, segmentation_id) tuple for encoded vlan_id.\"\"\""},{"line_number":35,"context_line":"    if vlan_id \u003d\u003d LOCAL_VLAN_ID:"},{"line_number":36,"context_line":"        return (TYPE_LOCAL, None)"},{"line_number":37,"context_line":"    elif vlan_id \u003d\u003d LOCAL_VLAN_ID:"},{"line_number":38,"context_line":"        return (TYPE_FLAT, None)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return (TYPE_VLAN, vlan_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2F%2B8%3D","line":37,"updated":"2013-05-15 06:00:14.000000000","message":"FLAT_VLAN_ID? why the test cases does not catch it?","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Return (network_type, segmentation_id) tuple for encoded vlan_id.\"\"\""},{"line_number":35,"context_line":"    if vlan_id \u003d\u003d LOCAL_VLAN_ID:"},{"line_number":36,"context_line":"        return (TYPE_LOCAL, None)"},{"line_number":37,"context_line":"    elif vlan_id \u003d\u003d LOCAL_VLAN_ID:"},{"line_number":38,"context_line":"        return (TYPE_FLAT, None)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return (TYPE_VLAN, vlan_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BR4%3D","line":37,"in_reply_to":"AAAAO3%2F%2F%2Bd8%3D","updated":"2013-05-16 02:14:14.000000000","message":"Done - Fixed function and added tests for flat and local cases.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Return (network_type, segmentation_id) tuple for encoded vlan_id.\"\"\""},{"line_number":35,"context_line":"    if vlan_id \u003d\u003d LOCAL_VLAN_ID:"},{"line_number":36,"context_line":"        return (TYPE_LOCAL, None)"},{"line_number":37,"context_line":"    elif vlan_id \u003d\u003d LOCAL_VLAN_ID:"},{"line_number":38,"context_line":"        return (TYPE_FLAT, None)"},{"line_number":39,"context_line":"    else:"},{"line_number":40,"context_line":"        return (TYPE_VLAN, vlan_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2Bd8%3D","line":37,"in_reply_to":"AAAAO3%2F%2F%2F%2B8%3D","updated":"2013-05-15 19:31:50.000000000","message":"Good catch. I had done most of my manual testing before introducing this helper function. I\u0027ll fix this and see if a unit test should/can catch it.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"}],"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                port\u003dport,"},{"line_number":185,"context_line":"                                network_type\u003dnetwork_type,"},{"line_number":186,"context_line":"                                physical_network\u003dphysical_network,"},{"line_number":187,"context_line":"                                segmentation_id\u003dsegmentation_id)"},{"line_number":188,"context_line":"        self.fanout_cast(context, msg,"},{"line_number":189,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2FxY%3D","line":187,"updated":"2013-05-15 08:31:07.000000000","message":"The following doesn\u0027t work. it is easier to know the difference:\n\nkwargs \u003d {\u0027port\u0027: port,\n          \u0027network_type\u0027: network_type,\n          \u0027physical_network\u0027: physical_network,\n          \u0027segmentation_id\u0027: segmentation_id}\nif cfg.CONF.AGENT.rpc_support_old_agents:\n    kwargs[\u0027vlan_id\u0027] \u003d vlan_id\nmsg \u003d self.make_msg(\u0027port_update\u0027, **kwargs)","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                port\u003dport,"},{"line_number":185,"context_line":"                                network_type\u003dnetwork_type,"},{"line_number":186,"context_line":"                                physical_network\u003dphysical_network,"},{"line_number":187,"context_line":"                                segmentation_id\u003dsegmentation_id)"},{"line_number":188,"context_line":"        self.fanout_cast(context, msg,"},{"line_number":189,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F9UU%3D","line":187,"in_reply_to":"AAAAO3%2F%2F%2BNc%3D","updated":"2013-05-16 05:43:47.000000000","message":"Oops. I tried to write \"Doesn\u0027t the following work?\".","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                port\u003dport,"},{"line_number":185,"context_line":"                                network_type\u003dnetwork_type,"},{"line_number":186,"context_line":"                                physical_network\u003dphysical_network,"},{"line_number":187,"context_line":"                                segmentation_id\u003dsegmentation_id)"},{"line_number":188,"context_line":"        self.fanout_cast(context, msg,"},{"line_number":189,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BNc%3D","line":187,"in_reply_to":"AAAAO3%2F%2F%2Bdo%3D","updated":"2013-05-16 02:14:14.000000000","message":"Done","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                port\u003dport,"},{"line_number":185,"context_line":"                                network_type\u003dnetwork_type,"},{"line_number":186,"context_line":"                                physical_network\u003dphysical_network,"},{"line_number":187,"context_line":"                                segmentation_id\u003dsegmentation_id)"},{"line_number":188,"context_line":"        self.fanout_cast(context, msg,"},{"line_number":189,"context_line":"                         topic\u003dself.topic_port_update)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2Bdo%3D","line":187,"in_reply_to":"AAAAO3%2F%2F%2FxY%3D","updated":"2013-05-15 19:31:50.000000000","message":"I like that better and will give it a try. I\u0027m not sure if you really meant to say \"The following doesn\u0027t work\"?","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"}],"quantum/tests/unit/linuxbridge/test_rpcapi.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"aa51b73c02cecd038fa61ac4d2581535654be1a8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                          \u0027network_delete\u0027, rpc_method\u003d\u0027fanout_cast\u0027,"},{"line_number":70,"context_line":"                          network_id\u003d\u0027fake_request_spec\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_port_update(self):"},{"line_number":73,"context_line":"        rpcapi \u003d plb.AgentNotifierApi(topics.AGENT)"},{"line_number":74,"context_line":"        expected_msg \u003d rpcapi.make_msg(\u0027port_update\u0027,"},{"line_number":75,"context_line":"                                       port\u003d\u0027fake_port\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2F%2Bs%3D","line":72,"updated":"2013-05-15 06:00:14.000000000","message":"how about adding a case with support_old_agent being true?","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":69,"context_line":"                          \u0027network_delete\u0027, rpc_method\u003d\u0027fanout_cast\u0027,"},{"line_number":70,"context_line":"                          network_id\u003d\u0027fake_request_spec\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_port_update(self):"},{"line_number":73,"context_line":"        rpcapi \u003d plb.AgentNotifierApi(topics.AGENT)"},{"line_number":74,"context_line":"        expected_msg \u003d rpcapi.make_msg(\u0027port_update\u0027,"},{"line_number":75,"context_line":"                                       port\u003d\u0027fake_port\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BDo%3D","line":72,"in_reply_to":"AAAAO3%2F%2F%2BaQ%3D","updated":"2013-05-16 02:14:14.000000000","message":"Done - Added test_port_update_old_agent().","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":69,"context_line":"                          \u0027network_delete\u0027, rpc_method\u003d\u0027fanout_cast\u0027,"},{"line_number":70,"context_line":"                          network_id\u003d\u0027fake_request_spec\u0027)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_port_update(self):"},{"line_number":73,"context_line":"        rpcapi \u003d plb.AgentNotifierApi(topics.AGENT)"},{"line_number":74,"context_line":"        expected_msg \u003d rpcapi.make_msg(\u0027port_update\u0027,"},{"line_number":75,"context_line":"                                       port\u003d\u0027fake_port\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2BaQ%3D","line":72,"in_reply_to":"AAAAO3%2F%2F%2F%2Bs%3D","updated":"2013-05-15 19:31:50.000000000","message":"I\u0027ll look into this.","commit_id":"6754ff64b2d6e8d7f989e3dc9f49eea31646284c"}]}