)]}'
{"neutron/tests/api/test_tag.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6f61d5dfa02030d057437238d288bb79be9116c1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def resource_setup(cls):"},{"line_number":23,"context_line":"        super(TagTestJSON, cls).resource_setup()"},{"line_number":24,"context_line":"        if not test.is_extension_enabled(\u0027tag\u0027, \u0027network\u0027):"},{"line_number":25,"context_line":"            msg \u003d \"tag extension not enabled.\""},{"line_number":26,"context_line":"            raise cls.skipException(msg)"},{"line_number":27,"context_line":"        network \u003d cls.create_network()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_9b29958c","line":24,"updated":"2016-03-14 13:11:15.000000000","message":"there\u0027s a skip_checks method, have you consider using that instead?","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"44009b77be5b122a912f31ab3cae0bccc00429cb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    @classmethod"},{"line_number":22,"context_line":"    def resource_setup(cls):"},{"line_number":23,"context_line":"        super(TagTestJSON, cls).resource_setup()"},{"line_number":24,"context_line":"        if not test.is_extension_enabled(\u0027tag\u0027, \u0027network\u0027):"},{"line_number":25,"context_line":"            msg \u003d \"tag extension not enabled.\""},{"line_number":26,"context_line":"            raise cls.skipException(msg)"},{"line_number":27,"context_line":"        network \u003d cls.create_network()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_b58ec2cd","line":24,"in_reply_to":"3afc51ec_9b29958c","updated":"2016-03-18 08:43:30.000000000","message":"Done","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6f61d5dfa02030d057437238d288bb79be9116c1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        network \u003d cls.create_network()"},{"line_number":28,"context_line":"        cls.net_id \u003d network[\u0027id\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def tearDown(self):"},{"line_number":31,"context_line":"        super(TagTestJSON, self).tearDown()"},{"line_number":32,"context_line":"        # make sure cls network has no tags."},{"line_number":33,"context_line":"        self.client.delete_tags(\u0027networks\u0027, self.net_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_9b77d59e","line":30,"updated":"2016-03-14 13:11:15.000000000","message":"this should be:\n\n  @classmethod\n   def resource_cleanup(cls):","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"44009b77be5b122a912f31ab3cae0bccc00429cb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        network \u003d cls.create_network()"},{"line_number":28,"context_line":"        cls.net_id \u003d network[\u0027id\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def tearDown(self):"},{"line_number":31,"context_line":"        super(TagTestJSON, self).tearDown()"},{"line_number":32,"context_line":"        # make sure cls network has no tags."},{"line_number":33,"context_line":"        self.client.delete_tags(\u0027networks\u0027, self.net_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d5042e19","line":30,"in_reply_to":"3afc51ec_9b77d59e","updated":"2016-03-18 08:43:30.000000000","message":"This was removed because of parallel test support.","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6f61d5dfa02030d057437238d288bb79be9116c1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":45,"context_line":"    @test.idempotent_id(\u00275621062d-fbfb-4437-9d69-138c78ea4188\u0027)"},{"line_number":46,"context_line":"    def test_update_tag(self):"},{"line_number":47,"context_line":"        self.client.update_tag(\u0027networks\u0027, self.net_id, \u0027red\u0027)"},{"line_number":48,"context_line":"        self._get_and_compare_tags([\u0027red\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_5be38d33","line":47,"updated":"2016-03-14 13:11:15.000000000","message":"it\u0027s weird this takes a single tag, whereas update_tags takes a dict {\u0027tags\u0027: tags}. Wouldn\u0027t it be better to pass a list to client.update_tags instead?","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"44009b77be5b122a912f31ab3cae0bccc00429cb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":45,"context_line":"    @test.idempotent_id(\u00275621062d-fbfb-4437-9d69-138c78ea4188\u0027)"},{"line_number":46,"context_line":"    def test_update_tag(self):"},{"line_number":47,"context_line":"        self.client.update_tag(\u0027networks\u0027, self.net_id, \u0027red\u0027)"},{"line_number":48,"context_line":"        self._get_and_compare_tags([\u0027red\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_b01b70c9","line":47,"in_reply_to":"3afc51ec_5be38d33","updated":"2016-03-18 08:43:30.000000000","message":"That tests PUT API which can put single tag only so it\u0027s not weird. Tag has 2 PUT API.\n\n - PUT /v2.0/networks/{network_id}/tags/{tag}\n - PUT /v2.0/networks/{network_id}/tags with request payload {\u0027tags\u0027: [\u0027red\u0027, \u0027blue\u0027]}\n\n\nI changed the arguments to list.","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2a5ecd87f0e3da69e4b3edbcbe6e80d70ab425fd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                          \u0027networks\u0027, self.net_id, \u0027green\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class TagFilterTestJSON(base.BaseAdminNetworkTest):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_fbfed969","line":109,"updated":"2016-03-14 13:13:32.000000000","message":"have you considered what happens when tests are executed in concurrency? Are you sure that they are not gonna stampede on each other causing filtering to be returning results that you cannot expect reliably?","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"44009b77be5b122a912f31ab3cae0bccc00429cb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                          \u0027networks\u0027, self.net_id, \u0027green\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"class TagFilterTestJSON(base.BaseAdminNetworkTest):"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d0a8bc22","line":109,"in_reply_to":"3afc51ec_fbfed969","updated":"2016-03-18 08:43:30.000000000","message":"You\u0027re right. I tried to consider collision issues in concurrency case.","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6f61d5dfa02030d057437238d288bb79be9116c1","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def resource_setup(cls):"},{"line_number":113,"context_line":"        super(TagFilterTestJSON, cls).resource_setup()"},{"line_number":114,"context_line":"        if not test.is_extension_enabled(\u0027tag\u0027, \u0027network\u0027):"},{"line_number":115,"context_line":"            msg \u003d \"tag extension not enabled.\""},{"line_number":116,"context_line":"            raise cls.skipException(msg)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_fb26d966","line":114,"updated":"2016-03-14 13:11:15.000000000","message":"see above","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"44009b77be5b122a912f31ab3cae0bccc00429cb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def resource_setup(cls):"},{"line_number":113,"context_line":"        super(TagFilterTestJSON, cls).resource_setup()"},{"line_number":114,"context_line":"        if not test.is_extension_enabled(\u0027tag\u0027, \u0027network\u0027):"},{"line_number":115,"context_line":"            msg \u003d \"tag extension not enabled.\""},{"line_number":116,"context_line":"            raise cls.skipException(msg)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_d5a8ae22","line":114,"in_reply_to":"3afc51ec_fb26d966","updated":"2016-03-18 08:43:30.000000000","message":"Done","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"}],"neutron/tests/tempest/api/test_tag.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e79d61f3fab00c424d6b8f806561788c8f6afc34","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self._assertEqualResources([\u0027tag-res2\u0027, \u0027tag-res3\u0027], res)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # tags-any multi"},{"line_number":134,"context_line":"        filters \u003d {\u0027tags-any\u0027: \u0027red,blue\u0027}"},{"line_number":135,"context_line":"        res \u003d self._list_resource(filters)"},{"line_number":136,"context_line":"        self._assertEqualResources([\u0027tag-res1\u0027, \u0027tag-res2\u0027, \u0027tag-res3\u0027], res)"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_0e8b3c69","line":134,"updated":"2016-12-10 00:19:15.000000000","message":"wouldnt a better test be with red,green or blue,green?  all blue resources are red as well.","commit_id":"a348c389583a0b7a9c48ed5a7cbc4ae734b766ee"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e79d61f3fab00c424d6b8f806561788c8f6afc34","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"class TagFilterNetworkTestJSON(TagFilterTestJSON):"},{"line_number":160,"context_line":"    resource \u003d \u0027networks\u0027"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    @classmethod"},{"line_number":163,"context_line":"    def _create_resource(cls, name):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_0ee25c2f","line":160,"updated":"2016-12-10 00:19:15.000000000","message":"nit: already set in parent","commit_id":"a348c389583a0b7a9c48ed5a7cbc4ae734b766ee"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"e79d61f3fab00c424d6b8f806561788c8f6afc34","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def _list_resource(self, filters):"},{"line_number":168,"context_line":"        res \u003d self.client.list_networks(**filters)"},{"line_number":169,"context_line":"        return res[\u0027networks\u0027]"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":172,"context_line":"    @test.idempotent_id(\u0027a66b5cca-7db2-40f5-a33d-8ac9f864e53e\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_eebb600d","line":169,"range":{"start_line":169,"start_character":19,"end_line":169,"end_character":29},"updated":"2016-12-10 00:19:15.000000000","message":"nit: self.resource","commit_id":"a348c389583a0b7a9c48ed5a7cbc4ae734b766ee"}],"neutron/tests/tempest/services/network/json/network_client.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2a5ecd87f0e3da69e4b3edbcbe6e80d70ab425fd","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        resp, body \u003d self.put(uri, None)"},{"line_number":734,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def update_tags(self, resource_type, resource_id, body):"},{"line_number":737,"context_line":"        uri \u003d \u0027%s/%s/%s/tags\u0027 % ("},{"line_number":738,"context_line":"            self.uri_prefix, resource_type, resource_id)"},{"line_number":739,"context_line":"        req_body \u003d json.dumps(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_fbb099df","line":736,"updated":"2016-03-14 13:13:32.000000000","message":"these two could be merged to handle both cases of single vs multiple tags?","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"44009b77be5b122a912f31ab3cae0bccc00429cb","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        resp, body \u003d self.put(uri, None)"},{"line_number":734,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def update_tags(self, resource_type, resource_id, body):"},{"line_number":737,"context_line":"        uri \u003d \u0027%s/%s/%s/tags\u0027 % ("},{"line_number":738,"context_line":"            self.uri_prefix, resource_type, resource_id)"},{"line_number":739,"context_line":"        req_body \u003d json.dumps(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_559dbe08","line":736,"in_reply_to":"3afc51ec_fbb099df","updated":"2016-03-18 08:43:30.000000000","message":"These API have some gaps: URI, Request Body, and Return Body so it\u0027s better to keep divided.","commit_id":"f9e6d3e78843120abc9019cb1990a5cc46d8ffe4"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0c172fcde0f4f84e4381394043a89d27c42bbb3a","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        uri \u003d \u0027%s/%s/%s/tags\u0027 % ("},{"line_number":738,"context_line":"            self.uri_prefix, resource_type, resource_id)"},{"line_number":739,"context_line":"        req_body \u003d json.dumps({\u0027tags\u0027: tags})"},{"line_number":740,"context_line":"        resp, res_body \u003d self.put(uri, req_body)"},{"line_number":741,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":742,"context_line":"        res_body \u003d json.loads(res_body)"},{"line_number":743,"context_line":"        return service_client.ResponseBody(resp, res_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_62383aa1","line":740,"range":{"start_line":740,"start_character":8,"end_line":740,"end_character":22},"updated":"2016-04-06 06:07:22.000000000","message":"In other methods, they are \u0027resp, body\u0027.\nIMO, it is disunity.\nBut just a nit.","commit_id":"3cd939ad674c172e52a8e8e923bf477c77d2cb55"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"91f67038f2f2e57d77a272952c63a268602a0204","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        resp, body \u003d self.delete(uri)"},{"line_number":837,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def delete_tag(self, resource_type, resource_id, tag):"},{"line_number":840,"context_line":"        uri \u003d \u0027%s/%s/%s/tags/%s\u0027 % ("},{"line_number":841,"context_line":"            self.uri_prefix, resource_type, resource_id, tag)"},{"line_number":842,"context_line":"        resp, body \u003d self.delete(uri)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_d1b1bb02","line":839,"updated":"2016-11-10 13:22:33.000000000","message":"Can not be _deleter/_updater work for some of this methods?","commit_id":"a348c389583a0b7a9c48ed5a7cbc4ae734b766ee"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"359a7cddf2863d2335f1a4172a766c9aee549fad","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        resp, body \u003d self.delete(uri)"},{"line_number":837,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def delete_tag(self, resource_type, resource_id, tag):"},{"line_number":840,"context_line":"        uri \u003d \u0027%s/%s/%s/tags/%s\u0027 % ("},{"line_number":841,"context_line":"            self.uri_prefix, resource_type, resource_id, tag)"},{"line_number":842,"context_line":"        resp, body \u003d self.delete(uri)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_6487dd0f","line":839,"in_reply_to":"9a629dbe_d1b1bb02","updated":"2016-11-15 08:52:33.000000000","message":"I don\u0027t think it\u0027s reasonable because Tag API is different from general API and it needs specific codes for tag only in _deleter/_updater.","commit_id":"a348c389583a0b7a9c48ed5a7cbc4ae734b766ee"}]}
