)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"f28be3874075137540317a1974aade726d3c6ab7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adit Sarfaty \u003casarfaty@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-14 14:22:52 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QOs: TestQosPlugin receives the plugin name dynamically"},{"line_number":8,"context_line":"The neutron QoS plugin test class \u0027TestQosPlugin\u0027 used the hard coded"},{"line_number":9,"context_line":"name \u0027qos\u0027 as the plugin name (alias, in this case), as well as"},{"line_number":10,"context_line":"hard coded core plugin name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afc51ec_1acd835d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":55},"updated":"2016-03-14 12:27:40.000000000","message":"Please enter a line of space between the title and the description, ie. line 8 should be just an empty line","commit_id":"edecd4ca05459fa302df2eb07b0419d0020b3871"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"f28be3874075137540317a1974aade726d3c6ab7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        self.rule \u003d rule_object.QosBandwidthLimitRule("},{"line_number":70,"context_line":"            self.ctxt, **self.rule_data[\u0027bandwidth_limit_rule\u0027])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _qos_plugin_name(self):"},{"line_number":73,"context_line":"        return \"qos\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _core_plugin_name(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_fab097df","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":31},"updated":"2016-03-14 12:27:40.000000000","message":"This should be a some class attribute that can be overridden by subclassing, and not a bound (non-static) method.","commit_id":"edecd4ca05459fa302df2eb07b0419d0020b3871"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"f28be3874075137540317a1974aade726d3c6ab7","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def _qos_plugin_name(self):"},{"line_number":73,"context_line":"        return \"qos\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _core_plugin_name(self):"},{"line_number":76,"context_line":"        return DB_PLUGIN_KLASS"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _validate_notif_driver_params(self, method_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_7ac5a73a","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":31},"updated":"2016-03-14 12:27:40.000000000","message":"ditto","commit_id":"edecd4ca05459fa302df2eb07b0419d0020b3871"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"027fcd7b5f1c08043250149998fe10b1ae76f3b4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class TestQosPlugin(base.BaseQosTestCase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    _core_plugin_name \u003d DB_PLUGIN_KLASS"},{"line_number":33,"context_line":"    _qos_plugin_name \u003d \"qos\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_e1f71c57","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":21},"updated":"2016-03-15 09:17:46.000000000","message":"As per other examples throughout the code [1], please use capital letters to name these:\n\n CORE_PLUGIN_NAME \u003d DB_PLUGIN_KLASS\n QOS_PLUGIN_NAME \u003d \"qos\"\n\n[1]: find neutron/tests/ -name \"*.py\" -type f | xargs grep -E \"^    [A-Z][A-Z]+\"","commit_id":"d371cca1bc7a60a0fce6b39220d13d255b628eb8"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"16fb9097aba95e6a8dbfeaa6ad66003a1c61a086","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027neutron.objects.qos.policy.QosPolicy.obj_load_attr\u0027).start()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        cfg.CONF.set_override(\"core_plugin\", self.CORE_PLUGIN_NAME)"},{"line_number":47,"context_line":"        cfg.CONF.set_override(\"service_plugins\", [self.QOS_PLUGIN_NAME])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        mgr \u003d manager.NeutronManager.get_instance()"},{"line_number":50,"context_line":"        self.qos_plugin \u003d mgr.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_02043015","line":47,"range":{"start_line":47,"start_character":55,"end_line":47,"end_character":70},"updated":"2016-03-15 20:09:58.000000000","message":"If you\u0027re overriding service_plugins option, probably would be better to call this variable as SERVICE_PLUGIN_NAME instead of just QOS_*\nIt would allow for greater re-usage of this class.","commit_id":"0ed676c854eb034e2fc2419b95225a9ffdd2b377"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab5a4503362c91e835e333aea7b4efc70e492a9c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027neutron.objects.qos.policy.QosPolicy.obj_load_attr\u0027).start()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        cfg.CONF.set_override(\"core_plugin\", self.CORE_PLUGIN_NAME)"},{"line_number":47,"context_line":"        cfg.CONF.set_override(\"service_plugins\", [self.SERVICE_PLUGIN_NAME])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        mgr \u003d manager.NeutronManager.get_instance()"},{"line_number":50,"context_line":"        self.qos_plugin \u003d mgr.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_c526b915","line":47,"updated":"2016-03-29 12:22:58.000000000","message":"Does it mean you want to have some other service plugin name for other plugins? I think it\u0027s twisted and breaks official docs on how to enable the feature. Instead, other plugins should provide their own notification driver to differentiate.","commit_id":"c00a7195e32517f113f89b4e52c3b7ad139d5159"}]}
