)]}'
{"neutron/db/l3_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a652ef6abff98f625c389c25121fdcad93b0adea","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                models_v2.IPAllocation.subnet_id \u003d\u003d internal_subnet_id)"},{"line_number":894,"context_line":"            .join(gw_port, gw_port.device_id \u003d\u003d RouterPort.router_id)"},{"line_number":895,"context_line":"            .filter(gw_port.network_id \u003d\u003d external_network_id)"},{"line_number":896,"context_line":"            .distinct())"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        first_router_id \u003d None"},{"line_number":899,"context_line":"        for router_id, interface_ip in routerport_qry:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_b5d6d44c","line":896,"updated":"2016-03-17 20:42:00.000000000","message":"I think if we want to make this look like all the other queries in this file it should be like:\n\nquery \u003d context.session.query(...)\nquery \u003d query.join(...)\nquery \u003d query.filter(...)\nquery \u003d query.join(...)\nquery \u003d query.filter(...)\nquery \u003d query.distinct()\n\n_notify_subnetpool_address_scope_update() is an example\n\nUnless there is some reason we need this in a single () ?","commit_id":"69c73d0be2c90682b6c700b8fe877b8d8e462d67"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a1abd5a7dcb31d20c77017d3f33a7eb51f75c3a2","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                models_v2.IPAllocation.subnet_id \u003d\u003d internal_subnet_id)"},{"line_number":894,"context_line":"            .join(gw_port, gw_port.device_id \u003d\u003d RouterPort.router_id)"},{"line_number":895,"context_line":"            .filter(gw_port.network_id \u003d\u003d external_network_id)"},{"line_number":896,"context_line":"            .distinct())"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        first_router_id \u003d None"},{"line_number":899,"context_line":"        for router_id, interface_ip in routerport_qry:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_15b35199","line":896,"in_reply_to":"1af94dfe_b5d6d44c","updated":"2016-03-31 03:04:04.000000000","message":"Brian,\ndo you want me to make your suggested style change in this commit?\ni prefer to make this minimum because this is a merely preparation for the following fix.","commit_id":"69c73d0be2c90682b6c700b8fe877b8d8e462d67"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e58e14855ad1c21007cec916a221b14202e72ff5","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                models_v2.IPAllocation.subnet_id \u003d\u003d internal_subnet_id)"},{"line_number":894,"context_line":"            .join(gw_port, gw_port.device_id \u003d\u003d RouterPort.router_id)"},{"line_number":895,"context_line":"            .filter(gw_port.network_id \u003d\u003d external_network_id)"},{"line_number":896,"context_line":"            .distinct())"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        first_router_id \u003d None"},{"line_number":899,"context_line":"        for router_id, interface_ip in routerport_qry:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_47019869","line":896,"in_reply_to":"1af94dfe_b5d6d44c","updated":"2016-03-18 06:54:53.000000000","message":"i don\u0027t have a strong preference either ways.","commit_id":"69c73d0be2c90682b6c700b8fe877b8d8e462d67"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2f7f9bde7211ee884860dc2dab91c6013f7893ed","unresolved":false,"context_lines":[{"line_number":893,"context_line":"                models_v2.IPAllocation.subnet_id \u003d\u003d internal_subnet_id)"},{"line_number":894,"context_line":"            .join(gw_port, gw_port.device_id \u003d\u003d RouterPort.router_id)"},{"line_number":895,"context_line":"            .filter(gw_port.network_id \u003d\u003d external_network_id)"},{"line_number":896,"context_line":"            .distinct())"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        first_router_id \u003d None"},{"line_number":899,"context_line":"        for router_id, interface_ip in routerport_qry:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_bc1b5bc9","line":896,"in_reply_to":"ba0121b8_15b35199","updated":"2016-03-31 12:57:40.000000000","message":"Yes, I guess I\u0027d vote for them all being the same.","commit_id":"69c73d0be2c90682b6c700b8fe877b8d8e462d67"}]}
