)]}'
{"neutron/agent/windows/polling.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a9f84763130f2d5bf7bdaccce1b2f0095cdb2d7d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class InterfacePollingMinimizer():"},{"line_number":28,"context_line":"\tpass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afc51ec_db7dd36f","line":28,"updated":"2016-03-14 15:18:26.000000000","message":"tab!","commit_id":"38d74c9d09cd5332a010b6e267c9ffc1a0e75267"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aa5e7586f2da70eebf7ae63fa57e8303f1bb74d5","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                # no action and by InterfacePollingMinimizer as start/stop"},{"line_number":1914,"context_line":"                if isinstance("},{"line_number":1915,"context_line":"                    polling_manager, polling.InterfacePollingMinimizer):"},{"line_number":1916,"context_line":"                    polling_manager.stop()"},{"line_number":1917,"context_line":"                    polling_manager.start()"},{"line_number":1918,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1919,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_9bdeab0f","line":1916,"updated":"2016-03-14 15:24:26.000000000","message":"Won\u0027t this line crash with AttributeError since you don\u0027t have those methods (start, stop) on your fake manager?","commit_id":"bc18895416b3ebe5205e2fbff52a0549c1ce489e"},{"author":{"_account_id":12604,"name":"Adelina Tuvenie","email":"atuvenie@cloudbasesolutions.com","username":"atuvenie"},"change_message_id":"855cc9e0419c631e1c48cddff920c17ad3b80c53","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                # no action and by InterfacePollingMinimizer as start/stop"},{"line_number":1914,"context_line":"                if isinstance("},{"line_number":1915,"context_line":"                    polling_manager, polling.InterfacePollingMinimizer):"},{"line_number":1916,"context_line":"                    polling_manager.stop()"},{"line_number":1917,"context_line":"                    polling_manager.start()"},{"line_number":1918,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1919,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_fe851dad","line":1916,"in_reply_to":"3afc51ec_5be703b0","updated":"2016-03-14 15:43:31.000000000","message":"Correct, this code will never be executed on Windows. get_polling_manager will return AlwaysPoll for Windows every time.","commit_id":"bc18895416b3ebe5205e2fbff52a0549c1ce489e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8b0ad0eb4fdfe7b94e82586ef4ccded5b5717b59","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                # no action and by InterfacePollingMinimizer as start/stop"},{"line_number":1914,"context_line":"                if isinstance("},{"line_number":1915,"context_line":"                    polling_manager, polling.InterfacePollingMinimizer):"},{"line_number":1916,"context_line":"                    polling_manager.stop()"},{"line_number":1917,"context_line":"                    polling_manager.start()"},{"line_number":1918,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1919,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_be16f552","line":1916,"in_reply_to":"3afc51ec_5be703b0","updated":"2016-03-14 15:45:51.000000000","message":"OK, it indeed won\u0027t trigger because for win32 we use base polling manager that does not inherit from the fake class.\n\nBut honestly, that kind of hackaround is hard to grasp to say the least. At least, that could use some comments to explain that, at least where the fake manager is defined.","commit_id":"bc18895416b3ebe5205e2fbff52a0549c1ce489e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6e87dc9e362e2d32d4b5c27078dcbb78ccd241ae","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                # no action and by InterfacePollingMinimizer as start/stop"},{"line_number":1914,"context_line":"                if isinstance("},{"line_number":1915,"context_line":"                    polling_manager, polling.InterfacePollingMinimizer):"},{"line_number":1916,"context_line":"                    polling_manager.stop()"},{"line_number":1917,"context_line":"                    polling_manager.start()"},{"line_number":1918,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1919,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_5be703b0","line":1916,"in_reply_to":"3afc51ec_9bdeab0f","updated":"2016-03-14 15:28:20.000000000","message":"you won\u0027t get here, I think because the isinstance would be false. That\u0027s how I read it anyway.","commit_id":"bc18895416b3ebe5205e2fbff52a0549c1ce489e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1b1cbdae42a3f26f2bc5abf054c1d95047fd8e0c","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                # no action and by InterfacePollingMinimizer as start/stop"},{"line_number":1914,"context_line":"                if isinstance("},{"line_number":1915,"context_line":"                    polling_manager, polling.InterfacePollingMinimizer):"},{"line_number":1916,"context_line":"                    polling_manager.stop()"},{"line_number":1917,"context_line":"                    polling_manager.start()"},{"line_number":1918,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1919,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_e110e003","line":1916,"in_reply_to":"3afc51ec_be16f552","updated":"2016-03-14 15:49:53.000000000","message":"to be fair, I agree with Ihar that this conditional defeats the point of inheritance, but I figure I\u0027d unblock this patch fast. That said, it\u0027d be probably best if we had a contract that any manager implement (even if with a no-op?","commit_id":"bc18895416b3ebe5205e2fbff52a0549c1ce489e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"cefe1a3ec86f41ca863b4970546d2bfde600648a","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                # no action and by InterfacePollingMinimizer as start/stop"},{"line_number":1914,"context_line":"                if isinstance("},{"line_number":1915,"context_line":"                    polling_manager, polling.InterfacePollingMinimizer):"},{"line_number":1916,"context_line":"                    polling_manager.stop()"},{"line_number":1917,"context_line":"                    polling_manager.start()"},{"line_number":1918,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1919,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_8290f744","line":1916,"in_reply_to":"3afc51ec_e110e003","updated":"2016-03-14 17:21:38.000000000","message":"I am ok with unblocking win32 folks. But can we at least add a TODO in win32 fake manager that would suggest where we want to see the code in the future? [\u003dcontract].","commit_id":"bc18895416b3ebe5205e2fbff52a0549c1ce489e"},{"author":{"_account_id":12604,"name":"Adelina Tuvenie","email":"atuvenie@cloudbasesolutions.com","username":"atuvenie"},"change_message_id":"aa60baaff685827c08d9c9329cb3fe93a79640ae","unresolved":false,"context_lines":[{"line_number":1913,"context_line":"                # no action and by InterfacePollingMinimizer as start/stop"},{"line_number":1914,"context_line":"                if isinstance("},{"line_number":1915,"context_line":"                    polling_manager, polling.InterfacePollingMinimizer):"},{"line_number":1916,"context_line":"                    polling_manager.stop()"},{"line_number":1917,"context_line":"                    polling_manager.start()"},{"line_number":1918,"context_line":"            elif ovs_status \u003d\u003d constants.OVS_DEAD:"},{"line_number":1919,"context_line":"                # Agent doesn\u0027t apply any operations when ovs is dead, to"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afc51ec_7e358df5","line":1916,"in_reply_to":"3afc51ec_fe851dad","updated":"2016-03-14 15:45:40.000000000","message":"Polling for windows side \nhttps://github.com/openstack/neutron/blob/master/neutron/agent/windows/polling.py","commit_id":"bc18895416b3ebe5205e2fbff52a0549c1ce489e"}]}