)]}'
{"neutron/common/utils.py":[{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"e1c8c29c9fc8ce97c2dfb71530f1723646a84e8a","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                                                           dep_id_attr):"},{"line_number":627,"context_line":"                        ctx.reraise \u003d False"},{"line_number":628,"context_line":"                        continue"},{"line_number":629,"context_line":"                # we have exceeded retries or have encountered a non-dependency"},{"line_number":630,"context_line":"                # related failure so we try to clean up the dependency if we"},{"line_number":631,"context_line":"                # created it before re-raising"},{"line_number":632,"context_line":"                if made_locally and dependency:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a1b2928_8e818f4d","line":629,"updated":"2016-04-11 14:35:37.000000000","message":"What if we created duplicate HA network, but creating HA network ports were successful.  In this case we might not be deleting duplicate HA network created by us.","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"0a361400ca663cc7c93d5ce2a2bfc237e4d8a4f4","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                                                           dep_id_attr):"},{"line_number":627,"context_line":"                        ctx.reraise \u003d False"},{"line_number":628,"context_line":"                        continue"},{"line_number":629,"context_line":"                # we have exceeded retries or have encountered a non-dependency"},{"line_number":630,"context_line":"                # related failure so we try to clean up the dependency if we"},{"line_number":631,"context_line":"                # created it before re-raising"},{"line_number":632,"context_line":"                if made_locally and dependency:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_ec1c9d79","line":629,"in_reply_to":"5a18252c_460c9294","updated":"2016-04-12 09:48:50.000000000","message":"you are correct. I missed https://github.com/openstack/neutron/blob/master/neutron/db/common_db_mixin.py#L71","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2bd6fb633d9658f1e382e58e1410ee7a7dece958","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                                                           dep_id_attr):"},{"line_number":627,"context_line":"                        ctx.reraise \u003d False"},{"line_number":628,"context_line":"                        continue"},{"line_number":629,"context_line":"                # we have exceeded retries or have encountered a non-dependency"},{"line_number":630,"context_line":"                # related failure so we try to clean up the dependency if we"},{"line_number":631,"context_line":"                # created it before re-raising"},{"line_number":632,"context_line":"                if made_locally and dependency:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_460c9294","line":629,"in_reply_to":"5a18252c_c1089594","updated":"2016-04-12 09:06:35.000000000","message":"If all of those succeeded, we wouldn\u0027t be in this code block. This is for handling exceptions.","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"3e12aa791f5a6420461c60e4078b89178ab0b2e8","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                                                           dep_id_attr):"},{"line_number":627,"context_line":"                        ctx.reraise \u003d False"},{"line_number":628,"context_line":"                        continue"},{"line_number":629,"context_line":"                # we have exceeded retries or have encountered a non-dependency"},{"line_number":630,"context_line":"                # related failure so we try to clean up the dependency if we"},{"line_number":631,"context_line":"                # created it before re-raising"},{"line_number":632,"context_line":"                if made_locally and dependency:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_c1089594","line":629,"in_reply_to":"5a18252c_f8574dc8","updated":"2016-04-12 04:30:02.000000000","message":"Yes. What I am saying is below scenario,\nboth \"made_locally\" and \"dependency\" are True and \"creator\" at Line 617 executed succesfuly without exception(i.e L618).\nIn this case, you are not deleting the HA network which is created locally.","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"df75399fc70ccb3979abff86b55184a685add2e4","unresolved":false,"context_lines":[{"line_number":626,"context_line":"                                                           dep_id_attr):"},{"line_number":627,"context_line":"                        ctx.reraise \u003d False"},{"line_number":628,"context_line":"                        continue"},{"line_number":629,"context_line":"                # we have exceeded retries or have encountered a non-dependency"},{"line_number":630,"context_line":"                # related failure so we try to clean up the dependency if we"},{"line_number":631,"context_line":"                # created it before re-raising"},{"line_number":632,"context_line":"                if made_locally and dependency:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_f8574dc8","line":629,"in_reply_to":"7a1b2928_8e818f4d","updated":"2016-04-11 21:29:23.000000000","message":"This function only deletes networks created locally. \"if made_locally\" ensures that. It also says that right in the comment here...","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"48dcbb2530da6b0214f55b92667aa19d52d4516c","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                    try:"},{"line_number":634,"context_line":"                        dep_deleter(dependency)"},{"line_number":635,"context_line":"                    except Exception:"},{"line_number":636,"context_line":"                        LOG.exception(_LE(\"Failed cleaning up dependency %s\"),"},{"line_number":637,"context_line":"                                      dep_id)"},{"line_number":638,"context_line":"    return result, dependency"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_1c026b0b","line":636,"range":{"start_line":636,"start_character":42,"end_line":636,"end_character":76},"updated":"2016-04-14 10:37:41.000000000","message":"This shouldn\u0027t happen quite often, but when it does we\u0027re gonna regret not printing the original exception. Can we add at least a repr(e) to the printout?","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"be2c5c88b5b428f30d4de62e0f5ae9f028b28c2d","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                    try:"},{"line_number":634,"context_line":"                        dep_deleter(dependency)"},{"line_number":635,"context_line":"                    except Exception:"},{"line_number":636,"context_line":"                        LOG.exception(_LE(\"Failed cleaning up dependency %s\"),"},{"line_number":637,"context_line":"                                      dep_id)"},{"line_number":638,"context_line":"    return result, dependency"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_ea668aeb","line":636,"range":{"start_line":636,"start_character":42,"end_line":636,"end_character":76},"in_reply_to":"1a122d0e_b798c0c1","updated":"2016-04-20 14:08:01.000000000","message":":O awesome!","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ef03330c86aef7a72b19154505ed2b81194616b8","unresolved":false,"context_lines":[{"line_number":633,"context_line":"                    try:"},{"line_number":634,"context_line":"                        dep_deleter(dependency)"},{"line_number":635,"context_line":"                    except Exception:"},{"line_number":636,"context_line":"                        LOG.exception(_LE(\"Failed cleaning up dependency %s\"),"},{"line_number":637,"context_line":"                                      dep_id)"},{"line_number":638,"context_line":"    return result, dependency"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_b798c0c1","line":636,"range":{"start_line":636,"start_character":42,"end_line":636,"end_character":76},"in_reply_to":"5a18252c_1c026b0b","updated":"2016-04-19 12:24:36.000000000","message":"LOG.exception prints the exception for you all for the same price! :)","commit_id":"3e28b5abafb317f318cc4ac46c4fcb11d31fb2f6"}]}