)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f7ed390d2633ed388894c006cdcc0307e3933b4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladimir Eremin \u003cveremin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-17 21:21:21 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to use several nics for physnet with SRIOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Accordind specs and docs, SRIOV_NIC.physical_device_mappings is not"},{"line_number":10,"context_line":"limited to be a 1-1 mapping between physnets and NICs. However,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af94dfe_5f80548b","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":48},"updated":"2016-03-17 18:47:25.000000000","message":"s/SRIOV/SR-IOV","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"f7ed390d2633ed388894c006cdcc0307e3933b4d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to use several nics for physnet with SRIOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Accordind specs and docs, SRIOV_NIC.physical_device_mappings is not"},{"line_number":10,"context_line":"limited to be a 1-1 mapping between physnets and NICs. However,"},{"line_number":11,"context_line":"implementation requires this. This bugfix unlocks 1-M mappings, so one"},{"line_number":12,"context_line":"physnet could be managed by many NICs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* introduced neutron.utils.parse_mappings_tuple"},{"line_number":15,"context_line":"* SRIOV_NIC.physical_device_mappings is parsed as list of tuples"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af94dfe_3a1636f1","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":38},"updated":"2016-03-17 18:47:25.000000000","message":"I didn\u0027t like the physical_device_mappings implementation in the first place because the pci_passthrough_whitelist has the mapping already and I don\u0027t think we should keep duplicate config between nova-compute and the SR-IOV agent.\nwhat do you say if we deprecate physical_device_mappings and let the agent monitor the PF by deducing it form the VF PCI of the port.","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"b8f9c003527726633051c71d647d2084f8d77f05","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow to use several nics for physnet with SRIOV"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Accordind specs and docs, SRIOV_NIC.physical_device_mappings is not"},{"line_number":10,"context_line":"limited to be a 1-1 mapping between physnets and NICs. However,"},{"line_number":11,"context_line":"implementation requires this. This bugfix unlocks 1-M mappings, so one"},{"line_number":12,"context_line":"physnet could be managed by many NICs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* introduced neutron.utils.parse_mappings_tuple"},{"line_number":15,"context_line":"* SRIOV_NIC.physical_device_mappings is parsed as list of tuples"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af94dfe_95d2bd5a","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":38},"in_reply_to":"1af94dfe_3a1636f1","updated":"2016-03-17 18:58:10.000000000","message":"I didn\u0027t either. Actually, this case works before Mitaka, whether agent wasn\u0027t required.\n\nI\u0027d like to reimplement this in master, but how could I propose this fix to mitaka (because it\u0027s clearly degradation)?","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"62d92d040bd837f03d96ff1abb93955e9a04c338","unresolved":false,"context_lines":[{"line_number":14,"context_line":"* introduced neutron.utils.parse_mappings_multi"},{"line_number":15,"context_line":"* SRIOV_NIC.physical_device_mappings is parsed as dict with lists as"},{"line_number":16,"context_line":"  values"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I07b8682fdfe8389a35893cc662b87c94a00bd4a5"},{"line_number":19,"context_line":"Closes-Bug: #1558626"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa0719c6_e73d17c5","line":17,"updated":"2016-03-24 12:29:22.000000000","message":"Please add DocImpact","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"}],"neutron/common/utils.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"ef54841572718af78d597df3a5c82262b21b6237","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                            close_fds\u003dclose_fds, env\u003denv)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def parse_mappings_tuple(mapping_list):"},{"line_number":218,"context_line":"    \"\"\"Parse a list of mapping strings into a list of tuples."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    :param mapping_list: a list of strings of the form \u0027\u003ckey\u003e:\u003cvalue\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_86a8dd8e","line":217,"updated":"2016-03-17 17:26:49.000000000","message":"You should have not overwritten this function - we lose history and Git Blame will be confusing to read. Please introduce the new function below this.","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"e71501d685fae64e2865ea4bfc18e594dddf3a14","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                            close_fds\u003dclose_fds, env\u003denv)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"def parse_mappings_tuple(mapping_list):"},{"line_number":218,"context_line":"    \"\"\"Parse a list of mapping strings into a list of tuples."},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    :param mapping_list: a list of strings of the form \u0027\u003ckey\u003e:\u003cvalue\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_46f89549","line":217,"in_reply_to":"1af94dfe_86a8dd8e","updated":"2016-03-17 17:33:28.000000000","message":"Done","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1a2f3ed207f6e529fbea1001cfd23fe7d60b5351","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        if not value:"},{"line_number":236,"context_line":"            raise ValueError(_(\"Missing value in mapping: \u0027%s\u0027\") % mapping)"},{"line_number":237,"context_line":"        mappings.append((key, value))"},{"line_number":238,"context_line":"    return mappings"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def parse_mappings(mapping_list, unique_values\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_06020d3d","line":238,"updated":"2016-03-17 17:35:40.000000000","message":"I actually don\u0027t understand the need to change the return value to a list of tuples instead of the dictionary. Vladimir, what is your reasoning here?","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"24a094b2b0e1c0c56f359afa10b6b84060be661c","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        if not value:"},{"line_number":236,"context_line":"            raise ValueError(_(\"Missing value in mapping: \u0027%s\u0027\") % mapping)"},{"line_number":237,"context_line":"        mappings.append((key, value))"},{"line_number":238,"context_line":"    return mappings"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"def parse_mappings(mapping_list, unique_values\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_6902c2b5","line":238,"in_reply_to":"1af94dfe_06020d3d","updated":"2016-03-17 17:43:32.000000000","message":"To enable 1-M mapping between physnets and NICs (to use many NICs for one physnet) I need to hanlde mapping like this:\n\n    physnet2:eth0,physnet2:eth1\n\nOriginal parse_mappings limits this, because of key duplication. I\u0027ve introduced new parser for this. And, as Sean notices, to make this more readable, I\u0027ll make parse_mappings_tuple from scratch instead of overwritting.","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    return mappings"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def parse_mappings_multi(mapping_list):"},{"line_number":250,"context_line":"    \"\"\"Parse a list of mapping strings into a dictionary."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    :param mapping_list: a list of strings of the form \u0027\u003ckey\u003e:\u003cvalue\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_a3d545ba","line":249,"updated":"2016-03-30 11:20:58.000000000","message":"I find this function wasteful. Can we instead extend the function above to allow for your use case?","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f00a28d292224fff623df71bb3711eac53c5d4cd","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    return mappings"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def parse_mappings_multi(mapping_list):"},{"line_number":250,"context_line":"    \"\"\"Parse a list of mapping strings into a dictionary."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    :param mapping_list: a list of strings of the form \u0027\u003ckey\u003e:\u003cvalue\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_83af5293","line":249,"in_reply_to":"ba0121b8_32c1792f","updated":"2016-03-30 13:19:25.000000000","message":"OK, but at least the common code should be reused, not copy pasted.","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"5bf64a9effa470f4c6df856c0eec018e5540d3f1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    return mappings"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def parse_mappings_multi(mapping_list):"},{"line_number":250,"context_line":"    \"\"\"Parse a list of mapping strings into a dictionary."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    :param mapping_list: a list of strings of the form \u0027\u003ckey\u003e:\u003cvalue\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_7572b1ae","line":249,"in_reply_to":"ba0121b8_83af5293","updated":"2016-03-30 13:28:55.000000000","message":"There was main concern from other reviewers:\n\u003e You should have not overwritten this function - we lose history and Git Blame will be confusing to read. Please introduce the new function below this.\n\nThats why I skip reusing. Please take a look on https://review.openstack.org/#/c/294188/1/neutron/common/utils.py@217","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"164d0d87997162f7ad6f50f994524b979a442d41","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    return mappings"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def parse_mappings_multi(mapping_list):"},{"line_number":250,"context_line":"    \"\"\"Parse a list of mapping strings into a dictionary."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    :param mapping_list: a list of strings of the form \u0027\u003ckey\u003e:\u003cvalue\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_32c1792f","line":249,"in_reply_to":"ba0121b8_a3d545ba","updated":"2016-03-30 12:01:23.000000000","message":"When I decided to extend it, everybody on this review said it was wrong, and I should make new one.","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"14b1a6daceb3f4a7ce5beb65603f6f7909d29ff7","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    :param unique_values: values must be unique if True"},{"line_number":222,"context_line":"    :param unique_keys: keys must be unique if True, else implies that keys"},{"line_number":223,"context_line":"    and values are not unique"},{"line_number":224,"context_line":"    :returns: a dict mapping keys to values or list of values"},{"line_number":225,"context_line":"    \"\"\""},{"line_number":226,"context_line":"    mappings \u003d {}"},{"line_number":227,"context_line":"    for mapping in mapping_list:"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba0121b8_0b4d186c","line":224,"range":{"start_line":224,"start_character":44,"end_line":224,"end_character":61},"updated":"2016-03-30 14:00:37.000000000","message":"nit: or to a list of values","commit_id":"586723563d35e12c867f0a461fd19e4f192c164a"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/eswitch_manager.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"c1598832dffee14cebb00f6757a4570f652429cb","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        if exclude_devices is None:"},{"line_number":342,"context_line":"            exclude_devices \u003d {}"},{"line_number":343,"context_line":"        for phys_net, dev_name in device_mappings:"},{"line_number":344,"context_line":"            self._create_emb_switch(phys_net, dev_name,"},{"line_number":345,"context_line":"                                    exclude_devices.get(dev_name, set()))"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_e6ae0180","line":343,"updated":"2016-03-17 17:28:07.000000000","message":"why did you remove this? This is needed for py3k compat","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"e71501d685fae64e2865ea4bfc18e594dddf3a14","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        \"\"\""},{"line_number":341,"context_line":"        if exclude_devices is None:"},{"line_number":342,"context_line":"            exclude_devices \u003d {}"},{"line_number":343,"context_line":"        for phys_net, dev_name in device_mappings:"},{"line_number":344,"context_line":"            self._create_emb_switch(phys_net, dev_name,"},{"line_number":345,"context_line":"                                    exclude_devices.get(dev_name, set()))"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_a6f07968","line":343,"in_reply_to":"1af94dfe_e6ae0180","updated":"2016-03-17 17:33:28.000000000","message":"Since I\u0027ve changed format for SRIOV_NIC.physical_device_mappings, it\u0027s no more dict, but list of tuples, so we don\u0027t need for six.iteritems.","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"63bdf6308c82bbfb5d44db34d03e5a8e1259b0c1","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                    self.ext_manager.delete_port(self.context, port)"},{"line_number":327,"context_line":"                else:"},{"line_number":328,"context_line":"                    LOG.warning(_LW(\"port_id to device with MAC \""},{"line_number":329,"context_line":"                                 \"%s not found\"), mac)"},{"line_number":330,"context_line":"                dev_details \u003d self.plugin_rpc.update_device_down(self.context,"},{"line_number":331,"context_line":"                                                                 mac,"},{"line_number":332,"context_line":"                                                                 self.agent_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_46c0952a","line":329,"updated":"2016-03-17 17:28:55.000000000","message":"this appears unrelated.","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"e71501d685fae64e2865ea4bfc18e594dddf3a14","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                    self.ext_manager.delete_port(self.context, port)"},{"line_number":327,"context_line":"                else:"},{"line_number":328,"context_line":"                    LOG.warning(_LW(\"port_id to device with MAC \""},{"line_number":329,"context_line":"                                 \"%s not found\"), mac)"},{"line_number":330,"context_line":"                dev_details \u003d self.plugin_rpc.update_device_down(self.context,"},{"line_number":331,"context_line":"                                                                 mac,"},{"line_number":332,"context_line":"                                                                 self.agent_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_c6a2e54a","line":329,"in_reply_to":"1af94dfe_46c0952a","updated":"2016-03-17 17:33:28.000000000","message":"Done","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"28ec4bbe22ce00724b9168fb4016791282962ae1","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        Validate that network_device in excluded_device"},{"line_number":420,"context_line":"        exists in device mappings"},{"line_number":421,"context_line":"        \"\"\""},{"line_number":422,"context_line":"        dev_net_set \u003d set(map(lambda i: i[1], self.device_mappings))"},{"line_number":423,"context_line":"        for dev_name in self.exclude_devices.keys():"},{"line_number":424,"context_line":"            if dev_name not in dev_net_set:"},{"line_number":425,"context_line":"                raise ValueError(_(\"Device name %(dev_name)s is missing from \""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_494a66ad","line":422,"updated":"2016-03-17 17:51:40.000000000","message":"I\u0027m really not crazy about code like this, where we just pick an element out of the tuple. What is at position 1 in this tuple?","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"a0c71b57619a98762fe5090c36b4b9aefbff65fe","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        Parse and validate the consistency in both mappings"},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        self.device_mappings \u003d n_utils.parse_mappings_multi("},{"line_number":412,"context_line":"            cfg.CONF.SRIOV_NIC.physical_device_mappings)"},{"line_number":413,"context_line":"        self.exclude_devices \u003d config.parse_exclude_devices("},{"line_number":414,"context_line":"            cfg.CONF.SRIOV_NIC.exclude_devices)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_5f769406","line":411,"updated":"2016-03-17 18:27:42.000000000","message":"So what happens to old style configuration mappings? In all this code you are directly replacing calls to parse_mappings with this new function - is it backwards compatible?","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"a0a278d7ece018422241aded62a73b46a283bd36","unresolved":false,"context_lines":[{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        Parse and validate the consistency in both mappings"},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        self.device_mappings \u003d n_utils.parse_mappings_multi("},{"line_number":412,"context_line":"            cfg.CONF.SRIOV_NIC.physical_device_mappings)"},{"line_number":413,"context_line":"        self.exclude_devices \u003d config.parse_exclude_devices("},{"line_number":414,"context_line":"            cfg.CONF.SRIOV_NIC.exclude_devices)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1af94dfe_ba9c065e","line":411,"in_reply_to":"1af94dfe_5f769406","updated":"2016-03-17 18:44:34.000000000","message":"Backward compatible.","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"}],"neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"28ec4bbe22ce00724b9168fb4016791282962ae1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                LOG.debug(\"Checking segment: %(segment)s \""},{"line_number":158,"context_line":"                          \"for mappings: %(mappings)s \","},{"line_number":159,"context_line":"                          {\u0027segment\u0027: segment, \u0027mappings\u0027: mappings})"},{"line_number":160,"context_line":"                return segment[api.PHYSICAL_NETWORK] in set(map(lambda i: i[0], mappings))"},{"line_number":161,"context_line":"            return True"},{"line_number":162,"context_line":"        return False"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_694da2c3","line":160,"updated":"2016-03-17 17:51:40.000000000","message":"Ditto on this - picking the 0th item out of the tuple. It\u0027s not clear.","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1a2f3ed207f6e529fbea1001cfd23fe7d60b5351","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                LOG.debug(\"Checking segment: %(segment)s \""},{"line_number":158,"context_line":"                          \"for mappings: %(mappings)s \","},{"line_number":159,"context_line":"                          {\u0027segment\u0027: segment, \u0027mappings\u0027: mappings})"},{"line_number":160,"context_line":"                return segment[api.PHYSICAL_NETWORK] in set(map(lambda i: i[0], mappings))"},{"line_number":161,"context_line":"            return True"},{"line_number":162,"context_line":"        return False"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_e6428167","line":160,"updated":"2016-03-17 17:35:40.000000000","message":"These changes were not necessary. The mappings dict keys were the physical network identifiers already.","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"24a094b2b0e1c0c56f359afa10b6b84060be661c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                LOG.debug(\"Checking segment: %(segment)s \""},{"line_number":158,"context_line":"                          \"for mappings: %(mappings)s \","},{"line_number":159,"context_line":"                          {\u0027segment\u0027: segment, \u0027mappings\u0027: mappings})"},{"line_number":160,"context_line":"                return segment[api.PHYSICAL_NETWORK] in set(map(lambda i: i[0], mappings))"},{"line_number":161,"context_line":"            return True"},{"line_number":162,"context_line":"        return False"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_c9e036fd","line":160,"in_reply_to":"1af94dfe_e6428167","updated":"2016-03-17 17:43:32.000000000","message":"As I\u0027ve changed the format in agent, mappings here now a list of tuples, like\n\n    [ [\u0027physnet2\u0027, \u0027eth1\u0027], [\u0027physnet2\u0027, \u0027eth2\u0027] ]","commit_id":"b5375f5f69b76eafbf678d4c2e903e5aa9e3f38b"}],"releasenotes/notes/sriov_allow_use_many_nics_for_one_physnet-3570aa67a60ce6c4.yaml":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"3b6795013a59df69b4036089d7e8b2badf51a528","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Allows 1-M mappings between physnet and NICs for"},{"line_number":4,"context_line":"    SR-IOV agent."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af94dfe_9fdf7c0c","line":4,"updated":"2016-03-17 18:23:49.000000000","message":"This needs to document *how* you can create these mappings. Examples please.","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"},{"author":{"_account_id":11708,"name":"Atsuko Ito","email":"me@yottatsa.name","username":"yottatsa"},"change_message_id":"489fa3f616076aef13915173acc81083eefedf62","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Allows 1-M mappings between physnet and NICs for"},{"line_number":4,"context_line":"    SR-IOV agent."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af94dfe_ff25e008","line":4,"in_reply_to":"1af94dfe_9fdf7c0c","updated":"2016-03-17 18:26:51.000000000","message":"Nothing changes from 1-1 mapping. Just physnet:nic list, as documented. Doc. string for option is still consistent.","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"91b192f5503dafabcfb690b565198a7823e8b117","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Allows 1-M mappings between physnet and NICs for"},{"line_number":4,"context_line":"    SR-IOV agent."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1af94dfe_5fe4d4aa","line":4,"in_reply_to":"1af94dfe_ff25e008","updated":"2016-03-17 18:28:28.000000000","message":"Right, but how do operators use the 1-M mapping? They\u0027re going to reading this release note looking for *how* to do it.","commit_id":"67d71f948d5662fb0a7c7a987b04538f3b8eff1b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Several nics for physnet could be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_264663bf","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":14},"updated":"2016-03-30 11:20:58.000000000","message":"NICs","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Several nics for physnet could be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_c60de791","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":32},"updated":"2016-03-30 11:20:58.000000000","message":"can","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Several nics for physnet could be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_8613efb7","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":26},"updated":"2016-03-30 11:20:58.000000000","message":"per physical network","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Several nics for physnet could be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"},{"line_number":7,"context_line":"    enp1s0f0 and enp1s0f1, \u0027physnet2:enp1s0f0,physnet2:enp1s0f1\u0027 will be valid"},{"line_number":8,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_a6eb93af","line":5,"range":{"start_line":5,"start_character":66,"end_line":5,"end_character":71},"updated":"2016-03-30 11:20:58.000000000","message":"can","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  Several nics for physnet could be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"},{"line_number":7,"context_line":"    enp1s0f0 and enp1s0f1, \u0027physnet2:enp1s0f0,physnet2:enp1s0f1\u0027 will be valid"},{"line_number":8,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_8605af7b","line":6,"range":{"start_line":6,"start_character":18,"end_line":6,"end_character":21},"updated":"2016-03-30 11:20:58.000000000","message":"NIC","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  Several nics for physnet could be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"},{"line_number":7,"context_line":"    enp1s0f0 and enp1s0f1, \u0027physnet2:enp1s0f0,physnet2:enp1s0f1\u0027 will be valid"},{"line_number":8,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_862c8f03","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":33},"updated":"2016-03-30 11:20:58.000000000","message":"per physical network","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"62d92d040bd837f03d96ff1abb93955e9a04c338","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  Several nics for physnet could be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"},{"line_number":7,"context_line":"    enp1s0f0 and enp1s0f1, \u0027physnet2:enp1s0f0,physnet2:enp1s0f1\u0027 will be valid"},{"line_number":8,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa0719c6_e716b74a","line":6,"range":{"start_line":6,"start_character":65,"end_line":6,"end_character":73},"updated":"2016-03-24 12:29:22.000000000","message":"typo","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"64e939ceb0150a5bbda070c0f18e779a5e9bea87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now could accept"},{"line_number":6,"context_line":"    more than one nic for physnet. For example, if \u0027physnet2\u0027 is conneted to"},{"line_number":7,"context_line":"    enp1s0f0 and enp1s0f1, \u0027physnet2:enp1s0f0,physnet2:enp1s0f1\u0027 will be valid"},{"line_number":8,"context_line":"    option."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_464b97c9","line":7,"range":{"start_line":7,"start_character":70,"end_line":7,"end_character":78},"updated":"2016-03-30 11:20:58.000000000","message":"be a valid","commit_id":"ab80315d1d087a9d6d8ee952d12c955ebf0c3303"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"14b1a6daceb3f4a7ce5beb65603f6f7909d29ff7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  Several NICs per physical network can be used with SR-IOV."},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - The \u0027physical_device_mappings\u0027 of sriov_nic configuration now can accept"},{"line_number":6,"context_line":"    more than one NIC per physical network. For example, if \u0027physnet2\u0027 is "},{"line_number":7,"context_line":"    connected to enp1s0f0 and enp1s0f1, \u0027physnet2:enp1s0f0,physnet2:enp1s0f1\u0027"},{"line_number":8,"context_line":"    will be a valid option."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba0121b8_eb51c4d9","line":6,"range":{"start_line":6,"start_character":73,"end_line":6,"end_character":74},"updated":"2016-03-30 14:00:37.000000000","message":"please remove whitespace","commit_id":"586723563d35e12c867f0a461fd19e4f192c164a"}]}
