)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"12f77f1d3883bcca23d0901305fbcb0914e6e590","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Oughton \u003calex.oughton@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-18 10:42:53 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes neutron-rootwrap-xen-dom0 to properly close XenAPI sessions. Moved logout within try, except, finally."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1558721"},{"line_number":10,"context_line":"Change-Id: Ida90a970c649745c492c28c41c4a151e4d940aa6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af94dfe_717f13e0","line":7,"updated":"2016-03-18 16:00:33.000000000","message":"First line of commit message should be \u003c50 chars - can you move the further description into a new line please?\n\nSee https://wiki.openstack.org/wiki/GitCommitMessages for guidance\n\nThanks!","commit_id":"3d48de8bd5de3be7b066656e7a0f79432b43164a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6f696c6c1a7f92c480e452aa7da51d78936f95ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alex Oughton \u003calex.oughton@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-18 11:12:10 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes neutron-rootwrap-xen-dom0 to properly close XenAPI sessions."},{"line_number":8,"context_line":"Moved logout within try, finally."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Closes-Bug: 1558721"},{"line_number":11,"context_line":"Change-Id: Ida90a970c649745c492c28c41c4a151e4d940aa6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1af94dfe_0fd94357","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":33},"updated":"2016-03-18 18:03:18.000000000","message":"This commit message is still wrong. Commit message needs a space between first line and second line. In addtion, the message properly doesn\u0027t describe this patch. How about the following?\n\n\n Close XenAPI sessions in neutron-rootwrap-xen-dom0\n\n\n Neutron with XenServer properly doesn\u0027t close XenAPI sessions.\n If it creates these sessions so rapidly, the XenServer host eventually\n exceeds its maximum allowed number of connections.\n This patch adds a close process for session.","commit_id":"c10aaaee9eb7ca9d10e492a92db694e5acdaf798"}],"bin/neutron-rootwrap-xen-dom0":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a8f6aeac6669b368557629beb4270f093b4561e4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        result \u003d session.xenapi.host.call_plugin("},{"line_number":118,"context_line":"            host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":119,"context_line":"            {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":120,"context_line":"        session.xenapi.session.logout()"},{"line_number":121,"context_line":"        return json.loads(result)"},{"line_number":122,"context_line":"    except Exception as e:"},{"line_number":123,"context_line":"        traceback.print_exc()"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1af94dfe_42986bc0","line":120,"updated":"2016-03-18 03:52:09.000000000","message":"wouldn\u0027t you want to logout even in case of failures (assumed that the session was opened successfully)?","commit_id":"5e3faa9b5356fe97a744aa71582261a942be9548"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"b7c0140fc71491105ce00828c484100bb8a95622","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        result \u003d session.xenapi.host.call_plugin("},{"line_number":118,"context_line":"            host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":119,"context_line":"            {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":120,"context_line":"        session.xenapi.session.logout()"},{"line_number":121,"context_line":"        return json.loads(result)"},{"line_number":122,"context_line":"    except Exception as e:"},{"line_number":123,"context_line":"        traceback.print_exc()"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1af94dfe_a344c7b6","line":120,"in_reply_to":"1af94dfe_42986bc0","updated":"2016-03-18 10:50:09.000000000","message":"Yes; This should be in a try/catch and always log out after a successful login.","commit_id":"5e3faa9b5356fe97a744aa71582261a942be9548"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"d5d2ced904999152a04eebb9ea6cf9cd36ed15eb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        traceback.print_exc()"},{"line_number":123,"context_line":"        sys.exit(RC_XENAPI_ERROR)"},{"line_number":124,"context_line":"    finally:"},{"line_number":125,"context_line":"        session.xenapi.session.logout()"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"def main():"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1af94dfe_7131d359","line":125,"updated":"2016-03-18 15:59:22.000000000","message":"I think this is closer, but I\u0027d prefer to see:\ntry:\n  session \u003d XenAPI.session(url)\n  session.login_with_password(...)\n  try:\n    ...\n  finally:\n    session.xenapi.session.logout()\nexcept Exception:\n    traceback.print_exc()\n    sys.exit(RC_XENAPI_ERROR)","commit_id":"3d48de8bd5de3be7b066656e7a0f79432b43164a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"931984f60467ef6680c6103d823fefbd4c432ef7","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":120,"context_line":"                {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":121,"context_line":"            return json.loads(result)"},{"line_number":122,"context_line":"        finally:"},{"line_number":123,"context_line":"            session.xenapi.session.logout()"},{"line_number":124,"context_line":"    except Exception as e:"},{"line_number":125,"context_line":"        traceback.print_exc()"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1af94dfe_75437e6c","line":122,"updated":"2016-03-18 16:18:31.000000000","message":"oh the joy of python 2.4!","commit_id":"c10aaaee9eb7ca9d10e492a92db694e5acdaf798"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"d694da3019dabea1ef2dd5973cd1af9bb95577a0","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":120,"context_line":"                {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":121,"context_line":"            return json.loads(result)"},{"line_number":122,"context_line":"        finally:"},{"line_number":123,"context_line":"            session.xenapi.session.logout()"},{"line_number":124,"context_line":"    except Exception as e:"},{"line_number":125,"context_line":"        traceback.print_exc()"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1af94dfe_fb4add53","line":122,"in_reply_to":"1af94dfe_75437e6c","updated":"2016-03-18 16:35:48.000000000","message":"Indeed... Will be 2.7 in XS Dundee(!) but in this case I was also suggesting it so we don\u0027t logout if the login failed (e.g. wrong username/password) :)","commit_id":"c10aaaee9eb7ca9d10e492a92db694e5acdaf798"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"7ab01397400d15c9a0deb627ad3de751877b14ec","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":120,"context_line":"                {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":121,"context_line":"            return json.loads(result)"},{"line_number":122,"context_line":"        finally:"},{"line_number":123,"context_line":"            session.xenapi.session.logout()"},{"line_number":124,"context_line":"    except Exception as e:"},{"line_number":125,"context_line":"        traceback.print_exc()"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1af94dfe_4fb86b75","line":122,"in_reply_to":"1af94dfe_841eda09","updated":"2016-03-18 18:07:21.000000000","message":"I think I\u0027ll hold a party to celebrate.","commit_id":"c10aaaee9eb7ca9d10e492a92db694e5acdaf798"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4d88f04fbf16b265f046d758181d35660b904094","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                host, \u0027netwrap\u0027, \u0027run_command\u0027,"},{"line_number":120,"context_line":"                {\u0027cmd\u0027: json.dumps(user_args), \u0027cmd_input\u0027: json.dumps(cmd_input)})"},{"line_number":121,"context_line":"            return json.loads(result)"},{"line_number":122,"context_line":"        finally:"},{"line_number":123,"context_line":"            session.xenapi.session.logout()"},{"line_number":124,"context_line":"    except Exception as e:"},{"line_number":125,"context_line":"        traceback.print_exc()"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1af94dfe_841eda09","line":122,"in_reply_to":"1af94dfe_fb4add53","updated":"2016-03-18 17:38:10.000000000","message":"2.7!! woot?","commit_id":"c10aaaee9eb7ca9d10e492a92db694e5acdaf798"}]}
