)]}'
{"neutron/extensions/qos.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"51b6eab9f21e164555f15433be3a8630c636a4ef","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        pass"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @abc.abstractmethod"},{"line_number":250,"context_line":"    def get_policy_dscp_marking_rules(self, context, policy_id,"},{"line_number":251,"context_line":"                                      filters\u003dNone, fields\u003dNone,"},{"line_number":252,"context_line":"                                      sorts\u003dNone, limit\u003dNone,"},{"line_number":253,"context_line":"                                      marker\u003dNone, page_reverse\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_a3f2f303","side":"PARENT","line":250,"updated":"2016-04-07 15:22:08.000000000","message":"Hm, that\u0027s a problem actually. Why do we remove those methods from the abstract plugin interface?","commit_id":"34b2a762ea90a21d050cdb7d190d02f599763935"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"9cc26c1c5abea2189d832eddcf6f01653018afaa","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        pass"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    @abc.abstractmethod"},{"line_number":250,"context_line":"    def get_policy_dscp_marking_rules(self, context, policy_id,"},{"line_number":251,"context_line":"                                      filters\u003dNone, fields\u003dNone,"},{"line_number":252,"context_line":"                                      sorts\u003dNone, limit\u003dNone,"},{"line_number":253,"context_line":"                                      marker\u003dNone, page_reverse\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_37e72fad","side":"PARENT","line":250,"in_reply_to":"9a061dce_a3f2f303","updated":"2016-04-07 18:48:15.000000000","message":"Yes, I see now that these should remain.  I\u0027ll reinstate them, but generated, once Ajo and I touch bases on my qos_plugin question.  Thanks, Ihar.","commit_id":"34b2a762ea90a21d050cdb7d190d02f599763935"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ef5dbc298d351aaf3890bacaa9ad9faea3dd610c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        :type attrib: str"},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        # The rule object type to use for each incoming rule-related request."},{"line_number":203,"context_line":"        rule_objects \u003d {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,"},{"line_number":204,"context_line":"                        \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        method_patterns \u003d [r\"^create_policy_(?P\u003crule_type\u003e.*)_rule$\","}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_9e7c0e22","line":203,"updated":"2016-05-06 11:57:32.000000000","message":"This can be a constant, so you don\u0027t need to recreate the dictionary in runtime.","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"569c25de935ed3640c49fd0698a0ce81934e0b1b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        :type attrib: str"},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        # The rule object type to use for each incoming rule-related request."},{"line_number":203,"context_line":"        rule_objects \u003d {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,"},{"line_number":204,"context_line":"                        \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        method_patterns \u003d [r\"^create_policy_(?P\u003crule_type\u003e.*)_rule$\","}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_cb4ac082","line":203,"in_reply_to":"dab17558_9e7c0e22","updated":"2016-05-17 10:20:12.000000000","message":"I agree that these are in the wrong spot and should be at least class variables.  I wasn\u0027t sure whether you intended these as class variables or module globals, but I think you meant the latter given the capitalization you used below.\n\nI hesitate to make them module globals, since they won\u0027t be accessed by anything but instances of this class.  Also, module globals should be placed just below imports and so readability would be compromised.  (Plus provided they\u0027re not (immutable and therefore copied as an instance variable because) reassigned, class variables are created once, at module load time, right?)\n\nLet me know if you disagree or if my claims or assumptions are wrong.","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ef5dbc298d351aaf3890bacaa9ad9faea3dd610c","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        rule_objects \u003d {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,"},{"line_number":204,"context_line":"                        \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        method_patterns \u003d [r\"^create_policy_(?P\u003crule_type\u003e.*)_rule$\","},{"line_number":207,"context_line":"                          r\"^update_policy_(?P\u003crule_type\u003e.*)_rule$\","},{"line_number":208,"context_line":"                          r\"^delete_policy_(?P\u003crule_type\u003e.*)_rule$\","},{"line_number":209,"context_line":"                          r\"^get_policy_(?P\u003crule_type\u003e.*)_rule$\","}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_7e796a2f","line":206,"updated":"2016-05-06 11:57:32.000000000","message":"ditto about constants.","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ef5dbc298d351aaf3890bacaa9ad9faea3dd610c","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                          r\"^update_policy_(?P\u003crule_type\u003e.*)_rule$\","},{"line_number":208,"context_line":"                          r\"^delete_policy_(?P\u003crule_type\u003e.*)_rule$\","},{"line_number":209,"context_line":"                          r\"^get_policy_(?P\u003crule_type\u003e.*)_rule$\","},{"line_number":210,"context_line":"                          r\"^get_policy_(?P\u003crule_type\u003e.*)_rules$\"]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        # Find and call the proxy method that implements the requested one."},{"line_number":213,"context_line":"        for pattern in method_patterns:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_1e12deb4","line":210,"updated":"2016-05-06 11:57:32.000000000","message":"I\u0027d compile them at module load\n\nQOS_METHOD_PATTERN_REs \u003d [re.compile(\".....\"), re.compile(\"....)]\n\nlater you can use those objects by obj.match, but keep reeding (L214)","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ef5dbc298d351aaf3890bacaa9ad9faea3dd610c","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        # Find and call the proxy method that implements the requested one."},{"line_number":213,"context_line":"        for pattern in method_patterns:"},{"line_number":214,"context_line":"            match \u003d re.search(pattern, attrib)"},{"line_number":215,"context_line":"            if match:"},{"line_number":216,"context_line":"                rule_type \u003d match.group(\u0027rule_type\u0027)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_be1d92bf","line":214,"updated":"2016-05-06 11:57:32.000000000","message":"you can use .match   .search is a bit heavier on processing.","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"569c25de935ed3640c49fd0698a0ce81934e0b1b","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        # Find and call the proxy method that implements the requested one."},{"line_number":213,"context_line":"        for pattern in method_patterns:"},{"line_number":214,"context_line":"            match \u003d re.search(pattern, attrib)"},{"line_number":215,"context_line":"            if match:"},{"line_number":216,"context_line":"                rule_type \u003d match.group(\u0027rule_type\u0027)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_2b9c2bbf","line":214,"in_reply_to":"dab17558_be1d92bf","updated":"2016-05-17 10:20:12.000000000","message":"Done.","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ef5dbc298d351aaf3890bacaa9ad9faea3dd610c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            if match:"},{"line_number":216,"context_line":"                rule_type \u003d match.group(\u0027rule_type\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                if rule_type in rule_objects:"},{"line_number":219,"context_line":"                    # Extract the proxy method name. So, for instance, from"},{"line_number":220,"context_line":"                    # \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":221,"context_line":"                    # \"delete_policy_rule\"."}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_9c13765c","line":218,"updated":"2016-05-06 11:57:32.000000000","message":"you could avoid this loop by doing:\n\u003e\u003e\u003e QOS_METHOD_PATTERN_RE \u003d re.compile(r\"^((?P\u003caction\u003e(create|update|delete|get))_policy_(?P\u003crule_type\u003e.*)_(?P\u003crules\u003e(rules|rule)))$\")\n\u003e\u003e\u003e res \u003d QOS_METHOD_PATTERN_RE.match(\"create_policy_dscp_mark_rule\")\n\u003e\u003e\u003e res.group(\u0027action\u0027)\n\u0027create\u0027\n\u003e\u003e\u003e res.group(\u0027rule_type\u0027)\n\u0027dscp_mark\u0027\n\u003e\u003e\u003e res.group(\u0027rules\u0027)\n\u0027rule\u0027\n\nYou may need to take care programatically of not allowing \"rules\" with other thing than \"get\".","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ef5dbc298d351aaf3890bacaa9ad9faea3dd610c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            if match:"},{"line_number":216,"context_line":"                rule_type \u003d match.group(\u0027rule_type\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                if rule_type in rule_objects:"},{"line_number":219,"context_line":"                    # Extract the proxy method name. So, for instance, from"},{"line_number":220,"context_line":"                    # \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":221,"context_line":"                    # \"delete_policy_rule\"."}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_4187670f","line":218,"updated":"2016-05-06 11:57:32.000000000","message":"you could even simplify your code if you do:\n\n   QOS_METHOD_PATTERN_RE \u003d re.compile(\n      r\"^((?P\u003caction\u003e(create|update|delete|get))_policy_(?P\u003crule_type\u003e.*)_(?P\u003crules\u003e(rules|rule)))$\")\n\u003e\u003e\u003e res \u003d QOS_METHOD_PATTERN_RE.match(\"create_policy_dscp_mark_rule\")\n\u003c_sre.SRE_Match object at 0x7fbcf1cb8be8\u003e\n\u003e\u003e\u003e res.group(\u0027action\u0027)\n\u0027create\u0027\n\u003e\u003e\u003e res.group(\u0027rule_type\u0027)\n\u0027dscp_mark\u0027\n\u003e\u003e\u003e res.group(\u0027rules\u0027)\n\u0027rule\u0027\n\nThen you also have to handle that \"rules\" is only allowed for get.","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"569c25de935ed3640c49fd0698a0ce81934e0b1b","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            if match:"},{"line_number":216,"context_line":"                rule_type \u003d match.group(\u0027rule_type\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                if rule_type in rule_objects:"},{"line_number":219,"context_line":"                    # Extract the proxy method name. So, for instance, from"},{"line_number":220,"context_line":"                    # \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":221,"context_line":"                    # \"delete_policy_rule\"."}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_2bbb8be6","line":218,"in_reply_to":"dab17558_9c13765c","updated":"2016-05-17 10:20:12.000000000","message":"This is great.\n\nI ended up using two patterns in order to avoid any confusion that less dedicated readers might experience in having a pattern (a promise) that is later followed by an exception (a reneging :) ).","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ef5dbc298d351aaf3890bacaa9ad9faea3dd610c","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                    # Extract the proxy method name. So, for instance, from"},{"line_number":220,"context_line":"                    # \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":221,"context_line":"                    # \"delete_policy_rule\"."},{"line_number":222,"context_line":"                    proxy_method \u003d \u0027\u0027.join(attrib.split(rule_type + \u0027_\u0027))"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                    rule_obj \u003d rule_objects[rule_type]"},{"line_number":225,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_1ce9461b","line":222,"updated":"2016-05-06 11:57:32.000000000","message":"and you can construct your proxy method more visually using the group keys instead.\n\n\"{action}_{rules}\".format(**{\u0027action\u0027:res.group(\u0027action\u0027), \u0027rules\u0027: res.group(\u0027rules\u0027)})","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"569c25de935ed3640c49fd0698a0ce81934e0b1b","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                    # Extract the proxy method name. So, for instance, from"},{"line_number":220,"context_line":"                    # \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":221,"context_line":"                    # \"delete_policy_rule\"."},{"line_number":222,"context_line":"                    proxy_method \u003d \u0027\u0027.join(attrib.split(rule_type + \u0027_\u0027))"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"                    rule_obj \u003d rule_objects[rule_type]"},{"line_number":225,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_2bdeeb10","line":222,"in_reply_to":"dab17558_1ce9461b","updated":"2016-05-17 10:20:12.000000000","message":"I think the code comment helps, but I agree the assignment itself is not visually clear. \n\nBut the \"action\" and the \"rules\" groups in the patterns would serve only the purpose of this string formatting, and a cost, I think, to the readability of the patterns themselves.  So hopefully you will like the compromise in what I have done instead, which is to use a string replace instead of the split/join.","commit_id":"c9fe7d980b35e832c1e799c681fd4488fe1abf01"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"b5bdabab3ab9960fa798a062edb6477caa206c65","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    rule_objects \u003d {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,"},{"line_number":193,"context_line":"                \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    # Patterns used to call method proxies for all policy-specific"},{"line_number":196,"context_line":"    # method calls (see __getattr__ docstring, below)."},{"line_number":197,"context_line":"    qos_rule_method_patterns \u003d ["},{"line_number":198,"context_line":"            re.compile("}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_99939f4f","line":195,"range":{"start_line":195,"start_character":51,"end_line":195,"end_character":66},"updated":"2016-05-18 03:47:28.000000000","message":"I\u0027ll fix this in next PS to read \"policy-rule-specific\"","commit_id":"4d2e5e57ca276543004b2b6fb61c3f0edcf16585"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"367dba4b5f567634ae5f75210378580086e3a470","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    # The rule object type to use for each incoming rule-related request."},{"line_number":194,"context_line":"    rule_objects \u003d {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,"},{"line_number":195,"context_line":"                \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # Patterns used to call method proxies for all policy-rule-specific"},{"line_number":198,"context_line":"    # method calls (see __getattr__ docstring, below)."}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_609b7eca","line":195,"updated":"2016-05-18 14:15:04.000000000","message":"nit: shouldn\u0027t it be alligned to \u0027bandwidth_limit\u0027?","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e4f1c13b36bc1957ebfbed816607d92176df3b23","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    # The rule object type to use for each incoming rule-related request."},{"line_number":194,"context_line":"    rule_objects \u003d {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,"},{"line_number":195,"context_line":"                \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # Patterns used to call method proxies for all policy-rule-specific"},{"line_number":198,"context_line":"    # method calls (see __getattr__ docstring, below)."}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_d5071c16","line":195,"in_reply_to":"bab6814e_5640bd56","updated":"2016-05-20 08:36:26.000000000","message":"gogogo, let\u0027s merge it ! ;)","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"9a01007f48100ba5129db5d8e405f557007e13de","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    # The rule object type to use for each incoming rule-related request."},{"line_number":194,"context_line":"    rule_objects \u003d {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,"},{"line_number":195,"context_line":"                \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # Patterns used to call method proxies for all policy-rule-specific"},{"line_number":198,"context_line":"    # method calls (see __getattr__ docstring, below)."}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_5640bd56","line":195,"in_reply_to":"bab6814e_609b7eca","updated":"2016-05-18 15:23:28.000000000","message":"Yes, thank you.  I will fix.","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a4f73ed8d8c314e2139f0c7039e2b70c5f3ad926","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        pass"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @abc.abstractmethod"},{"line_number":261,"context_line":"    def create_policy(self, context, policy_data):"},{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_124b6f2b","line":261,"updated":"2016-05-20 11:48:36.000000000","message":"I suspect the parameter name change policy-\u003epolicy_data could be partly responsible of the issues you\u0027re having (if this is called via kwargs, and it probably will do to the dynamic nature of the extensions)","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b87813cf1158908b91c5e2f00c9afbdcb5b5e39d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        pass"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @abc.abstractmethod"},{"line_number":261,"context_line":"    def create_policy(self, context, policy_data):"},{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_a20e7c38","line":261,"in_reply_to":"bab6814e_124b6f2b","updated":"2016-05-20 20:38:34.000000000","message":"Exactly. I checked it and it is reason of why API tests are failing (and this service plugin not works simply). But problem is IMHO more complicated because even if You change it here to \"policy\" then it still will fail on {create|update}_policy_rule methods and reason is similar there.","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a4f73ed8d8c314e2139f0c7039e2b70c5f3ad926","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @abc.abstractmethod"},{"line_number":265,"context_line":"    def update_policy(self, context, policy_id, policy_data):"},{"line_number":266,"context_line":"        pass"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_f256abcc","line":265,"updated":"2016-05-20 11:48:36.000000000","message":"same here.","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b87813cf1158908b91c5e2f00c9afbdcb5b5e39d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        pass"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @abc.abstractmethod"},{"line_number":265,"context_line":"    def update_policy(self, context, policy_id, policy_data):"},{"line_number":266,"context_line":"        pass"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_e2040419","line":265,"in_reply_to":"bab6814e_f256abcc","updated":"2016-05-20 20:38:34.000000000","message":"yes","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                    # in order to get the proxy method name. So, for instance,"},{"line_number":225,"context_line":"                    # from \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":226,"context_line":"                    # \"delete_policy_rule\"."},{"line_number":227,"context_line":"                    proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027, \u0027\u0027)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                    rule_obj \u003d self.rule_objects[rule_type]"},{"line_number":230,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ec5e4f11","line":227,"range":{"start_line":227,"start_character":20,"end_line":227,"end_character":70},"updated":"2016-05-24 10:57:00.000000000","message":"Here, we assume that the method is defined in the plugin. Sadly, it may be not the case for alternative service plugin implementations. I think we should fall back to the old method names if the proxy_method is not present on the plugin.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ada77e7682e3abf8f4d0fffa4abb1c1ebef0ade9","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                    # in order to get the proxy method name. So, for instance,"},{"line_number":225,"context_line":"                    # from \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":226,"context_line":"                    # \"delete_policy_rule\"."},{"line_number":227,"context_line":"                    proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027, \u0027\u0027)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                    rule_obj \u003d self.rule_objects[rule_type]"},{"line_number":230,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_17dd6142","line":227,"range":{"start_line":227,"start_character":20,"end_line":227,"end_character":70},"in_reply_to":"bab6814e_373ce5be","updated":"2016-05-25 09:26:55.000000000","message":"Exactly, \n\nWe\u0027re modifying the interface, it\u0027s not different from adding new rules, where it would break (any potential plugin out there) equally.\n\nAs per IRC talk with ihar, we should probably add a note here: \n\nhttps://github.com/openstack/neutron/blob/master/doc/source/devref/neutron_api.rst#breakages\n\nAnd, also, explain the change here: \n\nhttps://github.com/openstack/neutron/blob/master/doc/source/devref/quality_of_service.rst\n\nWith a new section.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"713258218db6b2b84c6d592d3ee88a9c71983dc3","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                    # in order to get the proxy method name. So, for instance,"},{"line_number":225,"context_line":"                    # from \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":226,"context_line":"                    # \"delete_policy_rule\"."},{"line_number":227,"context_line":"                    proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027, \u0027\u0027)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                    rule_obj \u003d self.rule_objects[rule_type]"},{"line_number":230,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_373ce5be","line":227,"range":{"start_line":227,"start_character":20,"end_line":227,"end_character":70},"in_reply_to":"bab6814e_d23e8028","updated":"2016-05-25 09:08:22.000000000","message":"OK, now that I thought about it more and chatted around, I think my ask is too much. Also, it does not save existing users of the ABC since on every new rule, they need to adopt the new interface anyway.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a3adecedf434568ee8c22ccd6badf6f9ffaac4f1","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                    # in order to get the proxy method name. So, for instance,"},{"line_number":225,"context_line":"                    # from \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":226,"context_line":"                    # \"delete_policy_rule\"."},{"line_number":227,"context_line":"                    proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027, \u0027\u0027)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                    rule_obj \u003d self.rule_objects[rule_type]"},{"line_number":230,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_53ce0fb5","line":227,"range":{"start_line":227,"start_character":20,"end_line":227,"end_character":70},"in_reply_to":"bab6814e_ec5e4f11","updated":"2016-05-24 13:56:04.000000000","message":"Maybe I\u0027m being obtuse, but I don\u0027t see how this is so.  \n\nFor old-style classes: Under both original and refactored implementations, if the caller calls a method that doesn\u0027t exist in the plugin, they\u0027ll get an error.  Under new implementation, in fact, we can handle this more gracefully, namely by having a try/except in _make_call or around the lambda.\n\nFor new-style classes: Under both original and refactored implementations an error would be raised upon instantiation of a subclass hasn\u0027t implemented one of the base class\u0027s abstract methods.\n\nThat\u0027s my understanding of how this all works.  I suspect I\u0027m missing something though.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3bf79ea4b73c5a49ab1a2e0814083a750e70036c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                    # in order to get the proxy method name. So, for instance,"},{"line_number":225,"context_line":"                    # from \"delete_policy_dscp_marking_rule\" we\u0027ll get"},{"line_number":226,"context_line":"                    # \"delete_policy_rule\"."},{"line_number":227,"context_line":"                    proxy_method \u003d attrib.replace(rule_type + \u0027_\u0027, \u0027\u0027)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"                    rule_obj \u003d self.rule_objects[rule_type]"},{"line_number":230,"context_line":"                    return self._call_proxy_method(proxy_method, rule_obj)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_d23e8028","line":227,"range":{"start_line":227,"start_character":20,"end_line":227,"end_character":70},"in_reply_to":"bab6814e_ec5e4f11","updated":"2016-05-24 14:44:44.000000000","message":"agreed, let\u0027s move the refactor down to QoSPlugin instead of here.\n\nLet\u0027s leave the base alone, and our reference plugin refactored. I wonder how I missed this.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        pass"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @abc.abstractmethod"},{"line_number":304,"context_line":"    def get_policy(self, context, policy_id, fields\u003dNone):"},{"line_number":305,"context_line":"        pass"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ece3ef31","line":304,"updated":"2016-05-24 10:57:00.000000000","message":"Requiring those new symbols may not work with alternative plugins. Remember, the interface is supposed to be subclassed by external code.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"713258218db6b2b84c6d592d3ee88a9c71983dc3","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        pass"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @abc.abstractmethod"},{"line_number":304,"context_line":"    def get_policy(self, context, policy_id, fields\u003dNone):"},{"line_number":305,"context_line":"        pass"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_77b4ad34","line":304,"in_reply_to":"bab6814e_27934551","updated":"2016-05-25 09:08:22.000000000","message":"I now think it\u0027s bearable to enforce the refactoring on all users. We do it on every new rule added anyway.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ada77e7682e3abf8f4d0fffa4abb1c1ebef0ade9","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        pass"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @abc.abstractmethod"},{"line_number":304,"context_line":"    def get_policy(self, context, policy_id, fields\u003dNone):"},{"line_number":305,"context_line":"        pass"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_3777c53c","line":304,"in_reply_to":"bab6814e_77b4ad34","updated":"2016-05-25 09:26:55.000000000","message":"Yes, let\u0027s add a breakage note explaining it, documentation, and that\u0027s it.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a3adecedf434568ee8c22ccd6badf6f9ffaac4f1","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        pass"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    @abc.abstractmethod"},{"line_number":304,"context_line":"    def get_policy(self, context, policy_id, fields\u003dNone):"},{"line_number":305,"context_line":"        pass"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_27934551","line":304,"in_reply_to":"bab6814e_ece3ef31","updated":"2016-05-24 13:56:04.000000000","message":"Maybe this is related to what I\u0027m not understanding.  What do you mean by symbols here?","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"}],"neutron/objects/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f907d336d2790b5fd51dcde5e15a2099fb5689e0","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            keys[key] \u003d getattr(self, key)"},{"line_number":324,"context_line":"        return self.modify_fields_to_db(keys)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def update_nonidentifying_fields(self, obj_data):"},{"line_number":327,"context_line":"        \"\"\"Updates non-identifying fields of an object."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param obj_data: the full set of object data"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_f20d4c91","line":326,"updated":"2016-03-22 16:10:24.000000000","message":"I am not sure how useful the method is to have it in base class.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            keys[key] \u003d getattr(self, key)"},{"line_number":324,"context_line":"        return self.modify_fields_to_db(keys)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def update_nonidentifying_fields(self, obj_data):"},{"line_number":327,"context_line":"        \"\"\"Updates non-identifying fields of an object."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param obj_data: the full set of object data"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_31bb57e7","line":326,"in_reply_to":"fa0719c6_585ff90d","updated":"2016-03-29 22:00:16.000000000","message":"I\u0027ve kept this here as it seems like the right spot to me since the functionality should be object-agnostic.  Let me know if you want this elsewhere though.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"cb6b2ec25453853033f693523e1c909f5939ac95","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            keys[key] \u003d getattr(self, key)"},{"line_number":324,"context_line":"        return self.modify_fields_to_db(keys)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def update_nonidentifying_fields(self, obj_data):"},{"line_number":327,"context_line":"        \"\"\"Updates non-identifying fields of an object."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param obj_data: the full set of object data"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_585ff90d","line":326,"in_reply_to":"fa0719c6_f20d4c91","updated":"2016-03-22 16:42:38.000000000","message":"what is the alternative?","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f907d336d2790b5fd51dcde5e15a2099fb5689e0","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        :returns: None"},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.obj_reset_changes()"},{"line_number":336,"context_line":"        for k, v in obj_data.items():"},{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_920970e0","line":335,"updated":"2016-03-22 16:10:24.000000000","message":"I am not sure all callers may want all their changes to be reset.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"cb6b2ec25453853033f693523e1c909f5939ac95","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        :returns: None"},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.obj_reset_changes()"},{"line_number":336,"context_line":"        for k, v in obj_data.items():"},{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_b8b735d7","line":335,"in_reply_to":"fa0719c6_920970e0","updated":"2016-03-22 16:42:38.000000000","message":"will have caller trigger this.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        :returns: None"},{"line_number":333,"context_line":"        \"\"\""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.obj_reset_changes()"},{"line_number":336,"context_line":"        for k, v in obj_data.items():"},{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_71b5cfec","line":335,"in_reply_to":"fa0719c6_b8b735d7","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f907d336d2790b5fd51dcde5e15a2099fb5689e0","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.obj_reset_changes()"},{"line_number":336,"context_line":"        for k, v in obj_data.items():"},{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"},{"line_number":339,"context_line":"                setattr(self, k, v)"},{"line_number":340,"context_line":"        self.update()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_f259ccff","line":337,"updated":"2016-03-22 16:10:24.000000000","message":"it\u0027s primary_keys, line 152.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.obj_reset_changes()"},{"line_number":336,"context_line":"        for k, v in obj_data.items():"},{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"},{"line_number":339,"context_line":"                setattr(self, k, v)"},{"line_number":340,"context_line":"        self.update()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_51b88be5","line":337,"in_reply_to":"fa0719c6_b890d544","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"cb6b2ec25453853033f693523e1c909f5939ac95","unresolved":false,"context_lines":[{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        self.obj_reset_changes()"},{"line_number":336,"context_line":"        for k, v in obj_data.items():"},{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"},{"line_number":339,"context_line":"                setattr(self, k, v)"},{"line_number":340,"context_line":"        self.update()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_b890d544","line":337,"in_reply_to":"fa0719c6_f259ccff","updated":"2016-03-22 16:42:38.000000000","message":"ahh, got it.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f907d336d2790b5fd51dcde5e15a2099fb5689e0","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"},{"line_number":339,"context_line":"                setattr(self, k, v)"},{"line_number":340,"context_line":"        self.update()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def update(self):"},{"line_number":343,"context_line":"        updates \u003d self._get_changed_persistent_fields()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_b27ab4ef","line":340,"updated":"2016-03-22 16:10:24.000000000","message":"I would prefer the caller to trigger update itself.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"},{"line_number":339,"context_line":"                setattr(self, k, v)"},{"line_number":340,"context_line":"        self.update()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def update(self):"},{"line_number":343,"context_line":"        updates \u003d self._get_changed_persistent_fields()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_b1cf677e","line":340,"in_reply_to":"fa0719c6_58aa5971","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"cb6b2ec25453853033f693523e1c909f5939ac95","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            #TODO(Margaret): some other fields may be identifying fields"},{"line_number":338,"context_line":"            if k !\u003d \u0027id\u0027:"},{"line_number":339,"context_line":"                setattr(self, k, v)"},{"line_number":340,"context_line":"        self.update()"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def update(self):"},{"line_number":343,"context_line":"        updates \u003d self._get_changed_persistent_fields()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_58aa5971","line":340,"in_reply_to":"fa0719c6_b27ab4ef","updated":"2016-03-22 16:42:38.000000000","message":"will have caller trigger this.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            keys[key] \u003d getattr(self, key)"},{"line_number":342,"context_line":"        return self.modify_fields_to_db(keys)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def update_nonidentifying_fields(self, obj_data, reset_changes\u003dFalse):"},{"line_number":345,"context_line":"        \"\"\"Updates non-identifying fields of an object."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        :param obj_data: the full set of object data"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ee15a69b","line":344,"updated":"2016-05-24 10:57:00.000000000","message":"I don\u0027t see unit tests for the method. Please add them to BaseObjectIfaceTestCase.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a3adecedf434568ee8c22ccd6badf6f9ffaac4f1","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            keys[key] \u003d getattr(self, key)"},{"line_number":342,"context_line":"        return self.modify_fields_to_db(keys)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    def update_nonidentifying_fields(self, obj_data, reset_changes\u003dFalse):"},{"line_number":345,"context_line":"        \"\"\"Updates non-identifying fields of an object."},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"        :param obj_data: the full set of object data"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_532a8f2d","line":344,"in_reply_to":"bab6814e_ee15a69b","updated":"2016-05-24 13:56:04.000000000","message":"I will do this.  Thanks for noticing this.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"065ff6e71543b8be598bf7f7d62e33a50410c6df","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return rule"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":101,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id, policy_id,"},{"line_number":102,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":103,"context_line":"        # make sure we will have a policy object to push resource update"},{"line_number":104,"context_line":"        with db_api.autonested_transaction(context.session):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_c85f020d","line":101,"updated":"2016-03-21 12:05:15.000000000","message":"The main part about avoiding DRY here is to have an \n\nupdate_policy_*_rule catch method, that then would have a map\nto {\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,\n      \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}\n\nto handle them all.\n\nOf course, if \"*\" not in that dictionary above, we run into NonImplementedMethod or something like that","commit_id":"60d11a85357abbb05208539767714d4c743dfeb1"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"844da1e15cf36f67348f85d5103bc1267936d893","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return rule"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":101,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id, policy_id,"},{"line_number":102,"context_line":"                                           bandwidth_limit_rule):"},{"line_number":103,"context_line":"        # make sure we will have a policy object to push resource update"},{"line_number":104,"context_line":"        with db_api.autonested_transaction(context.session):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_675c1126","line":101,"in_reply_to":"fa0719c6_c85f020d","updated":"2016-03-22 03:15:01.000000000","message":"Refactoring create, delete, and get rules now also.","commit_id":"60d11a85357abbb05208539767714d4c743dfeb1"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :type context: neutron.context.Context"},{"line_number":64,"context_line":"        :param policy_id: the id of the QoSPolicy to update"},{"line_number":65,"context_line":"        :param policy_id: str uuid"},{"line_number":66,"context_line":"        :param policy_data: policy data to be applied"},{"line_number":67,"context_line":"        :type policy_data: dict"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :returns: a QoSPolicy object"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_f35ba4f4","line":66,"range":{"start_line":66,"start_character":28,"end_line":66,"end_character":53},"updated":"2016-03-22 11:32:32.000000000","message":"new policy data","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        :type context: neutron.context.Context"},{"line_number":64,"context_line":"        :param policy_id: the id of the QoSPolicy to update"},{"line_number":65,"context_line":"        :param policy_id: str uuid"},{"line_number":66,"context_line":"        :param policy_data: policy data to be applied"},{"line_number":67,"context_line":"        :type policy_data: dict"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :returns: a QoSPolicy object"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_f1c9df79","line":66,"range":{"start_line":66,"start_character":28,"end_line":66,"end_character":53},"in_reply_to":"fa0719c6_f35ba4f4","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :type context: neutron.context.Context"},{"line_number":149,"context_line":"        :param policy_id: the id of the QoSPolicy for which to create the rule"},{"line_number":150,"context_line":"        :type policy_id: str uuid"},{"line_number":151,"context_line":"        :param rule_data: the rule data to create"},{"line_number":152,"context_line":"        :type rule_data: dict"},{"line_number":153,"context_line":"        :param rule_type: the type of rule to create"},{"line_number":154,"context_line":"        :type rule_type: str"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_936d089b","line":151,"range":{"start_line":151,"start_character":43,"end_line":151,"end_character":49},"updated":"2016-03-22 11:32:32.000000000","message":"be applied","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :type context: neutron.context.Context"},{"line_number":149,"context_line":"        :param policy_id: the id of the QoSPolicy for which to create the rule"},{"line_number":150,"context_line":"        :type policy_id: str uuid"},{"line_number":151,"context_line":"        :param rule_data: the rule data to create"},{"line_number":152,"context_line":"        :type rule_data: dict"},{"line_number":153,"context_line":"        :param rule_type: the type of rule to create"},{"line_number":154,"context_line":"        :type rule_type: str"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_d1c49b60","line":151,"range":{"start_line":151,"start_character":43,"end_line":151,"end_character":49},"in_reply_to":"fa0719c6_936d089b","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        :param rule_type: the type of rule to create"},{"line_number":154,"context_line":"        :type rule_type: str"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        :returns: a QoSPolicy Rule object"},{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        self._verify_rule_type(context, rule_type)"},{"line_number":159,"context_line":"        rule_data \u003d rule_data[rule_type]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_5397f08f","line":156,"range":{"start_line":156,"start_character":30,"end_line":156,"end_character":34},"updated":"2016-03-22 11:32:32.000000000","message":"rule","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        :param rule_type: the type of rule to create"},{"line_number":154,"context_line":"        :type rule_type: str"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        :returns: a QoSPolicy Rule object"},{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        self._verify_rule_type(context, rule_type)"},{"line_number":159,"context_line":"        rule_data \u003d rule_data[rule_type]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_31a237af","line":156,"range":{"start_line":156,"start_character":30,"end_line":156,"end_character":34},"in_reply_to":"fa0719c6_5397f08f","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :type context: neutron.context.Context"},{"line_number":178,"context_line":"        :param rule_id: the id of the QoS policy rule to update"},{"line_number":179,"context_line":"        :type rule_id: str uuid"},{"line_number":180,"context_line":"        :param policy_id: the id of rule\u0027s policy"},{"line_number":181,"context_line":"        :type policy_id: str uuid"},{"line_number":182,"context_line":"        :param rule_data: rule data to update"},{"line_number":183,"context_line":"        :type rule_data: dict"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_136f38c6","line":180,"range":{"start_line":180,"start_character":33,"end_line":180,"end_character":42},"updated":"2016-03-22 11:32:32.000000000","message":"of the rule\u0027s","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :type context: neutron.context.Context"},{"line_number":178,"context_line":"        :param rule_id: the id of the QoS policy rule to update"},{"line_number":179,"context_line":"        :type rule_id: str uuid"},{"line_number":180,"context_line":"        :param policy_id: the id of rule\u0027s policy"},{"line_number":181,"context_line":"        :type policy_id: str uuid"},{"line_number":182,"context_line":"        :param rule_data: rule data to update"},{"line_number":183,"context_line":"        :type rule_data: dict"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_11a573b4","line":180,"range":{"start_line":180,"start_character":33,"end_line":180,"end_character":42},"in_reply_to":"fa0719c6_136f38c6","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        :type rule_id: str uuid"},{"line_number":180,"context_line":"        :param policy_id: the id of rule\u0027s policy"},{"line_number":181,"context_line":"        :type policy_id: str uuid"},{"line_number":182,"context_line":"        :param rule_data: rule data to update"},{"line_number":183,"context_line":"        :type rule_data: dict"},{"line_number":184,"context_line":"        :param rule_type: the rule type of the rule to update"},{"line_number":185,"context_line":"        :type rule_type: str"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_b3080cdb","line":183,"range":{"start_line":182,"start_character":26,"end_line":183,"end_character":29},"updated":"2016-03-22 11:32:32.000000000","message":"the new rule data","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        :type rule_id: str uuid"},{"line_number":180,"context_line":"        :param policy_id: the id of rule\u0027s policy"},{"line_number":181,"context_line":"        :type policy_id: str uuid"},{"line_number":182,"context_line":"        :param rule_data: rule data to update"},{"line_number":183,"context_line":"        :type rule_data: dict"},{"line_number":184,"context_line":"        :param rule_type: the rule type of the rule to update"},{"line_number":185,"context_line":"        :type rule_type: str"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_71acafa0","line":183,"range":{"start_line":182,"start_character":26,"end_line":183,"end_character":29},"in_reply_to":"fa0719c6_b3080cdb","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :param context: neutron api request context"},{"line_number":230,"context_line":"        :type context: neutron.context.Context"},{"line_number":231,"context_line":"        :param rule_id: the id of the QoSPolicy Rule to get"},{"line_number":232,"context_line":"        :type rule_id: str uuid"},{"line_number":233,"context_line":"        :param policy_id: the id of the rule\u0027s policy"},{"line_number":234,"context_line":"        :type policy_id: str uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_b39e4cb6","line":231,"range":{"start_line":231,"start_character":38,"end_line":231,"end_character":52},"updated":"2016-03-22 11:32:32.000000000","message":"QoS policy rule","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        :param context: neutron api request context"},{"line_number":230,"context_line":"        :type context: neutron.context.Context"},{"line_number":231,"context_line":"        :param rule_id: the id of the QoSPolicy Rule to get"},{"line_number":232,"context_line":"        :type rule_id: str uuid"},{"line_number":233,"context_line":"        :param policy_id: the id of the rule\u0027s policy"},{"line_number":234,"context_line":"        :type policy_id: str uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_51afeb93","line":231,"range":{"start_line":231,"start_character":38,"end_line":231,"end_character":52},"in_reply_to":"fa0719c6_b39e4cb6","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        :type rule_id: str uuid"},{"line_number":233,"context_line":"        :param policy_id: the id of the rule\u0027s policy"},{"line_number":234,"context_line":"        :type policy_id: str uuid"},{"line_number":235,"context_line":"        :param rule_type: the rule type of the rule to update"},{"line_number":236,"context_line":"        :type rule_type: str"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        :returns: a QoS policy rule object"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_936348dc","line":235,"range":{"start_line":235,"start_character":55,"end_line":235,"end_character":61},"updated":"2016-03-22 11:32:32.000000000","message":"get","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":232,"context_line":"        :type rule_id: str uuid"},{"line_number":233,"context_line":"        :param policy_id: the id of the rule\u0027s policy"},{"line_number":234,"context_line":"        :type policy_id: str uuid"},{"line_number":235,"context_line":"        :param rule_type: the rule type of the rule to update"},{"line_number":236,"context_line":"        :type rule_type: str"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        :returns: a QoS policy rule object"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_b196474a","line":235,"range":{"start_line":235,"start_character":55,"end_line":235,"end_character":61},"in_reply_to":"fa0719c6_936348dc","updated":"2016-03-29 22:00:16.000000000","message":"Done","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f907d336d2790b5fd51dcde5e15a2099fb5689e0","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":273,"context_line":"            return self.rule_types[rule_type].get_objects(context, **filters)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":276,"context_line":"                                           rule_data):"},{"line_number":277,"context_line":"        return self.create_policy_rule(context, policy_id, rule_data,"},{"line_number":278,"context_line":"                                       \u0027bandwidth_limit_rule\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_320ea43b","line":275,"updated":"2016-03-22 16:10:24.000000000","message":"Ideally, there should be no type specific methods at all. Instead, you would generate them catching access on __get__ and proxying the call based on self.rule_type.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"cb6b2ec25453853033f693523e1c909f5939ac95","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":273,"context_line":"            return self.rule_types[rule_type].get_objects(context, **filters)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":276,"context_line":"                                           rule_data):"},{"line_number":277,"context_line":"        return self.create_policy_rule(context, policy_id, rule_data,"},{"line_number":278,"context_line":"                                       \u0027bandwidth_limit_rule\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_336a26b4","line":275,"in_reply_to":"fa0719c6_320ea43b","updated":"2016-03-22 16:42:38.000000000","message":"but i thought what i did was so cool! :)  okay, will move to figuring all this out...","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ef5dfc0a45eb0a613730506b94c51af9781e143b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":273,"context_line":"            return self.rule_types[rule_type].get_objects(context, **filters)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":276,"context_line":"                                           rule_data):"},{"line_number":277,"context_line":"        return self.create_policy_rule(context, policy_id, rule_data,"},{"line_number":278,"context_line":"                                       \u0027bandwidth_limit_rule\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_de956033","line":275,"in_reply_to":"fa0719c6_336a26b4","updated":"2016-03-23 21:39:33.000000000","message":"It is cool, it just can be cooler. :)","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"e18fcdc29a4a43e5399be9c3bea491d8ffd90f76","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":273,"context_line":"            return self.rule_types[rule_type].get_objects(context, **filters)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_policy_bandwidth_limit_rule(self, context, policy_id,"},{"line_number":276,"context_line":"                                           rule_data):"},{"line_number":277,"context_line":"        return self.create_policy_rule(context, policy_id, rule_data,"},{"line_number":278,"context_line":"                                       \u0027bandwidth_limit_rule\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_f1a0bfa1","line":275,"in_reply_to":"fa0719c6_de956033","updated":"2016-03-29 22:00:16.000000000","message":"Way cooler.  Hopefully I got this right.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"741b1fec9b2aa69e2496f248e8adbc95cc204ead","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        if rule_type not in self.get_rule_types(context):"},{"line_number":328,"context_line":"            raise n_exc.InvalidQosRuleType(rule_type\u003drule_type)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def get_rule_types(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":331,"context_line":"                       sorts\u003dNone, limit\u003dNone,"},{"line_number":332,"context_line":"                       marker\u003dNone, page_reverse\u003dFalse):"},{"line_number":333,"context_line":"        return rule_type_object.QosRuleType.get_objects(**filters)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_b33acc96","line":330,"range":{"start_line":330,"start_character":8,"end_line":330,"end_character":22},"updated":"2016-03-22 11:32:32.000000000","message":"TODO(Margaret): Docstring, including figuring out this signature.","commit_id":"78e1e557de6eb1e7551765a049b3b4e51de0f609"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a4cb34a599688278881d97f44c08a3620a16c6a5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Specify the proxied method, rule type, and object type for each policy"},{"line_number":45,"context_line":"    # rule method."},{"line_number":46,"context_line":"    _RULE_METHODS \u003d {"},{"line_number":47,"context_line":"        \u0027create_policy_bandwidth_limit_rule\u0027: (\u0027create_policy_rule\u0027,"},{"line_number":48,"context_line":"            [\u0027bandwidth_limit_rule\u0027, rule_object.QosBandwidthLimitRule]),"},{"line_number":49,"context_line":"        \u0027update_policy_bandwidth_limit_rule\u0027:"},{"line_number":50,"context_line":"            (\u0027update_policy_rule\u0027, [\u0027bandwidth_limit_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_262ee6fa","line":47,"updated":"2016-04-01 10:32:26.000000000","message":"can we find a way to just map the final part of the names\n*bandwidth_limit_rule\n*dscp_marking_rule, to the right objects, instead of having\na huge map ?","commit_id":"90311b54bd5e2b3c11f48c0d47fe48286ba95269"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4d3b175046a73ce67c25ab649462e87ee4d90bc2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Specify the proxied method, rule type, and object type for each policy"},{"line_number":45,"context_line":"    # rule method."},{"line_number":46,"context_line":"    _RULE_METHODS \u003d {"},{"line_number":47,"context_line":"        \u0027create_policy_bandwidth_limit_rule\u0027: (\u0027create_policy_rule\u0027,"},{"line_number":48,"context_line":"            [\u0027bandwidth_limit_rule\u0027, rule_object.QosBandwidthLimitRule]),"},{"line_number":49,"context_line":"        \u0027update_policy_bandwidth_limit_rule\u0027:"},{"line_number":50,"context_line":"            (\u0027update_policy_rule\u0027, [\u0027bandwidth_limit_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_78716b77","line":47,"in_reply_to":"9a061dce_319280a0","updated":"2016-04-08 13:13:42.000000000","message":"No problem Ajo.  I was on a business trip anyway.  I really appreciate your feedback.  I\u0027ll think about what you and Ihar said and get back to you with the next PS or further questions if I have them.  This is totally great.","commit_id":"90311b54bd5e2b3c11f48c0d47fe48286ba95269"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5b16b5e855558ba64f28396a335cd0bb38c79e28","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Specify the proxied method, rule type, and object type for each policy"},{"line_number":45,"context_line":"    # rule method."},{"line_number":46,"context_line":"    _RULE_METHODS \u003d {"},{"line_number":47,"context_line":"        \u0027create_policy_bandwidth_limit_rule\u0027: (\u0027create_policy_rule\u0027,"},{"line_number":48,"context_line":"            [\u0027bandwidth_limit_rule\u0027, rule_object.QosBandwidthLimitRule]),"},{"line_number":49,"context_line":"        \u0027update_policy_bandwidth_limit_rule\u0027:"},{"line_number":50,"context_line":"            (\u0027update_policy_rule\u0027, [\u0027bandwidth_limit_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_319280a0","line":47,"in_reply_to":"9a061dce_a3403308","updated":"2016-04-08 09:11:38.000000000","message":"Sorry for the delay in my answer, please free to ping me if you don\u0027t see me replying on IRC.\n\nyou could have in the keys just the object types (bandwidth_limit_rule, dscp_marking_rule), \nand then detect via regular expressions\n\nget_policy_(.*)_rules\nget_policy_(.*)_rule\ndelete_policy(.*)_rule\nupdate_policy(.*)_rule\ncreate_policy(.*)_rule\n\nyour dict would have\n{\u0027bandwidth_limit\u0027: rule_object.QosBandwidthLimitRule,\n \u0027dscp_marking\u0027: rule_object.QosDscpMarkingRule}\n\nand then have a get/delete/update/create generic method passed the API request parameters, and the object type (from this dictionary).","commit_id":"90311b54bd5e2b3c11f48c0d47fe48286ba95269"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"51b6eab9f21e164555f15433be3a8630c636a4ef","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Specify the proxied method, rule type, and object type for each policy"},{"line_number":45,"context_line":"    # rule method."},{"line_number":46,"context_line":"    _RULE_METHODS \u003d {"},{"line_number":47,"context_line":"        \u0027create_policy_bandwidth_limit_rule\u0027: (\u0027create_policy_rule\u0027,"},{"line_number":48,"context_line":"            [\u0027bandwidth_limit_rule\u0027, rule_object.QosBandwidthLimitRule]),"},{"line_number":49,"context_line":"        \u0027update_policy_bandwidth_limit_rule\u0027:"},{"line_number":50,"context_line":"            (\u0027update_policy_rule\u0027, [\u0027bandwidth_limit_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_a3403308","line":47,"in_reply_to":"ba0121b8_262ee6fa","updated":"2016-04-07 15:22:08.000000000","message":"And we should generate those methods in base plugin interface too.","commit_id":"90311b54bd5e2b3c11f48c0d47fe48286ba95269"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"f7ed84b6b59e47c02a2109330c24a29b4dd064b3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    # Specify the proxied method, rule type, and object type for each policy"},{"line_number":45,"context_line":"    # rule method."},{"line_number":46,"context_line":"    _RULE_METHODS \u003d {"},{"line_number":47,"context_line":"        \u0027create_policy_bandwidth_limit_rule\u0027: (\u0027create_policy_rule\u0027,"},{"line_number":48,"context_line":"            [\u0027bandwidth_limit_rule\u0027, rule_object.QosBandwidthLimitRule]),"},{"line_number":49,"context_line":"        \u0027update_policy_bandwidth_limit_rule\u0027:"},{"line_number":50,"context_line":"            (\u0027update_policy_rule\u0027, [\u0027bandwidth_limit_rule\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_8fd89054","line":47,"in_reply_to":"ba0121b8_262ee6fa","updated":"2016-04-01 18:02:30.000000000","message":"Excellent, good.  This map is very scary.  I can see how I can make this dictionary\u0027s values a lot more elegant.  But its keys must be the actual method names that will be used by the caller, right?","commit_id":"90311b54bd5e2b3c11f48c0d47fe48286ba95269"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b87813cf1158908b91c5e2f00c9afbdcb5b5e39d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        return rule_type_object.QosRuleType.get_objects(**filters)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":148,"context_line":"    def create_policy_rule(self, context, policy_id, rule_data, rule_obj):"},{"line_number":149,"context_line":"        \"\"\"Create a QoS policy rule."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_7d40b534","line":148,"updated":"2016-05-20 20:38:34.000000000","message":"problem here is that You are passing for example \"bandwidth_limit_rule\" to this method from Your proxy. There will be no \"rule_data\". I made test and changed this method littlebit to\n\ndef create_policy_rule(self, *args, **kwargs)\n\nthen I had:\n\n(Pdb++) pp args\n(\u003cneutron.context.Context object at 0x7f5079e58fd0\u003e, \u003cclass \u0027neutron.objects.qos.rule.QosBandwidthLimitRule\u0027\u003e)\n(Pdb++) pp kwargs\n{\u0027bandwidth_limit_rule\u0027: {u\u0027bandwidth_limit_rule\u0027: {\u0027max_burst_kbps\u0027: 0, u\u0027max_kbps\u0027: u\u0027100\u0027, \u0027tenant_id\u0027: u\u0027a8a31c9434ff431cb789c809777505ec\u0027}},\n \u0027policy_id\u0027: u\u002746985da5-9684-402e-b0d7-b7adac909c3a\u0027}\n\nSo as You can see this is reason of errors. I think that You should change somehow names of parameters here to other but I\u0027m not sure if it will be easy to do.","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"5f48466e53def8b7be30e92ae1d4909a6eec6ef6","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        return rule_type_object.QosRuleType.get_objects(**filters)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":148,"context_line":"    def create_policy_rule(self, context, policy_id, rule_data, rule_obj):"},{"line_number":149,"context_line":"        \"\"\"Create a QoS policy rule."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_b2287834","line":148,"in_reply_to":"bab6814e_7d40b534","updated":"2016-05-22 01:30:21.000000000","message":"We fixed this (by which I mean that you, primarily, fixed this).  Thank you!","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b87813cf1158908b91c5e2f00c9afbdcb5b5e39d","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        return rule"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":176,"context_line":"    def update_policy_rule(self, context, rule_id, policy_id, rule_data,"},{"line_number":177,"context_line":"                           rule_obj):"},{"line_number":178,"context_line":"        \"\"\"Update a QoS policy rule."},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_fd7ae586","line":176,"updated":"2016-05-20 20:38:34.000000000","message":"similar case here","commit_id":"eaefe388df640b91819f90acde6bdc532610a970"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0e6f54dfc39973dabb74c60da529e0bb1dcf9fab","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        return policy_object.QosPolicy.get_objects(context, **filters)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def _verify_rule_type(self, context, rule_type):"},{"line_number":138,"context_line":"        # Ensure that rule_type (e.g., \u0027dscp_marking\u0027) can be found as one of"},{"line_number":139,"context_line":"        # the values in the dict returned from get_rule_types, which takes the"},{"line_number":140,"context_line":"        # form:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_653ab79a","line":137,"updated":"2016-05-23 09:43:41.000000000","message":"We should not do this check. Even though if it\u0027s confusing, in some cases we could have the case where SR-IOV and OVS live side by side on the same deployment and hosts.\n\nSR-IOV does not support dscp yet, and OVS does, but the admin is aware of this and wants to leverage both.\n\nWe will introduce additional checks per-port type (vnic type) and available mechanism drivers in the system, but this is tangential to this patch.","commit_id":"389b47394d2b04003ff83056415169df7d525a52"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            return rule_object.QosDscpMarkingRule.get_objects(context,"},{"line_number":232,"context_line":"                                                              **filters)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # TODO(QoS): enforce rule types when accessing rule objects"},{"line_number":235,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":236,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":237,"context_line":"    def get_rule_types(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_8c8223c7","side":"PARENT","line":234,"updated":"2016-05-24 10:57:00.000000000","message":"Why do we remove the TODO?","commit_id":"0eed94a777dbbdb2d8554cba136cd8e8145a9870"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"757d1df109c37bf2ccfcb71174628a543997082a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            return rule_object.QosDscpMarkingRule.get_objects(context,"},{"line_number":232,"context_line":"                                                              **filters)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # TODO(QoS): enforce rule types when accessing rule objects"},{"line_number":235,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":236,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":237,"context_line":"    def get_rule_types(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_31440a73","side":"PARENT","line":234,"in_reply_to":"bab6814e_4e776f3b","updated":"2016-05-24 21:20:48.000000000","message":"Will restore.","commit_id":"0eed94a777dbbdb2d8554cba136cd8e8145a9870"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d71b7701726fe2af16ecf05e1a2f43caecd2c8b6","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            return rule_object.QosDscpMarkingRule.get_objects(context,"},{"line_number":232,"context_line":"                                                              **filters)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # TODO(QoS): enforce rule types when accessing rule objects"},{"line_number":235,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":236,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":237,"context_line":"    def get_rule_types(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_4e776f3b","side":"PARENT","line":234,"in_reply_to":"bab6814e_84d4a847","updated":"2016-05-24 20:43:44.000000000","message":"I agree.","commit_id":"0eed94a777dbbdb2d8554cba136cd8e8145a9870"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3bf79ea4b73c5a49ab1a2e0814083a750e70036c","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            return rule_object.QosDscpMarkingRule.get_objects(context,"},{"line_number":232,"context_line":"                                                              **filters)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # TODO(QoS): enforce rule types when accessing rule objects"},{"line_number":235,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":236,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":237,"context_line":"    def get_rule_types(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_fe3b8336","side":"PARENT","line":234,"in_reply_to":"bab6814e_8c8223c7","updated":"2016-05-24 14:44:44.000000000","message":"Oh, because she implemented it, and then it was removed becase we cannot test it, and slawek and I are handling that in a different way.","commit_id":"0eed94a777dbbdb2d8554cba136cd8e8145a9870"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2090a3b7d24feaaba75c1ba08151c3f6e08a44e0","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            return rule_object.QosDscpMarkingRule.get_objects(context,"},{"line_number":232,"context_line":"                                                              **filters)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    # TODO(QoS): enforce rule types when accessing rule objects"},{"line_number":235,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":236,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":237,"context_line":"    def get_rule_types(self, context, filters\u003dNone, fields\u003dNone,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_84d4a847","side":"PARENT","line":234,"in_reply_to":"bab6814e_fe3b8336","updated":"2016-05-24 15:02:43.000000000","message":"I think it should be restored here since it is not the goal of the patch to handle it.","commit_id":"0eed94a777dbbdb2d8554cba136cd8e8145a9870"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        :param policy: policy data to be applied"},{"line_number":47,"context_line":"        :type policy: dict"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :returns: a QoSPolicy object"},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"},{"line_number":52,"context_line":"        policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_4c2b1b34","line":49,"range":{"start_line":49,"start_character":20,"end_line":49,"end_character":29},"updated":"2016-05-24 10:57:00.000000000","message":"QosPolicy","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"a3adecedf434568ee8c22ccd6badf6f9ffaac4f1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        :param policy: policy data to be applied"},{"line_number":47,"context_line":"        :type policy: dict"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        :returns: a QoSPolicy object"},{"line_number":50,"context_line":"        \"\"\""},{"line_number":51,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, **policy[\u0027policy\u0027])"},{"line_number":52,"context_line":"        policy_obj.create()"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_73b3530b","line":49,"range":{"start_line":49,"start_character":20,"end_line":49,"end_character":29},"in_reply_to":"bab6814e_4c2b1b34","updated":"2016-05-24 13:56:04.000000000","message":"Thank you for catching this.  I will change.","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param context: neutron api request context"},{"line_number":61,"context_line":"        :type context: neutron.context.Context"},{"line_number":62,"context_line":"        :param policy_id: the id of the QoSPolicy to update"},{"line_number":63,"context_line":"        :param policy_id: str uuid"},{"line_number":64,"context_line":"        :param policy: new policy data to be applied"},{"line_number":65,"context_line":"        :type policy: dict"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ac1c4714","line":62,"range":{"start_line":62,"start_character":40,"end_line":62,"end_character":49},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        :param policy: new policy data to be applied"},{"line_number":65,"context_line":"        :type policy: dict"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        :returns: a QoSPolicy object"},{"line_number":68,"context_line":"        \"\"\""},{"line_number":69,"context_line":"        policy_data \u003d policy[\u0027policy\u0027]"},{"line_number":70,"context_line":"        policy_obj \u003d policy_object.QosPolicy(context, id\u003dpolicy_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ec164ff0","line":67,"range":{"start_line":67,"start_character":20,"end_line":67,"end_character":29},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        :param context: neutron api request context"},{"line_number":81,"context_line":"        :type context: neutron.context.Context"},{"line_number":82,"context_line":"        :param policy_id: the id of the QoSPolicy to delete"},{"line_number":83,"context_line":"        :type policy_id: str uuid"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :returns: None"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ace3a704","line":82,"range":{"start_line":82,"start_character":40,"end_line":82,"end_character":49},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param context: neutron api request context"},{"line_number":96,"context_line":"        :type context: neutron.context.Context"},{"line_number":97,"context_line":"        :param policy_id: the id of the QoSPolicy to fetch"},{"line_number":98,"context_line":"        :type policy_id: str uuid"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :returns: a QoSPolicy object"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_4cdcbb18","line":97,"range":{"start_line":97,"start_character":40,"end_line":97,"end_character":49},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        :param policy_id: the id of the QoSPolicy to fetch"},{"line_number":98,"context_line":"        :type policy_id: str uuid"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        :returns: a QoSPolicy object"},{"line_number":101,"context_line":"        :raises: n_exc.QosPolicyNotFound"},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":"        obj \u003d policy_object.QosPolicy.get_object(context, id\u003dpolicy_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_2ce177d1","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":29},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        :param context: neutron api request context"},{"line_number":114,"context_line":"        :type context: neutron.context.Context"},{"line_number":115,"context_line":"        :param policy_id: the id of the QoSPolicy to update"},{"line_number":116,"context_line":"        :type policy_id: str uuid"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        :returns: a QoSPolicy object"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ccd0abfa","line":115,"range":{"start_line":115,"start_character":40,"end_line":115,"end_character":49},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        :param policy_id: the id of the QoSPolicy to update"},{"line_number":116,"context_line":"        :type policy_id: str uuid"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        :returns: a QoSPolicy object"},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        return self._get_policy_obj(context, policy_id)"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_2c085791","line":118,"range":{"start_line":118,"start_character":20,"end_line":118,"end_character":29},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        :param filters: search criteria"},{"line_number":131,"context_line":"        :type filters: dict"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        :returns: QoSPolicy objects meeting the search criteria"},{"line_number":134,"context_line":"        \"\"\""},{"line_number":135,"context_line":"        return policy_object.QosPolicy.get_objects(context, **filters)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_ac3ba737","line":133,"range":{"start_line":133,"start_character":18,"end_line":133,"end_character":27},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        :type context: neutron.context.Context"},{"line_number":152,"context_line":"        :param rule_obj: the rule object"},{"line_number":153,"context_line":"        :type rule_obj: a class from the rule_object (qos.objects.rule) module"},{"line_number":154,"context_line":"        :param policy_id: the id of the QoSPolicy for which to create the rule"},{"line_number":155,"context_line":"        :type policy_id: str uuid"},{"line_number":156,"context_line":"        :param rule_data: the rule data to be applied"},{"line_number":157,"context_line":"        :type rule_data: dict"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_8c598391","line":154,"range":{"start_line":154,"start_character":40,"end_line":154,"end_character":49},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c16493cc99f67baec7bb7a8ef9ab4c688cb66b3e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        :type context: neutron.context.Context"},{"line_number":211,"context_line":"        :param rule_obj: the rule object"},{"line_number":212,"context_line":"        :type rule_obj: a class from the rule_object (qos.objects.rule) module"},{"line_number":213,"context_line":"        :param rule_id: the id of the QoSPolicy Rule to delete"},{"line_number":214,"context_line":"        :type rule_id: str uuid"},{"line_number":215,"context_line":"        :param policy_id: the id of the rule\u0027s policy"},{"line_number":216,"context_line":"        :type policy_id: str uuid"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_2ccb3720","line":213,"range":{"start_line":213,"start_character":38,"end_line":213,"end_character":47},"updated":"2016-05-24 10:57:00.000000000","message":"ditto","commit_id":"0e4949a21e36daace2f9405c9381770766dcd395"}]}
