)]}'
{"neutron/tests/functional/agent/test_firewall.py":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"1dc60a13c77b5b0355682b3744991dbdb5dd897e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            r for r in self.firewall.iptables.get_rules_for_table(\u0027filter\u0027)"},{"line_number":243,"context_line":"            if r.startswith(outgoing_rule_pref)"},{"line_number":244,"context_line":"        ]"},{"line_number":245,"context_line":"        # we want to ensure the rules went in the same order we sent"},{"line_number":246,"context_line":"        indexes \u003d [rules.index(\u0027%s -p tcp -m tcp --dport %s -j RETURN\u0027 %"},{"line_number":247,"context_line":"                               (outgoing_rule_pref, i[\u0027port_range_min\u0027]))"},{"line_number":248,"context_line":"                   for i in sg_rules]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_a59bb071","line":245,"updated":"2016-03-22 02:49:47.000000000","message":"no, in this case the double word is correct and should be retained: (quotes below to show grouping):\n\nwe want to ensure that the rules \"went in\" \"in the same order [as] we sent\"","commit_id":"30debe152e48e74ad5e7541f77b65fa475428ec3"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d5408d031325e011b1fe0cee3b41b4bd716d9ee2","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            r for r in self.firewall.iptables.get_rules_for_table(\u0027filter\u0027)"},{"line_number":243,"context_line":"            if r.startswith(outgoing_rule_pref)"},{"line_number":244,"context_line":"        ]"},{"line_number":245,"context_line":"        # we want to ensure the rules went in the same order we sent"},{"line_number":246,"context_line":"        indexes \u003d [rules.index(\u0027%s -p tcp -m tcp --dport %s -j RETURN\u0027 %"},{"line_number":247,"context_line":"                               (outgoing_rule_pref, i[\u0027port_range_min\u0027]))"},{"line_number":248,"context_line":"                   for i in sg_rules]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_65f4f886","line":245,"in_reply_to":"fa0719c6_a5729047","updated":"2016-03-22 03:02:19.000000000","message":"works for me","commit_id":"30debe152e48e74ad5e7541f77b65fa475428ec3"},{"author":{"_account_id":17958,"name":"NGUYEN TUONG THANH","email":"ngtthanh1010@gmail.com","username":"thanhnt"},"change_message_id":"005c6afc23656b2a8c061367e1ab435546cd28a8","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            r for r in self.firewall.iptables.get_rules_for_table(\u0027filter\u0027)"},{"line_number":243,"context_line":"            if r.startswith(outgoing_rule_pref)"},{"line_number":244,"context_line":"        ]"},{"line_number":245,"context_line":"        # we want to ensure the rules went in the same order we sent"},{"line_number":246,"context_line":"        indexes \u003d [rules.index(\u0027%s -p tcp -m tcp --dport %s -j RETURN\u0027 %"},{"line_number":247,"context_line":"                               (outgoing_rule_pref, i[\u0027port_range_min\u0027]))"},{"line_number":248,"context_line":"                   for i in sg_rules]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_a5729047","line":245,"in_reply_to":"fa0719c6_a59bb071","updated":"2016-03-22 02:58:29.000000000","message":"Thanks for your help. I will update this to: \n\nwe want to ensure that the rules \"went in\" in the same order as we sent\n\nIs it right?","commit_id":"30debe152e48e74ad5e7541f77b65fa475428ec3"}]}
