)]}'
{"neutron/db/migration/cli.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fd85e2d14c709d560d71619f748741710e942b12","unresolved":false,"context_lines":[{"line_number":61,"context_line":"BRANCHLESS_WARNING \u003d \u0027Branchless migration chains are deprecated as of Mitaka.\u0027"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"neutron_alembic_ini \u003d os.path.join(os.path.dirname(__file__), \u0027alembic.ini\u0027)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"VALID_SERVICES \u003d [\u0027fwaas\u0027, \u0027lbaas\u0027, \u0027vpnaas\u0027]"},{"line_number":67,"context_line":"INSTALLED_SERVICES \u003d [service_ for service_ in VALID_SERVICES"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_8691f6f3","line":64,"updated":"2016-03-23 15:14:28.000000000","message":"Put the logging setup here:\n\n  logging_config.fileConfig(neutron_alembic_ini)","commit_id":"8a15eb393dd7bec1890081fa69b48843090a33d3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8fb90777c55b3948051d4c30711b0ac574b09542","unresolved":false,"context_lines":[{"line_number":760,"context_line":""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"def main():"},{"line_number":763,"context_line":"    CONF(project\u003d\u0027neutron\u0027)"},{"line_number":764,"context_line":"    validate_cli_options()"},{"line_number":765,"context_line":"    return_val \u003d False"},{"line_number":766,"context_line":"    configs \u003d get_alembic_configs()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_04984177","line":763,"range":{"start_line":763,"start_character":4,"end_line":763,"end_character":27},"updated":"2016-03-23 14:56:55.000000000","message":"This line now emits:\n\n  No handlers could be found for logger \"oslo_config.cfg\"","commit_id":"8a15eb393dd7bec1890081fa69b48843090a33d3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"fd85e2d14c709d560d71619f748741710e942b12","unresolved":false,"context_lines":[{"line_number":760,"context_line":""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"def main():"},{"line_number":763,"context_line":"    CONF(project\u003d\u0027neutron\u0027)"},{"line_number":764,"context_line":"    validate_cli_options()"},{"line_number":765,"context_line":"    return_val \u003d False"},{"line_number":766,"context_line":"    configs \u003d get_alembic_configs()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_e66f12fa","line":763,"range":{"start_line":763,"start_character":4,"end_line":763,"end_character":27},"in_reply_to":"fa0719c6_04984177","updated":"2016-03-23 15:14:28.000000000","message":"See comment at line 65. No changes to main() needed.","commit_id":"8a15eb393dd7bec1890081fa69b48843090a33d3"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b6ca953e26d32fd0a97e8b16ec4f040c8aa381e7","unresolved":false,"context_lines":[{"line_number":760,"context_line":""},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"def main():"},{"line_number":763,"context_line":"    CONF(project\u003d\u0027neutron\u0027)"},{"line_number":764,"context_line":"    validate_cli_options()"},{"line_number":765,"context_line":"    return_val \u003d False"},{"line_number":766,"context_line":"    configs \u003d get_alembic_configs()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_6c6763b7","line":763,"range":{"start_line":763,"start_character":4,"end_line":763,"end_character":27},"in_reply_to":"fa0719c6_e66f12fa","updated":"2016-03-23 15:33:35.000000000","message":"Thanks Henry! Pushed https://review.openstack.org/#/c/296542/.","commit_id":"8a15eb393dd7bec1890081fa69b48843090a33d3"}],"neutron/tests/base.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f4c1cfc06098ac2cbaeecf2cb14db6dceb5e4e5f","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def setup_test_logging(config_opts, log_dir, log_file_path_template):"},{"line_number":104,"context_line":"    # Have each test log into its own log file"},{"line_number":105,"context_line":"    config_opts.set_override(\u0027debug\u0027, True)"},{"line_number":106,"context_line":"    utils.ensure_dir(log_dir)"},{"line_number":107,"context_line":"    log_file \u003d sanitize_log_path("},{"line_number":108,"context_line":"        os.path.join(log_dir, log_file_path_template))"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa0719c6_d4bc2a08","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":43},"updated":"2016-03-23 18:49:28.000000000","message":"Should we just set it to True at [1]?\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/etc/neutron.conf#L6","commit_id":"8603ea63402da847fc446d91c5ccbc01f329e88b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ea8517ac6c47e2ad8c83e7f8e38b6a5e0ac3eabd","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def setup_test_logging(config_opts, log_dir, log_file_path_template):"},{"line_number":104,"context_line":"    # Have each test log into its own log file"},{"line_number":105,"context_line":"    config_opts.set_override(\u0027debug\u0027, True)"},{"line_number":106,"context_line":"    utils.ensure_dir(log_dir)"},{"line_number":107,"context_line":"    log_file \u003d sanitize_log_path("},{"line_number":108,"context_line":"        os.path.join(log_dir, log_file_path_template))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da0c15f0_69a67f54","line":105,"range":{"start_line":105,"start_character":4,"end_line":105,"end_character":43},"in_reply_to":"fa0719c6_d4bc2a08","updated":"2016-03-27 23:45:56.000000000","message":"it would affect all tests instead of fullstack/functional ones","commit_id":"8603ea63402da847fc446d91c5ccbc01f329e88b"}]}