)]}'
{"quantum/agent/linux/dhcp.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"27b8494ff52cb0beaf48050e2f9872b404c6e63f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        try:"},{"line_number":235,"context_line":"            cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":236,"context_line":"            out \u003d utils.execute(cmd)"},{"line_number":237,"context_line":"            ver \u003d re.findall(\"\\d+.\\d+\", out)[0]"},{"line_number":238,"context_line":"            is_valid_version \u003d float(ver) \u003e\u003d cls.MINIMUM_VERSION"},{"line_number":239,"context_line":"            if not is_valid_version:"},{"line_number":240,"context_line":"                LOG.warning(_(\u0027FAILED VERSION REQUIREMENT FOR DNSMASQ. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F6S4%3D","line":237,"updated":"2013-05-20 14:40:50.000000000","message":"Since \u0027.\u0027 in regular expression matches any character, it is better to change \u0027.\u0027 to \u0027\\.\u0027 (with backslash) to ensure a major/minor version separator (though the current regexp works)","commit_id":"120c166a4f483d5e52d4178ba155eee01c22769a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"ad81db01bf7e5eece67b07e1e84b07ba35e39241","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        try:"},{"line_number":235,"context_line":"            cmd \u003d [\u0027dnsmasq\u0027, \u0027--version\u0027]"},{"line_number":236,"context_line":"            out \u003d utils.execute(cmd)"},{"line_number":237,"context_line":"            ver \u003d re.findall(\"\\d+.\\d+\", out)[0]"},{"line_number":238,"context_line":"            is_valid_version \u003d float(ver) \u003e\u003d cls.MINIMUM_VERSION"},{"line_number":239,"context_line":"            if not is_valid_version:"},{"line_number":240,"context_line":"                LOG.warning(_(\u0027FAILED VERSION REQUIREMENT FOR DNSMASQ. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F1lQ%3D","line":237,"in_reply_to":"AAAAPH%2F%2F6S4%3D","updated":"2013-05-22 00:07:39.000000000","message":"Escaping the dot is the most correct way.  At worst this matches 2x9 or 2#4 or similar and then the float conversion will throw a ValueError resulting in the same result as if the dot was escaped.  I think we should merge and we can propose a fix to master later to tighten the matching up a bit.","commit_id":"120c166a4f483d5e52d4178ba155eee01c22769a"}]}