)]}'
{"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"adcd918a4701cbdd88c59add52d703cc4f722c0f","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                ports_scopemark[ip_version].update("},{"line_number":232,"context_line":"                    external_port_scopemark[ip_version])"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not self.snat_iptables_manager:"},{"line_number":235,"context_line":"            LOG.debug(\"DVR router: no snat rules to be handled\")"},{"line_number":236,"context_line":"            return"},{"line_number":237,"context_line":"        with self.snat_iptables_manager.defer_apply():"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_55fae275","line":234,"range":{"start_line":234,"start_character":41,"end_line":234,"end_character":42},"updated":"2016-03-23 16:07:36.000000000","message":"can we do this check at L#220 and maitain the state.\nBecause, if there is not gateway then the internal_ports at L#221 will also return empty.","commit_id":"372934252b6581245a6d68af3abe0b5c494a945a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"af0316771481b7d162b3aa9c22b7834b2982d2a8","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                ports_scopemark[ip_version].update("},{"line_number":232,"context_line":"                    external_port_scopemark[ip_version])"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        if not self.snat_iptables_manager:"},{"line_number":235,"context_line":"            LOG.debug(\"DVR router: no snat rules to be handled\")"},{"line_number":236,"context_line":"            return"},{"line_number":237,"context_line":"        with self.snat_iptables_manager.defer_apply():"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_60fac276","line":234,"range":{"start_line":234,"start_character":41,"end_line":234,"end_character":42},"in_reply_to":"fa0719c6_55fae275","updated":"2016-03-23 16:19:32.000000000","message":"Done","commit_id":"372934252b6581245a6d68af3abe0b5c494a945a"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"348c83fb04f5991ad5ebe90163a64213732bd801","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        self._setup_dvr_ha_bridges()"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        router1 \u003d self._create_dvr_ha_router(self.agent, enable_gw\u003denable_gw)"},{"line_number":704,"context_line":"        router2 \u003d self._create_dvr_ha_router(self.failover_agent, enable_gw)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        utils.wait_until_true(lambda: router1.ha_state \u003d\u003d \u0027master\u0027)"},{"line_number":707,"context_line":"        utils.wait_until_true(lambda: router2.ha_state \u003d\u003d \u0027backup\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_70d9f121","line":704,"range":{"start_line":704,"start_character":66,"end_line":704,"end_character":75},"updated":"2016-03-23 17:05:43.000000000","message":"This is inconsistent with the above line and should be fixed if there\u0027s a new revision.","commit_id":"a8b60671150ac383c6ed24c26e773a97a476f7d2"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3f23d3690be82a479839978fea64ef4e65363f85","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        self._setup_dvr_ha_bridges()"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"        router1 \u003d self._create_dvr_ha_router(self.agent, enable_gw\u003denable_gw)"},{"line_number":704,"context_line":"        router2 \u003d self._create_dvr_ha_router(self.failover_agent, enable_gw)"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        utils.wait_until_true(lambda: router1.ha_state \u003d\u003d \u0027master\u0027)"},{"line_number":707,"context_line":"        utils.wait_until_true(lambda: router2.ha_state \u003d\u003d \u0027backup\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_d06f1dfa","line":704,"range":{"start_line":704,"start_character":66,"end_line":704,"end_character":75},"in_reply_to":"fa0719c6_70d9f121","updated":"2016-03-23 17:08:14.000000000","message":"May be we can fix it later.","commit_id":"a8b60671150ac383c6ed24c26e773a97a476f7d2"}]}