)]}'
{"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"799309c61891a0db246a7f926379df72aac2194f","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            os.remove(pid_file)"},{"line_number":374,"context_line":"        except OSError as e:"},{"line_number":375,"context_line":"            if e.errno !\u003d errno.ENOENT:"},{"line_number":376,"context_line":"                LOG.warning(_LW(\"Could not delete file %s, keepalived can \""},{"line_number":377,"context_line":"                                \"refuse to start.\"), pid_file)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def get_vrrp_pid_file_name(self, base_pid_file):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_60acc834","line":376,"updated":"2016-03-28 09:06:13.000000000","message":"This sounds like an error condition instead of just warning. Can you think of a reason this would happen normally? If not, upgrade it to LOG.error.","commit_id":"be312bd4f5ead886435dc4d101b30e4c359f4ab8"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"61de2afee8671b70d225707a503df25ec98680cb","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            os.remove(pid_file)"},{"line_number":374,"context_line":"        except OSError as e:"},{"line_number":375,"context_line":"            if e.errno !\u003d errno.ENOENT:"},{"line_number":376,"context_line":"                LOG.warning(_LW(\"Could not delete file %s, keepalived can \""},{"line_number":377,"context_line":"                                \"refuse to start.\"), pid_file)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def get_vrrp_pid_file_name(self, base_pid_file):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_2c7e4719","line":376,"in_reply_to":"da0c15f0_60acc834","updated":"2016-03-28 10:32:51.000000000","message":"Right, sounds more like an error.","commit_id":"be312bd4f5ead886435dc4d101b30e4c359f4ab8"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"d718c12b1dc4fc7ebeed0b8e4aed3ea8559fa573","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            os.remove(pid_file)"},{"line_number":374,"context_line":"        except OSError as e:"},{"line_number":375,"context_line":"            if e.errno !\u003d errno.ENOENT:"},{"line_number":376,"context_line":"                LOG.warning(_LW(\"Could not delete file %s, keepalived can \""},{"line_number":377,"context_line":"                                \"refuse to start.\"), pid_file)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def get_vrrp_pid_file_name(self, base_pid_file):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_65b6df8b","line":376,"in_reply_to":"da0c15f0_60acc834","updated":"2016-03-29 06:24:37.000000000","message":"Thanks, will upgrade it to error","commit_id":"be312bd4f5ead886435dc4d101b30e4c359f4ab8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9937f8c6e9f7fd2d53e9d6e5222d412e4ff562f9","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            os.remove(pid_file)"},{"line_number":374,"context_line":"        except OSError as e:"},{"line_number":375,"context_line":"            if e.errno !\u003d errno.ENOENT:"},{"line_number":376,"context_line":"                LOG.error(_LE(\"Could not delete file %s, keepalived can \""},{"line_number":377,"context_line":"                              \"refuse to start.\"), pid_file)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def get_vrrp_pid_file_name(self, base_pid_file):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_4865ab43","line":376,"updated":"2016-03-29 09:16:10.000000000","message":"can it be convinced to start?","commit_id":"e98fabb5836b12bc40a2b64a2668893ea73c2320"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b82f850eb7c94dd18582483c0d0e781db33b373c","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            os.remove(pid_file)"},{"line_number":374,"context_line":"        except OSError as e:"},{"line_number":375,"context_line":"            if e.errno !\u003d errno.ENOENT:"},{"line_number":376,"context_line":"                LOG.error(_LE(\"Could not delete file %s, keepalived can \""},{"line_number":377,"context_line":"                              \"refuse to start.\"), pid_file)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def get_vrrp_pid_file_name(self, base_pid_file):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_51bb8f72","line":376,"in_reply_to":"ba0121b8_2859575b","updated":"2016-03-29 11:19:22.000000000","message":"It seems that we can\u0027t do it.. :/","commit_id":"e98fabb5836b12bc40a2b64a2668893ea73c2320"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"f692a2891575e606060faab3af7612b13ba84a5c","unresolved":false,"context_lines":[{"line_number":373,"context_line":"            os.remove(pid_file)"},{"line_number":374,"context_line":"        except OSError as e:"},{"line_number":375,"context_line":"            if e.errno !\u003d errno.ENOENT:"},{"line_number":376,"context_line":"                LOG.error(_LE(\"Could not delete file %s, keepalived can \""},{"line_number":377,"context_line":"                              \"refuse to start.\"), pid_file)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def get_vrrp_pid_file_name(self, base_pid_file):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_2859575b","line":376,"in_reply_to":"ba0121b8_4865ab43","updated":"2016-03-29 09:18:45.000000000","message":"I don\u0027t think so, I was unable to find such an option to keepalived. Suggestions are welcome :-)","commit_id":"e98fabb5836b12bc40a2b64a2668893ea73c2320"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"bcddbddc60123a524d74dd1fe6d711e28157e64b","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        keepalived_pm.default_cmd_callback \u003d ("},{"line_number":399,"context_line":"            self._get_keepalived_process_callback(vrrp_pm, config_path))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        keepalived_pm.enable(reload_cfg\u003dTrue)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.process_monitor.register(uuid\u003dself.resource_id,"},{"line_number":404,"context_line":"                                      service_name\u003dKEEPALIVED_SERVICE_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_a9b449f2","line":401,"updated":"2016-03-29 09:59:50.000000000","message":"https://github.com/openstack/neutron/blob/master/neutron/agent/linux/external_process.py#L88\nMay be we can enhance \"def enable\" to remove pid files before running execute\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/linux/external_process.py#L91\n\nBut that should be a separate change and shouldn\u0027t block this patch :)","commit_id":"e98fabb5836b12bc40a2b64a2668893ea73c2320"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b82f850eb7c94dd18582483c0d0e781db33b373c","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        keepalived_pm.default_cmd_callback \u003d ("},{"line_number":399,"context_line":"            self._get_keepalived_process_callback(vrrp_pm, config_path))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        keepalived_pm.enable(reload_cfg\u003dTrue)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.process_monitor.register(uuid\u003dself.resource_id,"},{"line_number":404,"context_line":"                                      service_name\u003dKEEPALIVED_SERVICE_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_d155df1d","line":401,"in_reply_to":"ba0121b8_a9b449f2","updated":"2016-03-29 11:19:22.000000000","message":"The issue is that this is keepalived_pm and not vrrp_pm which is the problematic one.\n\nIt\u0027s very weird by keepalive to have such design with separate pid files we end up needing to watch, I hope it won\u0027t be common, if it becomes common I\u0027d also expect a more general solution.","commit_id":"e98fabb5836b12bc40a2b64a2668893ea73c2320"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"766349ca82ebf4c0892a1268921505c75e3fe4c1","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        keepalived_pm.default_cmd_callback \u003d ("},{"line_number":399,"context_line":"            self._get_keepalived_process_callback(vrrp_pm, config_path))"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        keepalived_pm.enable(reload_cfg\u003dTrue)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.process_monitor.register(uuid\u003dself.resource_id,"},{"line_number":404,"context_line":"                                      service_name\u003dKEEPALIVED_SERVICE_NAME,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_a592a555","line":401,"in_reply_to":"ba0121b8_d155df1d","updated":"2016-03-29 12:18:45.000000000","message":"Yes. May be RFE bug to enhance external_process to take care of these scenarios i.e if a process spawns child processes like this.","commit_id":"e98fabb5836b12bc40a2b64a2668893ea73c2320"}],"neutron/tests/functional/agent/linux/test_keepalived.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f1799fff6c543f06b930e3ccf774d66988557205","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # existing non-keepalived process. This situation can happen e.g."},{"line_number":87,"context_line":"        # after hard node reset."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        spawnProcess \u003d SleepyProcessFixture()"},{"line_number":90,"context_line":"        self.useFixture(spawnProcess)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        with open(pid_file, \"w\") as f_pid_file:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_9da227ad","line":89,"updated":"2016-03-28 08:24:18.000000000","message":"meganit: spawn_process","commit_id":"be312bd4f5ead886435dc4d101b30e4c359f4ab8"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"d718c12b1dc4fc7ebeed0b8e4aed3ea8559fa573","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # existing non-keepalived process. This situation can happen e.g."},{"line_number":87,"context_line":"        # after hard node reset."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        spawnProcess \u003d SleepyProcessFixture()"},{"line_number":90,"context_line":"        self.useFixture(spawnProcess)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        with open(pid_file, \"w\") as f_pid_file:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_254a2784","line":89,"in_reply_to":"da0c15f0_9da227ad","updated":"2016-03-29 06:24:37.000000000","message":"microdone :-)","commit_id":"be312bd4f5ead886435dc4d101b30e4c359f4ab8"}]}
