)]}'
{"neutron/db/providernet_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"36e13529c95fd54470021e096f0bf2da9b8b52e5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    segmentation_id \u003d sa.Column(sa.Integer)"},{"line_number":53,"context_line":"    is_dynamic \u003d sa.Column(sa.Boolean, default\u003dFalse, nullable\u003dFalse,"},{"line_number":54,"context_line":"                           server_default\u003dsa.sql.false())"},{"line_number":55,"context_line":"    segment_index \u003d sa.Column(sa.Integer, nullable\u003dFalse, server_default\u003d\u00270\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"NETWORK_TYPE \u003d NetworkSegment.network_type.name"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_0dda1ee8","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":17},"updated":"2016-03-23 16:50:13.000000000","message":"What is this thing?  How should it be handled in SegmentDbMixin?","commit_id":"099e1cebe5ce67e666cbaf062fc1f0ba6f84cc3c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"36e13529c95fd54470021e096f0bf2da9b8b52e5","unresolved":false,"context_lines":[{"line_number":151,"context_line":"         filter_by(id\u003dsegment_id).delete())"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class SegmentDbMixin(ext_segment.SegmentPluginBase):"},{"line_number":155,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _make_segment_dict(self, segment_db, fields\u003dNone, context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_8dcd8e33","line":154,"range":{"start_line":154,"start_character":6,"end_line":154,"end_character":20},"updated":"2016-03-23 16:50:13.000000000","message":"This class duplicates some of the code in the methods above.  I tend to think that this should be reconciled and hopefully share code.  It wasn\u0027t totally obvious to me how that should be done so it needs to be revisited.  Thoughts?","commit_id":"099e1cebe5ce67e666cbaf062fc1f0ba6f84cc3c"}],"neutron/db/segments_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"155e8c9f734e52ae05072c21b8841a3e563d3f5d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               \u0027segmentation_id\u0027: segment_db[SEGMENTATION_ID]}"},{"line_number":159,"context_line":"        return self._fields(res, fields)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _get_segment(self, context, id):"},{"line_number":162,"context_line":"        try:"},{"line_number":163,"context_line":"            return self._get_by_id(context, NetworkSegment, id)"},{"line_number":164,"context_line":"        except exc.NoResultFound:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_c8b9adeb","line":161,"updated":"2016-04-05 00:17:22.000000000","message":"I wish we stopped shadowing id() :(","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"032435ba9350e912970160d18f8844ac4d65c5e4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"               \u0027segmentation_id\u0027: segment_db[SEGMENTATION_ID]}"},{"line_number":159,"context_line":"        return self._fields(res, fields)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _get_segment(self, context, id):"},{"line_number":162,"context_line":"        try:"},{"line_number":163,"context_line":"            return self._get_by_id(context, NetworkSegment, id)"},{"line_number":164,"context_line":"        except exc.NoResultFound:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_7003ff42","line":161,"in_reply_to":"9a061dce_c8b9adeb","updated":"2016-04-05 16:31:18.000000000","message":"Done.  I totally agree with you but this method started as a cut/paste from something else I was looking at and I failed to notice that I should fix this.  :(","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"155e8c9f734e52ae05072c21b8841a3e563d3f5d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def delete_segment(self, context, uuid):"},{"line_number":226,"context_line":"        \"\"\"Delete an existing segment.\"\"\""},{"line_number":227,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":228,"context_line":"            segment_db \u003d self._get_segment(context, uuid)"},{"line_number":229,"context_line":"            context.session.delete(segment_db)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_88bfb5cf","line":228,"updated":"2016-04-05 00:17:22.000000000","message":"if we don\u0027t need to enforce quota on this can we simply issue a delete instead?","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"032435ba9350e912970160d18f8844ac4d65c5e4","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    def delete_segment(self, context, uuid):"},{"line_number":226,"context_line":"        \"\"\"Delete an existing segment.\"\"\""},{"line_number":227,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":228,"context_line":"            segment_db \u003d self._get_segment(context, uuid)"},{"line_number":229,"context_line":"            context.session.delete(segment_db)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_f3a1d9aa","line":228,"in_reply_to":"9a061dce_88bfb5cf","updated":"2016-04-05 16:31:18.000000000","message":"Good feedback.","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"50d0cd2b05d0b090b3e06abdf32bc39254f86168","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    segment_index \u003d sa.Column(sa.Integer, nullable\u003dFalse, server_default\u003d\u00270\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"NETWORK_TYPE \u003d NetworkSegment.network_type.name"},{"line_number":55,"context_line":"PHYSICAL_NETWORK \u003d NetworkSegment.physical_network.name"},{"line_number":56,"context_line":"SEGMENTATION_ID \u003d NetworkSegment.segmentation_id.name"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _make_segment_dict(record):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a061dce_49335f62","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":53},"updated":"2016-04-07 04:17:13.000000000","message":"I see the same const are added in the extension file. Can we eliminate the duplication here or there?","commit_id":"8b5c0dac13f7732f969cf64512d1606d3de1e6c4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"27efe828cf2a2bf5c9708fda9f71107bde5ee00d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    segment_index \u003d sa.Column(sa.Integer, nullable\u003dFalse, server_default\u003d\u00270\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"NETWORK_TYPE \u003d NetworkSegment.network_type.name"},{"line_number":55,"context_line":"PHYSICAL_NETWORK \u003d NetworkSegment.physical_network.name"},{"line_number":56,"context_line":"SEGMENTATION_ID \u003d NetworkSegment.segmentation_id.name"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _make_segment_dict(record):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_73fe5c38","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":53},"in_reply_to":"9a061dce_49335f62","updated":"2016-04-18 20:21:28.000000000","message":"These constants capture the name of the database columns without duplicating the hard-coded values.  They are just convenience definitions.  \n\nThe extension defines the names of the attributes from the API\u0027s perspective.  They are two different things that happen to have the same values but don\u0027t necessarily have to be tied together.\n\nI think there are a few ways we could avoid this \"duplication\".  In my mind, all of them seem unnatural and don\u0027t really improve anything.  I\u0027m fine just having two sets of constants that happen to have the same values but are meant for different contexts.\n\n1) Force the column names in L46-L48 to be the same as what the extension defines.  I think that would make the table definition look pretty unnatural.\n2) Define some common constants in a third file and import it both here and in the extension file.  To me, that just isn\u0027t worth it.","commit_id":"8b5c0dac13f7732f969cf64512d1606d3de1e6c4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a09446a12f53a609c3d641d54ff19dc98fbeaa03","unresolved":false,"context_lines":[{"line_number":150,"context_line":"class SegmentDbMixin(ext_segment.SegmentPluginBase):"},{"line_number":151,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _make_segment_dict(self, segment_db, fields\u003dNone, context\u003dNone):"},{"line_number":154,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":155,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":156,"context_line":"               \u0027physical_network\u0027: segment_db[PHYSICAL_NETWORK],"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a061dce_de539e15","line":153,"range":{"start_line":153,"start_character":58,"end_line":153,"end_character":65},"updated":"2016-04-07 10:40:45.000000000","message":"The context isn\u0027t used in this method, right?","commit_id":"8b5c0dac13f7732f969cf64512d1606d3de1e6c4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3d9c3b32a90a1c20c8b21ccd1c274099abf7556b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"class SegmentDbMixin(ext_segment.SegmentPluginBase):"},{"line_number":151,"context_line":"    \"\"\"Mixin class to add segment.\"\"\""},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _make_segment_dict(self, segment_db, fields\u003dNone, context\u003dNone):"},{"line_number":154,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":155,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":156,"context_line":"               \u0027physical_network\u0027: segment_db[PHYSICAL_NETWORK],"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_f3454c70","line":153,"range":{"start_line":153,"start_character":58,"end_line":153,"end_character":65},"in_reply_to":"9a061dce_de539e15","updated":"2016-04-18 20:25:27.000000000","message":"Sorry, I missed this before.  You\u0027re right.","commit_id":"8b5c0dac13f7732f969cf64512d1606d3de1e6c4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"50d0cd2b05d0b090b3e06abdf32bc39254f86168","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def _make_segment_dict(self, segment_db, fields\u003dNone, context\u003dNone):"},{"line_number":154,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":155,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":156,"context_line":"               \u0027physical_network\u0027: segment_db[PHYSICAL_NETWORK],"},{"line_number":157,"context_line":"               \u0027network_type\u0027: segment_db[NETWORK_TYPE],"},{"line_number":158,"context_line":"               \u0027segmentation_id\u0027: segment_db[SEGMENTATION_ID]}"},{"line_number":159,"context_line":"        return self._fields(res, fields)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _get_segment(self, context, segment_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a061dce_09c96726","line":158,"range":{"start_line":156,"start_character":0,"end_line":158,"end_character":62},"updated":"2016-04-07 04:17:13.000000000","message":"Maybe better with the const as the keys, since there are defined.","commit_id":"8b5c0dac13f7732f969cf64512d1606d3de1e6c4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3d9c3b32a90a1c20c8b21ccd1c274099abf7556b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def _make_segment_dict(self, segment_db, fields\u003dNone, context\u003dNone):"},{"line_number":154,"context_line":"        res \u003d {\u0027id\u0027: segment_db[\u0027id\u0027],"},{"line_number":155,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":156,"context_line":"               \u0027physical_network\u0027: segment_db[PHYSICAL_NETWORK],"},{"line_number":157,"context_line":"               \u0027network_type\u0027: segment_db[NETWORK_TYPE],"},{"line_number":158,"context_line":"               \u0027segmentation_id\u0027: segment_db[SEGMENTATION_ID]}"},{"line_number":159,"context_line":"        return self._fields(res, fields)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def _get_segment(self, context, segment_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_d33f70d4","line":158,"range":{"start_line":156,"start_character":0,"end_line":158,"end_character":62},"in_reply_to":"9a061dce_09c96726","updated":"2016-04-18 20:25:27.000000000","message":"Done","commit_id":"8b5c0dac13f7732f969cf64512d1606d3de1e6c4"}],"neutron/extensions/segment.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"36e13529c95fd54470021e096f0bf2da9b8b52e5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                          \u0027allow_put\u0027: False,"},{"line_number":66,"context_line":"                          \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":67,"context_line":"                          \u0027convert_to\u0027: attributes.convert_to_int,"},{"line_number":68,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"    },"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_ed324a5d","line":68,"updated":"2016-03-23 16:50:13.000000000","message":"What about is_dynamic?  Do we need to expose that through the API?","commit_id":"099e1cebe5ce67e666cbaf062fc1f0ba6f84cc3c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8e51b006fe79db2fb07ae5b5e9b4f754344efaf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":31,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# TODO(carl_baldwin) I\u0027m not sure what to do with tenant_id.  Apparently, it is"},{"line_number":34,"context_line":"# required for something but I\u0027m honestly not sure what.  I think that the"},{"line_number":35,"context_line":"# tenant_id for a segment should be the same as that of the network.  So, it"},{"line_number":36,"context_line":"# seems silly to store it in the DB (and that would require a migration)."}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_a6ea780d","line":33,"updated":"2016-03-28 09:35:45.000000000","message":"The policy engine is the one that requires it IIRC. We can either leave it to be consitent with everything else in the API and just pull the network tenant_id, or you could dig in to see why the policy engine demands it.","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"31b167cddc4f6e6f4c0e08e443703991f4358b4e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":31,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# TODO(carl_baldwin) I\u0027m not sure what to do with tenant_id.  Apparently, it is"},{"line_number":34,"context_line":"# required for something but I\u0027m honestly not sure what.  I think that the"},{"line_number":35,"context_line":"# tenant_id for a segment should be the same as that of the network.  So, it"},{"line_number":36,"context_line":"# seems silly to store it in the DB (and that would require a migration)."}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_2b5f440f","line":33,"in_reply_to":"da0c15f0_a6ea780d","updated":"2016-03-28 16:44:35.000000000","message":"If making it visible through the API is needed, then I think I\u0027ll just pull the network\u0027s tenant_id (I think could be done as low-hanging fruit in a follow-on).  As it is currently specified, it can\u0027t be viewed through the API.\n\nIt is allowed to be specified in POST.  At that point, it should probably be checking against the existing network_id\u0027s tenant id to be sure it matches (unless we just don\u0027t care because only admin can make the call anyway).  But, I don\u0027t think we need to do that in this patch either.  Do you?","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8e51b006fe79db2fb07ae5b5e9b4f754344efaf","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":56,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":57,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":58,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":59,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":60,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":61,"context_line":"                       \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_86edb427","line":58,"updated":"2016-03-28 09:35:45.000000000","message":"limit to PHYSICAL_NETWORK_MAX_LEN","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"31b167cddc4f6e6f4c0e08e443703991f4358b4e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":56,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":57,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":58,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":59,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":60,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":61,"context_line":"                       \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_f0fedd36","line":58,"in_reply_to":"da0c15f0_86edb427","updated":"2016-03-28 16:44:35.000000000","message":"Done","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8e51b006fe79db2fb07ae5b5e9b4f754344efaf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":60,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":61,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":62,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":63,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":64,"context_line":"        SEGMENTATION_ID: {\u0027allow_post\u0027: True,"},{"line_number":65,"context_line":"                          \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_e6f470f3","line":62,"updated":"2016-03-28 09:35:45.000000000","message":"need to limit to NETWORK_TYPE_MAX_LEN in extensions.providernet","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"31b167cddc4f6e6f4c0e08e443703991f4358b4e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":60,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":61,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":62,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027: None},"},{"line_number":63,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":64,"context_line":"        SEGMENTATION_ID: {\u0027allow_post\u0027: True,"},{"line_number":65,"context_line":"                          \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_108b91c4","line":62,"in_reply_to":"da0c15f0_e6f470f3","updated":"2016-03-28 16:44:35.000000000","message":"Done","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8e51b006fe79db2fb07ae5b5e9b4f754344efaf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":64,"context_line":"        SEGMENTATION_ID: {\u0027allow_post\u0027: True,"},{"line_number":65,"context_line":"                          \u0027allow_put\u0027: False,"},{"line_number":66,"context_line":"                          \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":67,"context_line":"                          \u0027convert_to\u0027: attributes.convert_to_int,"},{"line_number":68,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_c6f7acf3","line":66,"updated":"2016-03-28 09:35:45.000000000","message":"This \u0027non_negative\u0027 probably shouldn\u0027t be here. Some wonky type driver might allow negative segmentation IDs and it would work with the current create_network API because we don\u0027t enforce non_negative.","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"31b167cddc4f6e6f4c0e08e443703991f4358b4e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":64,"context_line":"        SEGMENTATION_ID: {\u0027allow_post\u0027: True,"},{"line_number":65,"context_line":"                          \u0027allow_put\u0027: False,"},{"line_number":66,"context_line":"                          \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":67,"context_line":"                          \u0027convert_to\u0027: attributes.convert_to_int,"},{"line_number":68,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":69,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_102711cb","line":66,"in_reply_to":"da0c15f0_c6f7acf3","updated":"2016-03-28 16:44:35.000000000","message":"Really, what are the chances?  Do you actually know of such a wonky type driver?\n\nYour point is good, though.  This validation should match the provider net validation regardless.","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"861b9e723a9cfdea77b1c9cd518c134c2a62b95f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                      \u0027is_visible\u0027: False},"},{"line_number":53,"context_line":"        \u0027network_id\u0027: {\u0027allow_post\u0027: True,"},{"line_number":54,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":55,"context_line":"                       \u0027default\u0027: None,"},{"line_number":56,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":58,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_e80a7b20","line":55,"range":{"start_line":55,"start_character":24,"end_line":55,"end_character":31},"updated":"2016-04-18 19:29:15.000000000","message":"I\u0027m not sure why I have a default of None for network_id.  It is a required attribute and None doesn\u0027t work.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"96799bfecd437f1ee2a81ac8dafa310b8b086e43","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027default\u0027: None,"},{"line_number":56,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":58,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":59,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_b80b71d5","line":58,"updated":"2016-04-06 19:51:09.000000000","message":"Should this have a default value or is it required regardless of the network type?","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"180ae2ee2647fd9e2db35dcc7c3f5f2efaa64042","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027default\u0027: None,"},{"line_number":56,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":58,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":59,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a1b2928_37e360a5","line":58,"in_reply_to":"7a1b2928_3701a0af","updated":"2016-04-11 19:42:35.000000000","message":"Thank you Carl.  I\u0027ll update my CLI patch sets accordingly.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"5511e7c73e2454091ad48563f02934c044e7697d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027default\u0027: None,"},{"line_number":56,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":58,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":59,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_9523aabc","line":58,"in_reply_to":"9a061dce_011da465","updated":"2016-04-07 14:03:36.000000000","message":"I tend to agree with Richard here. For example, now in the ML2, the physical_network must be unspecified for tunnel network type. I added the default value of \"attributes.ATTR_NOT_SPECIFIED\" to avoid user to specify blank value in such case when work on [1]\n\n[1] https://review.openstack.org/#/c/284440","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"acec9b61c7d4727d956b6aa20644b00c3f8f8963","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027default\u0027: None,"},{"line_number":56,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":58,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":59,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a1b2928_3701a0af","line":58,"in_reply_to":"9a061dce_9523aabc","updated":"2016-04-11 19:35:15.000000000","message":"I\u0027ll change it to default ATTR_NOT_SPECIFIED for this case.  That makes sense for this case because @xiaohhui is correct that it must not be specified for some network types.   I guess I thought that the unspecified value was implicit, if the client didn\u0027t specify a value then you got unspecified as the value but that probably isn\u0027t how it works.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"92d31baf13fe30cad5841b23ac107d3cd259b498","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027default\u0027: None,"},{"line_number":56,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":58,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":59,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_c0bd8b69","line":58,"in_reply_to":"9a061dce_b80b71d5","updated":"2016-04-06 21:57:57.000000000","message":"No, there is no default.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"498d50f9ea9594918ae65ad799e3de4b78ffd935","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                       \u0027default\u0027: None,"},{"line_number":56,"context_line":"                       \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":57,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":58,"context_line":"        PHYSICAL_NETWORK: {\u0027allow_post\u0027: True,"},{"line_number":59,"context_line":"                           \u0027allow_put\u0027: False,"},{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_011da465","line":58,"in_reply_to":"9a061dce_c0bd8b69","updated":"2016-04-07 13:00:54.000000000","message":"Hi Carl, I understand no default, but want to avoid the situation where callers are required to pass a blank value to satisfy the API/CLI even though the plugin implementation doesn\u0027t require a value.  Will this happen inside the plugin too?  Similar question for segmentation ID as well.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"96799bfecd437f1ee2a81ac8dafa310b8b086e43","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":62,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":63,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":64,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_584df53c","line":63,"updated":"2016-04-06 19:51:09.000000000","message":"Will the network type be validated against a set of choices?  If so, what are the choices (i.e. flat, vlan, vxlan, gre)?","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"5511e7c73e2454091ad48563f02934c044e7697d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":62,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":63,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":64,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_7056e406","line":63,"in_reply_to":"9a061dce_21ef081f","updated":"2016-04-07 14:03:36.000000000","message":"I don\u0027t think there will be a set of network types , if the network type is not supported by the plugin, an exception should be thrown out.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"92d31baf13fe30cad5841b23ac107d3cd259b498","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":62,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":63,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":64,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_60a59f45","line":63,"in_reply_to":"9a061dce_584df53c","updated":"2016-04-06 21:57:57.000000000","message":"This will actually happen inside the plugin.  Look for this in plugin implementations because it is implementation dependent.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"498d50f9ea9594918ae65ad799e3de4b78ffd935","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":62,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":63,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":64,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_21ef081f","line":63,"in_reply_to":"9a061dce_60a59f45","updated":"2016-04-07 13:00:54.000000000","message":"Thanks Carl.  Is there a superset of network types that the CLI can check when parsing the network type argument?","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"00068c6065bbd6f99ce3a732a20b4066aa788627","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                           \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":61,"context_line":"                                        providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":62,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":63,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True,"},{"line_number":64,"context_line":"                       \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_ade662e5","line":63,"in_reply_to":"9a061dce_7056e406","updated":"2016-04-07 15:04:19.000000000","message":"I\u0027m not suggesting any validation here, I\u0027m just wondering if I should provide a superset of choices at the CLI level which will ultimately be validated by the plugin.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"96799bfecd437f1ee2a81ac8dafa310b8b086e43","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":67,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":68,"context_line":"        SEGMENTATION_ID: {\u0027allow_post\u0027: True,"},{"line_number":69,"context_line":"                          \u0027allow_put\u0027: False,"},{"line_number":70,"context_line":"                          \u0027convert_to\u0027: attributes.convert_to_int,"},{"line_number":71,"context_line":"                          \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_d80625cd","line":68,"updated":"2016-04-06 19:51:09.000000000","message":"Should this have a default value or is it required regardless of the network type?","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"acec9b61c7d4727d956b6aa20644b00c3f8f8963","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":67,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":68,"context_line":"        SEGMENTATION_ID: {\u0027allow_post\u0027: True,"},{"line_number":69,"context_line":"                          \u0027allow_put\u0027: False,"},{"line_number":70,"context_line":"                          \u0027convert_to\u0027: attributes.convert_to_int,"},{"line_number":71,"context_line":"                          \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a1b2928_f7cba870","line":68,"in_reply_to":"9a061dce_006b03f2","updated":"2016-04-11 19:35:15.000000000","message":"I guess this could default to unspecified too given the discussion on L58.","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"92d31baf13fe30cad5841b23ac107d3cd259b498","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                       \u0027validate\u0027: {\u0027type:string\u0027:"},{"line_number":66,"context_line":"                                    providernet.PHYSICAL_NETWORK_MAX_LEN},"},{"line_number":67,"context_line":"                       \u0027is_visible\u0027: True},"},{"line_number":68,"context_line":"        SEGMENTATION_ID: {\u0027allow_post\u0027: True,"},{"line_number":69,"context_line":"                          \u0027allow_put\u0027: False,"},{"line_number":70,"context_line":"                          \u0027convert_to\u0027: attributes.convert_to_int,"},{"line_number":71,"context_line":"                          \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_006b03f2","line":68,"in_reply_to":"9a061dce_d80625cd","updated":"2016-04-06 21:57:57.000000000","message":"No default!","commit_id":"6e942f6d1cd35e01b5211b06191ee166e5010140"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a58e42f2c41b3228204230d7baf32610ff640f50","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# required for something but I\u0027m honestly not sure what.  I think that the"},{"line_number":34,"context_line":"# tenant_id for a segment should be the same as that of the network.  So, it"},{"line_number":35,"context_line":"# seems silly to store it in the DB (and that would require a migration)."},{"line_number":36,"context_line":"# Should it be visible through the API at all?"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Attribute Map"},{"line_number":39,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_3a8cf934","line":36,"updated":"2016-04-21 23:16:19.000000000","message":"i think even if you don\u0027t define it here, the API code will still require it.  It\u0027s weird to say that I know but I ran into it the other day when messing with a new extension.  Obviously that code can change if needed, but just throwing it out here.\n\nI do feel like not providing tenant_id would be very inconsistent with the rest of the resources so I think treating like the other top level resources makes sense.  Although I wouldn\u0027t mind it autoassigning the network\u0027s tenant_id either, but that might get tricky if tenant_id HAS to be defined in this schema.","commit_id":"211f4fad39712b17b17e23d41ee1b0451da52f2b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0e0c65681202cb7ff895ad247c6bd7d75db9a51f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# required for something but I\u0027m honestly not sure what.  I think that the"},{"line_number":34,"context_line":"# tenant_id for a segment should be the same as that of the network.  So, it"},{"line_number":35,"context_line":"# seems silly to store it in the DB (and that would require a migration)."},{"line_number":36,"context_line":"# Should it be visible through the API at all?"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Attribute Map"},{"line_number":39,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_e6678ce8","line":36,"in_reply_to":"1a122d0e_3a8cf934","updated":"2016-04-22 02:45:00.000000000","message":"Did a patch to allow this to not have tenant_id in case it is wanted.  Put it up for discussion.\n\nhttps://review.openstack.org/#/c/309235","commit_id":"211f4fad39712b17b17e23d41ee1b0451da52f2b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"415ffc2c476a55a33ecfae7ef25912ff7dece34c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        controller \u003d base.create_resource("},{"line_number":94,"context_line":"            SEGMENTS,"},{"line_number":95,"context_line":"            SEGMENT,"},{"line_number":96,"context_line":"            plugin.Plugin.get_instance(),"},{"line_number":97,"context_line":"            resource_attributes)"},{"line_number":98,"context_line":"        return [extensions.ResourceExtension(SEGMENTS,"},{"line_number":99,"context_line":"                                             controller,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_4449c18d","line":96,"range":{"start_line":96,"start_character":12,"end_line":96,"end_character":18},"updated":"2016-05-04 18:39:01.000000000","message":"Here, the extension loads the implementation.  How can an extension be implemented by a different implementation?  Seems like we\u0027d have to make this pluggable with stevedore or something.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5a549f59487653ce4dcf9f3845072f79fb3a951","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @abc.abstractmethod"},{"line_number":127,"context_line":"    def update_segment(self, context, id, segment):"},{"line_number":128,"context_line":"        \"\"\"Update values of a segment."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_64587858","line":127,"updated":"2016-05-03 16:09:52.000000000","message":"I wonder if we ever want to seriously consider stopping the nonsense of shadowing id(). Just a thought.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"def90a77fb9378c2abeeed147e50a14a03f48352","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        \"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @abc.abstractmethod"},{"line_number":127,"context_line":"    def update_segment(self, context, id, segment):"},{"line_number":128,"context_line":"        \"\"\"Update values of a segment."},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        :param context: neutron api request context"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_2a46477b","line":127,"in_reply_to":"1a122d0e_64587858","updated":"2016-05-03 16:44:18.000000000","message":"Yes.  You gave this feedback before in another part of the patch and I didn\u0027t apply it here.  There are places in the code where it would be difficult to do but this is a new interface so we could totally do it.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5a549f59487653ce4dcf9f3845072f79fb3a951","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                        value.  Each result returned by this function will have"},{"line_number":200,"context_line":"                        matched one of the values for each key in filters."},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_c4806c8e","line":202,"updated":"2016-05-03 16:09:52.000000000","message":"why is this different than the others? You expect this to be optional?","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"def90a77fb9378c2abeeed147e50a14a03f48352","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                        value.  Each result returned by this function will have"},{"line_number":200,"context_line":"                        matched one of the values for each key in filters."},{"line_number":201,"context_line":"        \"\"\""},{"line_number":202,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_ca2eb3a4","line":202,"in_reply_to":"1a122d0e_c4806c8e","updated":"2016-05-03 16:44:18.000000000","message":"I saw the pattern in a few other places and didn\u0027t think much about it.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"08ab6662bc7f4b30bc77d243233789b84bfabd03","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        controller \u003d base.create_resource("},{"line_number":94,"context_line":"            SEGMENTS,"},{"line_number":95,"context_line":"            SEGMENT,"},{"line_number":96,"context_line":"            plugin.Plugin.get_instance(),"},{"line_number":97,"context_line":"            resource_attributes)"},{"line_number":98,"context_line":"        return [extensions.ResourceExtension(SEGMENTS,"},{"line_number":99,"context_line":"                                             controller,"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_29d3b939","line":96,"updated":"2016-05-04 19:58:15.000000000","message":"instead of importing this plugin, we should use the NeutronManager.  NeutronManager.get_instance().get_service_plugins() will give us the already loaded service_plugins in a dictionary keyed off the plugin_type (which I commented on in the plugin.py file.\n\nThis way you don\u0027t have to import the neutron/services/segment/plugin.py module and the circular reference goes away.","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"}],"neutron/plugins/common/constants.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"39c371f5feed2c75fa4d37e32785902c2569c237","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Maps default service plugins entry points to their extension aliases"},{"line_number":42,"context_line":"DEFAULT_SERVICE_PLUGINS \u003d {"},{"line_number":43,"context_line":"    \u0027auto_allocate\u0027: \u0027auto-allocated-topology\u0027,"},{"line_number":44,"context_line":"    \u0027segments\u0027: \u0027segment\u0027,"},{"line_number":45,"context_line":"    \u0027tag\u0027: \u0027tag\u0027,"},{"line_number":46,"context_line":"    \u0027timestamp_core\u0027: \u0027timestamp_core\u0027,"},{"line_number":47,"context_line":"    \u0027network_ip_availability\u0027: \u0027network-ip-availability\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a122d0e_7f3d08dc","line":44,"updated":"2016-04-20 19:15:22.000000000","message":"I want to give this more time, because I am not 100% of the implications of this change for all the plugins that are out there. So please consider removing it as this won\u0027t impair your ability to do testing right now.\n\nOn another note, now that the extension alias and the entry point as so similar you might as well make them be the same.","commit_id":"238870ff8b6a9e96c97d8794a459c537cdbcdbdc"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"30c163bff5cffb305b07730a2e6c8749738b0061","unresolved":false,"context_lines":[{"line_number":41,"context_line":"# Maps default service plugins entry points to their extension aliases"},{"line_number":42,"context_line":"DEFAULT_SERVICE_PLUGINS \u003d {"},{"line_number":43,"context_line":"    \u0027auto_allocate\u0027: \u0027auto-allocated-topology\u0027,"},{"line_number":44,"context_line":"    \u0027segments\u0027: \u0027segment\u0027,"},{"line_number":45,"context_line":"    \u0027tag\u0027: \u0027tag\u0027,"},{"line_number":46,"context_line":"    \u0027timestamp_core\u0027: \u0027timestamp_core\u0027,"},{"line_number":47,"context_line":"    \u0027network_ip_availability\u0027: \u0027network-ip-availability\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a122d0e_1ae7c240","line":44,"in_reply_to":"1a122d0e_7f3d08dc","updated":"2016-04-20 20:46:17.000000000","message":"Done","commit_id":"238870ff8b6a9e96c97d8794a459c537cdbcdbdc"}],"neutron/services/segments/db.py":[{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"ae394bc229393e4642e906547a99a3a0948e00b1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":36,"context_line":"               db.PHYSICAL_NETWORK: segment_db[db.PHYSICAL_NETWORK],"},{"line_number":37,"context_line":"               db.NETWORK_TYPE: segment_db[db.NETWORK_TYPE],"},{"line_number":38,"context_line":"               db.SEGMENTATION_ID: segment_db[db.SEGMENTATION_ID]}"},{"line_number":39,"context_line":"        return self._fields(res, fields)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_segment(self, context, segment_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_820d5140","line":38,"updated":"2016-04-27 20:09:40.000000000","message":"We need to add port-id to which this segment is bound to.","commit_id":"211f4fad39712b17b17e23d41ee1b0451da52f2b"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"256f93f225b670e1789baae9776ab78ab8a68ee4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":36,"context_line":"               db.PHYSICAL_NETWORK: segment_db[db.PHYSICAL_NETWORK],"},{"line_number":37,"context_line":"               db.NETWORK_TYPE: segment_db[db.NETWORK_TYPE],"},{"line_number":38,"context_line":"               db.SEGMENTATION_ID: segment_db[db.SEGMENTATION_ID]}"},{"line_number":39,"context_line":"        return self._fields(res, fields)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_segment(self, context, segment_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_50c91b25","line":38,"in_reply_to":"1a122d0e_1c76a205","updated":"2016-04-28 21:37:54.000000000","message":"What is actually needed is a possibility to query which segments are used for a port binding.","commit_id":"211f4fad39712b17b17e23d41ee1b0451da52f2b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"db3d0e8e037b551e96e1fa77cf0450145fdf589b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":36,"context_line":"               db.PHYSICAL_NETWORK: segment_db[db.PHYSICAL_NETWORK],"},{"line_number":37,"context_line":"               db.NETWORK_TYPE: segment_db[db.NETWORK_TYPE],"},{"line_number":38,"context_line":"               db.SEGMENTATION_ID: segment_db[db.SEGMENTATION_ID]}"},{"line_number":39,"context_line":"        return self._fields(res, fields)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_segment(self, context, segment_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_00d710ee","line":38,"in_reply_to":"1a122d0e_50c91b25","updated":"2016-05-02 18:09:25.000000000","message":"I think that your use case needs to be solved with a mechanism driver the ML2 way as we began to discuss at the summit.  Let\u0027s not look to expose all of the ML2 internals through the API.","commit_id":"211f4fad39712b17b17e23d41ee1b0451da52f2b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"4f4bc59c9229447cbbdc482015bf2934179b502d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               \u0027network_id\u0027: segment_db[\u0027network_id\u0027],"},{"line_number":36,"context_line":"               db.PHYSICAL_NETWORK: segment_db[db.PHYSICAL_NETWORK],"},{"line_number":37,"context_line":"               db.NETWORK_TYPE: segment_db[db.NETWORK_TYPE],"},{"line_number":38,"context_line":"               db.SEGMENTATION_ID: segment_db[db.SEGMENTATION_ID]}"},{"line_number":39,"context_line":"        return self._fields(res, fields)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_segment(self, context, segment_id):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1c76a205","line":38,"in_reply_to":"1a122d0e_820d5140","updated":"2016-04-28 19:25:33.000000000","message":"why would a segment be bound to one port?","commit_id":"211f4fad39712b17b17e23d41ee1b0451da52f2b"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"ae394bc229393e4642e906547a99a3a0948e00b1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def get_segments(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":89,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":90,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":91,"context_line":"        marker_obj \u003d self._get_marker_obj(context, \u0027segment\u0027, limit, marker)"},{"line_number":92,"context_line":"        make_segment_dict \u003d functools.partial(self._make_segment_dict)"},{"line_number":93,"context_line":"        return self._get_collection(context,"},{"line_number":94,"context_line":"                                    db.NetworkSegment,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_c53113ef","line":91,"updated":"2016-04-27 20:09:40.000000000","message":"We would like to a filter to get the segments(s) which are bound to a port-id. Please see above comment - i.e. add the port-id to the record so, that it can be filtered to get a list of segments which are bound to the port-id.","commit_id":"211f4fad39712b17b17e23d41ee1b0451da52f2b"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"9dcb1ba19930ed8fd70f1908ef86d032e6bab98b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        segment_id \u003d segment.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":53,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":54,"context_line":"            network_id \u003d segment[\u0027network_id\u0027]"},{"line_number":55,"context_line":"            # FIXME couldn\u0027t use constants because of a circular import problem"},{"line_number":56,"context_line":"            physical_network \u003d segment[\u0027physical_network\u0027]"},{"line_number":57,"context_line":"            if physical_network \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":58,"context_line":"                physical_network \u003d None"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_dede790f","line":55,"updated":"2016-05-03 15:17:07.000000000","message":"i suppose a constants file under the neutron/services/segments would be the best option.  Not a big deal at this point though.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"161626a3e732c79956216aa6ef453ba631d0506e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        segment_id \u003d segment.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":53,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":54,"context_line":"            network_id \u003d segment[\u0027network_id\u0027]"},{"line_number":55,"context_line":"            # FIXME couldn\u0027t use constants because of a circular import problem"},{"line_number":56,"context_line":"            physical_network \u003d segment[\u0027physical_network\u0027]"},{"line_number":57,"context_line":"            if physical_network \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":58,"context_line":"                physical_network \u003d None"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_e900a604","line":55,"in_reply_to":"1a122d0e_95c33c8a","updated":"2016-05-04 18:27:34.000000000","message":"What I\u0027ve got is the following:\n\n1.  neutron/extensions/segment.py imports neutron/services/segments/plugin.py\n2.  which imports neutron/services/segments/db.py\n3.  which imports neutron/extensions/segment.py\n\nThe one that I don\u0027t like is #1.  Why should the extension definition point to the service plugin?  Interfaces shouldn\u0027t import implementations, should they?","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"def90a77fb9378c2abeeed147e50a14a03f48352","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        segment_id \u003d segment.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":53,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":54,"context_line":"            network_id \u003d segment[\u0027network_id\u0027]"},{"line_number":55,"context_line":"            # FIXME couldn\u0027t use constants because of a circular import problem"},{"line_number":56,"context_line":"            physical_network \u003d segment[\u0027physical_network\u0027]"},{"line_number":57,"context_line":"            if physical_network \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":58,"context_line":"                physical_network \u003d None"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_95c33c8a","line":55,"in_reply_to":"1a122d0e_dede790f","updated":"2016-05-03 16:44:18.000000000","message":"I\u0027ll see if I can revisit this later today.  I honestly forgot that I left this in here.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"08ab6662bc7f4b30bc77d243233789b84bfabd03","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        segment_id \u003d segment.get(\u0027id\u0027) or uuidutils.generate_uuid()"},{"line_number":53,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":54,"context_line":"            network_id \u003d segment[\u0027network_id\u0027]"},{"line_number":55,"context_line":"            # FIXME couldn\u0027t use constants because of a circular import problem"},{"line_number":56,"context_line":"            physical_network \u003d segment[\u0027physical_network\u0027]"},{"line_number":57,"context_line":"            if physical_network \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":58,"context_line":"                physical_network \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_235e3ae9","line":55,"updated":"2016-05-04 19:58:15.000000000","message":"moving this discussion to https://review.openstack.org/#/c/312688/2/neutron/extensions/segment.py","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"}],"neutron/services/segments/exceptions.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c68352b02d05d9ac0e93c252422b3bc3f3d5c730","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_0cf45d85","line":19,"updated":"2016-05-03 06:10:45.000000000","message":"Let\u0027s import from neutron_lib\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/exceptions.py","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"101e56c7e1474d5fe75ddb390ece797515d35697","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_bca3caff","line":19,"in_reply_to":"1a122d0e_0cf45d85","updated":"2016-05-03 14:05:12.000000000","message":"If I need to respin I\u0027ll change it.  Otherwise, as long as this exception is in tree, I\u0027ll use it and let it be changed when that code is removed.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"161626a3e732c79956216aa6ef453ba631d0506e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_84c919af","line":19,"in_reply_to":"1a122d0e_7eae45e8","updated":"2016-05-04 18:27:34.000000000","message":"Done","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"860c55ab7b31b492e37398603fece64e2c4cbf80","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_7eae45e8","line":19,"in_reply_to":"1a122d0e_bca3caff","updated":"2016-05-03 15:03:15.000000000","message":"No worries Carl! Since I have noticed, notified the same ;)","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"}],"neutron/services/segments/plugin.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"08ab6662bc7f4b30bc77d243233789b84bfabd03","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services.segments import db"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Plugin(db.SegmentDbMixin):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _instance \u003d None"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_6678407f","line":21,"updated":"2016-05-04 19:58:15.000000000","message":"So after testing out a fix for the circular import thing.  I realized that this plugin does not actually inherit from the SegmentPluginBase defined in the extension (SegmentDbMixin inherits from CommonDbMixin, which is just a plain class).  I think this should be fixed in this review.  I\u0027m not sure how you would do this without using multiple inheritance though.  Composition always made sense to me for the db anyway in this case (plugin.db is an instance of SegmentDbMixin).  This would obviously be inconsistent with all other plugins.  I do think composition is the right solution though, but for consistency wouldn\u0027t mind the multiple inheritance.","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"92751e7a37ddb96714afa504c0db6c74a44c2b54","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services.segments import db"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Plugin(db.SegmentDbMixin):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _instance \u003d None"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_8c3776fd","line":21,"in_reply_to":"1a122d0e_6678407f","updated":"2016-05-04 22:56:09.000000000","message":"To be honest, that interface serves no concrete purpose except to document methods which are pretty boilerplate anyway.  If I removed it, it would be completely consistent with the way the auto allocated topology is architected which was the pattern I was working from.  Would you be okay with that?","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f9b19c84e45eca8eefacf790a925159034a5e522","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services.segments import db"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Plugin(db.SegmentDbMixin):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _instance \u003d None"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_ef2d3c90","line":21,"in_reply_to":"1a122d0e_8c3776fd","updated":"2016-05-04 23:01:31.000000000","message":"Actually, would be be okay if we just left it like it is in this patch?  Part of me likes having the SegmentPluginBase just to document the interface.  The reason I don\u0027t inherit from it is the circular import problem.  So, would you be okay if we merged this like it is and then solve these issues here [1]?\n\n [1] https://review.openstack.org/#/c/312688","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"0f7caff8feb41fffe9a540fa53b46abca9660253","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services.segments import db"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Plugin(db.SegmentDbMixin):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _instance \u003d None"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_efeb7ca2","line":21,"in_reply_to":"1a122d0e_ef2d3c90","updated":"2016-05-04 23:23:50.000000000","message":"I disagree that the interface serves no concrete purpose because the NeutronManager was built with the expectation that all plugins implemented certain methods, and there being a base abstract class for all implementations of a service plugin can be useful.\n\nHowever, the options to fix this are multiple inheritance and composition and I don\u0027t think this is the right place to have that debate.  So I\u0027m fine with offloading this discussion to another forum.","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"024d387a3d578b64e1014ab2222cd88c09e74127","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.services.segments import db"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Plugin(db.SegmentDbMixin):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    _instance \u003d None"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_5a1968d0","line":21,"in_reply_to":"1a122d0e_efeb7ca2","updated":"2016-05-05 16:27:30.000000000","message":"I vote we leave it in and use it properly as soon as we get the circular import thing resolved.\n\nAnd by \"serves no concrete purpose\" I meant that it can be deleted without breaking any code.  Can\u0027t argue with that.  :)","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"08ab6662bc7f4b30bc77d243233789b84bfabd03","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    supported_extension_aliases \u003d [\"segment\"]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @classmethod"},{"line_number":28,"context_line":"    def get_instance(cls):"},{"line_number":29,"context_line":"        if cls._instance is None:"},{"line_number":30,"context_line":"            cls._instance \u003d cls()"},{"line_number":31,"context_line":"        return cls._instance"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_plugin_description(self):"},{"line_number":34,"context_line":"        return \"Network Segments\""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_03ee9e21","line":31,"range":{"start_line":27,"start_character":0,"end_line":31,"end_character":28},"updated":"2016-05-04 19:58:15.000000000","message":"I bet this entire block could be moved to the abstract base class defined in the extension because this seems like something that would be commonly done in any implementation of that abstract class.\n\nLeaving this comment in but this would not work without this inheriting from the interface/abstract class","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"08ab6662bc7f4b30bc77d243233789b84bfabd03","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return \"Network Segments\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def get_plugin_type(self):"},{"line_number":37,"context_line":"        return \"segments\""}],"source_content_type":"text/x-python","patch_set":18,"id":"1a122d0e_262be8ec","line":37,"updated":"2016-05-04 19:58:15.000000000","message":"This should be pulled into the abstract class in the extension because the NeutronManager only allows one instance of a plugin_type and it expects the plugin_type per interface to be unique.","commit_id":"3735fda023e52748fab761bcb742b1069b01d949"}],"neutron/tests/unit/extensions/test_segment.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0f1093fc3924038f312f03afd41d2300344cb2ff","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return segment"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class SegmentTestPlugin(segment_db.SegmentDbMixin,"},{"line_number":85,"context_line":"                        db_base_plugin_v2.NeutronDbPluginV2):"},{"line_number":86,"context_line":"    __native_pagination_support \u003d True"},{"line_number":87,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_41569d5c","line":84,"range":{"start_line":84,"start_character":24,"end_line":84,"end_character":49},"updated":"2016-03-23 17:53:30.000000000","message":"I\u0027m not sure that I\u0027m doing this right since this has to come before NeutronDbPluginV2.  It won\u0027t work in general.","commit_id":"099e1cebe5ce67e666cbaf062fc1f0ba6f84cc3c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e44c0d81a8effb9a32eceb4225e4eb835652f4fb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return segment"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class SegmentTestPlugin(segment_db.SegmentDbMixin,"},{"line_number":85,"context_line":"                        db_base_plugin_v2.NeutronDbPluginV2):"},{"line_number":86,"context_line":"    __native_pagination_support \u003d True"},{"line_number":87,"context_line":"    __native_sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa0719c6_32977949","line":84,"range":{"start_line":84,"start_character":24,"end_line":84,"end_character":49},"updated":"2016-03-23 18:33:12.000000000","message":"I fixed the problem but forgot to reverse the order here.","commit_id":"1a32a632aa11d5ae71f5d174bc2ce72f3775ca0a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e8e51b006fe79db2fb07ae5b5e9b4f754344efaf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @contextlib.contextmanager"},{"line_number":72,"context_line":"    def segment(self, **kwargs):"},{"line_number":73,"context_line":"        yield self._make_segment(self.fmt, tenant_id\u003dself._tenant_id, **kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _test_create_segment(self, expected\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_468d5c7a","line":72,"updated":"2016-03-28 09:35:45.000000000","message":"I think we should stop continuing the context manager pattern here. The usefulness of it is long dead since we don\u0027t use them to clean anything up.","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"31b167cddc4f6e6f4c0e08e443703991f4358b4e","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @contextlib.contextmanager"},{"line_number":72,"context_line":"    def segment(self, **kwargs):"},{"line_number":73,"context_line":"        yield self._make_segment(self.fmt, tenant_id\u003dself._tenant_id, **kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _test_create_segment(self, expected\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_1060b100","line":72,"in_reply_to":"da0c15f0_468d5c7a","updated":"2016-03-28 16:44:35.000000000","message":"I had exactly the same thought when I copied this!  But, I opted for consistency.  I can go either way and I\u0027m happy to get rid of the context manager.","commit_id":"3c94f0a6e335610f3d30a81cf5aac8b89521dbc5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"155e8c9f734e52ae05072c21b8841a3e563d3f5d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class SegmentTestPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":83,"context_line":"                        segments_db.SegmentDbMixin):"},{"line_number":84,"context_line":"    __native_pagination_support \u003d True"},{"line_number":85,"context_line":"    __native_sorting_support \u003d True"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_2896694c","line":83,"updated":"2016-04-05 00:17:22.000000000","message":"how do you intend to use this mixin in the real code?","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"032435ba9350e912970160d18f8844ac4d65c5e4","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class SegmentTestPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":83,"context_line":"                        segments_db.SegmentDbMixin):"},{"line_number":84,"context_line":"    __native_pagination_support \u003d True"},{"line_number":85,"context_line":"    __native_sorting_support \u003d True"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_53f525c9","line":83,"in_reply_to":"9a061dce_2896694c","updated":"2016-04-05 16:31:18.000000000","message":"I start that in a follow-on patch here [1].  More follow-ons will come later to enable create / delete in ML2.  I could go either way but since this patch provides the framework for both ML2 and OVN to work from, I separated out the ML2 part from this patch set to make it clear what could be common and what is ML2 specific.  I also am trying to limit the scope of each patch to make little bite-size reviews for reviewers.\n\n [1] https://review.openstack.org/#/c/296658/5/neutron/plugins/ml2/plugin.py@129","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"223c97d8fc2b8f091d5ad0707eae4665919ea4b7","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class SegmentTestPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":83,"context_line":"                        segments_db.SegmentDbMixin):"},{"line_number":84,"context_line":"    __native_pagination_support \u003d True"},{"line_number":85,"context_line":"    __native_sorting_support \u003d True"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_afefed85","line":83,"in_reply_to":"9a061dce_4908d62d","updated":"2016-04-05 18:44:58.000000000","message":"Would you like me to do something different?  If so, you haven\u0027t asked for it yet.","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"47ad9000766ecede8021ba71705e8b6e87a62a5c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class SegmentTestPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":83,"context_line":"                        segments_db.SegmentDbMixin):"},{"line_number":84,"context_line":"    __native_pagination_support \u003d True"},{"line_number":85,"context_line":"    __native_sorting_support \u003d True"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_4908d62d","line":83,"in_reply_to":"9a061dce_53f525c9","updated":"2016-04-05 16:36:40.000000000","message":"I feared that was the answer I was going to get. I give up.","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a41aef894cb4066c5ef9b2e520e553ed3c1c52b8","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class SegmentTestPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":83,"context_line":"                        segments_db.SegmentDbMixin):"},{"line_number":84,"context_line":"    __native_pagination_support \u003d True"},{"line_number":85,"context_line":"    __native_sorting_support \u003d True"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_b3458f18","line":83,"in_reply_to":"9a061dce_9d869a11","updated":"2016-04-05 21:56:42.000000000","message":"I guess we need to find some better core reviewers.  I\u0027m obviously not fit.  Maybe my time has come.","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1e72a98cec3a14edd23155d822dc5a6beaba8bae","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class SegmentTestPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":83,"context_line":"                        segments_db.SegmentDbMixin):"},{"line_number":84,"context_line":"    __native_pagination_support \u003d True"},{"line_number":85,"context_line":"    __native_sorting_support \u003d True"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_9d869a11","line":83,"in_reply_to":"9a061dce_afefed85","updated":"2016-04-05 21:12:38.000000000","message":"I expressed my position on the (ab)use of mixins many times  in the past, I have influenced design decisions of other people\u0027s features to minimize reliance on them, I have myself led development efforts that showed how not to use them, and I have put that in writing in the effective guide [1].\n\nMy bad, I thought that was implicit by now :)\n\n[1] http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#plugin-development","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"34d14f4f80275a77938ff66b6222191bd1389d1f","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class SegmentTestPlugin(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":83,"context_line":"                        segments_db.SegmentDbMixin):"},{"line_number":84,"context_line":"    __native_pagination_support \u003d True"},{"line_number":85,"context_line":"    __native_sorting_support \u003d True"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_13227b52","line":83,"in_reply_to":"9a061dce_b3458f18","updated":"2016-04-05 21:58:30.000000000","message":"you\u0027re not serious now, are you?","commit_id":"1503ba2a5812098570690eca99e1a91ff3407bf9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5a549f59487653ce4dcf9f3845072f79fb3a951","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    supported_extension_aliases \u003d [\"segment\"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class TestSegment(SegmentTestCase):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_create_segment(self):"},{"line_number":97,"context_line":"        with self.network() as network:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_2f281933","line":94,"updated":"2016-05-03 16:09:52.000000000","message":"do we need TestSegment inherit from SegmentTestCase? I am not quite sure I see the value in this. Can you elaborate?","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"def90a77fb9378c2abeeed147e50a14a03f48352","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    supported_extension_aliases \u003d [\"segment\"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class TestSegment(SegmentTestCase):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_create_segment(self):"},{"line_number":97,"context_line":"        with self.network() as network:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_75902097","line":94,"in_reply_to":"1a122d0e_2f281933","updated":"2016-05-03 16:44:18.000000000","message":"Are you thinking that instead of inheritance, I could use composition?  If so, that might be worth exploring.  Honestly, I saw the pattern somewhere else and copied it.  My mind was mostly on other aspects of this code and I didn\u0027t give this much thought.  Let me finish up some other things today and I\u0027ll see if I want to revisit this.\n\nAre you  thinking that the two could be combined in to one class?  If so, I just wanted SegmentTestCase to carry some of the boilerplate stuff (which will also be used by another class in the following patch set) and then this second class just has test cases.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"42a811ffa6edcf5aa34acfc7692a62a4a058e939","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    supported_extension_aliases \u003d [\"segment\"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class TestSegment(SegmentTestCase):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_create_segment(self):"},{"line_number":97,"context_line":"        with self.network() as network:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_ad19c789","line":94,"in_reply_to":"1a122d0e_75902097","updated":"2016-05-03 21:52:47.000000000","message":"what would be the reason to have two separate test cases? My suggestion would be to minimize the boilerplate test code.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"92b1c56f3a2a307eab1047ed155bbbbdc6aeee08","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    supported_extension_aliases \u003d [\"segment\"]"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class TestSegment(SegmentTestCase):"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def test_create_segment(self):"},{"line_number":97,"context_line":"        with self.network() as network:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1a122d0e_bfe6dc13","line":94,"in_reply_to":"1a122d0e_ad19c789","updated":"2016-05-04 18:50:44.000000000","message":"I hope its okay if I leave it as it is for now.  It isn\u0027t clear to me how to significantly reduce the boiler plate code and I personally like grouping test cases in a couple of different classes.","commit_id":"c7dd34195caa9264f853ee46783bda2f69bd447e"}]}
