)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6499dcff95acb496c67bca35b07367235bcd61b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updating dhcp allocation pool when subnet gateway ip is updated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when ever the subnet gateway ip is updated the dhcp allocation"},{"line_number":10,"context_line":"pool should also updated"},{"line_number":11,"context_line":"Closes-Bug : #1553968"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da0c15f0_a5173750","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":9},"updated":"2016-03-25 20:54:19.000000000","message":"\"Whenever\"","commit_id":"2418b381e128e94aa723ff859533bbea5eb235bb"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6499dcff95acb496c67bca35b07367235bcd61b1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Updating dhcp allocation pool when subnet gateway ip is updated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when ever the subnet gateway ip is updated the dhcp allocation"},{"line_number":10,"context_line":"pool should also updated"},{"line_number":11,"context_line":"Closes-Bug : #1553968"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaff1265f6f85e671632331fce0c7bae82afedd9d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da0c15f0_050d433e","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":24},"updated":"2016-03-25 20:54:19.000000000","message":"\"should also be updated\"","commit_id":"2418b381e128e94aa723ff859533bbea5eb235bb"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6499dcff95acb496c67bca35b07367235bcd61b1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when ever the subnet gateway ip is updated the dhcp allocation"},{"line_number":10,"context_line":"pool should also updated"},{"line_number":11,"context_line":"Closes-Bug : #1553968"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iaff1265f6f85e671632331fce0c7bae82afedd9d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da0c15f0_c5122b62","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":21},"updated":"2016-03-25 20:54:19.000000000","message":"You should get rid of extra whitespace after \"Closes-Bug\"\nCloses-Bug: #1553968","commit_id":"2418b381e128e94aa723ff859533bbea5eb235bb"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6499dcff95acb496c67bca35b07367235bcd61b1","unresolved":false,"context_lines":[{"line_number":704,"context_line":"                 \u0027end\u0027: str(netaddr.IPAddress(p.last, subnet[\u0027ip_version\u0027]))}"},{"line_number":705,"context_line":"                for p in allocation_pools]"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"    def _new_update_allocation_pools(self, s):"},{"line_number":708,"context_line":"        pools \u003d self.ipam.generate_pools(s[\u0027cidr\u0027],"},{"line_number":709,"context_line":"                                         s[\u0027gateway_ip\u0027])"},{"line_number":710,"context_line":"        return pools"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_2032f5f1","line":707,"range":{"start_line":707,"start_character":8,"end_line":707,"end_character":36},"updated":"2016-03-25 20:54:19.000000000","message":"Couple lines above you have exactly the same code. If you need to reuse it, please refactor it.","commit_id":"2418b381e128e94aa723ff859533bbea5eb235bb"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6499dcff95acb496c67bca35b07367235bcd61b1","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        gateway_ip \u003d s.get(\u0027gateway_ip\u0027, db_subnet.gateway_ip)"},{"line_number":753,"context_line":"        gateway_ip_changed \u003d gateway_ip !\u003d db_subnet.gateway_ip"},{"line_number":754,"context_line":"        if gateway_ip_changed or s.get(\u0027allocation_pools\u0027) is not None:"},{"line_number":755,"context_line":"            pools \u003d range_pools if range_pools is not None else db_pools"},{"line_number":756,"context_line":"            if (db_subnet.gateway_ip is None and"},{"line_number":757,"context_line":"                gateway_ip !\u003d db_subnet.gateway_ip):"},{"line_number":758,"context_line":"                pools \u003d self._new_update_allocation_pools(s)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_60798d93","line":755,"updated":"2016-03-25 20:54:19.000000000","message":"You\u0027re basically removing these values: range_pools or db_pools and recreating pools in L758. Are you sure it should be done like this?","commit_id":"2418b381e128e94aa723ff859533bbea5eb235bb"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6499dcff95acb496c67bca35b07367235bcd61b1","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        if gateway_ip_changed or s.get(\u0027allocation_pools\u0027) is not None:"},{"line_number":755,"context_line":"            pools \u003d range_pools if range_pools is not None else db_pools"},{"line_number":756,"context_line":"            if (db_subnet.gateway_ip is None and"},{"line_number":757,"context_line":"                gateway_ip !\u003d db_subnet.gateway_ip):"},{"line_number":758,"context_line":"                pools \u003d self._new_update_allocation_pools(s)"},{"line_number":759,"context_line":"                s[\u0027allocation_pools\u0027] \u003d pools"},{"line_number":760,"context_line":"            if gateway_ip:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_00141142","line":757,"range":{"start_line":757,"start_character":16,"end_line":757,"end_character":50},"updated":"2016-03-25 20:54:19.000000000","message":"Why are you checking this? It\u0027s already checked in L754","commit_id":"2418b381e128e94aa723ff859533bbea5eb235bb"}]}